Re: svn commit: r933881 - /tomcat/trunk/java/org/apache/catalina/session/StandardManager.java
2010/4/14 Mladen Turk : > On 04/14/2010 10:48 AM, kfuj...@apache.org wrote: >> >> Author: kfujino >> >> Modified: >> tomcat/trunk/java/org/apache/catalina/session/StandardManager.java >> >> + session.expire(); >> + } >> sessionCounter++; > > Seems we are using the sessionCounter as well as expiredSessions > just for the information purposes. > Think they should be declared as long instead of int cause > those values never gets reset and can only grow, eventually > reaching the MAX_INT and going to negative values. > > Given that Tomcat can survive long enough to > generate +2 billion sessions at the first place :) > OK. I will declare only sessionCounter and expiredSessions as long instead of int. -- Keiichi.Fujino - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 15/04/2010 01:31, sebb wrote: On 14/04/2010, Mark Thomas wrote: On 14/04/2010 21:06, sebb wrote: ... > There is a minor problem with the bin/tomcat-juli.jar - the NOTICE says: > Copyright 19...@year@ I'll take a look. Same problem in extras/tomcat-juli-adapters.jar This is exactly the kind of drip-feeding of problems that I want to avoid with Tomcat 7. To clarify what I wrote in the vote announcement: Please run all of your tests against this candidate and report all failures *in a single e-mail*. I'd like to avoid the test, stop at first failure, new RC, test, stop at first failure, new RC etc. cycle. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 15/04/2010 01:44, Ivan wrote: Hi, Just wonder does Tomcat 7 RC fully support Servlet 3.0 ? The last time I check it, it seems that ServletContainerInitializer has not been implemented yet. Thanks ! Yep. That looks like a (fairly large) oversight. I'll go back through the spec and see what else got missed. Mark 2010/4/15 sebb On 14/04/2010, Mark Thomas wrote: On 14/04/2010 21:06, sebb wrote: ... > There is a minor problem with the bin/tomcat-juli.jar - the NOTICE says: > Copyright 19...@year@ I'll take a look. Same problem in extras/tomcat-juli-adapters.jar - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 15/04/2010, Ivan wrote: > Usually, I trust the real codes more :-) > Just grep the Tomcat trunk codes with 'ServletContainerInitializer', I only > found an empty if block in AnnotationProcessor.java file. In that case maybe you have found a discrepancy between the release notes and the code ;-) > 2010/4/15 sebb > > > The RELEASE-NOTES file says: > > > > > > = > > Bundled APIs: > > = > > A standard installation of Tomcat 7.0 makes all of the following APIs > > available > > for use by web applications (by placing them in "lib"): > > > > * servlet-api.jar (Servlet 3.0 API) > > > > > > On 15/04/2010, Ivan wrote: > > > Hi, > > >Just wonder does Tomcat 7 RC fully support Servlet 3.0 ? The last > > time I > > > check it, it seems that ServletContainerInitializer has not been > > implemented > > > yet. > > >Thanks ! > > > > > > 2010/4/15 sebb > > > > > > > > > > On 14/04/2010, Mark Thomas wrote: > > > > > On 14/04/2010 21:06, sebb wrote: > > > > > > > > ... > > > > > > > > > > There is a minor problem with the bin/tomcat-juli.jar - the > > NOTICE > > > > says: > > > > > > Copyright 19...@year@ > > > > > > > > > > I'll take a look. > > > > > > > > > > > > > Same problem in extras/tomcat-juli-adapters.jar > > > > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > > > > > > > > > > > > > > -- > > > > > > Ivan > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > -- > Ivan > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
Usually, I trust the real codes more :-) Just grep the Tomcat trunk codes with 'ServletContainerInitializer', I only found an empty if block in AnnotationProcessor.java file. 2010/4/15 sebb > The RELEASE-NOTES file says: > > > = > Bundled APIs: > = > A standard installation of Tomcat 7.0 makes all of the following APIs > available > for use by web applications (by placing them in "lib"): > > * servlet-api.jar (Servlet 3.0 API) > > > On 15/04/2010, Ivan wrote: > > Hi, > >Just wonder does Tomcat 7 RC fully support Servlet 3.0 ? The last > time I > > check it, it seems that ServletContainerInitializer has not been > implemented > > yet. > >Thanks ! > > > > 2010/4/15 sebb > > > > > > > On 14/04/2010, Mark Thomas wrote: > > > > On 14/04/2010 21:06, sebb wrote: > > > > > > ... > > > > > > > > There is a minor problem with the bin/tomcat-juli.jar - the > NOTICE > > > says: > > > > > Copyright 19...@year@ > > > > > > > > I'll take a look. > > > > > > > > > > Same problem in extras/tomcat-juli-adapters.jar > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > > > > > > > > -- > > > > Ivan > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > -- Ivan
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
The RELEASE-NOTES file says: = Bundled APIs: = A standard installation of Tomcat 7.0 makes all of the following APIs available for use by web applications (by placing them in "lib"): * servlet-api.jar (Servlet 3.0 API) On 15/04/2010, Ivan wrote: > Hi, >Just wonder does Tomcat 7 RC fully support Servlet 3.0 ? The last time I > check it, it seems that ServletContainerInitializer has not been implemented > yet. >Thanks ! > > 2010/4/15 sebb > > > > On 14/04/2010, Mark Thomas wrote: > > > On 14/04/2010 21:06, sebb wrote: > > > > ... > > > > > > There is a minor problem with the bin/tomcat-juli.jar - the NOTICE > > says: > > > > Copyright 19...@year@ > > > > > > I'll take a look. > > > > > > > Same problem in extras/tomcat-juli-adapters.jar > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > > -- > > Ivan > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49130] New: NSIS - clarify that service is always installed
https://issues.apache.org/bugzilla/show_bug.cgi?id=49130 Summary: NSIS - clarify that service is always installed Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: enhancement Priority: P2 Component: Packaging AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Created an attachment (id=25300) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25300) Change installer wording as described I found the Service option text in the Windows installer a bit unclear: Service: Automatically start Tomcat when the computer is started. This could mean that the service won't be installed if the box is not selected. It might be clearer if the option were renamed "AutoStart", and the core description updated to state that the service is created. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
Hi, Just wonder does Tomcat 7 RC fully support Servlet 3.0 ? The last time I check it, it seems that ServletContainerInitializer has not been implemented yet. Thanks ! 2010/4/15 sebb > On 14/04/2010, Mark Thomas wrote: > > On 14/04/2010 21:06, sebb wrote: > > ... > > > > There is a minor problem with the bin/tomcat-juli.jar - the NOTICE > says: > > > Copyright 19...@year@ > > > > I'll take a look. > > > > Same problem in extras/tomcat-juli-adapters.jar > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > -- Ivan
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14/04/2010, Mark Thomas wrote: > On 14/04/2010 21:06, sebb wrote: ... > > There is a minor problem with the bin/tomcat-juli.jar - the NOTICE says: > > Copyright 19...@year@ > > I'll take a look. > Same problem in extras/tomcat-juli-adapters.jar - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49122] Update of ROOT application index.html
https://issues.apache.org/bugzilla/show_bug.cgi?id=49122 --- Comment #2 from Mark Thomas 2010-04-14 19:34:37 EDT --- I like the addition of the announce list but the larger test feels a little 'in your face'. Could you reduce the font size for the blod bits to be closer to the previous version? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 4/14/2010 5:32 PM, sebb wrote: > On 14/04/2010, William A. Rowe Jr. wrote: >> On 4/14/2010 4:22 PM, sebb wrote: >> > >> > Also, SVN is considered by some to be publishing code (e.g. links are >> > usually published on the web-site) so better safe than sorry. >> >> >> SVN is a development/work product area. Although now we have >> dist.apache.org/ >> which is, pretty clearly, a dist'ribution point :) The svn.apache.org/ >> space >> is definitely not a publication. > > Sorry, wrong word. It is a distribution however, at least according to Roy: > > http://mail-archives.apache.org/mod_mbox/www-legal-discuss/200907.mbox/%3c7a0220b7-5df1-4f4c-8c27-6ca8a175c...@gbiv.com%3e Ah yes, that old debate :) From perspective of license files, they need to be there. >From perspective of a Release (and Releases are Published), it isn't, until >the PMC decides it is :) In the meantime, it is a Distribution, even if only to developers. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49024] Enhance RemoteIpFilter docs
https://issues.apache.org/bugzilla/show_bug.cgi?id=49024 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-04-14 19:17:48 EDT --- Thanks for the patch. It has been applied to trunk and will be included in 7.0.0 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934239 - /tomcat/trunk/webapps/docs/config/filter.xml
Author: markt Date: Wed Apr 14 23:17:26 2010 New Revision: 934239 URL: http://svn.apache.org/viewvc?rev=934239&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49024 Enhance the RemoteIpFilter docs Patch provided by Cyrille Le Clerc Modified: tomcat/trunk/webapps/docs/config/filter.xml Modified: tomcat/trunk/webapps/docs/config/filter.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/filter.xml?rev=934239&r1=934238&r2=934239&view=diff == --- tomcat/trunk/webapps/docs/config/filter.xml (original) +++ tomcat/trunk/webapps/docs/config/filter.xml Wed Apr 14 23:17:26 2010 @@ -226,6 +226,296 @@ + + +The filter will process the x-forwarded-for http header. + + ++ + +RemoteIpFilter +org.apache.catalina.filters.RemoteIpFilter ++ + + + + + + +The filter will process x-forwarded-for and +x-forwarded-proto http headers. Expected value for the +x-forwarded-proto header in case of SSL connections is +https (case insensitive). + +RemoteIpFilter +/* +REQUEST ++ + +RemoteIpFilter +org.apache.catalina.filters.RemoteIpFilter ++ +protocolHeader +x-forwarded-proto ++ + + + + +RemoteIpFilter configuration: + +RemoteIpFilter +/* +REQUEST ++ + +Request values: + + +Property +Value Before RemoteIpFilter +Value After RemoteIpFilter + + + request.remoteAddr + 192.168.0.10 + 140.211.11.130 + + + request.header['x-forwarded-for'] + 140.211.11.130, 192.168.0.10 + null + + + request.header['x-forwarded-by'] + null + null + + + request.header['x-forwarded-proto'] + https + https + + + request.scheme + http + https + + + request.secure + false + true + + + request.serverPort + 80 + 443 + + + + +Note : x-forwarded-by header is null because only +internal proxies has been traversed by the request. +x-forwarded-for is null because all the proxies are +trusted or internal. + + + + + +RemoteIpFilter configuration: + +RemoteIpFilter +org.apache.catalina.filters.RemoteIpFilter ++ +allowedInternalProxies +192\.168\.0\.10, 192\.168\.0\.11 ++ +remoteIPHeader +x-forwarded-for ++ +remoteIPProxiesHeader +x-forwarded-by ++ +protocolHeader +x-forwarded-proto ++ + +Request values: + +Property +Value Before RemoteIpFilter +Value After RemoteIpFilter + + + request.remoteAddr + 192.168.0.10 + 140.211.11.130 + + + request.header['x-forwarded-for'] + 140.211.11.130, proxy1, proxy2 + null + + + request.header['x-forwardedRemoteIpFilter +org.apache.catalina.filters.RemoteIpFilter ++ +allowedInternalProxies +192\.168\.0\.10, 192\.168\.0\.11 ++ +remoteIPHeader +x-forwarded-for ++ +remoteIPProxiesHeader +x-forwarded-by ++ +trustedProxies +proxy1, proxy2 +
DO NOT REPLY [Bug 49129] DigestAuthenticator.md5Helper - possible incorrect lazy initialisation
https://issues.apache.org/bugzilla/show_bug.cgi?id=49129 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-04-14 19:13:50 EDT --- Fixed in 7.0.0. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934238 - /tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
Author: markt Date: Wed Apr 14 23:13:45 2010 New Revision: 934238 URL: http://svn.apache.org/viewvc?rev=934238&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49129 Modified: tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java Modified: tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java?rev=934238&r1=934237&r2=934238&view=diff == --- tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java (original) +++ tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java Wed Apr 14 23:13:45 2010 @@ -88,7 +88,7 @@ public class DigestAuthenticator /** * MD5 message digest provider. */ -protected static MessageDigest md5Helper; +protected volatile static MessageDigest md5Helper; /** - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49127] SimpleTcpReplicationManager.startInternal() ignores Exception
https://issues.apache.org/bugzilla/show_bug.cgi?id=49127 Mark Thomas changed: What|Removed |Added Priority|P2 |P5 Severity|normal |enhancement -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49129] New: DigestAuthenticator.md5Helper - possible incorrect lazy initialisation
https://issues.apache.org/bugzilla/show_bug.cgi?id=49129 Summary: DigestAuthenticator.md5Helper - possible incorrect lazy initialisation Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Findbugs says: "This method contains an unsynchronized lazy initialization of a non-volatile static field. Because the compiler or processor may reorder instructions, threads are not guaranteed to see a completely initialized object, if the method can be called by multiple threads. You can make the field volatile to correct the problem." -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49128] loader.WebappClassLoader.start() ignores Exception
https://issues.apache.org/bugzilla/show_bug.cgi?id=49128 Mark Thomas changed: What|Removed |Added Priority|P2 |P5 Severity|normal |enhancement -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49128] New: loader.WebappClassLoader.start() ignores Exception
https://issues.apache.org/bugzilla/show_bug.cgi?id=49128 Summary: loader.WebappClassLoader.start() ignores Exception Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org catalina.loader.WebappClassLoader.start() ignores Exception. However, it probably only needs to ignore SecurityException -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49126] jasper.compiler.Generator.createJspId() can generate negative number
https://issues.apache.org/bugzilla/show_bug.cgi?id=49126 Mark Thomas changed: What|Removed |Added Priority|P2 |P5 Severity|normal |enhancement --- Comment #1 from Mark Thomas 2010-04-14 19:06:11 EDT --- The Math.abs call is purely cosmetic. Leaning towards WONTFIX. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49127] New: SimpleTcpReplicationManager.startInternal() ignores Exception
https://issues.apache.org/bugzilla/show_bug.cgi?id=49127 Summary: SimpleTcpReplicationManager.startInternal() ignores Exception Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org ha.session.SimpleTcpReplicationManager.startInternal() ignores Exception when invoking Thread.sleep() - it only needs to ignore InterruptedException. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49125] toString on byte[] array probably is not correct
https://issues.apache.org/bugzilla/show_bug.cgi?id=49125 Mark Thomas changed: What|Removed |Added Priority|P2 |P5 Severity|normal |enhancement --- Comment #1 from Mark Thomas 2010-04-14 19:01:13 EDT --- The first issue only affects debug messages. The second issue doesn't match the code and is therefore invalid. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49126] New: jasper.compiler.Generator.createJspId() can generate negative number
https://issues.apache.org/bugzilla/show_bug.cgi?id=49126 Summary: jasper.compiler.Generator.createJspId() can generate negative number Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Jasper AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org jasper.compiler.Generator.createJspId() can create a jsp prefix containing a negative number, viz: jsp_-2147483648_ this is because Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE If this is acceptable, then it should be documented. [Findbugs adds: One out of 2^32 strings have a hashCode of Integer.MIN_VALUE, including "polygenelubricants" "GydZG_" and ""DESIGNING WORKHOUSES".] -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49124] util.http.FastHttpDateFormat odd synchronisation
https://issues.apache.org/bugzilla/show_bug.cgi?id=49124 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Mark Thomas 2010-04-14 18:56:37 EDT --- The class is final. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49125] New: toString on byte[] array probably is not correct
https://issues.apache.org/bugzilla/show_bug.cgi?id=49125 Summary: toString on byte[] array probably is not correct Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Two examples of using toString() on a byte[] array, which is unlikely to produce the desired output: ha.deploy.FileMessageFactory.writeMessage() log message uses toString on msg.getData() which is a byte[] array coyote.ajp.AjpMessage.dump use toString on "msg" which is of type byte[] -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49124] New: util.http.FastHttpDateFormat odd synchronisation
https://issues.apache.org/bugzilla/show_bug.cgi?id=49124 Summary: util.http.FastHttpDateFormat odd synchronisation Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org tomcat.util.http.FastHttpDateFormat.format tomcat.util.http.FastHttpDateFormat.formats are both protected static final SimpleDateFormats Access within the class is synch., but there is no guarantee that subclasses will use the same synch. object The fields should be made private, or the synch requirements documented. The class also synchronises on a ConcurrentHashMap which looks very odd. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49118] Inefficient use of String concatenation in loop
https://issues.apache.org/bugzilla/show_bug.cgi?id=49118 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-04-14 18:50:46 EDT --- Fixed in 7.0.0 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934234 - /tomcat/trunk/java/javax/servlet/http/HttpServlet.java
Author: markt
Date: Wed Apr 14 22:50:35 2010
New Revision: 934234
URL: http://svn.apache.org/viewvc?rev=934234&view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=49118
Use StringBuilder rather than concatenation
Modified:
tomcat/trunk/java/javax/servlet/http/HttpServlet.java
Modified: tomcat/trunk/java/javax/servlet/http/HttpServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/http/HttpServlet.java?rev=934234&r1=934233&r2=934234&view=diff
==
--- tomcat/trunk/java/javax/servlet/http/HttpServlet.java (original)
+++ tomcat/trunk/java/javax/servlet/http/HttpServlet.java Wed Apr 14 22:50:35
2010
@@ -559,25 +559,25 @@ public abstract class HttpServlet extend
int responseLength;
String CRLF = "\r\n";
-String responseString = "TRACE "+ req.getRequestURI()+
-" " + req.getProtocol();
+StringBuilder buffer = new StringBuilder("TRACE
").append(req.getRequestURI())
+.append(" ").append(req.getProtocol());
Enumeration reqHeaderEnum = req.getHeaderNames();
while( reqHeaderEnum.hasMoreElements() ) {
String headerName = reqHeaderEnum.nextElement();
-responseString += CRLF + headerName + ": " +
-req.getHeader(headerName);
+buffer.append(CRLF).append(headerName).append(": ")
+.append(req.getHeader(headerName));
}
-responseString += CRLF;
+buffer.append(CRLF);
-responseLength = responseString.length();
+responseLength = buffer.length();
resp.setContentType("message/http");
resp.setContentLength(responseLength);
ServletOutputStream out = resp.getOutputStream();
-out.print(responseString);
+out.print(buffer.toString());
out.close();
return;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49110] runtime.JspFactoryImpl$PageContextPool needs to be static
https://issues.apache.org/bugzilla/show_bug.cgi?id=49110 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-04-14 18:48:01 EDT --- Fixed for 7.0.0 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934233 - /tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java
Author: markt
Date: Wed Apr 14 22:47:57 2010
New Revision: 934233
URL: http://svn.apache.org/viewvc?rev=934233&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49110
Make inner class static to prevent possible memory leak - found by FindBugs
Modified:
tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java
Modified: tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java?rev=934233&r1=934232&r2=934233&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java (original)
+++ tomcat/trunk/java/org/apache/jasper/runtime/JspFactoryImpl.java Wed Apr 14
22:47:57 2010
@@ -174,7 +174,7 @@ public class JspFactoryImpl extends JspF
}
}
-protected final class PageContextPool {
+protected static final class PageContextPool {
private PageContext[] pool;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49109] RealmBase.authenticate uses toString on byte array
https://issues.apache.org/bugzilla/show_bug.cgi?id=49109 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-04-14 18:43:53 EDT --- I've removed the method for 7.0.0 - it was never used. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934232 - in /tomcat/trunk/java/org/apache/catalina: Realm.java realm/CombinedRealm.java realm/LockOutRealm.java realm/RealmBase.java
Author: markt
Date: Wed Apr 14 22:43:37 2010
New Revision: 934232
URL: http://svn.apache.org/viewvc?rev=934232&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49109
Remove unused authenticate() method with a broken default impl
Modified:
tomcat/trunk/java/org/apache/catalina/Realm.java
tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java
tomcat/trunk/java/org/apache/catalina/realm/LockOutRealm.java
tomcat/trunk/java/org/apache/catalina/realm/RealmBase.java
Modified: tomcat/trunk/java/org/apache/catalina/Realm.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Realm.java?rev=934232&r1=934231&r2=934232&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/Realm.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Realm.java Wed Apr 14 22:43:37 2010
@@ -88,17 +88,6 @@ public interface Realm {
/**
- * Return the Principal associated with the specified username and
- * credentials, if there is one; otherwise return null.
- *
- * @param username Username of the Principal to look up
- * @param credentials Password or other credentials to use in
- * authenticating this username
- */
-public Principal authenticate(String username, byte[] credentials);
-
-
-/**
* Return the Principal associated with the specified username, which
* matches the digest calculated using the given parameters using the
* method described in RFC 2069; otherwise return null.
Modified: tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java?rev=934232&r1=934231&r2=934232&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java (original)
+++ tomcat/trunk/java/org/apache/catalina/realm/CombinedRealm.java Wed Apr 14
22:43:37 2010
@@ -80,40 +80,6 @@ public class CombinedRealm extends Realm
/**
- * Return the Principal associated with the specified username and
- * credentials, if there is one; otherwise return null.
- *
- * @param username Username of the Principal to look up
- * @param credentials Password or other credentials to use in
- * authenticating this username
- */
-@Override
-public Principal authenticate(String username, byte[] credentials) {
-Principal authenticatedUser = null;
-
-for (Realm realm : realms) {
-if (log.isDebugEnabled()) {
-log.debug(sm.getString("combinedRealm.authStart", username,
realm.getInfo()));
-}
-
-authenticatedUser = realm.authenticate(username, credentials);
-
-if (authenticatedUser == null) {
-if (log.isDebugEnabled()) {
-log.debug(sm.getString("combinedRealm.authFail", username,
realm.getInfo()));
-}
-} else {
-if (log.isDebugEnabled()) {
-log.debug(sm.getString("combinedRealm.authSucess",
username, realm.getInfo()));
-}
-break;
-}
-}
-return authenticatedUser;
-}
-
-
-/**
* Return the Principal associated with the specified username, which
* matches the digest calculated using the given parameters using the
* method described in RFC 2069; otherwise return null.
Modified: tomcat/trunk/java/org/apache/catalina/realm/LockOutRealm.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/LockOutRealm.java?rev=934232&r1=934231&r2=934232&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/realm/LockOutRealm.java (original)
+++ tomcat/trunk/java/org/apache/catalina/realm/LockOutRealm.java Wed Apr 14
22:43:37 2010
@@ -115,35 +115,6 @@ public class LockOutRealm extends Combin
/**
- * Return the Principal associated with the specified username and
- * credentials, if there is one; otherwise return null.
- *
- * @param username Username of the Principal to look up
- * @param credentials Password or other credentials to use in
- * authenticating this username
- */
-@Override
-public Principal authenticate(String username, byte[] credentials) {
-if (isLocked(username)) {
-// Trying to authenticate a locked user is an automatic failure
-registerAuthFailure(username);
-
-log.warn(sm.getString("lockOutRealm.authLockedUser", username));
-return null;
-}
-
-Principal authenticatedUser = super.authenticate(username,
credentials);
-
-if (authenticatedUser == null) {
-registerAuthFailure(username);
-
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14/04/2010, William A. Rowe Jr. wrote: > On 4/14/2010 4:22 PM, sebb wrote: > > > > Also, SVN is considered by some to be publishing code (e.g. links are > > usually published on the web-site) so better safe than sorry. > > > SVN is a development/work product area. Although now we have dist.apache.org/ > which is, pretty clearly, a dist'ribution point :) The svn.apache.org/ space > is definitely not a publication. Sorry, wrong word. It is a distribution however, at least according to Roy: http://mail-archives.apache.org/mod_mbox/www-legal-discuss/200907.mbox/%3c7a0220b7-5df1-4f4c-8c27-6ca8a175c...@gbiv.com%3e The discussion starts at: http://mail-archives.apache.org/mod_mbox/www-legal-discuss/200907.mbox/%3c2d12b2f00907172041q543e361ekbce6dc935e865...@mail.gmail.com%3e > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49108] Eliminate double-check of same value and fix fallthrough warning
https://issues.apache.org/bugzilla/show_bug.cgi?id=49108 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #1 from Mark Thomas 2010-04-14 18:32:50 EDT --- Package renamed code is not modified. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49107] Document fallthrough, Eclipse-fashion
https://issues.apache.org/bugzilla/show_bug.cgi?id=49107 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #1 from Mark Thomas 2010-04-14 18:31:35 EDT --- The code is already appropriately commented. Not everyone uses Eclipse. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49106] Unused imports
https://issues.apache.org/bugzilla/show_bug.cgi?id=49106 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-04-14 18:29:45 EDT --- Fixed for 7.0.0 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934225 - /tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java
Author: markt Date: Wed Apr 14 22:29:34 2010 New Revision: 934225 URL: http://svn.apache.org/viewvc?rev=934225&view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=49106 Remove unused import Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java?rev=934225&r1=934224&r2=934225&view=diff == --- tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java (original) +++ tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java Wed Apr 14 22:29:34 2010 @@ -24,7 +24,6 @@ import java.security.Principal; import java.text.MessageFormat; import java.util.ArrayList; import java.util.Arrays; -import java.util.Collections; import java.util.HashMap; import java.util.Hashtable; import java.util.Iterator; - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49105] Javadoc corrections
https://issues.apache.org/bugzilla/show_bug.cgi?id=49105 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-04-14 18:28:10 EDT --- Patch has been applied to trunk and will be included in 7.0.0 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934224 - in /tomcat/trunk: java/javax/el/ java/javax/servlet/ java/org/apache/catalina/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/connector/ java/org/apache/catalin
Author: markt
Date: Wed Apr 14 22:27:59 2010
New Revision: 934224
URL: http://svn.apache.org/viewvc?rev=934224&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49105
Misc Javadoc corrections.
Modified:
tomcat/trunk/java/javax/el/ExpressionFactory.java
tomcat/trunk/java/javax/servlet/HttpConstraintElement.java
tomcat/trunk/java/javax/servlet/ServletContext.java
tomcat/trunk/java/org/apache/catalina/Context.java
tomcat/trunk/java/org/apache/catalina/Host.java
tomcat/trunk/java/org/apache/catalina/Lifecycle.java
tomcat/trunk/java/org/apache/catalina/Session.java
tomcat/trunk/java/org/apache/catalina/authenticator/FormAuthenticator.java
tomcat/trunk/java/org/apache/catalina/connector/Request.java
tomcat/trunk/java/org/apache/catalina/core/ApplicationSessionCookieConfig.java
tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
tomcat/trunk/java/org/apache/catalina/tribes/ChannelListener.java
tomcat/trunk/java/org/apache/catalina/tribes/group/RpcChannel.java
tomcat/trunk/java/org/apache/el/parser/AstValue.java
tomcat/trunk/java/org/apache/jasper/compiler/Node.java
tomcat/trunk/webapps/examples/WEB-INF/classes/chat/ChatServlet.java
tomcat/trunk/webapps/examples/WEB-INF/classes/filters/ExampleFilter.java
tomcat/trunk/webapps/examples/WEB-INF/classes/filters/SetCharacterEncodingFilter.java
Modified: tomcat/trunk/java/javax/el/ExpressionFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ExpressionFactory.java?rev=934224&r1=934223&r2=934224&view=diff
==
--- tomcat/trunk/java/javax/el/ExpressionFactory.java (original)
+++ tomcat/trunk/java/javax/el/ExpressionFactory.java Wed Apr 14 22:27:59 2010
@@ -101,7 +101,7 @@ public abstract class ExpressionFactory
* Platform default implementation -
* org.apache.el.ExpressionFactoryImpl
*
- * @return
+ * @return the new ExpressionFactory
*/
public static ExpressionFactory newInstance() {
return newInstance(null);
@@ -111,8 +111,8 @@ public abstract class ExpressionFactory
* Create a new {...@link ExpressionFactory} passing in the provided
* {...@link Properties}. Search order is the same as {...@link
#newInstance()}.
*
- * @param properties
- * @return
+ * @param properties the properties to be passed to the new instance (may
be null)
+ * @return the new ExpressionFactory
*/
public static ExpressionFactory newInstance(Properties properties) {
String className = null;
Modified: tomcat/trunk/java/javax/servlet/HttpConstraintElement.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/HttpConstraintElement.java?rev=934224&r1=934223&r2=934224&view=diff
==
--- tomcat/trunk/java/javax/servlet/HttpConstraintElement.java (original)
+++ tomcat/trunk/java/javax/servlet/HttpConstraintElement.java Wed Apr 14
22:27:59 2010
@@ -43,7 +43,7 @@ public class HttpConstraintElement {
}
/**
- * Convenience constructor for {...@link EmptyRoleSemantic.DENY}.
+ * Convenience constructor for {...@link EmptyRoleSemantic#DENY}.
*
*/
public HttpConstraintElement(EmptyRoleSemantic emptyRoleSemantic) {
Modified: tomcat/trunk/java/javax/servlet/ServletContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/ServletContext.java?rev=934224&r1=934223&r2=934224&view=diff
==
--- tomcat/trunk/java/javax/servlet/ServletContext.java (original)
+++ tomcat/trunk/java/javax/servlet/ServletContext.java Wed Apr 14 22:27:59 2010
@@ -843,7 +843,7 @@ public interface ServletContext {
*
* @param sessionTrackingModes
* @throws IllegalArgumentException If sessionTrackingModes specifies
- * {...@link SessionTrackingMode.SSL} in
+ * {...@link SessionTrackingMode#SSL} in
* combination with any other
* {...@link SessionTrackingMode}
* @throws IllegalStateExceptionIf the context has already been
Modified: tomcat/trunk/java/org/apache/catalina/Context.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/Context.java?rev=934224&r1=934223&r2=934224&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/Context.java (original)
+++ tomcat/trunk/java/org/apache/catalina/Context.java Wed Apr 14 22:27:59 2010
@@ -738,7 +738,7 @@ public interface Context extends Contain
*
DO NOT REPLY [Bug 49104] Fix up some raw types
https://issues.apache.org/bugzilla/show_bug.cgi?id=49104 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-04-14 18:24:55 EDT --- The patch does more than it claims. It also changes packaged renamed code - this part of the patch has been ignored. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934223 - in /tomcat/trunk/java/org/apache: coyote/ajp/AjpProtocol.java coyote/http11/Http11Protocol.java tomcat/util/net/JIoEndpoint.java
Author: markt
Date: Wed Apr 14 22:24:17 2010
New Revision: 934223
URL: http://svn.apache.org/viewvc?rev=934223&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49104
Generics
Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java
tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java
tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java?rev=934223&r1=934222&r2=934223&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProtocol.java Wed Apr 14
22:24:17 2010
@@ -321,8 +321,8 @@ public class AjpProtocol
protected AjpProtocol proto;
protected AtomicLong registerCount = new AtomicLong(0);
protected RequestGroupInfo global = new RequestGroupInfo();
-protected ConcurrentHashMap connections =
-new ConcurrentHashMap();
+protected ConcurrentHashMap, AjpProcessor>
connections =
+new ConcurrentHashMap, AjpProcessor>();
protected ConcurrentLinkedQueue recycledProcessors =
new ConcurrentLinkedQueue() {
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java?rev=934223&r1=934222&r2=934223&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java Wed Apr 14
22:24:17 2010
@@ -32,7 +32,6 @@ import org.apache.coyote.RequestInfo;
import org.apache.juli.logging.Log;
import org.apache.tomcat.util.modeler.Registry;
import org.apache.tomcat.util.net.JIoEndpoint;
-import org.apache.tomcat.util.net.NioChannel;
import org.apache.tomcat.util.net.SSLImplementation;
import org.apache.tomcat.util.net.ServerSocketFactory;
import org.apache.tomcat.util.net.SocketStatus;
@@ -190,8 +189,8 @@ public class Http11Protocol extends Abst
protected Http11Protocol proto;
protected AtomicLong registerCount = new AtomicLong(0);
protected RequestGroupInfo global = new RequestGroupInfo();
-protected ConcurrentHashMap
connections =
-new ConcurrentHashMap();
+protected ConcurrentHashMap, Http11Processor>
connections =
+new ConcurrentHashMap, Http11Processor>();
protected ConcurrentLinkedQueue recycledProcessors =
new ConcurrentLinkedQueue() {
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java?rev=934223&r1=934222&r2=934223&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java Wed Apr 14
22:24:17 2010
@@ -144,9 +144,10 @@ public class JIoEndpoint extends Abstrac
// Ignore
}
long now = System.currentTimeMillis();
-Iterator sockets = waitingRequests.iterator();
+Iterator> sockets =
+waitingRequests.iterator();
while (sockets.hasNext()) {
-SocketWrapper socket = sockets.next();
+SocketWrapper socket = sockets.next();
long access = socket.getLastAccess();
if ((now-access)>socket.getTimeout()) {
processSocket(socket,SocketStatus.TIMEOUT);
@@ -538,7 +539,8 @@ public class JIoEndpoint extends Abstrac
return true;
}
-protected ConcurrentLinkedQueue waitingRequests = new
ConcurrentLinkedQueue();
+protected ConcurrentLinkedQueue> waitingRequests =
+new ConcurrentLinkedQueue>();
private static class PrivilegedSetTccl
implements PrivilegedAction {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49103] Missing annotations
https://issues.apache.org/bugzilla/show_bug.cgi?id=49103 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas 2010-04-14 18:20:23 EDT --- Most of these are WONTFIX. We don't change generated or packaged renamed code unless we absolutely have to. The few there are valid have been fixed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934222 - in /tomcat/trunk/java/org/apache: coyote/http11/Http11NioProtocol.java coyote/http11/Http11Protocol.java tomcat/util/net/AprEndpoint.java tomcat/util/net/NioEndpoint.java tomcat/
Author: markt
Date: Wed Apr 14 22:19:33 2010
New Revision: 934222
URL: http://svn.apache.org/viewvc?rev=934222&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49103
Add @Override where appropriate
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java
tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java?rev=934222&r1=934221&r2=934222&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java Wed Apr
14 22:19:33 2010
@@ -52,6 +52,7 @@ public class Http11NioProtocol extends A
private static final Log log = LogFactory.getLog(Http11NioProtocol.class);
+@Override
protected Log getLog() { return log; }
public Http11NioProtocol() {
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java?rev=934222&r1=934221&r2=934222&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java Wed Apr 14
22:19:33 2010
@@ -55,6 +55,7 @@ public class Http11Protocol extends Abst
private static final org.apache.juli.logging.Log log
= org.apache.juli.logging.LogFactory.getLog(Http11Protocol.class);
+@Override
public Log getLog() { return log; }
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=934222&r1=934221&r2=934222&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Wed Apr 14
22:19:33 2010
@@ -358,6 +358,7 @@ public class AprEndpoint extends Abstrac
/**
* Initialize the endpoint.
*/
+@Override
public void init()
throws Exception {
@@ -515,6 +516,7 @@ public class AprEndpoint extends Abstrac
/**
* Start the APR endpoint, creating acceptor, poller and sendfile threads.
*/
+@Override
public void start()
throws Exception {
// Initialize socket if not done before
@@ -580,6 +582,7 @@ public class AprEndpoint extends Abstrac
/**
* Pause the endpoint, which will make it stop accepting new sockets.
*/
+@Override
public void pause() {
if (running && !paused) {
paused = true;
@@ -592,6 +595,7 @@ public class AprEndpoint extends Abstrac
* Resume the endpoint, which will make it start accepting new sockets
* again.
*/
+@Override
public void resume() {
if (running) {
paused = false;
@@ -628,6 +632,7 @@ public class AprEndpoint extends Abstrac
/**
* Deallocate APR memory pools, and close server socket.
*/
+@Override
public void destroy() throws Exception {
if (running) {
stop();
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java?rev=934222&r1=934221&r2=934222&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java Wed Apr 14
22:19:33 2010
@@ -478,6 +478,7 @@ public class NioEndpoint extends Abstrac
/**
* Initialize the endpoint.
*/
+@Override
public void init()
throws Exception {
@@ -569,6 +570,7 @@ public class NioEndpoint extends Abstrac
/**
* Start the NIO endpoint, creating acceptor, poller threads.
*/
+@Override
public void start()
throws Exception {
// Initialize socket if not done before
@@ -608,6 +610,7 @@ public class NioEndpoint extends Abstrac
/**
* Pause the endpoint, which will make it stop accepting new sockets.
*/
+@Override
public void pause() {
if (running && !paused) {
paused = true;
@@ -620,6 +623,7 @@ public class NioEndpoint extends Abstrac
* Resume the endpoint, which will make it start accepting new socke
DO NOT REPLY [Bug 49102] coyote.ajp.Constants - 3 "constant" arrays are mutable
https://issues.apache.org/bugzilla/show_bug.cgi?id=49102 Mark Thomas changed: What|Removed |Added Priority|P2 |P5 Severity|normal |enhancement --- Comment #1 from Mark Thomas 2010-04-14 18:14:02 EDT --- Leaning towards WONTFIX. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49101] All constants in tribes.transport.Constants are mutable
https://issues.apache.org/bugzilla/show_bug.cgi?id=49101 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #1 from Mark Thomas 2010-04-14 18:12:52 EDT --- Leaning towards WONTFIX. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934219 - in /tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile: EnclosingMethod.java LocalVariableTypeTable.java
Author: markt Date: Wed Apr 14 22:10:35 2010 New Revision: 934219 URL: http://svn.apache.org/viewvc?rev=934219&view=rev Log: CPL allows us to elect to distribute under a later version of the license so elect to distribute under EPL as we are already using EPL for Eclipse JDT. Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/EnclosingMethod.java tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTypeTable.java Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/EnclosingMethod.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/EnclosingMethod.java?rev=934219&r1=934218&r2=934219&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/EnclosingMethod.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/EnclosingMethod.java Wed Apr 14 22:10:35 2010 @@ -6,10 +6,17 @@ * under the terms of the Common Public License v1.0 * which accompanies this distribution and is available at * http://www.eclipse.org/legal/cpl-v10.html - * + * * Contributors: *Andy Clement initial implementation * **/ + +/* + * Under the terms of the CPL v1.0, the ASF has elected to distribute this + * file under the Eclipse Public License (EPL) 1.0 which has been designated + * as the follow-on version of the CPL by the Agreement Steward. + */ + package org.apache.tomcat.util.bcel.classfile; import java.io.DataInput; Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTypeTable.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTypeTable.java?rev=934219&r1=934218&r2=934219&view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTypeTable.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTypeTable.java Wed Apr 14 22:10:35 2010 @@ -11,6 +11,13 @@ *Andy Clement initial implementation *Heavily based on LocalVariableTable * **/ + +/* + * Under the terms of the CPL v1.0, the ASF has elected to distribute this + * file under the Eclipse Public License (EPL) 1.0 which has been designated + * as the follow-on version of the CPL by the Agreement Steward. + */ + package org.apache.tomcat.util.bcel.classfile; - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 4/14/2010 4:22 PM, sebb wrote: > > Also, SVN is considered by some to be publishing code (e.g. links are > usually published on the web-site) so better safe than sorry. SVN is a development/work product area. Although now we have dist.apache.org/ which is, pretty clearly, a dist'ribution point :) The svn.apache.org/ space is definitely not a publication. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14/04/2010 21:31, Mark Thomas wrote: > On 14/04/2010 21:06, sebb wrote: >> 2 files in BCEL have IBM headers; these headers are presumably OK, but >> the NOTICE file probably needs to mention IBM. Not sure why the BCEL >> source archive does not do so in its NOTICE file. That might be an >> error. > Hmm. I might be able to strip down what we use from BCEL to get rid of > those. Easier said than done. I'll add the necessary updates to LICENSE & NOTICE. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934207 - /tomcat/trunk/build.xml
Author: markt
Date: Wed Apr 14 21:40:13 2010
New Revision: 934207
URL: http://svn.apache.org/viewvc?rev=934207&view=rev
Log:
Don't include modules in the src release
Modified:
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=934207&r1=934206&r2=934207&view=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Wed Apr 14 21:40:13 2010
@@ -1251,6 +1251,7 @@ Apache Tomcat ${version} native binaries
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14/04/2010 22:22, sebb wrote: > On 14/04/2010, Mark Thomas wrote: >> On 14/04/2010 21:06, sebb wrote: >> > Many of the java and xml files in tomcat-lite don't have AL headers. >> >> Not an issue. tomcat-lite isn't being shipped (at least it shoudln't be..) > > It's currently in the source archives. I've dropped modules from the src archive. They shouldn't have been included. > Also, SVN is considered by some to be publishing code (e.g. links are > usually published on the web-site) so better safe than sorry. Then they are mis-informed. > Just noticed - RELEASE-NOTES in source archive contains: > > "Tomcat @VERSION_MAJOR_MINOR@ is designed to run on Java SE 6 and later. > > In addition, Tomcat @VERSION_MAJOR_MINOR@ uses the Eclipse JDT Java > compiler for" > > A few other source files also have similar tags (I searched for "@VERSION_"). > > I think the tags in the RELEASE-NOTES (and RUNNING.txt) ought to be > processed to correspond with the release. I disagree. The source bundle should be an exact copy of the tag. The version number is set in build.properties. > This is not so clear for some of the other files - are they supposed > to be the same as the SVN versions, or should they be customised for > the release? See previous comment. > Also, in the Windows binary archives, service.bat includes an RC1 reference: > set PR_DESCRIPTION=Apache Tomcat 7.0.0-RC1 Server - http://tomcat.apache.org/ > > As do various copies of Release Notes and index.html As intended. > I assume the other binary archives are similar, but I did not check them. > > I would have thought that these version references should omit the RC1 > suffix, unless the code is to be released as such (which has been > known in other projects). I disagree. I want to be quite clear which version someone is using when they report a bug, particularly with release candidates when there are likely to be several versions close together. When we have an RC we are happy with, a new tag for the final release will be created and voted on that does not include the RCn. That vote should be very quick as all that will be required is comparing the RCn source tarball with the release source tarball. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934203 - in /tomcat/trunk: build.xml res/META-INF/jasper-jdt.jar.notice res/META-INF/jsp-api.jar.notice res/META-INF/servlet-api.jar.notice
Author: markt
Date: Wed Apr 14 21:25:20 2010
New Revision: 934203
URL: http://svn.apache.org/viewvc?rev=934203&view=rev
Log:
Parametrise current year in all embedded NOTICE files
Don't use the same property name for different output files
Modified:
tomcat/trunk/build.xml
tomcat/trunk/res/META-INF/jasper-jdt.jar.notice
tomcat/trunk/res/META-INF/jsp-api.jar.notice
tomcat/trunk/res/META-INF/servlet-api.jar.notice
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=934203&r1=934202&r2=934203&view=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Wed Apr 14 21:25:20 2010
@@ -112,7 +112,7 @@
-
+
@@ -824,8 +824,8 @@
+ notice="${tomcat.manifests}/servlet-api.jar.notice"
+ license="${tomcat.manifests}/servlet-api.jar.license"/>
@@ -942,7 +942,7 @@
dir="${tomcat.extras}/logging/commons-logging-${commons-logging-version}-src"
target="compile" />
-
@@ -961,13 +961,13 @@
-
-
-
+
-
-
@@ -1067,9 +1067,9 @@
-
-
@@ -1810,8 +1810,8 @@ Apache Tomcat ${version} native binaries
filesDir="${jasper-jdt.home}"
filesId="files.jasper-jdt"
manifest="${tomcat.manifests}/default.manifest"
- notice="${tomcat.home}/res/META-INF/jasper-jdt.jar.notice"
- license="${tomcat.home}/res/META-INF/jasper-jdt.jar.license"/>
+ notice="${tomcat.manifests}/jasper-jdt.jar.notice"
+ license="${tomcat.manifests}/jasper-jdt.jar.license"/>
Modified: tomcat/trunk/res/META-INF/jasper-jdt.jar.notice
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/META-INF/jasper-jdt.jar.notice?rev=934203&r1=934202&r2=934203&view=diff
==
--- tomcat/trunk/res/META-INF/jasper-jdt.jar.notice (original)
+++ tomcat/trunk/res/META-INF/jasper-jdt.jar.notice Wed Apr 14 21:25:20 2010
@@ -1,5 +1,5 @@
Apache Tomcat
-Copyright 1999-2010 The Apache Software Foundation
+Copyright 19...@year@ The Apache Software Foundation
This product includes software developed by
The Apache Software Foundation (http://www.apache.org/).
Modified: tomcat/trunk/res/META-INF/jsp-api.jar.notice
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/META-INF/jsp-api.jar.notice?rev=934203&r1=934202&r2=934203&view=diff
==
--- tomcat/trunk/res/META-INF/jsp-api.jar.notice (original)
+++ tomcat/trunk/res/META-INF/jsp-api.jar.notice Wed Apr 14 21:25:20 2010
@@ -1,5 +1,5 @@
Apache Tomcat
-Copyright 1999-2010 The Apache Software Foundation
+Copyright 19...@year@ The Apache Software Foundation
This product includes software developed by
The Apache Software Foundation (http://www.apache.org/).
Modified: tomcat/trunk/res/META-INF/servlet-api.jar.notice
URL:
http://svn.apache.org/viewvc/tomcat/trunk/res/META-INF/servlet-api.jar.notice?rev=934203&r1=934202&r2=934203&view=diff
==
--- tomcat/trunk/res/META-INF/servlet-api.jar.notice (original)
+++ tomcat/trunk/res/META-INF/servlet-api.jar.notice Wed Apr 14 21:25:20 2010
@@ -1,5 +1,5 @@
Apache Tomcat
-Copyright 1999-2010 The Apache Software Foundation
+Copyright 19...@year@ The Apache Software Foundation
This product includes software developed by
The Apache Software Foundation (http://www.apache.org/).
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14/04/2010, Mark Thomas wrote: > On 14/04/2010 21:06, sebb wrote: > > Many of the java and xml files in tomcat-lite don't have AL headers. > > Not an issue. tomcat-lite isn't being shipped (at least it shoudln't be..) It's currently in the source archives. Also, SVN is considered by some to be publishing code (e.g. links are usually published on the web-site) so better safe than sorry. > > The following other files don't have AL headers: > > > > res/config.ini > > res/jvm.ini > > test/org/apache/coyote/http11/TestInternalInputBuffer.java > > test/org/apache/naming/resources/TestBaseDirContext.java > > > > The java files definitely need AL headers. > > Yep. fixed. > > > > I don't know the syntax of the .ini files, so it may be impossible to > > add comments, but if comments are possible, then the appropriate > > header should be added as these are not trivial files. > > I think I have the format for this. Need to build the installer to test it. > > > > 2 files in BCEL have IBM headers; these headers are presumably OK, but > > the NOTICE file probably needs to mention IBM. Not sure why the BCEL > > source archive does not do so in its NOTICE file. That might be an > > error. > > Hmm. I might be able to strip down what we use from BCEL to get rid of > those. > > > > Otherwise the source archives and SVN tag look OK, and they agree with > > each other apart from .classpath and .project, which aren't needed in > > the archives. > > As expected. > > > The binary archives generally look good, with N&L files and useful > manifests. > > However, the Implementation-version headers include -RC1. > > Not sure that's correct; depends how the RC is promoted to GA. > > Current thinking is tag with another vote that should be quick as folks > will just need to diff the approved RC with the new source tarball. > > > There is a minor problem with the bin/tomcat-juli.jar - the NOTICE says: > > Copyright 19...@year@ > > I'll take a look. > Just noticed - RELEASE-NOTES in source archive contains: "Tomcat @VERSION_MAJOR_MINOR@ is designed to run on Java SE 6 and later. In addition, Tomcat @VERSION_MAJOR_MINOR@ uses the Eclipse JDT Java compiler for" A few other source files also have similar tags (I searched for "@VERSION_"). I think the tags in the RELEASE-NOTES (and RUNNING.txt) ought to be processed to correspond with the release. This is not so clear for some of the other files - are they supposed to be the same as the SVN versions, or should they be customised for the release? Also, in the Windows binary archives, service.bat includes an RC1 reference: set PR_DESCRIPTION=Apache Tomcat 7.0.0-RC1 Server - http://tomcat.apache.org/ As do various copies of Release Notes and index.html I assume the other binary archives are similar, but I did not check them. I would have thought that these version references should omit the RC1 suffix, unless the code is to be released as such (which has been known in other projects). > > And for some odd reason there is an MD5 hash for it in the directory. > > The file could probably be removed. > > And at that. > > > > The bin/tomcat-native.tar.gz file includes a KEYS file which probably > > does not belong. > > Since it can be a separate download, I'm happy with that. It's OK, just unnecessary. In fact KEYS is present in the source archives too. > > > My vote would be -1 because of the licensing issues. > > Yep. RC2 coming up. > > > Mark > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934192 - in /tomcat/trunk/res: config.ini jvm.ini
Author: markt Date: Wed Apr 14 20:51:19 2010 New Revision: 934192 URL: http://svn.apache.org/viewvc?rev=934192&view=rev Log: Add license headers to NSIS files Modified: tomcat/trunk/res/config.ini tomcat/trunk/res/jvm.ini Modified: tomcat/trunk/res/config.ini URL: http://svn.apache.org/viewvc/tomcat/trunk/res/config.ini?rev=934192&r1=934191&r2=934192&view=diff == --- tomcat/trunk/res/config.ini (original) +++ tomcat/trunk/res/config.ini Wed Apr 14 20:51:19 2010 @@ -1,3 +1,18 @@ +; Licensed to the Apache Software Foundation (ASF) under one or more +; contributor license agreements. See the NOTICE file distributed with +; this work for additional information regarding copyright ownership. +; The ASF licenses this file to You under the Apache License, Version 2.0 +; (the "License"); you may not use this file except in compliance with +; the License. You may obtain a copy of the License at +; +; http://www.apache.org/licenses/LICENSE-2.0 +; +; Unless required by applicable law or agreed to in writing, software +; distributed under the License is distributed on an "AS IS" BASIS, +; WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +; See the License for the specific language governing permissions and +; limitations under the License. + [Settings] NumFields=7 Modified: tomcat/trunk/res/jvm.ini URL: http://svn.apache.org/viewvc/tomcat/trunk/res/jvm.ini?rev=934192&r1=934191&r2=934192&view=diff == --- tomcat/trunk/res/jvm.ini (original) +++ tomcat/trunk/res/jvm.ini Wed Apr 14 20:51:19 2010 @@ -1,3 +1,18 @@ +; Licensed to the Apache Software Foundation (ASF) under one or more +; contributor license agreements. See the NOTICE file distributed with +; this work for additional information regarding copyright ownership. +; The ASF licenses this file to You under the Apache License, Version 2.0 +; (the "License"); you may not use this file except in compliance with +; the License. You may obtain a copy of the License at +; +; http://www.apache.org/licenses/LICENSE-2.0 +; +; Unless required by applicable law or agreed to in writing, software +; distributed under the License is distributed on an "AS IS" BASIS, +; WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +; See the License for the specific language governing permissions and +; limitations under the License. + [Settings] NumFields=2 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14/04/2010 21:06, sebb wrote: > Many of the java and xml files in tomcat-lite don't have AL headers. Not an issue. tomcat-lite isn't being shipped (at least it shoudln't be..) > The following other files don't have AL headers: > > res/config.ini > res/jvm.ini > test/org/apache/coyote/http11/TestInternalInputBuffer.java > test/org/apache/naming/resources/TestBaseDirContext.java > > The java files definitely need AL headers. Yep. fixed. > I don't know the syntax of the .ini files, so it may be impossible to > add comments, but if comments are possible, then the appropriate > header should be added as these are not trivial files. I think I have the format for this. Need to build the installer to test it. > 2 files in BCEL have IBM headers; these headers are presumably OK, but > the NOTICE file probably needs to mention IBM. Not sure why the BCEL > source archive does not do so in its NOTICE file. That might be an > error. Hmm. I might be able to strip down what we use from BCEL to get rid of those. > Otherwise the source archives and SVN tag look OK, and they agree with > each other apart from .classpath and .project, which aren't needed in > the archives. As expected. > The binary archives generally look good, with N&L files and useful manifests. > However, the Implementation-version headers include -RC1. > Not sure that's correct; depends how the RC is promoted to GA. Current thinking is tag with another vote that should be quick as folks will just need to diff the approved RC with the new source tarball. > There is a minor problem with the bin/tomcat-juli.jar - the NOTICE says: > Copyright 19...@year@ I'll take a look. > And for some odd reason there is an MD5 hash for it in the directory. > The file could probably be removed. And at that. > The bin/tomcat-native.tar.gz file includes a KEYS file which probably > does not belong. Since it can be a separate download, I'm happy with that. > My vote would be -1 because of the licensing issues. Yep. RC2 coming up. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 04/14/2010 01:58 PM, Rainer Jung wrote: On 14.04.2010 20:52, Mladen Turk wrote: On 04/14/2010 08:35 PM, Rainer Jung wrote: On 14.04.2010 16:13, Mladen Turk wrote: Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.Catalina startInternal INFO: Server startup in 965 ms ^^ Impressive! 8 core i7 does the remaining :) Naaa, startup is single-threaded ... the other 7 are cheering it on, hence boosting its confidence and speed - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934173 - in /tomcat/trunk/test/org/apache: coyote/http11/TestInternalInputBuffer.java naming/resources/TestBaseDirContext.java
Author: markt Date: Wed Apr 14 20:18:14 2010 New Revision: 934173 URL: http://svn.apache.org/viewvc?rev=934173&view=rev Log: AL2 header Modified: tomcat/trunk/test/org/apache/coyote/http11/TestInternalInputBuffer.java tomcat/trunk/test/org/apache/naming/resources/TestBaseDirContext.java Modified: tomcat/trunk/test/org/apache/coyote/http11/TestInternalInputBuffer.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http11/TestInternalInputBuffer.java?rev=934173&r1=934172&r2=934173&view=diff == --- tomcat/trunk/test/org/apache/coyote/http11/TestInternalInputBuffer.java (original) +++ tomcat/trunk/test/org/apache/coyote/http11/TestInternalInputBuffer.java Wed Apr 14 20:18:14 2010 @@ -1,3 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + package org.apache.coyote.http11; import java.io.IOException; Modified: tomcat/trunk/test/org/apache/naming/resources/TestBaseDirContext.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/naming/resources/TestBaseDirContext.java?rev=934173&r1=934172&r2=934173&view=diff == --- tomcat/trunk/test/org/apache/naming/resources/TestBaseDirContext.java (original) +++ tomcat/trunk/test/org/apache/naming/resources/TestBaseDirContext.java Wed Apr 14 20:18:14 2010 @@ -1,3 +1,20 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + package org.apache.naming.resources; import java.io.File; - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934170 - /tomcat/trunk/res/jvm.ini
Author: markt Date: Wed Apr 14 20:11:59 2010 New Revision: 934170 URL: http://svn.apache.org/viewvc?rev=934170&view=rev Log: Tomcat 7 needs Java 6 Modified: tomcat/trunk/res/jvm.ini Modified: tomcat/trunk/res/jvm.ini URL: http://svn.apache.org/viewvc/tomcat/trunk/res/jvm.ini?rev=934170&r1=934169&r2=934170&view=diff == --- tomcat/trunk/res/jvm.ini (original) +++ tomcat/trunk/res/jvm.ini Wed Apr 14 20:11:59 2010 @@ -3,7 +3,7 @@ NumFields=2 [Field 1] Type=Label -Text=Please select the path of a J2SE 5.0 or later JRE installed on your system. Note that if you have a 64-bit operating system, you must specify a 64-bit JRE: +Text=Please select the path of a J2SE 6.0 or later JRE installed on your system. Note that if you have a 64-bit operating system, you must specify a 64-bit JRE: left=0 right=300 top=5 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14/04/2010, Mark Thomas wrote: > All, > > After the experience of the recent 6.0.x releases, I wanted to try an > alternative approach and use explicit release candidates for 7.0.x. I'm > expecting to tweak the release process as we go. > > The first Tomcat 7 release candiate is ready for testing. 7.0.0-RC1 can > be obtained from: > http://people.apache.org/~markt/dev/tomcat-7/v7.0.0-RC1/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_0_RC1/ > > Please test this release candidate and provide feedback. > > Please run all of your tests against this candidate and report all > failures. I'd like to avoid the test, stop at first failure, new RC, > test, stop at first failure, new RC etc. cycle. > > And now for the important part: > > The 7.0.0-RC1 tag is > [ ] Broken - do not release > [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 > [ ] Beta - go ahead and release 7.0.0 Beta based on 7.0.0-RC1 > [ ] Stable - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 > > The following issues were noted: > - > > There are a few licensing issues: Many of the java and xml files in tomcat-lite don't have AL headers. The following other files don't have AL headers: res/config.ini res/jvm.ini test/org/apache/coyote/http11/TestInternalInputBuffer.java test/org/apache/naming/resources/TestBaseDirContext.java The java files definitely need AL headers. I don't know the syntax of the .ini files, so it may be impossible to add comments, but if comments are possible, then the appropriate header should be added as these are not trivial files. 2 files in BCEL have IBM headers; these headers are presumably OK, but the NOTICE file probably needs to mention IBM. Not sure why the BCEL source archive does not do so in its NOTICE file. That might be an error. Otherwise the source archives and SVN tag look OK, and they agree with each other apart from .classpath and .project, which aren't needed in the archives. The binary archives generally look good, with N&L files and useful manifests. However, the Implementation-version headers include -RC1. Not sure that's correct; depends how the RC is promoted to GA. There is a minor problem with the bin/tomcat-juli.jar - the NOTICE says: Copyright 19...@year@ And for some odd reason there is an MD5 hash for it in the directory. The file could probably be removed. The bin/tomcat-native.tar.gz file includes a KEYS file which probably does not belong. My vote would be -1 because of the licensing issues. Not yet had a chance to test the binaries. > Thanks, > > Mark > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14.04.2010 20:52, Mladen Turk wrote: On 04/14/2010 08:35 PM, Rainer Jung wrote: On 14.04.2010 16:13, Mladen Turk wrote: Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.Catalina startInternal INFO: Server startup in 965 ms ^^ Impressive! 8 core i7 does the remaining :) Naaa, startup is single-threaded ... - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
INFO: Starting Servlet Engine: Apache Tomcat/7.0.0-RC1 Apr 14, 2010 9:00:34 PM org.apache.catalina.startup.HostConfig deployWAR INFO: Deploying web application archive webtest.war Apr 14, 2010 9:00:34 PM org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application directory ROOT Apr 14, 2010 9:00:34 PM org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application directory manager Apr 14, 2010 9:00:34 PM org.apache.coyote.http11.Http11Protocol start INFO: Starting Coyote HTTP/1.1 on http-8080 Apr 14, 2010 9:00:34 PM org.apache.coyote.ajp.AjpProtocol start INFO: Starting Coyote AJP/1.3 on ajp-8009 Apr 14, 2010 9:00:34 PM org.apache.catalina.startup.Catalina startInternal INFO: Server startup in 627 ms Laptop with Intel Core 2 Duo :-), I'll do some testing on a z10 EC tomorrow. I noticed that the Lambda Probe burks with a StackOverflowError in tomcat7, but haven't looked at it further : Apr 14, 2010 7:01:28 PM org.apache.catalina.core.ApplicationContext log INFO: IvpServlet: Total execution time (ms) : 1 Apr 14, 2010 7:03:49 PM org.apache.catalina.core.ApplicationContext log INFO: Loading WebApplicationContext for Spring FrameworkServlet 'probe' Apr 14, 2010 7:03:52 PM org.apache.catalina.core.StandardWrapperValve invoke SEVERE: Servlet.service() for servlet jsp threw exception java.lang.StackOverflowError at org.springframework.web.util.NestedServletException.getCause(NestedServletException.java:69) at javax.servlet.ServletException.getRootCause(ServletException.java:96) at org.springframework.web.util.NestedServletException.getCause(NestedServletException.java:69) at javax.servlet.ServletException.getRootCause(ServletException.java:96) at org.springframework.web.util.NestedServletException.getCause(NestedServletException.java:69) at javax.servlet.ServletException.getRootCause(ServletException.java:96) regards, Harry 2010/4/14 Mladen Turk > On 04/14/2010 08:35 PM, Rainer Jung wrote: > >> On 14.04.2010 16:13, Mladen Turk wrote: >> >>> Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.Catalina >>> startInternal >>> INFO: Server startup in 965 ms >>> >> >> ^^ >> >> Impressive! >> >> > 8 core i7 does the remaining :) > > > Cheers > -- > ^TM > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 04/14/2010 08:35 PM, Rainer Jung wrote: On 14.04.2010 16:13, Mladen Turk wrote: Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.Catalina startInternal INFO: Server startup in 965 ms ^^ Impressive! 8 core i7 does the remaining :) Cheers -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14.04.2010 16:13, Mladen Turk wrote: Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.Catalina startInternal INFO: Server startup in 965 ms ^^ Impressive! Cheers, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49100] Mutable public constants: MemberImpl.TRIBES_MBR_BEGIN/END
https://issues.apache.org/bugzilla/show_bug.cgi?id=49100 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #1 from Mark Thomas 2010-04-14 14:04:35 EDT --- Leaning towards WONTFIX. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r934067 - /tomcat/trunk/RELEASE-NOTES
Author: markt Date: Wed Apr 14 18:00:34 2010 New Revision: 934067 URL: http://svn.apache.org/viewvc?rev=934067&view=rev Log: Add info on API stability to the release. Modified: tomcat/trunk/RELEASE-NOTES Modified: tomcat/trunk/RELEASE-NOTES URL: http://svn.apache.org/viewvc/tomcat/trunk/RELEASE-NOTES?rev=934067&r1=934066&r2=934067&view=diff == --- tomcat/trunk/RELEASE-NOTES (original) +++ tomcat/trunk/RELEASE-NOTES Wed Apr 14 18:00:34 2010 @@ -27,6 +27,7 @@ CONTENTS: = * Dependency Changes +* API Stability * JNI Based Applications * Bundled APIs * Web application reloading and static fields in shared libraries @@ -53,6 +54,25 @@ compiler from the JDK to compile JSPs, o by Apache Ant. +== +API Stability: +== +The public interfaces for the following classes are fixed and will not be +changed at all during the remaining lifetime of the 7.x series: +- javax/**/* + +The public interfaces for the following classes may be added to in order to +resolve bugs and/or add new features. No existing interface will be removed or +changed although it may be deprecated. +- none + +Note: As Tomcat 7 matures, the above list will be added to. The list is not + considered complete at this time. + +The remaining classes are considered part of the Tomcat internals and may change +without notice between point releases. + + === JNI Based Applications: === - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
setRequest method on HttpServletRequestWrapper
Hi, I was going through tomcat source code. (Specifically ApplicationDispatcher.java). The way HttpServletRequestWrapper is used there, puzzled me. What is the intent of all the methods of HttpServletRequestWrapper class in servlet api? Specifically HttpServletRequestWrapper's setRequest method looks like exposed only for container writers. It will never work if develoepers use this method in their filter to wrap the request (for something like url rewriting). What do you think is the intent of exposing this method to public? I was actually thinking if its possible to write Url rewriter (like mod_rewrite) using J2EE API. (request.forward does actually the same thing, but its container controlled). Thanks, Unmesh - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14/04/2010 11:34, Mark Thomas wrote: > The 7.0.0-RC1 tag is > [ ] Broken - do not release > [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 > [X] Beta - go ahead and release 7.0.0 Beta based on 7.0.0-RC1 > [ ] Stable - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 > > The following issues were noted: - Need to add note on stability of APIs to release notes - APR has a recommended minimum of 1.2.21 which hasn't been released yet - Re-opened https://issues.apache.org/bugzilla/show_bug.cgi?id=49082 - Servlet 3.0 TCK passes with BIO connector and no security manager - Servlet 3.0 TCK passes with BIO connector and a security manager - Servlet 3.0 TCK passes with NIO connector and a security manager with some exceptions [1] - Servlet 3.0 TCK fails with APR connector and a security manager [2] - JSP 2.2 TCK passes with a security manager - EL 2.2 TCK passes with a security manager The lack of complete Async support for the APR connector makes this a Beta release for me. Mark [1] Tests that require SSL renegotiation fail since the NIO connector does not support it. [2] Async implementation is yet to be addressed for APR - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 04/14/2010 04:13 PM, Mladen Turk wrote: > On 04/14/2010 03:35 PM, jean-frederic clere wrote: >> On 04/14/2010 12:34 PM, Mark Thomas wrote: >> >> The APR gives some errors for example Address already in use:8080 >> on my Linux box. All other test/plaforms look ok. >> > > Seems you have a broken linux box :) Nah... I was using a broken tc-native :-/ redoing tests now... Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49082] ExpressionFactory.newInstance needs to be privileged
https://issues.apache.org/bugzilla/show_bug.cgi?id=49082 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #3 from Mark Thomas 2010-04-14 10:46:11 EDT --- Thanks. Fixed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r933972 - /tomcat/trunk/java/javax/el/ExpressionFactory.java
Author: markt
Date: Wed Apr 14 14:46:07 2010
New Revision: 933972
URL: http://svn.apache.org/viewvc?rev=933972&view=rev
Log:
Fully fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49082
Modified:
tomcat/trunk/java/javax/el/ExpressionFactory.java
Modified: tomcat/trunk/java/javax/el/ExpressionFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ExpressionFactory.java?rev=933972&r1=933971&r2=933972&view=diff
==
--- tomcat/trunk/java/javax/el/ExpressionFactory.java (original)
+++ tomcat/trunk/java/javax/el/ExpressionFactory.java Wed Apr 14 14:46:07 2010
@@ -71,8 +71,8 @@ public abstract class ExpressionFactory
);
} else {
SEP = System.getProperty("file.separator");
-PROPERTY_FILE = System.getProperty("java.home") + "lib" + SEP +
-"el.properties";
+PROPERTY_FILE = System.getProperty("java.home") + SEP + "lib" +
+SEP + "el.properties";
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49082] ExpressionFactory.newInstance needs to be privileged
https://issues.apache.org/bugzilla/show_bug.cgi?id=49082
Robert Goff changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED |
--- Comment #2 from Robert Goff 2010-04-14 10:32:19
EDT ---
The additional SEP after System.getProperty("java.home") was only added when
security is enabled. This needs to be fixed when security is not enabled as
well.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 04/14/2010 03:50 PM, Mark Thomas wrote: > On 14/04/2010 14:35, jean-frederic clere wrote: >> On 04/14/2010 12:34 PM, Mark Thomas wrote: > >>> The 7.0.0-RC1 tag is >>> [ ] Broken - do not release >>> [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 >>> [X] Beta - go ahead and release 7.0.0 Beta based on 7.0.0-RC1 >> >> The APR gives some errors for example Address already in use :8080 +++ at org.apache.catalina.connector.Connector.initialize(Connector.java:899) at org.apache.catalina.core.StandardService.initialize(StandardService.java:593) at org.apache.catalina.core.StandardServer.initialize(StandardServer.java:730) at org.apache.catalina.startup.Catalina.load(Catalina.java:504) at org.apache.catalina.startup.Catalina.load(Catalina.java:527) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.catalina.startup.Bootstrap.load(Bootstrap.java:260) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:412) +++ >> on my Linux box. All other test/plaforms look ok. > > Could expand on what causes those failures? There isn't much to go on > here in terms of repeating them and getting them fixed. The others are TCK related I will use the private list to report them. Cheers Jean-Frederic > > Mark > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 04/14/2010 03:35 PM, jean-frederic clere wrote: On 04/14/2010 12:34 PM, Mark Thomas wrote: The APR gives some errors for example Address already in use:8080 on my Linux box. All other test/plaforms look ok. Seems you have a broken linux box :) Here is mine dump on RHEL-5 Apr 14, 2010 4:05:12 PM org.apache.catalina.core.AprLifecycleListener init INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters [false], random [true]. Apr 14, 2010 4:05:12 PM org.apache.coyote.http11.Http11AprProtocol init INFO: Initializing Coyote HTTP/1.1 on http-8080 Apr 14, 2010 4:05:12 PM org.apache.coyote.ajp.AjpAprProtocol init INFO: Initializing Coyote AJP/1.3 on ajp-8009 INFO: Starting Servlet Engine: Apache Tomcat/7.0.0-RC1 And on Fedora 12 Apr 14, 2010 4:12:14 PM org.apache.catalina.core.AprLifecycleListener init INFO: An older version 1.1.19 of the APR based Apache Tomcat Native library is installed, while Tomcat recommends a minimum version of 1.1.21 Apr 14, 2010 4:12:14 PM org.apache.catalina.core.AprLifecycleListener init INFO: Loaded APR based Apache Tomcat Native library 1.1.19. Apr 14, 2010 4:12:14 PM org.apache.catalina.core.AprLifecycleListener init INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters [false], random [true]. Apr 14, 2010 4:12:15 PM org.apache.coyote.http11.Http11AprProtocol init INFO: Initializing Coyote HTTP/1.1 on http-8080 Apr 14, 2010 4:12:15 PM org.apache.coyote.ajp.AjpAprProtocol init INFO: Initializing Coyote AJP/1.3 on ajp-8009 Apr 14, 2010 4:12:15 PM org.apache.catalina.startup.Catalina load INFO: Initialization processed in 1439 ms Apr 14, 2010 4:12:15 PM org.apache.catalina.core.StandardService startInternal INFO: Starting service Catalina Apr 14, 2010 4:12:15 PM org.apache.catalina.core.StandardEngine startInternal INFO: Starting Servlet Engine: Apache Tomcat/7.0.0-RC1 Apr 14, 2010 4:12:15 PM org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application directory ROOT Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application directory host-manager Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application directory examples Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application directory docs Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.HostConfig deployDirectory INFO: Deploying web application directory manager Apr 14, 2010 4:12:16 PM org.apache.coyote.http11.Http11AprProtocol start INFO: Starting Coyote HTTP/1.1 on http-8080 Apr 14, 2010 4:12:16 PM org.apache.coyote.ajp.AjpAprProtocol start INFO: Starting Coyote AJP/1.3 on ajp-8009 Apr 14, 2010 4:12:16 PM org.apache.catalina.startup.Catalina startInternal INFO: Server startup in 965 ms Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14/04/2010, Mladen Turk wrote: > On 04/14/2010 12:34 PM, Mark Thomas wrote: > > > > > The 7.0.0-RC1 tag is > > [ ] Broken - do not release > > [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 > > [ ] Beta - go ahead and release 7.0.0 Beta based on 7.0.0-RC1 > > [X] Stable - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 > > > > > > Tested on win32 and linux, both with and without native. > Even SSL renegotiation works :) > > Sadly sebb blocked my daemon 1.0.3 release because of few comment typos, > that has fixed stdout/stderr redirection, but I hope we'll have it in > the next release. That's not fair. I voted -1, but that does not block a release. > Regards > -- > ^TM > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14/04/2010 14:35, jean-frederic clere wrote: > On 04/14/2010 12:34 PM, Mark Thomas wrote: >> The 7.0.0-RC1 tag is >> [ ] Broken - do not release >> [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 >> [X] Beta - go ahead and release 7.0.0 Beta based on 7.0.0-RC1 > > The APR gives some errors for example Address already in use :8080 > on my Linux box. All other test/plaforms look ok. Could expand on what causes those failures? There isn't much to go on here in terms of repeating them and getting them fixed. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49122] Update of ROOT application index.html
https://issues.apache.org/bugzilla/show_bug.cgi?id=49122 --- Comment #1 from Pid 2010-04-14 09:41:54 EDT --- Created an attachment (id=25295) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25295) Modified ROOT app index.html -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49122] New: Update of ROOT application index.html
https://issues.apache.org/bugzilla/show_bug.cgi?id=49122 Summary: Update of ROOT application index.html Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P2 Component: Examples AssignedTo: dev@tomcat.apache.org ReportedBy: bugzi...@pidster.com The patch adds a new paragraph at the top of the page, recommending that users join the low volume Tomcat Announce list and adds a link to the appropriate subscription email address. The patch also replaces the table based layout with a standards compliant CSS version, which is largely visually identical. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 04/14/2010 12:34 PM, Mark Thomas wrote: > All, > > After the experience of the recent 6.0.x releases, I wanted to try an > alternative approach and use explicit release candidates for 7.0.x. I'm > expecting to tweak the release process as we go. > > The first Tomcat 7 release candiate is ready for testing. 7.0.0-RC1 can > be obtained from: > http://people.apache.org/~markt/dev/tomcat-7/v7.0.0-RC1/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_0_RC1/ > > Please test this release candidate and provide feedback. > > Please run all of your tests against this candidate and report all > failures. I'd like to avoid the test, stop at first failure, new RC, > test, stop at first failure, new RC etc. cycle. > > And now for the important part: > > The 7.0.0-RC1 tag is > [ ] Broken - do not release > [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 > [X] Beta - go ahead and release 7.0.0 Beta based on 7.0.0-RC1 The APR gives some errors for example Address already in use :8080 on my Linux box. All other test/plaforms look ok. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
On 04/14/2010 07:07 AM, Konstantin Kolinko wrote: 2010/4/13 Filip Hanik - Dev Lists: This makes zero sense and I would do a -1 on this commit and the bug in general. What effectively has happened here is that there has been a public API change without any justification. Since this is a mutable field, you've now made it non mutable. and in there lies the change. I am +1 on the change. doesn't change a veto If we need it configurable, let's define a system property to initialize its value at startup, I agree, however that was not done in the original commit. or better to define an instance field somewhere. again, I agree. If you're gonna change the API, do it right. Let's not make variables "final" cause it's someone preference It makes no sense for me to flip between "secure random" and "insecure random" at runtime. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
2010/4/13 Filip Hanik - Dev Lists : > This makes zero sense and I would do a -1 on this commit and the bug in > general. > What effectively has happened here is that there has been a public API > change without any justification. > > Since this is a mutable field, you've now made it non mutable. and in there > lies the change. > I am +1 on the change. If we need it configurable, let's define a system property to initialize its value at startup, or better to define an instance field somewhere. It makes no sense for me to flip between "secure random" and "insecure random" at runtime. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 04/14/2010 12:34 PM, Mark Thomas wrote: The 7.0.0-RC1 tag is [ ] Broken - do not release [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 [ ] Beta - go ahead and release 7.0.0 Beta based on 7.0.0-RC1 [X] Stable - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 Tested on win32 and linux, both with and without native. Even SSL renegotiation works :) Sadly sebb blocked my daemon 1.0.3 release because of few comment typos, that has fixed stdout/stderr redirection, but I hope we'll have it in the next release. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49045] JMX Enhancement- Provision of MBeanFactory createStandardService
https://issues.apache.org/bugzilla/show_bug.cgi?id=49045 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #8 from Mark Thomas 2010-04-14 08:07:06 EDT --- Thanks for the analysis and updated patch. As I reviewed the patch I realised that a lot of the complexity was caused by trying to add Service and Engine separately. When considered along side the long term aim to merge Service and Engine and the short term goal to extend Lifecycle to cover MBean registration I now think you original idea to add the two togetehr is the right way to go. I have applied a patch based you your patches that does this and also cleans up some old methods from the descriptors. In terms of what to do next, I'd suggest posting your ideas for the next steps to the dev list. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r933921 - in /tomcat/trunk/java/org/apache/catalina/mbeans: MBeanFactory.java mbeans-descriptors.xml
Author: markt
Date: Wed Apr 14 12:07:04 2010
New Revision: 933921
URL: http://svn.apache.org/viewvc?rev=933921&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49045
Add support for adding Services and Engines via JMX
Based on a patch by Chamith Buddhika
Modified:
tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java
tomcat/trunk/java/org/apache/catalina/mbeans/mbeans-descriptors.xml
Modified: tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java?rev=933921&r1=933920&r2=933921&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java (original)
+++ tomcat/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java Wed Apr 14
12:07:04 2010
@@ -50,7 +50,6 @@ import org.apache.catalina.valves.Access
import org.apache.catalina.valves.RemoteAddrValve;
import org.apache.catalina.valves.RemoteHostValve;
import org.apache.catalina.valves.ValveBase;
-import org.apache.tomcat.util.modeler.BaseModelMBean;
/**
@@ -61,7 +60,7 @@ import org.apache.tomcat.util.modeler.Ba
* @version $Revision$ $Date$
*/
-public class MBeanFactory extends BaseModelMBean {
+public class MBeanFactory {
private static final org.apache.juli.logging.Log log =
org.apache.juli.logging.LogFactory.getLog(MBeanFactory.class);
@@ -548,9 +547,8 @@ public class MBeanFactory extends BaseMo
String docBase)
throws Exception {
-// XXX for backward compatibility. Remove it once supported by the
admin
-return
-
createStandardContext(parent,path,docBase,false,false,false,false);
+return createStandardContext(parent, path, docBase, false, false,
+false, false);
}
/**
@@ -687,6 +685,38 @@ public class MBeanFactory extends BaseMo
/**
+ * Creates a new StandardService and StandardEngine.
+ *
+ * @param domain Domain name for the container instance
+ * @param defaultHost Name of the default host to be used in the Engine
+ * @param baseDir Base directory value for Engine
+ *
+ * @exception Exception if an MBean cannot be created or registered
+ */
+public String createStandardServiceEngine(String domain,
+String defaultHost, String baseDir) throws Exception{
+
+if (!(container instanceof Server)) {
+throw new Exception();
+}
+
+StandardEngine engine = new StandardEngine();
+engine.setDomain(domain);
+engine.setName(domain);
+engine.setDefaultHost(defaultHost);
+engine.setBaseDir(baseDir);
+
+Service service = new StandardService();
+service.setContainer(engine);
+service.setName(domain);
+
+((Server) container).addService(service);
+
+return engine.getJmxName().toString();
+}
+
+
+/**
* Create a new StandardManager.
*
* @param parent MBean Name of the associated parent component
@@ -946,6 +976,26 @@ public class MBeanFactory extends BaseMo
/**
+ * Remove an existing Service.
+ *
+ * @param name MBean Name of the component to remove
+ *
+ * @exception Exception if a component cannot be removed
+ */
+public void removeService(String name) throws Exception {
+
+if (!(container instanceof Server)) {
+throw new Exception();
+}
+
+// Acquire a reference to the component to be removed
+ObjectName oname = new ObjectName(name);
+Service service = getService(oname);
+((Server) container).removeService(service);
+}
+
+
+/**
* Remove an existing Valve.
*
* @param name MBean Name of the component to remove
Modified: tomcat/trunk/java/org/apache/catalina/mbeans/mbeans-descriptors.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mbeans/mbeans-descriptors.xml?rev=933921&r1=933920&r2=933921&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/mbeans/mbeans-descriptors.xml
(original)
+++ tomcat/trunk/java/org/apache/catalina/mbeans/mbeans-descriptors.xml Wed Apr
14 12:07:04 2010
@@ -18,7 +18,7 @@
@@ -81,15 +81,6 @@
type="java.lang.String"/>
-
-
-
-
-
-
-
-
-
-
-
-
-
-
@@ -276,39 +249,6 @@
type="java.lang.String"/>
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14/04/2010 12:02, sebb wrote: > On 14/04/2010, Mark Thomas wrote: >> Please test this release candidate and provide feedback. > > Some bugs reported against Tomcat 7 may require API changes to fix. > Are API changes going to be possible once the RC has been released? Yes. I still have some Lifecycle changes that will require API changes as may the JMX GSOC project if that gets accepted. One of the things I intend to add to the release notes is a list of APIs that are considered public and fixed. At the moment that is: javax/**/*.class Anything under apache.org is open to change. Folks can use it, but it might change. It would only be an issue for folks working on custom components. As the release matures, we'll fix more of the API. There will , however, always remain some parts of the API that are viewed as internal and subject to change at any time. The idea is that we document this as we go and end up with a clearer definition. > If not, please consider at least reviewing the bugs before committing > to the API. I think it is fair to say that the API is fixed to the extent that we don't want to change it unless we have to. No point breaking backwards compatibility for no good reason. Historically, 'good reason' has equated to 'bug causing pain for user' and similar. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
On 14/04/2010, Mark Thomas wrote: > All, > > After the experience of the recent 6.0.x releases, I wanted to try an > alternative approach and use explicit release candidates for 7.0.x. I'm > expecting to tweak the release process as we go. > > The first Tomcat 7 release candiate is ready for testing. 7.0.0-RC1 can > be obtained from: > http://people.apache.org/~markt/dev/tomcat-7/v7.0.0-RC1/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_0_RC1/ > > Please test this release candidate and provide feedback. Some bugs reported against Tomcat 7 may require API changes to fix. Are API changes going to be possible once the RC has been released? If not, please consider at least reviewing the bugs before committing to the API. > Please run all of your tests against this candidate and report all > failures. I'd like to avoid the test, stop at first failure, new RC, > test, stop at first failure, new RC etc. cycle. > > And now for the important part: > > The 7.0.0-RC1 tag is > [ ] Broken - do not release > [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 > [ ] Beta - go ahead and release 7.0.0 Beta based on 7.0.0-RC1 > [ ] Stable - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 > > The following issues were noted: > - > > > Thanks, > > Mark > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Need help in setting up virtual url for tomcat 5
us...@tomcat.apache.org On Wed, Apr 14, 2010 at 12:42 PM, Vivek Kanchan wrote: > please give me the id.. > thanks > > > -Original Message- > From: Mark Thomas [mailto:ma...@apache.org] > Sent: Wednesday, April 14, 2010 4:02 PM > To: Tomcat Developers List > Subject: Re: Need help in setting up virtual url for tomcat 5 > > > On 14/04/2010 11:29, Vivek Kanchan wrote: > > HI, > > > > I have setup tomcat 5 for a customer, now i need to use virtual url and > por= > > t > > t other than 8080 , please let me know how to do it , what files to > change = > > for these. > > Please use the Tomcat users mailing list. > > Mark > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > -- Sincerely yours and Best Regards, Xie Xiaodong
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
On 14/04/2010, Mark Thomas wrote:
> On 13/04/2010 17:48, Filip Hanik - Dev Lists wrote:
> > This makes zero sense and I would do a -1 on this commit and the bug in
> > general.
> > What effectively has happened here is that there has been a public API
> > change without any justification.
> >
> > Since this is a mutable field, you've now made it non mutable. and in
> > there lies the change.
>
>
> Fair point. I'll remove the final but make it volatile to avoid any
> threading issues.
Sorry to go on about this, but AFAICT volatile does not really help here.
The boolean is not used for communication between threads, it is used
as a configuration option.
If two different threads want two different values then there is a
conflict. If there is never any need to change the value, then there
is no need for volatile.
Is the current API really immutable at this stage?
> Mark
>
>
> >
> > Filip
> >
> > On 04/12/2010 12:59 PM, sebb wrote:
> >> On 12/04/2010, Mark Thomas wrote:
> >>
> >>> On 12/04/2010 11:53, Tim Funk wrote:
> >>> > This seems like an odd thing to make a constant. (Is something else
> >>> > setting this or was there an intention for this to be set?
> >>> Especially
> >>> > since it is used only once in this file)
> >>>
> >>>
> >>> It isn't entirely clear. I suspect it was going to be made configurable
> >>> at start-up at some point. The naming convention implies constant.
> >>> If it
> >>> is ever made configurable, the final can be removed if required.
> >>>
> >> This was done to fix:
> >>
> >> https://issues.apache.org/bugzilla/show_bug.cgi?id=49089
> >>
> >> If it is ever made mutable, please consider making it a private
> >> instance variable instead of a thread-hostile mutable static.
> >>
> >>
> >>> Mark
> >>>
> >>>
> >>> >
> >>> > -Tim
> >>> >
> >>> > On 4/12/2010 5:35 AM, ma...@apache.org wrote:
> >>> >> Author: markt
> >>> >> Date: Mon Apr 12 09:35:52 2010
> >>> >> New Revision: 933165
> >>> >>
> >>> >> URL: http://svn.apache.org/viewvc?rev=933165&view=rev
> >>> >> Log:
> >>> >> Make public constant final
> >>> >>
> >>> >> Modified:
> >>> >>
> >>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >>> >>
> >>> >> Modified:
> >>> >> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >>> >> URL:
> >>> >>
> >>>
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
> >>>
> >>> >>
> >>> >>
> >>>
> ==
> >>>
> >>> >>
> >>> >> ---
> >>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >>> >> (original)
> >>> >> +++
> >>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
> >>> >> Mon Apr 12 09:35:52 2010
> >>> >> @@ -38,7 +38,7 @@ import java.sql.Timestamp;
> >>> >>public class ChannelData implements ChannelMessage {
> >>> >>public static final ChannelData[] EMPTY_DATA_ARRAY = new
> >>> >> ChannelData[0];
> >>> >>
> >>> >> -public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
> >>> >> +public static final boolean USE_SECURE_RANDOM_FOR_UUID =
> >>> false;
> >>> >>
> >>> >>/**
> >>> >> * The options this message was sent with
> >>> >
> >>> >
> >>> -
> >>> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >>> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>> >
> >>>
> >>>
> >>>
> >>>
> >>> -
> >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >>> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>>
> >>>
> >>>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >>
> >>
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: Need help in setting up virtual url for tomcat 5
please give me the id.. thanks -Original Message- From: Mark Thomas [mailto:ma...@apache.org] Sent: Wednesday, April 14, 2010 4:02 PM To: Tomcat Developers List Subject: Re: Need help in setting up virtual url for tomcat 5 On 14/04/2010 11:29, Vivek Kanchan wrote: > HI, > > I have setup tomcat 5 for a customer, now i need to use virtual url and por= > t > t other than 8080 , please let me know how to do it , what files to change = > for these. Please use the Tomcat users mailing list. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC1
All, After the experience of the recent 6.0.x releases, I wanted to try an alternative approach and use explicit release candidates for 7.0.x. I'm expecting to tweak the release process as we go. The first Tomcat 7 release candiate is ready for testing. 7.0.0-RC1 can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.0-RC1/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_0_RC1/ Please test this release candidate and provide feedback. Please run all of your tests against this candidate and report all failures. I'd like to avoid the test, stop at first failure, new RC, test, stop at first failure, new RC etc. cycle. And now for the important part: The 7.0.0-RC1 tag is [ ] Broken - do not release [ ] Alpha - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 [ ] Beta - go ahead and release 7.0.0 Beta based on 7.0.0-RC1 [ ] Stable - go ahead and release 7.0.0 Stable based on 7.0.0-RC1 The following issues were noted: - Thanks, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Need help in setting up virtual url for tomcat 5
On 14/04/2010 11:29, Vivek Kanchan wrote: > HI, > > I have setup tomcat 5 for a customer, now i need to use virtual url and por= > t > t other than 8080 , please let me know how to do it , what files to change = > for these. Please use the Tomcat users mailing list. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Need help in setting up virtual url for tomcat 5
HI, I have setup tomcat 5 for a customer, now i need to use virtual url and por= t t other than 8080 , please let me know how to do it , what files to change = for these. Thanks, Vivyek kanchan - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49120] gc new capacity of JVM is gradually reducing when webapp(tomcat) started
https://issues.apache.org/bugzilla/show_bug.cgi?id=49120 Pid changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Pid 2010-04-14 06:28:09 EDT --- Subscribe to the Tomcat Users mailing list and ask your question there. http://tomcat.apache.org/lists.html Bugzilla is not intended for reporting peoples' web application bugs - this bug will just get closed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49120] New: gc new capacity of JVM is gradually reducing when webapp(tomcat) started
https://issues.apache.org/bugzilla/show_bug.cgi?id=49120 Summary: gc new capacity of JVM is gradually reducing when webapp(tomcat) started Product: Tomcat 5 Version: 5.5.13 Platform: Sun OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Webapps:Manager AssignedTo: dev@tomcat.apache.org ReportedBy: ses...@gmail.com hi,all there is a problem with my webapp. by manual configuration, i allocated 1G(1024M) memory for webapp. where the gc new capacity automatically is 262M, the gc old capacity automatically is 699M, S0/S1 automatically is 43.6M/43.6M. When my webapp is started, I use the jvm's own tools(jstat) to trace the garbage collections. when the 6th Young garbage collection has happened, gc new capacity(262M) is gradually reducing. About 10 hours after, gc new capacity is only 40.6M. ##web operating environment: tomcat5.5.27 + Apache/2.2.3 + jdk1.5.0_13 + Linux_x86_64 ##blow is my manual configurations for tomcat JVM CATALINA_OPTS="-Xms1024M -Xmx1024M -Dorg.apache.jasper.compiler.Parser.STRICT_QUOTE_ESCAPING=false" ##Jstat Tracking data (unit/k) systemTime--- EC--- EU---OC---OU ---YGC 10:03:10 --- 262208--- 217735---699072---163.6---4 ##webpp startup 10:03:13 --- 262208--- 217735---699072---163.6---4 ... 10:11:35 --- 262208--- 261516---699072---163.6---5 ##5th YGC 10:11:38 --- 258688--- 4845.1---699072---163.6---6 ##6th YGC, EC is reduced. ... 10:18:41 --- 255232--- 4914 ---699072---163.6---7 ##7th YGC, EC is reduced. ... 18:34:43 --- 40832 --- 36858 ---699072---87896---380##380th YGC, EC is reduced. this problem has been troubling me. please help ! -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r933907 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Author: markt
Date: Wed Apr 14 10:14:34 2010
New Revision: 933907
URL: http://svn.apache.org/viewvc?rev=933907&view=rev
Log:
Alternative fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49089
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
Modified: tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933907&r1=933906&r2=933907&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java (original)
+++ tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java Wed Apr 14
10:14:34 2010
@@ -38,7 +38,7 @@ import java.sql.Timestamp;
public class ChannelData implements ChannelMessage {
public static final ChannelData[] EMPTY_DATA_ARRAY = new ChannelData[0];
-public static final boolean USE_SECURE_RANDOM_FOR_UUID = false;
+public static volatile boolean USE_SECURE_RANDOM_FOR_UUID = false;
/**
* The options this message was sent with
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r933165 - /tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
On 13/04/2010 17:48, Filip Hanik - Dev Lists wrote:
> This makes zero sense and I would do a -1 on this commit and the bug in
> general.
> What effectively has happened here is that there has been a public API
> change without any justification.
>
> Since this is a mutable field, you've now made it non mutable. and in
> there lies the change.
Fair point. I'll remove the final but make it volatile to avoid any
threading issues.
Mark
>
> Filip
>
> On 04/12/2010 12:59 PM, sebb wrote:
>> On 12/04/2010, Mark Thomas wrote:
>>
>>> On 12/04/2010 11:53, Tim Funk wrote:
>>> > This seems like an odd thing to make a constant. (Is something else
>>> > setting this or was there an intention for this to be set?
>>> Especially
>>> > since it is used only once in this file)
>>>
>>>
>>> It isn't entirely clear. I suspect it was going to be made configurable
>>> at start-up at some point. The naming convention implies constant.
>>> If it
>>> is ever made configurable, the final can be removed if required.
>>>
>> This was done to fix:
>>
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=49089
>>
>> If it is ever made mutable, please consider making it a private
>> instance variable instead of a thread-hostile mutable static.
>>
>>
>>> Mark
>>>
>>>
>>> >
>>> > -Tim
>>> >
>>> > On 4/12/2010 5:35 AM, ma...@apache.org wrote:
>>> >> Author: markt
>>> >> Date: Mon Apr 12 09:35:52 2010
>>> >> New Revision: 933165
>>> >>
>>> >> URL: http://svn.apache.org/viewvc?rev=933165&view=rev
>>> >> Log:
>>> >> Make public constant final
>>> >>
>>> >> Modified:
>>> >>
>>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>>> >>
>>> >> Modified:
>>> >> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>>> >> URL:
>>> >>
>>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java?rev=933165&r1=933164&r2=933165&view=diff
>>>
>>> >>
>>> >>
>>> ==
>>>
>>> >>
>>> >> ---
>>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>>> >> (original)
>>> >> +++
>>> tomcat/trunk/java/org/apache/catalina/tribes/io/ChannelData.java
>>> >> Mon Apr 12 09:35:52 2010
>>> >> @@ -38,7 +38,7 @@ import java.sql.Timestamp;
>>> >>public class ChannelData implements ChannelMessage {
>>> >>public static final ChannelData[] EMPTY_DATA_ARRAY = new
>>> >> ChannelData[0];
>>> >>
>>> >> -public static boolean USE_SECURE_RANDOM_FOR_UUID = false;
>>> >> +public static final boolean USE_SECURE_RANDOM_FOR_UUID =
>>> false;
>>> >>
>>> >>/**
>>> >> * The options this message was sent with
>>> >
>>> >
>>> -
>>> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> > For additional commands, e-mail: dev-h...@tomcat.apache.org
>>> >
>>>
>>>
>>>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>>
>>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49118] New: Inefficient use of String concatenation in loop
https://issues.apache.org/bugzilla/show_bug.cgi?id=49118 Summary: Inefficient use of String concatenation in loop Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Created an attachment (id=25293) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25293) Patch to use StringBuilder instead of +=String HttpServlet toTrace method concatenates Strings in a loop; this is very inefficient. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r933881 - /tomcat/trunk/java/org/apache/catalina/session/StandardManager.java
On 04/14/2010 10:48 AM, kfuj...@apache.org wrote: Author: kfujino Modified: tomcat/trunk/java/org/apache/catalina/session/StandardManager.java +session.expire(); +} sessionCounter++; Seems we are using the sessionCounter as well as expiredSessions just for the information purposes. Think they should be declared as long instead of int cause those values never gets reset and can only grow, eventually reaching the MAX_INT and going to negative values. Given that Tomcat can survive long enough to generate +2 billion sessions at the first place :) Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 43642] Add prestartminSpareThreads attribute for Executor
https://issues.apache.org/bugzilla/show_bug.cgi?id=43642 Ruediger Pluem changed: What|Removed |Added Attachment #25291|Patch against Tomcat trunk |Patch against Tomcat 6.0 description||trunk -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 43642] Add prestartminSpareThreads attribute for Executor
https://issues.apache.org/bugzilla/show_bug.cgi?id=43642 --- Comment #5 from Ruediger Pluem 2010-04-14 05:15:01 EDT --- Created an attachment (id=25292) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25292) Patch against Tomcat trunk -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 43642] Add prestartminSpareThreads attribute for Executor
https://issues.apache.org/bugzilla/show_bug.cgi?id=43642 --- Comment #4 from Ruediger Pluem 2010-04-14 05:14:34 EDT --- Created an attachment (id=25291) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25291) Patch against Tomcat trunk -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49116] Memory leak by HttpSession.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49116 --- Comment #2 from Keiichi Fujino 2010-04-14 04:57:53 EDT --- Fixed in trunk and proposed for 6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
