Re: NamingContext Possible Bug
For reference, the EE 6 platform spec explains that usually a new instance
should be returned on each lookup in section 5.2.4 page 67 Sharing of
Environment Entries. The servlet 3.0 spec section 15.2.2 page 174 indicates
that this applies to servlet containers that are part of an EE
technology-compliant implementation. I guess this means that unless tomcat
implements web profile they don't have to support this? It still seems like a
good idea to me.
thanks
david jencks
On Sep 22, 2010, at 10:36 PM, Gurkan Erdogdu wrote:
Hello,
I want to bring this question again.
Why do we change NamingEntry type from REFERENCE to ENTRY? I think that each
lookup must return a new instance. But in this case, it returns the same
bound
object instance.
Let's says that we have a Servlet
MyServlet{
private @Resource(name=MyResource) myResource;
...
public blabla(){
new InitialContext().lookup(myResource);
}
}
myResource has injected by the container before @PostConstruct is called.
After
that I would like to get a new resource object in blabla() method. It returns
the same injected resource instance instead of creating a new resource.
I think that it must return a different instance from myResource. JNDI tree
of
the Servlet contains MyResource/ResourceRef binding. Therefore each lookup
to
MyResource must return a ResourceRef. Becuase it is a reference, context
must call NamingManager.getObjectInstance again to create a new instance.
If this is a bug, I will open an issue.
Thanks;
--Gurkan
- Original Message
From: Gurkan Erdogdu gurkanerdo...@yahoo.com
To: dev@tomcat.apache.org
Sent: Tue, September 21, 2010 6:30:43 PM
Subject: NamingContext Possible Bug
Hello folks,
In NamingContext implementation, if lookup() is a Reference, current
implementation caches the result of the NamingManager # getObjectInstance via
following statements and changes the type of the entry. In the following
lookups, same object is returned. I would like to write ObjectFactory that
returns new instance for each time lookup is called on its reference. But
with
the current implementation, it is not possible to write such an object
factory
because of aferomentioned sitaution. I think that entry must be stay as
Reference instead of changing entry type.
WDYT?
NamingContext class:
protected Object lookup(Name name, boolean resolveLinks)
throws NamingException {
.
} else if (entry.type == NamingEntry.REFERENCE) {
try {
Object obj = NamingManager.getObjectInstance
(entry.value, name, this, env);
if (obj != null) {
entry.value = obj;
entry.type = NamingEntry.ENTRY; --- CHANGES type of
the naming entry
}
return obj;
} catch (NamingException e) {
throw e;
} catch (Exception e) {
log.warn(sm.getString
(namingContext.failResolvingReference), e);
throw new NamingException(e.getMessage());
}
}
...
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[g...@vmgump]: Project tomcat-tc6 (in module tomcat-tc6) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc6 has an issue affecting its community integration. This issue affects 4 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - javax.el : Java Servlet 2.5 Server Pages JSP 2.1 implementation (for ... - javax.servlet : Java Servlet 2.5 Server Pages JSP 2.1 implementation (for ... - javax.servlet.jsp : Java Servlet 2.5 Server Pages JSP 2.1 implementation (for ... - tomcat-tc6 : Java Servlet 2.5 Server Pages JSP 2.1 implementation (for ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.jsvc.tar.gz. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -INFO- Failed with reason build failed -DEBUG- Extracted fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6/gump_work/build_tomcat-tc6_tomcat-tc6.html Work Name: build_tomcat-tc6_tomcat-tc6 (Type: Build) Work ended in a state of : Failed Elapsed: 43 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-23092010-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/tomcat-tc6/BUILDING.txt -Dcommons-daemon.jsvc.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-23092010-native-src.tar.gz -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-23092010.jar -Djasper-jdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-logging-api.jar=/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-23092010.jar -Djavax.sql.DataSource.Factory=org.apache.commons.dbcp.BasicDataSourceFactory -Dtomcat-dbcp.jar=/srv/gump/public/workspace/apache-commons/dbcp/dist/commons-dbcp.jar [Working Directory: /srv/gump/public/workspace/tomcat-tc6] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-tc6/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/packages/junit3.8.1/junit.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/junit/dist/junit-23092010.jar:/srv/gump/public/workspace/junit/dist/junit-dep-23092010.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-23092010.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jd t.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/apache-commons/dbcp/dist/commons-dbcp.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-23092010.jar - [xslt] Processing /srv/gump/public/workspace/tomcat-tc6/webapps/docs/config/resources.xml to /srv/gump/public/workspace/tomcat-tc6/output/build/webapps/docs/config/resources.html [xslt] Processing /srv/gump/public/workspace/tomcat-tc6/webapps/docs/config/server.xml to /srv/gump/public/workspace/tomcat-tc6/output/build/webapps/docs/config/server.html [xslt] Processing /srv/gump/public/workspace/tomcat-tc6/webapps/docs/config/service.xml to /srv/gump/public/workspace/tomcat-tc6/output/build/webapps/docs/config/service.html [xslt] Processing /srv/gump/public/workspace/tomcat-tc6/webapps/docs/config/systemprops.xml to /srv/gump/public/workspace/tomcat-tc6/output/build/webapps/docs/config/systemprops.html [xslt] Processing /srv/gump/public/workspace/tomcat-tc6/webapps/docs/config/valve.xml to /srv/gump/public/workspace/tomcat-tc6/output/build/webapps/docs/config/valve.html [xslt] Transforming into /srv/gump/public/workspace/tomcat-tc6/output/build/webapps/docs/architecture [xslt] Processing
DO NOT REPLY [Bug 49972] Double-check idiom. Possible data-race.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49972 --- Comment #8 from Kostya Serebryany konstantin.s.serebry...@gmail.com 2010-09-23 04:03:35 EDT --- If there were no possibility of an exception, your statement would be true. I am not sure about this particular case, but in general a compiler (JIT) may statically figure out that an exception will never be thrown and eliminate the exception handling code completely -- and then shuffle the code in arbitrary way. I don't think that 'this code may throw exception' may be used as synchronization. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49979] SimpleDateFormat StringIndexOutOfBoundsException
https://issues.apache.org/bugzilla/show_bug.cgi?id=49979 --- Comment #1 from Pid pids...@apache.org 2010-09-23 06:14:03 EDT --- OS: CentOS5 Tomcat ver.: 6.0.20 requests are coming from Windows XP/IE6 SP3 Which JVM version are you using? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1000391 - /tomcat/trunk/build.xml
Author: timw
Date: Thu Sep 23 10:14:54 2010
New Revision: 1000391
URL: http://svn.apache.org/viewvc?rev=1000391view=rev
Log:
Adding a description for build-docs task
Modified:
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1000391r1=1000390r2=1000391view=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Thu Sep 23 10:14:54 2010
@@ -599,7 +599,7 @@
/target
- target name=build-docs
+ target name=build-docs description=Builds all documentation from XML
sources
copy todir=${tomcat.build}/webapps
fileset dir=webapps
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
Author: timw
Date: Thu Sep 23 10:15:16 2010
New Revision: 1000392
URL: http://svn.apache.org/viewvc?rev=1000392view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=49955
Improvements and corrections for the Building Tomcat guide, plus
sample Eclipse launch targets.
Based on contribution from Wesley Acheson.
Added:
tomcat/trunk/Start Tomcat.launch
tomcat/trunk/Stop Tomcat.launch
Modified:
tomcat/trunk/webapps/docs/building.xml
tomcat/trunk/webapps/docs/changelog.xml
Added: tomcat/trunk/Start Tomcat.launch
URL:
http://svn.apache.org/viewvc/tomcat/trunk/Start%20Tomcat.launch?rev=1000392view=auto
==
--- tomcat/trunk/Start Tomcat.launch (added)
+++ tomcat/trunk/Start Tomcat.launch Thu Sep 23 10:15:16 2010
@@ -0,0 +1,13 @@
+?xml version=1.0 encoding=UTF-8 standalone=no?
+launchConfiguration type=org.eclipse.jdt.launching.localJavaApplication
+listAttribute key=org.eclipse.debug.core.MAPPED_RESOURCE_PATHS
+listEntry
value=/tomcat-7.0.x/java/org/apache/catalina/startup/Bootstrap.java/
+/listAttribute
+listAttribute key=org.eclipse.debug.core.MAPPED_RESOURCE_TYPES
+listEntry value=1/
+/listAttribute
+stringAttribute key=org.eclipse.jdt.launching.MAIN_TYPE
value=org.apache.catalina.startup.Bootstrap/
+stringAttribute key=org.eclipse.jdt.launching.PROGRAM_ARGUMENTS
value=start/
+stringAttribute key=org.eclipse.jdt.launching.PROJECT_ATTR
value=tomcat-7.0.x/
+stringAttribute key=org.eclipse.jdt.launching.VM_ARGUMENTS
value=-Dcatalina.home=${project_loc:/tomcat-7.0.x/java/org/apache/catalina/startup/Bootstrap.java}/
+/launchConfiguration
Added: tomcat/trunk/Stop Tomcat.launch
URL:
http://svn.apache.org/viewvc/tomcat/trunk/Stop%20Tomcat.launch?rev=1000392view=auto
==
--- tomcat/trunk/Stop Tomcat.launch (added)
+++ tomcat/trunk/Stop Tomcat.launch Thu Sep 23 10:15:16 2010
@@ -0,0 +1,13 @@
+?xml version=1.0 encoding=UTF-8 standalone=no?
+launchConfiguration type=org.eclipse.jdt.launching.localJavaApplication
+listAttribute key=org.eclipse.debug.core.MAPPED_RESOURCE_PATHS
+listEntry
value=/tomcat-7.0.x/java/org/apache/catalina/startup/Bootstrap.java/
+/listAttribute
+listAttribute key=org.eclipse.debug.core.MAPPED_RESOURCE_TYPES
+listEntry value=1/
+/listAttribute
+stringAttribute key=org.eclipse.jdt.launching.MAIN_TYPE
value=org.apache.catalina.startup.Bootstrap/
+stringAttribute key=org.eclipse.jdt.launching.PROGRAM_ARGUMENTS
value=stop/
+stringAttribute key=org.eclipse.jdt.launching.PROJECT_ATTR
value=tomcat-7.0.x/
+stringAttribute key=org.eclipse.jdt.launching.VM_ARGUMENTS
value=-Dcatalina.home=${project_loc:/tomcat-7.0.x/java/org/apache/catalina/startup/Bootstrap.java}/
+/launchConfiguration
Modified: tomcat/trunk/webapps/docs/building.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/building.xml?rev=1000392r1=1000391r2=1000392view=diff
==
--- tomcat/trunk/webapps/docs/building.xml (original)
+++ tomcat/trunk/webapps/docs/building.xml Thu Sep 23 10:15:16 2010
@@ -23,7 +23,7 @@
project;
properties
- authorRemy Maucherat/author
+ authorRemy Maucherat, Tim Whittington/author
titleBuilding Tomcat/title
/properties
@@ -36,16 +36,17 @@
section name=Introduction
p
-Building Apache Tomcat from SVN is very easy, and is the first step to
contributing to
-Tomcat. The following is a step by step TODO list.
+Building Apache Tomcat from source is very easy, and is the first step to
contributing to
+Tomcat. The following is a step by step guide.
/p
/section
-section name=Download a Java Development Kit (JDK) release (version 1.6.x or
later)
+section name=Download a Java Development Kit (JDK) 1.6 or later
p
-The Sun JDK can be downloaded
+Tomcat requires a JDK (version 1.6 or later) to be installed.
+br/The Sun JDK can be downloaded
a
href=http://www.oracle.com/technetwork/java/javase/downloads/index.html;here/a.
/p
@@ -66,15 +67,15 @@ Download a binary distribution of Ant 1.
p
Unpack the binary distribution into a convenient location so that the
Ant release resides in its own directory (conventionally named
-apache-ant-1.8.x). For the purposes of the remainder of this document,
-the symbolic name ${ant.home} is used to refer to the full pathname of
- the release directory.
+codeapache-ant-1.8.x/code). For the remainder of this guide,
+the symbolic name code${ant.home}/code is used to refer to the full
pathname of
+ the Ant installation directory directory.
/p
p
-Create an ANT_HOME environment variable to point the directory ${ant.home},
+bIMPORTANT/b: Create an ANT_HOME environment variable to point the
directory code${ant.home}/code,
and modify the PATH environment variable to include directory
-${ant.home}/bin in its list. This makes the ant command line script
DO NOT REPLY [Bug 49955] Building instructions incorrect.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49955 Tim Whittington t...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Tim Whittington t...@apache.org 2010-09-23 06:18:28 EDT --- Guide updated and improved for 7.0 based on your patch, with some modifications. Updated guide will hit the website soon. Thanks for the contribution. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1000400 - in /tomcat/trunk/java/org/apache/coyote/ajp: AjpAprProcessor.java AjpProcessor.java Constants.java
Author: timw
Date: Thu Sep 23 10:38:56 2010
New Revision: 1000400
URL: http://svn.apache.org/viewvc?rev=1000400view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=49102
Protecting AJP code - header/method lookup arrays with getters.
No measurable slowdown (especially after a profiling JIT gets done with it).
Modified:
tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
tomcat/trunk/java/org/apache/coyote/ajp/Constants.java
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java?rev=1000400r1=1000399r2=1000400view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProcessor.java Thu Sep 23
10:38:56 2010
@@ -713,7 +713,7 @@ public class AjpAprProcessor implements
// Translate the HTTP method code to a String.
byte methodCode = requestHeaderMessage.getByte();
if (methodCode != Constants.SC_M_JK_STORED) {
-String methodName = Constants.methodTransArray[methodCode - 1];
+String methodName = Constants.getMethodForCode(methodCode - 1);
request.method().setString(methodName);
}
@@ -747,7 +747,7 @@ public class AjpAprProcessor implements
isc = 0xFF00;
if(0xA000 == isc) {
requestHeaderMessage.getInt(); // To advance the read position
-hName = Constants.headerTransArray[hId - 1];
+hName = Constants.getHeaderForCode(hId - 1);
vMB = headers.addValue(hName);
} else {
// reset hId -- if the header currently being read
Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java?rev=1000400r1=1000399r2=1000400view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java Thu Sep 23
10:38:56 2010
@@ -719,7 +719,7 @@ public class AjpProcessor implements Act
// Translate the HTTP method code to a String.
byte methodCode = requestHeaderMessage.getByte();
if (methodCode != Constants.SC_M_JK_STORED) {
-String methodName = Constants.methodTransArray[methodCode - 1];
+String methodName = Constants.getMethodForCode(methodCode - 1);
request.method().setString(methodName);
}
@@ -753,7 +753,7 @@ public class AjpProcessor implements Act
isc = 0xFF00;
if(0xA000 == isc) {
requestHeaderMessage.getInt(); // To advance the read position
-hName = Constants.headerTransArray[hId - 1];
+hName = Constants.getHeaderForCode(hId - 1);
vMB = headers.addValue(hName);
} else {
// reset hId -- if the header currently being read
Modified: tomcat/trunk/java/org/apache/coyote/ajp/Constants.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/Constants.java?rev=1000400r1=1000399r2=1000400view=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/Constants.java (original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/Constants.java Thu Sep 23 10:38:56
2010
@@ -120,7 +120,7 @@ public final class Constants {
public static final int MAX_SEND_SIZE = MAX_PACKET_SIZE - SEND_HEAD_LEN;
// Translates integer codes to names of HTTP methods
-public static final String []methodTransArray = {
+private static final String [] methodTransArray = {
OPTIONS,
GET,
HEAD,
@@ -149,6 +149,16 @@ public final class Constants {
BASELINE-CONTROL,
MKACTIVITY
};
+
+/**
+ * Converts an AJP coded HTTP method to the method name.
+ * @param code the coded value
+ * @return the string value of the method
+ */
+ public static final String getMethodForCode(final int code) {
+ return methodTransArray[code];
+ }
+
public static final int SC_M_JK_STORED = (byte) 0xFF;
// id's for common request headers
@@ -170,7 +180,7 @@ public final class Constants {
public static final byte SC_A_SSL_KEY_SIZE = 11; // XXX ???
// Translates integer codes to request header names
-public static final String []headerTransArray = {
+private static final String [] headerTransArray = {
accept,
accept-charset,
accept-encoding,
@@ -187,8 +197,17 @@ public final class Constants {
user-agent
DO NOT REPLY [Bug 49102] coyote.ajp.Constants - 3 constant arrays are mutable
https://issues.apache.org/bugzilla/show_bug.cgi?id=49102 Tim Whittington t...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #3 from Tim Whittington t...@apache.org 2010-09-23 06:42:29 EDT --- Fixed in trunk by protecting the lookups with static final getters. Slowdown is negligible on a micro-benchmark with 1 billion executions, so there should be no performance hit. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49591] Custom error page always uses Transfer-Encoding: chunked
https://issues.apache.org/bugzilla/show_bug.cgi?id=49591 Tim Whittington t...@apache.org changed: What|Removed |Added Priority|P2 |P5 --- Comment #1 from Tim Whittington t...@apache.org 2010-09-23 07:13:23 EDT --- The only way to fix this is to call Response.finishResponse() after sending of the error page, or to remove the flushBuffer() call. The former seems dubious, and the latter means that we wouldn't be flushing the error response (headers and data) as soon as possible, which is probably desirable. Chunked encoding isn't itself an issue, so for the sake of optimising small error pages I'm leaning towards WONTFIX on this one. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49591] Custom error page always uses Transfer-Encoding: chunked
https://issues.apache.org/bugzilla/show_bug.cgi?id=49591 Tim Whittington t...@apache.org changed: What|Removed |Added Priority|P5 |P4 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48870] avoid parallel arrays of base types
https://issues.apache.org/bugzilla/show_bug.cgi?id=48870 Tim Whittington t...@apache.org changed: What|Removed |Added Priority|P2 |P4 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of Tomcat_and_IIS_Howto by LiamLeane
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Tomcat Wiki for change
notification.
The Tomcat_and_IIS_Howto page has been changed by LiamLeane.
The comment on this change is: Added permissions and IIS7 howto.
http://wiki.apache.org/tomcat/Tomcat_and_IIS_Howto?action=diffrev1=13rev2=14
--
+ === Permissions ===
+ The official documentation lacks a few important bits around file permissions
that must be set if the application pool identity the connector is running
under does not have global permissions to the servers file system:
+
+ * The directory with your isapi_redirect.dll and associated .properties
files must be at least read only to the application pool identity account
+ * If you have logging enabled for the filter then the application pool
identity must have read write access to the log file
+ * If you use the registry for the configuration then the application pool
identity must have read access to the keys If you miss any of the above then
the filter simply will not work and you will not receive any form of error
messages to tell you it has not worked.
+
+ === Windows 2008 / IIS 7 Step by Step ===
+ The following steps detail setting up IIS to function correctly with the
connector, it assumes you have already completed the .properties or registry
configuration:
+
+ '''Allow ISAPI Filter to run:'''
+
+ * In the IIS Manager console select the computer node
+ * Open the ISAPI and CGI restrictions panel
+ * Click the Add button
+ * Under ISAPI or CGI path enter the full path to the Connector ISAPI dll
+ * Under Description add something meaningful such as Tomcat
+ * Check Allow extension path to execute
+ * Click Ok
+
+ '''Enable ISAPI Filter for individual sites:'''
+
+ * In the IIS Manager console open the computer node and select the website
to add the ISAPI filter to
+ * Right click on the website node and add a new virtual directory pointing
to the directory containing the dll and associated .properties files
+ * Open the ISAPI Filters panel
+ * Click the Add button
+ * Under Filter Name add something meaningful such as Tomcat
+ * Under Executable enter the full path to the Connector ISAPI dll
+ * Click Ok
+
+ If you are using the website for hosting other technologies (such as asp.net)
the order of execution for the filters may have to be changed for everything
to work as expected. In order to do this click View Ordered List in the
ISAPI Filters panel for a website and then use the Move Up and Move Down
buttons to reorganise the execution order. If you would like asp.net to handle
cases such as 404's then the Tomcat filter should appear BEFORE those for
.net. If you are using specialist authentication filters (such as CA
SiteMinder) then these should appear before Tomcat so that requests are
correctly authenticated prior to being received by the connector.
+
+ === Setup ===
Configuring Tomcat and IIS is documented at
[[http://tomcat.apache.org/connectors-doc/webserver_howto/iis.html|the IIS
Howto page]] . The instructions there work fine, but there is a
[[http://archive.apache.org/dist/tomcat/tomcat-connectors/jk/binaries/win32/jk-1.2.15/isapi_redirect.msi|setup
program]] which allows you to skip steps 1 through 7 in the Configuring the
ISAPI Redirector section of this page. Also, step 8 can be done using a
VBScript file like this:
{{{
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49955] Building instructions incorrect.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49955 Wesley wesley.ache...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED | --- Comment #2 from Wesley wesley.ache...@gmail.com 2010-09-23 07:41:20 EDT --- (In reply to comment #1) Guide updated and improved for 7.0 based on your patch, with some modifications. Updated guide will hit the website soon. Thanks for the contribution. I'd have created the .launch files if you wanted. Looking at the svn commit I think there is still an error though. +br/If you want to configure these yourself (or are using a different IDE) +then use codeorg.apache.catalina.startup.Catalina/code as the main class, +codestart/code/codestop/code as program arguments, and specify code-Dcatalina.home=.../code +(with the name of your build directory) as VM arguments. AFAIK org.apache.catalina.startup.Catalina no longer has a main method. I think this should be org.apache.catalina.startup.Bootstrap as it is in the two launch files. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
Put a comment in the main bug but I don't know if people see that. The
main class below appears to be wrong. Its now
org.apache.catalina.startup.Bootstrap
On Thu, Sep 23, 2010 at 12:15 PM, t...@apache.org wrote:
Author: timw
Date: Thu Sep 23 10:15:16 2010
New Revision: 1000392
URL: http://svn.apache.org/viewvc?rev=1000392view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=49955
Improvements and corrections for the Building Tomcat guide, plus
sample Eclipse launch targets.
Based on contribution from Wesley Acheson.
Added:
tomcat/trunk/Start Tomcat.launch
tomcat/trunk/Stop Tomcat.launch
Modified:
tomcat/trunk/webapps/docs/building.xml
tomcat/trunk/webapps/docs/changelog.xml
Added: tomcat/trunk/Start Tomcat.launch
URL:
http://svn.apache.org/viewvc/tomcat/trunk/Start%20Tomcat.launch?rev=1000392view=auto
==
--- tomcat/trunk/Start Tomcat.launch (added)
+++ tomcat/trunk/Start Tomcat.launch Thu Sep 23 10:15:16 2010
@@ -0,0 +1,13 @@
+?xml version=1.0 encoding=UTF-8 standalone=no?
+launchConfiguration type=org.eclipse.jdt.launching.localJavaApplication
+listAttribute key=org.eclipse.debug.core.MAPPED_RESOURCE_PATHS
+listEntry
value=/tomcat-7.0.x/java/org/apache/catalina/startup/Bootstrap.java/
+/listAttribute
+listAttribute key=org.eclipse.debug.core.MAPPED_RESOURCE_TYPES
+listEntry value=1/
+/listAttribute
+stringAttribute key=org.eclipse.jdt.launching.MAIN_TYPE
value=org.apache.catalina.startup.Bootstrap/
+stringAttribute key=org.eclipse.jdt.launching.PROGRAM_ARGUMENTS
value=start/
+stringAttribute key=org.eclipse.jdt.launching.PROJECT_ATTR
value=tomcat-7.0.x/
+stringAttribute key=org.eclipse.jdt.launching.VM_ARGUMENTS
value=-Dcatalina.home=${project_loc:/tomcat-7.0.x/java/org/apache/catalina/startup/Bootstrap.java}/
+/launchConfiguration
Added: tomcat/trunk/Stop Tomcat.launch
URL:
http://svn.apache.org/viewvc/tomcat/trunk/Stop%20Tomcat.launch?rev=1000392view=auto
==
--- tomcat/trunk/Stop Tomcat.launch (added)
+++ tomcat/trunk/Stop Tomcat.launch Thu Sep 23 10:15:16 2010
@@ -0,0 +1,13 @@
+?xml version=1.0 encoding=UTF-8 standalone=no?
+launchConfiguration type=org.eclipse.jdt.launching.localJavaApplication
+listAttribute key=org.eclipse.debug.core.MAPPED_RESOURCE_PATHS
+listEntry
value=/tomcat-7.0.x/java/org/apache/catalina/startup/Bootstrap.java/
+/listAttribute
+listAttribute key=org.eclipse.debug.core.MAPPED_RESOURCE_TYPES
+listEntry value=1/
+/listAttribute
+stringAttribute key=org.eclipse.jdt.launching.MAIN_TYPE
value=org.apache.catalina.startup.Bootstrap/
+stringAttribute key=org.eclipse.jdt.launching.PROGRAM_ARGUMENTS
value=stop/
+stringAttribute key=org.eclipse.jdt.launching.PROJECT_ATTR
value=tomcat-7.0.x/
+stringAttribute key=org.eclipse.jdt.launching.VM_ARGUMENTS
value=-Dcatalina.home=${project_loc:/tomcat-7.0.x/java/org/apache/catalina/startup/Bootstrap.java}/
+/launchConfiguration
Modified: tomcat/trunk/webapps/docs/building.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/building.xml?rev=1000392r1=1000391r2=1000392view=diff
==
--- tomcat/trunk/webapps/docs/building.xml (original)
+++ tomcat/trunk/webapps/docs/building.xml Thu Sep 23 10:15:16 2010
@@ -23,7 +23,7 @@
project;
properties
- authorRemy Maucherat/author
+ authorRemy Maucherat, Tim Whittington/author
titleBuilding Tomcat/title
/properties
@@ -36,16 +36,17 @@
section name=Introduction
p
-Building Apache Tomcat from SVN is very easy, and is the first step to
contributing to
-Tomcat. The following is a step by step TODO list.
+Building Apache Tomcat from source is very easy, and is the first step to
contributing to
+Tomcat. The following is a step by step guide.
/p
/section
-section name=Download a Java Development Kit (JDK) release (version 1.6.x
or later)
+section name=Download a Java Development Kit (JDK) 1.6 or later
p
-The Sun JDK can be downloaded
+Tomcat requires a JDK (version 1.6 or later) to be installed.
+br/The Sun JDK can be downloaded
a
href=http://www.oracle.com/technetwork/java/javase/downloads/index.html;here/a.
/p
@@ -66,15 +67,15 @@ Download a binary distribution of Ant 1.
p
Unpack the binary distribution into a convenient location so that the
Ant release resides in its own directory (conventionally named
-apache-ant-1.8.x). For the purposes of the remainder of this document,
-the symbolic name ${ant.home} is used to refer to the full pathname of
- the release directory.
+codeapache-ant-1.8.x/code). For the remainder of this guide,
+the symbolic name code${ant.home}/code is used to refer to the full
pathname of
+ the Ant installation directory directory.
/p
p
-Create an
DO NOT REPLY [Bug 49102] coyote.ajp.Constants - 3 constant arrays are mutable
https://issues.apache.org/bugzilla/show_bug.cgi?id=49102 --- Comment #4 from Sebb s...@apache.org 2010-09-23 08:08:00 EDT --- Thanks! Useful to know that the getter method is efficient. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1000423 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch build.xml
Author: kkolinko Date: Thu Sep 23 12:15:56 2010 New Revision: 1000423 URL: http://svn.apache.org/viewvc?rev=1000423view=rev Log: Take care of line endings for the two files added in r1000392 Modified: tomcat/trunk/Start Tomcat.launch (props changed) tomcat/trunk/Stop Tomcat.launch (props changed) tomcat/trunk/build.xml Propchange: tomcat/trunk/Start Tomcat.launch -- svn:eol-style = native Propchange: tomcat/trunk/Stop Tomcat.launch -- svn:eol-style = native Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1000423r1=1000422r2=1000423view=diff == --- tomcat/trunk/build.xml (original) +++ tomcat/trunk/build.xml Thu Sep 23 12:15:56 2010 @@ -206,6 +206,7 @@ include name=**/*.jsp/ include name=**/*.jspf/ include name=**/*.jspx/ +include name=**/*.launch/ include name=**/*.license/ include name=**/*.manifest/ include name=**/*.mdl/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49955] Building instructions incorrect.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49955 Wesley wesley.ache...@gmail.com changed: What|Removed |Added Platform|PC |All OS/Version|Windows Vista |All -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1000433 - /tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
Author: kkolinko
Date: Thu Sep 23 12:46:50 2010
New Revision: 1000433
URL: http://svn.apache.org/viewvc?rev=1000433view=rev
Log:
Add a comment.
I guess it is too late to change it now, as the code is more than 3 years old.
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
Modified:
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java?rev=1000433r1=1000432r2=1000433view=diff
==
---
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
Thu Sep 23 12:46:50 2010
@@ -144,6 +144,7 @@ public abstract class AbstractReplicated
//--
public static interface MapOwner {
+// a typo, should have been objectMadePrimary
public void objectMadePrimay(Object key, Object value);
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Tomcat diagnostics
Hi, I've been playing with a CLI, JMX and a few other things. At work I am manually extracting and monitoring various bits of JMX data in order to diagnose problems with Tomcat configs and applications. There's lot of information available in the JVM Tomcat which could be polled periodically, (theoretically comparatively cheaply), in order to determine if there is a problem developing or occurring. Some of this information could be collated and presented in a structured format to enable more easy analysis. Tomcat could then self-diagnose some common problems. Rainer I had a lengthy conversation at the Apache Retreat last weekend and extrapolated, coming up with more ideas: - Periodic snaphots of key indicators, e.g. Connector backlog, error counts, resource pool usage. - A 'black box recorder' mode which can be enabled to log key data - Periodic inspection of threads to warn about blocking, deadlocks - A simple web UI (like the /manager) which presents collates this info and does some simple analysis It should also be possible to make some educated guesses about the sources of common problems by doing statistical analysis of thread stacks. There are products on the market and app in the JDK which instrument apps and perform profiling, but we concluded we can simulate some of this with little performance cost. There's a huge gap between understanding basic info, and understanding what the JDK tools output. It should be possible for Tomcat provide an intermediate level and help users improve their own analysis. No silver bullets, just a step up from the basics. Thoughts? p (@Rainer did I forget anything?) 0x62590808.asc Description: application/pgp-keys signature.asc Description: OpenPGP digital signature
DO NOT REPLY [Bug 49985] New: Lazy initialization without any synchronization - data race in AstInteger, AstFloatingPoint, AstString
https://issues.apache.org/bugzilla/show_bug.cgi?id=49985
Summary: Lazy initialization without any synchronization - data
race in AstInteger, AstFloatingPoint, AstString
Product: Tomcat 6
Version: 6.0.29
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: sergeyvorob...@google.com
r998053
http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/java/org/apache/el/parser/AstInteger.java
http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/java/org/apache/el/parser/AstFloatingPoint.java
http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/java/org/apache/el/parser/AstString.java
Use lazy init without any synchronization in methods getInteger(),
getFloatingPoint(), getString(), respectively.
Consider AstInteger:
private Number number;
protected Number getInteger() {
if (this.number == null) {
try {
this.number = new Long(this.image);
} catch (ArithmeticException e1) {
this.number = new BigInteger(this.image);
}
}
return number;
}
Data races on variable number :37
in method getInteger() :39
concurrent read on line 40
concurrent write on lines 42, 44
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49985] Lazy initialization without any synchronization - data race in AstInteger, AstFloatingPoint, AstString
https://issues.apache.org/bugzilla/show_bug.cgi?id=49985 Sergey Vorobyev sergeyvorob...@google.com changed: What|Removed |Added CC||konstantin.s.serebry...@gma ||il.com, ||sergeyvorob...@google.com OS/Version||All -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1000448 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Thu Sep 23 13:06:28 2010 New Revision: 1000448 URL: http://svn.apache.org/viewvc?rev=1000448view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1000448r1=1000447r2=1000448view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Sep 23 13:06:28 2010 @@ -141,7 +141,7 @@ PATCHES PROPOSED TO BACKPORT: * Allow off-line building of the extras packages. Also saves downloading deps every build http://people.apache.org/~markt/patches/2010-08-23-offline-extras-tc6.patch - +1: markt, rjung + +1: markt, rjung, kkolinko -1: rjung: s/vesion/version/g @@ -149,14 +149,17 @@ PATCHES PROPOSED TO BACKPORT: failed ping message rather than propagating the exception (which just logs the stack trace but doesn't do anything to deal with the failure) http://svn.apache.org/viewvc?rev=993007view=rev - +1: markt, kfujino + +1: markt, kfujino, kkolinko -1: + kkolinko: s/membersq/members/ in a comment * Make sure Contexts defined in server.xml pick up any configClass setting from the parent Host. http://people.apache.org/~markt/patches/2010-09-11-configClass.patch +1: markt -1: + kkolinko: A bit hard to understand. The proposal is about a rule that processes +Context, but LifecycleListenerRule is used for Engine and Host as well. * Update commons pool to 1.5.5 http://svn.apache.org/viewvc?rev=996163view=rev @@ -170,3 +173,5 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?view=revisionrevision=996778 +1: kfujino, markt -1: + kkolinko: I think getMapOwner().objectMadePrimay(key, entry.getValue()); can +throw an NPE. Can the mapOwner be null? - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49986] New: Double-check locking. Possible data-race in JspServletWrapper
https://issues.apache.org/bugzilla/show_bug.cgi?id=49986
Summary: Double-check locking. Possible data-race in
JspServletWrapper
Product: Tomcat 6
Version: 6.0.29
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Component: Jasper
AssignedTo: dev@tomcat.apache.org
ReportedBy: sergeyvorob...@google.com
r998053
http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java
Common anti-pattern: Double checked locking. I don't know is this race
dangerous or no.
Race on private boolean reload
public Servlet getServlet()
throws ServletException, IOException, FileNotFoundException
{
if (reload) {
synchronized (this) {
// Synchronizing on jsw enables simultaneous loading
// of different pages, but not the same page.
if (reload) {
// This is to maintain the original protocol.
..
theServlet = servlet;
reload = false;
}
}
}
return theServlet;
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49986] Double-check locking. Possible data-race in JspServletWrapper
https://issues.apache.org/bugzilla/show_bug.cgi?id=49986 Sergey Vorobyev sergeyvorob...@google.com changed: What|Removed |Added CC||konstantin.s.serebry...@gma ||il.com, ||sergeyvorob...@google.com OS/Version||All -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49987] New: Data race in ApplicationContext
https://issues.apache.org/bugzilla/show_bug.cgi?id=49987
Summary: Data race in ApplicationContext
Product: Tomcat 6
Version: 6.0.29
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: sergeyvorob...@google.com
r998053
http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/ApplicationContext.java
Data race on variable
private Map parameters
In method
private void mergeParameters() {
if (parameters != null) // concurrent read : 881
return;
Map results = new ConcurrentHashMap();
...
parameters = results; // concurrent write : 897
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49987] Data race in ApplicationContext
https://issues.apache.org/bugzilla/show_bug.cgi?id=49987 Sergey Vorobyev sergeyvorob...@google.com changed: What|Removed |Added CC||konstantin.s.serebry...@gma ||il.com, ||sergeyvorob...@google.com OS/Version||All -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49986] Double-check locking. Possible data-race in JspServletWrapper
https://issues.apache.org/bugzilla/show_bug.cgi?id=49986 --- Comment #1 from Sebb s...@apache.org 2010-09-23 10:18:53 EDT --- Looks like a problem to me if the class can be called from multiple threads. If not, then why have any synch. blocks at all? Could perhaps be fixed by making reload volatile, but the reload variable can be set false elsewhere without synch. The servletClassLastModifiedTime also looks to be used in a similar way; that is a long so could potentially an invalid value could be read. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49986] Double-check locking. Possible data-race in JspServletWrapper
https://issues.apache.org/bugzilla/show_bug.cgi?id=49986
--- Comment #2 from Sergey Vorobyev sergeyvorob...@google.com 2010-09-23
10:29:38 EDT ---
(In reply to comment #1)
Looks like a problem to me if the class can be called from multiple threads.
If not, then why have any synch. blocks at all?
It's called from multiple threads.
Stack trace:
Thread 28
#0 org/apache/jasper/servlet/JspServletWrapper.getServlet
JspServletWrapper.java:166
#1 org/apache/jasper/servlet/JspServletWrapper.service
JspServletWrapper.java:329
#2 org/apache/jasper/servlet/JspServlet.serviceJspFile JspServlet.java:313
#3 org/apache/jasper/servlet/JspServlet.service JspServlet.java:260
#4 javax/servlet/http/HttpServlet.service HttpServlet.java:717
#5 org/apache/catalina/core/ApplicationFilterChain.internalDoFilter
ApplicationFilterChain.java:290
#6 org/apache/catalina/core/ApplicationFilterChain.doFilter
ApplicationFilterChain.java:206
#7 org/apache/catalina/core/StandardWrapperValve.invoke
StandardWrapperValve.java:233
#8 org/apache/catalina/core/StandardContextValve.invoke
StandardContextValve.java:191
#9 org/apache/catalina/authenticator/AuthenticatorBase.invoke
AuthenticatorBase.java:470
#10 org/apache/catalina/core/StandardHostValve.invoke
StandardHostValve.java:127
#11 org/apache/catalina/valves/ErrorReportValve.invoke
ErrorReportValve.java:102
Thread 25
#0 org/apache/jasper/servlet/JspServletWrapper.getServlet
JspServletWrapper.java:133
#1 org/apache/jasper/servlet/JspServletWrapper.service
JspServletWrapper.java:329
#2 org/apache/jasper/servlet/JspServlet.serviceJspFile JspServlet.java:313
#3 org/apache/jasper/servlet/JspServlet.service JspServlet.java:260
#4 javax/servlet/http/HttpServlet.service HttpServlet.java:717
#5 org/apache/catalina/core/ApplicationFilterChain.internalDoFilter
ApplicationFilterChain.java:290
#6 org/apache/catalina/core/ApplicationFilterChain.doFilter
ApplicationFilterChain.java:206
#7 org/apache/catalina/core/StandardWrapperValve.invoke
StandardWrapperValve.java:233
#8 org/apache/catalina/core/StandardContextValve.invoke
StandardContextValve.java:191
#9 org/apache/catalina/authenticator/AuthenticatorBase.invoke
AuthenticatorBase.java:470
The servletClassLastModifiedTime also looks to be used in a similar way; that
is a long so could potentially an invalid value could be read.
Exactly! Thank you for point
public void setServletClassLastModifiedTime(long lastModified) {
if (this.servletClassLastModifiedTime lastModified) {
synchronized (this) {
if (this.servletClassLastModifiedTime lastModified) {
this.servletClassLastModifiedTime = lastModified;
reload = true;
}
}
}
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49159] Improve ThreadLocal memory leak clean-up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159 --- Comment #5 from Pid pids...@apache.org 2010-09-23 10:49:43 EDT --- Created an attachment (id=26068) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26068) Alternative approach to renewing threads Instead of completely renewing the entire thread pool, it's possible to do it incrementally, which might be less invasive, in the event of a large number of applications being updated at the same time. This patch adds a TaskThread class and modifies the StandardContextValve. The goal is to terminate a class after it's used, when it's discovered to be older than the Context which it last serviced. This approach wouldn't be as comprehensive as replacing the entire pool, but should cause the pool to refresh incrementally over time. Further enhancement could include self-cleaning of thread locals etc. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
Could we remove the spaces from the names of the new files? Files with whitespace in their names are a PITA on most platforms. Regards, Rainer On 23.09.2010 12:15, t...@apache.org wrote: Author: timw Date: Thu Sep 23 10:15:16 2010 New Revision: 1000392 URL: http://svn.apache.org/viewvc?rev=1000392view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=49955 Improvements and corrections for the Building Tomcat guide, plus sample Eclipse launch targets. Based on contribution from Wesley Acheson. Added: tomcat/trunk/Start Tomcat.launch tomcat/trunk/Stop Tomcat.launch ... - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: NamingContext Possible Bug
On 22/09/2010 23:48, David Jencks wrote: For reference, the EE 6 platform spec explains that usually a new instance should be returned on each lookup in section 5.2.4 page 67 Sharing of Environment Entries. The servlet 3.0 spec section 15.2.2 page 174 indicates that this applies to servlet containers that are part of an EE technology-compliant implementation. I guess this means that unless tomcat implements web profile they don't have to support this? I have always worked on the basis that the broader EE spec does apply to Tomcat so we should be supporting this. On Sep 22, 2010, at 10:36 PM, Gurkan Erdogdu wrote: If this is a bug, I will open an issue. Please do. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
On 23/09/2010 03:15, t...@apache.org wrote: Author: timw Date: Thu Sep 23 10:15:16 2010 New Revision: 1000392 URL: http://svn.apache.org/viewvc?rev=1000392view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=49955 Improvements and corrections for the Building Tomcat guide, plus sample Eclipse launch targets. Based on contribution from Wesley Acheson. Added: tomcat/trunk/Start Tomcat.launch tomcat/trunk/Stop Tomcat.launch -1 on the names. File names with spaces are a PITA. Do these have to be in the root of the source tree? I know I started the whole adding Eclipse files to the source tree but I am beginning to regret how I did it. How about moving all the the IDE support files to res/ide-support and update the docs to point to the new location from where users can copy the files they want and ignore the ones they don't? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1000433 - /tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java
On 23/09/2010 05:46, kkoli...@apache.org wrote: Author: kkolinko Date: Thu Sep 23 12:46:50 2010 New Revision: 1000433 URL: http://svn.apache.org/viewvc?rev=1000433view=rev Log: Add a comment. I guess it is too late to change it now, as the code is more than 3 years old. Feel free to change it in 7. We've changed more widely used APIs than this. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tomcat diagnostics
On 23/09/2010 05:52, Pid wrote: - Periodic snaphots of key indicators, e.g. Connector backlog, error counts, resource pool usage. - A 'black box recorder' mode which can be enabled to log key data - Periodic inspection of threads to warn about blocking, deadlocks - A simple web UI (like the /manager) which presents collates this info and does some simple analysis Like it. I assume the same info would be available via JMX. For developers the web UI is the most important. For enterprises it is JMX (or maybe a simple text based outout) so the data can be integrated with other tools. It should also be possible to make some educated guesses about the sources of common problems by doing statistical analysis of thread stacks. That sounds a little more tricky. No silver bullets, just a step up from the basics. Thoughts? Overall, I like it. It fits in with the GSOC work to improve the JMX support (which is still a work in progress but improved a lot over the summer). Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [g...@vmgump]: Project tomcat-tc6 (in module tomcat-tc6) failed
On 23/09/2010 07:57, Bill Barker wrote: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc6 has an issue affecting its community integration. I think I've fixed this. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[OT]Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
-1 on the names. File names with spaces are a PITA. Do these have to be in the root of the source tree? I know I started the whole adding Eclipse files to the source tree but I am beginning to regret how I did it. How about moving all the the IDE support files to res/ide-support and update the docs to point to the new location from where users can copy the files they want and ignore the ones they don't? Mark Whats PITA? Anyway this is just a thought. How about putting an eclipse target into the ant script. similar to maven mvn eclipse:eclipse could put one in for netbeans etc as well. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: [OT]Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
From: Wesley Acheson [mailto:wesley.ache...@gmail.com] Subject: [OT]Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml Whats PITA? GIYF. - Chuck THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY MATERIAL and is thus for use only by the intended recipient. If you received this in error, please contact the sender and delete the e-mail and its attachments from all computers. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
On 23.09.2010 18:24, Mark Thomas wrote: On 23/09/2010 03:15, t...@apache.org wrote: Author: timw Date: Thu Sep 23 10:15:16 2010 New Revision: 1000392 URL: http://svn.apache.org/viewvc?rev=1000392view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=49955 Improvements and corrections for the Building Tomcat guide, plus sample Eclipse launch targets. Based on contribution from Wesley Acheson. Added: tomcat/trunk/Start Tomcat.launch tomcat/trunk/Stop Tomcat.launch -1 on the names. File names with spaces are a PITA. Do these have to be in the root of the source tree? I know I started the whole adding Eclipse files to the source tree but I am beginning to regret how I did it. How about moving all the the IDE support files to res/ide-support and update the docs to point to the new location from where users can copy the files they want and ignore the ones they don't? +1 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
On Thu, Sep 23, 2010 at 12:15 PM, t...@apache.org wrote: Author: timw Date: Thu Sep 23 10:15:16 2010 New Revision: 1000392 URL: http://svn.apache.org/viewvc?rev=1000392view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=49955 Improvements and corrections for the Building Tomcat guide, plus sample Eclipse launch targets. tomcat/trunk/Start Tomcat.launch tomcat/trunk/Stop Tomcat.launch In accordance with the others -1 on the filename. Also your launch files depend on the project being called tomcat-7.0.x which for instance my checkout just isn't called. Finally you removed the line in the patch that mentioned where the branches were stored. If someones trying to checkout the files to find a bug in a particular downloaded version then thats making it more difficult for them. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [OT]Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
On Thu, Sep 23, 2010 at 7:47 PM, Caldarale, Charles R chuck.caldar...@unisys.com wrote: From: Wesley Acheson [mailto:wesley.ache...@gmail.com] Subject: [OT]Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml Whats PITA? GIYF. - Chuck I already did (Sorry). I think that may have been a bit curt though. It wasn't the full of my comment by any means. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: [OT]Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
From: Wesley Acheson [mailto:wesley.ache...@gmail.com] Subject: Re: [OT]Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml I think that may have been a bit curt though. Sorry, I just couldn't resist the opportunity. Did you discover the meaning of the acronym? It wasn't the full of my comment by any means. About which I had nothing to say, so the rest of your post wasn't included in my response. - Chuck THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY MATERIAL and is thus for use only by the intended recipient. If you received this in error, please contact the sender and delete the e-mail and its attachments from all computers. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [OT]Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
On Thu, Sep 23, 2010 at 7:56 PM, Caldarale, Charles R chuck.caldar...@unisys.com wrote: From: Wesley Acheson [mailto:wesley.ache...@gmail.com] Subject: Re: [OT]Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml I think that may have been a bit curt though. Sorry, I just couldn't resist the opportunity. Did you discover the meaning of the acronym? It wasn't the full of my comment by any means. About which I had nothing to say, so the rest of your post wasn't included in my response. - Chuck Okay yes I discovered the meaning of *both* acronym's. Which is ironic considering the meaning of the second (given the way I found it out). PITA is a type of bread. Still not sure what that has to do with a filesystem though. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49979] SimpleDateFormat StringIndexOutOfBoundsException
https://issues.apache.org/bugzilla/show_bug.cgi?id=49979 --- Comment #2 from sosig...@gmail.com 2010-09-23 14:13:22 EDT --- (In reply to comment #1) OS: CentOS5 Tomcat ver.: 6.0.20 requests are coming from Windows XP/IE6 SP3 Which JVM version are you using? sun jdk1.6.0_16 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tomcat diagnostics
On 23/09/2010 17:30, Mark Thomas wrote: On 23/09/2010 05:52, Pid wrote: - Periodic snaphots of key indicators, e.g. Connector backlog, error counts, resource pool usage. - A 'black box recorder' mode which can be enabled to log key data - Periodic inspection of threads to warn about blocking, deadlocks - A simple web UI (like the /manager) which presents collates this info and does some simple analysis Like it. I assume the same info would be available via JMX. For developers the web UI is the most important. For enterprises it is JMX (or maybe a simple text based outout) so the data can be integrated with other tools. Yep, JMX would be the primary location to get the data and enable the BBR. The web UI would interact with JMX, as the Manager app does. p It should also be possible to make some educated guesses about the sources of common problems by doing statistical analysis of thread stacks. That sounds a little more tricky. No silver bullets, just a step up from the basics. Thoughts? Overall, I like it. It fits in with the GSOC work to improve the JMX support (which is still a work in progress but improved a lot over the summer). Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org 0x62590808.asc Description: application/pgp-keys signature.asc Description: OpenPGP digital signature
work directory svn ignore.
Just a suggestion but I feel the work directory should be in svn:ignore. I'm looking at trunk for tc7 and it says I've a lot of outgoing changes because I've executed it. It also showed outgoing additions in conf. I'd put in a patch but dunno how to put in a patch for svn properties. Wes - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [OT]Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
On 23 September 2010 19:10, Wesley Acheson wesley.ache...@gmail.com wrote: On Thu, Sep 23, 2010 at 7:56 PM, Caldarale, Charles R chuck.caldar...@unisys.com wrote: From: Wesley Acheson [mailto:wesley.ache...@gmail.com] Subject: Re: [OT]Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml I think that may have been a bit curt though. Sorry, I just couldn't resist the opportunity. Did you discover the meaning of the acronym? It wasn't the full of my comment by any means. About which I had nothing to say, so the rest of your post wasn't included in my response. - Chuck Okay yes I discovered the meaning of *both* acronym's. Which is ironic considering the meaning of the second (given the way I found it out). PITA is a type of bread. Still not sure what that has to do with a filesystem though. http://www.urbandictionary.com/define.php?term=PITA - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [OT]Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml
Okay yes I discovered the meaning of *both* acronym's. Which is ironic considering the meaning of the second (given the way I found it out). PITA is a type of bread. Still not sure what that has to do with a filesystem though. http://www.urbandictionary.com/define.php?term=PITA Okay sorry. I saw that earlier I was being silly mostly in response to chucks response. JIC anyone thought I was serious. AFIK TLA's LOLspk are difficult to read IMHO. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: work directory svn ignore.
On 23/09/2010 12:10, Wesley Acheson wrote: Just a suggestion but I feel the work directory should be in svn:ignore. I'm looking at trunk for tc7 and it says I've a lot of outgoing changes because I've executed it. It also showed outgoing additions in conf. I'd put in a patch but dunno how to put in a patch for svn properties. You build env is messed up. You should be running Tomcat from trunk/output/build and that is already ignored. You should not be running from trunk/ Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: work directory svn ignore.
Okay thanks for the heads up. On Thu, Sep 23, 2010 at 9:45 PM, Mark Thomas ma...@apache.org wrote: On 23/09/2010 12:10, Wesley Acheson wrote: Just a suggestion but I feel the work directory should be in svn:ignore. I'm looking at trunk for tc7 and it says I've a lot of outgoing changes because I've executed it. It also showed outgoing additions in conf. I'd put in a patch but dunno how to put in a patch for svn properties. You build env is messed up. You should be running Tomcat from trunk/output/build and that is already ignored. You should not be running from trunk/ Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: work directory svn ignore.
In that case looking further at this I think the eclipse.classpath is wrong. On Thu, Sep 23, 2010 at 9:45 PM, Mark Thomas ma...@apache.org wrote: On 23/09/2010 12:10, Wesley Acheson wrote: You build env is messed up. You should be running Tomcat from trunk/output/build and that is already ignored. You should not be running from trunk/ Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49159] Improve ThreadLocal memory leak clean-up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159 --- Comment #6 from sylvain.laur...@gmail.com 2010-09-23 16:51:38 EDT --- Pid, I applied your patch but it does not work. Actually when the thread calls join(0) on itself it just leads to a deadlock : the Thread will remain forever in the join method unless it is interrupted. Furthermore your idea works only if a new context is started. If a context is stopped and no other context is started, Threads won't be renewed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tomcat diagnostics
what about all the existing solutions that are there already? Doesn't it make more sense to embed in one of these instead of creating the n+1 ? leon On Thu, Sep 23, 2010 at 8:17 PM, Pid p...@pidster.com wrote: On 23/09/2010 17:30, Mark Thomas wrote: On 23/09/2010 05:52, Pid wrote: - Periodic snaphots of key indicators, e.g. Connector backlog, error counts, resource pool usage. - A 'black box recorder' mode which can be enabled to log key data - Periodic inspection of threads to warn about blocking, deadlocks - A simple web UI (like the /manager) which presents collates this info and does some simple analysis Like it. I assume the same info would be available via JMX. For developers the web UI is the most important. For enterprises it is JMX (or maybe a simple text based outout) so the data can be integrated with other tools. Yep, JMX would be the primary location to get the data and enable the BBR. The web UI would interact with JMX, as the Manager app does. p It should also be possible to make some educated guesses about the sources of common problems by doing statistical analysis of thread stacks. That sounds a little more tricky. No silver bullets, just a step up from the basics. Thoughts? Overall, I like it. It fits in with the GSOC work to improve the JMX support (which is still a work in progress but improved a lot over the summer). Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49683] Separate async, keep-alive, connection timeout with APR/native connector
https://issues.apache.org/bugzilla/show_bug.cgi?id=49683 Mark Thomas ma...@apache.org changed: What|Removed |Added Summary|Separate keep-alive and |Separate async, keep-alive, |connection timeout with |connection timeout with |APR/native connector|APR/native connector --- Comment #1 from Mark Thomas ma...@apache.org 2010-09-23 17:07:26 EDT --- Currently async timeouts are ignored as well. That makes this issue more serious. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1000625 - /tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
Author: markt Date: Thu Sep 23 21:08:14 2010 New Revision: 1000625 URL: http://svn.apache.org/viewvc?rev=1000625view=rev Log: Reduce timeout from 60s to 3s to speed up async tests Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java?rev=1000625r1=1000624r2=1000625view=diff == --- tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java (original) +++ tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Thu Sep 23 21:08:14 2010 @@ -121,6 +121,8 @@ public abstract class TomcatBaseTest ext // If each test is running on same port - they // may interfere with each other (on unix at least) connector.setPort(getNextPort()); +// Mainly set to reduce timeouts during async tests +connector.setAttribute(connectionTimeout, 3000); tomcat.getService().addConnector(connector); tomcat.setConnector(connector); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: work directory svn ignore.
On 23/09/2010 13:28, Wesley Acheson wrote: In that case looking further at this I think the eclipse.classpath is wrong. That was intended for building Tomcat, not running it. Personally, I'd never run Tomcat inside Eclipse. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tomcat diagnostics
On 23/09/2010 22:01, Leon Rosenberg wrote: what about all the existing solutions that are there already? Doesn't it make more sense to embed in one of these instead of creating the n+1 ? What kind of solutions do you have in mind? p On Thu, Sep 23, 2010 at 8:17 PM, Pid p...@pidster.com wrote: On 23/09/2010 17:30, Mark Thomas wrote: On 23/09/2010 05:52, Pid wrote: - Periodic snaphots of key indicators, e.g. Connector backlog, error counts, resource pool usage. - A 'black box recorder' mode which can be enabled to log key data - Periodic inspection of threads to warn about blocking, deadlocks - A simple web UI (like the /manager) which presents collates this info and does some simple analysis Like it. I assume the same info would be available via JMX. For developers the web UI is the most important. For enterprises it is JMX (or maybe a simple text based outout) so the data can be integrated with other tools. Yep, JMX would be the primary location to get the data and enable the BBR. The web UI would interact with JMX, as the Manager app does. p It should also be possible to make some educated guesses about the sources of common problems by doing statistical analysis of thread stacks. That sounds a little more tricky. No silver bullets, just a step up from the basics. Thoughts? Overall, I like it. It fits in with the GSOC work to improve the JMX support (which is still a work in progress but improved a lot over the summer). Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org 0x62590808.asc Description: application/pgp-keys signature.asc Description: OpenPGP digital signature
DO NOT REPLY [Bug 49159] Improve ThreadLocal memory leak clean-up
https://issues.apache.org/bugzilla/show_bug.cgi?id=49159 --- Comment #7 from Pid pids...@apache.org 2010-09-23 17:55:09 EDT --- (In reply to comment #6) Pid, I applied your patch but it does not work. Actually when the thread calls join(0) on itself it just leads to a deadlock : the Thread will remain forever in the join method unless it is interrupted. It's experimental admittedly. I'll clean up my SVN repo retry it, thought it was working... If it won't work at all, then the idea is dead, but there must be a way to terminate an individual thread remove it from the pool. Furthermore your idea works only if a new context is started. Or an existing one is restarted, the point is that it's a compromise. The idea was to have a lower impact than restarting the whole thread pool. If a context is stopped and no other context is started, Threads won't be renewed. If a context is stopped and no other context is started, how will the server work? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: work directory svn ignore.
On Thu, Sep 23, 2010 at 11:28 PM, Mark Thomas ma...@apache.org wrote: On 23/09/2010 13:28, Wesley Acheson wrote: In that case looking further at this I think the eclipse.classpath is wrong. That was intended for building Tomcat, not running it. Personally, I'd never run Tomcat inside Eclipse. Mark Hey Mark, Its useful sometimes. I use the step debugger. The only reason I have the project checked out is for that issue I was looking at before with the / filter. Yeah I could attach with the JDPA but this way is easier. Doesn't matter though. I'm really not fussed. I just thought I'd bring it up thats all. Wes - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: NamingContext Possible Bug
2010/9/21 Gurkan Erdogdu gurkanerdo...@yahoo.com: Hello folks, In NamingContext implementation, if lookup() is a Reference, current implementation caches the result of the NamingManager # getObjectInstance via following statements and changes the type of the entry. In the following lookups, same object is returned. I would like to write ObjectFactory that returns new instance for each time lookup is called on its reference. But with the current implementation, it is not possible to write such an object factory because of aferomentioned sitaution. I think that entry must be stay as Reference instead of changing entry type. WDYT? There was some discussion previously, proposed and vetoed patch and some issue in bugzilla. [1] From some later code review I think that that code is used to handle ResourceLink elements. That is, when you have a global resource in server.xml and a ResourceLink in your context.xml. [2] It would be undesirable to break that. [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=47512 [2] http://tomcat.apache.org/tomcat-6.0-doc/jndi-resources-howto.html#context.xml_configuration Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49991] New: Tomcat 7 JAAS problem with CDI
https://issues.apache.org/bugzilla/show_bug.cgi?id=49991 Summary: Tomcat 7 JAAS problem with CDI Product: Tomcat 7 Version: 7.0.2 Platform: PC Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: serv...@ig.com.br Tomcat is suffering from the same bug fixed in Glassfish: https://glassfish.dev.java.net/issues/show_bug.cgi?id=12642 When the container redirects to a login page, CDI (Weld) tell that there is no active contexts for requestscope. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1000687 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kfujino Date: Fri Sep 24 01:33:09 2010 New Revision: 1000687 URL: http://svn.apache.org/viewvc?rev=1000687view=rev Log: Add comment. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1000687r1=1000686r2=1000687view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Sep 24 01:33:09 2010 @@ -175,3 +175,6 @@ PATCHES PROPOSED TO BACKPORT: -1: kkolinko: I think getMapOwner().objectMadePrimay(key, entry.getValue()); can throw an NPE. Can the mapOwner be null? + kfujino : mapOwner is specified by the argument of the constructor of AbstractReplicatedMap. + LazyReplicatedMap is constructed specifying this in BackupManager#startInternal(). + Therefore, I think mapOwner can not be null. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 49993] New: service.bat does not check for JAVA_HOME validity
https://issues.apache.org/bugzilla/show_bug.cgi?id=49993 Summary: service.bat does not check for JAVA_HOME validity Product: Tomcat 7 Version: unspecified Platform: PC OS/Version: Windows NT Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: mt...@apache.org service.bat does not check for JAVA_HOME validity. It also does not check for JRE_HOME like catalina.bat does trough setclasspath.bat script. If neither the JAVA_HOME nor JRE_HOME are set we should inform the user and then switch to auto detection mode from the registry -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
