Re: Connection draining when upload to large

2011-02-11 Thread Mark Thomas
On 10/02/2011 21:32, Christopher Schultz wrote:
 Rainer,
 
 On 2/10/2011 8:04 AM, Rainer Jung wrote:
 It seems there's still no server-side prevention against huge uploads
 possible. The upload is not put into memory, but the thread is only
 freed once the whole request body is read. Shouldn't Tomcat ignore the
 rest of data and close the connection in this case?
 
 +1
 
 I've always wondered why Tomcat drains the input stream instead of just
 closing it.
 
 I could write a client that does a PUT or POST with no Content-Length
 and just send 1 byte every second or so and tie up a request thread
 indefinitely. That seems dangerous.

That is a different issue. You are describing a slowloris attack. The
simple mitigation for that is to use the NIO connector.

Mark



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Connection draining when upload to large

2011-02-11 Thread Rainer Jung

On 10.02.2011 18:00, Filip Hanik - Dev Lists wrote:

On 2/10/2011 6:04 AM, Rainer Jung wrote:

Servlet 3 standardizes file uploads. It contains the ability to limit
on request size, pretty much the same as commons fileupload supported
for many years.

It seems when this conditions triggers the rest of the request inout
stream is still drained at the end of the request. swallowInput is not
being set to false.

It seems there's still no server-side prevention against huge uploads
possible. The upload is not put into memory, but the thread is only
freed once the whole request body is read. Shouldn't Tomcat ignore the
rest of data and close the connection in this case?

standard soTimeout (read timeout) should apply. Meaning, if the client
stops sending data, it should eventually result in an IOException and
back out the thread.


Right, but this is more about clients sending huge uploads you don't 
want to consume. There should be a clean way of signalling to the 
container, that the rest of the upload should be discarded in the sense 
of please do not read it and do no longer read from the connection 
(e.g. for Keep-Alive).


Clients might not react well-behaved to that. E.g. if I change TC code a 
bit and allow it to close the connection instead of draining it before, 
then firefox will still try to upload, finally receive a few resets form 
the server and display an error message - even if the server send out a 
valid HTTP response before closing the reading side of the connection. 
So it won't actually help in transferring an abort message reliably to 
the client, but at least the containr thread would get freed more quickly.


Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 22895] [PATCH] req:isUserInRole upgrade to support multiple roles

2011-02-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=22895

jasonchu zjji...@cti.hkbn.com.hk changed:

   What|Removed |Added

 CC||zjji...@cti.hkbn.com.hk

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1069766 - in /tomcat/trunk/test/org/apache/tomcat/util/net: TestCustomSsl.java jsse/ jsse/TesterBug50640SslImpl.java

2011-02-11 Thread markt
Author: markt
Date: Fri Feb 11 12:08:55 2011
New Revision: 1069766

URL: http://svn.apache.org/viewvc?rev=1069766view=rev
Log:
Add unit test that demonstrates use of a custom SSL implementation that extends 
the default JSSE implementation.

Added:
tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java
tomcat/trunk/test/org/apache/tomcat/util/net/jsse/
tomcat/trunk/test/org/apache/tomcat/util/net/jsse/TesterBug50640SslImpl.java

Added: tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java?rev=1069766view=auto
==
--- tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java (added)
+++ tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java Fri Feb 11 
12:08:55 2011
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ * 
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.util.net;
+
+import java.io.File;
+
+import javax.net.ssl.SSLContext;
+
+import org.apache.catalina.connector.Connector;
+import org.apache.catalina.startup.Tomcat;
+import org.apache.catalina.startup.TomcatBaseTest;
+import org.apache.tomcat.util.buf.ByteChunk;
+import org.apache.tomcat.util.net.jsse.TesterBug50640SslImpl;
+
+/**
+ * Requires test.keystore (checked in), generated with:
+ *  keytool -genkey -alias tomcat -keyalg RSA
+ *  pass: changeit 
+ *  CN: localhost ( for hostname validation )
+ */
+public class TestCustomSsl extends TomcatBaseTest {
+
+public void testSimpleSsl() throws Exception {
+// Install the all-trusting trust manager so https:// works 
+// with unsigned certs. 
+
+try {
+SSLContext sc = SSLContext.getInstance(SSL);
+sc.init(null, TesterSupport.TRUST_ALL_CERTS,
+new java.security.SecureRandom());
+javax.net.ssl.HttpsURLConnection.setDefaultSSLSocketFactory(
+sc.getSocketFactory());
+} catch (Exception e) {
+e.printStackTrace();
+} 
+
+Tomcat tomcat = getTomcatInstance();
+Connector connector = tomcat.getConnector();
+if (connector.getProtocol().indexOf(Apr)  -1) {
+// This test is only for JSSE based SSL connectors
+return;
+}
+
+connector.setProperty(sslImplemenationName, 
+org.apache.tomcat.util.net.jsse.TesterBug50640SslImpl);
+connector.setProperty(TesterBug50640SslImpl.PROPERTY_NAME,
+TesterBug50640SslImpl.PROPERTY_VALUE);
+
+connector.setProperty(sslProtocol, tls);
+
+File keystoreFile =
+new File(test/org/apache/catalina/startup/test.keystore);
+connector.setAttribute(
+keystoreFile, keystoreFile.getAbsolutePath());
+
+connector.setSecure(true);
+connector.setProperty(SSLEnabled, true);
+
+File appDir = new File(getBuildDirectory(), webapps/examples);
+tomcat.addWebapp(null, /examples, appDir.getAbsolutePath());
+
+tomcat.start();
+ByteChunk res = getUrl(https://localhost:; + getPort() +
+/examples/servlets/servlet/HelloWorldExample);
+assertTrue(res.toString().indexOf(h1Hello World!/h1)  0);
+}
+
+}

Added: 
tomcat/trunk/test/org/apache/tomcat/util/net/jsse/TesterBug50640SslImpl.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/net/jsse/TesterBug50640SslImpl.java?rev=1069766view=auto
==
--- 
tomcat/trunk/test/org/apache/tomcat/util/net/jsse/TesterBug50640SslImpl.java 
(added)
+++ 
tomcat/trunk/test/org/apache/tomcat/util/net/jsse/TesterBug50640SslImpl.java 
Fri Feb 11 12:08:55 2011
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance 

DO NOT REPLY [Bug 50640] Keystore in AbstractEndpoint doesn't have to be a file

2011-02-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50640

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||WONTFIX

--- Comment #3 from Mark Thomas ma...@apache.org 2011-02-11 07:10:20 EST ---
You should not be re-using an attribute intended for a file for something else.
Generally, that approach will make your solution fragile.

I have added a test case to Tomcat 7 that demonstrates how a custom SSL
implementation can use custom attributes. If you have have further questions on
how to implement this, the users list is the place to ask them.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1069768 - /tomcat/trunk/test/org/apache/catalina/core/TestStandardContext.java

2011-02-11 Thread markt
Author: markt
Date: Fri Feb 11 12:16:31 2011
New Revision: 1069768

URL: http://svn.apache.org/viewvc?rev=1069768view=rev
Log:
Fix Eclipse warnings

Modified:
tomcat/trunk/test/org/apache/catalina/core/TestStandardContext.java

Modified: tomcat/trunk/test/org/apache/catalina/core/TestStandardContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestStandardContext.java?rev=1069768r1=1069767r2=1069768view=diff
==
--- tomcat/trunk/test/org/apache/catalina/core/TestStandardContext.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/core/TestStandardContext.java Fri Feb 
11 12:16:31 2011
@@ -370,6 +370,8 @@ public class TestStandardContext extends
 }
 
 private static class Bug49711Servlet extends HttpServlet {
+private static final long serialVersionUID = 1L;
+
 @Override
 protected void service(HttpServletRequest req, HttpServletResponse 
resp)
 throws ServletException, IOException {
@@ -381,12 +383,13 @@ public class TestStandardContext extends
 
 out.println(parts= + (null == req.getParts()
 ? null
-: req.getParts().size()));
+: Integer.valueOf(req.getParts().size(;
 }
 }
 
 @MultipartConfig
 private static class Bug49711Servlet_multipart extends Bug49711Servlet {
+private static final long serialVersionUID = 1L;
 }
 
 /**
@@ -436,12 +439,10 @@ public class TestStandardContext extends
 String content = -- + boundary + CRLF
 + Content-Disposition: form-data; name=\name\ + 
CRLF + CRLF
 + value + CRLF
-+ -- + boundary + -- + CRLF
-;
++ -- + boundary + -- + CRLF;
 
 // Re-encode the content so that bytes = characters
-if(null != content)
-content = new String(content.getBytes(UTF-8), 
ASCII);
+content = new String(content.getBytes(UTF-8), ASCII);
 
 request = new String[] {
 POST http://localhost:; + getPort() + uri +  
HTTP/1.1 + CRLF



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1069770 - in /tomcat/trunk: java/org/apache/catalina/startup/Embedded.java webapps/docs/changelog.xml

2011-02-11 Thread markt
Author: markt
Date: Fri Feb 11 12:24:47 2011
New Revision: 1069770

URL: http://svn.apache.org/viewvc?rev=1069770view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50752
Correct typo

Modified:
tomcat/trunk/java/org/apache/catalina/startup/Embedded.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/startup/Embedded.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/Embedded.java?rev=1069770r1=1069769r2=1069770view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/Embedded.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/Embedded.java Fri Feb 11 
12:24:47 2011
@@ -896,7 +896,7 @@ public class Embedded  extends StandardS
 (javax.naming.Context.INITIAL_CONTEXT_FACTORY,
  org.apache.naming.java.javaURLContextFactory);
 } else {
-log.debug( INITIAL_CONTEXT_FACTORY alread set  + value );
+log.debug( INITIAL_CONTEXT_FACTORY already set  + value );
 }
 }
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1069770r1=1069769r2=1069770view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri Feb 11 12:24:47 2011
@@ -71,6 +71,10 @@
 bug50748/bug: Allow the content length header to be set up to the
 point the response is committed when a writer is being used. (markt)
   /fix
+  fix
+bug50752/bug: Fix typo in debug message in deprecated Embedded
+class. (markt)
+  /fix
 /changelog
   /subsection
   subsection name=Jasper



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1069774 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-02-11 Thread markt
Author: markt
Date: Fri Feb 11 12:31:08 2011
New Revision: 1069774

URL: http://svn.apache.org/viewvc?rev=1069774view=rev
Log:
Proposal, vote

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1069774r1=1069773r2=1069774view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Feb 11 12:31:08 2011
@@ -92,5 +92,11 @@ PATCHES PROPOSED TO BACKPORT:
 * Reduce severity of log messages in o.a.t.util.http.Parameters
   (backport of revs 1067039, 1067139)
   http://people.apache.org/~kkolinko/patches/2011-02-08_tc6_Parameters.patch
-  +1: kkolinko
+  +1: kkolinko, markt
   -1:
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50752
+  Correct typo
+  http://svn.apache.org/viewvc?rev=1069770view=rev
+  +1: markt
+  -1:
\ No newline at end of file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50752] Typo in Embedded.java log message

2011-02-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50752

--- Comment #1 from Mark Thomas ma...@apache.org 2011-02-11 07:31:44 EST ---
Fixed in 7.0.x for 7.0.9 onwards.

Proposed for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1069824 - in /tomcat/trunk: java/org/apache/catalina/realm/JNDIRealm.java webapps/docs/changelog.xml

2011-02-11 Thread markt
Author: markt
Date: Fri Feb 11 14:49:41 2011
New Revision: 1069824

URL: http://svn.apache.org/viewvc?rev=1069824view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50751
Don't try to retrieve attributes if we don't need to. If anonymous bind is not 
allowed, the login will always fail.

Modified:
tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java?rev=1069824r1=1069823r2=1069824view=diff
==
--- tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java (original)
+++ tomcat/trunk/java/org/apache/catalina/realm/JNDIRealm.java Fri Feb 11 
14:49:41 2011
@@ -1245,6 +1245,11 @@ public class JNDIRealm extends RealmBase
 String dn)
 throws NamingException {
 
+// If no attributes are requested, no need to look for them
+if (attrIds == null || attrIds.length  0) {
+return new User(username, dn, null, null);
+}
+
 // Get required attributes from user entry
 Attributes attrs = null;
 try {

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1069824r1=1069823r2=1069824view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri Feb 11 14:49:41 2011
@@ -72,6 +72,11 @@
 point the response is committed when a writer is being used. (markt)
   /fix
   fix
+bug50751/bug: When authenticating with the JNDI Realm, only attempt
+to read user attributes from the directory if attributes are required.
+(markt)
+  /fix
+  fix
 bug50752/bug: Fix typo in debug message in deprecated Embedded
 class. (markt)
   /fix



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1069825 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-02-11 Thread markt
Author: markt
Date: Fri Feb 11 14:51:33 2011
New Revision: 1069825

URL: http://svn.apache.org/viewvc?rev=1069825view=rev
Log:
Proposal

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1069825r1=1069824r2=1069825view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Feb 11 14:51:33 2011
@@ -99,4 +99,11 @@ PATCHES PROPOSED TO BACKPORT:
   Correct typo
   http://svn.apache.org/viewvc?rev=1069770view=rev
   +1: markt
-  -1:
\ No newline at end of file
+  -1:
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50751
+  Don't try to retrieve attributes if we don't need to. If anonymous bind is 
not
+  allowed, the login will always fail.
+  http://svn.apache.org/viewvc?rev=1069824view=rev
+  +1: markt
+  -1:



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50751] JNDIRealm invokes getAttributes with no attribute ids. Prevents using DOMAIN\{0} to login.

2011-02-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50751

--- Comment #1 from Mark Thomas ma...@apache.org 2011-02-11 09:52:51 EST ---
I applied a slightly different patch for this issue that acheives the same
results. Note that the JNDI realm assumes that anonymous access is allowed in
some cumstances.

Fixed in 7.0.x for 7.0.9 onwards.

Proposed for 6.0.x.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1069832 - in /tomcat/trunk: java/org/apache/catalina/startup/ExpandWar.java java/org/apache/catalina/startup/LocalStrings.properties webapps/docs/changelog.xml

2011-02-11 Thread markt
Author: markt
Date: Fri Feb 11 15:21:54 2011
New Revision: 1069832

URL: http://svn.apache.org/viewvc?rev=1069832view=rev
Log:
Add additional information to assist with tracking down the root cause of 
https://issues.apache.org/bugzilla/show_bug.cgi?id=50737

Modified:
tomcat/trunk/java/org/apache/catalina/startup/ExpandWar.java
tomcat/trunk/java/org/apache/catalina/startup/LocalStrings.properties
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/startup/ExpandWar.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/ExpandWar.java?rev=1069832r1=1069831r2=1069832view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/ExpandWar.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/ExpandWar.java Fri Feb 11 
15:21:54 2011
@@ -119,7 +119,9 @@ public class ExpandWar {
 // Trying to expand outside the docBase
 // Throw an exception to stop the deployment
 throw new IllegalArgumentException(
-sm.getString(expandWar.illegalPath,war, name));
+sm.getString(expandWar.illegalPath,war, name,
+expandedFile.getCanonicalPath(),
+canonicalDocBasePrefix));
 }
 int last = name.lastIndexOf('/');
 if (last = 0) {
@@ -220,7 +222,9 @@ public class ExpandWar {
 // Entry located outside the docBase
 // Throw an exception to stop the deployment
 throw new IllegalArgumentException(
-sm.getString(expandWar.illegalPath,war, name));
+sm.getString(expandWar.illegalPath,war, name,
+expandedFile.getCanonicalPath(),
+canonicalDocBasePrefix));
 }
 }
 } catch (IOException e) {

Modified: tomcat/trunk/java/org/apache/catalina/startup/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/LocalStrings.properties?rev=1069832r1=1069831r2=1069832view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/LocalStrings.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/startup/LocalStrings.properties Fri 
Feb 11 15:21:54 2011
@@ -69,7 +69,7 @@ engineConfig.start=EngineConfig: Process
 engineConfig.stop=EngineConfig: Processing STOP
 expandWar.copy=Error copying {0} to {1}
 expandWar.deleteFailed=[{0}] could not be completely deleted. The presence of 
the remaining files may cause problems
-expandWar.illegalPath=The archive [{0}] is malformed and will be ignored: an 
entry contains an illegal path [{1}]
+expandWar.illegalPath=The archive [{0}] is malformed and will be ignored: an 
entry contains an illegal path [{1}] which was not expanded to [{2}] since that 
is outside of the defined docBase [{3}]
 hostConfig.appBase=Application base directory {0} does not exist
 hostConfig.canonicalizing=Error delete redeploy resources from context [{0}]
 hostConfig.cce=Lifecycle event data object {0} is not a Host

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1069832r1=1069831r2=1069832view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri Feb 11 15:21:54 2011
@@ -67,6 +67,10 @@
 bug50721/bug: Correctly handle URL decoding where the URL ends in
 %nn. Patch provided by Christof Marti. (markt)
   /fix
+  add
+bug50737/bug: Add additional information when an invalid WAR file 
is
+detected. (markt)
+  /add
   fix
 bug50748/bug: Allow the content length header to be set up to the
 point the response is committed when a writer is being used. (markt)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of PoweredBy by prosch

2011-02-11 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Tomcat Wiki for change 
notification.

The PoweredBy page has been changed by prosch.
http://wiki.apache.org/tomcat/PoweredBy?action=diffrev1=312rev2=313

--

  #pragma section-numbers 2
  = Sites, Applications, and Systems that are Powered By Tomcat =
- This page is a list of some, in all likelihood a very small fraction 
actually, of the sites out there that use [[http://tomcat.apache.org|Apache 
Tomcat]] in production.  For security and other policy-related reasons, many 
organizations choose not to disclose the server they use.  Tomcat has been 
downloaded more than 10 million times: assuming even a 1% production adoption 
rate results in more than 10 installations.  As an aside for the curious, 
you can see recent Tomcat download statistics on 
[[http://people.apache.org/~vgritsenko/stats/projects/tomcat.html|Vadim 
Gritsenko's page]].  Note, however, that these represent downloads from 
apache.org servers only, and not from mirrors, so they are likely to represent 
only a small minority of downloads: the total number is much (more than an 
order of magnitude) greater.  Companies that support Tomcat, such as 
[[http://www.springsource.com|SpringSource]] claim more than half of the global 
Fortune 500 as their clients.
+ This page is a list of some, in all likelihood a very small fraction 
actually, of the sites out there that use [[http://tomcat.apache.org|Apache 
Tomcat]] in production.  For security and other policy-related reasons, many 
organizations choose not to disclose the server they use.  Tomcat has been 
downloaded more than 10 million times: assuming even a 1% production adoption 
rate results in more than 10 installations.  As an aside for the curious, 
you can see recent Tomcat download statistics on 
[[http://people.apache.org/~vgritsenko/stats/projects/tomcat.html|Vadim 
Gritsenko's page]].  Note, however, that these represent downloads from 
apache.org servers only, and not from mirrors, so they are likely to represent 
only a small minority of downloads: the total number is much (more than an 
order of magnitude) greater.  Companies that support Tomcat, such as 
[[http://www.springsource.com|SpringSource]] claim more than half of the global 
Fortune 500 as their clients. [[http://www.profischnell.com|Übersetzung]]
  
- This page is organized by categories: [[#pub|sites with publications]], 
[[#user|sites added by users]], [[#surveys|independent surveys]], and 
[[#more|more]].  Anyone can and is encouraged to add to this page: please add 
your site, application, or system as you see fit.  You do need to register with 
the Apache wiki system to edit this page: simply click the login or user 
preferences links at the top right of your screen to do so.  Don't worry if you 
don't think it fits here or into any particular category: we would like to see 
your application listed no matter how big, how small, or how miscategorized ;)  
Some of these applications are simply compatible with, ship with, or run on 
Tomcat.  Others are specifically designed or documented with Tomcat as the 
container in mind.
+ This page is organized by categories: [[#pub|sites with publications]], 
[[#user|sites added by users]], [[#surveys|independent surveys]], and 
[[#more|more]].  Anyone can and is encouraged to add to this page: please add 
your site, application, or system as you see fit.  You do need to register with 
the Apache wiki system to edit this page: simply click the login or user 
preferences links at the top right of your screen to do so.  Don't worry if you 
don't think it fits here or into any particular category: we would like to see 
your application listed no matter how big, how small, or how miscategorized ;)  
Some of these applications are simply compatible with, ship with, or run on 
Tomcat.  Others are specifically designed or documented with Tomcat as the 
container in mind. [[http://www.profi-fachuebersetzung.de|Übersetzer]]
  
  Please note that all the corporate logos and names used below are trademarked 
by their respective organizations.  These organizations are not affiliated with 
this web site or with The Apache Software Foundation, and make no claims 
regarding The Foundation or its products.  Further, in most cases the companies 
are not aware of their being listed on this site at all.
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1069835 - /tomcat/trunk/java/org/apache/catalina/startup/ExpandWar.java

2011-02-11 Thread markt
Author: markt
Date: Fri Feb 11 15:27:06 2011
New Revision: 1069835

URL: http://svn.apache.org/viewvc?rev=1069835view=rev
Log:
Remove unused deprecated method

Modified:
tomcat/trunk/java/org/apache/catalina/startup/ExpandWar.java

Modified: tomcat/trunk/java/org/apache/catalina/startup/ExpandWar.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/ExpandWar.java?rev=1069835r1=1069834r2=1069835view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/ExpandWar.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/ExpandWar.java Fri Feb 11 
15:27:06 2011
@@ -389,27 +389,6 @@ public class ExpandWar {
 
 
 /**
- * Expand the specified input stream into the specified directory, creating
- * a file named from the specified relative path.
- *
- * @param input InputStream to be copied
- * @param docBase Document base directory into which we are expanding
- * @param name Relative pathname of the file to be created
- * @return A handle to the expanded File
- *
- * @exception IOException if an input/output error occurs
- * 
- * @deprecated
- */
-protected static File expand(InputStream input, File docBase, String name)
-throws IOException {
-File file = new File(docBase, name);
-expand(input, file);
-return file;
-}
-
-
-/**
  * Expand the specified input stream into the specified file.
  *
  * @param input InputStream to be copied



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1069836 - /tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java

2011-02-11 Thread markt
Author: markt
Date: Fri Feb 11 15:29:34 2011
New Revision: 1069836

URL: http://svn.apache.org/viewvc?rev=1069836view=rev
Log:
Remove deprecated code

Modified:
tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java

Modified: tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java?rev=1069836r1=1069835r2=1069836view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java Fri Feb 
11 15:29:34 2011
@@ -274,27 +274,6 @@ public class SimpleTcpCluster extends Li
 }
 
 /**
- * @deprecated use getManagerTemplate().getClass().getName() instead.
- * @return String
- */
-@Deprecated
-public String getManagerClassName() {
-return managerTemplate.getClass().getName();
-}
-
-/**
- * @deprecated use nested lt;Managergt; element inside the cluster 
config instead.
- * @param managerClassName String
- */
-@Deprecated
-public void setManagerClassName(
-@SuppressWarnings(unused) String managerClassName) {
-log.warn(setManagerClassName is deprecated, use nested Manager  +
- element inside the Cluster element instead, this request  
+
- will be ignored.);
-}
-
-/**
  * Add cluster valve 
  * Cluster Valves are only add to container when cluster is started!
  * @param valve The new cluster Valve.
@@ -527,7 +506,10 @@ public class SimpleTcpCluster extends Li
  */
 @Override
 public synchronized Manager createManager(String name) {
-if (log.isDebugEnabled()) log.debug(Creating ClusterManager for 
context  + name +  using class  + getManagerClassName());
+if (log.isDebugEnabled()) {
+log.debug(Creating ClusterManager for context  + name +
+ using class  + 
getManagerTemplate().getClass().getName());
+}
 Manager manager = null;
 try {
 manager = managerTemplate.cloneFromTemplate();



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



PoweredBy reverted to revision 312 on Tomcat Wiki

2011-02-11 Thread Apache Wiki
Dear wiki user,

You have subscribed to a wiki page Tomcat Wiki for change notification.

The page PoweredBy has been reverted to revision 312 by ChuckCaldarale.
The comment on this change is: Spam removal.
http://wiki.apache.org/tomcat/PoweredBy?action=diffrev1=313rev2=314

--

  #pragma section-numbers 2
  = Sites, Applications, and Systems that are Powered By Tomcat =
- This page is a list of some, in all likelihood a very small fraction 
actually, of the sites out there that use [[http://tomcat.apache.org|Apache 
Tomcat]] in production.  For security and other policy-related reasons, many 
organizations choose not to disclose the server they use.  Tomcat has been 
downloaded more than 10 million times: assuming even a 1% production adoption 
rate results in more than 10 installations.  As an aside for the curious, 
you can see recent Tomcat download statistics on 
[[http://people.apache.org/~vgritsenko/stats/projects/tomcat.html|Vadim 
Gritsenko's page]].  Note, however, that these represent downloads from 
apache.org servers only, and not from mirrors, so they are likely to represent 
only a small minority of downloads: the total number is much (more than an 
order of magnitude) greater.  Companies that support Tomcat, such as 
[[http://www.springsource.com|SpringSource]] claim more than half of the global 
Fortune 500 as their clients. [[http://www.profischnell.com|Übersetzung]]
+ This page is a list of some, in all likelihood a very small fraction 
actually, of the sites out there that use [[http://tomcat.apache.org|Apache 
Tomcat]] in production.  For security and other policy-related reasons, many 
organizations choose not to disclose the server they use.  Tomcat has been 
downloaded more than 10 million times: assuming even a 1% production adoption 
rate results in more than 10 installations.  As an aside for the curious, 
you can see recent Tomcat download statistics on 
[[http://people.apache.org/~vgritsenko/stats/projects/tomcat.html|Vadim 
Gritsenko's page]].  Note, however, that these represent downloads from 
apache.org servers only, and not from mirrors, so they are likely to represent 
only a small minority of downloads: the total number is much (more than an 
order of magnitude) greater.  Companies that support Tomcat, such as 
[[http://www.springsource.com|SpringSource]] claim more than half of the global 
Fortune 500 as their clients.
  
- This page is organized by categories: [[#pub|sites with publications]], 
[[#user|sites added by users]], [[#surveys|independent surveys]], and 
[[#more|more]].  Anyone can and is encouraged to add to this page: please add 
your site, application, or system as you see fit.  You do need to register with 
the Apache wiki system to edit this page: simply click the login or user 
preferences links at the top right of your screen to do so.  Don't worry if you 
don't think it fits here or into any particular category: we would like to see 
your application listed no matter how big, how small, or how miscategorized ;)  
Some of these applications are simply compatible with, ship with, or run on 
Tomcat.  Others are specifically designed or documented with Tomcat as the 
container in mind. [[http://www.profi-fachuebersetzung.de|Übersetzer]]
+ This page is organized by categories: [[#pub|sites with publications]], 
[[#user|sites added by users]], [[#surveys|independent surveys]], and 
[[#more|more]].  Anyone can and is encouraged to add to this page: please add 
your site, application, or system as you see fit.  You do need to register with 
the Apache wiki system to edit this page: simply click the login or user 
preferences links at the top right of your screen to do so.  Don't worry if you 
don't think it fits here or into any particular category: we would like to see 
your application listed no matter how big, how small, or how miscategorized ;)  
Some of these applications are simply compatible with, ship with, or run on 
Tomcat.  Others are specifically designed or documented with Tomcat as the 
container in mind.
  
  Please note that all the corporate logos and names used below are trademarked 
by their respective organizations.  These organizations are not affiliated with 
this web site or with The Apache Software Foundation, and make no claims 
regarding The Foundation or its products.  Further, in most cases the companies 
are not aware of their being listed on this site at all.
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1069844 - /tomcat/trunk/java/org/apache/naming/resources/ResourceAttributes.java

2011-02-11 Thread markt
Author: markt
Date: Fri Feb 11 15:39:52 2011
New Revision: 1069844

URL: http://svn.apache.org/viewvc?rev=1069844view=rev
Log:
Remove deprecated code

Modified:
tomcat/trunk/java/org/apache/naming/resources/ResourceAttributes.java

Modified: tomcat/trunk/java/org/apache/naming/resources/ResourceAttributes.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/resources/ResourceAttributes.java?rev=1069844r1=1069843r2=1069844view=diff
==
--- tomcat/trunk/java/org/apache/naming/resources/ResourceAttributes.java 
(original)
+++ tomcat/trunk/java/org/apache/naming/resources/ResourceAttributes.java Fri 
Feb 11 15:39:52 2011
@@ -507,18 +507,6 @@ public class ResourceAttributes implemen
 
 
 /**
- * Set last modified date.
- * 
- * @param lastModified New last modified date value
- * @deprecated
- */
-@Deprecated
-public void setLastModified(Date lastModified) {
-setLastModifiedDate(lastModified);
-}
-
-
-/**
  * Get lastModified date.
  * 
  * @return LastModified date value



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50737] Error on .war deploy - archive malformed (on recent Tomcat releases) on IBM iSeries System i

2011-02-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50737

--- Comment #2 from Mark Thomas ma...@apache.org 2011-02-11 10:43:31 EST ---
This looks like a JVM bug at this point. I think the best we can do is add some
debug logging to help track this down. If I add the looging to Tomcat 7, can
you build Tomcat 7.0.x from svn and test?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1069857 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-02-11 Thread markt
Author: markt
Date: Fri Feb 11 16:14:54 2011
New Revision: 1069857

URL: http://svn.apache.org/viewvc?rev=1069857view=rev
Log:
Proposal

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1069857r1=1069856r2=1069857view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Feb 11 16:14:54 2011
@@ -107,3 +107,10 @@ PATCHES PROPOSED TO BACKPORT:
   http://svn.apache.org/viewvc?rev=1069824view=rev
   +1: markt
   -1:
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50734
+  Return 404 rather than 400 for requests to / when no ROOT context is deployed
+  https://issues.apache.org/bugzilla/attachment.cgi?id=26626
+  Patch provided by Violeta Georgieva
+  +1: markt
+  -1:



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50734] 400 Bad Request when there are no web applications deployed on Tomcat 6.0.32

2011-02-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50734

--- Comment #3 from Mark Thomas ma...@apache.org 2011-02-11 11:15:18 EST ---
Thanks for the patch. I have proposed it for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50737] Error on .war deploy - archive malformed (on recent Tomcat releases) on IBM iSeries System i

2011-02-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50737

--- Comment #3 from Jon E. j...@jonericson.com 2011-02-11 11:24:22 EST ---
I modified the ExpandWar class to spit out the failed comparison values in the
validate method right before the exception is thrown.  After stuffing the
modified class back into the Catalina.jar and testing the deployment again, I
could see  the problem appears to be with with case of the value of the root
folder being returned by the getCononicalPath() method.

I am currently working with IBM support on this issue, and will post back once
we have a definitive answer.  There is a theory as to the cause and we are in
the process of verifying it.  I will definitely post back here when we have a
solid answer.

btw - Konstantin's comment about the ExpandWar class really helped put me on
the right track - thank you!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1069864 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PooledConnection.java

2011-02-11 Thread fhanik
Author: fhanik
Date: Fri Feb 11 16:32:41 2011
New Revision: 1069864

URL: http://svn.apache.org/viewvc?rev=1069864view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=50759
Update validation timestamp if using an external validator.


Modified:

tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PooledConnection.java

Modified: 
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PooledConnection.java?rev=1069864r1=1069863r2=1069864view=diff
==
--- 
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
 (original)
+++ 
tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
 Fri Feb 11 16:32:41 2011
@@ -417,7 +417,12 @@ public class PooledConnection {
 }
 
 if (poolProperties.getValidator() != null) {
-return poolProperties.getValidator().validate(connection, 
validateAction);
+if (poolProperties.getValidator().validate(connection, 
validateAction)) {
+this.lastValidated = now;
+return true;
+} else {
+return false;
+}
 }
 
 String query = sql;



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50759] ValidatorClassName Validation fails to set lastValidated timestamp

2011-02-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50759

Filip Hanik fha...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Filip Hanik fha...@apache.org 2011-02-11 11:32:55 EST ---
Thanks for the report.
Fixed in r1069864

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1069876 - in /tomcat/trunk/modules/jdbc-pool: build.properties.default doc/changelog.xml sign.sh

2011-02-11 Thread fhanik
Author: fhanik
Date: Fri Feb 11 16:42:05 2011
New Revision: 1069876

URL: http://svn.apache.org/viewvc?rev=1069876view=rev
Log:
doco and version update

Modified:
tomcat/trunk/modules/jdbc-pool/build.properties.default
tomcat/trunk/modules/jdbc-pool/doc/changelog.xml
tomcat/trunk/modules/jdbc-pool/sign.sh

Modified: tomcat/trunk/modules/jdbc-pool/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/build.properties.default?rev=1069876r1=1069875r2=1069876view=diff
==
--- tomcat/trunk/modules/jdbc-pool/build.properties.default (original)
+++ tomcat/trunk/modules/jdbc-pool/build.properties.default Fri Feb 11 16:42:05 
2011
@@ -28,7 +28,7 @@
 version.major=1
 version.minor=0
 version.build=9
-version.patch=3
+version.patch=4
 version.suffix=
 
 # - Default Base Path for Dependent Packages -

Modified: tomcat/trunk/modules/jdbc-pool/doc/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/doc/changelog.xml?rev=1069876r1=1069875r2=1069876view=diff
==
--- tomcat/trunk/modules/jdbc-pool/doc/changelog.xml (original)
+++ tomcat/trunk/modules/jdbc-pool/doc/changelog.xml Fri Feb 11 16:42:05 2011
@@ -28,6 +28,14 @@
   /properties
 
 body
+section name=Tomcat JDBC Connection Pool 1.0.9.4
+  subsection name=pool
+changelog
+  fixrev1069864/rev bug50759/bug Correctly set validation 
timestamp when using external validator.(fhanik)/fix
+/changelog
+  /subsection
+/section
+
 section name=Tomcat JDBC Connection Pool 1.0.9.3
   subsection name=pool
 changelog

Modified: tomcat/trunk/modules/jdbc-pool/sign.sh
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/sign.sh?rev=1069876r1=1069875r2=1069876view=diff
==
--- tomcat/trunk/modules/jdbc-pool/sign.sh (original)
+++ tomcat/trunk/modules/jdbc-pool/sign.sh Fri Feb 11 16:42:05 2011
@@ -15,7 +15,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-VERSION=v1.0.9.3
+VERSION=v1.0.9.4
 for i in $(find output/release/$VERSION -name *.zip -o -name *.tar.gz); do
   echo Signing $i
   echo $1|gpg --passphrase-fd 0 -a -b $i



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1069774 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-02-11 Thread Konstantin Kolinko
2011/2/11  ma...@apache.org:
 Author: markt
 Date: Fri Feb 11 12:31:08 2011
 New Revision: 1069774

 URL: http://svn.apache.org/viewvc?rev=1069774view=rev
 Log:
 Proposal, vote

 Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt


 +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50752
 +  Correct typo
 +  http://svn.apache.org/viewvc?rev=1069770view=rev
 +  +1: markt
 +  -1:

Corrections to messages are CTR as long as it does not change the
parameters that are passed to it. Feel free to go on.  Anyway, my +1.
http://wiki.apache.org/tomcat/TomcatVersions#RTC_Exceptions

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 50726] Jasper can generate uncompilable source code if genStringAsCharArray is turned on

2011-02-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50726

--- Comment #4 from Mark Thomas ma...@apache.org 2011-02-11 13:03:45 EST ---
For info, it appears the the Eclipse compiler does not enforce this limit.
Dynamic compilation works whereas pre-compilation fails.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Connection draining when upload to large

2011-02-11 Thread Christopher Schultz
William,

On 2/10/2011 4:51 PM, William A. Rowe Jr. wrote:
 On 2/10/2011 7:04 AM, Rainer Jung wrote:
 Servlet 3 standardizes file uploads. It contains the ability to limit on 
 request size,
 pretty much the same as commons fileupload supported for many years.

 It seems when this conditions triggers the rest of the request inout stream 
 is still
 drained at the end of the request. swallowInput is not being set to false.

 It seems there's still no server-side prevention against huge uploads 
 possible. The upload
 is not put into memory, but the thread is only freed once the whole request 
 body is read.
 Shouldn't Tomcat ignore the rest of data and close the connection in this 
 case?
 
 In HTTP, this is required if you will reject the request with a status.

I didn't realize that. Can you point me to a reference to the portion of
the spec that requires that?

 The behavior is RFC-correct per Apache httpd's design, which has been
 debated on plenty of occasions and the finger always goes back to
 RFC 2616 correctness.

This seems like something we could allow with a non-default
configuration setting. We have all kinds of options in Tomcat that allow
non-servlet-spec-compliant behavior.

-chris



signature.asc
Description: OpenPGP digital signature


Re: Connection draining when upload to large

2011-02-11 Thread Christopher Schultz
Mark,

On 2/11/2011 4:37 AM, Mark Thomas wrote:
 On 10/02/2011 21:32, Christopher Schultz wrote:
 Rainer,

 On 2/10/2011 8:04 AM, Rainer Jung wrote:
 It seems there's still no server-side prevention against huge uploads
 possible. The upload is not put into memory, but the thread is only
 freed once the whole request body is read. Shouldn't Tomcat ignore the
 rest of data and close the connection in this case?

 +1

 I've always wondered why Tomcat drains the input stream instead of just
 closing it.

 I could write a client that does a PUT or POST with no Content-Length
 and just send 1 byte every second or so and tie up a request thread
 indefinitely. That seems dangerous.
 
 That is a different issue. You are describing a slowloris attack. The
 simple mitigation for that is to use the NIO connector.

Good point.

-chris



signature.asc
Description: OpenPGP digital signature


DO NOT REPLY [Bug 50737] Error on .war deploy - archive malformed (on recent Tomcat releases) on IBM iSeries System i

2011-02-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50737

--- Comment #4 from Jon E. j...@jonericson.com 2011-02-11 14:51:27 EST ---
The problem occurs when Tomcat (on the iSeries / System i / AS400) is started
with a command line that has different case values than where the file system
resides.

We configured the IBM System i to start Tomcat with the following QShell
command:

qsh cmd('/Apache/apache-tomcat-6.0.32/bin/startup.sh')

Yet the real name where Tomcat resides is:

/apache/apache-tocmat-6.0.32/bin/startup.sh

Deployment fails when they are not equal, even though Tomcat is running.

In ExpandWar, when it compares the canonical paths, the
expandedFile.getCononicalPath() value is the value that was used to start
Tomcat, and the canonicalDocBasePrefix is set to the value of where the .jar
file entries reside on the file system.

/Apache/apache-tomcat-6.0.32/bin/startup.sh != 
/apache/apache-tomcat-6.0.32/bin/startup.sh

Previously we were using Tomcat 6.0.20, which did not have this validation in
class ExpandWar.  On hosts that do not have case sensitive file systems, should
the path names all be resolved to lower case before this check?

WORK AROUND:  On our system, we changed the command string that starts Tomcat
to be exactly the same, case-for-case, as the directory in which it resides. 
When this is done, deployment works fine.

Thank you for your help.

- Jon

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of AdminGroup by SebastianBazley

2011-02-11 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Tomcat Wiki for change 
notification.

The AdminGroup page has been changed by SebastianBazley.
http://wiki.apache.org/tomcat/AdminGroup

--

New page:

This is a list of people who can do editing of the LocalBadContent page: 
 * ChuckCaldarale
 * KonstantinKolinko
 * markt
 * SebastianBazley

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of AdminGroup by SebastianBazley

2011-02-11 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Tomcat Wiki for change 
notification.

The AdminGroup page has been changed by SebastianBazley.
http://wiki.apache.org/tomcat/AdminGroup?action=diffrev1=1rev2=2

--

+ #acl AdminGroup:read,write,admin,revert,delete All:read
  
  This is a list of people who can do editing of the LocalBadContent page: 
   * ChuckCaldarale

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Tomcat Wiki spam prevention

2011-02-11 Thread sebb
On 31 January 2011 13:26, sebb seb...@gmail.com wrote:
 On 31 January 2011 09:09, Apache Wiki wikidi...@apache.org wrote:
 Dear wiki user,

 You have subscribed to a wiki page Tomcat Wiki for change notification.

 The page PoweredBy has been reverted to revision 305 by KonstantinKolinko.
 The comment on this change is: Reverted to r305 to remove spam.
 http://wiki.apache.org/tomcat/PoweredBy?action=diffrev1=306rev2=307

 --

 You can prevent these spam URLs by updating the following page:

 http://wiki.apache.org/tomcat/LocalBadContent

 (Unfortunately the /general/ version of the page now only applies to
 its own Wiki).

 There should be a page

 http://wiki.apache.org/tomcat/AdminGroup

 which controls access to the LocalBadContent page.

 I tried creating AdminGroup, but failed. Might need to involve infra
 in resolving this.

Just tried again, and succeeded this time, so I have updated the
LocalBadContent to add the SPAM URLs favoured by prosch.

I added some Tomcat PMCers to the AdminGroup who have been active in
fixing the Wiki recently; any of those can update the AdminGroup page
to allow access to further Wiki guardians.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org