DO NOT REPLY [Bug 51234] New: NumberFormatException in fmt:formatNumber tag
https://issues.apache.org/bugzilla/show_bug.cgi?id=51234
Bug #: 51234
Summary: NumberFormatException in fmt:formatNumber tag
Product: Taglibs
Version: 1.1.0
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Standard Taglib
AssignedTo: dev@tomcat.apache.org
ReportedBy: a.kup...@gmail.com
Classification: Unclassified
http://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/impl/src/main/java/org/apache/taglibs/standard/tag/common/fmt/FormatNumberSupport.java
Cut
if (input instanceof String) {
try {
if (((String) input).indexOf('.') != -1) {
input = Double.valueOf((String) input);
} else {
input = Long.valueOf((String) input);
}
} catch (NumberFormatException nfe) {
throw new JspException(
Resources.getMessage(FORMAT_NUMBER_PARSE_ERROR,
input),
nfe);
}
}
End of cut ==
What about string value 0e-8? It is a normal zero value but exception throws.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51181] Add support for Web Sockets
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 --- Comment #7 from Filip Hanik fha...@apache.org 2011-05-20 14:39:57 UTC --- true, web sockets are really nothing more than comet, with some additional packet info, and that could be deal with using an InputFilter -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51234] NumberFormatException in fmt:formatNumber tag
https://issues.apache.org/bugzilla/show_bug.cgi?id=51234 --- Comment #1 from Christopher Schultz ch...@christopherschultz.net 2011-05-20 15:24:57 UTC --- I don't see any documentation that mandates what formats are acceptable to the value attribute of this tag. One could argue that it doesn't accept European-style decimals numbers like 1,05 for 1 + point-oh-five, etc. (that's what fmt:parseNumber is for). But it's true that 0e-8 is a valid String-value for a double, so the code could afford to be modified at least slightly. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51181] Add support for Web Sockets
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 --- Comment #8 from Nikolas nikolasarmstr...@gmail.com 2011-05-20 15:34:44 UTC --- @Mark Thomas If practical. Heh @Filip Hanik It is not the same thing as Comet, clearly you've never actually done any development with Comet or Websockets. I can't have you polluting this thread with misinformation. The overhead in both server resources, latency, and throughput makes Comet laughable in comparison to websockets. Its an ok fallback solution for asynchronous communication but it's by no means on the same level as websockets. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 33453] Jasper should recompile JSP files whose datestamps change in either direction (not just newer)
https://issues.apache.org/bugzilla/show_bug.cgi?id=33453 --- Comment #67 from Mark Thomas ma...@apache.org 2011-05-20 16:26:13 UTC --- Created attachment 27040 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27040 Proposed patch for Tomcat 7 Having spent a little time on this, I am attaching a proposed patch for Tomcat 7. The patch breaks binary compatibility for compiled JSPs which I am not at all comfortable about. I have some ideas for a solution to that which I will be discussing on the dev list. If this issue is addressed in Tomcat 7, I don't see the fix being back-ported to earlier versions. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Fixing bug 33453
All, I've been looking at [1]. Ignoring the flames, there do appear to be several use cases where the current time-stamp checks are insufficient (although there are simple work-arounds). I have a patch [2] but I don't particularly like the fact that it breaks binary compatibility with JSPs compiled with an earlier version. My instinct is that this is bad. What does everyone else think? I do have an idea for addressing this: - Leave JspSourceDependent as is in 7.0.14 but deprecate it - Add a new JspSourceDependent2 interface (better names welcome) - Compilation always uses JspSourceDependent2 - Isoutdated checked for JspSourceDependent as well as JspSourceDependent2 and any classes implementing JspSourceDependent are treated as outdated. Thoughts? Mark [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=33453 [2] https://issues.apache.org/bugzilla/attachment.cgi?id=27040action=diff - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 33671] Manual Windows service installation with custom name using service.bat fails.
https://issues.apache.org/bugzilla/show_bug.cgi?id=33671 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||INVALID --- Comment #6 from Mark Thomas ma...@apache.org 2011-05-20 16:41:25 UTC --- The patch is for Commons Daemon which is a dependency of Tomcat. I have created https://issues.apache.org/jira/browse/DAEMON-206 to track this. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1125461 - in /tomcat/trunk/java/org/apache/catalina/startup: EngineConfig.java HomesUserDatabase.java
Author: markt
Date: Fri May 20 16:52:50 2011
New Revision: 1125461
URL: http://svn.apache.org/viewvc?rev=1125461view=rev
Log:
Minor clean-up
Modified:
tomcat/trunk/java/org/apache/catalina/startup/EngineConfig.java
tomcat/trunk/java/org/apache/catalina/startup/HomesUserDatabase.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/EngineConfig.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/EngineConfig.java?rev=1125461r1=1125460r2=1125461view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/EngineConfig.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/EngineConfig.java Fri May 20
16:52:50 2011
@@ -66,6 +66,7 @@ public class EngineConfig
*
* @param event The lifecycle event that has occurred
*/
+@Override
public void lifecycleEvent(LifecycleEvent event) {
// Identify the engine we are associated with
Modified: tomcat/trunk/java/org/apache/catalina/startup/HomesUserDatabase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/HomesUserDatabase.java?rev=1125461r1=1125460r2=1125461view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/HomesUserDatabase.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/startup/HomesUserDatabase.java Fri
May 20 16:52:50 2011
@@ -71,6 +71,7 @@ public final class HomesUserDatabase
/**
* Return the UserConfig listener with which we are associated.
*/
+@Override
public UserConfig getUserConfig() {
return (this.userConfig);
@@ -83,6 +84,7 @@ public final class HomesUserDatabase
*
* @param userConfig The new UserConfig listener
*/
+@Override
public void setUserConfig(UserConfig userConfig) {
this.userConfig = userConfig;
@@ -99,6 +101,7 @@ public final class HomesUserDatabase
*
* @param user User for which a home directory should be retrieved
*/
+@Override
public String getHome(String user) {
return homes.get(user);
@@ -109,6 +112,7 @@ public final class HomesUserDatabase
/**
* Return an enumeration of the usernames defined on this server.
*/
+@Override
public EnumerationString getUsers() {
return (homes.keys());
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51235] New: Access Violation in httpd.exe originating in mod_jk code while getting sessionid from headers
https://issues.apache.org/bugzilla/show_bug.cgi?id=51235 Bug #: 51235 Summary: Access Violation in httpd.exe originating in mod_jk code while getting sessionid from headers Product: Tomcat Connectors Version: 1.2.28 Platform: PC OS/Version: Windows Server 2003 Status: NEW Severity: major Priority: P2 Component: mod_jk AssignedTo: dev@tomcat.apache.org ReportedBy: pierre.boudr...@t4g.com Classification: Unclassified Created attachment 27041 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27041 Screen shots of one of crash dumps in Visual Studio 2010 debugger This happens in our production environment almost every day. It causes the Apache httpd.exe process to crash and restart itself. The error shows up in the Windows event log as: Faulting application httpd.exe, version 2.2.17.0, faulting module msvcrt.dll, version 7.0.3790.3959, fault address 0x00038bab. We have not been able to reproduce it with tests, but we do have several crash dumps that can be used to debug. The fault is always in exactly the same spot in the mod_jk code. I opened one of the crash dumps in Visual Studio 2010 and tried to find the problem. I found that the code is going out of bounds of an array in get_sessionid() in jk_lb_worker.c because the num_headers in jk_ws_service_t that gets passed in ot the get_sessionid method is bigger than the actual number of headers in header_names and header_values. See ApacheCrash_2.png in the attached zip file. I don't know how it got this way though... I can provide crash dumps to someone who can look into this. We get new ones regularly. Configuration: 2 load balanced web servers running httpd 2.2.17 mod_jk 1.2.28 on Windows Server 2003 6 JBOSS 4.2 workers running ATG 9.0 application using mod_jk loadbalancer -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51235] Access Violation in httpd.exe originating in mod_jk code while getting sessionid from headers
https://issues.apache.org/bugzilla/show_bug.cgi?id=51235 Pierre Boudreau pierre.boudr...@t4g.com changed: What|Removed |Added CC||pierre.boudr...@t4g.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 35054] warn if appBase is not existing as a File or directory
https://issues.apache.org/bugzilla/show_bug.cgi?id=35054 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||FIXED --- Comment #5 from Mark Thomas ma...@apache.org 2011-05-20 18:11:32 UTC --- Specifying a non-existing appBase is not necessarily invalid. By default, Tomcat 7 will create the appBase if it does not already exist. I have tweaked the tests Tomcat does in case a file is specified as an appBase. I do not propose back-porting this to Tomcat 5 or 6. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1125492 - in /tomcat/trunk: java/org/apache/catalina/startup/HostConfig.java webapps/docs/changelog.xml
Author: markt
Date: Fri May 20 18:11:53 2011
New Revision: 1125492
URL: http://svn.apache.org/viewvc?rev=1125492view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=35054
Check that a file is not specified for a Host's appBase and log an error if it
is.
Modified:
tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java?rev=1125492r1=1125491r2=1125492view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/HostConfig.java Fri May 20
18:11:53 2011
@@ -1312,7 +1312,7 @@ public class HostConfig
if (host.getCreateDirs()) {
File[] dirs = new File[] {appBase(),configBase()};
for (int i=0; idirs.length; i++) {
-if ( (!dirs[i].exists()) (!dirs[i].mkdirs())) {
+if ( (!dirs[i].isDirectory()) (!dirs[i].mkdirs())) {
log.error(sm.getString(hostConfig.createDirs,dirs[i]));
}
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1125492r1=1125491r2=1125492view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri May 20 18:11:53 2011
@@ -46,6 +46,10 @@
subsection name=Catalina
changelog
fix
+bug35054/bug: Check that a file is not specified for a Hostapos;s
+appBase and log an error if it is. (markt)
+ /fix
+ fix
bug51197/bug: Fix possible dropped connection when sendError or
sendRedirst are used during async processing. (markt)
/fix
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51235] Access Violation in httpd.exe originating in mod_jk code while getting sessionid from headers
https://issues.apache.org/bugzilla/show_bug.cgi?id=51235 --- Comment #1 from William A. Rowe Jr. wr...@apache.org 2011-05-20 18:21:53 UTC --- 1.2.28 is old, and there have been a few bug fixes that could have touched this. Can you reproduce with 1.2.31? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51235] Access Violation in httpd.exe originating in mod_jk code while getting sessionid from headers
https://issues.apache.org/bugzilla/show_bug.cgi?id=51235 --- Comment #2 from Pierre Boudreau pierre.boudr...@t4g.com 2011-05-20 18:34:16 UTC --- I have not tried reproducing it with 1.2.31, but I have looked through the changelog and compared the code between the two versions and didn't see anything that looked like it addressed this. Only a couple lines of code have changed in jk_lb_worker.c where the fault happens and they are not near the location of the fault... Of course, the root cause could be somewhere else... Considering that this only happens in our production environment, I have been reluctant to upgrade without some indication that there is a good chance that it will resolve the problem. Do some particular bug fixes come to mind that could have indirectly fixed this? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51195] Find leaks reports a false positive memory/classloader leak
https://issues.apache.org/bugzilla/show_bug.cgi?id=51195 --- Comment #5 from Mark Thomas ma...@apache.org 2011-05-20 18:58:43 UTC --- A couple of comments on the proposed patch. 1. This looks like clean-up code and as such is better placed in the WebappClassLoader as another ClearReferencesXXX method. 2. Rather than clearing the entire map, it would be better to iterate over the map and remove only those entries that had been loaded by the class WebappClassLoader currently being stopped. In terms of checking the build, ant should suffice rather than the full ant release. You;ll still get a working Tomcat instance you can test in output/build. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 36569] Redirects produce illegal URL's
https://issues.apache.org/bugzilla/show_bug.cgi?id=36569 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||WONTFIX --- Comment #6 from Mark Thomas ma...@apache.org 2011-05-20 19:04:00 UTC --- Hmm. No patch has been forthcoming and I don't recall this as something that users are complaining about on the users list. Given that if the API is used as recommended by the spec, this should be a non-issue I am resolving this as WONTFIX. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 37018] Document how to use tomcat-SSL with a pkcs11 token
https://issues.apache.org/bugzilla/show_bug.cgi?id=37018 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||WONTFIX --- Comment #3 from Mark Thomas ma...@apache.org 2011-05-20 19:07:34 UTC --- The Sun URL no longer works - it redirects to the home page for the Oracle forums. Since bug 40677 has been fixed, I don't see much more that can be done here. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 40712] Realm admin error.
https://issues.apache.org/bugzilla/show_bug.cgi?id=40712 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #3 from Mark Thomas ma...@apache.org 2011-05-20 19:12:09 UTC --- The administration web application no longer exists in 6.0.x onwards. The direction things are moving in (slowly) is to generally improve the JMX interface. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 37334] Realm digest property not aligned with the administration console functionalities
https://issues.apache.org/bugzilla/show_bug.cgi?id=37334 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||WONTFIX --- Comment #5 from Mark Thomas ma...@apache.org 2011-05-20 19:12:54 UTC --- The administration web application no longer exists in 6.0.x onwards. The direction things are moving in (slowly) is to generally improve the JMX interface. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51235] Access Violation in httpd.exe originating in mod_jk code while getting sessionid from headers
https://issues.apache.org/bugzilla/show_bug.cgi?id=51235 --- Comment #3 from Rainer Jung rainer.j...@kippdata.de 2011-05-20 19:23:19 UTC --- If you really can not upgrade: could you tell us, what the header names and values are? The screenshot looks like the num_headers is 10, but it doesn't give us any info about how many headers are in the arrays and what the names and values are. If you could provide a list of names and values, we might be able to guess the root cause. Regards, Rainer -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51234] NumberFormatException in fmt:formatNumber tag
https://issues.apache.org/bugzilla/show_bug.cgi?id=51234 --- Comment #2 from Alexander Kupcov a.kup...@gmail.com 2011-05-20 19:45:51 UTC --- I'm getting data from a database query. One of the values - 0 in the form of 0E-8 and this value can not be shown in the output JSP because an exception is thrown. I do not use European-style decimals numbers. I think one of the solutions - in this example, besides the point look for the presence of a character 'e' (and 'E'). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51234] NumberFormatException in fmt:formatNumber tag
https://issues.apache.org/bugzilla/show_bug.cgi?id=51234 --- Comment #3 from Kris Schneider kschnei...@gmail.com 2011-05-20 20:09:41 UTC --- From the JSTL 1.2 spec: If the numeric value is given as a string literal, it is first parsed into a java.lang.Number. If the string does not contain any decimal point, it is parsed using java.lang.Long.valueOf(), or java.lang.Double.valueOf() otherwise. So the code appears to at least match the spec, for what it's worth. As a workaround, perhaps you can make use of the pattern attribute... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38268] User friendly: Need submit button on adding/deleting user
https://issues.apache.org/bugzilla/show_bug.cgi?id=38268 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED Component|Servlet JSP API |Webapps:Administration Resolution||WONTFIX --- Comment #3 from Mark Thomas ma...@apache.org 2011-05-20 20:38:47 UTC --- The administration web application no longer exists in 6.0.x onwards. The direction things are moving in (slowly) is to generally improve the JMX interface. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51185] Performance : DataSourceProxy#createPool should use more fine grained synchronisation
https://issues.apache.org/bugzilla/show_bug.cgi?id=51185 --- Comment #5 from Philippe Mouawad p.moua...@ubik-ingenierie.com 2011-05-20 21:06:25 UTC --- Hello, Is there something missing in the patch ? Do you think it is wrong ? Thank you Regards Philippe -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51198] Trunk Version : Performance enhancement in ConnectionPool regarding busy Queue
https://issues.apache.org/bugzilla/show_bug.cgi?id=51198 --- Comment #1 from Philippe Mouawad p.moua...@ubik-ingenierie.com 2011-05-20 21:07:43 UTC --- Hello, Is there something wrong in the patch ? I have been doing very High load tests during all the week and all seems OK. Regards Philippe -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51237] New: SlowQueryReport interceptor does not log anything
https://issues.apache.org/bugzilla/show_bug.cgi?id=51237 Bug #: 51237 Summary: SlowQueryReport interceptor does not log anything Product: Tomcat Modules Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: jdbc-pool AssignedTo: dev@tomcat.apache.org ReportedBy: hay_d...@yahoo.com Classification: Unclassified The documentation I've seen for the SlowQueryInterceptor (http://people.apache.org/~fhanik/jdbc-pool/jdbc-pool.html#org.apache.tomcat.jdbc.pool.interceptor.SlowQueryReport) indicate that it is supposed to log a message with level WARN when a slow query is detected or there is a failure. However, it appears that no logging is ever done. reportSlowQuery and reportFailedQuery simply record the event with the QueryStats object. No call to the logging framework is ever made. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1125573 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
Author: fhanik
Date: Fri May 20 22:03:39 2011
New Revision: 1125573
URL: http://svn.apache.org/viewvc?rev=1125573view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=51185
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java?rev=1125573r1=1125572r2=1125573view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
Fri May 20 22:03:39 2011
@@ -92,7 +92,20 @@ public class DataSourceProxy implements
* @return Driver
* @throws SQLException
*/
-public synchronized ConnectionPool createPool() throws SQLException {
+public ConnectionPool createPool() throws SQLException {
+if (pool != null) {
+return pool;
+} else {
+return pCreatePool();
+}
+}
+
+/**
+ * Sets up the connection pool, by creating a pooling driver.
+ * @return Driver
+ * @throws SQLException
+ */
+private synchronized ConnectionPool pCreatePool() throws SQLException {
if (pool != null) {
return pool;
} else {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51185] Performance : DataSourceProxy#createPool should use more fine grained synchronisation
https://issues.apache.org/bugzilla/show_bug.cgi?id=51185 Filip Hanik fha...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #6 from Filip Hanik fha...@apache.org 2011-05-20 22:03:36 UTC --- sorry for the delay, fixed in r1125573 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51181] Add support for Web Sockets
https://issues.apache.org/bugzilla/show_bug.cgi?id=51181 --- Comment #9 from Filip Hanik fha...@apache.org 2011-05-20 22:20:21 UTC --- (In reply to comment #8) @Filip Hanik It is not the same thing as Comet, clearly you've never actually done any development with Comet or Websockets. I can't have you polluting this thread with misinformation. The overhead in both server resources, latency, and throughput makes Comet laughable in comparison to websockets. Its an ok fallback solution for asynchronous communication but it's by no means on the same level as websockets. misinformed, I like that. I was commenting from an implementation standpoint at the connector level. We can piggy back on the low level comet notifications we have implemented in the endpoints. At the processor level, we would need an inputfilter to handle package dissemination. and at the servlet level, provide new interfaces for DataPackets before you call people misinformed, read the source code of tomcat, read the websocket spec, and you'll arrive at the same conclusion. now, go and inform yourself!! -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51235] Access Violation in httpd.exe originating in mod_jk code while getting sessionid from headers
https://issues.apache.org/bugzilla/show_bug.cgi?id=51235 --- Comment #4 from Pierre Boudreau pierre.boudr...@t4g.com 2011-05-20 22:22:30 UTC --- At first I thought there was only one header, which was showing in the watch window in one of the screen shots, but now I see there is the correct amount of header names and values. Below are header names and values for the crash dump I am looking at now. The fault happens while parsing the Cookies values for JSESSIONID. Anything unusual with that Cookie string? The spaces after the ; maybe? Are those supposed to be there? s-headers_names[0]0x66452f08 Host s-headers_values[0]0x66452f10 www.superstore.ca s-headers_names[1]0x66452f28 Accept-Encoding s-headers_values[1]0x66452f38 gzip s-headers_names[2]0x66452f40 Referer s-headers_values[2]0x66452f48 http://www.superstore.ca/LCLOnline/home.jsp?_requestid=18620; s-headers_names[3]0x66452f88 Accept-Language s-headers_values[3]0x66452f98 en-US s-headers_names[4]0x66452fa0 x-wap-profile s-headers_values[4]0x66452fb0 http://wap.sonyericsson.com/UAprof/X10aR201.xml; s-headers_names[5]0x66452fe0 User-Agent s-headers_values[5]0x66452ff0 Mozilla/5.0 (Linux; U; Android 2.1-update1; en-us; SonyEricssonX10a Build/2.0.A.0.504) AppleWebKit/530.17 (KHTML, like Gecko) Version/4.0 Mobile Safari/530.17 s-headers_names[6]0x66453090 Cookie s-headers_values[6]0x66453098 lclLastVsitedUserStore=203; ATG_SESSION_ID=MXBsllpe5HEZQUMWUFUtog**.node3; JSESSIONID=MXBsllpe5HEZQUMWUFUtog**.node3 s-headers_names[7]0x134ea6a8 Accept s-headers_values[7]0x134ea6b0 text/xml, text/html, application/xhtml+xml, image/png, text/plain, */*;q=0.8 s-headers_names[8]0x134ea700 Accept-Charset s-headers_values[8]0x134ea710 utf-8, iso-8859-1, utf-16, *;q=0.7 s-headers_names[9]0x6a6e7a80 content-length s-headers_values[9]0x6a6e7488 0 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51235] Access Violation in httpd.exe originating in mod_jk code while getting sessionid from headers
https://issues.apache.org/bugzilla/show_bug.cgi?id=51235 --- Comment #5 from Pierre Boudreau pierre.boudr...@t4g.com 2011-05-20 22:55:00 UTC --- I constructed a request with all the same headers with Firefox and the Poster add-on and send it to our dev server. It returned without crashing the httpd, so it looks like there's something more to it... I'll look at some other crash dumps to see if there is some kind of recurring pattern in the requests. This one was requesting an image, which returned fine when I sent the same request to our dev server. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51235] Access Violation in httpd.exe originating in mod_jk code while getting sessionid from headers
https://issues.apache.org/bugzilla/show_bug.cgi?id=51235 --- Comment #6 from Pierre Boudreau pierre.boudr...@t4g.com 2011-05-21 00:53:28 UTC --- Here's another one. A common thing that jumps out to me is that the User-Agent shows that both requests are coming from devices running Android 2.1-update1. I'm guessing that's not a coincidence. s-headers_names[3]0x78074330 Accept-Language s-headers_values[3]0x78074340 en-CA, en-US s-headers_names[4]0x78074350 x-wap-profile s-headers_values[4]0x78074360 http://wap.samsungmobile.com/uaprof/SGH-I896.xml; s-headers_names[5]0x78074398 User-Agent s-headers_values[5]0x780743a8 Mozilla/5.0 (Linux; U; Android 2.1-update1; en-ca; SAMSUNG-SGH-I896 Build/ECLAIR) AppleWebKit/530.17 (KHTML, like Gecko) Version/4.0 Mobile Safari/530.17 s-headers_names[6]0x78074448 Cookie s-headers_values[6]0x78074450 lclLastVsitedUserStore=24; ATG_SESSION_ID=uYF2WRWqtZMu65os-uonsA**.node24; JSESSIONID=uYF2WRWqtZMu65os-uonsA**.node24 s-headers_names[7]0x10eadd60 Accept s-headers_values[7]0x10eadd68 text/xml, text/html, application/xhtml+xml, image/png, text/plain, */*;q=0.8 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
