Bug report for Tomcat 6 [2012/08/12]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43400|New|Enh|2007-09-14|enum support for tag libs | |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag | |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI java.nam| |44787|New|Enh|2008-04-09|provide more error context on java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46263|New|Enh|2008-11-21|Tomcat reloading of context.xml does not update do| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46727|New|Enh|2009-02-17|DefaultServlet - serving multiple encodings | |46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch| |47214|New|Enh|2009-05-17|Inner classes that are explicitly referenced - sho| |47242|New|Enh|2009-05-22|request for AJP command line client | |47281|New|Enh|2009-05-28|Efficiency of the JDBCStore | |47407|New|Enh|2009-06-23|HttpSessionListener doesn't operate in the session| |47467|New|Enh|2009-07-02|Deployment of the war file by URL when contextpath| |47785|Opn|Enh|2009-09-04|Cluster MBean not registered | |47834|New|Enh|2009-09-14|TldConfig throws Exception when exploring unpacked| |47919|New|Enh|2009-09-30|Log Tomcat Java environment variables in additio| |48358|Opn|Enh|2009-12-09|JSP-unloading reloaded| |48543|New|Enh|2010-01-14|[Patch] More flexibility in specifying -Dcatalina.| |48672|New|Enh|2010-02-03|Tomcat Virtual Host Manager (/host-manager) have b| |48674|New|Enh|2010-02-03|Tomcat Virtual Host Manager application doesn't pe| |48743|New|Enh|2010-02-15|Make the SLEEP variable in catalina.sh settable fr| |48899|New|Enh|2010-03-12|Guess URI charset should solve lot of problems| |48922|New|Enh|2010-03-16|org.apache.catalina.connector.Request clone static| |48928|New|Enh|2010-03-17|An alternative solution to preloading classes when| |49161|New|Enh|2010-04-21|Unknown Publisher when installing tomcat 6.0.26 | |49176|Opn|Enh|2010-04-23|Jasper in Dev Mode Is Memory Inefficient | |49464|New|Enh|2010-06-18|DefaultServlet and CharacterEncoding | |49531|New|Enh|2010-06-30|singlesignon failover not working on DeltaManager/| |49804|New|Enh|2010-08-23|Allow Embedded.redirectStreams value to be configu| |49939|New|Enh|2010-09-16|Expose a method via JMX which empties the webapp f| |49943|New|Enh|2010-09-16|Logging (via juli) does not reread configuration c|
Bug report for Taglibs [2012/08/12]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements | |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Enh|2009-12-02|TLD generator | +-+---+---+--+--+ | Total5 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 5 [2012/08/12]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |52579|New|Reg|2012-02-02|Tomcat5.5.35?Java1.5 cannot return proper value of| |53050|New|Nor|2012-04-09|org.apache.catalina.session.ManagerBase has issues| +-+---+---+--+--+ | Total2 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Connectors [2012/08/12]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|Inf|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|Inf|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|Inf|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 apache 2.2.9 static compiled on so| |46337|New|Nor|2008-12-04|real worker name is wrong | |46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|Inf|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. | |49822|New|Enh|2010-08-25|Add hash lb worker method | |49903|New|Enh|2010-09-09|Make workers file reloadable | |50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c| |52334|New|Maj|2011-12-14|recover_time is not properly used | |52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus| |52651|New|Nor|2012-02-13|JKSHMFile size limitation | |53324|Opn|Nor|2012-05-30|Starting with mod_jk 1.2.35 I cannot modify worker| |53542|New|Min|2012-07-13|Spelling mistake on 503 service unavailable page | +-+---+---+--+--+ | Total 41 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 7 [2012/08/12]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to| |18500|New|Enh|2003-03-30|Host aliases to match by regular expression | |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel - | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing | |44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr| |48550|Inf|Enh|2010-01-14|Update examples and default server.xml to use UTF-| |49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak| |49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al| |49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm| |49821|New|Enh|2010-08-25|Tomcat CLI| |50019|New|Enh|2010-09-28|Adding JNDI lookup-name support In XML and Resou| |50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply| |50234|New|Enh|2010-11-08|JspC use servlet 3.0 features | |50504|New|Enh|2010-12-21|Allow setting query string character set trough re| |50670|New|Enh|2011-01-27|Tribes | RpcChannel | Add option to specify extern| |51195|New|Enh|2011-05-13|Find leaks reports a false positive memory/class| |51294|Opn|Enh|2011-05-30|Since 7.0.12 do not work option unpackWARs=true fo| |51423|Inf|Enh|2011-06-23|[Patch] to add a path and a version parameters to | |51463|New|Enh|2011-07-01|Tomcat.setBaseDir (package org.apache.catalina.st| |51496|New|Enh|2011-07-11|NSIS - Warn that duplicate service name will resul| |51497|New|Enh|2011-07-11|Use canonical IPv6 text representation in logs| |51526|New|Enh|2011-07-18|Process web application context config with embedd| |51587|New|Enh|2011-07-29|Implement status and uptime commands | |51953|New|Enh|2011-10-04|Proposal: netmask filtering valve and filter | |52092|New|Enh|2011-10-26|Please make AsyncFileHandler and OneLineFormatter | |52235|New|Enh|2011-11-23|Please do a bit of SEO tuning for the web site| |52236|New|Enh|2011-11-23|Idea: support 'overlays' shaped like Maven overlay| |52323|New|Enh|2011-12-13|Cobertura test code coverage support for build.xml| |52381|New|Enh|2011-12-22|Please add OSGi metadata | |52448|New|Enh|2012-01-11|Cache jar indexes in WebappClassLoader to speed up| |52489|New|Enh|2012-01-19|Enhancement request for code signing of war files | |52558|New|Enh|2012-01-30|CometConnectionManagerValve is adding non-serializ| |52688|New|Enh|2012-02-16|Add ability to remove old access log files| |52751|Opn|Enh|2012-02-23|Optimized configuration of the system info display| |52777|New|Enh|2012-02-27|Automatically shut down old versions in parallel d| |52952|New|Enh|2012-03-20|Improve ExtensionValidator handling for embedded s| |53071|Opn|Nor|2012-04-13|ErrorReportValve ignores message from throwable | |53085|New|Enh|2012-04-16|[perf] [concurrency] DefaultInstanceManager.annota| |53387|New|Enh|2012-06-08|SSI: Allow to use $1 to get result of regular expr| |53411|Opn|Enh|2012-06-13|NullPointerException in org.apache.tomcat.util.buf| |53469|Opn|Nor|2012-06-26|possible bug in Response.normalize(CharChunk cc) | |53492|New|Enh|2012-07-01|Make JspC shell multithreaded | |53553|New|Enh|2012-07-16|[PATCH] Deploy uploaded WAR with context.xml from | |53602|New|Enh|2012-07-25|Support for HTTP status code 451 | |53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l| |53623|New|Nor|2012-07-30|Incorrect request properties after AsyncContext.di| |53624|New|Nor|2012-07-30|sendRedirect doesn't work after a dispatch through|
Bug report for Tomcat Modules [2012/08/12]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers | |48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite | |48861|New|Nor|2010-03-04|Files without AL headers | |49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean | |49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da| |50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen| |51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho| |51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods | |52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o| |53088|Opn|Min|2012-04-17|Give PoolCleaner TimerTask a better name | |53198|New|Cri|2012-05-07|'driverClassName' Data Source Property Being Manda| |53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe| |53200|New|Enh|2012-05-07|Be able to use SlowQueryReport without reporting f| |53565|New|Min|2012-07-18|deprecated| +-+---+---+--+--+ | Total 14 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat Native [2012/08/12]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |45392|New|Nor|2008-07-14|No OCSP support for client SSL verification | |46179|Opn|Maj|2008-11-10|apr ssl client authentication | |48655|Inf|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | |51655|New|Nor|2011-08-12|Index page does not say what native does | |51813|New|Cri|2011-09-14|Tomcat randomly crashes with [libtcnative-1.so.1+0| |52153|New|Maj|2011-11-08|periodic JVM crash (access violation) on buffer fl| |52231|New|Nor|2011-11-23|Ant Tasks need to reflect changes in manager comma| |52319|New|Maj|2011-12-12|Tomcat 6 crashes with [libapr-1.so.0+0x196da] sig| |52627|New|Min|2012-02-08|Segmentation fault in org.apache.tomcat.jni.File.i| |52856|New|Maj|2012-03-08|High CPU load when the underlying socket error in | |53110|New|Cri|2012-04-20|Access Violation Error while creating SHM | |53605|New|Nor|2012-07-26|use tcnative-1.1.24 Tomcat shutdown still crash | +-+---+---+--+--+ | Total 13 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53700] New: InternalNioOutputBuffer unused (debug?) code
https://issues.apache.org/bugzilla/show_bug.cgi?id=53700 Priority: P2 Bug ID: 53700 Assignee: dev@tomcat.apache.org Summary: InternalNioOutputBuffer unused (debug?) code Severity: minor Classification: Unclassified OS: Windows XP Reporter: s...@apache.org Hardware: PC Status: NEW Version: trunk Component: Catalina Product: Tomcat 7 The class InternalNioOutputBuffer includes the field: int total = 0; This is currently defined at line 227, which is between the Javadoc and method body to which the Javadoc applies, i.e. private synchronized int writeToSocket. This invalidates the method Javadoc. The field is used to keep a running total of bytes written by the method; however the field is not actually referenced - the System.out.println statement is commented out. The field and associated code shcould probably be deleted. If the field is to be kept, it should be private, and it should probably be changed to long, and of course should be moved so it does not invalidate the method Javadoc. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53701] New: Javadoc fixes
https://issues.apache.org/bugzilla/show_bug.cgi?id=53701 Priority: P2 Bug ID: 53701 Assignee: dev@tomcat.apache.org Summary: Javadoc fixes Severity: minor Classification: Unclassified OS: All Reporter: s...@apache.org Hardware: All Status: NEW Version: trunk Component: Catalina Product: Tomcat 7 Created attachment 29214 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29214action=edit Javadoc fixes The attached patch fixes various Javadoc issues -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1372082 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml
Author: kkolinko Date: Sun Aug 12 12:43:28 2012 New Revision: 1372082 URL: http://svn.apache.org/viewvc?rev=1372082view=rev Log: Minor cleanups: Add missing ':' in changelog. Mark r1370549 as merged. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1370549 Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1372082r1=1372081r2=1372082view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Sun Aug 12 12:43:28 2012 @@ -238,7 +238,7 @@ declared in web.xml - unless metadata complete is set to true. (markt) /fix fix -bug53619/bugAs per clarification from the Servlet Expert Group, +bug53619/bug: As per clarification from the Servlet Expert Group, JARs will always be scanned for ServletContainerInitializers regardless of the setting of metadata complete. However, if an absolute ordering is specified and a JAR is excluded from that ordering it will not be - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-taglibs-standard has an issue affecting its community
integration.
This issue affects 2 projects,
and has been outstanding for 8 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-taglibs-standard : Standard Taglib
- tomcat-taglibs-standard-install : JSP Taglibs
Full details are available at:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-INFO- Optional dependency httpunit failed with reason build failed
-DEBUG- (Apache Gump generated) Apache Maven Settings in:
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
-INFO- Failed with reason build failed
-DEBUG- Maven POM in:
/srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml
-INFO- Failed to extract fallback artifacts from Gump Repository
The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html
Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build)
Work ended in a state of : Failed
Elapsed: 20 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
install
[Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard]
M2_HOME: /opt/maven2
-
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Nothing to compile - all classes are up to date
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/src/test/resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] No sources to compile
[INFO] [surefire:test {execution: default-test}]
[INFO] Tests are skipped.
[INFO] [bundle:bundle {execution: default-bundle}]
[INFO] [install:install {execution: default-install}]
[INFO] Installing
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/target/taglibs-standard-spec-1.2-SNAPSHOT.jar
to
/srv/gump/public/workspace/mvnlocalrepo/shared/org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] [bundle:install {execution: default-install}]
[INFO] Parsing
file:/srv/gump/public/workspace/mvnlocalrepo/shared/repository.xml
[INFO] Installing
org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] Writing OBR metadata
[INFO]
[INFO] Building JSTL Implementation
[INFO]task-segment: [install]
[INFO]
[INFO] [remote-resources:process {execution: default}]
[INFO] snapshot org.apache.taglibs:taglibs-standard-spec:1.2-SNAPSHOT: checking
for updates from apache.snapshots
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 14 resources
[INFO] Copying 3 resources
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 96 source files to
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/classes
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
error: DataSourceWrapper is not abstract and does not override abstract method
getParentLogger() in CommonDataSource
[INFO] 1 error
[INFO] -
[INFO]
[ERROR] BUILD FAILURE
[INFO]
[INFO] Compilation failure
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
error: DataSourceWrapper is not abstract and does not override abstract method
getParentLogger() in CommonDataSource
[INFO]
[INFO] For more information, run Maven with the -e switch
[INFO]
[Bug 53702] New: Only the last url-pattern from jsp-property-group is processed
https://issues.apache.org/bugzilla/show_bug.cgi?id=53702 Priority: P2 Bug ID: 53702 Assignee: dev@tomcat.apache.org Summary: Only the last url-pattern from jsp-property-group is processed Severity: normal Classification: Unclassified OS: Windows XP Reporter: knst.koli...@gmail.com Hardware: PC Status: NEW Version: 7.0.29 Component: Catalina Product: Tomcat 7 Created attachment 29215 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29215action=edit Modified files from the ROOT webapp According to XSDs (jsp_2_0.xsd, jsp_2_1.xsd, jsp_2_2.xsd), the url-pattern can occur more than once in the same jsp-property-group. [[[ xsd:complexType name=jsp-property-groupType ... xsd:element name=url-pattern type=javaee:url-patternType maxOccurs=unbounded/ ]]] There are three places where the jsp-property-group element is represented by an object in Tomcat: a) in Jasper, o.a.jasper.compiler.JspConfig$JspPropertyGroup b) in Catalina, o.a.catalina.deploy.JspPropertyGroup c) in Servlet 3.0 API, javax.servlet.descriptor.JspPropertyGroupDescriptor (implemented by o.a.c.core.ApplicationJspPropertyGroupDescriptor) The implementations in a) and c) are correct ones, but in b) the collection of url patterns is mistakenly represented by a single value and setUrlPattern() method. As the setUrlPattern method is called by digester (configured in o.a.c.startup.WebRuleSet), only the last url-pattern value survives. The observable consequences of this issue: === 1. Merged web.xml is reproduced and passed to Jasper incorrectly. (Currently it is passed only when metadata-complete=false or absent, as I noted in Re:r1371995 on dev@, which is a different issue but it hides the effect of this one). 2. A known feature is that the paths mentioned in jsp-property-group are implicitly mapped to the JspServlet. Due to this issue this mapping occurs only for the last url-pattern. (in WebXml#configureContext()) To reproduce in current 7.0.x (7.0.29 is affected): 1. Unpack attached archive and put the files into the ROOT webapp. The files are context.xml with Context logEffectiveWebXml=true/ and web.xml without metadata-compete attribute and adding the following: [[[ jsp-config jsp-property-group url-pattern*.foo/url-pattern url-pattern*.bar/url-pattern is-xmltrue/is-xml /jsp-property-group /jsp-config ]]] 2. Start Tomcat and look into the catalina.`date`.log file. The merged web.xml should have been dumped there. Look for the jsp-property-group element. Actual result: [[[ jsp-config jsp-property-group url-pattern*.bar/url-pattern is-xmltrue/is-xml /jsp-property-group /jsp-config ]]] Expected result: both *.foo and *.bar should be mentioned. Tomcat 6 does not have this issue, because there is no such object in Catalina there. The digester configured in WebRuleSet calls StandardContext.addJspMapping(..), which is additive. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1372131 - /tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java
Author: markt
Date: Sun Aug 12 15:39:24 2012
New Revision: 1372131
URL: http://svn.apache.org/viewvc?rev=1372131view=rev
Log:
Additional fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=53071
Trim long exception messages
Modified:
tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java
Modified: tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java?rev=1372131r1=1372130r2=1372131view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/ErrorReportValve.java Sun Aug
12 15:39:24 2012
@@ -19,6 +19,7 @@ package org.apache.catalina.valves;
import java.io.IOException;
import java.io.Writer;
+import java.util.Scanner;
import javax.servlet.RequestDispatcher;
import javax.servlet.ServletException;
@@ -142,7 +143,11 @@ public class ErrorReportValve extends Va
String message = RequestUtil.filter(response.getMessage());
if (message == null) {
if (throwable != null) {
-message = RequestUtil.filter(throwable.getMessage());
+String exceptionMessage = throwable.getMessage();
+if (exceptionMessage != null exceptionMessage.length() 0)
{
+message = RequestUtil.filter(
+(new Scanner(exceptionMessage)).nextLine());
+}
}
if (message == null) {
message = ;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1372132 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/ErrorReportValve.java webapps/docs/changelog.xml
Author: markt
Date: Sun Aug 12 15:42:33 2012
New Revision: 1372132
URL: http://svn.apache.org/viewvc?rev=1372132view=rev
Log:
Additional fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=53071
Trim long exception messages
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1372131
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java?rev=1372132r1=1372131r2=1372132view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java
Sun Aug 12 15:42:33 2012
@@ -19,6 +19,7 @@ package org.apache.catalina.valves;
import java.io.IOException;
import java.io.Writer;
+import java.util.Scanner;
import javax.servlet.RequestDispatcher;
import javax.servlet.ServletException;
@@ -166,7 +167,11 @@ public class ErrorReportValve extends Va
String message = RequestUtil.filter(response.getMessage());
if (message == null) {
if (throwable != null) {
-message = RequestUtil.filter(throwable.getMessage());
+String exceptionMessage = throwable.getMessage();
+if (exceptionMessage != null exceptionMessage.length() 0)
{
+message = RequestUtil.filter(
+(new Scanner(exceptionMessage)).nextLine());
+}
}
if (message == null) {
message = ;
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1372132r1=1372131r2=1372132view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Sun Aug 12 15:42:33 2012
@@ -63,6 +63,11 @@
when request processing completes. (kkolinko)
/fix
fix
+bug53071/bug: This additional fix for this issue improves the
+formatting of Jasper errors (or any exceptions that use a multi-line
+message) with the codeErrorReportValve/code. (markt)
+ /fix
+ fix
bug53469/bug: If a URL passed to
codejavax.servlet.http.HttpServletResponse.encodeURL()/code cannot
be made absolute, never encode it and return it unchanged. Previously,
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Component|Catalina|Catalina
Version|7.0.29 |6.0.35
Product|Tomcat 7|Tomcat 6
Target Milestone|--- |default
--- Comment #14 from Mark Thomas ma...@apache.org ---
Jasper issue fixed in trunk and 7.0.x.
Jasper fix and {0} fix proposed for 6.0.c
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1372134 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Sun Aug 12 15:45:37 2012 New Revision: 1372134 URL: http://svn.apache.org/viewvc?rev=1372134view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1372134r1=1372133r2=1372134view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Aug 12 15:45:37 2012 @@ -165,6 +165,15 @@ PATCHES PROPOSED TO BACKPORT: and http://svn.apache.org/viewvc?view=revisionrevision=1049264 to fix the formatting issues. +* Further fixes for https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 + - Use standard text for standard HTTP error codes + - Trim Jasper error messages + http://svn.apache.org/viewvc?view=revisionrevision=1361991 + http://svn.apache.org/viewvc?rev=1372131view=rev + +1: markt + -1: + + PATCHES/ISSUES THAT ARE STALLED * Backport JSP unloading patch (BZ48358). - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1372137 - in /tomcat/trunk/test/org/apache/catalina/core: TestAsyncContextImpl.java TestStandardWrapper.java
Author: markt
Date: Sun Aug 12 15:53:59 2012
New Revision: 1372137
URL: http://svn.apache.org/viewvc?rev=1372137view=rev
Log:
Java 7 changes
Modified:
tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
tomcat/trunk/test/org/apache/catalina/core/TestStandardWrapper.java
Modified: tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java?rev=1372137r1=1372136r2=1372137view=diff
==
--- tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java Sun
Aug 12 15:53:59 2012
@@ -1036,8 +1036,7 @@ public class TestAsyncContextImpl extend
tomcat.start();
// Call the servlet once
-MapString,ListString headers =
-new LinkedHashMapString,ListString();
+MapString,ListString headers = new LinkedHashMap();
ByteChunk bc = new ByteChunk();
int rc = getUrl(http://localhost:; + getPort() + /, bc, headers);
assertEquals(200, rc);
Modified: tomcat/trunk/test/org/apache/catalina/core/TestStandardWrapper.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestStandardWrapper.java?rev=1372137r1=1372136r2=1372137view=diff
==
--- tomcat/trunk/test/org/apache/catalina/core/TestStandardWrapper.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/core/TestStandardWrapper.java Sun Aug
12 15:53:59 2012
@@ -251,8 +251,8 @@ public class TestStandardWrapper extends
ByteChunk bc = new ByteChunk();
MapString,ListString reqHeaders = null;
if (useRole) {
-reqHeaders = new HashMapString,ListString();
-ListString authHeaders = new ArrayListString();
+reqHeaders = new HashMap();
+ListString authHeaders = new ArrayList();
// testUser, testPwd
authHeaders.add(Basic dGVzdFVzZXI6dGVzdFB3ZA==);
reqHeaders.put(Authorization, authHeaders);
@@ -387,7 +387,7 @@ public class TestStandardWrapper extends
threads[i].join();
}
-SetString servlets = new HashSetString();
+SetString servlets = new HashSet();
// Output the result
for (int i = 0; i BUG51445_THREAD_COUNT; i ++) {
System.out.println(threads[i].getResult());
@@ -434,7 +434,7 @@ public class TestStandardWrapper extends
threads[i].join();
}
-SetString servlets = new HashSetString();
+SetString servlets = new HashSet();
// Output the result
for (int i = 0; i BUG51445_THREAD_COUNT; i ++) {
System.out.println(threads[i].getResult());
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1372152 - /tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
Author: markt
Date: Sun Aug 12 17:33:31 2012
New Revision: 1372152
URL: http://svn.apache.org/viewvc?rev=1372152view=rev
Log:
Add additional check on current behaviour to try and catch any regressions in
the fix for 53623
Modified:
tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
Modified: tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java?rev=1372152r1=1372151r2=1372152view=diff
==
--- tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java Sun
Aug 12 17:33:31 2012
@@ -28,6 +28,7 @@ import java.util.concurrent.Executors;
import javax.servlet.AsyncContext;
import javax.servlet.AsyncEvent;
import javax.servlet.AsyncListener;
+import javax.servlet.DispatcherType;
import javax.servlet.RequestDispatcher;
import javax.servlet.ServletException;
import javax.servlet.ServletRequestEvent;
@@ -597,6 +598,7 @@ public class TestAsyncContextImpl extend
private static final long serialVersionUID = 1L;
private static final String ITER_PARAM = iter;
+private static final String DISPATCH_CHECK = check;
private boolean addTrackingListener = false;
private boolean completeOnError = false;
@@ -610,6 +612,11 @@ public class TestAsyncContextImpl extend
protected void doGet(HttpServletRequest req, HttpServletResponse resp)
throws ServletException, IOException {
+if (y.equals(req.getParameter(DISPATCH_CHECK))) {
+if (req.getDispatcherType() != DispatcherType.ASYNC) {
+resp.getWriter().write(WrongDispatcherType-);
+}
+}
resp.getWriter().write(DispatchingServletGet-);
resp.flushBuffer();
final int iter = Integer.parseInt(req.getParameter(ITER_PARAM)) -
1;
@@ -623,7 +630,8 @@ public class TestAsyncContextImpl extend
@Override
public void run() {
if (iter 0) {
-ctxt.dispatch(/stage1? + ITER_PARAM + = + iter);
+ctxt.dispatch(/stage1? + ITER_PARAM + = + iter +
+ + DISPATCH_CHECK + =y);
} else {
ctxt.dispatch(/stage2);
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1372153 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/core/TestAsyncContextImpl.java
Author: markt
Date: Sun Aug 12 17:34:13 2012
New Revision: 1372153
URL: http://svn.apache.org/viewvc?rev=1372153view=rev
Log:
Add additional check on current behaviour to try and catch any regressions in
the fix for 53623
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1372152
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java?rev=1372153r1=1372152r2=1372153view=diff
==
---
tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
(original)
+++
tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
Sun Aug 12 17:34:13 2012
@@ -28,6 +28,7 @@ import java.util.concurrent.Executors;
import javax.servlet.AsyncContext;
import javax.servlet.AsyncEvent;
import javax.servlet.AsyncListener;
+import javax.servlet.DispatcherType;
import javax.servlet.RequestDispatcher;
import javax.servlet.ServletException;
import javax.servlet.ServletRequestEvent;
@@ -597,6 +598,7 @@ public class TestAsyncContextImpl extend
private static final long serialVersionUID = 1L;
private static final String ITER_PARAM = iter;
+private static final String DISPATCH_CHECK = check;
private boolean addTrackingListener = false;
private boolean completeOnError = false;
@@ -610,6 +612,11 @@ public class TestAsyncContextImpl extend
protected void doGet(HttpServletRequest req, HttpServletResponse resp)
throws ServletException, IOException {
+if (y.equals(req.getParameter(DISPATCH_CHECK))) {
+if (req.getDispatcherType() != DispatcherType.ASYNC) {
+resp.getWriter().write(WrongDispatcherType-);
+}
+}
resp.getWriter().write(DispatchingServletGet-);
resp.flushBuffer();
final int iter = Integer.parseInt(req.getParameter(ITER_PARAM)) -
1;
@@ -623,7 +630,8 @@ public class TestAsyncContextImpl extend
@Override
public void run() {
if (iter 0) {
-ctxt.dispatch(/stage1? + ITER_PARAM + = + iter);
+ctxt.dispatch(/stage1? + ITER_PARAM + = + iter +
+ + DISPATCH_CHECK + =y);
} else {
ctxt.dispatch(/stage2);
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1372156 - in /tomcat/trunk/java/org/apache/catalina/core: ApplicationDispatcher.java ApplicationFilterFactory.java StandardHostValve.java StandardWrapperValve.java
Author: markt
Date: Sun Aug 12 17:41:53 2012
New Revision: 1372156
URL: http://svn.apache.org/viewvc?rev=1372156view=rev
Log:
Deprecate duplicated constants
Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java
tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
tomcat/trunk/java/org/apache/catalina/core/StandardWrapperValve.java
Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java?rev=1372156r1=1372155r2=1372156view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java Sun
Aug 12 17:41:53 2012
@@ -437,7 +437,7 @@ final class ApplicationDispatcher
State state)
throws IOException, ServletException {
-DispatcherType disInt = (DispatcherType)
request.getAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR);
+DispatcherType disInt = (DispatcherType)
request.getAttribute(Globals.DISPATCHER_TYPE_ATTR);
if (disInt != null) {
boolean doInvoke = true;
@@ -448,12 +448,12 @@ final class ApplicationDispatcher
if (doInvoke) {
if (disInt != DispatcherType.ERROR) {
-state.outerRequest.setAttribute
-(ApplicationFilterFactory.DISPATCHER_REQUEST_PATH_ATTR,
- getCombinedPath());
-state.outerRequest.setAttribute
-(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR,
- DispatcherType.FORWARD);
+state.outerRequest.setAttribute(
+Globals.DISPATCHER_REQUEST_PATH_ATTR,
+getCombinedPath());
+state.outerRequest.setAttribute(
+Globals.DISPATCHER_TYPE_ATTR,
+DispatcherType.FORWARD);
invoke(state.outerRequest, response, state);
} else {
invoke(state.outerRequest, response, state);
@@ -539,10 +539,8 @@ final class ApplicationDispatcher
wrequest.setAttribute(Globals.NAMED_DISPATCHER_ATTR, name);
if (servletPath != null)
wrequest.setServletPath(servletPath);
-
wrequest.setAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR,
-type);
-wrequest.setAttribute(
-ApplicationFilterFactory.DISPATCHER_REQUEST_PATH_ATTR,
+wrequest.setAttribute(Globals.DISPATCHER_TYPE_ATTR, type);
+wrequest.setAttribute(Globals.DISPATCHER_REQUEST_PATH_ATTR,
getCombinedPath());
invoke(state.outerRequest, state.outerResponse, state);
}
@@ -571,10 +569,8 @@ final class ApplicationDispatcher
wrequest.setQueryParams(queryString);
}
-
wrequest.setAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR,
-type);
-wrequest.setAttribute(
-ApplicationFilterFactory.DISPATCHER_REQUEST_PATH_ATTR,
+wrequest.setAttribute(Globals.DISPATCHER_TYPE_ATTR, type);
+wrequest.setAttribute(Globals.DISPATCHER_REQUEST_PATH_ATTR,
getCombinedPath());
invoke(state.outerRequest, state.outerResponse, state);
}
Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java?rev=1372156r1=1372155r2=1372156view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
Sun Aug 12 17:41:53 2012
@@ -45,10 +45,18 @@ public final class ApplicationFilterFact
// -- Constants
+/**
+ * @deprecated Use {@link Globals#DISPATCHER_TYPE_ATTR}
+ */
+@Deprecated
public static final String DISPATCHER_TYPE_ATTR =
-Globals.DISPATCHER_TYPE_ATTR;
+Globals.DISPATCHER_TYPE_ATTR;
+/**
+ * @deprecated Use {@link Globals#DISPATCHER_REQUEST_PATH_ATTR}
+ */
+@Deprecated
public static final String DISPATCHER_REQUEST_PATH_ATTR =
-Globals.DISPATCHER_REQUEST_PATH_ATTR;
+Globals.DISPATCHER_REQUEST_PATH_ATTR;
private static ApplicationFilterFactory factory = null;
@@ -87,11 +95,13 @@ public final class ApplicationFilterFact
svn commit: r1372157 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
Author: markt
Date: Sun Aug 12 17:43:08 2012
New Revision: 1372157
URL: http://svn.apache.org/viewvc?rev=1372157view=rev
Log:
Remove deprecated code
Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java?rev=1372157r1=1372156r2=1372157view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
Sun Aug 12 17:43:08 2012
@@ -14,11 +14,8 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
-
package org.apache.catalina.core;
-
import javax.servlet.DispatcherType;
import javax.servlet.Servlet;
import javax.servlet.ServletRequest;
@@ -38,31 +35,11 @@ import org.apache.tomcat.util.ExceptionU
* @author Remy Maucherat
* @version $Revision: 1.0
*/
-
public final class ApplicationFilterFactory {
-
-// -- Constants
-
-
-/**
- * @deprecated Use {@link Globals#DISPATCHER_TYPE_ATTR}
- */
-@Deprecated
-public static final String DISPATCHER_TYPE_ATTR =
-Globals.DISPATCHER_TYPE_ATTR;
-/**
- * @deprecated Use {@link Globals#DISPATCHER_REQUEST_PATH_ATTR}
- */
-@Deprecated
-public static final String DISPATCHER_REQUEST_PATH_ATTR =
-Globals.DISPATCHER_REQUEST_PATH_ATTR;
-
private static ApplicationFilterFactory factory = null;
-// --- Constructors
-
private ApplicationFilterFactory() {
// Prevent instantiation outside of the getInstanceMethod().
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1372158 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/
Author: markt
Date: Sun Aug 12 17:44:18 2012
New Revision: 1372158
URL: http://svn.apache.org/viewvc?rev=1372158view=rev
Log:
Deprecate duplicated constants
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardHostValve.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardWrapperValve.java
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1372156
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java?rev=1372158r1=1372157r2=1372158view=diff
==
---
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java
(original)
+++
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationDispatcher.java
Sun Aug 12 17:44:18 2012
@@ -457,7 +457,7 @@ final class ApplicationDispatcher
State state)
throws IOException, ServletException {
-DispatcherType disInt = (DispatcherType)
request.getAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR);
+DispatcherType disInt = (DispatcherType)
request.getAttribute(Globals.DISPATCHER_TYPE_ATTR);
if (disInt != null) {
boolean doInvoke = true;
@@ -468,12 +468,12 @@ final class ApplicationDispatcher
if (doInvoke) {
if (disInt != DispatcherType.ERROR) {
-state.outerRequest.setAttribute
-(ApplicationFilterFactory.DISPATCHER_REQUEST_PATH_ATTR,
- getCombinedPath());
-state.outerRequest.setAttribute
-(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR,
- DispatcherType.FORWARD);
+state.outerRequest.setAttribute(
+Globals.DISPATCHER_REQUEST_PATH_ATTR,
+getCombinedPath());
+state.outerRequest.setAttribute(
+Globals.DISPATCHER_TYPE_ATTR,
+DispatcherType.FORWARD);
invoke(state.outerRequest, response, state);
} else {
invoke(state.outerRequest, response, state);
@@ -559,10 +559,8 @@ final class ApplicationDispatcher
wrequest.setAttribute(Globals.NAMED_DISPATCHER_ATTR, name);
if (servletPath != null)
wrequest.setServletPath(servletPath);
-
wrequest.setAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR,
-type);
-wrequest.setAttribute(
-ApplicationFilterFactory.DISPATCHER_REQUEST_PATH_ATTR,
+wrequest.setAttribute(Globals.DISPATCHER_TYPE_ATTR, type);
+wrequest.setAttribute(Globals.DISPATCHER_REQUEST_PATH_ATTR,
getCombinedPath());
invoke(state.outerRequest, state.outerResponse, state);
}
@@ -591,10 +589,8 @@ final class ApplicationDispatcher
wrequest.setQueryParams(queryString);
}
-
wrequest.setAttribute(ApplicationFilterFactory.DISPATCHER_TYPE_ATTR,
-type);
-wrequest.setAttribute(
-ApplicationFilterFactory.DISPATCHER_REQUEST_PATH_ATTR,
+wrequest.setAttribute(Globals.DISPATCHER_TYPE_ATTR, type);
+wrequest.setAttribute(Globals.DISPATCHER_REQUEST_PATH_ATTR,
getCombinedPath());
invoke(state.outerRequest, state.outerResponse, state);
}
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java?rev=1372158r1=1372157r2=1372158view=diff
==
---
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
(original)
+++
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
Sun Aug 12 17:44:18 2012
@@ -45,10 +45,18 @@ public final class ApplicationFilterFact
// -- Constants
-public static final String DISPATCHER_TYPE_ATTR =
-Globals.DISPATCHER_TYPE_ATTR;
+/**
+ * @deprecated Use {@link Globals#DISPATCHER_TYPE_ATTR}
+ */
+@Deprecated
+public static final String DISPATCHER_TYPE_ATTR =
+Globals.DISPATCHER_TYPE_ATTR;
+
Re: svn commit: r1372002 - /tomcat/tc5.5.x/trunk/STATUS.txt
Konstantin, On 8/11/12 3:26 PM, kkoli...@apache.org wrote: Author: kkolinko Date: Sat Aug 11 19:26:30 2012 New Revision: 1372002 URL: http://svn.apache.org/viewvc?rev=1372002view=rev Log: Update Christopher Schultz' proposal with an actual patch. I am keeping Christopher's vote. The difference between this patch and his fix in TC6 is trivial. Thanks for preparing a patch. That was going to be my next move this week. -chris signature.asc Description: OpenPGP digital signature
svn commit: r1372196 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: rjung Date: Sun Aug 12 20:56:10 2012 New Revision: 1372196 URL: http://svn.apache.org/viewvc?rev=1372196view=rev Log: Vote, comment. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1372196r1=1372195r2=1372196view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Aug 12 20:56:10 2012 @@ -170,8 +170,11 @@ PATCHES PROPOSED TO BACKPORT: - Trim Jasper error messages http://svn.apache.org/viewvc?view=revisionrevision=1361991 http://svn.apache.org/viewvc?rev=1372131view=rev - +1: markt + +1: markt, rjung -1: + rjung: 1361991 doesn't apply cleanly, because the list of status codes + was extended in 1361263 and 1361962. + I would be +1 to backport those two as well. PATCHES/ISSUES THAT ARE STALLED - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53697] java.lang.NullPointerException at org.apache.coyote.http11.Http11AprProcessor.actionInternal(Http11AprProcessor.java:277)
https://issues.apache.org/bugzilla/show_bug.cgi?id=53697 lac...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX |--- --- Comment #2 from lac...@gmail.com --- Please find the test case at: https://chrislacy.net/downloads/tomcat-bug-53697.tar.gz Steps: - install apr and dependencies - compile and install native - startup tomcat (./startup.sh) - hit https://localhost:8443/AtmosphereTest - hit http://localhost:8080/AtmosphereTest - repeat hits if necessary (usually first round does it, but sometimes another hit to https is needed) I used firefox and tested on both the server I mentioned and another development box. A second, related, error that happends ~1/2 of the time, is currently in catalina.out and has the pid error file in CATALINA_HOME - copied here: # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x7fd3840a78d0, pid=28351, tid=140546779842304 # # JRE version: 7.0_05 # Java VM: OpenJDK 64-Bit Server VM (23.0-b21 mixed mode linux-amd64 compressed oops) # Problematic frame: # C 0x7fd3840a78d0 # # Failed to write core dump. Core dumps have been disabled. To enable core dumping, try ulimit -c unlimited before starting Java again # # An error report file with more information is saved as: # /home/chris/Documents/apache-tomcat-7.0.29/bin/hs_err_pid28351.log # # If you would like to submit a bug report, please include # instructions on how to reproduce the bug and visit: # http://icedtea.classpath.org/bugzilla # -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1372224 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Mon Aug 13 00:41:40 2012 New Revision: 1372224 URL: http://svn.apache.org/viewvc?rev=1372224view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1372224r1=1372223r2=1372224view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Aug 13 00:41:40 2012 @@ -170,11 +170,12 @@ PATCHES PROPOSED TO BACKPORT: - Trim Jasper error messages http://svn.apache.org/viewvc?view=revisionrevision=1361991 http://svn.apache.org/viewvc?rev=1372131view=rev - +1: markt, rjung + +1: markt, rjung, kkolinko -1: rjung: 1361991 doesn't apply cleanly, because the list of status codes was extended in 1361263 and 1361962. I would be +1 to backport those two as well. + kkolinko: +1 for 1361263 and 1361962 as well. PATCHES/ISSUES THAT ARE STALLED - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1372234 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Mon Aug 13 01:28:46 2012 New Revision: 1372234 URL: http://svn.apache.org/viewvc?rev=1372234view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1372234r1=1372233r2=1372234view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Aug 13 01:28:46 2012 @@ -123,19 +123,19 @@ PATCHES PROPOSED TO BACKPORT: Fix race condition between the processing of session sync message and transfer complete message. http://svn.apache.org/viewvc?view=revisionrevision=1359044 - +1: kfujino + +1: kfujino, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53607 To avoid NPE, set TCP PING data to ChannelMessage. http://svn.apache.org/viewvc?view=revisionrevision=1367456 - +1: kfujino + +1: kfujino, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53606 Fix possible NPE when sending pings between cluster nodes. http://svn.apache.org/viewvc?view=revisionrevision=1366961 - +1: kfujino + +1: kfujino, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53584 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1372242 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Mon Aug 13 02:20:18 2012 New Revision: 1372242 URL: http://svn.apache.org/viewvc?rev=1372242view=rev Log: veto. It concerns current Tomcat 7 code (r1370537) as well. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1372242r1=1372241r2=1372242view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Aug 13 02:20:18 2012 @@ -144,7 +144,26 @@ PATCHES PROPOSED TO BACKPORT: IDs are being encoded as path parameters. http://svn.apache.org/viewvc?rev=1370537view=rev +1: markt, schultz - -1: + -1: kkolinko: + Regarding FormAuthenticator.restoreRequest(..): + My -1 is because decodedURI is saved into SavedRequest in #saveRequest(..) + but is restored into requestURI field in #restoreRequest(..). + + The following are my concerns: + 1. The web application protected by FORM auth might have expected path + parameters, and now those are lost from requestURI. + 2. The decodedURI value is url-decoded in CoyoteAdapter.postParseRequest(..), + while requestURI is not. Using one for the other changes behaviour. + + 3. An issue that exists in the old code as well: I wonder why + decodedURI value is not restored by restoreRequest(). It looks like a + bug. I think an observable consequence is that o.a.c.connector.Request#toAbsolute() + will return different values because of different values of decodedURI. + + The BZ 53584 bug is essentially in matchRequest(..) and I agree that it should + be changed to compare decodedURI values. + Can SavedRequest store both requestURI and decodedURI values and + restore both of them? * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53481 Add support for SSLHonorCipherOrder - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
