Re: [VOTE] Release Apache Tomcat 7.0.48

2013-12-10 Thread Ognjen Blagojevic

On 9.12.2013 22:21, Violeta Georgieva wrote:

The proposed Apache Tomcat 7.0.48 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.48/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-030/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_48/

The proposed 7.0.48 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 7.0.48 Stable


Tested .zip distribution on Windows 7 64-bit:

- Tested SSL/TLS connectivity for BIO, NIO and APR connectors.

- Crawled all links (except /manager, /host-manager and 
/examples/async*). No broken links found, except links to JavaDocs.


- Smoke tests of BIO, NIO and APR, with and without TLS, all passed.


-Ognjen


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



New JDBC SessionManager for non sticky-sessions

2013-12-10 Thread Spielmann, Simon
Hello together,

we developed a custom JDBC SessionManager which supports non sticky-sessions.
Is there interest in including this in the official tomcat distribution?

Kind Regards
Simon








Firma: Capgemini Deutschland GmbH
Geschäftsführer: Dr. Michael Schulte (Sprecher) • Dr. Uwe Dumslaff • Josef 
Ranner
Aufsichtsratsvorsitzender: Antonio Schnieder
Amtsgericht Berlin-Charlottenburg, HRB 98814
This message contains information that may be privileged or confidential and is 
the property of the Capgemini Group. It is intended only for the person to whom 
it is addressed. If you are not the intended recipient, you are not authorized 
to read, print, retain, copy, disseminate, distribute, or use this message or 
any part thereof. If you receive this message in error, please notify the 
sender immediately and delete all copies of this message.


Re: [VOTE] Release Apache Tomcat 7.0.48

2013-12-10 Thread Mark Thomas
On 09/12/2013 21:21, Violeta Georgieva wrote:
 The proposed Apache Tomcat 7.0.48 release is now available for voting.
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.48/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-030/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_48/
 
 The proposed 7.0.48 release is:
 [X] Broken - do not release
 [ ] Stable - go ahead and release as 7.0.48 Stable

XML validation is broken. I'm pretty sure I broke it. Looking at it now
and I should have a fix shortly.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 7.0.48

2013-12-10 Thread Mark Thomas
On 10/12/2013 12:23, Mark Thomas wrote:
 On 09/12/2013 21:21, Violeta Georgieva wrote:
 The proposed Apache Tomcat 7.0.48 release is now available for voting.

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.48/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-030/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_48/

 The proposed 7.0.48 release is:
 [X] Broken - do not release
 [ ] Stable - go ahead and release as 7.0.48 Stable
 
 XML validation is broken. I'm pretty sure I broke it. Looking at it now
 and I should have a fix shortly.

It is the Tomcat 7 version of
https://issues.apache.org/bugzilla/show_bug.cgi?id=55166 which is a
regression introduced by the switch to the new LocalResolver.

I am current testing the following patch:

Index: java/org/apache/tomcat/util/descriptor/DigesterFactory.java
===
--- java/org/apache/tomcat/util/descriptor/DigesterFactory.java
(revision 1549529)
+++ java/org/apache/tomcat/util/descriptor/DigesterFactory.java (working
copy)
@@ -96,6 +96,7 @@
 private static void addSelf(MapString, String ids, String id) {
 String systemId = idFor(id);
 ids.put(systemId, systemId);
+ids.put(id, systemId);
 }

 private static String idFor(String url) {


It is a little bit of a hack but so were all the other options I
considered. So far the testing looks good.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1549832 - /tomcat/trunk/test/javax/servlet/resources/TestSchemaValidation.java

2013-12-10 Thread markt
Author: markt
Date: Tue Dec 10 13:14:04 2013
New Revision: 1549832

URL: http://svn.apache.org/r1549832
Log:
Expand validation tests to make sure there are no parsing errors.

Modified:
tomcat/trunk/test/javax/servlet/resources/TestSchemaValidation.java

Modified: tomcat/trunk/test/javax/servlet/resources/TestSchemaValidation.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/javax/servlet/resources/TestSchemaValidation.java?rev=1549832r1=1549831r2=1549832view=diff
==
--- tomcat/trunk/test/javax/servlet/resources/TestSchemaValidation.java 
(original)
+++ tomcat/trunk/test/javax/servlet/resources/TestSchemaValidation.java Tue Dec 
10 13:14:04 2013
@@ -22,6 +22,7 @@ import org.junit.Assert;
 import org.junit.Test;
 
 import org.apache.tomcat.util.descriptor.DigesterFactory;
+import org.apache.tomcat.util.descriptor.XmlErrorHandler;
 import org.apache.tomcat.util.descriptor.XmlIdentifiers;
 import org.apache.tomcat.util.descriptor.web.WebRuleSet;
 import org.apache.tomcat.util.descriptor.web.WebXml;
@@ -31,73 +32,101 @@ public class TestSchemaValidation {
 
 @Test
 public void testWebapp() throws Exception {
+XmlErrorHandler handler = new XmlErrorHandler();
 Digester digester = DigesterFactory.newDigester(
 true, true, new WebRuleSet(false), true);
+digester.setErrorHandler(handler);
 digester.push(new WebXml());
 WebXml desc = (WebXml) digester.parse(
 new File(test/webapp/WEB-INF/web.xml));
 Assert.assertEquals(3.1, desc.getVersion());
+Assert.assertEquals(0, handler.getErrors().size());
+Assert.assertEquals(0, handler.getWarnings().size());
 }
 
 @Test
 public void testWebapp_2_2() throws Exception {
+XmlErrorHandler handler = new XmlErrorHandler();
 Digester digester = DigesterFactory.newDigester(
 true, true, new WebRuleSet(false), true);
+digester.setErrorHandler(handler);
 digester.push(new WebXml());
 WebXml desc = (WebXml) digester.parse(
 new File(test/webapp-2.2/WEB-INF/web.xml));
 Assert.assertEquals(2.2, desc.getVersion());
 Assert.assertEquals(XmlIdentifiers.WEB_22_PUBLIC, desc.getPublicId());
+Assert.assertEquals(0, handler.getErrors().size());
+Assert.assertEquals(0, handler.getWarnings().size());
 }
 
 @Test
 public void testWebapp_2_3() throws Exception {
+XmlErrorHandler handler = new XmlErrorHandler();
 Digester digester = DigesterFactory.newDigester(
 true, true, new WebRuleSet(false), true);
+digester.setErrorHandler(handler);
 digester.push(new WebXml());
 WebXml desc = (WebXml) digester.parse(
 new File(test/webapp-2.3/WEB-INF/web.xml));
 Assert.assertEquals(2.3, desc.getVersion());
 Assert.assertEquals(XmlIdentifiers.WEB_23_PUBLIC, desc.getPublicId());
+Assert.assertEquals(0, handler.getErrors().size());
+Assert.assertEquals(0, handler.getWarnings().size());
 }
 
 @Test
 public void testWebapp_2_4() throws Exception {
+XmlErrorHandler handler = new XmlErrorHandler();
 Digester digester = DigesterFactory.newDigester(
 true, true, new WebRuleSet(false), true);
+digester.setErrorHandler(handler);
 digester.push(new WebXml());
 WebXml desc = (WebXml) digester.parse(
 new File(test/webapp-2.4/WEB-INF/web.xml));
 Assert.assertEquals(2.4, desc.getVersion());
+Assert.assertEquals(0, handler.getErrors().size());
+Assert.assertEquals(0, handler.getWarnings().size());
 }
 
 @Test
 public void testWebapp_2_5() throws Exception {
+XmlErrorHandler handler = new XmlErrorHandler();
 Digester digester = DigesterFactory.newDigester(
 true, true, new WebRuleSet(false), true);
+digester.setErrorHandler(handler);
 digester.push(new WebXml());
 WebXml desc = (WebXml) digester.parse(
 new File(test/webapp-2.5/WEB-INF/web.xml));
 Assert.assertEquals(2.5, desc.getVersion());
+Assert.assertEquals(0, handler.getErrors().size());
+Assert.assertEquals(0, handler.getWarnings().size());
 }
 
 @Test
 public void testWebapp_3_0() throws Exception {
+XmlErrorHandler handler = new XmlErrorHandler();
 Digester digester = DigesterFactory.newDigester(
 true, true, new WebRuleSet(false), true);
+digester.setErrorHandler(handler);
 digester.push(new WebXml());
 WebXml desc = (WebXml) digester.parse(
 new File(test/webapp-3.0/WEB-INF/web.xml));
 Assert.assertEquals(3.0, desc.getVersion());
+Assert.assertEquals(0, handler.getErrors().size());
+Assert.assertEquals(0, 

svn commit: r1549836 - in /tomcat/tc7.0.x/trunk: java/org/apache/tomcat/util/descriptor/DigesterFactory.java test/javax/servlet/resources/TestSchemaValidation.java

2013-12-10 Thread markt
Author: markt
Date: Tue Dec 10 13:16:52 2013
New Revision: 1549836

URL: http://svn.apache.org/r1549836
Log:
Expand validation tests to make sure there are no parsing errors.
Fix parsing errors identified by expanded tests.

Modified:

tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/descriptor/DigesterFactory.java
tomcat/tc7.0.x/trunk/test/javax/servlet/resources/TestSchemaValidation.java

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/descriptor/DigesterFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/descriptor/DigesterFactory.java?rev=1549836r1=1549835r2=1549836view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/descriptor/DigesterFactory.java
 (original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/descriptor/DigesterFactory.java
 Tue Dec 10 13:16:52 2013
@@ -96,6 +96,7 @@ public class DigesterFactory {
 private static void addSelf(MapString, String ids, String id) {
 String systemId = idFor(id);
 ids.put(systemId, systemId);
+ids.put(id, systemId);
 }
 
 private static String idFor(String url) {

Modified: 
tomcat/tc7.0.x/trunk/test/javax/servlet/resources/TestSchemaValidation.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/javax/servlet/resources/TestSchemaValidation.java?rev=1549836r1=1549835r2=1549836view=diff
==
--- tomcat/tc7.0.x/trunk/test/javax/servlet/resources/TestSchemaValidation.java 
(original)
+++ tomcat/tc7.0.x/trunk/test/javax/servlet/resources/TestSchemaValidation.java 
Tue Dec 10 13:16:52 2013
@@ -24,6 +24,7 @@ import org.junit.Test;
 import org.apache.catalina.deploy.WebXml;
 import org.apache.catalina.startup.WebRuleSet;
 import org.apache.tomcat.util.descriptor.DigesterFactory;
+import org.apache.tomcat.util.descriptor.XmlErrorHandler;
 import org.apache.tomcat.util.descriptor.XmlIdentifiers;
 import org.apache.tomcat.util.digester.Digester;
 
@@ -31,53 +32,73 @@ public class TestSchemaValidation {
 
 @Test
 public void testWebapp_2_2() throws Exception {
+XmlErrorHandler handler = new XmlErrorHandler();
 Digester digester = DigesterFactory.newDigester(
 true, true, new WebRuleSet(false), true);
+digester.setErrorHandler(handler);
 digester.push(new WebXml());
 WebXml desc = (WebXml) digester.parse(
 new File(test/webapp-2.2/WEB-INF/web.xml));
 Assert.assertEquals(2.2, desc.getVersion());
 Assert.assertEquals(XmlIdentifiers.WEB_22_PUBLIC, desc.getPublicId());
+Assert.assertEquals(0, handler.getErrors().size());
+Assert.assertEquals(0, handler.getWarnings().size());
 }
 
 @Test
 public void testWebapp_2_3() throws Exception {
+XmlErrorHandler handler = new XmlErrorHandler();
 Digester digester = DigesterFactory.newDigester(
 true, true, new WebRuleSet(false), true);
+digester.setErrorHandler(handler);
 digester.push(new WebXml());
 WebXml desc = (WebXml) digester.parse(
 new File(test/webapp-2.3/WEB-INF/web.xml));
 Assert.assertEquals(2.3, desc.getVersion());
 Assert.assertEquals(XmlIdentifiers.WEB_23_PUBLIC, desc.getPublicId());
+Assert.assertEquals(0, handler.getErrors().size());
+Assert.assertEquals(0, handler.getWarnings().size());
 }
 
 @Test
 public void testWebapp_2_4() throws Exception {
+XmlErrorHandler handler = new XmlErrorHandler();
 Digester digester = DigesterFactory.newDigester(
 true, true, new WebRuleSet(false), true);
+digester.setErrorHandler(handler);
 digester.push(new WebXml());
 WebXml desc = (WebXml) digester.parse(
 new File(test/webapp-2.4/WEB-INF/web.xml));
 Assert.assertEquals(2.4, desc.getVersion());
+Assert.assertEquals(0, handler.getErrors().size());
+Assert.assertEquals(0, handler.getWarnings().size());
 }
 
 @Test
 public void testWebapp_2_5() throws Exception {
+XmlErrorHandler handler = new XmlErrorHandler();
 Digester digester = DigesterFactory.newDigester(
 true, true, new WebRuleSet(false), true);
+digester.setErrorHandler(handler);
 digester.push(new WebXml());
 WebXml desc = (WebXml) digester.parse(
 new File(test/webapp-2.5/WEB-INF/web.xml));
 Assert.assertEquals(2.5, desc.getVersion());
+Assert.assertEquals(0, handler.getErrors().size());
+Assert.assertEquals(0, handler.getWarnings().size());
 }
 
 @Test
 public void testWebapp_3_0() throws Exception {
+XmlErrorHandler handler = new XmlErrorHandler();
 Digester digester = DigesterFactory.newDigester(
 true, true, new 

Re: New JDBC SessionManager for non sticky-sessions

2013-12-10 Thread Daniel Mikusa
On Dec 10, 2013, at 6:34 AM, Spielmann, Simon simon.spielm...@capgemini.com 
wrote:

 Hello together,
 
 we developed a custom JDBC SessionManager which supports non sticky-sessions.
 Is there interest in including this in the official tomcat distribution?

Can you tell us more?  Some questions coming to mind…

  - What motivated you to develop this?
  - How does it work? How does it integrate with Tomcat?
  - Have you performance / load tested it?  If so, with what results?
  - What databases does it support?  What tables does it need setup to work?
  - What benefits does it offer other than not requiring sticky sessions? or is 
that the main feature? 
  - Can I use it with sticky sessions or would that break it / defeat the 
purpose?
  - How is it different than using a persistent manager with JDBC based store?

  
https://tomcat.apache.org/tomcat-7.0-doc/config/manager.html#Nested_Components

  - Is the source posted some where?  So anyone curious could try it out?
  - Are there installation instructions?

Dan


 
 Kind Regards
 Simon

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54387] Having servlets with same url should at least cause warning

2013-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

Abdul Aziz javahop...@gmail.com changed:

   What|Removed |Added

Version|7.0.34  |7.0.47

--- Comment #8 from Abdul Aziz javahop...@gmail.com ---
I want to understand more..

having following configuration in deployment descriptor

servlet
servlet-namesn1/servlet-name
servlet-classcom.servlets.urlpatterns.Servlet1/servlet-class
/servlet
servlet-mapping
servlet-namesn1/servlet-name
url-pattern/s/url-pattern
/servlet-mapping

servlet
servlet-namesn2/servlet-name
servlet-classcom.servlets.urlpatterns.Servlet1/servlet-class
/servlet
servlet-mapping
servlet-namesn2/servlet-name
url-pattern/s/url-pattern
/servlet-mapping

why should the server startup / app deployment fail? what makes the difference?

Any how both the servlets sn1 and sn2 are referring to same Servlet1

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54387] Having servlets with same url should at least cause warning

2013-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

--- Comment #9 from Violeta Georgieva violet...@apache.org ---
(In reply to Abdul Aziz from comment #8)
 
 Any how both the servlets sn1 and sn2 are referring to same Servlet1

Once you use 
servlet-classcom.servlets.urlpatterns.Servlet1/servlet-class
the servlets will point to one and the same class.

But you need to specify different url-patterns that's the case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



RE: New JDBC SessionManager for non sticky-sessions

2013-12-10 Thread Spielmann, Simon
The main difference is, that session data is written to the database at the end 
of every request.
The existing jdbc session manager does only support lazy writes into the 
database, so if the app server crashes session data is not guaranteed written 
to the database.
We did some load testing, but compared it only to a in application session 
persistence, which does in fact the same but did not reside in tomcat.
We tested it with oracle rac, other database should be possible.
Main feature is the support for sticky seasons and higher availability, because 
sessions are in the database after every request (see above).
We have documented installation procedure (in German at the moment). 
Translation to English would be possible.
Code is not public available at the moment. I could probably publish it when 
general interest is there.

Simon

-Original Message-
From: Daniel Mikusa [mailto:dmik...@gopivotal.com]
Sent: Dienstag, 10. Dezember 2013 14:19
To: Tomcat Developers List
Subject: Re: New JDBC SessionManager for non sticky-sessions

On Dec 10, 2013, at 6:34 AM, Spielmann, Simon simon.spielm...@capgemini.com 
wrote:

 Hello together,

 we developed a custom JDBC SessionManager which supports non sticky-sessions.
 Is there interest in including this in the official tomcat distribution?

Can you tell us more?  Some questions coming to mind…

  - What motivated you to develop this?
  - How does it work? How does it integrate with Tomcat?
  - Have you performance / load tested it?  If so, with what results?
  - What databases does it support?  What tables does it need setup to work?
  - What benefits does it offer other than not requiring sticky sessions? or is 
that the main feature?
  - Can I use it with sticky sessions or would that break it / defeat the 
purpose?
  - How is it different than using a persistent manager with JDBC based store?

  
https://tomcat.apache.org/tomcat-7.0-doc/config/manager.html#Nested_Components

  - Is the source posted some where?  So anyone curious could try it out?
  - Are there installation instructions?

Dan



 Kind Regards
 Simon

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




Firma: Capgemini Deutschland GmbH
Geschäftsführer: Dr. Michael Schulte (Sprecher) • Dr. Uwe Dumslaff • Josef 
Ranner
Aufsichtsratsvorsitzender: Antonio Schnieder
Amtsgericht Berlin-Charlottenburg, HRB 98814
This message contains information that may be privileged or confidential and is 
the property of the Capgemini Group. It is intended only for the person to whom 
it is addressed. If you are not the intended recipient, you are not authorized 
to read, print, retain, copy, disseminate, distribute, or use this message or 
any part thereof. If you receive this message in error, please notify the 
sender immediately and delete all copies of this message.


Re: New JDBC SessionManager for non sticky-sessions

2013-12-10 Thread Daniel Mikusa
On Dec 10, 2013, at 9:00 AM, Spielmann, Simon simon.spielm...@capgemini.com 
wrote:

 The main difference is, that session data is written to the database at the 
 end of every request.
 The existing jdbc session manager does only support lazy writes into the 
 database, so if the app server crashes session data is not guaranteed written 
 to the database.
 We did some load testing, but compared it only to a in application session 
 persistence, which does in fact the same but did not reside in tomcat.
 We tested it with oracle rac, other database should be possible.
 Main feature is the support for sticky seasons and higher availability, 
 because sessions are in the database after every request (see above).
 We have documented installation procedure (in German at the moment). 
 Translation to English would be possible.
 Code is not public available at the moment. I could probably publish it when 
 general interest is there.

If it's not too much trouble, could you share the code and docs?  I'm 
interested enough to at least take a further look and give it a test run, 
assuming it's using the Apache license.

Dan

 
 Simon
 
 -Original Message-
 From: Daniel Mikusa [mailto:dmik...@gopivotal.com]
 Sent: Dienstag, 10. Dezember 2013 14:19
 To: Tomcat Developers List
 Subject: Re: New JDBC SessionManager for non sticky-sessions
 
 On Dec 10, 2013, at 6:34 AM, Spielmann, Simon 
 simon.spielm...@capgemini.com wrote:
 
 Hello together,
 
 we developed a custom JDBC SessionManager which supports non sticky-sessions.
 Is there interest in including this in the official tomcat distribution?
 
 Can you tell us more?  Some questions coming to mind…
 
  - What motivated you to develop this?
  - How does it work? How does it integrate with Tomcat?
  - Have you performance / load tested it?  If so, with what results?
  - What databases does it support?  What tables does it need setup to work?
  - What benefits does it offer other than not requiring sticky sessions? or 
 is that the main feature?
  - Can I use it with sticky sessions or would that break it / defeat the 
 purpose?
  - How is it different than using a persistent manager with JDBC based store?
 
  
 https://tomcat.apache.org/tomcat-7.0-doc/config/manager.html#Nested_Components
 
  - Is the source posted some where?  So anyone curious could try it out?
  - Are there installation instructions?
 
 Dan
 
 
 
 Kind Regards
 Simon
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org
 

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-7-trunk

2013-12-10 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-7-trunk/builds/1625

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1549836
Blamelist: markt

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot





RE: New JDBC SessionManager for non sticky-sessions

2013-12-10 Thread Spielmann, Simon
Sounds good. My customer who owns the usage rights is interested in providing 
the code. Nevertheless I have to ask for the official permission to provide the 
code now.




___
Simon Spielmann
Custom Solution Development | Application Services

Capgemini | Offenbach
Phone: +49 69 9515 2248 – Mobile: +49 160 477 2820
e-mail: simon.spielm...@capgemini.com
www.de.capgemini.com

Berliner Str 76, D-63065 Offenbach, Germany
People matter, results count.
___



-Original Message-
From: Daniel Mikusa [mailto:dmik...@gopivotal.com]
Sent: Dienstag, 10. Dezember 2013 15:18
To: Tomcat Developers List
Subject: Re: New JDBC SessionManager for non sticky-sessions

On Dec 10, 2013, at 9:00 AM, Spielmann, Simon simon.spielm...@capgemini.com 
wrote:

 The main difference is, that session data is written to the database at the 
 end of every request.
 The existing jdbc session manager does only support lazy writes into the 
 database, so if the app server crashes session data is not guaranteed written 
 to the database.
 We did some load testing, but compared it only to a in application session 
 persistence, which does in fact the same but did not reside in tomcat.
 We tested it with oracle rac, other database should be possible.
 Main feature is the support for sticky seasons and higher availability, 
 because sessions are in the database after every request (see above).
 We have documented installation procedure (in German at the moment). 
 Translation to English would be possible.
 Code is not public available at the moment. I could probably publish it when 
 general interest is there.

If it's not too much trouble, could you share the code and docs?  I'm 
interested enough to at least take a further look and give it a test run, 
assuming it's using the Apache license.

Dan


 Simon

 -Original Message-
 From: Daniel Mikusa [mailto:dmik...@gopivotal.com]
 Sent: Dienstag, 10. Dezember 2013 14:19
 To: Tomcat Developers List
 Subject: Re: New JDBC SessionManager for non sticky-sessions

 On Dec 10, 2013, at 6:34 AM, Spielmann, Simon 
 simon.spielm...@capgemini.com wrote:

 Hello together,

 we developed a custom JDBC SessionManager which supports non sticky-sessions.
 Is there interest in including this in the official tomcat distribution?

 Can you tell us more?  Some questions coming to mind…

  - What motivated you to develop this?
  - How does it work? How does it integrate with Tomcat?
  - Have you performance / load tested it?  If so, with what results?
  - What databases does it support?  What tables does it need setup to work?
  - What benefits does it offer other than not requiring sticky sessions? or 
 is that the main feature?
  - Can I use it with sticky sessions or would that break it / defeat the 
 purpose?
  - How is it different than using a persistent manager with JDBC based store?

  
 https://tomcat.apache.org/tomcat-7.0-doc/config/manager.html#Nested_Components

  - Is the source posted some where?  So anyone curious could try it out?
  - Are there installation instructions?

 Dan



 Kind Regards
 Simon

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




Firma: Capgemini Deutschland GmbH
Geschäftsführer: Dr. Michael Schulte (Sprecher) • Dr. Uwe Dumslaff • Josef 
Ranner
Aufsichtsratsvorsitzender: Antonio Schnieder
Amtsgericht Berlin-Charlottenburg, HRB 98814
This message contains information that may be privileged or confidential and is 
the property of the Capgemini Group. It is intended only for the person to whom 
it is addressed. If you are not the intended recipient, you are not authorized 
to read, print, retain, copy, disseminate, distribute, or use this message or 
any part thereof. If you receive this message in error, please notify the 
sender immediately and delete all copies of this message.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54387] Having servlets with same url should at least cause warning

2013-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

--- Comment #10 from Abdul Aziz javahop...@gmail.com ---
(In reply to Violeta Georgieva from comment #9)
 (In reply to Abdul Aziz from comment #8)
  
  Any how both the servlets sn1 and sn2 are referring to same Servlet1
 
 Once you use 
 servlet-classcom.servlets.urlpatterns.Servlet1/servlet-class
 the servlets will point to one and the same class.
 
 But you need to specify different url-patterns that's the case.

Correct!! My Question is, Why should the server start-up fail?

What difference would it make if I try to access either of the servlet's with
same url pattern?

I agree its foolish doing so.. But failure during server up doesn't make sense,
Right?

Earlier versions of Tomcat used to support this (prior to 7.0.35)

However server start-up should fail, if same url pattern refers to different
servlets say

servlet
servlet-namesn1/servlet-name
servlet-classcom.servlets.urlpatterns.Servlet1/servlet-class
/servlet
servlet-mapping
servlet-namesn1/servlet-name
url-pattern/s/url-pattern
/servlet-mapping

servlet
servlet-namesn2/servlet-name
servlet-classcom.servlets.urlpatterns.Servlet2/servlet-class
/servlet
servlet-mapping
servlet-namesn2/servlet-name
url-pattern/s/url-pattern
/servlet-mapping

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-trunk

2013-12-10 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/5315

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1549832
Blamelist: markt

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot





RE: [VOTE] Release Apache Tomcat 8.0.0-RC6

2013-12-10 Thread Konstantin Preißer
Hi,

 -Original Message-
 From: Mark Thomas [mailto:ma...@apache.org]
 Sent: Tuesday, December 10, 2013 1:22 AM

 snip/

  Any idea what is going on there? Why would Tomcat create such a big
  byte array for a static file?
 
 Lots of things going on here.
 
 1. The content of resources was still being cached on access even if it
 was bigger than the maximum object size.
 
 2. The test of object size was checking against the total limit for the
 cache rather than the single object limit.
 
 3. The DefaultServlet was working on assumptions that were true in the
 7.0.x resources implementation but not true in the new 8.0.x
 implementation.
 
 All of the above - and few additional issues spotted along the way -
 have been fixed in trunk.
 
 Thanks for the report.

Thanks, Mark. I can confirm that with r1549832, downloading the large static 
file works as expected.


Regards,
Konstantin Preißer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 7.0.48

2013-12-10 Thread Violeta Georgieva
2013/12/10 Mark Thomas ma...@apache.org

 On 10/12/2013 12:23, Mark Thomas wrote:
  On 09/12/2013 21:21, Violeta Georgieva wrote:
  The proposed Apache Tomcat 7.0.48 release is now available for voting.
 
  It can be obtained from:
  https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.48/
  The Maven staging repo is:
  https://repository.apache.org/content/repositories/orgapachetomcat-030/
  The svn tag is:
  http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_48/
 
  The proposed 7.0.48 release is:
  [X] Broken - do not release
  [ ] Stable - go ahead and release as 7.0.48 Stable
 
  XML validation is broken. I'm pretty sure I broke it. Looking at it now
  and I should have a fix shortly.

 It is the Tomcat 7 version of
 https://issues.apache.org/bugzilla/show_bug.cgi?id=55166 which is a
 regression introduced by the switch to the new LocalResolver.

 I am current testing the following patch:

 Index: java/org/apache/tomcat/util/descriptor/DigesterFactory.java
 ===
 --- java/org/apache/tomcat/util/descriptor/DigesterFactory.java
 (revision 1549529)
 +++ java/org/apache/tomcat/util/descriptor/DigesterFactory.java (working
 copy)
 @@ -96,6 +96,7 @@
  private static void addSelf(MapString, String ids, String id) {
  String systemId = idFor(id);
  ids.put(systemId, systemId);
 +ids.put(id, systemId);
  }

  private static String idFor(String url) {


 It is a little bit of a hack but so were all the other options I
 considered. So far the testing looks good.

 Mark


I'm canceling the vote and I'll tag 7.0.49 in order to include this fix.

Regards
Violeta


svn commit: r3866 - /dev/tomcat/tomcat-7/v7.0.48/

2013-12-10 Thread violetagg
Author: violetagg
Date: Tue Dec 10 17:07:00 2013
New Revision: 3866

Log:
7.0.48 did not pass the vote - dropping.

Removed:
dev/tomcat/tomcat-7/v7.0.48/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r3866 - /dev/tomcat/tomcat-7/v7.0.48/

2013-12-10 Thread violetagg
Author: violetagg
Date: Tue Dec 10 17:07:00 2013
New Revision: 3866

Log:
7.0.48 did not pass the vote - dropping.

Removed:
dev/tomcat/tomcat-7/v7.0.48/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 7.0.48

2013-12-10 Thread Rainer Jung
On 09.12.2013 22:21, Violeta Georgieva wrote:
 The proposed Apache Tomcat 7.0.48 release is now available for voting.
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.48/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-030/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_48/
 
 The proposed 7.0.48 release is:
 [ ] Broken - do not release
 [ ] Stable - go ahead and release as 7.0.48 Stable

I see one test suite failure:

INFO: Failures in
output/build/logs/TEST-org.apache.tomcat.websocket.TestWsSubprotocols.APR.txt
WARN: Test failure in
'output/build/logs/TEST-org.apache.tomcat.websocket.TestWsSubprotocols.APR.txt':
Testsuite: org.apache.tomcat.websocket.TestWsSubprotocols
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.088 sec
- Standard Error -
Dec 10, 2013 10:55:59 AM org.apache.catalina.core.AprLifecycleListener init
INFO: Loaded APR based Apache Tomcat Native library 1.1.29 using APR
version 1.4.8.
Dec 10, 2013 10:55:59 AM org.apache.catalina.core.AprLifecycleListener init
INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters
[false], random [true].
Dec 10, 2013 10:55:59 AM org.apache.catalina.core.AprLifecycleListener
initializeSSL
INFO: OpenSSL successfully initialized (OpenSSL 1.0.1esp1 12 Feb 2013)
Dec 10, 2013 10:56:01 AM org.apache.coyote.AbstractProtocol init
INFO: Initializing ProtocolHandler [http-apr-127.0.0.1-auto-1]
Dec 10, 2013 10:56:01 AM org.apache.catalina.core.StandardService
startInternal
INFO: Starting service Tomcat
Dec 10, 2013 10:56:01 AM org.apache.catalina.core.StandardEngine
startInternal
INFO: Starting Servlet Engine: Apache Tomcat/7.0.48
Dec 10, 2013 10:56:02 AM org.apache.catalina.util.SessionIdGenerator
createSecureRandom
INFO: Creation of SecureRandom instance for session ID generation using
[INSECURE] took [404] milliseconds.
Dec 10, 2013 10:56:02 AM org.apache.coyote.AbstractProtocol start
INFO: Starting ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
Dec 10, 2013 10:56:02 AM org.apache.catalina.util.LifecycleBase start
INFO: The start() method was called on component [StandardServer[-1]]
after start() had already been called. The second call will be ignored.
Dec 10, 2013 10:56:03 AM org.apache.coyote.AbstractProtocol pause
INFO: Pausing ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
Dec 10, 2013 10:56:03 AM org.apache.catalina.core.StandardService
stopInternal
INFO: Stopping service Tomcat
Dec 10, 2013 10:56:03 AM
org.apache.tomcat.websocket.server.WsHttpUpgradeHandler destroy
SEVERE: Failed to close WebConnection while destroying the WebSocket
HttpUpgradeHandler
java.lang.NullPointerException
at
org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.destroy(WsHttpUpgradeHandler.java:143)
at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:686)
at
org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.doRun(AprEndpoint.java:2441)
at
org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:2430)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)

Dec 10, 2013 10:56:03 AM org.apache.coyote.AbstractProtocol stop
INFO: Stopping ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
Dec 10, 2013 10:56:03 AM org.apache.coyote.AbstractProtocol destroy
INFO: Destroying ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
-  ---

Testcase: testWsSubprotocols took 5.032 sec
Caused an ERROR
null
java.lang.NullPointerException
at
org.apache.tomcat.websocket.TestWsSubprotocols.testWsSubprotocols(TestWsSubprotocols.java:89)


I can't investigate more currently, but maybe that already rings a bell?

The line in question is 143 in WsHttpUpgradeHandler.java:

140 @Override
141 public void destroy() {
142 try {
143 connection.close();
144 } catch (Exception e) {
145
log.error(sm.getString(wsHttpUpgradeHandler.destroyFailed), e);
146 }
147 }

so the connection must be null.

Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1549904 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2013-12-10 Thread violetagg
Author: violetagg
Date: Tue Dec 10 17:28:52 2013
New Revision: 1549904

URL: http://svn.apache.org/r1549904
Log:
Mark 7.0.48 as not released based on the vote results.

Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1549904r1=1549903r2=1549904view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Tue Dec 10 17:28:52 2013
@@ -55,7 +55,9 @@
   They eventually become mixed with the numbered issues. (I.e., numbered
   issues to not pop up wrt. others).
 --
-section name=Tomcat 7.0.48 (violetagg)
+section name=Tomcat 7.0.49 (violetagg)
+/section
+section name=Tomcat 7.0.48 (violetagg) rtext=not released
   subsection name=Catalina
 changelog
   add



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1549909 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java

2013-12-10 Thread violetagg
Author: violetagg
Date: Tue Dec 10 17:54:52 2013
New Revision: 1549909

URL: http://svn.apache.org/r1549909
Log:
In o.a.tomcat.websocket.server.WsHttpUpgradeHandler.init(WebConnection) if the 
endpoint is NULL the connection will not be initialized.
Then in o.a.tomcat.websocket.server.WsHttpUpgradeHandler.destroy() the 
connection should be tested for NULL.

Modified:

tomcat/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java

Modified: 
tomcat/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java?rev=1549909r1=1549908r2=1549909view=diff
==
--- 
tomcat/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java 
(original)
+++ 
tomcat/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java 
Tue Dec 10 17:54:52 2013
@@ -139,10 +139,12 @@ public class WsHttpUpgradeHandler implem
 
 @Override
 public void destroy() {
-try {
-connection.close();
-} catch (Exception e) {
-log.error(sm.getString(wsHttpUpgradeHandler.destroyFailed), e);
+if (connection != null) {
+try {
+connection.close();
+} catch (Exception e) {
+log.error(sm.getString(wsHttpUpgradeHandler.destroyFailed), 
e);
+}
 }
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1549911 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2013-12-10 Thread markt
Author: markt
Date: Tue Dec 10 18:00:42 2013
New Revision: 1549911

URL: http://svn.apache.org/r1549911
Log:
Update changelog

Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1549911r1=1549910r2=1549911view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Tue Dec 10 18:00:42 2013
@@ -56,6 +56,12 @@
   issues to not pop up wrt. others).
 --
 section name=Tomcat 7.0.49 (violetagg)
+  subsection name=Catalina
+changelog
+  Correct a regression in the new XML local resolver that triggered false
+  failures when XML validation was configured. (markt)
+/changelog
+  /subsection
 /section
 section name=Tomcat 7.0.48 (violetagg) rtext=not released
   subsection name=Catalina



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 7.0.48

2013-12-10 Thread Violeta Georgieva
2013/12/10 Rainer Jung rainer.j...@kippdata.de

 On 09.12.2013 22:21, Violeta Georgieva wrote:
  The proposed Apache Tomcat 7.0.48 release is now available for voting.
 
  It can be obtained from:
  https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.48/
  The Maven staging repo is:
  https://repository.apache.org/content/repositories/orgapachetomcat-030/
  The svn tag is:
  http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_48/
 
  The proposed 7.0.48 release is:
  [ ] Broken - do not release
  [ ] Stable - go ahead and release as 7.0.48 Stable

 I see one test suite failure:

 INFO: Failures in

output/build/logs/TEST-org.apache.tomcat.websocket.TestWsSubprotocols.APR.txt
 WARN: Test failure in

'output/build/logs/TEST-org.apache.tomcat.websocket.TestWsSubprotocols.APR.txt':
 Testsuite: org.apache.tomcat.websocket.TestWsSubprotocols
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 5.088 sec
 - Standard Error -
 Dec 10, 2013 10:55:59 AM org.apache.catalina.core.AprLifecycleListener
init
 INFO: Loaded APR based Apache Tomcat Native library 1.1.29 using APR
 version 1.4.8.
 Dec 10, 2013 10:55:59 AM org.apache.catalina.core.AprLifecycleListener
init
 INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters
 [false], random [true].
 Dec 10, 2013 10:55:59 AM org.apache.catalina.core.AprLifecycleListener
 initializeSSL
 INFO: OpenSSL successfully initialized (OpenSSL 1.0.1esp1 12 Feb 2013)
 Dec 10, 2013 10:56:01 AM org.apache.coyote.AbstractProtocol init
 INFO: Initializing ProtocolHandler [http-apr-127.0.0.1-auto-1]
 Dec 10, 2013 10:56:01 AM org.apache.catalina.core.StandardService
 startInternal
 INFO: Starting service Tomcat
 Dec 10, 2013 10:56:01 AM org.apache.catalina.core.StandardEngine
 startInternal
 INFO: Starting Servlet Engine: Apache Tomcat/7.0.48
 Dec 10, 2013 10:56:02 AM org.apache.catalina.util.SessionIdGenerator
 createSecureRandom
 INFO: Creation of SecureRandom instance for session ID generation using
 [INSECURE] took [404] milliseconds.
 Dec 10, 2013 10:56:02 AM org.apache.coyote.AbstractProtocol start
 INFO: Starting ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
 Dec 10, 2013 10:56:02 AM org.apache.catalina.util.LifecycleBase start
 INFO: The start() method was called on component [StandardServer[-1]]
 after start() had already been called. The second call will be ignored.
 Dec 10, 2013 10:56:03 AM org.apache.coyote.AbstractProtocol pause
 INFO: Pausing ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
 Dec 10, 2013 10:56:03 AM org.apache.catalina.core.StandardService
 stopInternal
 INFO: Stopping service Tomcat
 Dec 10, 2013 10:56:03 AM
 org.apache.tomcat.websocket.server.WsHttpUpgradeHandler destroy
 SEVERE: Failed to close WebConnection while destroying the WebSocket
 HttpUpgradeHandler
 java.lang.NullPointerException
 at

org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.destroy(WsHttpUpgradeHandler.java:143)
 at

org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:686)
 at

org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.doRun(AprEndpoint.java:2441)
 at

org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:2430)
 at

java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
 at

java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
 at java.lang.Thread.run(Thread.java:744)

 Dec 10, 2013 10:56:03 AM org.apache.coyote.AbstractProtocol stop
 INFO: Stopping ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
 Dec 10, 2013 10:56:03 AM org.apache.coyote.AbstractProtocol destroy
 INFO: Destroying ProtocolHandler [http-apr-127.0.0.1-auto-1-50559]
 -  ---

 Testcase: testWsSubprotocols took 5.032 sec
 Caused an ERROR
 null
 java.lang.NullPointerException
 at

org.apache.tomcat.websocket.TestWsSubprotocols.testWsSubprotocols(TestWsSubprotocols.java:89)


 I can't investigate more currently, but maybe that already rings a bell?

 The line in question is 143 in WsHttpUpgradeHandler.java:

 140 @Override
 141 public void destroy() {
 142 try {
 143 connection.close();
 144 } catch (Exception e) {
 145
 log.error(sm.getString(wsHttpUpgradeHandler.destroyFailed), e);
 146 }
 147 }

 so the connection must be null.

 Regards,

 Rainer


This NPE can happen if for some reason the endpoint is NULL then the
connection is not initialized.
Do you see any other log or trace?
I cannot reproduce the failure.

Regards
Violeta


buildbot success in ASF Buildbot on tomcat-7-trunk

2013-12-10 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-7-trunk/builds/1626

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1549904
Blamelist: violetagg

Build succeeded!

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1549918 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java webapps/docs/changelog.xml

2013-12-10 Thread violetagg
Author: violetagg
Date: Tue Dec 10 18:21:28 2013
New Revision: 1549918

URL: http://svn.apache.org/r1549918
Log:
Merged revision 1549909 from tomcat/trunk:
In o.a.tomcat.websocket.server.WsHttpUpgradeHandler.init(WebConnection) if the 
endpoint is NULL the connection will not be initialized.
Then in o.a.tomcat.websocket.server.WsHttpUpgradeHandler.destroy() the 
connection should be tested for NULL.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)

tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1549909

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java?rev=1549918r1=1549917r2=1549918view=diff
==
--- 
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java
 (original)
+++ 
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java
 Tue Dec 10 18:21:28 2013
@@ -139,10 +139,12 @@ public class WsHttpUpgradeHandler implem
 
 @Override
 public void destroy() {
-try {
-connection.close();
-} catch (Exception e) {
-log.error(sm.getString(wsHttpUpgradeHandler.destroyFailed), e);
+if (connection != null) {
+try {
+connection.close();
+} catch (Exception e) {
+log.error(sm.getString(wsHttpUpgradeHandler.destroyFailed), 
e);
+}
 }
 }
 

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1549918r1=1549917r2=1549918view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Tue Dec 10 18:21:28 2013
@@ -58,8 +58,14 @@
 section name=Tomcat 7.0.49 (violetagg)
   subsection name=Catalina
 changelog
-  Correct a regression in the new XML local resolver that triggered false
-  failures when XML validation was configured. (markt)
+  fix
+Correct a regression in the new XML local resolver that triggered false
+failures when XML validation was configured. (markt)
+  /fix
+  fix
+Prevent a NPE when destroying HTTP upgrade handler for WebSocket
+connections. (violetagg)
+  /fix
 /changelog
   /subsection
 /section



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-7-trunk

2013-12-10 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-7-trunk/builds/1627

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1549911
Blamelist: markt

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot





buildbot success in ASF Buildbot on tomcat-7-trunk

2013-12-10 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-7-trunk/builds/1628

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1549918
Blamelist: violetagg

Build succeeded!

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Created] (MTOMCAT-250) Pull Request: Support Alternate Session Managers in Standalone War Bootstrap

2013-12-10 Thread Josh Chaitin-Pollak (JIRA)
Josh Chaitin-Pollak created MTOMCAT-250:
---

 Summary: Pull Request: Support Alternate Session Managers in 
Standalone War Bootstrap
 Key: MTOMCAT-250
 URL: https://issues.apache.org/jira/browse/MTOMCAT-250
 Project: Apache Tomcat Maven Plugin
  Issue Type: Improvement
Reporter: Josh Chaitin-Pollak
Priority: Minor


Hello,

I have created a pull request on GitHub to allow the standalone war 
bootstrapper to use a factory to create an alternate session manager.

https://github.com/apache/tomcat-maven-plugin/pull/5

I am using this with a modified version of the memcached-session-manager 
project to allow my standalone war project to use that session manager.

I think this would be of utility to more people. Here is the MSM pull request 
for reference: https://github.com/magro/memcached-session-manager/pull/33

And here is an example of how you would use this patch:

{code}
java -Dmsm.memcachedNodes=n1:localhost:21211 -jar standalone.jar \
   -sessionManagerFactory 
de.javakaffee.web.msm.MemcachedBackupSessionManagerFactory
{code}



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org