[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 3 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-nio2 : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2 -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build) Work ended in a state of : Failed Elapsed: 25 mins 31 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO2 -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140807-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140807.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140807-native-src.tar.gz -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true -Dexecute.test.nio=false -Dexecute.test.apr=false -Dexecute.test.bio=false -Dexecute.test.nio2=t rue -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/hamcrest-java/build/hamcrest-core-20140807.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu ild/lib/tomcat-spdy.jar:/srv/gump/public/workspace/tomcat-trunk/output/
buildbot success in ASF Buildbot on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/334 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1616310 Blamelist: markt Build succeeded! sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot retry in ASF Buildbot on tomcat-trunk
on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/331 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1616310 Blamelist: markt BUILD FAILED: retry exception slave lost sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56798] Idle eviction strategy could perform better (and is sometimes suboptimal)
https://issues.apache.org/bugzilla/show_bug.cgi?id=56798 --- Comment #7 from Bertrand Renuart --- (In reply to Chuck Caldarale from comment #6) The pool currently uses java.util.concurrent.ArrayBlockingQueue unless a "fair" implementation is requested (in which case a custom implementation is used). A stack/LIFO/MRU strategy could be built on top of a java.util.concurrent.LinkedBlockingDeque. I'm not an expert in concurrency issues but both implementations seem to make use of a single global lock for their put/get operations. We should therefore get the same performances except may be for a small penalty for the LinkedBlockingDeque due to the extra overhead of creating Nodes. I made a quick prototype by changing the idle pool into a LinkedBlockingDeque and ran about 100 concurrent threads asking for 10 thousands connections each. At first glance the difference between the two approaches is minimal. I haven't got any further though because you may already have been doing tests in that direction... -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/330 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1616309 Blamelist: markt Build succeeded! sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56739] Error response body generated only occasionally
https://issues.apache.org/bugzilla/show_bug.cgi?id=56739 --- Comment #3 from Mark Thomas --- Generally we like to close every open bug (not enahncement request) for a branch (e.g. 8.0.x) before we do the next 8.0.x release. The excpetion is API breaking changes. Tomcat doesn't have a black and white view of what is the public API and what isn't. It is very much a judgement call based on how likely we think it is that someone will have written a custom component that is using the API that needs to change. How we handle these sorts of changes depends on the severity of the bug, the scale of the API change and what those API changes are. For this particular bug I think I can see a solution but I'm not there yet. There are API changes but they aren't in an area where I'd expect folks to be writing custom components (I don't think I'll need to change the ErrorReportValve for example) so - assuming my solution works - this should be in the next 8.0.x release. It should also make it into the next 7.0.x release. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56739] Error response body generated only occasionally
https://issues.apache.org/bugzilla/show_bug.cgi?id=56739 --- Comment #2 from marko asplund --- Thanks for the update and investigating this issue! What's the Tomcat dev team's policy to fixing issues like this? Is it something that can be addressed in a TC 7.0 / 8.0 maintenance releases? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1616310 - /tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
Author: markt
Date: Wed Aug 6 19:14:27 2014
New Revision: 1616310
URL: http://svn.apache.org/r1616310
Log:
Refactor - no functional change
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java?rev=1616310&r1=1616309&r2=1616310&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java Wed Aug
6 19:14:27 2014
@@ -130,54 +130,56 @@ final class StandardHostValve extends Va
try {
context.bind(Globals.IS_SECURITY_ENABLED, MY_CLASSLOADER);
-if (asyncAtStart || context.fireRequestInitEvent(request)) {
-
-// Ask this Context to process this request
-try {
-context.getPipeline().getFirst().invoke(request, response);
-} catch (Throwable t) {
-ExceptionUtils.handleThrowable(t);
-if (errorAtStart) {
-container.getLogger().error("Exception Processing " +
-request.getRequestURI(), t);
-} else {
-
request.setAttribute(RequestDispatcher.ERROR_EXCEPTION, t);
-throwable(request, response, t);
-}
+if (!asyncAtStart && !context.fireRequestInitEvent(request)) {
+// If a listener fails then request processing stops here.
+return;
+}
+
+// Ask this Context to process this request
+try {
+context.getPipeline().getFirst().invoke(request, response);
+} catch (Throwable t) {
+ExceptionUtils.handleThrowable(t);
+if (errorAtStart) {
+container.getLogger().error("Exception Processing " +
+request.getRequestURI(), t);
+} else {
+request.setAttribute(RequestDispatcher.ERROR_EXCEPTION, t);
+throwable(request, response, t);
}
+}
-Throwable t = (Throwable)
request.getAttribute(RequestDispatcher.ERROR_EXCEPTION);
+Throwable t = (Throwable)
request.getAttribute(RequestDispatcher.ERROR_EXCEPTION);
-// If the request was async at the start and an error occurred
-// then the async error handling will kick-in and that will
fire
-// the request destroyed event *after* the error handling has
-// taken place.
-if (!(request.isAsync() || (asyncAtStart && t != null))) {
-// Protect against NPEs if context was destroyed during a
-// long running request.
-if (context.getState().isAvailable()) {
-if (!errorAtStart) {
-// Error page processing
-response.setSuspended(false);
-
-if (t != null) {
-throwable(request, response, t);
-} else {
-status(request, response);
-}
+// If the request was async at the start and an error occurred
+// then the async error handling will kick-in and that will fire
+// the request destroyed event *after* the error handling has
+// taken place.
+if (!(request.isAsync() || (asyncAtStart && t != null))) {
+// Protect against NPEs if context was destroyed during a
+// long running request.
+if (context.getState().isAvailable()) {
+if (!errorAtStart) {
+// Error page processing
+response.setSuspended(false);
+
+if (t != null) {
+throwable(request, response, t);
+} else {
+status(request, response);
}
-
-context.fireRequestDestroyEvent(request);
}
+
+context.fireRequestDestroyEvent(request);
}
}
-
+} finally {
// Access a session (if present) to update last accessed time,
based
// on a strict interpretation of the specification
if (ACCESS_SESSION) {
request.getSession(false);
}
-} finally {
+
context.unbind(Globals.IS_SECURITY_ENABLED, MY_CLASSLOADER);
}
}
-
svn commit: r1616309 - /tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
Author: markt
Date: Wed Aug 6 19:08:07 2014
New Revision: 1616309
URL: http://svn.apache.org/r1616309
Log:
Ensure unbind() is always called after calling bind()
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java?rev=1616309&r1=1616308&r2=1616309&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java Wed Aug
6 19:08:07 2014
@@ -127,57 +127,59 @@ final class StandardHostValve extends Va
// ensure an infinite error handling loop is not entered
boolean errorAtStart = response.isError();
-context.bind(Globals.IS_SECURITY_ENABLED, MY_CLASSLOADER);
+try {
+context.bind(Globals.IS_SECURITY_ENABLED, MY_CLASSLOADER);
-if (asyncAtStart || context.fireRequestInitEvent(request)) {
+if (asyncAtStart || context.fireRequestInitEvent(request)) {
-// Ask this Context to process this request
-try {
-context.getPipeline().getFirst().invoke(request, response);
-} catch (Throwable t) {
-ExceptionUtils.handleThrowable(t);
-if (errorAtStart) {
-container.getLogger().error("Exception Processing " +
-request.getRequestURI(), t);
-} else {
-request.setAttribute(RequestDispatcher.ERROR_EXCEPTION, t);
-throwable(request, response, t);
+// Ask this Context to process this request
+try {
+context.getPipeline().getFirst().invoke(request, response);
+} catch (Throwable t) {
+ExceptionUtils.handleThrowable(t);
+if (errorAtStart) {
+container.getLogger().error("Exception Processing " +
+request.getRequestURI(), t);
+} else {
+
request.setAttribute(RequestDispatcher.ERROR_EXCEPTION, t);
+throwable(request, response, t);
+}
}
-}
-Throwable t = (Throwable)
request.getAttribute(RequestDispatcher.ERROR_EXCEPTION);
+Throwable t = (Throwable)
request.getAttribute(RequestDispatcher.ERROR_EXCEPTION);
-// If the request was async at the start and an error occurred then
-// the async error handling will kick-in and that will fire the
-// request destroyed event *after* the error handling has taken
-// place
-if (!(request.isAsync() || (asyncAtStart && t != null))) {
-// Protect against NPEs if context was destroyed during a
-// long running request.
-if (context.getState().isAvailable()) {
-if (!errorAtStart) {
-// Error page processing
-response.setSuspended(false);
-
-if (t != null) {
-throwable(request, response, t);
-} else {
-status(request, response);
+// If the request was async at the start and an error occurred
+// then the async error handling will kick-in and that will
fire
+// the request destroyed event *after* the error handling has
+// taken place.
+if (!(request.isAsync() || (asyncAtStart && t != null))) {
+// Protect against NPEs if context was destroyed during a
+// long running request.
+if (context.getState().isAvailable()) {
+if (!errorAtStart) {
+// Error page processing
+response.setSuspended(false);
+
+if (t != null) {
+throwable(request, response, t);
+} else {
+status(request, response);
+}
}
-}
-context.fireRequestDestroyEvent(request);
+context.fireRequestDestroyEvent(request);
+}
}
}
-}
-// Access a session (if present) to update last accessed time, based
on a
-// strict interpretation of the specification
-if (ACCESS_SESSION) {
-request.getSession(false);
+// Access a session (if present) to update last accessed time,
based
+
svn commit: r1616308 - /tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
Author: markt
Date: Wed Aug 6 19:05:58 2014
New Revision: 1616308
URL: http://svn.apache.org/r1616308
Log:
Re-ordering - no functional change
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java?rev=1616308&r1=1616307&r2=1616308&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java Wed Aug
6 19:05:58 2014
@@ -115,8 +115,6 @@ final class StandardHostValve extends Va
return;
}
-context.bind(Globals.IS_SECURITY_ENABLED, MY_CLASSLOADER);
-
if (request.isAsyncSupported()) {
request.setAsyncSupported(context.getPipeline().isAsyncSupported());
}
@@ -128,6 +126,9 @@ final class StandardHostValve extends Va
// An async error page may dispatch to another resource. This flag
helps
// ensure an infinite error handling loop is not entered
boolean errorAtStart = response.isError();
+
+context.bind(Globals.IS_SECURITY_ENABLED, MY_CLASSLOADER);
+
if (asyncAtStart || context.fireRequestInitEvent(request)) {
// Ask this Context to process this request
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1616307 - /tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
Author: markt
Date: Wed Aug 6 19:05:15 2014
New Revision: 1616307
URL: http://svn.apache.org/r1616307
Log:
Code simplification & reformatting - no functional change
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java?rev=1616307&r1=1616306&r2=1616307&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardHostValve.java Wed Aug
6 19:05:15 2014
@@ -110,8 +110,7 @@ final class StandardHostValve extends Va
// Select the Context to be used for this Request
Context context = request.getContext();
if (context == null) {
-response.sendError
-(HttpServletResponse.SC_INTERNAL_SERVER_ERROR,
+response.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR,
sm.getString("standardHost.noContext"));
return;
}
@@ -145,13 +144,13 @@ final class StandardHostValve extends Va
}
}
+Throwable t = (Throwable)
request.getAttribute(RequestDispatcher.ERROR_EXCEPTION);
+
// If the request was async at the start and an error occurred then
// the async error handling will kick-in and that will fire the
// request destroyed event *after* the error handling has taken
// place
-if (!(request.isAsync() || (asyncAtStart &&
-request.getAttribute(
-RequestDispatcher.ERROR_EXCEPTION) != null))) {
+if (!(request.isAsync() || (asyncAtStart && t != null))) {
// Protect against NPEs if context was destroyed during a
// long running request.
if (context.getState().isAvailable()) {
@@ -159,9 +158,6 @@ final class StandardHostValve extends Va
// Error page processing
response.setSuspended(false);
-Throwable t = (Throwable) request.getAttribute(
-RequestDispatcher.ERROR_EXCEPTION);
-
if (t != null) {
throwable(request, response, t);
} else {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55943] Provide a way prevent looking at the System classloader before the webapp classloaders
https://issues.apache.org/bugzilla/show_bug.cgi?id=55943 betoneto@gmail.com changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56756] VM argument javaagent is not working
https://issues.apache.org/bugzilla/show_bug.cgi?id=56756 betoneto@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #8 from betoneto@gmail.com --- 1 - Import the attachment as a project in Eclipse JEE (my version is Kepler) 2 - Configure 2 WTP servers (with tomcat 7.40 and 7.54) 3 - Configure the java agent in both server launchers -javaagent:"c:\users\YOUR_USER\.m2\repository\org\springframework\spring-instrument\4.0.5.RELEASE\spring-instrument-4.0.5.RELEASE.jar"" 5 - Run the server with tomcat 7.40 6 - Access the web application on your browser: http://localhost:8080/test-instrumentation 7 - This page will print: Instrumentation is: on 8 - Stop the server, and run the other (with tomcat 7.54) 9 - Access the web application url again 10 - This time the page print: Instrumentation is: off -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56756] VM argument javaagent is not working
https://issues.apache.org/bugzilla/show_bug.cgi?id=56756 --- Comment #7 from betoneto@gmail.com --- Created attachment 31883 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31883&action=edit web application to reproduce 1 - Import the attachment as a project in Eclipse JEE (my version is Kepler) 2 - Configure 2 WTP servers (with tomcat 7.40 and 7.54) 3 - Configure the java agent in both server launchers -javaagent:"c:\users\YOUR_USER\.m2\repository\org\springframework\spring-instrument\4.0.5.RELEASE\spring-instrument-4.0.5.RELEASE.jar"" 5 - Run the server with tomcat 7.40 6 - Access the web application on your browser: http://localhost:8080/test-instrumentation 7 - This page will print: Instrumentation is: on 8 - Stop the server, and run the other (with tomcat 7.54) 9 - Access the web application url again 10 - This time the page print: Instrumentation is: off -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56756] VM argument javaagent is not working
https://issues.apache.org/bugzilla/show_bug.cgi?id=56756 --- Comment #6 from betoneto@gmail.com --- Created attachment 31882 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31882&action=edit example to reproduce This is an maven project using: - servlet 3.0 - spring 4.0.5 instrumentation Open eclipse JEE: 1 - import the project (attachment) 2 - configure a WTP server with tomcat 7.40 3 - configure a WTP server with tomcat 7.54 4 - in the both server launchers configure the java agent -javaagent:"c:\users\user\.m2\repository\org\springframework\spring-instrument\4.0.5.RELEASE\spring-instrument-4.0.5.RELEASE.jar" 5 - run the application on server 7.40 6 - access the site (http://localhost:8080/test-instrumentation) 7 - this site will print: Instrumentation is: on 8 - stop the server, and run the other (7.54) 9 - access the same url site 10 - note, this time the site will print: Instrumentation is: off -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: AuthenticatorBase bug using SSL?
2014-08-06 16:19 GMT+02:00 Mark Thomas : > On 06/08/2014 14:54, Jean-Louis MONTEIRO wrote: > > Hello guys, > > > > I'm currently facing an issue with the BaseAuthenticator. > > Before opening a issue on the bug tracker, I'd like to get your opinion > > guys. > > The members of this list include both men and women. Please use a more > inclusive term than "guys". > > My apologize if I offended someone, it was definitely my intention. I've always used "you guys" when addressing a group of men, or a group of women, or a group of mixed gender. English is not my main langage, that's why I probably abused the term. Never heard girls or ladies complaining until now. Amazing situation that a guy is actually complaining :) Not the purpose of the post nor the mailing list. Thanks anyway for the answer, I gonna open an issue. Jean-Louis
[Bug 56756] VM argument javaagent is not working
https://issues.apache.org/bugzilla/show_bug.cgi?id=56756 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Mark Thomas --- I have tested this with 7.0.40, 7.0.x and 8.0.x and all work as expected. This looks like configuration error. The users list is the place to seek help. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56756] VM argument javaagent is not working
https://issues.apache.org/bugzilla/show_bug.cgi?id=56756 --- Comment #4 from Mark Thomas --- >From Andy Wilkinson (Spring developer at $work): ...if you want to involve as little of Spring as possible a Servlet that calls InstrumentationLoadTimeWeaver.isInstrumentationAvailable() directly should be sufficient. It'll return true if things are working and false if they're not. That class is in spring-context. This should be enough for me to reproduce / test this. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: AuthenticatorBase bug using SSL?
On 06/08/2014 14:54, Jean-Louis MONTEIRO wrote: > Hello guys, > > I'm currently facing an issue with the BaseAuthenticator. > Before opening a issue on the bug tracker, I'd like to get your opinion > guys. The members of this list include both men and women. Please use a more inclusive term than "guys". > The use case is simple: use an HTTPS tomcat connector with mutual > authentication (CLIENT-CERT). > > It does not involve at all any front serveur like Apache HTTPD. > > Everything works fine until you want to add the SSLAuthenticator valve with > the preemptive mode. > At the end of the invoke method (AuthenticatorBase), the presence of the > X509 certificate is checked under the usual key (ie. > request.getAttribute(Globals.CERTIFICATES_ATTR)). > > This works fine when using an Apache HTTPD front, but does not work with > tomcat SSL connectors cause the request is not populated. > > If you check the Authenticate of the SSLAuthenticator that should be invoke > is a certificate is found, if nothing is found in the request under the > usual key, the following is done before trying again > > request.getCoyoteRequest().action(ActionCode.REQ_SSL_CERTIFICATE, null); > > Roughly and simply speaking, the certificat is going to be extracted from > the coyote request and the entry in the HTTP request is populated. > > I'm wondering why it's not done also in the AuthenticatorBase? An oversight. > It makes it impossible to use the preemptive mode with the SSLAuthenticator > valve. > > I think creating a getRequestCertificate() method in the AuthenticatorBase > that wraps up the logic of calling or not the coyote request would do the > trick. Then it's just a matter of using it in the invoke method > (AuthenticatorBase) or in the authenticate (SSLAuthenticator). Agreed. > Feedback welcome so that I can create a JIRA and submit a patch if you want. Patches welcome (via Bugzilla, Tomcat doesn't use JIRA). Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-nio2 : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2 -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build) Work ended in a state of : Failed Elapsed: 25 mins 24 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO2 -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140806-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140806.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140806-native-src.tar.gz -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true -Dexecute.test.nio=false -Dexecute.test.apr=false -Dexecute.test.bio=false -Dexecute.test.nio2=t rue -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/hamcrest-java/build/hamcrest-core-20140806.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu ild/lib/tomcat-spdy.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomca
buildbot failure in ASF Buildbot on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/329 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1616204 Blamelist: markt BUILD FAILED: failed compile_1 sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
AuthenticatorBase bug using SSL?
Hello guys, I'm currently facing an issue with the BaseAuthenticator. Before opening a issue on the bug tracker, I'd like to get your opinion guys. The use case is simple: use an HTTPS tomcat connector with mutual authentication (CLIENT-CERT). It does not involve at all any front serveur like Apache HTTPD. Everything works fine until you want to add the SSLAuthenticator valve with the preemptive mode. At the end of the invoke method (AuthenticatorBase), the presence of the X509 certificate is checked under the usual key (ie. request.getAttribute(Globals.CERTIFICATES_ATTR)). This works fine when using an Apache HTTPD front, but does not work with tomcat SSL connectors cause the request is not populated. If you check the Authenticate of the SSLAuthenticator that should be invoke is a certificate is found, if nothing is found in the request under the usual key, the following is done before trying again request.getCoyoteRequest().action(ActionCode.REQ_SSL_CERTIFICATE, null); Roughly and simply speaking, the certificat is going to be extracted from the coyote request and the entry in the HTTP request is populated. I'm wondering why it's not done also in the AuthenticatorBase? It makes it impossible to use the preemptive mode with the SSLAuthenticator valve. I think creating a getRequestCertificate() method in the AuthenticatorBase that wraps up the logic of calling or not the coyote request would do the trick. Then it's just a matter of using it in the invoke method (AuthenticatorBase) or in the authenticate (SSLAuthenticator). Feedback welcome so that I can create a JIRA and submit a patch if you want. -- Jean-Louis
[Bug 56739] Error response body generated only occasionally
https://issues.apache.org/bugzilla/show_bug.cgi?id=56739 --- Comment #1 from Mark Thomas --- The good news is that I now know what is going on here. When the request is received it is process on container Thread C. By the time the thread reaches the Servlet, it has passed through Tomcat's request processing pipeline including the ErrorReportValve. If the Servlet's doGet() method, an application thread A is created just before the end of doGet(). Thread C then starts to exit Tomcat's request processing pipeline. Thread A calls sendError() and complete(). If thread C exits the ErrorReportValve before thread A calls sendError() then no response body will be generated. If thread A calls sendError() before thread C exits the ErrorReportValve then a response body will be generated. In short, this comes down to a timing issue between the container and the application thread and the way that Tomcat reports unhandled errors with the ErrorReportValve. It would also be the case the a custom error page (handled by the StandardHostValve) is unlikely to be called in this case. The bad news is that I don't see an obvious fix. It looks like the error page handling is going to need some refactoring but doing that without breaking the existing API (particularly for the ErrorReportVlave) is going to be tricky. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1616204 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java
Author: markt
Date: Wed Aug 6 12:27:43 2014
New Revision: 1616204
URL: http://svn.apache.org/r1616204
Log:
Avoid possible NPE (unlikely but observed while stepping through code
investogating BZ 56739)
Modified:
tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java
Modified:
tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java?rev=1616204&r1=1616203&r2=1616204&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java Wed
Aug 6 12:27:43 2014
@@ -898,7 +898,10 @@ public abstract class AbstractHttp11Proc
break;
}
case DISPATCH_EXECUTE: {
-getEndpoint().executeNonBlockingDispatches(socketWrapper);
+SocketWrapper wrapper = socketWrapper;
+if (wrapper != null) {
+getEndpoint().executeNonBlockingDispatches(wrapper);
+}
break;
}
case CLOSE_NOW: {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56756] VM argument javaagent is not working
https://issues.apache.org/bugzilla/show_bug.cgi?id=56756 --- Comment #3 from Mark Thomas --- Can you put together the simplest possible web application that demonstrates this and attach it to this issue please? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-nio2 : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2 -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build) Work ended in a state of : Failed Elapsed: 25 mins 29 secs Command Line: /usr/lib/jvm/java-7-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO2 -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140806-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/P20140317-1600/ecj-P20140317-1600.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20140806.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140806-native-src.tar.gz -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true -Dexecute.test.nio=false -Dexecute.test.apr=false -Dexecute.test.bio=false -Dexecute.test.nio2=t rue -Deasymock.jar=/srv/gump/public/workspace/easymock/easymock/target/easymock-3.3-SNAPSHOT.jar -Dhamcrest.jar=/srv/gump/public/workspace/hamcrest/hamcrest-java/build/hamcrest-core-20140806.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-7-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-jni.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu ild/lib/tomcat-spdy.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomca
