[Bug 57115] Parse application/x-www-form-urlencoded PATCH requests

2014-10-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57115

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Mark Thomas  ---
parseBodyMethods supports arbitrary method names.

Note that the Servlet spec does not require support for RFC 5789 and unless you
explicitly code your servlet to handle that method it will be rejected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 57115] Parse application/x-www-form-urlencoded PATCH requests

2014-10-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57115

Konstantinos Liakos  changed:

   What|Removed |Added

 CC||liakoskonstan...@gmail.com
 OS||All

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 57115] New: Parse application/x-www-form-urlencoded PATCH requests

2014-10-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57115

Bug ID: 57115
   Summary: Parse application/x-www-form-urlencoded PATCH requests
   Product: Tomcat 8
   Version: trunk
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: liakoskonstan...@gmail.com

Similar to this https://issues.apache.org/bugzilla/show_bug.cgi?id=48692 and
based on the discussion made there, PATCH requests with
application/x-www-form-urlencoded should be parsed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1632765 - in /tomcat/tc6.0.x/trunk: BUILDING.txt STATUS.txt webapps/docs/building.xml webapps/docs/changelog.xml

2014-10-18 Thread kkolinko
Author: kkolinko
Date: Sat Oct 18 11:38:14 2014
New Revision: 1632765

URL: http://svn.apache.org/r1632765
Log:
Update documented minimum Ant version to use at build time to be 1.8.0

Modified:
tomcat/tc6.0.x/trunk/BUILDING.txt
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/webapps/docs/building.xml
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/BUILDING.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/BUILDING.txt?rev=1632765&r1=1632764&r2=1632765&view=diff
==
--- tomcat/tc6.0.x/trunk/BUILDING.txt (original)
+++ tomcat/tc6.0.x/trunk/BUILDING.txt Sat Oct 18 11:38:14 2014
@@ -67,11 +67,11 @@ source distribution, do the following:
   into which you installed the JDK release.
 
 
-(1) Install Apache Ant 1.6.x on your computer
+(1) Install Apache Ant 1.8.x on your computer
 
-* If Apache Ant 1.6.x is already installed on your computer, skip to (2).
+* If Apache Ant 1.8.x is already installed on your computer, skip to (2).
 
-* Download a binary distribution of Ant 1.6.x from:
+* Download a binary distribution of Ant 1.8.x from:
 
 http://ant.apache.org/bindownload.cgi
 

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1632765&r1=1632764&r2=1632765&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Oct 18 11:38:14 2014
@@ -57,28 +57,6 @@ PATCHES PROPOSED TO BACKPORT:
   +1: kkolinko, markt
   -1:
 
-* Update documented minimum Ant version to use at build time to be 1.8.0
-
-  Motivation: Align documentation with code.
-
-  - Compatibility with Ant 1.6.5 was broken 6 years ago by r673614,
-as "osfamily" attribute of  task is since Ant 1.7.0.
-Running `ant -f dist.xml` with Ant 1.6.5 fails with
-.../dist.xml:403: The  type doesn't support the "osfamily" attribute.
-  
-  - Compatibility with Ant 1.7.x was broken 8 months ago by r1557724
-as  task supports arbitrary collections such as 
-since Ant 1.8.
-Running `ant -f dist.xml` with Ant 1.7.0, 1.7.1 fails with
-.../dist.xml:239: The following error occurred while executing this line:
-.../dist.xml:258: replace doesn't support the nested "restrict" element.
-
-  - Builds successfully with Ant 1.8.0.
-
-  https://people.apache.org/~kkolinko/patches/2014-09-22_tc6_Ant180.patch
-  +1: kkolinko, markt, remm
-  -1:
-
 * For https://issues.apache.org/bugzilla/show_bug.cgi?id=56079
   Switch to the signed versions of Apache Commons Daemon 1.0.15 binaries.
 

Modified: tomcat/tc6.0.x/trunk/webapps/docs/building.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/building.xml?rev=1632765&r1=1632764&r2=1632765&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/building.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/building.xml Sat Oct 18 11:38:14 2014
@@ -56,17 +56,17 @@ directory into which you installed the J
 
 
 
-
+
 
 
-Download a binary distribution of Ant 1.6.5 or later from 
+Download a binary distribution of Ant 1.8.0 or later from 
 http://ant.apache.org/bindownload.cgi";>here.
 
 
 
 Unpack the binary distribution into a convenient location so that the
 Ant release resides in its own directory (conventionally named
-"apache-ant-1.6.x").  For the purposes of the remainder of this document,
+"apache-ant-1.8.x").  For the purposes of the remainder of this document,
 the symbolic name "${ant.home}" is used to refer to the full pathname of
  the release directory.
 
@@ -180,7 +180,7 @@ Variables to add two new Classpath varia
 
 
  TOMCAT_LIBS_BASEthe base path where the binary dependencies 
have been downloaded
- ANT_HOMEthe base path of Ant 1.6.2 or later
+ ANT_HOMEthe base path of Ant 1.8.0 or later
 
 
 

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1632765&r1=1632764&r2=1632765&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Sat Oct 18 11:38:14 2014
@@ -58,6 +58,10 @@
 56988: Allow to use relative path in base.path
 setting when building Tomcat. (kkolinko)
   
+  
+Update documentation: the minimum version of Apache Ant required to
+build Tomcat is 1.8.0. (kkolinko)
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56988] Allow to use relative paths in base.path setting when building Tomcat, e.g. "base.path=../libraries"

2014-10-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56988

--- Comment #3 from Konstantin Kolinko  ---
Fixed in Tomcat 6 by r1632761 and will be in 6.0.43 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1632761 - in /tomcat/tc6.0.x/trunk: STATUS.txt build.xml extras.xml webapps/docs/changelog.xml

2014-10-18 Thread kkolinko
Author: kkolinko
Date: Sat Oct 18 11:24:58 2014
New Revision: 1632761

URL: http://svn.apache.org/r1632761
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56988
Allow to use relative path in base.path setting when building 
Tomcat.

Tested with Ant 1.8.0.

Motivation: Allow to simplify configuration of automated CI tools that may run 
in different environments, e.g. Buildbot.

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/build.xml
tomcat/tc6.0.x/trunk/extras.xml
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1632761&r1=1632760&r2=1632761&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sat Oct 18 11:24:58 2014
@@ -79,19 +79,6 @@ PATCHES PROPOSED TO BACKPORT:
   +1: kkolinko, markt, remm
   -1:
 
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56988
-  Allow to use relative path in base.path setting when
-  building Tomcat.
-
-  Tested with Ant 1.8.0.
-
-  Motivation: Allow to simplify configuration of automated CI tools that
-  may run in different environments, e.g. Buildbot.
-
-  https://issues.apache.org/bugzilla/attachment.cgi?id=32041
-  +1: kkolinko, markt, remm
-  -1:
-
 * For https://issues.apache.org/bugzilla/show_bug.cgi?id=56079
   Switch to the signed versions of Apache Commons Daemon 1.0.15 binaries.
 

Modified: tomcat/tc6.0.x/trunk/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/build.xml?rev=1632761&r1=1632760&r2=1632761&view=diff
==
--- tomcat/tc6.0.x/trunk/build.xml (original)
+++ tomcat/tc6.0.x/trunk/build.xml Sat Oct 18 11:24:58 2014
@@ -827,9 +827,7 @@
   
 
 
-
-  
-
+
 
 
 

Modified: tomcat/tc6.0.x/trunk/extras.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/extras.xml?rev=1632761&r1=1632760&r2=1632761&view=diff
==
--- tomcat/tc6.0.x/trunk/extras.xml (original)
+++ tomcat/tc6.0.x/trunk/extras.xml Sat Oct 18 11:24:58 2014
@@ -182,7 +182,7 @@
 
 
+ inheritAll="false" target="compile" />
 
 

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1632761&r1=1632760&r2=1632761&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Sat Oct 18 11:24:58 2014
@@ -52,6 +52,14 @@
   
 
   
+  
+
+  
+56988: Allow to use relative path in base.path
+setting when building Tomcat. (kkolinko)
+  
+
+  
 
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1632759 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2014-10-18 Thread kkolinko
Author: kkolinko
Date: Sat Oct 18 11:22:08 2014
New Revision: 1632759

URL: http://svn.apache.org/r1632759
Log:
Move changelog entry for the fix for BZ 57102. It will be in 6.0.43.

Modified:
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1632759&r1=1632758&r2=1632759&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Sat Oct 18 11:22:08 2014
@@ -43,7 +43,17 @@
 
-
+
+  
+
+  
+57102: Fix bug that meant sslEnabledProtocols setting was 
not
+recognised for the HTTPS NIO connector. (markt)
+  
+
+  
+
+
   
 
   
@@ -73,10 +83,6 @@
 56661:  Support using AJP request attribute
 AJP_LOCAL_ADDR to fix getLocalAddr(). (rjung)
   
-  
-57102: Fix bug that meant sslEnabledProtocols setting was 
not
-recognised for the HTTPS NIO connector. (markt)
-  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56844] Update to OpenSSL 1.0.1j

2014-10-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56844

--- Comment #3 from Konstantin Kolinko  ---
(In reply to Prasad from comment #2)
> Is there a simple way to build the DLL for Windows (32-bit and 64-bit)? I
> have seen the comments for building this in the bug ID 56596, but there
> doesn't seem to be a conclusive way of doing this.

Instructions are on the Wiki. That is how official Tomcat Native 1.1.31 release
was built.
http://wiki.apache.org/tomcat/BuildTcNativeWin

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 57113] New: ImportHandler not returning class properly from resolveClass()

2014-10-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57113

Bug ID: 57113
   Summary: ImportHandler not returning class properly from
resolveClass()
   Product: Tomcat 8
   Version: trunk
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: EL
  Assignee: dev@tomcat.apache.org
  Reporter: artfied...@gmail.com

Typically the importHandler.resolveClass(String) function is used something
like...
  result = ctx.getImportHandler().resolveClass("MyClass");
  if (result != null)
return result;

However the current functionality will fail (before classes are cached) if
MyClass is in package "com.test" and "org.apache" is imported after com.test
is... eg.

ctx.getImportHandler().importPackage("com.test");
ctx.getImportHandler().importPackage("org.apache");

Object result = ctx.getImportHandler().resolveClass("MyClass");

At this point result is null the first time ran through, because resolveClass
loops through all packages finding the className in each package before it
returns the temp variable its been using... which when it comes to
org.apache.MyClass it will be null, when com.test.MyClass was actually found...
but method returns null. 

I would think the expected result should be to return the first matching class.
To continue its current logic for multi match detection, it can be modified to
save the first match and return that variable... Like so.


public java.lang.Class resolveClass(String name) {
Class result = clazzes.get(name);

if (result == null) {
// Search the package imports - note there may be multiple matches
// (which correctly triggers an error)
for (String p : packages) {
String className = p + '.' + name;
Class tmpClass = findClass(className, true);
if (result == null && tmpClass != null) {
result = tmpClass;
} 
}
}

return result;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org