[Bug 60183] missing reason phrase in tomcat 8.5.x

2016-09-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60183

--- Comment #3 from Huxing Zhang  ---
Hi, if you read the source codes,  the reason is stated clearly: 

https://github.com/apache/tomcat/blob/fc6f2ead8463d06ae73954508927e4f2224c8e77/java/org/apache/coyote/http11/Http11OutputBuffer.java#L341


// The reason phrase is optional but the space before it is not. Skip
// sending the reason phrase. Clients should ignore it (RFC 7230) and it
// just wastes bytes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed

2016-09-28 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc7.0.x-test-apr has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 17 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-test-apr :  Tomcat 7.x, a web server implementing Java 
Servlet 3.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/test-tmp-APR/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-apr/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test-apr.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 25 mins 44 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-build-libs 
-Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x 
-Dtest.temp=output/test-tmp-APR 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.5-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160929.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar
 -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps 
-Dtest.excludePerformance=true 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcommons-dbcp.home=/srv/gump/public/workspace/commons-dbcp-1.x 
-Dexecute.test.apr=true -Dexec
 ute.test.bio=false 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160929-native-src.tar.gz
 -Dtest.reports=output/logs-APR 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160929-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-12/dest-20160929/lib 
-Dtest.relaxTiming=true -Dexecute.test.nio=false -Dtest.accesslog=true 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-20160929.jar
 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/t

Re: [VOTE] JK 1.2.42

2016-09-28 Thread Keiichi Fujino
2016-09-27 23:23 GMT+09:00 Mark Thomas :

> Tag:
> http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_42/
>
> Source:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/
>
> This is a maintenance release with a handful of bug fixes. It also
> includes Windows binaries for IIS.
>
> The proposed JK 1.2.42 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 1.2.42
>
>
>
Hi

MD5 seems to be .
SHA1 is also the same.



> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
> --
> Keiichi.Fujino
> 




[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2016-09-28 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 26 mins 24 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.5-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160929-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160929.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160929-native-src.
 tar.gz -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true 
-Dexecute.test.nio=true 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20160929/bin/openssl
 -Dexecute.test.apr=false -Dtest.excludePerformance=true 
-Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/outpu

[Tomcat Wiki] Update of "WikiSandBox" by JamesLampert

2016-09-28 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "WikiSandBox" page has been changed by JamesLampert:
https://wiki.apache.org/tomcat/WikiSandBox?action=diff&rev1=9&rev2=10

   blockquote
. deeper
  
- IBM_MidrangeSystem
+ 
  
  === Glossary ===
   Term:: Definition

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "WikiSandBox" by JamesLampert

2016-09-28 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "WikiSandBox" page has been changed by JamesLampert:
https://wiki.apache.org/tomcat/WikiSandBox?action=diff&rev1=8&rev2=9

   blockquote
. deeper
  
- CL_Program
+ IBM_MidrangeSystem
  
  === Glossary ===
   Term:: Definition

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "WikiSandBox" by JamesLampert

2016-09-28 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "WikiSandBox" page has been changed by JamesLampert:
https://wiki.apache.org/tomcat/WikiSandBox?action=diff&rev1=7&rev2=8

  Please feel free to experiment here, after the four dashes below... and 
please do '''NOT''' create new pages without any meaningful content just to try 
it out.
  
  '''Tip:''' Shift-click "HelpOnEditing" to open a second window with the help 
pages.
+ 
  
  
  == Formatting ==
- 
- ''italic'' '''bold''' {{{typewriter}}} 
+ ''italic'' '''bold''' {{{typewriter}}}
  
  `backtick typewriter` (configurable)
  
  {{{
  preformatted
  }}}
- 
  == Linking ==
- 
- HelpOnEditing MoinMoin:InterWiki 
+ HelpOnEditing MoinMoin:InterWiki
  
  http://purl.net/wiki/moin/ [[http://www.python.org/|Python]]
  
  some...@the.inter.net
  
- 
  === Image Link ===
  {{http://c2.com/sig/wiki.gif}}
  
  == Lists ==
- 
  === Bullet ===
   * first
-1. nested and numbered
+   1. nested and numbered
-1. numbered lists are renumbered
+   1. numbered lists are renumbered
   * second
-1. number
+   1. number
-  A. letter
+A. letter
  
   * third
-1.
+   1.
-2.
+   1.
   blockquote
-deeper
+   . deeper
+ 
- CLProgram
+ CL_Program
  
  === Glossary ===
   Term:: Definition
  
  === Drawing ===
- {{drawing:mytest}}
+ {{drawing:mytest.tdraw}}
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "WikiSandBox" by JamesLampert

2016-09-28 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "WikiSandBox" page has been changed by JamesLampert:
https://wiki.apache.org/tomcat/WikiSandBox?action=diff&rev1=6&rev2=7

 2.
   blockquote
 deeper
+ CLProgram
  
  === Glossary ===
   Term:: Definition

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1762713 - in /tomcat/tc7.0.x/trunk: ./ bin/catalina.bat webapps/docs/changelog.xml

2016-09-28 Thread schultz
Author: schultz
Date: Wed Sep 28 21:11:31 2016
New Revision: 1762713

URL: http://svn.apache.org/viewvc?rev=1762713&view=rev
Log:
Back-port r1762710 to add startup script documentation clarifying the (non) use 
of enviroment variables when Tomcat is launched as a Windows Service.
[DOC: CTR]


Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/bin/catalina.bat
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Sep 28 21:11:31 2016
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702
 
742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1
 
726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1759565,1761686,1762173,1762206
 
/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132,1740521,1740536,1740804,1740811,1740981,1741165,1741174,1741182,1741191,1741203,1741209,1741226,1741233,1741410,1742277,1743118,1743126,1743139-1743140,1743718,1743722,1743724,1744059,1744127,1744151,1744232,1744377,1744687,1744698,1744706,1745228,1746940,1748548,1748716,1749288,1749375,1749668-1749669,1750016,1750057,1750976,1751000,1751062,1751098,1754112,1754144,1754282,1754312,1754614,1754726,1754806,1754878,1754889,1754894,1754900,1754945,1754954,1754958,1755891,1755944,1756040,1756412,1756940,1757134,1757176,1757203,17

svn commit: r1762712 - in /tomcat/tc8.0.x/trunk: ./ bin/catalina.bat webapps/docs/changelog.xml

2016-09-28 Thread schultz
Author: schultz
Date: Wed Sep 28 21:09:25 2016
New Revision: 1762712

URL: http://svn.apache.org/viewvc?rev=1762712&view=rev
Log:
Back-port r1762710 to add startup script documentation clarifying the (non) use 
of enviroment variables when Tomcat is launched as a Windows Service.


Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/bin/catalina.bat
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Sep 28 21:09:25 2016
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 
7,1684549-1684550,1685556,1685591,1685739,1685744,1685772,1685816,1685826,1685891,1687242,1687261,1687268,1687340,1687544,1687551,1688563,1688841,1688878,165,1688896,1688901,1689345-1689346,1689357,1689656,1689675-1689677,1689679,168

Re: Introduce methods read/write with ByteBuffer in CoyoteInputStream/CoyoteOutputStream

2016-09-28 Thread Violeta Georgieva
Hi,

2016-09-22 22:21 GMT+03:00 Violeta Georgieva :
>
>
>
> 2016-09-22 18:29 GMT+03:00 Rémy Maucherat :
> >
> > 2016-09-22 17:13 GMT+02:00 Violeta Georgieva :
> >
> > > Hi,
> > >
> > > 2016-09-14 20:43 GMT+03:00 Rémy Maucherat :
> > > >
> > > > 2016-09-13 20:07 GMT+02:00 Violeta Georgieva :
> > > >
> > > > > I would like to back port these changes to Tomcat 8.5 if you do
not
> > > have
> > > > > any concerns.
> > > > >
> > > > > -0.1. I think this is ok, but not certain yet.
> > > > - Performance is ok for the "common" unencrypted scenario, but it
could
> > > go
> > > > down if using SSL, for example [= if the need for direct buffers
could be
> > > > hurting - if it is, then there's a problem since SSL will be used
almost
> > > > all the time moving forwards].
> > >
> > > I executed many combinations of performance scenarios - using direct
> > > ByteBuffer/non direct ByteBuffer,
> > > HTTP/HTTPS, sslImplementationName -
> > > org.apache.tomcat.util.net.jsse.JSSEImplementation/org.
> > > apache.tomcat.util.net.openssl.OpenSSLImplementation
> > > And results with/without my changes are the same.
> > > I'm testing with original Tomcat 9.0.0.M9 and Tomcat 9.0.0.M9 + only
my
> > > changes.
> > > I'm testing with blocking and non blocking.
> > >
> > > Just for testing purposes I changed
> > > org.apache.catalina.connector.OutputBuffer
> > > to use direct ByteBuffer and then executed SSL scenarios and again the
> > > results are the same.
> > > No visible performance improvement/degradation.
> > >
> > > Do you have some scenarios in mind in which a performance degradation
can
> > > be experienced.
> > > I can test them and take a deeper look.
> > >
> >
> > Ok, good, normally it's the best thing to test. If using OpenSSL, you
> > should see better performance with direct buffers though, so maybe
there's
> > something "wrong" with the testing. If you plan more ByteBuffer use,
then
> > go ahead and I'll test it.
>
> My idea was to introduce the changes step by step,
> because of this I wanted to backport the current changes to Tomcat 8.5
and receive a feedback.
> But if you propose to introduce all ByteBuffer related changes together,
I'm OK and can commit the next changes.
> I saw several places where switch to ByteBuffer can be done and I'm going
to finish and commit it.


I committed the changes that I planed. I executed several combinations of
tests (performance and regression).
There are neither issues nor performance degradation.

Do you see some risks with this change and performance scenario that should
be executed?

Thanks,
Violeta


> > >
> > >
> > > > - I didn't test again after the header processing refactoring (the
old
> > > code
> > > > was there for speed back then in early 2000s, most likely it
doesn't make
> > > > any difference now but it could be verified as well).
> > >
> > > I executed many tests and didn't see any problems.
> > >
> >
> > Yes, I had verified this one already :)
>
> I really appreciate your reviews and testing.
>
> Thanks,
> Violeta
>
>
> > Rémy


svn commit: r1762711 - in /tomcat/tc8.5.x/trunk: ./ bin/catalina.bat webapps/docs/changelog.xml

2016-09-28 Thread schultz
Author: schultz
Date: Wed Sep 28 21:08:16 2016
New Revision: 1762711

URL: http://svn.apache.org/viewvc?rev=1762711&view=rev
Log:
Back-port r1762710 to add startup script documentation clarifying the (non) use 
of enviroment variables when Tomcat is launched as a Windows Service.


Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/bin/catalina.bat
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Sep 28 21:08:16 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757853,1757903,1757997,1758072-1758075,1758078-1758079,1758292,1758369,1758423,1758425-1758427,1758430,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1760005,1760022,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762123,1762168,1762172,1762182,1762202,1762288,1762296,1762348,1762353,1762374,1762503,1762505,1762541,1762608
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,173

svn commit: r1762710 - in /tomcat/trunk: bin/catalina.bat webapps/docs/changelog.xml

2016-09-28 Thread schultz
Author: schultz
Date: Wed Sep 28 21:05:48 2016
New Revision: 1762710

URL: http://svn.apache.org/viewvc?rev=1762710&view=rev
Log:
Add startup script documentation clarifying the (non) use of enviroment 
variables when Tomcat is launched as a Windows Service.

Modified:
tomcat/trunk/bin/catalina.bat
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/bin/catalina.bat
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.bat?rev=1762710&r1=1762709&r2=1762710&view=diff
==
--- tomcat/trunk/bin/catalina.bat (original)
+++ tomcat/trunk/bin/catalina.bat Wed Sep 28 21:05:48 2016
@@ -22,6 +22,16 @@ rem
 rem   Do not set the variables in this script. Instead put them into a script
 rem   setenv.bat in CATALINA_BASE/bin to keep your customizations separate.
 rem
+rem   WHEN RUNNING TOMCAT AS A WINDOWS SERVICE:
+rem   Note that the environment variables that affect the behavior of this
+rem   script will have no effect at all on Windows Services. As such, any
+rem   local customizations made in a CATALINA_BASE/bin/setenv.bat script
+rem   will also have no effect on Tomcat when launched as a Windows Service.
+rem   The configuration that controls Windows Services is stored in the Windows
+rem   Registry, and is most conveniently maintained using the "tomcatXw.exe"
+rem   maintenance utility, where "X" is the major version of Tomcat you are
+rem   running.
+rem
 rem   CATALINA_HOME   May point at your Catalina "build" directory.
 rem
 rem   CATALINA_BASE   (Optional) Base directory for resolving dynamic portions

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1762710&r1=1762709&r2=1762710&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Sep 28 21:05:48 2016
@@ -174,6 +174,12 @@
 log4j-web*.jar since it is log4j-web*.jar 
that
 contains the ServletContainerInitializer. (markt)
   
+  
+Add documentation to the bin/catalina.bat script to remind users that
+environment variables don't affect the configuration of Tomcat when
+run as a Windows Service. Based upon a documentation patch by
+James H.H. Lampert. (schultz)
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of "ContributorsGroup" by ChristopherSchultz

2016-09-28 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change 
notification.

The "ContributorsGroup" page has been changed by ChristopherSchultz:
https://wiki.apache.org/tomcat/ContributorsGroup?action=diff&rev1=29&rev2=30

   * GregTrasuk
   * HartmutBecker
   * jboynes
+  * JamesLampert
   * JonLucas
   * [[Krzysztof Gil]]
   * LucaVisconti

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 57767] Websocket client proprietary configuration

2016-09-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767

--- Comment #5 from MikeLing  ---
(In reply to Mark Thomas from comment #4)
> I'd suggest supporting 302 responses as a starting point. The code should
> handle both absolute and relative redirects.
> 
> There is a ready made test case here:
> http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/websocket/
> TestWebSocketFrameClient.java?view=annotate#l100
> if you restore the commented out request.
> 
> The starting point for the client code is here:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/
> WsWebSocketContainer.java?view=annotate#l341

Sorry for the late reply. So, how do I know the Websocket client can handle
redirections as expected after I make some changes? It's my first bug in
Tomcat, so please tell me what should I do or where should I look into?  Thank
you very much! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1762638 - /tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java

2016-09-28 Thread markt
Author: markt
Date: Wed Sep 28 12:44:04 2016
New Revision: 1762638

URL: http://svn.apache.org/viewvc?rev=1762638&view=rev
Log:
Add some Javadoc
Reduce whitespace
Use longer lines where possible

Modified:
tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java

Modified: tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java?rev=1762638&r1=1762637&r2=1762638&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java (original)
+++ tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java Wed Sep 28 
12:44:04 2016
@@ -14,7 +14,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 package org.apache.catalina.util;
 
 import java.util.List;
@@ -30,7 +29,6 @@ import org.apache.juli.logging.LogFactor
 import org.apache.tomcat.util.ExceptionUtils;
 import org.apache.tomcat.util.res.StringManager;
 
-
 /**
  * Base implementation of the {@link Lifecycle} interface that implements the
  * state transition rules for {@link Lifecycle#start()} and
@@ -109,14 +107,20 @@ public abstract class LifecycleBase impl
 } catch (Throwable t) {
 ExceptionUtils.handleThrowable(t);
 setStateInternal(LifecycleState.FAILED, null, false);
-throw new LifecycleException(
-sm.getString("lifecycleBase.initFail",toString()), t);
+throw new 
LifecycleException(sm.getString("lifecycleBase.initFail",toString()), t);
 }
 }
 
 
+/**
+ * Sub-classes implement this method to perform any instance initialisation
+ * required.
+ *
+ * @throws LifecycleException If the initialisation fails
+ */
 protected abstract void initInternal() throws LifecycleException;
 
+
 /**
  * {@inheritDoc}
  */
@@ -269,9 +273,7 @@ public abstract class LifecycleBase impl
 }
 }
 
-if (LifecycleState.DESTROYING.equals(state) ||
-LifecycleState.DESTROYED.equals(state)) {
-
+if (LifecycleState.DESTROYING.equals(state) || 
LifecycleState.DESTROYED.equals(state)) {
 if (log.isDebugEnabled()) {
 Exception e = new LifecycleException();
 log.debug(sm.getString("lifecycleBase.alreadyDestroyed", 
toString()), e);
@@ -285,10 +287,8 @@ public abstract class LifecycleBase impl
 return;
 }
 
-if (!state.equals(LifecycleState.STOPPED) &&
-!state.equals(LifecycleState.FAILED) &&
-!state.equals(LifecycleState.NEW) &&
-!state.equals(LifecycleState.INITIALIZED)) {
+if (!state.equals(LifecycleState.STOPPED) && 
!state.equals(LifecycleState.FAILED) &&
+!state.equals(LifecycleState.NEW) && 
!state.equals(LifecycleState.INITIALIZED)) {
 invalidTransition(Lifecycle.BEFORE_DESTROY_EVENT);
 }
 
@@ -299,14 +299,20 @@ public abstract class LifecycleBase impl
 } catch (Throwable t) {
 ExceptionUtils.handleThrowable(t);
 setStateInternal(LifecycleState.FAILED, null, false);
-throw new LifecycleException(
-sm.getString("lifecycleBase.destroyFail",toString()), t);
+throw new 
LifecycleException(sm.getString("lifecycleBase.destroyFail",toString()), t);
 }
 }
 
 
+/**
+ * Sub-classes implement this method to perform any instance destruction
+ * required.
+ *
+ * @throws LifecycleException If the destruction fails
+ */
 protected abstract void destroyInternal() throws LifecycleException;
 
+
 /**
  * {@inheritDoc}
  */
@@ -334,8 +340,7 @@ public abstract class LifecycleBase impl
  * @param state The new state for this component
  * @throws LifecycleException when attempting to set an invalid state
  */
-protected synchronized void setState(LifecycleState state)
-throws LifecycleException {
+protected synchronized void setState(LifecycleState state) throws 
LifecycleException {
 setStateInternal(state, null, true);
 }
 
@@ -355,8 +360,9 @@ public abstract class LifecycleBase impl
 setStateInternal(state, data, true);
 }
 
-private synchronized void setStateInternal(LifecycleState state,
-Object data, boolean check) throws LifecycleException {
+
+private synchronized void setStateInternal(LifecycleState state, Object 
data, boolean check)
+throws LifecycleException {
 
 if (log.isDebugEnabled()) {
 log.debug(sm.getString("lifecycleBase.setState", this, state));
@@ -396,9 +402,9 @@ public abstract class LifecycleBase impl
 }
 }
 
+
 private void invalidTransition(String type) throws LifecycleException {
-String msg = sm.getString("lifecyc

[Bug 60173] tomcat 8 fails with non standard HPACK receiver size

2016-09-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60173

--- Comment #9 from patrick mcmanus  ---
(In reply to Remy Maucherat from comment #8)
> (In reply to patrick mcmanus from comment #6)
> > can I ask what happens if a client advertises >64KB? I'm assuming tomcat
> > just uses 64 and ignores the rest but wanted to ask.
> 
> 64*1024 is the new size limit.

can I ask what happens if a client advertises >64KB?

does the connection fail? Afterall the client cannot know what your limit is.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60152] Allow exceptions from Connector.start() to be caught and handled in code that embeds Tomcat

2016-09-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60152

--- Comment #7 from Mark Thomas  ---
The current behaviour derives to bug 49030 and r752323.

I'm still looking at options for implementing this but it does look like it is
going to involve some form of new configuration option.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] tomcat issue #34: fixed retrieval org.apache.catalina.startup.EXIT_ON_INIT_F...

2016-09-28 Thread alostale
Github user alostale commented on the issue:

https://github.com/apache/tomcat/pull/34
  
Sorry, I misread the docs :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] tomcat pull request #34: fixed retrieval org.apache.catalina.startup.EXIT_ON...

2016-09-28 Thread alostale
Github user alostale closed the pull request at:

https://github.com/apache/tomcat/pull/34


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] tomcat issue #34: fixed retrieval org.apache.catalina.startup.EXIT_ON_INIT_F...

2016-09-28 Thread SvetlinZarev
Github user SvetlinZarev commented on the issue:

https://github.com/apache/tomcat/pull/34
  
Nope, Boolean.getBoolean("xxx") tries to convert the value of the system 
property "xxx" to a boolean or returns false if it's missing. The method name 
is indeed very misleading, but works as expected.


http://docs.oracle.com/javase/7/docs/api/java/lang/Boolean.html#getBoolean(java.lang.String)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] tomcat pull request #34: fixed retrieval org.apache.catalina.startup.EXIT_ON...

2016-09-28 Thread alostale
GitHub user alostale opened a pull request:

https://github.com/apache/tomcat/pull/34

fixed retrieval org.apache.catalina.startup.EXIT_ON_INIT_FAILURE

  This property was incorrectly tried to be retrieved: it converted the
  proprety name directly into boolean instead of its value from System
  properties.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alostale/tomcat trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #34


commit 22a86bd59f3e37d3e079361be1ed2deef857933a
Author: Asier Lostalé 
Date:   2016-09-28T11:10:36Z

fixed retrieval org.apache.catalina.startup.EXIT_ON_INIT_FAILURE

  This property was incorrectly tried to be retrieved: it converted the
  proprety name directly into boolean instead of its value from System
  properties.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60183] missing reason phrase in tomcat 8.5.x

2016-09-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60183

--- Comment #2 from Arul  ---
Reason Phrase was provided till 8.0.37. Not sure why this is intentionally
removed from 8.5.x.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60183] missing reason phrase in tomcat 8.5.x

2016-09-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60183

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID
 OS||All

--- Comment #1 from Mark Thomas  ---
As per the current HTTP/1.1 specification, the reason phrase is optional and
Tomcat does not provide it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60183] New: missing reason phrase in tomcat 8.5.x

2016-09-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60183

Bug ID: 60183
   Summary: missing reason phrase in tomcat 8.5.x
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: arulpra...@gmail.com

In apache-tomcat-8.0.36

Request URL:http://localhost:8080/
Request Method:GET
Status Code:200 OK
Remote Address:[::1]:8080

In apache-tomcat-8.5.5

Request URL:http://localhost:8080/
Request Method:GET
Status Code:200 
Remote Address:[::1]:8080


>From 8.5.x onwards we miss reason phrase(OK). we just get the status code (200)
alone.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60173] tomcat 8 fails with non standard HPACK receiver size

2016-09-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60173

--- Comment #8 from Remy Maucherat  ---
(In reply to patrick mcmanus from comment #6)
> can I ask what happens if a client advertises >64KB? I'm assuming tomcat
> just uses 64 and ignores the rest but wanted to ask.

64*1024 is the new size limit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org