[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2016-12-22 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-apr has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 20 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-apr :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-apr/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-apr.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 21 mins 55 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dexecute.test.nio2=false -Dtest.temp=output/test-tmp-APR 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-8.0.x/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.5-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20161223.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20161223/bin/openssl
 -Dexecute.test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dexecute.test.apr=true -Dexecute.test.bio=false 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commo
 ns-daemon-20161223-native-src.tar.gz -Dtest.reports=output/logs-APR 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20161223-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-12/dest-20161223/lib 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true -Dtest.accesslog=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja

[Bug 60511] org.apache.coyote.ajp.AjpNio2Protocol sends wrong data to Apache MOD_JK connector causing connection closure and multiple reconnects

2016-12-22 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60511

--- Comment #4 from Areg Vrtanesyan  ---
Not sure if I can do it on my side. 
I will work with Atlassian to see if they can do that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60511] org.apache.coyote.ajp.AjpNio2Protocol sends wrong data to Apache MOD_JK connector causing connection closure and multiple reconnects

2016-12-22 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60511

--- Comment #3 from Rainer Jung  ---
Just in case this is not clear: it seems sometimes the request is immediately
answered with an AJP packet with signature "05", which is an "End Response"
packet. No response headers, just "End Response".

Of course it could be, that the request was invalid and the connector
immediately closed the connection.

Looking at the AJP connector code, the endAndCloseMessageArray was sent in
finish() and getErrorState().isError() was true.

I'd agree, that it would be helpful to reproduce the problem with a current
version and to try to provide a self-contained reproduction example. From your
full log it seems that sometimes correct responses come back, so we need to
understand what properties the failing requests distinguish from the good ones.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60511] org.apache.coyote.ajp.AjpNio2Protocol sends wrong data to Apache MOD_JK connector causing connection closure and multiple reconnects

2016-12-22 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60511

Areg Vrtanesyan  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #2 from Areg Vrtanesyan  ---
(In reply to Remy Maucherat from comment #1)
> Ok, the client reports an issue, but it is impossible to look into it with
> only this. It is unlikely anyone will look at that issue in the Tomcat 8.0
> branch, as ongoing support is expected to move to 8.5.

Hi Remy

Are you suggesting that Atlassian should have a look to uplift Tomcat version
in use?

>From another point of view could this bug be present in latest 8.5 version too?

What I can do to help? 

I was suggested to use NIO2 connector and results was quite not pleasant. 

Regards, 
Areg

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60513] New: RMI leak cleaning is not thread safe

2016-12-22 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60513

Bug ID: 60513
   Summary: RMI leak cleaning is not thread safe
   Product: Tomcat 8
   Version: 8.0.30
  Hardware: PC
OS: Mac OS X 10.1
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: ma...@apache.org
  Target Milestone: 

As reported via users list.
https://lists.apache.org/thread.html/7b6c57b1838f180019bdd2bf8bf673b3b2365fe74f0e035b3b20cf8c@%3Cusers.tomcat.apache.org%3E

With multiple start/stop threads, concurrent calls are possible to the RMI leak
cleaning which is not thread safe.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JASPIC Specification info missing from a few places

2016-12-22 Thread Mark Thomas 
On 21/12/2016 21:51, Coty Sutherland wrote:
>> Is there a space there? I'm assuming not since none of the others have
>> one. If it does, we'll need to figure out how to handle that.
> 
> That was my fault; I fixed it and am able to edit.
> 
>> You should be able to add components now.
> 
> I just updated the description. Should I also add a component for
> JASPIC, or just leave it lumped together in the 'Specification APIs'
> component? There isn't a component for JSP and Servlet, but there are
> ones for WebSocket and EL, so I'm not sure what the convention is.

I'm not sure there is a convention. It is more what feels right at the
time. If we had a convention I'd say map Bugzilla components to the
section headings we use in the changelog but even with that I suspect
there are significant differences.

I have no strong view on whether we need a JASPIC component or not. If
you would find it useful, feel free to add it. If not, we can use the
existing components.

Mark

> 
> On Wed, Dec 21, 2016 at 3:59 PM, Mark Thomas  wrote:
>> On 21/12/2016 20:15, Coty Sutherland wrote:
 Yes. We need you MoinMoin ID for the Tomcat wiki.
>>>
>>> Ah. OK, I created an account for the wiki (I didn't see the sign up
>>> link before). It's "Coty Sutherland", if you need that.
>>
>> Is there a space there? I'm assuming not since none of the others have
>> one. If it does, we'll need to figure out how to handle that.
>>
 BZ account name? I'll add you as an admin
>>>
>>> Awesome, thanks. It's `csuth...@redhat.com`.
>>
>> You should be able to add components now.
>>
>> Mark
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat can report that a request-processing thread was started by an application?

2016-12-22 Thread Rémy Maucherat 
2016-12-22 15:31 GMT+01:00 Christopher Schultz :

> All,
>
> I was browsing the Tomcat-related questions on SO and I noticed this one:
>
> http://stackoverflow.com/questions/41223141/threads-in-tomcat-memory-leaks
>
> The poster shows a snip of his error log which says this:
>
> дек 19, 2016 12:25:10 AM
> org.apache.catalina.loader.WebappClassLoaderBase clearReferencesThreads
> SEVERE: The web application [/someContext] appears to have started a
> thread named [http-apr-8081-exec-10] but has failed to stop it. This is
> very likely to create a memory leak.
>
> That seems like an incorrect -- and very confusing -- error message.
>
> The use-case was undeploying an application while a request was being
> handled (your basic Thread.sleep() to hold a request in-flight in order
> to undeploy during that time). This was with Tomcat 7 (no specific
> version number).
>
> It also seems like in that case, Tomcat may forcibly-change the TCCL of
> the in-flight request-processing thread, bus it's not quite clear to me
> precisely what's going on.
>
> It's mostly as expected. The servlet unloading waits for an unload delay
(2s) then moves on. The thread is then flagged as a possible leak, which is
true. The odd thing is that there's code to identify a request thread, and
it's not reported as one (the code looks like it will work, so I don't
understand). Maybe this check was not present in the version that is being
used.

Rémy

Tomcat can report that a request-processing thread was started by an application?

2016-12-22 Thread Christopher Schultz 
All,

I was browsing the Tomcat-related questions on SO and I noticed this one:

http://stackoverflow.com/questions/41223141/threads-in-tomcat-memory-leaks

The poster shows a snip of his error log which says this:

дек 19, 2016 12:25:10 AM
org.apache.catalina.loader.WebappClassLoaderBase clearReferencesThreads
SEVERE: The web application [/someContext] appears to have started a
thread named [http-apr-8081-exec-10] but has failed to stop it. This is
very likely to create a memory leak.

That seems like an incorrect -- and very confusing -- error message.

The use-case was undeploying an application while a request was being
handled (your basic Thread.sleep() to hold a request in-flight in order
to undeploy during that time). This was with Tomcat 7 (no specific
version number).

It also seems like in that case, Tomcat may forcibly-change the TCCL of
the in-flight request-processing thread, bus it's not quite clear to me
precisely what's going on.

-chris



signature.asc
Description: OpenPGP digital signature

[Bug 60511] org.apache.coyote.ajp.AjpNio2Protocol sends wrong data to Apache MOD_JK connector causing connection closure and multiple reconnects

2016-12-22 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60511

Remy Maucherat  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from Remy Maucherat  ---
Ok, the client reports an issue, but it is impossible to look into it with only
this. It is unlikely anyone will look at that issue in the Tomcat 8.0 branch,
as ongoing support is expected to move to 8.5.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1775649 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2016-12-22 Thread Coty Sutherland 
> I believe the committer names are sorted by family name...
> So probably you should not place yourself at last.

Yep, fixed.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1775658 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2016-12-22 Thread csutherl 
Author: csutherl
Date: Thu Dec 22 13:59:23 2016
New Revision: 1775658

URL: http://svn.apache.org/viewvc?rev=1775658=rev
Log:
Putting my name in the correct order...

Modified:
tomcat/site/trunk/docs/whoweare.html
tomcat/site/trunk/xdocs/whoweare.xml

Modified: tomcat/site/trunk/docs/whoweare.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whoweare.html?rev=1775658=1775657=1775658=diff
==
--- tomcat/site/trunk/docs/whoweare.html (original)
+++ tomcat/site/trunk/docs/whoweare.html Thu Dec 22 13:59:23 2016
@@ -409,6 +409,12 @@ A complete list of all the Apache Commit
 
 
 
+Coty Sutherland (csutherl at apache.org)
+
+
+
+
+
 Eiji Takahashi (eijit at apache.org)
 
 
@@ -443,12 +449,6 @@ A complete list of all the Apache Commit
 
 
 
-
-
-Coty Sutherland (csutherl at apache.org)
-
-
-
 
 Emeritus PMC members
 

Modified: tomcat/site/trunk/xdocs/whoweare.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whoweare.xml?rev=1775658=1775657=1775658=diff
==
--- tomcat/site/trunk/xdocs/whoweare.xml (original)
+++ tomcat/site/trunk/xdocs/whoweare.xml Thu Dec 22 13:59:23 2016
@@ -121,6 +121,9 @@ A complete list of all the Apache Commit
 Felix Schumacher (fschumacher at apache.org)
 
 
+Coty Sutherland (csutherl at apache.org)
+
+
 Eiji Takahashi (eijit at apache.org)
 
 
@@ -138,9 +141,6 @@ A complete list of all the Apache Commit
 
 Huxing Zhang (huxing at apache.org)
 
-
-Coty Sutherland (csutherl at apache.org)
-
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60511] org.apache.coyote.ajp.AjpNio2Protocol sends wrong data to Apache MOD_JK connector causing connection closure and multiple reconnects

2016-12-22 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60511

Areg Vrtanesyan  changed:

   What|Removed |Added

 CC||areg.vrtanes...@arm.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60511] New: org.apache.coyote.ajp.AjpNio2Protocol sends wrong data to Apache MOD_JK connector causing connection closure and multiple reconnects

2016-12-22 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60511

Bug ID: 60511
   Summary: org.apache.coyote.ajp.AjpNio2Protocol sends wrong data
to Apache MOD_JK connector causing connection closure
and multiple reconnects
   Product: Tomcat 8
   Version: 8.0.38
  Hardware: PC
OS: Linux
Status: NEW
  Severity: major
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: areg.vrtanes...@arm.com
  Target Milestone: 

Created attachment 34548
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34548=edit
sanitised mod_jk debug log

Hi Team

I have been working with Atlassian and in Jira we discovered that
"org.apache.coyote.ajp.AjpNio2Protocol" in Tomcat causing troubles.

---
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
map_uri_to_worker_ext::jk_uri_worker_map.c (1185): Attempting to map URI
'sanitised_url' from 4 maps
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
find_match::jk_uri_worker_map.c (980): Attempting to map context URI
'/*=jira-pro0-lb' source 'JkMount'
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
find_match::jk_uri_worker_map.c (993): Found a wildchar match '/*=jira-pro0-lb'
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
jk_handler::mod_jk.c (2823): Into handler jakarta-servlet worker=jira-pro0-lb
r->proxyreq=0
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
wc_get_worker_for_name::jk_worker.c (120): found a worker jira-pro0-lb
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
wc_get_name_for_type::jk_worker.c (304): Found worker type 'lb'
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
init_ws_service::mod_jk.c (1196): Service protocol=HTTP/1.1 method=GET ssl=true
host=(null) addr=nn.nn.nn.nn name=jira.company.com port=443 auth=(null)
user=(null) laddr=nn.n.nnn.nn raddr=nn.nn.nn.nn uaddr=nn.nn.nn.nn
uri=sanitised_url
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
service::jk_lb_worker.c (1270): service sticky_session=1
id='7B8F781E9D9786ABFD7408CFC8E82667.jira-pro0-node2'
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
get_most_suitable_worker::jk_lb_worker.c (1078): searching worker for partial
sessionid 7B8F781E9D9786ABFD7408CFC8E82667.jira-pro0-node2
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
get_most_suitable_worker::jk_lb_worker.c (1086): searching worker for session
route jira-pro0-node2
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
get_most_suitable_worker::jk_lb_worker.c (1101): found worker jira-pro0-n2
(jira-pro0-node2) for route jira-pro0-node2 and partial sessionid
7B8F781E9D9786ABFD7408CFC8E82667.jira-pro0-node2
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
service::jk_lb_worker.c (1315): service worker=jira-pro0-n2
route=jira-pro0-node2 failover=false
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
ajp_get_endpoint::jk_ajp_common.c (3356): (jira-pro0-n2) acquired connection
pool slot=0 after 0 retries
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
ajp_marshal_into_msgb::jk_ajp_common.c (684): (jira-pro0-n2) ajp marshaling
done
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
ajp_service::jk_ajp_common.c (2591): processing jira-pro0-n2 with 2 retries
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
jk_shutdown_socket::jk_connect.c (932): About to shutdown socket 38
[nn.n.nnn.nn:47243 -> nn.n.nnn.nn:8600]
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
jk_is_input_event::jk_connect.c (1411): error event during poll on socket 38
[nn.n.nnn.nn:47243 -> nn.n.nnn.nn:8600] (event=16)
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
jk_shutdown_socket::jk_connect.c (1016): Shutdown socket 38 [nn.n.nnn.nn:47243
-> nn.n.nnn.nn:8600] and read 0 lingering bytes in 0 sec.
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
ajp_send_request::jk_ajp_common.c (1639): (jira-pro0-n2) failed sending
request, socket 38 is not connected any more (errno=0)
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
ajp_abort_endpoint::jk_ajp_common.c (821): (jira-pro0-n2) aborting endpoint
with socket 38
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
ajp_send_request::jk_ajp_common.c (1717): (jira-pro0-n2) no usable connection
found, will create a new one, detected by connect check (1), cping (0), send
(0).
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
jk_open_socket::jk_connect.c (675): socket TCP_NODELAY set to On
[Wed Dec 21 15:38:05.939 2016] [22617:140683748223040] [debug]
jk_open_socket::jk_connect.c (799): trying to connect socket 38 to
nn.n.nnn.nn:8600
[Wed Dec 21 15:38:05.940 2016] [22617:140683748223040] [debug]

Re: svn commit: r1775649 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2016-12-22 Thread Huxing Zhang 
Hi，

I believe the committer names are sorted by family name...
So probably you should not place yourself at last.

--
From:csutherl 
Time:2016 Dec 22 (Thu) 21:19
To:dev 
Subject:svn commit: r1775649 - in /tomcat/site/trunk: docs/whoweare.html 
xdocs/whoweare.xml


Author: csutherl
Date: Thu Dec 22 13:19:34 2016
New Revision: 1775649

URL: http://svn.apache.org/viewvc?rev=1775649=rev
Log:
Adding myself to the whoarewe page

Modified:
tomcat/site/trunk/docs/whoweare.html
tomcat/site/trunk/xdocs/whoweare.xml

Modified: tomcat/site/trunk/docs/whoweare.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whoweare.html?rev=1775649=1775648=1775649=diff
==
--- tomcat/site/trunk/docs/whoweare.html (original)
+++ tomcat/site/trunk/docs/whoweare.html Thu Dec 22 13:19:34 2016
@@ -443,6 +443,12 @@ A complete list of all the Apache Commit
 
 
 
+
+
+Coty Sutherland (csutherl at apache.org)
+
+
+
 
 Emeritus PMC members
 

Modified: tomcat/site/trunk/xdocs/whoweare.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whoweare.xml?rev=1775649=1775648=1775649=diff
==
--- tomcat/site/trunk/xdocs/whoweare.xml (original)
+++ tomcat/site/trunk/xdocs/whoweare.xml Thu Dec 22 13:19:34 2016
@@ -138,6 +138,9 @@ A complete list of all the Apache Commit
 
 Huxing Zhang (huxing at apache.org)
 
+
+Coty Sutherland (csutherl at apache.org)
+
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1775523 - /tomcat/site/trunk/docs/whichversion.html

2016-12-22 Thread Coty Sutherland 
> 1). *.html are generated files. Do not edit them manually!

Got it, sorry. Fixed! Thanks for catching that.

> 2). Please add yourself to the following page:

Done.



Cheers,
-Coty

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1775652 - in /tomcat/site/trunk: docs/whichversion.html xdocs/whichversion.xml

2016-12-22 Thread csutherl 
Author: csutherl
Date: Thu Dec 22 13:37:26 2016
New Revision: 1775652

URL: http://svn.apache.org/viewvc?rev=1775652=rev
Log:
XML update to accompany my html modifications in r1775523 and r1775535

Modified:
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/docs/whichversion.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1775652=1775651=1775652=diff
==
--- tomcat/site/trunk/docs/whichversion.html (original)
+++ tomcat/site/trunk/docs/whichversion.html Thu Dec 22 13:37:26 2016
@@ -450,8 +450,8 @@ run stably for extended periods of time.
 builds on Tomcat 8.0.x and implements the current draft of the Servlet
 4.0 specification and will also implement the
 JSP 2.4?, EL 3.1?, WebSocket 1.2?
- and JASPIC 1.1  specifications once work starts on 
-updating those specifications for Java EE 8. In addition to this, it includes 
+ and JASPIC 1.1  specifications once work starts on
+updating those specifications for Java EE 8. In addition to this, it includes
 the following significant improvements:
 
 

Modified: tomcat/site/trunk/xdocs/whichversion.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whichversion.xml?rev=1775652=1775651=1775652=diff
==
--- tomcat/site/trunk/xdocs/whichversion.xml (original)
+++ tomcat/site/trunk/xdocs/whichversion.xml Thu Dec 22 13:37:26 2016
@@ -194,10 +194,10 @@ run stably for extended periods of time.
 Apache Tomcat 9.x is the current focus of development, it
 builds on Tomcat 8.0.x and implements the current draft of the Servlet
 4.0 specification and will also implement the
-JSP 2.4?, EL 3.1? and
-WebSocket 1.2? specifications once work starts on updating
-those specifications for Java EE 8. In addition to this, it includes the
-following significant improvements:
+JSP 2.4?, EL 3.1?, WebSocket 1.2?
+ and JASPIC 1.1  specifications once work starts on
+updating those specifications for Java EE 8. In addition to this, it includes
+the following significant improvements:
 
 
 Adds support for HTTP/2 (requires the APR/native library)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1775651 - /tomcat/site/trunk/xdocs/whichversion.xml

2016-12-22 Thread csutherl 
Author: csutherl
Date: Thu Dec 22 13:34:36 2016
New Revision: 1775651

URL: http://svn.apache.org/viewvc?rev=1775651=rev
Log:
XML update to accompany my html modifications in r1775524

Modified:
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/xdocs/whichversion.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whichversion.xml?rev=1775651=1775650=1775651=diff
==
--- tomcat/site/trunk/xdocs/whichversion.xml (original)
+++ tomcat/site/trunk/xdocs/whichversion.xml Thu Dec 22 13:34:36 2016
@@ -195,7 +195,7 @@ run stably for extended periods of time.
 builds on Tomcat 8.0.x and implements the current draft of the Servlet
 4.0 specification and will also implement the
 JSP 2.4?, EL 3.1? and
-Web Socket 1.2? specifications once work starts on updating
+WebSocket 1.2? specifications once work starts on updating
 those specifications for Java EE 8. In addition to this, it includes the
 following significant improvements:
 
@@ -211,7 +211,7 @@ following significant improvements:
 
 Apache Tomcat 8.x builds on Tomcat 7.0.x and implements the
 Servlet 3.1, JSP 2.3, EL 3.0
-and Web Socket 1.1 specifications. In addition
+and WebSocket 1.1 specifications. In addition
 to that, it includes the following significant improvements:
 
 
@@ -236,7 +236,7 @@ Apache Tomcat 8.5 Changelog for details.
 Apache Tomcat 7.x builds upon the improvements made in
 Tomcat 6.0.x and implements the Servlet 3.0,
 JSP 2.2, EL 2.2 and
-Web Socket 1.1 specifications. In addition
+WebSocket 1.1 specifications. In addition
 to that, it includes the following improvements:
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1775650 - in /tomcat/site/trunk: docs/whichversion.html xdocs/whichversion.xml

2016-12-22 Thread csutherl 
Author: csutherl
Date: Thu Dec 22 13:32:41 2016
New Revision: 1775650

URL: http://svn.apache.org/viewvc?rev=1775650=rev
Log:
XML update to accompany my html modifications in r1775522

Modified:
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/docs/whichversion.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1775650=1775649=1775650=diff
==
--- tomcat/site/trunk/docs/whichversion.html (original)
+++ tomcat/site/trunk/docs/whichversion.html Thu Dec 22 13:32:41 2016
@@ -486,15 +486,18 @@ to that, it includes the following signi
 
 
 
+
 
+
 Apache Tomcat 8.5.x supports the same Servlet, JSP, EL, and
-WebSocket Specification versions as Apache Tomcat 8.0.x. In addition to that, 
-it also implements the JASPIC 1.1 specification. There are 
-significant changes in many areas under the hood, resulting in improved 
-performance, stability, and total cost of ownership.  Please refer to the 
+WebSocket Specification versions as Apache Tomcat 8.0.x. In addition to that,
+it also implements the JASPIC 1.1 specification. There are
+significant changes in many areas under the hood, resulting in improved
+performance, stability, and total cost of ownership.  Please refer to the
 Apache Tomcat 8.5 Changelog for details.
 
 
+
 
 Apache Tomcat 7.x
 

Modified: tomcat/site/trunk/xdocs/whichversion.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whichversion.xml?rev=1775650=1775649=1775650=diff
==
--- tomcat/site/trunk/xdocs/whichversion.xml (original)
+++ tomcat/site/trunk/xdocs/whichversion.xml Thu Dec 22 13:32:41 2016
@@ -219,6 +219,15 @@ to that, it includes the following signi
 extension features provided in earlier versions.
 
 
+
+Apache Tomcat 8.5.x supports the same Servlet, JSP, EL, and
+WebSocket Specification versions as Apache Tomcat 8.0.x. In addition to that,
+it also implements the JASPIC 1.1 specification. There are
+significant changes in many areas under the hood, resulting in improved
+performance, stability, and total cost of ownership.  Please refer to the
+Apache Tomcat 8.5 Changelog for details.
+
+
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60497] JSP custom tags returned to the tag pools to be reused without executing the doEndTag method

2016-12-22 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60497

Remy Maucherat  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #9 from Remy Maucherat  ---
I applied the patch and it will be included in 9M16, 8.5.10, 8.0.40, 7.0.74 and
6.0.49. It is possible the new behavior gets reintroduced in 8.5 and 9 after it
is reviewed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1775649 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2016-12-22 Thread csutherl 
Author: csutherl
Date: Thu Dec 22 13:19:34 2016
New Revision: 1775649

URL: http://svn.apache.org/viewvc?rev=1775649=rev
Log:
Adding myself to the whoarewe page

Modified:
tomcat/site/trunk/docs/whoweare.html
tomcat/site/trunk/xdocs/whoweare.xml

Modified: tomcat/site/trunk/docs/whoweare.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whoweare.html?rev=1775649=1775648=1775649=diff
==
--- tomcat/site/trunk/docs/whoweare.html (original)
+++ tomcat/site/trunk/docs/whoweare.html Thu Dec 22 13:19:34 2016
@@ -443,6 +443,12 @@ A complete list of all the Apache Commit
 
 
 
+
+
+Coty Sutherland (csutherl at apache.org)
+
+
+
 
 Emeritus PMC members
 

Modified: tomcat/site/trunk/xdocs/whoweare.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whoweare.xml?rev=1775649=1775648=1775649=diff
==
--- tomcat/site/trunk/xdocs/whoweare.xml (original)
+++ tomcat/site/trunk/xdocs/whoweare.xml Thu Dec 22 13:19:34 2016
@@ -138,6 +138,9 @@ A complete list of all the Apache Commit
 
 Huxing Zhang (huxing at apache.org)
 
+
+Coty Sutherland (csutherl at apache.org)
+
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1775523 - /tomcat/site/trunk/docs/whichversion.html

2016-12-22 Thread Konstantin Kolinko 
Coty,

1). *.html are generated files. Do not edit them manually!

You should edit the source ones (*.xml) and then run Apache Ant to
regenerate the site.

There is README file there:
https://svn.apache.org/repos/asf/tomcat/site/trunk/README.txt


2). Please add yourself to the following page:
http://tomcat.apache.org/whoweare.html

Usually that is the first task for new committers.

You are welcome.


Best regards,
Konstantin Kolinko

2016-12-21 22:05 GMT+03:00 Coty Sutherland :
>> That reference is correct. Tomcat 9 implements specs from Java EE 8.
>
> Ah, I'll fix it. Sorry.
>
> On Wed, Dec 21, 2016 at 2:00 PM, Mark Thomas  wrote:
>> On 21/12/2016 18:18, csuth...@apache.org wrote:
>>> Author: csutherl
>>> Date: Wed Dec 21 18:18:32 2016
>>> New Revision: 1775523
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1775523=rev
>>> Log:
>>> Added missing JASPIC spec implementation note for tomcat 9.0 and updated an 
>>> incorrect reference to Java EE 8.
>>
>> That reference is correct. Tomcat 9 implements specs from Java EE 8.
>> There has been little to no movement on a number of specs. Based on past
>> experience there may be some last minute maintenance releases just
>> before javaEE 8 goes final.
>>
>> Mark
>>
>>
>>>
>>> Modified:
>>> tomcat/site/trunk/docs/whichversion.html
>>>
>>> Modified: tomcat/site/trunk/docs/whichversion.html
>>> URL: 
>>> http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1775523=1775522=1775523=diff
>>> ==
>>> --- tomcat/site/trunk/docs/whichversion.html (original)
>>> +++ tomcat/site/trunk/docs/whichversion.html Wed Dec 21 18:18:32 2016
>>> @@ -449,10 +449,10 @@ run stably for extended periods of time.
>>>  Apache Tomcat 9.x is the current focus of development, it
>>>  builds on Tomcat 8.0.x and implements the current draft of the 
>>> Servlet
>>>  4.0 specification and will also implement the
>>> -JSP 2.4?, EL 3.1? and
>>> -Web Socket 1.2? specifications once work starts on 
>>> updating
>>> -those specifications for Java EE 8. In addition to this, it includes the
>>> -following significant improvements:
>>> +JSP 2.4?, EL 3.1?, Web Socket 
>>> 1.2?
>>> + and JASPIC 1.1  specifications once work starts 
>>> on
>>> +updating those specifications for Java EE 9. In addition to this, it 
>>> includes
>>> +the following significant improvements:
>>>  
>>>
>>>  
>>>
>>>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1775623 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

2016-12-22 Thread remm 
Author: remm
Date: Thu Dec 22 11:01:06 2016
New Revision: 1775623

URL: http://svn.apache.org/viewvc?rev=1775623=rev
Log:
60497: Restore previous tag reuse behavior following the use of try/finally.\n 
Improve the error handling for simple tags to ensure that the tag is released 
and destroyed once used.

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Dec 22 11:01:06 2016
@@ -1,4 +1,4 @@
 
/tomcat/tc7.0.x/trunk:1190476,1224802,1243045,1298635,1304471,1311997,1312007,1331772,1333164,1333176,1348992,1354866,1371298,1371302,1371620,1402110,1409014,1413553,1413557,1413563,1430083,1438415,1446641-1446660,1447013,1453106,1453119,1484919,1486877,1498342,1500065,1503852,1505844,1513151,1521040,1524796,1526470,1536524,1539176-1539177,1544469,1544473,1552805,1558894,1558917,1560812,1561368,1561382,1561386,1561552,1561561,1561636,1561641,1561643,1561737,1562748,1564317,1564417,1568922,1570163,1577328,1577464-1577465,1578814,1586659,1586897,1586960,1588199,1588997,1589740,1589851,1589997,1590019,1590028,1590337,1590492,1590651,1590838,1590845,1590848,1590912,1593262,1593288,1593371,1593835,1594230,1595174,1595366,1600956,1601333,1601856,1601909,1609079,1609606,1617364,1617374,1617433,1617457-1617458,1624249,1626579,1627420,1627469,1632586,1637686,1637711,1640675,1642045,1643515,1643540,1643572,1643585-1643586,1643642,1643647,1644019,1648817,1656301,1658815,1659523,1659564,1664001
 
,1664176,1665087,1666762,1666968,1666989,1668541,1668635,1669802,1676557,1681183,1681841,1681865,1681867,1685829,1693109,1694293,1694433,1694875,1696381,1701945,1710353,1712656,1713873,1714000,1714005,1714540,1715213,1716221,1716417,1717107,1717210,1717212,1720236,1720398,1720443,1720464,1721814,1721883,1722645,1722801,1723151,1724435,1724553,1724675,1724797,1724806,1725931,1726631,1726808,1726813,1726815,1726817,1726819,1726917,1726919,1726922-1726924,1727031,1727034,1727043,1727158,1727672,1727903,1728450,1729363,1731010,1731119,1731956,1731978,1732362,1732674-1732675,1733942,1734116,1734134,1734532,1737249,1737253,1737968,1738049,1738186,1739778,1741178,1741184,1741193,1741211,1741218,1741228,1741235,1742281,1743121,1743142,1743649,1744061,1744129,1744155,1744241,1744383,1744689,1745230,1746942,1746994,1749377,1750018,1750980,1751066,1754114,1754147,1754728,1754880,1754891,1754898,1754902,1756030,1756417,1756420,1756423,1756942,1757275,1757284,1757503,1758490,1758495,1759567,1761
 
631,1761748,1762772,1763236,1763415,1763580,1765593,1765598,1767374,1767675-1767676,1771211,1772177,1772262,1772270,1773421,1774139,1774252,1774321,1774323,1774325,1774345
 
/tomcat/tc8.0.x/trunk:1637685,1637709,1640674,1641726,1641729-1641730,1643513,1643539,1643571,1643581-1643582,1644018,1648816,1656300,1658801-1658803,1658811,1659522,1663997,1664175,1665086,1666759,1666967,1666988,1668634,1669801,1676556,1681182,1681840,1681864,1685827,1689921,1693108,1694291,1694427,1694873,1696379,1701944,1710347,1712618,1712655,1713872,1713998,1714004,1714538,1715207,1715866,1716216-1716217,1716414,1717208-1717209,1720235,1720396,1720442,1720463,1721813,1721882,1722800,1723130,1724434,1724674,1724792,1724803,1725929,1725963-1725965,1725970,1725974,1726172,1726175,1726179-1726182,1726195-1726198,1726200,1726203,1726226,1726576,1726630,1727029,1727037,1727671,1727900,1728449,1729362,1731009,1731955,1731977,1732360,1732672,1733941,1734115,1734133,1734531,1737967,1738173,1739777,1741217,1743647,1744152,1756018,1759565,1767653,1767656
 
/tomcat/tc8.5.x/trunk:1737199,1737966,1738044,1741174,1741182,1741191,1741209,1741226,1741233,1742277,1743118,1743139-1743140,1744059,1744127,1744151,1744232,1744377,1744687,1745228,1746940,1749375,1750016,1750976,1751062,1754112,1754144,1754726,1754806,1754878,1754889,1754894,1754900,1756412,1756940,1757272,1757282,1757501,1758488,1758493,1761629,1761741,1762770,1763233,1763413,1763578,1765591,1765596,1767370,1772175,1772230,1773419,1774137,1774250,1774306-1774307,1774309,1774342

svn commit: r1775606 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

2016-12-22 Thread remm 
Author: remm
Date: Thu Dec 22 10:13:20 2016
New Revision: 1775606

URL: http://svn.apache.org/viewvc?rev=1775606=rev
Log:
60497: Restore previous tag reuse behavior following the use of try/finally.\n 
Improve the error handling for simple tags to ensure that the tag is released 
and destroyed once used.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Generator.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Dec 22 10:13:20 2016
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702
 
742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1
 
726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104

svn commit: r1775599 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

2016-12-22 Thread remm 
Author: remm
Date: Thu Dec 22 09:50:24 2016
New Revision: 1775599

URL: http://svn.apache.org/viewvc?rev=1775599=rev
Log:
60497: Restore previous tag reuse behavior following the use of try/finally.\n 
Improve the error handling for simple tags to ensure that the tag is released 
and destroyed once used.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/jasper/compiler/Generator.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Dec 22 09:50:24 2016
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452

svn commit: r1775598 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

2016-12-22 Thread remm 
Author: remm
Date: Thu Dec 22 09:43:22 2016
New Revision: 1775598

URL: http://svn.apache.org/viewvc?rev=1775598=rev
Log:
60497: Restore previous tag reuse behavior following the use of try/finally.\n 
Improve the error handling for simple tags to ensure that the tag is released 
and destroyed once used.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/jasper/compiler/Generator.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Dec 22 09:43:22 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,1762168,176217

[Bug 60508] New: AccessLogValve using %D doesn't log milliseconds for HTTP/2

2016-12-22 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=60508

Bug ID: 60508
   Summary: AccessLogValve using %D doesn't log milliseconds for
HTTP/2
   Product: Tomcat 8
   Version: 8.5.8
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: keco...@gmail.com
  Target Milestone: 

The last parameter %D in my example should output "Time taken to process the
request, in millis".

server.xml configuration in a Host element:



Log output for HTTP/2 requests:
85.x.y.z - - [22/Dec/2016:09:51:49 +0100] 'GET / HTTP/2.0' 200 1165
1482396709364

Using connector org.apache.coyote.http11.Http11AprProtocol with upgrade
protocol org.apache.coyote.http2.Http2Protocol

The value seems to be the UNIX timestamp instead for HTTP/2.0. HTTP/1.1
requests works as expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1775596 - in /tomcat/trunk: java/org/apache/jasper/compiler/Generator.java webapps/docs/changelog.xml

2016-12-22 Thread remm 
Author: remm
Date: Thu Dec 22 09:14:53 2016
New Revision: 1775596

URL: http://svn.apache.org/viewvc?rev=1775596=rev
Log:
60497: Restore previous tag reuse behavior following the use of try/finally.
Improve the error handling for simple tags to ensure that the tag is released 
and destroyed once used.

Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Generator.java?rev=1775596=1775595=1775596=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Generator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Thu Dec 22 
09:14:53 2016
@@ -2395,6 +2395,9 @@ class Generator {
 out.print(".get(");
 out.print(tagHandlerClassName);
 out.println(".class);");
+out.printin("boolean ");
+out.print(n.getTagHandlerPoolName());
+out.println("_reused = false;");
 } else {
 writeNewInstance(tagHandlerVar, tagHandlerClassName);
 }
@@ -2600,19 +2603,32 @@ class Generator {
 out.printil("}");
 }
 
-// Ensure clean-up takes place
-out.popIndent();
-out.printil("} finally {");
-out.pushIndent();
+// Print tag reuse
 if (isPoolingEnabled && !(n.implementsJspIdConsumer())) {
 out.printin(n.getTagHandlerPoolName());
 out.print(".reuse(");
 out.print(tagHandlerVar);
 out.println(");");
-} else {
-out.printin(tagHandlerVar);
-out.println(".release();");
-writeDestroyInstance(tagHandlerVar);
+out.printin(n.getTagHandlerPoolName());
+out.println("_reused = true;");
+}
+
+// Ensure clean-up takes place
+out.popIndent();
+out.printil("} finally {");
+out.pushIndent();
+if (isPoolingEnabled && !(n.implementsJspIdConsumer())) {
+out.printin("if (!");
+out.print(n.getTagHandlerPoolName());
+out.println("_reused) {");
+out.pushIndent();
+}
+out.printin(tagHandlerVar);
+out.println(".release();");
+writeDestroyInstance(tagHandlerVar);
+if (isPoolingEnabled && !(n.implementsJspIdConsumer())) {
+out.popIndent();
+out.printil("}");
 }
 out.popIndent();
 out.printil("}");
@@ -2643,6 +2659,9 @@ class Generator {
 String tagHandlerClassName = tagHandlerClass.getCanonicalName();
 writeNewInstance(tagHandlerVar, tagHandlerClassName);
 
+out.printil("try {");
+out.pushIndent();
+
 generateSetters(n, tagHandlerVar, handlerInfo, true);
 
 // JspIdConsumer (after context has been set)
@@ -2694,9 +2713,16 @@ class Generator {
 declareScriptingVars(n, VariableInfo.AT_END);
 syncScriptingVars(n, VariableInfo.AT_END);
 
+out.popIndent();
+out.printil("} finally {");
+out.pushIndent();
+
 // Resource injection
 writeDestroyInstance(tagHandlerVar);
 
+out.popIndent();
+out.printil("}");
+
 n.setEndJavaLine(out.getJavaLine());
 }
 

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1775596=1775595=1775596=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Dec 22 09:14:53 2016
@@ -100,9 +100,19 @@
   
   
 
-  Implement a simpler JSP file encoding detector that delegates XML prolog
-  encoding detection to the JRE rather than using a custom XML parser.
-  (markt)
+  
+Implement a simpler JSP file encoding detector that delegates XML 
prolog
+encoding detection to the JRE rather than using a custom XML parser.
+(markt)
+  
+  
+60497: Restore previous tag reuse behavior following the use
+of try/finally. (remm)
+  
+  
+Improve the error handling for simple tags to ensure that the tag is
+released and destroyed once used. (remm)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org