date:20170123

Re: [RESULT][VOTE] Release Apache Tomcat 8.0.41

2017-01-23 Thread Violeta Georgieva

Hi,

2017-01-19 1:07 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 8.0.41 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.41/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1118/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_41/
>
> The proposed 8.0.41 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.0.41

+1 (binding):violetagg, mgrigorov, fschumacher, remm
+1 (non-binding): csutherl

No other voters were cast.

The vote has passed.

I'll do the release shortly and announce it once the mirrors catch up.

Thanks,
Violeta

Re: [RESULT][VOTE] Release Apache Tomcat 7.0.75

2017-01-23 Thread Violeta Georgieva

Hi,

2017-01-18 23:45 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.75 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.75/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1117/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_75/
>
> The proposed 7.0.75 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.75 Stable

+1 (binding):violetagg, mgrigorov, fschumacher, remm
+1 (non-binding): csutherl

No other voters were cast.

The vote has passed.

I'll do the release shortly and announce it once the mirrors catch up.

Thanks,
Violeta

[Bug 54618] Add filter implementing HTTP Strict Transport Security (HSTS) [PATCH]

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=54618

Ralf Hauser  changed:

   What|Removed |Added

 CC||hau...@acm.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60362] Missing reason phrase in response

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60362

--- Comment #10 from Josh Soref  ---
https://github.com/jech/polipo/blob/master/tunnel.c#L302
const char *message = "HTTP/1.1 200 Tunnel established\r\n\r\n";

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60632] Last logs lost when running Tomcat with systemd and journald

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60632

Chuck Caldarale  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59390] Tomcat systemd/systemctl status tomcat don't show catalina errors.

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=59390

--- Comment #4 from Jeff Turner  ---
> 2) solution should be that systemctl status should report directly that ths 
> ssl configuration is failed, and the other configuration are fine, but 
> starting tomcat, unlike solution 1).

The lack of error message in 'systemctl status' is a systemd bug:

https://github.com/systemd/systemd/issues/1347

See Tomcat workaround suggestion at
https://bz.apache.org/bugzilla/show_bug.cgi?id=60632

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60632] Last logs lost when running Tomcat with systemd and journald

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60632

--- Comment #1 from Jeff Turner  ---
FYI I can't add an attachment - keep getting 'Permission denied' from
attachment.cgi. Here's the suggested patch:


--- bin/catalina.sh.orig2017-01-24 12:54:39.181880382 +1100
+++ bin/catalina.sh 2017-01-24 12:55:56.862144647 +1100
@@ -100,6 +100,9 @@
 #   case the default is "true"
 #
-

+# If running in systemd, give it a chance to tag the last output.
https://github.com/systemd/systemd/issues/1347
+trap 'sleep 0.1' INT TERM EXIT
+
 # OS specific support.  $var _must_ be set to either true or false.
 cygwin=false
 darwin=false

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60632] New: Last logs lost when running Tomcat with systemd and journald

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60632

Bug ID: 60632
   Summary: Last logs lost when running Tomcat with systemd and
journald
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: j...@redradishtech.com
  Target Milestone: 

Many people run Tomcat from systemd, and will be using 'journalctl' to manage
Tomcat's stdout. journalctl has a not-easily-fixed bug that causes the last few
stdout/stderr lines to be 'lost'. This is a problem, as the last few lines are
usually the most important. Here I suggest a small workaround in
bin/catalina.sh that I feel would be safe and worthwhile.

A simple example: let's deploy a Tomcat instance running as a dedicated user:

# useradd -s /bin/bash -d /tmp testtomcat
# su - testtomcat
curl -sLO
http://www-us.apache.org/dist/tomcat/tomcat-8/v8.5.11/bin/apache-tomcat-8.5.11.tar.gz
tar xf apache-tomcat-8.5.11.tar.gz
cd apache-tomcat-8.5.11

If we run 'bin/catalina.sh run' it starts normally.

testtomcat@jturner-desktop:~/apache-tomcat-8.5.11$ ./bin/catalina.sh run
Using CATALINA_BASE:   /tmp/apache-tomcat-8.5.11
Using CATALINA_HOME:   /tmp/apache-tomcat-8.5.11
Using CATALINA_TMPDIR: /tmp/apache-tomcat-8.5.11/temp
Using JRE_HOME:/usr/lib/jvm/java-8-oracle
Using CLASSPATH:  
/tmp/apache-tomcat-8.5.11/bin/bootstrap.jar:/tmp/apache-tomcat-8.5.11/bin/tomcat-juli.jar
...

Let's introduce an error. Say we got JAVA_HOME wrong. We get an error message
as expected:

testtomcat@jturner-desktop:~/apache-tomcat-8.5.11$ JAVA_HOME=/incorrect/path
./bin/catalina.sh run
Using CATALINA_BASE:   /tmp/apache-tomcat-8.5.11
Using CATALINA_HOME:   /tmp/apache-tomcat-8.5.11
Using CATALINA_TMPDIR: /tmp/apache-tomcat-8.5.11/temp
Using JRE_HOME:/incorrect/path
Using CLASSPATH:  
/tmp/apache-tomcat-8.5.11/bin/bootstrap.jar:/tmp/apache-tomcat-8.5.11/bin/tomcat-juli.jar
./bin/catalina.sh: 1: exec: /incorrect/path/bin/java: not found
testtomcat@jturner-desktop:~/apache-tomcat-8.5.11$ 

All find and dandy.

Now let's run Tomcat via systemd. Create a minimal service file as root and
load it:

# cat > /etc/systemd/system/testtomcat.service  /etc/systemd/system/testtomcat.service

Re: Dynamic reloading of SSL certificates

2017-01-23 Thread Christopher Schultz

Mark and Emmanuel,

On 1/23/17 5:01 AM, Mark Thomas wrote:
> On 23/01/2017 09:36, Emmanuel Bourg wrote:
>> Hi all,
>>
>> With the fast adoption of Let's Encrypt many people are interested in
>> integrating it with Tomcat. A first step was to ensure that Tomcat can
>> directly use the PEM certificates generated by the letsencrypt/certbot
>> client. An important aspect of Let's Encrypt is automation, the
>> certificates are relatively short lived (90 days) and must be updated
>> automatically. AFAIK there is no easy way yet to reload a connector in
>> Tomcat to pick a new certificate. The administrator either has to
>> restart Tomcat (bad in a production environment) or do some JMX tricks
>> [1] (but JMX must be enabled and secured properly).
>>
>> I'm wondering if it would be possible for Tomcat to monitor the
>> certificates/keystore files and reload the associated connectors
>> automatically? If there is a consensus on this feature I'd be interested
>> in implementing it.
> 
> For background reading:
> 
> http://tomcat.markmail.org/thread/fthbtwuozidno6lw
> 
> http://tomcat.markmail.org/thread/753blzkslmifcvh4

Yep. I'm also planning on giving a presentation about this exact topic
at ApacheCon in Miami.

-chris



signature.asc
Description: OpenPGP digital signature

[Bug 60597] Add ability to set cipher suites for websocket client connections

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60597

Christopher Schultz  changed:

   What|Removed |Added

Summary|Add ability to set cipher   |Add ability to set cipher
   |suites for websocket|suites for websocket client
   |connections |connections

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60623] When startStopThreads is 1, don't rely on an executor and instead start synchronously

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60623

--- Comment #12 from romain.manni-bucau  ---
Ok, if you have a listener observing before_init or before_start on Context (or
even org.apache.catalina.core.StandardHost#addChild) you can initialize some
context there, if you only deploy in this pool then you are safe to set and not
unset the value there.

I saw that several times in company integrations and I think it would be great
to not break them. Also keep in mind 1 is the default.

Regarding 0, you are right. For the story it means "auto number" from the
available processors which is something I missed.

Side note - unrelated to this ticket but still related to in context
deployment: for the embedded case using tomcat.getHost().addChild(context)
already deploys in current thread (that's what does Apache Meecrowave for
instance). This also means org.apache.catalina.core.ContainerBase#initInternal
could be lazy to avoid to create these useless threads.

Thinking more about it I think a clean solution would to just pass an executor
name like for connectors and just lookup the executor from the server.xml
definitions. If you don't want that pool deployment tomcat can provide an
InCallerThreadExecutor implementing Executor interface.

wdyt?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60623] When startStopThreads is 1, don't rely on an executor and instead start synchronously

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60623

--- Comment #11 from Mark Thomas  ---
You are going to have to explain that code sample. It means nothing to me.

0 and negative numbers are already defined to have special meaning.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60623] When startStopThreads is 1, don't rely on an executor and instead start synchronously

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60623

--- Comment #10 from romain.manni-bucau  ---
> Code that relies on the deployment mechanism for correct clean-up is broken 
> and needs to be fixed. Deployment threads may be re-used before they are 
> stopped and if any component fails to fully clean-up, the data could leak to 
> the next deployment and potentially cause a security issue.

No cause it is only in these threads so this pattern works well without
leaking:

deploymentStart() { context.set(new DeploymentEn(...)); }
deploymentStop() {}


Don't get me wrong, I don't like that code but saw it often and with tomcat
behavior it was more than valid.

> Re-defining a value of 1 for startStopThreads to mean 'serial deployment on 
> the main processing thread' rather than 'serial deployment via a thread pool 
> with a single thread' looks perfectly reasonable to me at this point.

I think I didn't get what was the issue using 0 for that? It keeps
compatibility and allow this new feature as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60623] When startStopThreads is 1, don't rely on an executor and instead start synchronously

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60623

--- Comment #9 from Mark Thomas  ---
Code that relies on the deployment mechanism for correct clean-up is broken and
needs to be fixed. Deployment threads may be re-used before they are stopped
and if any component fails to fully clean-up, the data could leak to the next
deployment and potentially cause a security issue.

Re-defining a value of 1 for startStopThreads to mean 'serial deployment on the
main processing thread' rather than 'serial deployment via a thread pool with a
single thread' looks perfectly reasonable to me at this point.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.75

2017-01-23 Thread Coty Sutherland

2017-01-18 23:45 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.75 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.75/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1117/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_75/
>
> The proposed 7.0.75 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.75 Stable

+1

On Mon, Jan 23, 2017 at 12:12 PM, Rémy Maucherat  wrote:
> 2017-01-18 22:45 GMT+01:00 Violeta Georgieva :
>
>> The proposed Apache Tomcat 7.0.75 release is now available for voting.
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.75/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1117/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_75/
>>
>> The proposed 7.0.75 release is:
>> [ ] Broken - do not release
>> [X] Stable - go ahead and release as 7.0.75 Stable
>>
>> Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.41

2017-01-23 Thread Coty Sutherland

2017-01-19 1:07 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 8.0.41 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.41/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1118/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_41/
>
> The proposed 8.0.41 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.0.41

+1

On Mon, Jan 23, 2017 at 11:43 AM, Rémy Maucherat  wrote:
> 2017-01-19 0:07 GMT+01:00 Violeta Georgieva :
>
>> The proposed Apache Tomcat 8.0.41 release is now available for voting.
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.41/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1118/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_41/
>>
>> The proposed 8.0.41 release is:
>> [ ] Broken - do not release
>> [X] Stable - go ahead and release as 8.0.41
>>
>> Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.75

2017-01-23 Thread Rémy Maucherat

2017-01-18 22:45 GMT+01:00 Violeta Georgieva :

> The proposed Apache Tomcat 7.0.75 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.75/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1117/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_75/
>
> The proposed 7.0.75 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.75 Stable
>
> Rémy

[Bug 60627] Wrong cookie makes Rfc6265CookieProcessor ommit all following cookies

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60627

--- Comment #2 from Mark Thomas  ---
The RFC6265 parser switches to RFC2109 rules if it sees $Version="1". It
currently treats any other version as unknown and rejects the header.

We could configure the RFC6265 parser to parse version 0 either with the
RFC2109 parser or the RFC6265 parser. I'm leaning towards RFC2109 but I'd like
to give this a little more thought. Also, any feedback would be very welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.41

2017-01-23 Thread Rémy Maucherat

2017-01-19 0:07 GMT+01:00 Violeta Georgieva :

> The proposed Apache Tomcat 8.0.41 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.41/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1118/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_41/
>
> The proposed 8.0.41 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.0.41
>
> Rémy

[Bug 60629] Misleading/erroneous log message from TldScanner#scanJars() about no TLDs in scanned JARs

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60629

--- Comment #6 from Michael Osipov <1983-01...@gmx.net> ---
(In reply to Remy Maucherat from comment #5)
> The point was to say that some JARs were needlessly scanned, and they could
> be filtered out. People go on to complain sometimes that they have 1000s of
> JARs in their webapp and it takes too long to start.
> 
> The INFO log explains the JAR filtering part correctly, but the first part
> is too convoluted, and the "yet" -> "which" is marginally better, but not
> *so* much. I'm not sure who wrote that originally, maybe me who knows.
> 
> -> "JAR scanner did not find TLDs in some JARs. Enable debug logging for
> this logger for a complete list of JARs. Skipping unneeded JARs during
> scanning can improve startup time and JSP compilation time.".
> 
> That's shorter, is it better ?

Yes, it is: "JAR scanner did not find any TLDs in some JARs. ..."

It removes the fail-fast implication for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.75

2017-01-23 Thread Felix Schumacher



Am 18. Januar 2017 22:45:53 MEZ schrieb Violeta Georgieva 
:
>The proposed Apache Tomcat 7.0.75 release is now available for voting.
>
>It can be obtained from:
>https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.75/
>The Maven staging repo is:
>https://repository.apache.org/content/repositories/orgapachetomcat-1117/
>The svn tag is:
>http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_75/
>
>The proposed 7.0.75 release is:
>[ ] Broken - do not release
>[x] Stable - go ahead and release as 7.0.75 Stable

Regards,
 Felix

>
>Regards,
>Violeta

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.0.41

2017-01-23 Thread Felix Schumacher



Am 19. Januar 2017 00:07:32 MEZ schrieb Violeta Georgieva 
:
>The proposed Apache Tomcat 8.0.41 release is now available for voting.
>
>It can be obtained from:
>https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.41/
>The Maven staging repo is:
>https://repository.apache.org/content/repositories/orgapachetomcat-1118/
>The svn tag is:
>http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_41/
>
>The proposed 8.0.41 release is:
>[ ] Broken - do not release
>[x] Stable - go ahead and release as 8.0.41

Regards,
 Felix

>
>Regards,
>Violeta

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60629] Misleading/erroneous log message from TldScanner#scanJars() about no TLDs in scanned JARs

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60629

--- Comment #5 from Remy Maucherat  ---
The point was to say that some JARs were needlessly scanned, and they could be
filtered out. People go on to complain sometimes that they have 1000s of JARs
in their webapp and it takes too long to start.

The INFO log explains the JAR filtering part correctly, but the first part is
too convoluted, and the "yet" -> "which" is marginally better, but not *so*
much. I'm not sure who wrote that originally, maybe me who knows.

-> "JAR scanner did not find TLDs in some JARs. Enable debug logging for this
logger for a complete list of JARs. Skipping unneeded JARs during scanning can
improve startup time and JSP compilation time.".

That's shorter, is it better ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60627] Wrong cookie makes Rfc6265CookieProcessor ommit all following cookies

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60627

--- Comment #1 from Ales Dolecek  ---
The format used by the client is RFC 2109 or RFC 2965. So I guess it was
probably dropped from Rfc6265CookieProcessor intentionally.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60629] Misleading/erroneous log message from TldScanner#scanJars() about no TLDs in scanned JARs

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60629

--- Comment #4 from Michael Osipov <1983-01...@gmx.net> ---
(In reply to Rainer Jung from comment #3)
> Maybe instead of
> 
> "At least one JAR was scanned for TLDs yet contained no TLDs."
> 
> use
> 
> "At least one JAR was scanned for TLDs which contained no TLDs."
> 
> Would that make it easier to understand?

If I (user) wouldn't read the source code nor enabled debug, the message
implies that: "Hey, I have scanned one JAR, found no TLD and gave up." The
problem is the "At least one JAR", it sounds like fail-fast and not fail-last.

I would rather expect: "n JARs were scanned, but some did not contain any TLDs.
Enable ..." or "Some scanned JARs did not contain any TLDs. Enable ..."

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60629] Misleading/erroneous log message from TldScanner#scanJars() about no TLDs in scanned JARs

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60629

--- Comment #3 from Rainer Jung  ---
Maybe instead of

"At least one JAR was scanned for TLDs yet contained no TLDs."

use

"At least one JAR was scanned for TLDs which contained no TLDs."

Would that make it easier to understand?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60362] Missing reason phrase in response

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60362

--- Comment #9 from Michael Osipov <1983-01...@gmx.net> ---
(In reply to Mateusz Nowakowski from comment #8)
> >Do your clients require just some text after the space or do they really 
> >analyze >the text for predefined values?
> 
> They analyze the text, however they are compatible with previous behavior.
> They analyze/require:  "HTTP/1.1 200 OK" to be returned.
> 
> I thought about just a boolean configuration option to bring back previous
> behavior.

What about "HTTP/1.1 200 Fine, mate!"? This would work or hard requirement for
"OK"?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60629] Misleading/erroneous log message from TldScanner#scanJars() about no TLDs in scanned JARs

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60629

--- Comment #2 from Michael Osipov <1983-01...@gmx.net> ---
(In reply to Mark Thomas from comment #1)
> The message is correct.
> 
> Of the JARs scanned, at least one JAR was scanned for TLDs without any TLDs
> being found in that JAR.
> 
> Configuring the JAR scanner to skip the TLD scan for those JARs that do not
> contain TLDs should improve the web application start time.

Thanks, this might be a wording issue of the message. It implied erratic
behavior to me. Maybe a rewording will help to avoid future misunderstanding
from non-English natives.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60629] Misleading/erroneous log message from TldScanner#scanJars() about no TLDs in scanned JARs

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60629

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Mark Thomas  ---
The message is correct.

Of the JARs scanned, at least one JAR was scanned for TLDs without any TLDs
being found in that JAR.

Configuring the JAR scanner to skip the TLD scan for those JARs that do not
contain TLDs should improve the web application start time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60629] New: Misleading/erroneous log message from TldScanner#scanJars() about no TLDs in scanned JARs

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60629

Bug ID: 60629
   Summary: Misleading/erroneous log message from
TldScanner#scanJars() about no TLDs in scanned JARs
   Product: Tomcat 8
   Version: 8.5.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: 1983-01...@gmx.net
  Target Milestone: 

I believe that this log message is incorrect. In debug mode I get the following
output (trimmed for brevity):

> 23-Jan-2017 15:18:34.368 INFORMATION [localhost-startStop-1] 
> o.a.catalina.startup.HostConfig.deployWAR Deploying web application archive 
> /var/opt/tomcat-8.5/webapps/smartld.war
> 23-Jan-2017 15:18:44.315 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner.scanResourcePaths No TLD files were found in 
> resource path [/WEB-INF/jsp/control/recordUpdate/].
> 23-Jan-2017 15:18:44.315 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner.scanResourcePaths No TLD files were found in 
> resource path [/WEB-INF/jsp/control/].
> 23-Jan-2017 15:18:44.316 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner.scanResourcePaths No TLD files were found in 
> resource path [/WEB-INF/jsp/admin/].
> 23-Jan-2017 15:18:44.317 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner.scanResourcePaths No TLD files were found in 
> resource path [/WEB-INF/jsp/].
> 23-Jan-2017 15:18:44.349 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner.scanResourcePaths No TLD files were found in 
> resource path [/WEB-INF/vm/].
> 23-Jan-2017 15:18:44.349 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner.scanResourcePaths TLD files were found in 
> resource path [/WEB-INF/].
> 23-Jan-2017 15:18:44.360 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner$TldScannerCallback.scan No TLD files were found 
> in 
> [file:/var/opt/tomcat-8.5/webapps/smartld/WEB-INF/lib/jericho-html-2.4.jar]. 
> Consider ...
> 23-Jan-2017 15:18:44.371 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner$TldScannerCallback.scan No TLD files were found 
> in 
> [file:/var/opt/tomcat-8.5/webapps/smartld/WEB-INF/lib/logback-core-1.1.8.jar].
>  Consider ...
> 23-Jan-2017 15:18:44.375 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner$TldScannerCallback.scan No TLD files were found 
> in 
> [file:/var/opt/tomcat-8.5/webapps/smartld/WEB-INF/lib/json-lib-2.4-jdk15.jar].
>  Consider ...
> 23-Jan-2017 15:18:44.377 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner$TldScannerCallback.scan No TLD files were found 
> in 
> [file:/var/opt/tomcat-8.5/webapps/smartld/WEB-INF/lib/tedab-services-search-syntax-converter-1.5.jar].
>  Consider ...
> 23-Jan-2017 15:18:44.421 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner$TldScannerCallback.scan TLD files were found in 
> JAR 
> [file:/var/opt/tomcat-8.5/webapps/smartld/WEB-INF/lib/smartld-widget-taglib-3.0-SNAPSHOT.jar].
> 23-Jan-2017 15:18:44.424 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner$TldScannerCallback.scan No TLD files were found 
> in 
> [file:/var/opt/tomcat-8.5/webapps/smartld/WEB-INF/lib/yui2-assets-2.9.0-dynamowerk-10.jar].
>  Consider ...
> 23-Jan-2017 15:18:44.425 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner$TldScannerCallback.scan No TLD files were found 
> in 
> [file:/var/opt/tomcat-8.5/webapps/smartld/WEB-INF/lib/commons-dbutils-1.6.jar].
>  Consider ...
> 23-Jan-2017 15:18:44.426 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner$TldScannerCallback.scan No TLD files were found 
> in 
> [file:/var/opt/tomcat-8.5/webapps/smartld/WEB-INF/lib/xmlpull-1.1.3.1.jar]. 
> Consider ...
> 23-Jan-2017 15:18:44.562 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner$TldScannerCallback.scan TLD files were found in 
> JAR 
> [file:/var/opt/tomcat-8.5/webapps/smartld/WEB-INF/lib/displaytag-1.2-dynamowerk-4.jar].
> 23-Jan-2017 15:18:44.564 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner$TldScannerCallback.scan No TLD files were found 
> in 
> [file:/var/opt/tomcat-8.5/webapps/smartld/WEB-INF/lib/urlrewritefilter-4.0.4.jar].
>  Consider ...
> 23-Jan-2017 15:18:44.565 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner$TldScannerCallback.scan No TLD files were found 
> in [file:/var/opt/tomcat-8.5/webapps/smartld/WEB-INF/lib/ezmorph-1.0.6.jar]. 
> Consider ...
> 23-Jan-2017 15:18:44.566 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner$TldScannerCallback.scan No TLD files were found 
> in 
> [file:/var/opt/tomcat-8.5/webapps/smartld/WEB-INF/lib/dynamowerk-js-0.4.1.jar].
>  Consider ...
> 23-Jan-2017 15:18:44.568 FEIN [localhost-startStop-1] 
> o.a.jasper.servlet.TldScanner$TldScannerCallback.scan No TLD files were found 
> in 
> [file:/var/opt/tomcat-8.5/webapps/smartld/WEB-INF/lib/logback-classic-1.1.8.jar].

[Bug 60362] Missing reason phrase in response

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60362

--- Comment #8 from Mateusz Nowakowski  ---
>Do your clients require just some text after the space or do they really 
>analyze >the text for predefined values?

They analyze the text, however they are compatible with previous behavior.
They analyze/require:  "HTTP/1.1 200 OK" to be returned.

I thought about just a boolean configuration option to bring back previous
behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60627] Wrong cookie makes Rfc6265CookieProcessor ommit all following cookies

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60627

Michael Osipov <1983-01...@gmx.net> changed:

   What|Removed |Added

 OS||All
 CC||1983-01...@gmx.net

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1779932 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteBufferUtils.java LocalStrings.properties

2017-01-23 Thread markt

Author: markt
Date: Mon Jan 23 14:16:32 2017
New Revision: 1779932

URL: http://svn.apache.org/viewvc?rev=1779932&view=rev
Log:
Remove unused code, effectively reverting 1779370 and 1779612.
Java 9 is now handled in other branch of if/else.

Modified:
tomcat/trunk/java/org/apache/tomcat/util/buf/ByteBufferUtils.java
tomcat/trunk/java/org/apache/tomcat/util/buf/LocalStrings.properties

Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/ByteBufferUtils.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/buf/ByteBufferUtils.java?rev=1779932&r1=1779931&r2=1779932&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/buf/ByteBufferUtils.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/buf/ByteBufferUtils.java Mon Jan 
23 14:16:32 2017
@@ -23,7 +23,6 @@ import java.nio.ByteBuffer;
 
 import org.apache.juli.logging.Log;
 import org.apache.juli.logging.LogFactory;
-import org.apache.tomcat.util.ExceptionUtils;
 import org.apache.tomcat.util.compat.JreCompat;
 import org.apache.tomcat.util.res.StringManager;
 
@@ -65,16 +64,9 @@ public class ByteBufferUtils {
 Object cleanerObject = cleanerMethodLocal.invoke(tempBuffer);
 cleanMethodLocal = cleanerObject.getClass().getMethod("clean");
 cleanMethodLocal.invoke(cleanerObject);
-} catch (Throwable t) {
-JreCompat jreCompat = JreCompat.getInstance();
-if (jreCompat.isInstanceOfInaccessibleObjectException(t)) {
-// Must be running on Java 9 without the necessary command 
line
-// options.
-
log.warn(sm.getString("byteBufferUtils.addExportsCleaner"));
-} else {
-ExceptionUtils.handleThrowable(t);
-}
-log.warn(sm.getString("byteBufferUtils.cleaner"), t);
+} catch (NoSuchMethodException | SecurityException | 
IllegalAccessException |
+IllegalArgumentException | InvocationTargetException e) {
+log.warn(sm.getString("byteBufferUtils.cleaner"), e);
 cleanerMethodLocal = null;
 cleanMethodLocal = null;
 }

Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/buf/LocalStrings.properties?rev=1779932&r1=1779931&r2=1779932&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/buf/LocalStrings.properties 
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/buf/LocalStrings.properties Mon 
Jan 23 14:16:32 2017
@@ -23,5 +23,4 @@ uDecoder.urlDecode.missingDigit=The % ch
 uDecoder.convertHexDigit.notHex=[{0}] is not a hexadecimal digit
 uDecoder.urlDecode.uee=Unable to URL decode the specified input since the 
encoding [{0}] is not supported.
 
-byteBufferUtils.addExportsCleaner=When running on Java 9 you need to add 
"--add-opens=java.base/java.nio=ALL-UNNAMED" to the JVM command line arguments 
to enable the direct ByteBuffer cleaner
 byteBufferUtils.cleaner=Cannot use direct ByteBuffer cleaner, memory leaking 
may occur



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60362] Missing reason phrase in response

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60362

--- Comment #7 from Michael Osipov <1983-01...@gmx.net> ---
(In reply to Mateusz Nowakowski from comment #6)
> Facts: 
> 8.0.39 still returns the reason phase.
> 8.5.x and onward do not return the reason phase.
> 
> Purpose of this story is to add a config option to bring it back in 8.5.x
> and onward.
> 
> Apache Tomcat Team & Product Owner,
> 
> Do you agree to add configuration option for this?
> 
> If yes, what the potential ETA is?
> 
> This information is needed to decide what kind of actions I need to perform
> (whether change all legacy / old clients & postpone or not  migration to the
> latest Tomcat 8.5.x)

Do your clients require just some text after the space or do they really
analyze the text for predefined values?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.75

2017-01-23 Thread Violeta Georgieva

Hi,

2017-01-18 23:45 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.75 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.75/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1117/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_75/
>
> The proposed 7.0.75 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.75 Stable

We need more votes.

 Thanks,
 Violeta

Re: [VOTE] Release Apache Tomcat 8.0.41

2017-01-23 Thread Violeta Georgieva

Hi,

2017-01-19 1:07 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 8.0.41 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.41/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1118/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_41/
>
> The proposed 8.0.41 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.0.41

We need more votes.

 Thanks,
 Violeta

Re: [VOTE] Release Apache Tomcat 6.0.50

2017-01-23 Thread Violeta Georgieva

2017-01-22 17:59 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 6.0.50 release is now available for voting.
>
> Note: This is the last Tomcat 6 release.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.50/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1119/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_50/
>
> The proposed 6.0.50 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 6.0.50 Stable

 Regards,
 Violeta

[Bug 60362] Missing reason phrase in response

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60362

Mateusz Nowakowski  changed:

   What|Removed |Added

Version|8.0.x-trunk |8.5.x-trunk

--- Comment #6 from Mateusz Nowakowski  ---
Facts: 
8.0.39 still returns the reason phase.
8.5.x and onward do not return the reason phase.

Purpose of this story is to add a config option to bring it back in 8.5.x and
onward.

Apache Tomcat Team & Product Owner,

Do you agree to add configuration option for this?

If yes, what the potential ETA is?

This information is needed to decide what kind of actions I need to perform
(whether change all legacy / old clients & postpone or not  migration to the
latest Tomcat 8.5.x)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60613] getting Maximum code footprint error after upgrade to Tomcat 8.5.11

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60613

--- Comment #6 from Mark Thomas  ---
The users list is the best place to discuss ways to handle problems with overly
large methods.

I've taken a quick look at the generated source and I don;t see any obvious
ways to reduce the size of the generated method.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60490] Several improvements to the ErrorReportValve

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60490

--- Comment #6 from Michael Osipov <1983-01...@gmx.net> ---
(In reply to Mark Thomas from comment #5)
> Thanks for the patch.
> 
> Fixed in:
> - trunk for 9.0.0.M18 onwards
> - 8.5.x for 8.5.12 onwards

Thank you very much, I can finally discontinue my public version:
http://mo-tomcat-ext.sourceforge.net/xref/net/sf/michaelo/tomcat/extras/valves/EnhancedErrorReportValve.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Publish snapshots from the Buidlbot

2017-01-23 Thread Mark Thomas

I think it would be useful if we configured buildbot to publish
snapshots (probably as part of the daily build) to repository.a.o.
Therefore I have requested the appropriate credentials from infra and
when I have them I'll make the necessary changes tot he buildbot config.
It might also be necessary to tweak our build scripts.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60627] New: Wrong cookie makes Rfc6265CookieProcessor ommit all following cookies

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60627

Bug ID: 60627
   Summary: Wrong cookie makes Rfc6265CookieProcessor ommit all
following cookies
   Product: Tomcat 8
   Version: 8.5.8
  Hardware: PC
Status: NEW
  Severity: minor
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: ale...@seznam.cz
  Target Milestone: 

Our client (NGi/GVP Media Control Platform (Build: 8.5.150.63)) sends following
Cookie header with request:

Cookie: $Version="0"; JSESSIONID=3BE951FE7F4A2BA1A47390E6674256A3.WH5;
$Path=/ivr-csob

The cookie is not processed however and new session is created. If the
JSESSIONID cookie goes before the $Version cookie it understood.

The old LegacyCookieProcessor can understand it - so we have forced the
application to use it.

I'm aware that the Cookie hewader is not RFC6265 compliant, but it would be
nice if it tired to process all cookies specified in the header and not fail
after first parsing error. From this point of view is the new processor less
lenient thatn the old one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1779901 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/Tomcat.java webapps/docs/changelog.xml

2017-01-23 Thread markt

Author: markt
Date: Mon Jan 23 10:18:45 2017
New Revision: 1779901

URL: http://svn.apache.org/viewvc?rev=1779901&view=rev
Log:
Make it easier for sub-classes of Tomcat to modify the default web.xml settings 
by over-riding getDefaultWebXmlListener().
Patch provided by Aaron Anderson.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/Tomcat.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jan 23 10:18:45 2017
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702
 
742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1
 
726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330
-/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132,1740521,1740536,1740804,1740811,1740981,1741165,1741174,1741182,1741191,1741203,1741209,1741226,1741233,1741410,1742277,1743118,1743126,1743139-1743140,1743718,1743722,1743724,1744059,1744127,1744151,1744232,1744377,1744687,1744698,1744706,1745228,1746940,1748548,1748716,1749288,1749375,1749668-1749669,1750016,1750057,1750976,1751000,1751062,1751098,1754112,1754144,1754282,1754312,1754614,1754726,175480

svn commit: r1779900 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/startup/Tomcat.java webapps/docs/changelog.xml

2017-01-23 Thread markt

Author: markt
Date: Mon Jan 23 10:16:55 2017
New Revision: 1779900

URL: http://svn.apache.org/viewvc?rev=1779900&view=rev
Log:
Make it easier for sub-classes of Tomcat to modify the default web.xml settings 
by over-riding getDefaultWebXmlListener().
Patch provided by Aaron Anderson.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/startup/Tomcat.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jan 23 10:16:55 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,1762168,176217
 
2,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450

[GitHub] tomcat pull request #40: Corrected addWebapp default web xml listener refere...

2017-01-23 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/tomcat/pull/40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1779899 - in /tomcat/trunk: java/org/apache/catalina/startup/Tomcat.java webapps/docs/changelog.xml

2017-01-23 Thread markt

Author: markt
Date: Mon Jan 23 10:16:18 2017
New Revision: 1779899

URL: http://svn.apache.org/viewvc?rev=1779899&view=rev
Log:
Make it easier for sub-classes of Tomcat to modify the default web.xml settings 
by over-riding getDefaultWebXmlListener().
Patch provided by Aaron Anderson.
This closes #40

Modified:
tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java?rev=1779899&r1=1779898&r2=1779899&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java Mon Jan 23 
10:16:18 2017
@@ -593,7 +593,7 @@ public class Tomcat {
 Context ctx = createContext(host, contextPath);
 ctx.setPath(contextPath);
 ctx.setDocBase(docBase);
-ctx.addLifecycleListener(new DefaultWebXmlListener());
+ctx.addLifecycleListener(getDefaultWebXmlListener());
 ctx.setConfigFile(getWebappConfigFile(docBase, contextPath));
 
 ctx.addLifecycleListener(config);

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1779899&r1=1779898&r2=1779899&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Jan 23 10:16:18 2017
@@ -55,6 +55,12 @@
 60596: Improve performance of DefaultServlet when sendfile
 feature is disabled on connector. (kkolinko)
   
+  
+Make it easier for sub-classes of Tomcat to modify the
+default web.xml settings by over-riding
+getDefaultWebXmlListener(). Patch provided by Aaron
+Anderson. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Dynamic reloading of SSL certificates

2017-01-23 Thread Mark Thomas

On 23/01/2017 09:36, Emmanuel Bourg wrote:
> Hi all,
> 
> With the fast adoption of Let's Encrypt many people are interested in
> integrating it with Tomcat. A first step was to ensure that Tomcat can
> directly use the PEM certificates generated by the letsencrypt/certbot
> client. An important aspect of Let's Encrypt is automation, the
> certificates are relatively short lived (90 days) and must be updated
> automatically. AFAIK there is no easy way yet to reload a connector in
> Tomcat to pick a new certificate. The administrator either has to
> restart Tomcat (bad in a production environment) or do some JMX tricks
> [1] (but JMX must be enabled and secured properly).
> 
> I'm wondering if it would be possible for Tomcat to monitor the
> certificates/keystore files and reload the associated connectors
> automatically? If there is a consensus on this feature I'd be interested
> in implementing it.

For background reading:

http://tomcat.markmail.org/thread/fthbtwuozidno6lw

http://tomcat.markmail.org/thread/753blzkslmifcvh4

Mark


> 
> Emmanuel Bourg
> 
> [1]
> http://serverfault.com/questions/328533/can-tomcat-reload-its-ssl-certificate-without-being-restarted
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60623] When startStopThreads is 1, don't rely on an executor and instead start synchronously

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60623

--- Comment #8 from romain.manni-bucau  ---
Fact is tomcat kind of guarantee you execute code in a specific thread pool
(far from any user pool or http pool to be concrete).

So there is now a lot of code relying on deployment "initialization" setting
there and not cleaning it (for good or bad reasons depending the listener
implementation/hook). This is not an issue - assuming classes are coming from
the "container" - since you are limited to this pool so it will be initialized
each time and runtime will either not use that or get null and handle it
(that's the 2 cases I'm aware of).

Add to that #pool=1 is used to avoid concurrent deployments and uresing this
value to change the deployment mode will break instances.

Also just on a semantic point of view pool size = 1 sounds like a pool size is
1 and not 0 which correspond to "execute in context" no?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60623] When startStopThreads is 1, don't rely on an executor and instead start synchronously

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60623

--- Comment #7 from Mark Thomas  ---
(In reply to romain.manni-bucau from comment #4)
> Can 1 keep current behavior and 0 or negative values use an executor
> executing directly the task? 1 is used and relying on deployer threads
> avoids to leak data where this change would enable leakages for numerous
> cases like html deployer.

?

Please explain. The origins of the startStopThreads feature are not related to
memory leak prevention.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Dynamic reloading of SSL certificates

2017-01-23 Thread Emmanuel Bourg

Hi all,

With the fast adoption of Let's Encrypt many people are interested in
integrating it with Tomcat. A first step was to ensure that Tomcat can
directly use the PEM certificates generated by the letsencrypt/certbot
client. An important aspect of Let's Encrypt is automation, the
certificates are relatively short lived (90 days) and must be updated
automatically. AFAIK there is no easy way yet to reload a connector in
Tomcat to pick a new certificate. The administrator either has to
restart Tomcat (bad in a production environment) or do some JMX tricks
[1] (but JMX must be enabled and secured properly).

I'm wondering if it would be possible for Tomcat to monitor the
certificates/keystore files and reload the associated connectors
automatically? If there is a consensus on this feature I'd be interested
in implementing it.

Emmanuel Bourg

[1]
http://serverfault.com/questions/328533/can-tomcat-reload-its-ssl-certificate-without-being-restarted


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60490] Several improvements to the ErrorReportValve

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60490

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Mark Thomas  ---
Thanks for the patch.

Fixed in:
- trunk for 9.0.0.M18 onwards
- 8.5.x for 8.5.12 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1779898 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/valves/ test/org/apache/catalina/valves/ webapps/docs/

2017-01-23 Thread markt

Author: markt
Date: Mon Jan 23 09:50:09 2017
New Revision: 1779898

URL: http://svn.apache.org/viewvc?rev=1779898&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60490
Format improvements to ErrorReportValve
Patch by Michael Osipov

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/ErrorReportValve.java
tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/LocalStrings.properties

tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/LocalStrings_es.properties

tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/LocalStrings_fr.properties

tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/LocalStrings_ja.properties

tomcat/tc8.5.x/trunk/test/org/apache/catalina/valves/TestErrorReportValve.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jan 23 09:50:09 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,17

[Bug 60613] getting Maximum code footprint error after upgrade to Tomcat 8.5.11

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60613

--- Comment #5 from M. Manna  ---
Thanks - But isn't this going to cause quite a lot of Legacy systems to be
broken? Or do you expect developers to use the older versions of Tomcat?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1779897 - /tomcat/trunk/webapps/docs/changelog.xml

2017-01-23 Thread markt

Author: markt
Date: Mon Jan 23 09:45:04 2017
New Revision: 1779897

URL: http://svn.apache.org/viewvc?rev=1779897&view=rev
Log:
Update changelog

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1779897&r1=1779896&r2=1779897&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Jan 23 09:45:04 2017
@@ -47,6 +47,10 @@
 
   
 
+  
+60490: Various formatting and layout improvements for the
+ErrorReportValve. Patch provided by Michael Osipov. 
(markt)
+  
   
 60596: Improve performance of DefaultServlet when sendfile
 feature is disabled on connector. (kkolinko)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60613] getting Maximum code footprint error after upgrade to Tomcat 8.5.11

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60613

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #4 from Mark Thomas  ---
There is no bug here.

The code generated for JSPs got longer as additional error handling had to be
added to tags. JSps that use a lot of tags and/or were close to the limit are
likely to need to be refactored to bring them under the limit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Memory leak found in java.util.concurrent.ForkJoinPool

2017-01-23 Thread Rory O'Donnell




On 21/01/2017 16:56, Mark Thomas wrote:

On 21/01/2017 09:31, Konstantin Kolinko wrote:

2017-01-09 23:58 GMT+03:00 Mark Thomas :

All,

As a result of a thread on the users list, a memory leak has been
discovered in java.util.concurrent.ForkJoinPool.commonPool. It appears
that use of this pool is hard-coded in multiple places such as
Collection.parallelStream().forEach().

I have some ideas about how to work-around the leaks with
JreMemoryLeakPreventionListener but any code that depends on the Tomcat
class loader being set (e.g. JNDI lookup) is going to break if the user
tries to use Collection.parallelStream().


Rory,

The review Id for my report is 9046841. Anything you can do to get this
accepted and in front of the right folks to fix it would be appreciated.

Mark this bug is already under investigation!

By the way, JDK-8163449 - Allow per protocol setting for URLConnection 
defaultUseCaches

is included in b153, now available on java.net.

Rgds,Rory


Kind regards,
Mark

Hi!

I filed this into Tomcat Bugzilla, to keep track of our workaround code
https://bz.apache.org/bugzilla/show_bug.cgi?id=60620


As for Oracle bug number, I do not see this issue with a quick search
at http://bugs.java.com/

The review ID does not get re-used as the bug number. The bug, as
references in the Javadoc in JreMemoryLeakPreventionListener, is:
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8172726

Mark


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60613] getting Maximum code footprint error after upgrade to Tomcat 8.5.11

2017-01-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60613

--- Comment #3 from M. Manna  ---
Also found the same problem when downgraded to 8.0.39. Hence, downgrading to
8.0.29. I am not facing the issue anymore with 8.0.29. Could someone please let
me know if a bugfix will be done on 8.5.11?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1779674 - /tomcat/native/trunk/native/configure.in

2017-01-23 Thread Emmanuel Bourg

Hi Konstantin,

Le 21/01/2017 à 08:58, Konstantin Kolinko a écrit :

> 1. Please update xdocs/miscellaneous/changelog.xml   as well.

Thanks I didn't see it.


> 2. I see that other "able-" flags use AS_HELP_STRING() macro to format
> help string.
> 
> Maybe use it here as well?

I got a look and they seem fine since they already use ${enableval}.


> 3. Don't forget to add youself to the list at Tomcat site
> http://tomcat.apache.org/whoweare.html
> 
> See README.txt in the site source directory,
> https://svn.apache.org/repos/asf/tomcat/site/trunk/

Done.

Thank you for the review.

Emmanuel Bourg


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1779891 - /tomcat/site/trunk/xdocs/whoweare.xml

2017-01-23 Thread ebourg

Author: ebourg
Date: Mon Jan 23 08:28:34 2017
New Revision: 1779891

URL: http://svn.apache.org/viewvc?rev=1779891&view=rev
Log:
Added myself to the list of committers

Modified:
tomcat/site/trunk/xdocs/whoweare.xml

Modified: tomcat/site/trunk/xdocs/whoweare.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whoweare.xml?rev=1779891&r1=1779890&r2=1779891&view=diff
==
--- tomcat/site/trunk/xdocs/whoweare.xml (original)
+++ tomcat/site/trunk/xdocs/whoweare.xml Mon Jan 23 08:28:34 2017
@@ -57,6 +57,9 @@ A complete list of all the Apache Commit
 Ognjen BlagojeviÄ (ognjen at apache.org)
 
 
+Emmanuel Bourg (ebourg at apache.org)
+
+
 Jeremy Boynes (jboynes at apache.org)
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1779890 - /tomcat/native/trunk/xdocs/miscellaneous/changelog.xml

2017-01-23 Thread ebourg

Author: ebourg
Date: Mon Jan 23 07:59:54 2017
New Revision: 1779890

URL: http://svn.apache.org/viewvc?rev=1779890&view=rev
Log:
Changelog update

Modified:
tomcat/native/trunk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/native/trunk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/native/trunk/xdocs/miscellaneous/changelog.xml?rev=1779890&r1=1779889&r2=1779890&view=diff
==
--- tomcat/native/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/native/trunk/xdocs/miscellaneous/changelog.xml Mon Jan 23 07:59:54 
2017
@@ -36,6 +36,10 @@
 
 
   
+
+  The --disable-maintainer-mode option of the configure script no longer
+  enables the maintainer mode. (ebourg)
+
   
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

60 matches

Mail list logo