date:20170208

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

2017-02-08 Thread Bill Barker

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-nio2 :  Tomcat 8.x, a web server implementing the 
Java Servlet 3.1,
...


Full details are available at:

http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 19 mins 13 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dexecute.test.nio2=true -Dtest.temp=output/test-tmp-NIO2 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dtest.accesslog=true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.6-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170209.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20170209/bin/openssl
 -Dexecute.test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dexecute.test.apr=false -Dexecute.test.bio=false 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170209-native-src.tar.gz
 -Dtest.repor
 ts=output/logs-NIO2 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170209-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-8.0.x/true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-8.0.x/outpu

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

2017-02-08 Thread Bill Barker

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-validate has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-validate :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-validate.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 19 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20170209.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.4-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.6-SNAPSHOT.jar
 
:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20170209.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20170209.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-22.0-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-8.0.x/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-8.0.x/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-8.0.x/output/build/temp

compile-prepare:

download-validate:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar

setproxy:

downloadfile:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-8.0.x/output/res/checkstyle
[checkstyle] Running Checkstyle 7.6-SNAPSHOT on 3016 files
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-8.0.x/java/org/apache/tomcat/util/http/parser/HttpParser.java:25:
 Extra separation in import group before 
'org.apache.tomcat.util.res.StringManager' [ImportOrder]

BUILD FAILED
/srv/gump/public/workspace/tomcat-8.0.x/build.xml:552: Got 1 errors and 0 
warnings.

Total time: 19 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/rss.xml
- Atom: 
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 20170209060011, vmgump-vm3.apache.org:vmgump:20170209060011
Gump E-mail Identifier (unique within run) #3.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump-vm3]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2017-02-08 Thread Bill Barker

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc7.0.x-validate has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-validate :  Tomcat 7.x, a web server implementing Java 
Servlet 3.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-validate.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 16 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-build-libs 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20170209.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.4-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.6-SNAPSHOT.jar
 
:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20170209.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20170209.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-22.0-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-7.0.x/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-7.0.x/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-7.0.x/output/build/temp

compile-prepare:

download-validate:

proxyflags:

setproxy:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar

downloadfile:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle
[checkstyle] Running Checkstyle 7.6-SNAPSHOT on 2653 files
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-7.0.x/java/org/apache/tomcat/util/http/parser/HttpParser.java:29:
 Extra separation in import group before 
'org.apache.tomcat.util.res.StringManager' [ImportOrder]

BUILD FAILED
/srv/gump/public/workspace/tomcat-7.0.x/build.xml:535: Got 1 errors and 0 
warnings.

Total time: 16 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/rss.xml
- Atom: 
http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 20170209060011, vmgump-vm3.apache.org:vmgump:20170209060011
Gump E-mail Identifier (unique within run) #2.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump-vm3]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

2017-02-08 Thread Bill Barker

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-validate has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 7 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-validate :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-validate.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 18 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20170209.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.4-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.6-SNAPSHOT.jar
 
:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20170209.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20170209.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-22.0-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-8.0.x/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-8.0.x/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-8.0.x/output/build/temp

compile-prepare:

download-validate:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar

setproxy:

downloadfile:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-8.0.x/output/res/checkstyle
[checkstyle] Running Checkstyle 7.6-SNAPSHOT on 3016 files
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-8.0.x/java/org/apache/tomcat/util/http/parser/HttpParser.java:25:
 Extra separation in import group before 
'org.apache.tomcat.util.res.StringManager' [ImportOrder]

BUILD FAILED
/srv/gump/public/workspace/tomcat-8.0.x/build.xml:552: Got 1 errors and 0 
warnings.

Total time: 18 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/rss.xml
- Atom: 
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 2017020905, vmgump-vm3.apache.org:vmgump:2017020905
Gump E-mail Identifier (unique within run) #7.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump-vm3]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2017-02-08 Thread Bill Barker

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc7.0.x-validate has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 7 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-validate :  Tomcat 7.x, a web server implementing Java 
Servlet 3.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-validate.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-build-libs 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20170209.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.4-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.6-SNAPSHOT.jar
 
:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20170209.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20170209.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-22.0-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-7.0.x/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-7.0.x/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-7.0.x/output/build/temp

compile-prepare:

download-validate:

proxyflags:

setproxy:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-7.6-SNAPSHOT.jar

downloadfile:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle
[checkstyle] Running Checkstyle 7.6-SNAPSHOT on 2653 files
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-7.0.x/java/org/apache/tomcat/util/http/parser/HttpParser.java:29:
 Extra separation in import group before 
'org.apache.tomcat.util.res.StringManager' [ImportOrder]

BUILD FAILED
/srv/gump/public/workspace/tomcat-7.0.x/build.xml:535: Got 1 errors and 0 
warnings.

Total time: 17 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/rss.xml
- Atom: 
http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 2017020905, vmgump-vm3.apache.org:vmgump:2017020905
Gump E-mail Identifier (unique within run) #6.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump-vm3]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.11

2017-02-08 Thread Mark Thomas


On 07/02/17 20:30, Mark Thomas wrote:

Version 1.2.10 includes the following change:

- Update minimum recommended OpenSSL version to 1.0.2k
- Windows binaries built with OpenSSL 1.0.2k
- Better documentation for building on Windows
  (including with FIPS enabled OpenSSL)

The proposed release artefacts can be found at [1],
and the build was done using tag [2].

The Apache Tomcat Native 1.2.11 is
 [ ] Stable, go ahead and release
 [X] Broken because of ...


I'm seeing intermittent crashes in the in the unit tests on Windows.

As far as I can tell it is caused by the following:
- test 1 ends
- test 1 shuts down APR
- not all test 1 threads complete
- test 2 starts
- remaining test 1 threads complete
- remaining test 1 threads try to clean up thread-local memory
- crash as this memory was cleaned-up when APR for test 1 was shut down

Liberal use of #if to remove all references to APR thread locals for the 
Windows code and calling the OpenSSL clean-up directly seems to fix it.


I am therefore cancelling this release vote.

I should have a new RC ready in ~ 12 hours.

Sorry for not spotting the problem sooner.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Fwd: ApacheCon Jwala talk

2017-02-08 Thread Mark Thomas


On 08/02/17 22:12, Christopher Schultz wrote:

All,

One of our community members will be submitting this proposal. Also,
they are interested in potentially incubating their product at the ASF.

I think this makes a lot of sense to add to the list of presentations
for TomcatCon.


Big +1

Mark




Thanks,
-chris

 Forwarded Message 
Subject:ApacheCon Jwala talk
Date:   Tue, 7 Feb 2017 23:45:46 +
From:   Ger,Steven 
To: Christopher Schultz 



About to submit this but wanted to run it by you first.  What do you think?


/(We renamed TOC, Tomcat Operations Center, to Jwala in honor of our
internal release name … and thought it was catchy.  It’s Hindi for blaze.)/


*Steven Ger Bio*


A proud graduate of Penn State University, Steven Ger has close to two
decades of experience developing and orchestrating software for a
variety of organizations in the Telecom and Healthcare sectors. His
software contributions have scaled to benefit companies of all sizes,
from small startups to global enterprises, and everything in between. In
addition to extensive knowledge of the Java/JEE stack and all things
related, Steven is known for his entrepreneurial vision and drive to
rapidly deliver software that addresses market opportunities in a
creative, reliable, secure, and flexible manner. Steven is a Software
Architect with Cerner Corporation focusing on enterprise lightweight
open-source solutions.  He was instrumental in developing Jwala, a
Cerner open-source platform based on configuration and management of
large Apache Tomcat and Apache HTTPD topologies.


*Jwala*


Apache Tomcat (Tomcat) and Apache HTTPD are hardened, scalable, and
reliable open-source solutions. Widely adopted, these solutions are
commonly used to host and load-balance Java applications.

Configuring and managing a small set of these is relatively easy, but
once you start scaling out your application and platform, things get
complicated.  Questions such as “How do I update the heap or database
pool-size across hundreds of Tomcat JVMs?” arise. Although commercial
solutions exist to solve this and similar problems, an open-source
solution was not available, until Jwala was created.

Jwala is an application that enables the configuration, deployment, and
management of logical groups of Tomcat JVMs fronted by Apache web
servers.  It was designed and developed to accommodate Cerner’s complex
topologies. Cerner has donated Jwala to the open-source community to
help others with the same needs.


In this session, you will learn how to use Jwala to manage your large
Apache Tomcat/Apache HTTPD topology. We’ll dive deep into best practices
and proven techniques to use Jwala to configure, deploy, and manage your
topology at an enterprise scale.


*Target Audience*

The target audience for this session is anyone with Tomcat and Apache
HTTPD experience looking for an easier way to configure and manage a
large topology. Anyone in development, operations, or management will
benefit from using Jwala.



*Steven Ger *|** Knowledge Architect | steven@cerner.com
 | 404-353-4977 | www.cerner.com



CONFIDENTIALITY NOTICE This message and any included attachments are
from Cerner Corporation and are intended only for the addressee. The
information contained in this message is confidential and may constitute
inside or non-public information under international, federal, or state
securities laws. Unauthorized forwarding, printing, copying,
distribution, or use of such information is strictly prohibited and may
be unlawful. If you are not the addressee, please promptly delete this
message and notify the sender of the delivery error by e-mail or you may
call Cerner's corporate offices in Kansas City, Missouri, U.S.A at (+1)
(816)221-1024.





-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Fwd: ApacheCon Jwala talk

2017-02-08 Thread Christopher Schultz

All,

One of our community members will be submitting this proposal. Also,
they are interested in potentially incubating their product at the ASF.

I think this makes a lot of sense to add to the list of presentations
for TomcatCon.

Thanks,
-chris

 Forwarded Message 
Subject:ApacheCon Jwala talk
Date:   Tue, 7 Feb 2017 23:45:46 +
From:   Ger,Steven 
To: Christopher Schultz 



About to submit this but wanted to run it by you first.  What do you think?


/(We renamed TOC, Tomcat Operations Center, to Jwala in honor of our
internal release name … and thought it was catchy.  It’s Hindi for blaze.)/


*Steven Ger Bio*


A proud graduate of Penn State University, Steven Ger has close to two
decades of experience developing and orchestrating software for a
variety of organizations in the Telecom and Healthcare sectors. His
software contributions have scaled to benefit companies of all sizes,
from small startups to global enterprises, and everything in between. In
addition to extensive knowledge of the Java/JEE stack and all things
related, Steven is known for his entrepreneurial vision and drive to
rapidly deliver software that addresses market opportunities in a
creative, reliable, secure, and flexible manner. Steven is a Software
Architect with Cerner Corporation focusing on enterprise lightweight
open-source solutions.  He was instrumental in developing Jwala, a
Cerner open-source platform based on configuration and management of
large Apache Tomcat and Apache HTTPD topologies.


*Jwala*


Apache Tomcat (Tomcat) and Apache HTTPD are hardened, scalable, and
reliable open-source solutions. Widely adopted, these solutions are
commonly used to host and load-balance Java applications.

Configuring and managing a small set of these is relatively easy, but
once you start scaling out your application and platform, things get
complicated.  Questions such as “How do I update the heap or database
pool-size across hundreds of Tomcat JVMs?” arise. Although commercial
solutions exist to solve this and similar problems, an open-source
solution was not available, until Jwala was created.

Jwala is an application that enables the configuration, deployment, and
management of logical groups of Tomcat JVMs fronted by Apache web
servers.  It was designed and developed to accommodate Cerner’s complex
topologies. Cerner has donated Jwala to the open-source community to
help others with the same needs.


In this session, you will learn how to use Jwala to manage your large
Apache Tomcat/Apache HTTPD topology. We’ll dive deep into best practices
and proven techniques to use Jwala to configure, deploy, and manage your
topology at an enterprise scale.


*Target Audience*

The target audience for this session is anyone with Tomcat and Apache
HTTPD experience looking for an easier way to configure and manage a
large topology. Anyone in development, operations, or management will
benefit from using Jwala.



*Steven Ger *|** Knowledge Architect | steven@cerner.com
 | 404-353-4977 | www.cerner.com



CONFIDENTIALITY NOTICE This message and any included attachments are
from Cerner Corporation and are intended only for the addressee. The
information contained in this message is confidential and may constitute
inside or non-public information under international, federal, or state
securities laws. Unauthorized forwarding, printing, copying,
distribution, or use of such information is strictly prohibited and may
be unlawful. If you are not the addressee, please promptly delete this
message and notify the sender of the delivery error by e-mail or you may
call Cerner's corporate offices in Kansas City, Missouri, U.S.A at (+1)
(816)221-1024.




signature.asc
Description: OpenPGP digital signature

svn commit: r1782246 - in /tomcat/tc7.0.x/trunk: ./ conf/catalina.properties java/org/apache/tomcat/util/http/parser/HttpParser.java java/org/apache/tomcat/util/http/parser/LocalStrings.properties web

2017-02-08 Thread csutherl

Author: csutherl
Date: Wed Feb  8 19:57:41 2017
New Revision: 1782246

URL: http://svn.apache.org/viewvc?rev=1782246&view=rev
Log:
Followup commit for r1782037, adding warnings and StringManager

Added:

tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/parser/LocalStrings.properties
Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/conf/catalina.properties
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
tomcat/tc7.0.x/trunk/webapps/docs/config/systemprops.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Feb  8 19:57:41 2017
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702
 
742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1
 
726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330
-/tomcat/tc8.5.x/trunk:1735579,1736839,1737199,1737966,1738042,1738044,1738162,1738165,1738178,1739157,1739173,1739177,1739476,1740132,1740521,1740536,1740804,1740811,1740981,1741165,1741174,1741182,1741191,1741203,1741209,1741226,1741233,1741410,1742277,1743118,1743126,1743139-1743140,1743718,1743722,1743724,1744059,1744127,1744151,1744232,1744377,1744687,1744698,1744706,1745228,1746940,1748548,1748716,1749288,1749375,1749668-1749669,1750016,1750057,1750976,17

Re: svn commit: r1782037 - in /tomcat/tc8.5.x/trunk: conf/catalina.properties java/org/apache/tomcat/util/http/parser/HttpParser.java webapps/docs/changelog.xml webapps/docs/config/systemprops.xml

2017-02-08 Thread Coty Sutherland

> LGTM. Thanks for seeing this through.

Awesome, no problem :)

On Wed, Feb 8, 2017 at 2:46 PM, Mark Thomas  wrote:
> On 08/02/17 19:42, Coty Sutherland wrote:
>>
>> Thanks for the suggestions; I implemented them in
>> http://svn.apache.org/r1782240
>
>
> LGTM. Thanks for seeing this through.
>
> Mark
>
>
>
>>
>> On Tue, Feb 7, 2017 at 7:13 PM, Mark Thomas  wrote:
>>>
>>> On 07/02/17 18:13, csuth...@apache.org wrote:


 Author: csutherl
 Date: Tue Feb  7 18:13:40 2017
 New Revision: 1782037

 URL: http://svn.apache.org/viewvc?rev=1782037&view=rev
 Log:
 Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60594
 Adding implementation of whitelist patch

 Modified:
 tomcat/tc8.5.x/trunk/conf/catalina.properties


 tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
 tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
 tomcat/tc8.5.x/trunk/webapps/docs/config/systemprops.xml

 Modified: tomcat/tc8.5.x/trunk/conf/catalina.properties
 URL:

 http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/conf/catalina.properties?rev=1782037&r1=1782036&r2=1782037&view=diff


 ==
 --- tomcat/tc8.5.x/trunk/conf/catalina.properties (original)
 +++ tomcat/tc8.5.x/trunk/conf/catalina.properties Tue Feb  7 18:13:40
 2017
 @@ -146,3 +146,6 @@ tomcat.util.buf.StringCache.byte.enabled
  #tomcat.util.buf.StringCache.char.enabled=true
  #tomcat.util.buf.StringCache.trainThreshold=50
  #tomcat.util.buf.StringCache.cacheSize=5000
 +
 +# Allow for changes to HTTP request validation
>>>
>>>
>>>
>>> I'd add here:
>>>
>>> # WARNING: Using this option will expose the server to CVE-2016-6816
>>>
>>>
 +#tomcat.util.http.parser.HttpParser.requestTargetAllow=|

 Modified:

 tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
 URL:

 http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java?rev=1782037&r1=1782036&r2=1782037&view=diff


 ==
 ---

 tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
 (original)
 +++

 tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
 Tue Feb  7 18:13:40 2017
 @@ -19,6 +19,9 @@ package org.apache.tomcat.util.http.pars
  import java.io.IOException;
  import java.io.StringReader;

 +import org.apache.juli.logging.Log;
 +import org.apache.juli.logging.LogFactory;
 +
  /**
   * HTTP header value parser implementation. Parsing HTTP headers as per
 RFC2616
   * is not always as simple as it first appears. For headers that only
 use
 tokens
 @@ -34,6 +37,8 @@ import java.io.StringReader;
   */
  public class HttpParser {

 +private static final Log log = LogFactory.getLog(HttpParser.class);
 +
  private static final int ARRAY_SIZE = 128;

  private static final boolean[] IS_CONTROL = new
 boolean[ARRAY_SIZE];
 @@ -42,8 +47,22 @@ public class HttpParser {
  private static final boolean[] IS_HEX = new boolean[ARRAY_SIZE];
  private static final boolean[] IS_NOT_REQUEST_TARGET = new
 boolean[ARRAY_SIZE];
  private static final boolean[] IS_HTTP_PROTOCOL = new
 boolean[ARRAY_SIZE];
 +private static final boolean[] REQUEST_TARGET_ALLOW = new
 boolean[ARRAY_SIZE];

  static {
 +String prop =

 System.getProperty("tomcat.util.http.parser.HttpParser.requestTargetAllow");
 +if (prop != null) {
 +for (int i = 0; i < prop.length(); i++) {
 +char c = prop.charAt(i);
 +if (c == '{' || c == '}' || c == '|') {
 +REQUEST_TARGET_ALLOW[c] = true;
 +} else {
 +log.warn("HttpParser: Character '" + c + "' is not
 allowed and will continue "
 ++ "being rejected.");
>>>
>>>
>>>
>>> This should use the StringManager for i18n support.
>>>
>>> Also "... will continue to be rejected." sounds better.
>>>
>>>
 +}
 +}
 +}
 +
  for (int i = 0; i < ARRAY_SIZE; i++) {
  // Control> 0-31, 127
  if (i < 32 || i == 127) {
 @@ -74,7 +93,9 @@ public class HttpParser {
  if (IS_CONTROL[i] || i > 127 ||
  i == ' ' || i == '\"' || i == '#' || i == '<' || i
 ==
 '>' || i == '\\' ||
  i == '^' || i == '`'  || i == '{' || i == '|' || i
 ==
 '}') {
 -IS_NOT_REQUEST_TARGET[i] = true;
 +if

Re: svn commit: r1782037 - in /tomcat/tc8.5.x/trunk: conf/catalina.properties java/org/apache/tomcat/util/http/parser/HttpParser.java webapps/docs/changelog.xml webapps/docs/config/systemprops.xml

2017-02-08 Thread Mark Thomas


On 08/02/17 19:42, Coty Sutherland wrote:

Thanks for the suggestions; I implemented them in http://svn.apache.org/r1782240


LGTM. Thanks for seeing this through.

Mark




On Tue, Feb 7, 2017 at 7:13 PM, Mark Thomas  wrote:

On 07/02/17 18:13, csuth...@apache.org wrote:


Author: csutherl
Date: Tue Feb  7 18:13:40 2017
New Revision: 1782037

URL: http://svn.apache.org/viewvc?rev=1782037&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60594
Adding implementation of whitelist patch

Modified:
tomcat/tc8.5.x/trunk/conf/catalina.properties

tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.5.x/trunk/webapps/docs/config/systemprops.xml

Modified: tomcat/tc8.5.x/trunk/conf/catalina.properties
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/conf/catalina.properties?rev=1782037&r1=1782036&r2=1782037&view=diff

==
--- tomcat/tc8.5.x/trunk/conf/catalina.properties (original)
+++ tomcat/tc8.5.x/trunk/conf/catalina.properties Tue Feb  7 18:13:40 2017
@@ -146,3 +146,6 @@ tomcat.util.buf.StringCache.byte.enabled
 #tomcat.util.buf.StringCache.char.enabled=true
 #tomcat.util.buf.StringCache.trainThreshold=50
 #tomcat.util.buf.StringCache.cacheSize=5000
+
+# Allow for changes to HTTP request validation



I'd add here:

# WARNING: Using this option will expose the server to CVE-2016-6816



+#tomcat.util.http.parser.HttpParser.requestTargetAllow=|

Modified:
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java?rev=1782037&r1=1782036&r2=1782037&view=diff

==
---
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
(original)
+++
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
Tue Feb  7 18:13:40 2017
@@ -19,6 +19,9 @@ package org.apache.tomcat.util.http.pars
 import java.io.IOException;
 import java.io.StringReader;

+import org.apache.juli.logging.Log;
+import org.apache.juli.logging.LogFactory;
+
 /**
  * HTTP header value parser implementation. Parsing HTTP headers as per
RFC2616
  * is not always as simple as it first appears. For headers that only use
tokens
@@ -34,6 +37,8 @@ import java.io.StringReader;
  */
 public class HttpParser {

+private static final Log log = LogFactory.getLog(HttpParser.class);
+
 private static final int ARRAY_SIZE = 128;

 private static final boolean[] IS_CONTROL = new boolean[ARRAY_SIZE];
@@ -42,8 +47,22 @@ public class HttpParser {
 private static final boolean[] IS_HEX = new boolean[ARRAY_SIZE];
 private static final boolean[] IS_NOT_REQUEST_TARGET = new
boolean[ARRAY_SIZE];
 private static final boolean[] IS_HTTP_PROTOCOL = new
boolean[ARRAY_SIZE];
+private static final boolean[] REQUEST_TARGET_ALLOW = new
boolean[ARRAY_SIZE];

 static {
+String prop =
System.getProperty("tomcat.util.http.parser.HttpParser.requestTargetAllow");
+if (prop != null) {
+for (int i = 0; i < prop.length(); i++) {
+char c = prop.charAt(i);
+if (c == '{' || c == '}' || c == '|') {
+REQUEST_TARGET_ALLOW[c] = true;
+} else {
+log.warn("HttpParser: Character '" + c + "' is not
allowed and will continue "
++ "being rejected.");



This should use the StringManager for i18n support.

Also "... will continue to be rejected." sounds better.



+}
+}
+}
+
 for (int i = 0; i < ARRAY_SIZE; i++) {
 // Control> 0-31, 127
 if (i < 32 || i == 127) {
@@ -74,7 +93,9 @@ public class HttpParser {
 if (IS_CONTROL[i] || i > 127 ||
 i == ' ' || i == '\"' || i == '#' || i == '<' || i ==
'>' || i == '\\' ||
 i == '^' || i == '`'  || i == '{' || i == '|' || i ==
'}') {
-IS_NOT_REQUEST_TARGET[i] = true;
+if (!REQUEST_TARGET_ALLOW[i]) {
+IS_NOT_REQUEST_TARGET[i] = true;
+}
 }

 // Not valid for HTTP protocol

Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1782037&r1=1782036&r2=1782037&view=diff

==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Tue Feb  7 18:13:40
2017
@@ -103,6 +103,12 @@
 Ensure that executor thread pools used with connectors, pre-start
the
 configured minimum number of idle threads. (markt)
   
+  
+60594: Allow

svn commit: r1782243 - in /tomcat/tc8.0.x/trunk: ./ conf/catalina.properties java/org/apache/tomcat/util/http/parser/HttpParser.java java/org/apache/tomcat/util/http/parser/LocalStrings.properties web

2017-02-08 Thread csutherl

Author: csutherl
Date: Wed Feb  8 19:43:59 2017
New Revision: 1782243

URL: http://svn.apache.org/viewvc?rev=1782243&view=rev
Log:
Followup commit for r1782037, adding warnings and StringManager

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/conf/catalina.properties
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java

tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/http/parser/LocalStrings.properties
tomcat/tc8.0.x/trunk/webapps/docs/config/systemprops.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Feb  8 19:43:59 2017
@@ -1,2 +1,2 @@
-/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037
+/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240
 
/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,16

Re: svn commit: r1782037 - in /tomcat/tc8.5.x/trunk: conf/catalina.properties java/org/apache/tomcat/util/http/parser/HttpParser.java webapps/docs/changelog.xml webapps/docs/config/systemprops.xml

2017-02-08 Thread Coty Sutherland

Thanks for the suggestions; I implemented them in http://svn.apache.org/r1782240

On Tue, Feb 7, 2017 at 7:13 PM, Mark Thomas  wrote:
> On 07/02/17 18:13, csuth...@apache.org wrote:
>>
>> Author: csutherl
>> Date: Tue Feb  7 18:13:40 2017
>> New Revision: 1782037
>>
>> URL: http://svn.apache.org/viewvc?rev=1782037&view=rev
>> Log:
>> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60594
>> Adding implementation of whitelist patch
>>
>> Modified:
>> tomcat/tc8.5.x/trunk/conf/catalina.properties
>>
>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
>> tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
>> tomcat/tc8.5.x/trunk/webapps/docs/config/systemprops.xml
>>
>> Modified: tomcat/tc8.5.x/trunk/conf/catalina.properties
>> URL:
>> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/conf/catalina.properties?rev=1782037&r1=1782036&r2=1782037&view=diff
>>
>> ==
>> --- tomcat/tc8.5.x/trunk/conf/catalina.properties (original)
>> +++ tomcat/tc8.5.x/trunk/conf/catalina.properties Tue Feb  7 18:13:40 2017
>> @@ -146,3 +146,6 @@ tomcat.util.buf.StringCache.byte.enabled
>>  #tomcat.util.buf.StringCache.char.enabled=true
>>  #tomcat.util.buf.StringCache.trainThreshold=50
>>  #tomcat.util.buf.StringCache.cacheSize=5000
>> +
>> +# Allow for changes to HTTP request validation
>
>
> I'd add here:
>
> # WARNING: Using this option will expose the server to CVE-2016-6816
>
>
>> +#tomcat.util.http.parser.HttpParser.requestTargetAllow=|
>>
>> Modified:
>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
>> URL:
>> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java?rev=1782037&r1=1782036&r2=1782037&view=diff
>>
>> ==
>> ---
>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
>> (original)
>> +++
>> tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
>> Tue Feb  7 18:13:40 2017
>> @@ -19,6 +19,9 @@ package org.apache.tomcat.util.http.pars
>>  import java.io.IOException;
>>  import java.io.StringReader;
>>
>> +import org.apache.juli.logging.Log;
>> +import org.apache.juli.logging.LogFactory;
>> +
>>  /**
>>   * HTTP header value parser implementation. Parsing HTTP headers as per
>> RFC2616
>>   * is not always as simple as it first appears. For headers that only use
>> tokens
>> @@ -34,6 +37,8 @@ import java.io.StringReader;
>>   */
>>  public class HttpParser {
>>
>> +private static final Log log = LogFactory.getLog(HttpParser.class);
>> +
>>  private static final int ARRAY_SIZE = 128;
>>
>>  private static final boolean[] IS_CONTROL = new boolean[ARRAY_SIZE];
>> @@ -42,8 +47,22 @@ public class HttpParser {
>>  private static final boolean[] IS_HEX = new boolean[ARRAY_SIZE];
>>  private static final boolean[] IS_NOT_REQUEST_TARGET = new
>> boolean[ARRAY_SIZE];
>>  private static final boolean[] IS_HTTP_PROTOCOL = new
>> boolean[ARRAY_SIZE];
>> +private static final boolean[] REQUEST_TARGET_ALLOW = new
>> boolean[ARRAY_SIZE];
>>
>>  static {
>> +String prop =
>> System.getProperty("tomcat.util.http.parser.HttpParser.requestTargetAllow");
>> +if (prop != null) {
>> +for (int i = 0; i < prop.length(); i++) {
>> +char c = prop.charAt(i);
>> +if (c == '{' || c == '}' || c == '|') {
>> +REQUEST_TARGET_ALLOW[c] = true;
>> +} else {
>> +log.warn("HttpParser: Character '" + c + "' is not
>> allowed and will continue "
>> ++ "being rejected.");
>
>
> This should use the StringManager for i18n support.
>
> Also "... will continue to be rejected." sounds better.
>
>
>> +}
>> +}
>> +}
>> +
>>  for (int i = 0; i < ARRAY_SIZE; i++) {
>>  // Control> 0-31, 127
>>  if (i < 32 || i == 127) {
>> @@ -74,7 +93,9 @@ public class HttpParser {
>>  if (IS_CONTROL[i] || i > 127 ||
>>  i == ' ' || i == '\"' || i == '#' || i == '<' || i ==
>> '>' || i == '\\' ||
>>  i == '^' || i == '`'  || i == '{' || i == '|' || i ==
>> '}') {
>> -IS_NOT_REQUEST_TARGET[i] = true;
>> +if (!REQUEST_TARGET_ALLOW[i]) {
>> +IS_NOT_REQUEST_TARGET[i] = true;
>> +}
>>  }
>>
>>  // Not valid for HTTP protocol
>>
>> Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
>> URL:
>> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1782037&r1=1782036&r2=1782037&view=diff
>>
>> ==
>> --- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
>> +++ tomcat/tc8.5.x/trunk/w

svn commit: r1782240 - in /tomcat/tc8.5.x/trunk: conf/catalina.properties java/org/apache/tomcat/util/http/parser/HttpParser.java java/org/apache/tomcat/util/http/parser/LocalStrings.properties webapp

2017-02-08 Thread csutherl

Author: csutherl
Date: Wed Feb  8 19:40:51 2017
New Revision: 1782240

URL: http://svn.apache.org/viewvc?rev=1782240&view=rev
Log:
Followup commit for r1782037, adding warnings and StringManager

Modified:
tomcat/tc8.5.x/trunk/conf/catalina.properties
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java

tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/LocalStrings.properties
tomcat/tc8.5.x/trunk/webapps/docs/config/systemprops.xml

Modified: tomcat/tc8.5.x/trunk/conf/catalina.properties
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/conf/catalina.properties?rev=1782240&r1=1782239&r2=1782240&view=diff
==
--- tomcat/tc8.5.x/trunk/conf/catalina.properties (original)
+++ tomcat/tc8.5.x/trunk/conf/catalina.properties Wed Feb  8 19:40:51 2017
@@ -148,4 +148,5 @@ tomcat.util.buf.StringCache.byte.enabled
 #tomcat.util.buf.StringCache.cacheSize=5000
 
 # Allow for changes to HTTP request validation
+# WARNING: Using this option will expose the server to CVE-2016-6816
 #tomcat.util.http.parser.HttpParser.requestTargetAllow=|

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java?rev=1782240&r1=1782239&r2=1782240&view=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java 
(original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/HttpParser.java 
Wed Feb  8 19:40:51 2017
@@ -22,6 +22,8 @@ import java.io.StringReader;
 import org.apache.juli.logging.Log;
 import org.apache.juli.logging.LogFactory;
 
+import org.apache.tomcat.util.res.StringManager;
+
 /**
  * HTTP header value parser implementation. Parsing HTTP headers as per RFC2616
  * is not always as simple as it first appears. For headers that only use 
tokens
@@ -37,6 +39,8 @@ import org.apache.juli.logging.LogFactor
  */
 public class HttpParser {
 
+private static final StringManager sm = 
StringManager.getManager(HttpParser.class);
+
 private static final Log log = LogFactory.getLog(HttpParser.class);
 
 private static final int ARRAY_SIZE = 128;
@@ -57,8 +61,7 @@ public class HttpParser {
 if (c == '{' || c == '}' || c == '|') {
 REQUEST_TARGET_ALLOW[c] = true;
 } else {
-log.warn("HttpParser: Character '" + c + "' is not allowed 
and will continue "
-+ "being rejected.");
+
log.warn(sm.getString("httpparser.invalidRequestTargetCharacter", c));
 }
 }
 }

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/LocalStrings.properties?rev=1782240&r1=1782239&r2=1782240&view=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/LocalStrings.properties
 (original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/http/parser/LocalStrings.properties
 Wed Feb  8 19:40:51 2017
@@ -17,4 +17,5 @@ authorization.unknownType=Unknown Type [
 cookie.fallToDebug=Note: further occurrences of this error will be logged at 
DEBUG level.
 cookie.invalidCookieValue=A cookie header was received [{0}] that contained an 
invalid cookie. That cookie will be ignored.
 cookie.invalidCookieVersion=A cookie header was received using an unrecognised 
cookie version of [{0}]. The header and the cookies it contains will be ignored.
-cookie.valueNotPresent=
\ No newline at end of file
+cookie.valueNotPresent=
+httpparser.invalidRequestTargetCharacter=Character [{0}] is not allowed and 
will continue to be rejected.

Modified: tomcat/tc8.5.x/trunk/webapps/docs/config/systemprops.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/config/systemprops.xml?rev=1782240&r1=1782239&r2=1782240&view=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/config/systemprops.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/config/systemprops.xml Wed Feb  8 
19:40:51 2017
@@ -644,6 +644,8 @@
   These characters would normally result in a 400 status.
   The acceptable characters for this property are: |, 
{
   , and }
+  WARNING: Use of this option will expose the server 
to CVE-2016-6816.
+  
   If not specified, the default value of null will be 
used.
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59317] AsyncContextImpl breaks request URL containing spaces

2017-02-08 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=59317

--- Comment #7 from Mark Thomas  ---
Potential regressions should be followed up on the users list in the first
instance and be accompanied by simple test cases (JSPs can be useful for this)
that demonstrate the problem. That will enable us to identify where the problem
lies.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.11

2017-02-08 Thread therealneworld

On Tue, Feb 7, 2017 at 3:30 PM, Mark Thomas  wrote:
> Version 1.2.10 includes the following change:
>
> - Update minimum recommended OpenSSL version to 1.0.2k
> - Windows binaries built with OpenSSL 1.0.2k
> - Better documentation for building on Windows
>   (including with FIPS enabled OpenSSL)
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.11 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...
>
> Thanks,
>
> Mark
>

Tested on Linux and works well for me.

-nate

>
> [1]
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.11/
> [2] https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_11
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59317] AsyncContextImpl breaks request URL containing spaces

2017-02-08 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=59317

--- Comment #6 from Nitin Kamate  ---
The change done for this issue caused regression in the webapp and We wan into
this of URL encoding. Few of the URLs that use : inside are getting encoded and
the server is unable to locate the resource anymore.

e.g. /data/parent:children/id is getting encoded as /data/parent%3Achildren/id.
Due to this the app does not locate the resources on v7.0.70 as it was doing
earlier. Is it possible to allow turning-off this URL-encoding to retain
previous behavior?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: AuthConfigProvider initialization while constructing the authenticator

2017-02-08 Thread Mark Thomas

On 07/02/17 21:54, Violeta Georgieva wrote:
> 2017-02-07 23:44 GMT+02:00 Mark Thomas :
>>
>> On 06/02/17 20:35, Violeta Georgieva wrote:
>>>
>>> Hi,
>>>
>>> With the current implementation if there is AuthConfigProvider we will
>>> initialize it once and then we will use it. However if such
>>> AuthConfigProvider is not available, on every request we will spend time
> in
>>> redundant search operation to find AuthConfigProvider that is not
> available.
>>>
>>> What do you think about moving AuthConfigProvider initialization while
>>> constructing the authenticator?
>>
>>
>> Won't that break web applications that initialize their own JASPIC
> configuration on web application start?
>
> :( most probably
>
>> If performance is a concern we could store a static constant NO-OP
>> AuthConfigProvider in jaspicProvider if no provider is available and then
>> check for that on subsequent calls and return null if we find it. That
>> should be marginally quicker than the repeating the lookup.
>
> +1

I've been looking into this along with re-reading parts of the JASPIC 
spec and the current implementation isn't quite right. The good news is 
that, with the correct implementation, the proposal above will work.

The bad news is that AuthConfigFactoryImpl is going to need some 
non-trivial surgery to get it working correctly.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2017-02-08 Thread Bill Barker

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-apr has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 mins 8 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Dtest.temp=output/test-tmp-APR 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dtest.accesslog=true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.6-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170208.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20170208/bin/openssl
 -Dexecute.test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dexecute.test.apr=true -Dexecute.test.nio2=false 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170208-native-src.tar.gz
 -Dtest.reports=output/logs-APR -Dtomc
 
at-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170208-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-trunk/dest-20170208/lib 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.

Re: AuthConfigProvider initialization while constructing the authenticator

2017-02-08 Thread Violeta Georgieva

2017-02-07 23:54 GMT+02:00 Violeta Georgieva :
>
>
>
> 2017-02-07 23:44 GMT+02:00 Mark Thomas :
> >
> > On 06/02/17 20:35, Violeta Georgieva wrote:
> >>
> >> Hi,
> >>
> >> With the current implementation if there is AuthConfigProvider we will
> >> initialize it once and then we will use it. However if such
> >> AuthConfigProvider is not available, on every request we will spend
time in
> >> redundant search operation to find AuthConfigProvider that is not
available.
> >>
> >> What do you think about moving AuthConfigProvider initialization while
> >> constructing the authenticator?
> >
> >
> > Won't that break web applications that initialize their own JASPIC
configuration on web application start?
>
> :( most probably
>
> > If performance is a concern we could store a static constant NO-OP
AuthConfigProvider in jaspicProvider if no provider is available and then
check for that on subsequent calls and return null if we find it. That
should be marginally quicker than the repeating the lookup.
>
> +1

What do you think about this approach?
https://github.com/apache/tomcat/pull/43

>
> Thanks,
> Violeta
>
> >
> > Mark
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>

[GitHub] tomcat pull request #43: Ensure a search for Jaspic Provider is performed on...

2017-02-08 Thread violetagg

GitHub user violetagg opened a pull request:

https://github.com/apache/tomcat/pull/43

Ensure a search for Jaspic Provider is performed only once.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/violetagg/tomcat 
jaspic-provider-initialization

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #43


commit 410611f1986f1d3aea1d687580e7c4d1f37fa3b6
Author: Violeta Georgieva 
Date:   2017-02-08T13:40:16Z

Ensure a search for Jaspic Provider is performed only once.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2017-02-08 Thread Bill Barker

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 mins 37 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.6-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170208-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170208.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170208-native-src
 .tar.gz -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true 
-Dexecute.test.nio=false 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20170208/bin/openssl
 -Dexecute.test.apr=false -Dtest.excludePerformance=true 
-Dexecute.test.nio2=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2017-02-08 Thread Bill Barker

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 mins 46 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.6-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170208-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170208.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170208-native-src.
 tar.gz -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true 
-Dexecute.test.nio=true 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20170208/bin/openssl
 -Dexecute.test.apr=false -Dtest.excludePerformance=true 
-Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.

Re: [VOTE] Release Apache Tomcat Native 1.2.11

2017-02-08 Thread Rémy Maucherat

2017-02-07 21:30 GMT+01:00 Mark Thomas :

> Version 1.2.10 includes the following change:
>
> - Update minimum recommended OpenSSL version to 1.0.2k
> - Windows binaries built with OpenSSL 1.0.2k
> - Better documentation for building on Windows
>   (including with FIPS enabled OpenSSL)
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.11 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...
>

Tested on Linux, where everything is always good, though.

Rémy

>
> Thanks,
>
> Mark
>
>
> [1]
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connect
> ors/native/1.2.11/
> [2] https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_N
> ATIVE_1_2_11
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

FINAL REMINDER: CFP for ApacheCon closes February 11th

2017-02-08 Thread Rich Bowen

Dear Apache Enthusiast,

This is your FINAL reminder that the Call for Papers (CFP) for ApacheCon
Miami is closing this weekend - February 11th. This is your final
opportunity to submit a talk for consideration at this event.

This year, we are running several mini conferences in conjunction with
the main event, so if you're submitting for one of those events, please
pay attention to the instructions below.

Apache: Big Data
* Event information:
http://events.linuxfoundation.org/events/apache-big-data-north-america
* CFP:
http://events.linuxfoundation.org/events/apache-big-data-north-america/program/cfp

Apache: IoT (Internet of Things)
* Event Information: http://us.apacheiot.org/
* CFP -
http://events.linuxfoundation.org/events/apachecon-north-america/program/cfp
(Indicate 'IoT' in the Target Audience field)

CloudStack Collaboration Conference
* Event information: http://us.cloudstackcollab.org/
* CFP -
http://events.linuxfoundation.org/events/apachecon-north-america/program/cfp
(Indicate 'CloudStack' in the Target Audience field)

FlexJS Summit
* Event information - http://us.apacheflexjs.org/
* CFP -
http://events.linuxfoundation.org/events/apachecon-north-america/program/cfp
(Indicate 'Flex' in the Target Audience field)

TomcatCon
* Event information - https://tomcat.apache.org/conference.html
* CFP -
http://events.linuxfoundation.org/events/apachecon-north-america/program/cfp
(Indicate 'Tomcat' in the Target Audience field)

All other topics and projects
* Event information -
http://events.linuxfoundation.org/events/apachecon-north-america/program/about
* CFP -
http://events.linuxfoundation.org/events/apachecon-north-america/program/cfp

Admission to any of these events also grants you access to all of the
others.

Thanks, and we look forward to seeing you in Miami!

-- 
Rich Bowen
VP Conferences, Apache Software Foundation
rbo...@apache.org
Twitter: @apachecon



(You are receiving this email because you are subscribed to a dev@ or
users@ list of some Apache Software Foundation project. If you do not
wish to receive email from these lists any more, you must follow that
list's unsubscription procedure. View the headers of this message for
unsubscription instructions.)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60698] getContentLength returns -1 for requests without body

2017-02-08 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60698

Remy Maucherat  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #3 from Remy Maucherat  ---
I researched a bit in other implementations, and at this point the result
reflects only the value of the content-length header.
Please do not reopen the report unless you get the Servlet EG to make an
explicit clarification about this behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread martin-g

Github user martin-g commented on a diff in the pull request:

https://github.com/apache/tomcat/pull/42#discussion_r100054233
  
--- Diff: java/org/apache/tomcat/websocket/WsFrameBase.java ---
@@ -687,6 +691,29 @@ protected Transformation getTransformation() {
 }
 
 
+@Override
+public void suspend() {
+if (!this.suspended.compareAndSet(false, true)) {
+getLog().warn("Message receiving has already been suspended.");
--- End diff --

Should this use StringManager ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60698] getContentLength returns -1 for requests without body

2017-02-08 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60698

Tobias Oberlies  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #2 from Tobias Oberlies  ---
> I think user code will have to check for the transfer-encoding header anyway

Why is that? Do servlets care about the framing of request bodies? I don't
think so. The HTTP standard even requires that the framing of the message body
(i.e. if transfer-encoding is used or content-length) must not have an
influence on the semantics: "Request message framing is independent of method
semantics" [1] So for most servlets, framing will not make a difference.

Similarly, most servlets will not care how the absence of a request body is
signaled. They will want to handle requests in the same way regardless of
whether the request has a content-length: 0 header or neither content-length
nor transfer-encoding header. So the servlet API should hide this detail by
returning 0 on getContentLenth() in both cases.

[1] https://tools.ietf.org/html/rfc7230#section-3.3

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.11

2017-02-08 Thread Violeta Georgieva

Hi,

2017-02-07 22:30 GMT+02:00 Mark Thomas :
>
> Version 1.2.10 includes the following change:
>
> - Update minimum recommended OpenSSL version to 1.0.2k
> - Windows binaries built with OpenSSL 1.0.2k
> - Better documentation for building on Windows
>   (including with FIPS enabled OpenSSL)
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.11 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...

OS Windows 7

Loaded APR based Apache Tomcat Native library 1.2.11 using APR version
1.5.2.
OpenSSL successfully initialized (OpenSSL 1.0.2k  26 Jan 2017)

Tomcat 6 trunk, APR tests, JDK jdk1.5.0_22 - successful
Tomcat 7 trunk, APR tests, JDK jdk1.6.0_45 - successful
Tomcat 8 trunk, APR tests, JDK jdk1.7.0_80 - successful
Tomcat 8.5 trunk, APR tests, JDK jdk1.7.0_80 - successful
Tomcat 9 trunk, APR tests, JDK jdk1.8.0_101 - successful

Regards,
Violeta

> Thanks,
>
> Mark
>
>
> [1]
>
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.11/
> [2]
https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_11
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: Read events suspend/resume logic in websocket impl to achieve backpressure

2017-02-08 Thread Violeta Georgieva

2017-02-08 1:51 GMT+02:00 Mark Thomas :

> On 06/02/17 19:55, Violeta Georgieva wrote:
>
>> Hi,
>>
>> Currently JSR356 provides possibility to add message handlers in order to
>> receive web socket
>> messages but there is no way to instruct the web socket implementation to
>> suspend for a while
>> the incoming messages (backpressure) so that the application is able to
>> process the already delivered messages.
>> The other web containers (Jetty, Undertow) supports such functionality so
>> I
>> would like to introduce it in Tomcat.
>> Here [1] I prepared one possible implementation.
>>
>> What do you think about this feature and the proposed implementation?
>>
>
> I suggest you go ahead and commit (and back-port) the formatting updates.
> They all look good and getting those out of the way will make the diff
> easier to read.
>

Formatting changes were committed.


>
> I'm currently undecided on this.
>
> I understand the requirement but rather than have proprietary methods
> added to various WebSocket implementations, I would have preferred to see a
> reactive wrapper provided for Java WebSocket that would have used
> Server->Client WebSocket messages to communicate back pressure to the
> client.
>
> However, that doesn't work if the aim is to feed 'uncontrolled' WebSocket
> clients into a reactive server side framework. Blocking is going to be only
> option to apply back-pressure and better to do that just on the client
> rather than on the client and the server - which means this feature is
> required in some form.
>
> I guess that makes me reluctantly in favour of it in principle but I'd
> very much prefer to review a patch proposal minus the reformatting.
>
>
There is a new patch
- no formatting noise
- Martin's comments included


> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: Read events suspend/resume logic in websocket impl to achieve backpressure

2017-02-08 Thread Rémy Maucherat

2017-02-08 0:51 GMT+01:00 Mark Thomas :

> On 06/02/17 19:55, Violeta Georgieva wrote:
>
>> Hi,
>>
>> Currently JSR356 provides possibility to add message handlers in order to
>> receive web socket
>> messages but there is no way to instruct the web socket implementation to
>> suspend for a while
>> the incoming messages (backpressure) so that the application is able to
>> process the already delivered messages.
>> The other web containers (Jetty, Undertow) supports such functionality so
>> I
>> would like to introduce it in Tomcat.
>> Here [1] I prepared one possible implementation.
>>
>> What do you think about this feature and the proposed implementation?
>>
>
> I suggest you go ahead and commit (and back-port) the formatting updates.
> They all look good and getting those out of the way will make the diff
> easier to read.
>
> I'm currently undecided on this.
>
> I understand the requirement but rather than have proprietary methods
> added to various WebSocket implementations, I would have preferred to see a
> reactive wrapper provided for Java WebSocket that would have used
> Server->Client WebSocket messages to communicate back pressure to the
> client.
>
> However, that doesn't work if the aim is to feed 'uncontrolled' WebSocket
> clients into a reactive server side framework. Blocking is going to be only
> option to apply back-pressure and better to do that just on the client
> rather than on the client and the server - which means this feature is
> required in some form.
>
> I guess that makes me reluctantly in favour of it in principle but I'd
> very much prefer to review a patch proposal minus the reformatting.
>
> This new solution says that it should be the network that takes care of
the congestion. Personally, I prefer thinking the application should
decouple its IO from the actual processing and take care of the backlog
itself. One example: with some APIs, we've noticed that when a server
disconnects or become unresponsive, they become notified with an error like
... Never. Or, even better, as you say, the server should send something to
the client to actually give it information, but it's all proprietary then
(client + server).

Overall, I don't really see the point of retrofitting this new stuff into
already old things like websockets, while HTTP/2 should have this server ->
client "control" capability (minus an actual API to use it from Servlets, I
guess).

If this is still included, I suppose you will make sure the performance
doesn't go down BTW.

Rémy

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg

Github user violetagg commented on a diff in the pull request:

https://github.com/apache/tomcat/pull/42#discussion_r100015643
  
--- Diff: test/org/apache/tomcat/websocket/TestWsSessionSuspendResume.java 
---
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.websocket;
+
+import java.io.IOException;
+import java.net.URI;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import javax.websocket.ClientEndpointConfig;
+import javax.websocket.CloseReason;
+import javax.websocket.ContainerProvider;
+import javax.websocket.Endpoint;
+import javax.websocket.EndpointConfig;
+import javax.websocket.Session;
+import javax.websocket.WebSocketContainer;
+import javax.websocket.server.ServerEndpointConfig;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import org.apache.catalina.Context;
+import org.apache.catalina.servlets.DefaultServlet;
+import org.apache.catalina.startup.Tomcat;
+import 
org.apache.tomcat.websocket.TesterMessageCountClient.TesterProgrammaticEndpoint;
+import org.apache.tomcat.websocket.server.TesterEndpointConfig;
+
+public class TestWsSessionSuspendResume extends WebSocketBaseTest {
+
+@Test
+public void test() throws Exception {
+Tomcat tomcat = getTomcatInstance();
+
+Context ctx = tomcat.addContext("", null);
+ctx.addApplicationListener(Config.class.getName());
+
+Tomcat.addServlet(ctx, "default", new DefaultServlet());
+ctx.addServletMappingDecoded("/", "default");
+
+tomcat.start();
+
+WebSocketContainer wsContainer = 
ContainerProvider.getWebSocketContainer();
+
+ClientEndpointConfig clientEndpointConfig = 
ClientEndpointConfig.Builder.create().build();
+Session wsSession = wsContainer.connectToServer(
+TesterProgrammaticEndpoint.class,
+clientEndpointConfig,
+new URI("ws://localhost:" + getPort() + Config.PATH));
+
+CountDownLatch latch = new CountDownLatch(2);
+wsSession.addMessageHandler(String.class, message -> {
+Assert.assertTrue("[echo, echo, echo]".equals(message));
+latch.countDown();
+});
+for (int i = 0; i < 8; i++) {
+wsSession.getAsyncRemote().sendText("echo");
+}
+
+boolean latchResult = latch.await(30, TimeUnit.SECONDS);
+Assert.assertTrue(latchResult);
+
+wsSession.close();
+}
+
+
+public static final class Config extends TesterEndpointConfig {
+private static final String PATH = "/echo";
+
+@Override
+protected Class getEndpointClass() {
+return SuspendResumeEndpoint.class;
+}
+
+@Override
+protected ServerEndpointConfig getServerEndpointConfig() {
+return ServerEndpointConfig.Builder.create(getEndpointClass(), 
PATH).build();
+}
+}
+
+
+public static final class SuspendResumeEndpoint extends Endpoint {
+
+@Override
+public void onOpen(Session session, EndpointConfig  epc) {
+MessageProcessor processor = new MessageProcessor(session, 3);
+session.addMessageHandler(String.class, message -> 
processor.addMessage(message));
+}
+
+@Override
+public void onClose(Session session, CloseReason closeReason) {
+try {
+session.close();
+} catch (IOException e) {
+e.printStackTrace();
+}
+}
+
+@Override
+public void onError(Session session, Throwable t) {
+t.printStackTrace();
+}
+}
+
+
+private static final

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg

Github user violetagg commented on a diff in the pull request:

https://github.com/apache/tomcat/pull/42#discussion_r100015479
  
--- Diff: java/org/apache/tomcat/websocket/SuspendableMessageReceiver.java 
---
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.tomcat.websocket;
+
+public interface SuspendableMessageReceiver {
+
+public void suspend();
--- End diff --

applied


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg

Github user violetagg commented on a diff in the pull request:

https://github.com/apache/tomcat/pull/42#discussion_r100015036
  
--- Diff: java/org/apache/tomcat/websocket/server/WsFrameServer.java ---
@@ -124,4 +135,56 @@ protected void sendMessageBinary(ByteBuffer msg, 
boolean last) throws WsIOExcept
 Thread.currentThread().setContextClassLoader(cl);
 }
 }
+
+
+@Override
+protected void resumeProcessing() {
+if (!reading.get()) {
+try {
+if (reading.compareAndSet(false, true)) {
+try {
+if (isOpen() && inputBuffer.remaining() > 0) {
+processInputBuffer();
+}
+} finally {
+reading.getAndSet(false);
--- End diff --

applied


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg

Github user violetagg commented on a diff in the pull request:

https://github.com/apache/tomcat/pull/42#discussion_r100015018
  
--- Diff: java/org/apache/tomcat/websocket/server/WsFrameServer.java ---
@@ -56,21 +61,27 @@ public void onDataAvailable() throws IOException {
 if (log.isDebugEnabled()) {
 log.debug("wsFrameServer.onDataAvailable");
 }
-while (isOpen()) {
-// Fill up the input buffer with as much data as we can
-inputBuffer.mark();
-
inputBuffer.position(inputBuffer.limit()).limit(inputBuffer.capacity());
-int read = socketWrapper.read(false, inputBuffer);
-inputBuffer.limit(inputBuffer.position()).reset();
-if (read < 0) {
-throw new EOFException();
-} else if (read == 0) {
-return;
-}
-if (log.isDebugEnabled()) {
-log.debug(sm.getString("wsFrameServer.bytesRead", 
Integer.toString(read)));
+if (reading.compareAndSet(false, true)) {
+try {
+while (isOpen() && !isSuspended()) {
+// Fill up the input buffer with as much data as 
we can
+inputBuffer.mark();
+
inputBuffer.position(inputBuffer.limit()).limit(inputBuffer.capacity());
+int read = socketWrapper.read(false, inputBuffer);
+inputBuffer.limit(inputBuffer.position()).reset();
+if (read < 0) {
+throw new EOFException();
+} else if (read == 0) {
+return;
+}
+if (log.isDebugEnabled()) {
+
log.debug(sm.getString("wsFrameServer.bytesRead", Integer.toString(read)));
+}
+processInputBuffer();
+}
+} finally {
+reading.getAndSet(false);
--- End diff --

applied


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg

Github user violetagg commented on a diff in the pull request:

https://github.com/apache/tomcat/pull/42#discussion_r100014999
  
--- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java ---
@@ -116,12 +129,11 @@ protected Log getLog() {
 return log;
 }
 
-
-private class WsFrameClientCompletionHandler
-implements CompletionHandler {
+private class WsFrameClientCompletionHandler implements 
CompletionHandler {
 
 @Override
 public void completed(Integer result, Void attachment) {
+reading.getAndSet(false);
--- End diff --

applied


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg

Github user violetagg commented on a diff in the pull request:

https://github.com/apache/tomcat/pull/42#discussion_r100015008
  
--- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java ---
@@ -150,10 +162,11 @@ public void completed(Integer result, Void 
attachment) {
 
 @Override
 public void failed(Throwable exc, Void attachment) {
+reading.getAndSet(false);
--- End diff --

applied


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg

Github user violetagg commented on a diff in the pull request:

https://github.com/apache/tomcat/pull/42#discussion_r100014979
  
--- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java ---
@@ -58,31 +59,44 @@ void startInputProcessing() {
 
 
 private void processSocketRead() throws IOException {
+if (reading.compareAndSet(false, true)) {
+while (response.hasRemaining()) {
+if (isSuspended()) {
+reading.getAndSet(false);
+return;
+}
 
-while (response.hasRemaining()) {
-inputBuffer.mark();
-
inputBuffer.position(inputBuffer.limit()).limit(inputBuffer.capacity());
+inputBuffer.mark();
+
inputBuffer.position(inputBuffer.limit()).limit(inputBuffer.capacity());
 
-int toCopy = Math.min(response.remaining(), 
inputBuffer.remaining());
+int toCopy = Math.min(response.remaining(), 
inputBuffer.remaining());
 
-// Copy remaining bytes read in HTTP phase to input buffer 
used by
-// frame processing
+// Copy remaining bytes read in HTTP phase to input buffer 
used by
+// frame processing
 
-int orgLimit = response.limit();
-response.limit(response.position() + toCopy);
-inputBuffer.put(response);
-response.limit(orgLimit);
+int orgLimit = response.limit();
+response.limit(response.position() + toCopy);
+inputBuffer.put(response);
+response.limit(orgLimit);
 
-inputBuffer.limit(inputBuffer.position()).reset();
+inputBuffer.limit(inputBuffer.position()).reset();
 
-// Process the data we have
-processInputBuffer();
-}
-response.clear();
+// Process the data we have
+try {
+processInputBuffer();
+} catch (IOException e) {
+reading.getAndSet(false);
--- End diff --

applied


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #42: Read events suspend/resume logic in websocket impl ...

2017-02-08 Thread violetagg

Github user violetagg commented on a diff in the pull request:

https://github.com/apache/tomcat/pull/42#discussion_r100014965
  
--- Diff: java/org/apache/tomcat/websocket/WsFrameClient.java ---
@@ -58,31 +59,44 @@ void startInputProcessing() {
 
 
 private void processSocketRead() throws IOException {
+if (reading.compareAndSet(false, true)) {
+while (response.hasRemaining()) {
+if (isSuspended()) {
+reading.getAndSet(false);
--- End diff --

applied


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r18215 - /dev/tomcat/tomcat-6/v6.0.50/

2017-02-08 Thread violetagg

Author: violetagg
Date: Wed Feb  8 08:22:44 2017
New Revision: 18215

Log:
Tomcat 6.0.50 did not pass the vote

Removed:
dev/tomcat/tomcat-6/v6.0.50/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1782117 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/websocket/WsFrameBase.java java/org/apache/tomcat/websocket/WsFrameClient.java java/org/apache/tomcat/websocket/WsSession.jav

2017-02-08 Thread violetagg

Author: violetagg
Date: Wed Feb  8 08:11:48 2017
New Revision: 1782117

URL: http://svn.apache.org/viewvc?rev=1782117&view=rev
Log:
Format the code. No functional changes.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/WsFrameClient.java
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/websocket/WsSession.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Feb  8 08:11:48 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,1762168,176217
 
2,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,17

svn commit: r1782116 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsFrameBase.java WsFrameClient.java WsSession.java

2017-02-08 Thread violetagg

Author: violetagg
Date: Wed Feb  8 08:06:38 2017
New Revision: 1782116

URL: http://svn.apache.org/viewvc?rev=1782116&view=rev
Log:
Format the code. No functional changes.

Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java
tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameClient.java
tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java

Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java?rev=1782116&r1=1782115&r2=1782116&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java Wed Feb  8 
08:06:38 2017
@@ -42,8 +42,7 @@ import org.apache.tomcat.util.res.String
  */
 public abstract class WsFrameBase {
 
-private static final StringManager sm =
-StringManager.getManager(WsFrameBase.class);
+private static final StringManager sm = 
StringManager.getManager(WsFrameBase.class);
 
 // Connection level attributes
 protected final WsSession wsSession;
@@ -88,10 +87,8 @@ public abstract class WsFrameBase {
 public WsFrameBase(WsSession wsSession, Transformation transformation) {
 inputBuffer = ByteBuffer.allocate(Constants.DEFAULT_BUFFER_SIZE);
 inputBuffer.position(0).limit(0);
-messageBufferBinary =
-ByteBuffer.allocate(wsSession.getMaxBinaryMessageBufferSize());
-messageBufferText =
-CharBuffer.allocate(wsSession.getMaxTextMessageBufferSize());
+messageBufferBinary = 
ByteBuffer.allocate(wsSession.getMaxBinaryMessageBufferSize());
+messageBufferText = 
CharBuffer.allocate(wsSession.getMaxTextMessageBufferSize());
 this.wsSession = wsSession;
 Transformation finalTransformation;
 if (isMasked()) {
@@ -151,8 +148,7 @@ public abstract class WsFrameBase {
 if (!transformation.validateRsv(rsv, opCode)) {
 throw new WsIOException(new CloseReason(
 CloseCodes.PROTOCOL_ERROR,
-sm.getString("wsFrame.wrongRsv", Integer.valueOf(rsv),
-Integer.valueOf(opCode;
+sm.getString("wsFrame.wrongRsv", Integer.valueOf(rsv), 
Integer.valueOf(opCode;
 }
 
 if (Util.isControl(opCode)) {
@@ -166,8 +162,7 @@ public abstract class WsFrameBase {
 opCode != Constants.OPCODE_CLOSE) {
 throw new WsIOException(new CloseReason(
 CloseCodes.PROTOCOL_ERROR,
-sm.getString("wsFrame.invalidOpCode",
-Integer.valueOf(opCode;
+sm.getString("wsFrame.invalidOpCode", 
Integer.valueOf(opCode;
 }
 } else {
 if (continuationExpected) {
@@ -199,8 +194,7 @@ public abstract class WsFrameBase {
 } else {
 throw new WsIOException(new CloseReason(
 CloseCodes.PROTOCOL_ERROR,
-sm.getString("wsFrame.invalidOpCode",
-Integer.valueOf(opCode;
+sm.getString("wsFrame.invalidOpCode", 
Integer.valueOf(opCode;
 }
 } catch (IllegalStateException ise) {
 // Thrown if the session is already closed
@@ -267,8 +261,7 @@ public abstract class WsFrameBase {
 if (payloadLength > 125) {
 throw new WsIOException(new CloseReason(
 CloseCodes.PROTOCOL_ERROR,
-sm.getString("wsFrame.controlPayloadTooBig",
-Long.valueOf(payloadLength;
+sm.getString("wsFrame.controlPayloadTooBig", 
Long.valueOf(payloadLength;
 }
 if (!fin) {
 throw new WsIOException(new CloseReason(
@@ -329,8 +322,8 @@ public abstract class WsFrameBase {
 if (controlBufferBinary.remaining() > 1) {
 code = controlBufferBinary.getShort();
 if (controlBufferBinary.remaining() > 0) {
-CoderResult cr = utf8DecoderControl.decode(
-controlBufferBinary, controlBufferText, true);
+CoderResult cr = 
utf8DecoderControl.decode(controlBufferBinary,
+controlBufferText, true);
 if (cr.isError()) {
 controlBufferBinary.clear();
 controlBufferText.clear();
@@ -351,8 +344,7 @@ public abstract class WsFrameBase {
 wsSession.getBasicRemote().sendPong(controlBufferBinary);
 }
 } else if (opCode == Constants.OPCODE_

42 matches

Mail list logo