[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed

[Bill Barker]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc7.0.x-test-apr has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 6 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-test-apr :  Tomcat 7.x, a web server implementing Java 
Servlet 3.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/test-tmp-APR/logs



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-test-apr/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test-apr.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 19 mins 32 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-build-libs 
-Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x 
-Dtest.temp=output/test-tmp-APR 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.6-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170602.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar
 -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps 
-Dtest.excludePerformance=true 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcommons-dbcp.home=/srv/gump/public/workspace/commons-dbcp-1.x 
-Dexecute.test.apr=true -Dexec
 ute.test.bio=false 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170602-native-src.tar.gz
 -Dtest.reports=output/logs-APR 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170602-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-12/dest-20170602/lib 
-Dtest.relaxTiming=true -Dexecute.test.nio=false -Dtest.accesslog=true 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-20170602.jar
 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.ja
 

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

[Bill Barker]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-apr has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 6 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-apr :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-apr/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-apr.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 21 mins 46 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dexecute.test.nio2=false -Dtest.temp=output/test-tmp-APR 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-8.0.x/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.6-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170602.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20170602/bin/openssl
 -Dexecute.test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dexecute.test.apr=true -Dexecute.test.bio=false 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commo
 ns-daemon-20170602-native-src.tar.gz -Dtest.reports=output/logs-APR 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170602-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-12/dest-20170602/lib 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true -Dtest.accesslog=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 

[GitHub] tomcat issue #56: Convert Cluster Manager human-readable SendOptions names t...

[isapir]

Github user isapir commented on the issue:

https://github.com/apache/tomcat/pull/56
  
@violetagg I refactored the method to use `switch` statement as advised. 
https://github.com/apache/tomcat/pull/56/files#diff-5c721c838c78fa7c31f9eb62c27863ceR383

@ChristopherSchultz 

>I think the patch should include some TRACE-level logging, especially when 
catching the NumberFormatException.

Added

>If there is an unrecognized option string, it should at least result in a 
WARN message emitted to the log. I might even lobby for an exception to be 
thrown.

Throwing IllegalArgumentException

>There are options that seem to be in conflict with each other, if only in 
terminology: e.g. "async" and "sync" can be specified together, which would 
read like a bug in the config.

If we add this then it should go into setChannelSendOptions() so that we 
also check if two conflicting integer options are passed then we warn/throw.  I 
can add that, but it should be a separate ticket/PR IMO.

>Splitting on a comma should include optional whitespace e.g. "\s,\s" as 
the pattern.

Changed regex to `\s*,\s*` 

>The patch needs to include documentation for the string-based 
configuration options (webapps/docs/cluster-howto.html).

Added

>The javadoc in the patch needs to include the list of acceptable string 
option-names.

Added

>A small unit test wouldn't hurt, as well (just testing 
setChannelSendOptions(String) -> getChannelSendOptions:int would be fine).

Added, **but I couldn't run the test case** in my IDE.  getting an error 
`Error:(33, 16) java: package trailers does not exist` for 
`test\org\apache\coyote\http2\TestStream.java` and other files and I'm not sure 
yet how to resolve the dependencies.  where is package `trailers` coming from?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 48672] Tomcat Virtual Host Manager (/host-manager) needs documentation

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=48672

Christopher Schultz  changed:

   What|Removed |Added

  Component|Catalina|Documentation

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 48672] Tomcat Virtual Host Manager (/host-manager) needs documentation

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=48672

--- Comment #5 from Coty Sutherland  ---
(In reply to Christopher Schultz from comment #4)
> (Should we add a "documentation" component for Tomcat 9?

Added.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 48672] Tomcat Virtual Host Manager (/host-manager) needs documentation

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=48672

Christopher Schultz  changed:

   What|Removed |Added

   Keywords||Beginner

--- Comment #4 from Christopher Schultz  ---
Speculatively tagging this is "Beginner" because it is "only" a documentation
patch.

(Should we add a "documentation" component for Tomcat 9?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #56: Convert Cluster Manager human-readable SendOptions names t...

[isapir]

Github user isapir commented on the issue:

https://github.com/apache/tomcat/pull/56
  
> Did you actually test it to see if it would give you the desired channel 
options?
I actually did

> A small unit test wouldn't hurt
Will do


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #56: Convert Cluster Manager human-readable SendOptions names t...

[ChristopherSchultz]

Github user ChristopherSchultz commented on the issue:

https://github.com/apache/tomcat/pull/56
  
@isapir I appreciate your core patch as an initial effort. It looks like it 
will work. In order for it to be a good patch, it needs to be expanded, so a 
larger patch is appropriate.

Did you actually test it to see if it would give you the desired channel 
options?

A small unit test wouldn't hurt, as well (just testing 
setChannelSendOptions(String) -> getChannelSendOptions:int would be fine).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 48672] Tomcat Virtual Host Manager (/host-manager) needs documentation

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=48672

Mark Thomas  changed:

   What|Removed |Added

Product|Tomcat 6|Tomcat 9
   Target Milestone|default |-
Version|6.0.24  |unspecified
Summary|Tomcat Virtual Host Manager |Tomcat Virtual Host Manager
   |(/host-manager) have broken |(/host-manager) needs
   |"Host Manager Help" link.   |documentation
  Component|Manager application |Catalina

--- Comment #3 from Mark Thomas  ---
This remains a TODO item for Tomcat 9

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 48543] [Patch] More flexibility in specifying -Dcatalina.config

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=48543

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #6 from Mark Thomas  ---
Thanks for the patch and sorry this didn't get looked at further at the time.
I've just picked this up as part of my review of the remaining Tomcat 6 bugs.

I opted to implement this as part of the existing catalina.config property
rather than as a new property.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1797255 - in /tomcat/trunk: java/org/apache/catalina/startup/CatalinaProperties.java webapps/docs/changelog.xml webapps/docs/config/systemprops.xml

[markt]

Author: markt
Date: Thu Jun  1 19:44:14 2017
New Revision: 1797255

URL: http://svn.apache.org/viewvc?rev=1797255=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=48543
Add the option to specify an alternative file name for the catalina.config 
system property. Also document that relative, as well as absolute, URLs are 
permitted.

Modified:
tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/systemprops.xml

Modified: tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java?rev=1797255=1797254=1797255=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/startup/CatalinaProperties.java Thu 
Jun  1 19:44:14 2017
@@ -60,10 +60,17 @@ public class CatalinaProperties {
 private static void loadProperties() {
 
 InputStream is = null;
+String fileName = "catalina.properties";
+
 try {
 String configUrl = System.getProperty("catalina.config");
 if (configUrl != null) {
-is = (new URL(configUrl)).openStream();
+if (configUrl.indexOf('/') == -1) {
+// No '/'. Must be a file name rather than a URL
+fileName = configUrl;
+} else {
+is = (new URL(configUrl)).openStream();
+}
 }
 } catch (Throwable t) {
 handleThrowable(t);
@@ -73,7 +80,7 @@ public class CatalinaProperties {
 try {
 File home = new File(Bootstrap.getCatalinaBase());
 File conf = new File(home, "conf");
-File propsFile = new File(conf, "catalina.properties");
+File propsFile = new File(conf, fileName);
 is = new FileInputStream(propsFile);
 } catch (Throwable t) {
 handleThrowable(t);
@@ -100,14 +107,14 @@ public class CatalinaProperties {
 try {
 is.close();
 } catch (IOException ioe) {
-log.warn("Could not close catalina.properties", ioe);
+log.warn("Could not close catalina properties file", ioe);
 }
 }
 }
 
 if ((is == null)) {
 // Do something
-log.warn("Failed to load catalina.properties");
+log.warn("Failed to load catalina properties file");
 // That's fine - we have reasonable defaults.
 properties = new Properties();
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1797255=1797254=1797255=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jun  1 19:44:14 2017
@@ -48,6 +48,11 @@
   
 
   
+48543: Add the option to specify an alternative file name 
for
+the catalina.config system property. Also document that
+relative, as well as absolute, URLs are permitted. (markt)
+  
+  
 61072: Respect the documentation statements that allow
 using the platform default secure random for session id generation.
 (remm)

Modified: tomcat/trunk/webapps/docs/config/systemprops.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/systemprops.xml?rev=1797255=1797254=1797255=diff
==
--- tomcat/trunk/webapps/docs/config/systemprops.xml (original)
+++ tomcat/trunk/webapps/docs/config/systemprops.xml Thu Jun  1 19:44:14 2017
@@ -580,7 +580,11 @@
 
 
 
-  The URL for the catalina.properties configuration file.
+  The location from which to load the catalina.properties configuration
+  file. This may be an absolute URL, a relative (to the current working
+  directory) URL or an alternative file name in which case Tomcat will
+  attempt to load the file from the default location of
+  $CATALINA_BASE/conf/.
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #56: Convert Cluster Manager human-readable SendOptions names t...

[violetagg]

Github user violetagg commented on the issue:

https://github.com/apache/tomcat/pull/56
  
> I was pointing out these examples while trying to figure out if you still 
require that I wrap each single statement if with braces, which would make the 
code less readable IMO.

+1 for `switch` as you proposed earlier 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #56: Convert Cluster Manager human-readable SendOptions names t...

[isapir]

Github user isapir commented on the issue:

https://github.com/apache/tomcat/pull/56
  
@ChristopherSchultz That's exactly the kind of feedback that I was looking 
for.  I will address the points to the best of my ability.

Keep in mind that after those changes, the commit will be much larger and 
take longer to review, which raises the concerns that I mentioned in the 
mailing list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #56: Convert Cluster Manager human-readable SendOptions names t...

[isapir]

Github user isapir commented on the issue:

https://github.com/apache/tomcat/pull/56
  
@violetagg Yes, I read that on 
http://tomcat.apache.org/getinvolved.html#Coding_Conventions

I was pointing out these examples while trying to figure out if you still 
require that I wrap each single statement `if` with braces, which would make 
the code less readable IMO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Things that we can do to increase contributor involvement?

[Igal @ Lucee.org]

Chris,

On 6/1/2017 11:16 AM, Christopher Schultz wrote:

Just remember that everyone here is a volunteer, and it takes much
longer to review/test a patch/PR than it does to e.g. reply to a message
on a mailing list. We all have our primary jobs and our families and
both of those take priority over volunteering for the ASF and its
communities.


I'm not sure if you read my first email in this thread (reading emails 
is also very time consuming, I know), but I made it very clear there 
that I am aware of these factors and that I set my expectations 
accordingly.  I wouldn't have even mentioned my PR at this point if it 
weren't for Coty's email which started this thread.


I believe that my perspective represents most new contributors, and not 
only my own personal views, and that's the reason I posted it.



We always say "patches are always welcome" but, you're right, if the
patches sit unreviewed for a long time, it's tough to feel like your
contributions are valued.


I have been contributing to various open source projects for the better 
part of a decade now.  Unfortunately, in the beginning, I had submitted 
large PRs a few times, that contained a lot of work.  That work was not 
reviewed in a timely manner, and at some point the code base has changed 
so much that it was un-mergeable anymore, leading to loss of time and 
effort.


I have learned since to submit smaller and cleaner patches, so that they 
are easier to review.  But still, if they are not reviewed in a timely 
manner there is: 1) a risk of them becoming unmergable due to changes in 
the code base; and 2) discouragement of the submitter from doing more work.



-chris


If that really is your name...  Christopher Schultz signs his messages 
with a PGP signature ;)


Igal Sapir
Lucee Core Developer
Lucee.org 

[GitHub] tomcat issue #56: Convert Cluster Manager human-readable SendOptions names t...

[violetagg]

Github user violetagg commented on the issue:

https://github.com/apache/tomcat/pull/56
  
> I noticed instances of the code where curly braces were omitted for 
single-statement ifs, 

Yep, we know that. If you take a look at the history you will see that 
typically when we prepare changes first make a change with formatting if we see 
that it is needed and then implement the change.
We use 
- the standard Eclipse formatting  
- spaces only 
- lines up to 100 chars for code and 80 chars for javadoc, comments etc. 
- some additional settings for the compiler and javadoc 
http://svn.apache.org/repos/asf/tomcat/trunk/res/ide-support/eclipse/java-compiler-errors-warnings.txt


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #56: Convert Cluster Manager human-readable SendOptions names t...

[ChristopherSchultz]

Github user ChristopherSchultz commented on the issue:

https://github.com/apache/tomcat/pull/56
  
A few comments:

1. I think the patch should include some TRACE-level logging, especially 
when catching the NumberFormatException.
2. If there is an unrecognized option string, it should at least result in 
a WARN message emitted to the log. I might even lobby for an exception to be 
thrown.
3. There are options that seem to be in conflict with each other, if only 
in terminology: e.g. "async" and "sync" can be specified together, which would 
read like a bug in the config.
4. Splitting on a comma should include optional whitespace e.g. "\\s,*\\s*" 
as the pattern.
5. The patch needs to include documentation for the string-based 
configuration options (webapps/docs/cluster-howto.html).
6. The javadoc in the patch needs to include the list of acceptable string 
option-names.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Things that we can do to increase contributor involvement?

[Christopher Schultz]

Igal,

On 6/1/17 1:59 PM, Igal @ Lucee.org wrote:
> On 6/1/2017 5:05 AM, Coty Sutherland wrote:
>>
>> Just for future reference, when you submit a PR it's easiest to review
>> if you squash all of the commits into one rather than multiple
>> commits.
>
> Perhaps that's a mentality difference between SVN users and git users.
> In git it is common to do as in voting: commit early and commit often (
> https://en.wikipedia.org/wiki/Vote_early_and_vote_often ).
>
> But there is a very simple solution for that -- rather than check the
> individual commits, check the "Files changed" tab in github, in this
> case https://github.com/apache/tomcat/pull/56/files (notice `files`
> added to endpoint, but clicking the tab would take you there directly).
>
> That shows the cumulative changes of all of the commits.
>
> I try to make my PRs as easy as possible to review.
>
> On 6/1/2017 6:29 AM, Mark Thomas wrote:
 There is generally a large difference in responsiveness between bugs
 and enhancement requests. Most of the open PRs have been reviewed
 and are waiting for feedback. The others are enhancement requests
 which typically remain open until there is sufficient interest in
 implementing them.
>
> Understandable, but please bear in mind that new contributors can not
> usually start with complicated bugs.  The new "Newbie / Stater /
> Beginner" keyword that you added to BZ was a great idea (h/t Chris), but
> if "Beginner" issues will not be reviewed due to lack of interest, then
> new contributors are very unlikely to submit any PRs after that first
> one that will not be addressed.
>
> If Tomcat wants new contributors (and it should!), then a better
> feedback loop is required.
>
> I, for one, am excited to contribute more to the project.  I've already
> received some feedback from Violeta about my PR since I sent my last
> email, and updated the PR accordingly.  I'm not sure if this thread had
> triggered the review or not, but AFAIC this is good progress :)

All good points.

Just remember that everyone here is a volunteer, and it takes much
longer to review/test a patch/PR than it does to e.g. reply to a message
on a mailing list. We all have our primary jobs and our families and
both of those take priority over volunteering for the ASF and its
communities.

If you aren't getting enough feedback, don't hesitate to post to the
mailing list to "remind" everyone that you have a pending patch/PR and
that you'd appreciate some feedback.

We always say "patches are always welcome" but, you're right, if the
patches sit unreviewed for a long time, it's tough to feel like your
contributions are valued.

-chris



signature.asc
Description: OpenPGP digital signature

Re: Things that we can do to increase contributor involvement?

[Igal @ Lucee.org]

On 6/1/2017 5:05 AM, Coty Sutherland wrote:


Just for future reference, when you submit a PR it's easiest to review
if you squash all of the commits into one rather than multiple
commits.


Perhaps that's a mentality difference between SVN users and git users.  
In git it is common to do as in voting: commit early and commit often ( 
https://en.wikipedia.org/wiki/Vote_early_and_vote_often ).


But there is a very simple solution for that -- rather than check the 
individual commits, check the "Files changed" tab in github, in this 
case https://github.com/apache/tomcat/pull/56/files (notice `files` 
added to endpoint, but clicking the tab would take you there directly).


That shows the cumulative changes of all of the commits.

I try to make my PRs as easy as possible to review.

On 6/1/2017 6:29 AM, Mark Thomas wrote:

There is generally a large difference in responsiveness between bugs and 
enhancement requests. Most of the open PRs have been reviewed and are waiting 
for feedback. The others are enhancement requests which typically remain open 
until there is sufficient interest in implementing them.


Understandable, but please bear in mind that new contributors can not 
usually start with complicated bugs.  The new "Newbie / Stater / 
Beginner" keyword that you added to BZ was a great idea (h/t Chris), but 
if "Beginner" issues will not be reviewed due to lack of interest, then 
new contributors are very unlikely to submit any PRs after that first 
one that will not be addressed.


If Tomcat wants new contributors (and it should!), then a better 
feedback loop is required.


I, for one, am excited to contribute more to the project.  I've already 
received some feedback from Violeta about my PR since I sent my last 
email, and updated the PR accordingly.  I'm not sure if this thread had 
triggered the review or not, but AFAIC this is good progress :)



Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #56: Convert Cluster Manager human-readable SendOptions names t...

[isapir]

Github user isapir commented on the issue:

https://github.com/apache/tomcat/pull/56
  
@violetagg Thank you for your feedback, I updated the `for`, `catch`, and 
one of the `if`'s.

While looking into updating the rest of the `if` statements I noticed 
instances of the code where curly braces were omitted for single-statement 
`if`s, e.g.


https://github.com/isapir/tomcat/blob/e51512fdc062ffd07a3dd323cba76ab057d23322/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java#L256


https://github.com/isapir/tomcat/blob/e51512fdc062ffd07a3dd323cba76ab057d23322/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java#L424


https://github.com/isapir/tomcat/blob/e51512fdc062ffd07a3dd323cba76ab057d23322/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java#L470


https://github.com/isapir/tomcat/blob/e51512fdc062ffd07a3dd323cba76ab057d23322/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java#L500


https://github.com/isapir/tomcat/blob/e51512fdc062ffd07a3dd323cba76ab057d23322/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java#L503


https://github.com/isapir/tomcat/blob/e51512fdc062ffd07a3dd323cba76ab057d23322/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java#L537


https://github.com/isapir/tomcat/blob/e51512fdc062ffd07a3dd323cba76ab057d23322/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java#L546


https://github.com/isapir/tomcat/blob/e51512fdc062ffd07a3dd323cba76ab057d23322/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java#L564


https://github.com/isapir/tomcat/blob/e51512fdc062ffd07a3dd323cba76ab057d23322/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java#L565


https://github.com/isapir/tomcat/blob/e51512fdc062ffd07a3dd323cba76ab057d23322/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java#L570


https://github.com/isapir/tomcat/blob/e51512fdc062ffd07a3dd323cba76ab057d23322/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java#L621

Anyway, it seemed like I shouldn't even continue in that file.  If you want 
to enforce these styles then perhaps it'd be better to run the source code 
through a code formatter.

Thanks,


Igal


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #56: Convert Cluster Manager human-readable SendOptions ...

[isapir]

Github user isapir commented on a diff in the pull request:

https://github.com/apache/tomcat/pull/56#discussion_r119663995
  
--- Diff: java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java ---
@@ -339,6 +339,13 @@ public void setChannelSendOptions(int 
channelSendOptions) {
 this.channelSendOptions = channelSendOptions;
 }
 
+public void setChannelSendOptions(String channelSendOptions) {
+
+int value = Channel.parseChannelSendOptions(channelSendOptions);
+if (value > 0)
--- End diff --

Violeta, thank you for your feedback.

I'll add curly braces to the `for` block.

So each of those if's should have curly braces?

```if ("asynchronous".equals(opt) || "async".equals(opt))
return SEND_OPTIONS_ASYNCHRONOUS;```

That's a lot of curly braces...  Perhaps a `switch` statement would be 
"cleaner" here then?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1797237 - in /tomcat/site/trunk: docs/presentations.html xdocs/presentations.xml

[schultz]

Author: schultz
Date: Thu Jun  1 16:08:20 2017
New Revision: 1797237

URL: http://svn.apache.org/viewvc?rev=1797237=rev
Log:
Add 3 presentations and links to recordings of two of them.

Modified:
tomcat/site/trunk/docs/presentations.html
tomcat/site/trunk/xdocs/presentations.xml

Modified: tomcat/site/trunk/docs/presentations.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/presentations.html?rev=1797237=1797236=1797237=diff
==
--- tomcat/site/trunk/docs/presentations.html (original)
+++ tomcat/site/trunk/docs/presentations.html Thu Jun  1 16:08:20 2017
@@ -284,12 +284,26 @@ mailing list.
 
   
 
+Seamless Upgrades for Credential Security in Apache Tomcat - Christopher 
Schultz,
+http://people.apache.org/~schultz/ApacheCon%20NA%202017/Seamless%20Upgrades%20for%20Credential%20Security%20in%20Apache%20Tomcat.odp;>slides,
+http://people.apache.org/~schultz/ApacheCon%20NA%202017/;>sample 
code
+  
+
+  
+
 Introduction to Tomcat and TLS - Mark Thomas,
 http://people.apache.org/~markt/presentations/2017-05-16-b-tomcat-ssl.pdf;>slides
   
 
   
 
+Let's Encrypt Apache Tomcat - Christopher Schultz,
+http://people.apache.org/~schultz/ApacheCon%20NA%202017/Let's%20Encrypt%20Apache%20Tomcat.odp">slides,
+http://people.apache.org/~schultz/ApacheCon%20NA%202017/;>sample 
code
+  
+
+  
+
 Securing Tomcat for your environment - Mark Thomas,
 http://people.apache.org/~markt/presentations/2017-05-16-c-securing-tomcat.pdf;>slides
   
@@ -302,8 +316,15 @@ mailing list.
 
   
 
+From a Cluster to the Cloud - Jean-Frederic Clere,
+https://www.youtube.com/watch?v=9PN-JZje6wsindex=51list=PLbzoR-pLrL6pLDCyPxByWQwYTL-JrF5Rp;>recording
+  
+
+  
+
 Wrap up - Mark Thomas,
-http://people.apache.org/~markt/presentations/2017-05-18-e-wrapup.pdf;>slides
+http://people.apache.org/~markt/presentations/2017-05-18-e-wrapup.pdf;>slides,
+https://www.youtube.com/watch?v=kpJVTp2kfmkindex=50list=PLbzoR-pLrL6pLDCyPxByWQwYTL-JrF5Rp;>recording
   
 
 

Modified: tomcat/site/trunk/xdocs/presentations.xml
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/presentations.xml?rev=1797237=1797236=1797237=diff
==
--- tomcat/site/trunk/xdocs/presentations.xml (original)
+++ tomcat/site/trunk/xdocs/presentations.xml Thu Jun  1 16:08:20 2017
@@ -42,10 +42,20 @@ mailing list.
 http://people.apache.org/~markt/presentations/2017-05-16-a-state-of-the-cat.pdf;>slides
   
   
+Seamless Upgrades for Credential Security in Apache Tomcat - Christopher 
Schultz,
+http://people.apache.org/~schultz/ApacheCon%20NA%202017/Seamless%20Upgrades%20for%20Credential%20Security%20in%20Apache%20Tomcat.odp;>slides,
+http://people.apache.org/~schultz/ApacheCon%20NA%202017/;>sample 
code
+  
+  
 Introduction to Tomcat and TLS - Mark Thomas,
 http://people.apache.org/~markt/presentations/2017-05-16-b-tomcat-ssl.pdf;>slides
   
   
+Let's Encrypt Apache Tomcat - Christopher Schultz,
+http://people.apache.org/~schultz/ApacheCon%20NA%202017/Let's%20Encrypt%20Apache%20Tomcat.odp">slides,
+http://people.apache.org/~schultz/ApacheCon%20NA%202017/;>sample 
code
+  
+  
 Securing Tomcat for your environment - Mark Thomas,
 http://people.apache.org/~markt/presentations/2017-05-16-c-securing-tomcat.pdf;>slides
   
@@ -54,8 +64,13 @@ mailing list.
 http://people.apache.org/~markt/presentations/2017-05-17-d-tomcat-load-balancing.pdf;>slides
   
   
+From a Cluster to the Cloud - Jean-Frederic Clere,
+https://www.youtube.com/watch?v=9PN-JZje6wsindex=51list=PLbzoR-pLrL6pLDCyPxByWQwYTL-JrF5Rp;>recording
+  
+  
 Wrap up - Mark Thomas,
-http://people.apache.org/~markt/presentations/2017-05-18-e-wrapup.pdf;>slides
+http://people.apache.org/~markt/presentations/2017-05-18-e-wrapup.pdf;>slides,
+https://www.youtube.com/watch?v=kpJVTp2kfmkindex=50list=PLbzoR-pLrL6pLDCyPxByWQwYTL-JrF5Rp;>recording
   
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Things that we can do to increase contributor involvement?

[Romain Manni-Bucau]

Hi guys,

a quick feedback on that topic:

- github seems to be the preferred way to submit code these days (what we
saw in tomee, batchee etc), it implies almost the same amount of work for
dev (just need to comment if applied or not on github itself for tracking)
so it is a good way probably
- tomcat build not being "standard" can be a stopper for newcomers, I know
migrating to a real maven structure was rejected multiple times but I think
it can help. It would enable to import the project smoothly in any IDE, run
it almost directly from the command line (it is not rare now to not have
ant), and make it easier to browse the structure/package/module




Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | JavaEE Factory


2017-06-01 15:29 GMT+02:00 Mark Thomas :

> On 1 June 2017 13:05:18 BST, Coty Sutherland  wrote:
>
> >Hm, using Git was mentioned at the TomcatCon but I can't recall if the
> >git repository on github is bi-directional or just a clone of svn. Can
> >anyone answer that?
>
> The ASF hosts a read-only git clone of svn. GitHub has a read-only mirror
> of the ASF repo.
>
> I.e. only ASF svn is read/write.
>
> > Have we made a decision about the best way to
> >submit patches? BZ attachment, github PR, email, other?
>
> BZ or PR are generally best since they are less likely to be forgotten.
>
> > How often do
> >we check the github projects for contributions?
>
> Notifications of PRs get sent to the dev list.
>
> >  We also talked about
> >going over the tomcat 6 and older version BZs to clean them up, maybe
> >we should do the same for github PRs?
>
> 5.5.x and earlier was cleaned up as they went EOL. There are currently 15
> or so 6.0.x BZ entries left to clean up.
>
> >> Anyway, there are PRs there from a few months ago, all the way to a
> >couple
> >> of years ago.  The really old ones should be closed IMO, and suggest
> >to the
> >> contributors to submit again if the issue(s) are still valid.
>
> There is generally a large difference in responsiveness between bugs and
> enhancement requests. Most of the open PRs have been reviewed and are
> waiting for feedback. The others are enhancement requests which typically
> remain open until there is sufficient interest in implementing them.
>
> Yes it would be great to move faster on these. That needs more people
> looking at them. Things are slowly improving - the total open issues is
> trending downwards over time.
>
> Mark
>
>
>  > The
> >newer
> >> ones should be evaluated and feedback should be given to the
> >contributors
> >> You already "found" new contributors -- better spend some time
> >"cultivating"
> >> them than look for new ones who might end up stuck in that same
> >situation.
> >>
> >> The most recent PR ATM -- https://github.com/apache/tomcat/pull/56 --
> >is
> >> from me, and it's only been a few days, so normally I wouldn't have
> >said
> >> anything at this point because it hasn't been "long enough" since I
> >> submitted it.  But then I saw this email and it made perfect sense
> >for me to
> >> chime in.
> >>
> >> It was very important for me to keep my PR as small and simple as
> >possible,
> >> so that it's easy to review and accept or reject.  But there is no
> >feedback
> >
> >Just for future reference, when you submit a PR it's easiest to review
> >if you squash all of the commits into one rather than multiple
> >commits.
> >
> >> whatsoever.  I usually have more time to contribute on the weekends,
> >so if
> >> I'll get some feedback soon, I will hopefully be able to implement
> >whatever
> >> changes necessary on the weekend.  If not, then another week goes by.
> >>
> >> Anyway, I really am not complaining here.  Just providing a
> >perspective from
> >> "the other side".
> >>
> >> All the best, and keep up the good work!
> >
> >I appreciate the perspective and hope to hear more from new
> >contributors :) Thanks again!
> >
> >> Igal
> >>
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >
> >-
> >To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: Things that we can do to increase contributor involvement?

[Mark Thomas]

On 1 June 2017 13:05:18 BST, Coty Sutherland  wrote:

>Hm, using Git was mentioned at the TomcatCon but I can't recall if the
>git repository on github is bi-directional or just a clone of svn. Can
>anyone answer that?

The ASF hosts a read-only git clone of svn. GitHub has a read-only mirror of 
the ASF repo. 

I.e. only ASF svn is read/write.

> Have we made a decision about the best way to
>submit patches? BZ attachment, github PR, email, other?

BZ or PR are generally best since they are less likely to be forgotten.

> How often do
>we check the github projects for contributions?

Notifications of PRs get sent to the dev list.

>  We also talked about
>going over the tomcat 6 and older version BZs to clean them up, maybe
>we should do the same for github PRs?

5.5.x and earlier was cleaned up as they went EOL. There are currently 15 or so 
6.0.x BZ entries left to clean up.

>> Anyway, there are PRs there from a few months ago, all the way to a
>couple
>> of years ago.  The really old ones should be closed IMO, and suggest
>to the
>> contributors to submit again if the issue(s) are still valid.

There is generally a large difference in responsiveness between bugs and 
enhancement requests. Most of the open PRs have been reviewed and are waiting 
for feedback. The others are enhancement requests which typically remain open 
until there is sufficient interest in implementing them.

Yes it would be great to move faster on these. That needs more people looking 
at them. Things are slowly improving - the total open issues is trending 
downwards over time.

Mark


 > The
>newer
>> ones should be evaluated and feedback should be given to the
>contributors
>> You already "found" new contributors -- better spend some time
>"cultivating"
>> them than look for new ones who might end up stuck in that same
>situation.
>>
>> The most recent PR ATM -- https://github.com/apache/tomcat/pull/56 --
>is
>> from me, and it's only been a few days, so normally I wouldn't have
>said
>> anything at this point because it hasn't been "long enough" since I
>> submitted it.  But then I saw this email and it made perfect sense
>for me to
>> chime in.
>>
>> It was very important for me to keep my PR as small and simple as
>possible,
>> so that it's easy to review and accept or reject.  But there is no
>feedback
>
>Just for future reference, when you submit a PR it's easiest to review
>if you squash all of the commits into one rather than multiple
>commits.
>
>> whatsoever.  I usually have more time to contribute on the weekends,
>so if
>> I'll get some feedback soon, I will hopefully be able to implement
>whatever
>> changes necessary on the weekend.  If not, then another week goes by.
>>
>> Anyway, I really am not complaining here.  Just providing a
>perspective from
>> "the other side".
>>
>> All the best, and keep up the good work!
>
>I appreciate the perspective and hope to hear more from new
>contributors :) Thanks again!
>
>> Igal
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61134] Unexpected [ ] in public text on default error pages

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61134

Violeta Georgieva  changed:

   What|Removed |Added

   Keywords||Beginner

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Things that we can do to increase contributor involvement?

[Konstantin Kolinko]

2017-06-01 15:05 GMT+03:00 Coty Sutherland :
> Hi,
>
> On Wed, May 31, 2017 at 12:08 PM, Igal @ Lucee.org  wrote:
>> Hi all,
>>
>> On 5/31/2017 1:12 AM, Mark Thomas wrote:
>>>
>>> On 31/05/17 04:07, Coty Sutherland wrote:

 I've been thinking about things that we could do for Tomcat to help
 bring in new contributors and to be more appealing to new developers.
>>>
>>> https://helpwanted.apache.org/
>>
>>
>> I would like to offer the perspective of the "new contributor" here.  I, for
>> one, would love to contribute and be more involved with the Tomcat project,
>> and I believe that thanks to Tomcat's popularity there are many out there
>> just like me.
>>
>> As a new contributor, the most important thing is to get some feedback.  The
>> "worst" thing from a new contributor's perspective is that he/she will put
>> much time into work that will never be looked at, and all that time will go
>> to waste.
>
> I agree :) Thanks for the feedback. By voicing concerns like these we
> can get them addressed.
>
>> We understand that not all contributions will be accepted, and that they
>> must adhere to the standards set by the project.  We also realize that this
>> is open source, and that the people who review the submission are usually
>> volunteers who do the best they can in the time that they can afford to
>> contribute to the project.
>>
>> We still need, however, to get some feedback on our submitted work in a
>> timely manner before we can try again, or submit some other work.

1. Do you read dev@tomcat ?

Do you review others' commits?

Do you test release candidates?

For me, new contributions come after that.

>> Take for example the PRs on Github (sorry, but SVN feels like the 1980s --
>> great time for partying, not so much for writing code -- and I know,
>> ironically the SVN project started in 2000, but I digress):
>> https://github.com/apache/tomcat/pulls
>
> Hm, using Git was mentioned at the TomcatCon but I can't recall if the
> git repository on github is bi-directional or just a clone of svn. Can
> anyone answer that?

2. ASF Git repository is read-only mirror of svn repository.
Github repository is mirror of ASF Git repository.

It is possible to use git-svn bridge to commit to svn with git commands
(git-svn metadata are present in commits and it is possible),
but I prefer to overlap git checkout over svn working copy
and commit with svn.

This way it is easier to review.

> Have we made a decision about the best way to
> submit patches? BZ attachment, github PR, email, other? How often do
> we check the github projects for contributions?

3. The work-to-do is tracked via Bugzilla.
The changelog file references Bugzilla.

Thus it is better when a PR references a Bugzilla issue.

For me, PRs are equivalent to attached patches.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 46284] Add flag to DeltaManager that blocks processing cluster messages until local applicaiton initialization is completed

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=46284

--- Comment #4 from Jason A. Lunn  ---
After over 8 and a half years I have long since stopped being invested in the
outcome of this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Things that we can do to increase contributor involvement?

[Coty Sutherland]

Hi,

On Wed, May 31, 2017 at 12:08 PM, Igal @ Lucee.org  wrote:
> Hi all,
>
> On 5/31/2017 1:12 AM, Mark Thomas wrote:
>>
>> On 31/05/17 04:07, Coty Sutherland wrote:
>>>
>>> I've been thinking about things that we could do for Tomcat to help
>>> bring in new contributors and to be more appealing to new developers.
>>
>> https://helpwanted.apache.org/
>
>
> I would like to offer the perspective of the "new contributor" here.  I, for
> one, would love to contribute and be more involved with the Tomcat project,
> and I believe that thanks to Tomcat's popularity there are many out there
> just like me.
>
> As a new contributor, the most important thing is to get some feedback.  The
> "worst" thing from a new contributor's perspective is that he/she will put
> much time into work that will never be looked at, and all that time will go
> to waste.

I agree :) Thanks for the feedback. By voicing concerns like these we
can get them addressed.

> We understand that not all contributions will be accepted, and that they
> must adhere to the standards set by the project.  We also realize that this
> is open source, and that the people who review the submission are usually
> volunteers who do the best they can in the time that they can afford to
> contribute to the project.
>
> We still need, however, to get some feedback on our submitted work in a
> timely manner before we can try again, or submit some other work.
>
> Take for example the PRs on Github (sorry, but SVN feels like the 1980s --
> great time for partying, not so much for writing code -- and I know,
> ironically the SVN project started in 2000, but I digress):
> https://github.com/apache/tomcat/pulls

Hm, using Git was mentioned at the TomcatCon but I can't recall if the
git repository on github is bi-directional or just a clone of svn. Can
anyone answer that? Have we made a decision about the best way to
submit patches? BZ attachment, github PR, email, other? How often do
we check the github projects for contributions? We also talked about
going over the tomcat 6 and older version BZs to clean them up, maybe
we should do the same for github PRs?

> Anyway, there are PRs there from a few months ago, all the way to a couple
> of years ago.  The really old ones should be closed IMO, and suggest to the
> contributors to submit again if the issue(s) are still valid.  The newer
> ones should be evaluated and feedback should be given to the contributors
> You already "found" new contributors -- better spend some time "cultivating"
> them than look for new ones who might end up stuck in that same situation.
>
> The most recent PR ATM -- https://github.com/apache/tomcat/pull/56 -- is
> from me, and it's only been a few days, so normally I wouldn't have said
> anything at this point because it hasn't been "long enough" since I
> submitted it.  But then I saw this email and it made perfect sense for me to
> chime in.
>
> It was very important for me to keep my PR as small and simple as possible,
> so that it's easy to review and accept or reject.  But there is no feedback

Just for future reference, when you submit a PR it's easiest to review
if you squash all of the commits into one rather than multiple
commits.

> whatsoever.  I usually have more time to contribute on the weekends, so if
> I'll get some feedback soon, I will hopefully be able to implement whatever
> changes necessary on the weekend.  If not, then another week goes by.
>
> Anyway, I really am not complaining here.  Just providing a perspective from
> "the other side".
>
> All the best, and keep up the good work!

I appreciate the perspective and hope to hear more from new
contributors :) Thanks again!

> Igal
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61137] TagLibraryInfo uri and prefix fields should not be final

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61137

Violeta Georgieva  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #2 from Violeta Georgieva  ---
Hi,

Thanks for the report and the patch.
Fixed in:
- trunk for 9.0.0.M22 onwards
- 8.5.x for 8.5.16 onwards
- 8.0.x for 8.0.45 onwards

Regards,
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1797201 - in /tomcat/tc8.0.x/trunk: ./ java/javax/servlet/jsp/tagext/TagLibraryInfo.java webapps/docs/changelog.xml

[violetagg]

Author: violetagg
Date: Thu Jun  1 11:36:09 2017
New Revision: 1797201

URL: http://svn.apache.org/viewvc?rev=1797201=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61137
TagLibraryInfo#uri and TagLibraryInfo#prefix fields should not be final. Patch 
provided by Katya Todorova.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/javax/servlet/jsp/tagext/TagLibraryInfo.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Jun  1 11:36:09 2017
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452
 

svn commit: r1797200 - in /tomcat/tc8.5.x/trunk: ./ java/javax/servlet/jsp/tagext/TagLibraryInfo.java webapps/docs/changelog.xml

[violetagg]

Author: violetagg
Date: Thu Jun  1 11:34:39 2017
New Revision: 1797200

URL: http://svn.apache.org/viewvc?rev=1797200=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61137
TagLibraryInfo#uri and TagLibraryInfo#prefix fields should not be final. Patch 
provided by Katya Todorova.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/javax/servlet/jsp/tagext/TagLibraryInfo.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Jun  1 11:34:39 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747
 
536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1
 
756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,176216
 

[GitHub] tomcat pull request #57: Remove final modifiers from TagLibraryInfo uri and ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/tomcat/pull/57


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1797197 - in /tomcat/trunk: java/javax/servlet/jsp/tagext/TagLibraryInfo.java webapps/docs/changelog.xml

[violetagg]

Author: violetagg
Date: Thu Jun  1 11:31:48 2017
New Revision: 1797197

URL: http://svn.apache.org/viewvc?rev=1797197=rev
Log:
TagLibraryInfo#uri and TagLibraryInfo#prefix fields should not be final. Patch 
provided by Katya Todorova.

This closes #57

Modified:
tomcat/trunk/java/javax/servlet/jsp/tagext/TagLibraryInfo.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/javax/servlet/jsp/tagext/TagLibraryInfo.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/jsp/tagext/TagLibraryInfo.java?rev=1797197=1797196=1797197=diff
==
--- tomcat/trunk/java/javax/servlet/jsp/tagext/TagLibraryInfo.java (original)
+++ tomcat/trunk/java/javax/servlet/jsp/tagext/TagLibraryInfo.java Thu Jun  1 
11:31:48 2017
@@ -230,13 +230,13 @@ public abstract class TagLibraryInfo {
 /**
  * The prefix assigned to this taglib from the taglib directive.
  */
-protected final String prefix;
+protected String prefix;
 
 /**
  * The value of the uri attribute from the taglib directive for this
  * library.
  */
-protected final String uri;
+protected String uri;
 
 /**
  * An array describing the tags that are defined in this tag library.

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1797197=1797196=1797197=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jun  1 11:31:48 2017
@@ -98,6 +98,11 @@
 stopping after the first error. Based on a patch provided by Marc 
Pompl.
 (markt)
   
+  
+61137: j.s.jsp.tagext.TagLibraryInfo#uri and
+j.s.jsp.tagext.TagLibraryInfo#prefix fields should not be
+final. Patch provided by Katya Todorova. (violetagg)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61137] TagLibraryInfo uri and prefix fields should not be final

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61137

--- Comment #1 from Katya Todorova  ---
Pull request: https://github.com/apache/tomcat/pull/57
tomcat tests pass

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #57: Remove final modifiers from TagLibraryInfo uri and ...

[katya-stoycheva]

GitHub user katya-stoycheva opened a pull request:

https://github.com/apache/tomcat/pull/57

Remove final modifiers from TagLibraryInfo uri and prefix

Remove final modifiers from TagLibraryInfo uri and prefix fields to match 
the spec

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/katya-stoycheva/tomcat trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #57


commit a333f9e1bfcddd4fceed534941b7a23c3c64d434
Author: Katya Todorova 
Date:   2017-06-01T08:09:19Z

Remove final modifiers from uri and prefix fields so they match the 
specification




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Proposal to remove AjpApr connector

[Rainer Jung]

Am 30.05.2017 um 22:06 schrieb Emmanuel Bourg:

On 05/26/2017 01:46 PM, Mark Thomas wrote:


It feels a bit late to do this for 9.0.x although we code if we wanted
to. It is more of an option for 10.0.x.


Tomcat 9 is still in an alpha stage and not widely deployed yet. I
wouldn't be shocked if APR was dropped in this release.


Dropping APR already in 9 would also be OK for me. Either 9 or 10. I 
always felt uneasy with the combination of very bad potential problem 
(process crash) and the difficulties to analyze root causes for the APR 
connector.


Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #56: Convert Cluster Manager human-readable SendOptions ...

[violetagg]

Github user violetagg commented on a diff in the pull request:

https://github.com/apache/tomcat/pull/56#discussion_r119539287
  
--- Diff: java/org/apache/catalina/tribes/Channel.java ---
@@ -369,4 +369,58 @@
  */
 public void setName(String name);
 
+/**
+ * Translates the name of an option to its integer value
+ * @param opt The name of the option
+ * @return
+ */
+public static int getOptionValue(String opt){
+
+if ("asynchronous".equals(opt) || "async".equals(opt))
+return SEND_OPTIONS_ASYNCHRONOUS;
+
+if ("byte_message".equals(opt) || "byte".equals(opt))
+return SEND_OPTIONS_BYTE_MESSAGE;
+
+if ("multicast".equals(opt))
+return SEND_OPTIONS_MULTICAST;
+
+if ("secure".equals(opt))
+return SEND_OPTIONS_SECURE;
+
+if ("synchronized_ack".equals(opt) || "sync".equals(opt))
+return SEND_OPTIONS_SYNCHRONIZED_ACK;
+
+if ("udp".equals(opt))
+return SEND_OPTIONS_UDP;
+
+if ("use_ack".equals(opt))
+return SEND_OPTIONS_USE_ACK;
+
+return 0;
+}
+
+/**
+ * Translates a comma separated list of option names to their 
bitwise-ORd value
+ * @param input A comma separated list of options, e.g. 
"async,multicast"
+ * @return
+ */
+public static int parseChannelSendOptions(String input){
+
+try {
+
+return Integer.parseInt(input);
+}
+catch (NumberFormatException nfe){}
+
--- End diff --

Hi,

From code format point of view: Keep the closing curly brace with "catch" 
on the same line.

Regards,
Violeta


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #56: Convert Cluster Manager human-readable SendOptions ...

[violetagg]

Github user violetagg commented on a diff in the pull request:

https://github.com/apache/tomcat/pull/56#discussion_r119538772
  
--- Diff: java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java ---
@@ -339,6 +339,13 @@ public void setChannelSendOptions(int 
channelSendOptions) {
 this.channelSendOptions = channelSendOptions;
 }
 
+public void setChannelSendOptions(String channelSendOptions) {
+
+int value = Channel.parseChannelSendOptions(channelSendOptions);
+if (value > 0)
--- End diff --

Hi,

From code format point of view: We use curly braces even when there is only 
one statement in "if", "for" blocks.

Regards,
Violeta


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org