[Bug 62577] apache cannot be resolved or is not a field

2018-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62577

--- Comment #3 from xlee poi  ---
I found this issue in the link below

https://access.redhat.com/solutions/307583

"

This issue was known as tomcat bug but it is totally wrong.

According to tomcat
bug-ziller,https://issues.apache.org/bugzilla/show_bug.cgi?id=42475, tomcat
engineer also marked it as a WONTFIX.

What is the main reason to cause this issue is that JBossweb uses jasper to
compile jsp file. In detail, package name of jasper is started with
"org.apache.jasper." hence org variable which declared before tag make
something wrong in grammar.

"

I think I can only give up :-(

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62577] apache cannot be resolved or is not a field

2018-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62577

xlee poi  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |---

--- Comment #2 from xlee poi  ---
(In reply to Mark Thomas from comment #1)
> It is a conflict with the package of the same name.
> Look at the Java source (in the work directory) to see exactly what the
> conflict is.
> You need to use a different variable name.

Thank you for your reply

Finally, I found that conflicts occurred between taglib tags and "org"
variables

This is the simplest jsp example:

<%@ taglib prefix="c" 
   uri="http://java.sun.com/jsp/jstl/core"; %>

<%
String org = (String)session.getAttribute("org_id");
%>



  <%=System.currentTimeMillis()%>






I understand that this is a conflict

But I don't understand why the old version of Tomcat has no problem.

Theoretically Tomcat's minor upgrades(7.0.75==>7.0.76) should not change
compatibility

Our legacy project takes the "org"  variable as the basic parameter of the JSP.
Hundreds of pages use the variable

Recently I want to upgrade the Tomcat server to the new version

Maybe I can only give up

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2018-07-27 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-validate has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 6 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-validate :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on checkstyle exists, no need to add for property 
checkstyle.jar.
 -INFO- Failed with reason build failed



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 34 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.12-SNAPSHOT.jar
 -Dexecute.validate=true validate 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.12-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/commons-beanutils/dist/commons-beanutils-20180728.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.8-SNAPSHOT.jar:/srv/gump/pu
 
blic/workspace/apache-commons/logging/target/commons-logging-20180728.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20180728.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-HEAD-jre-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp

compile-prepare:

download-validate:

testexist:
 [echo] Testing  for 
/srv/gump/public/workspace/checkstyle/target/checkstyle-8.12-SNAPSHOT.jar

setproxy:

downloadfile:

validate:
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle
[checkstyle] Running Checkstyle 8.12-SNAPSHOT on 3301 files
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/catalina/tribes/membership/StaticMembershipProvider.java:48:
 Line matches the illegal pattern '\s+$'. [RegexpSingleline]
[checkstyle] [ERROR] 
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/catalina/tribes/membership/StaticMembershipService.java:92:
 Line matches the illegal pattern '\s+$'. [RegexpSingleline]

BUILD FAILED
/srv/gump/public/workspace/tomcat-trunk/build.xml:569: Got 2 errors and 0 
warnings.

Total time: 34 seconds
-

To subscribe to this information via syndicated feeds:
- RSS: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/rss.xml
- Atom: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/atom.xml

== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 2018072806, vmgump-vm3.apache.org:vmgump:2018072806
Gump E-mail Identifier (unique within run) #3.

--
Apache Gump
http://gump.apache.org/ [Instance: vmgump-vm3]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62577] apache cannot be resolved or is not a field

2018-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62577

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEEDINFO|RESOLVED

--- Comment #1 from Mark Thomas  ---
It is a conflict with the package of the same name.
Look at the Java source (in the work directory) to see exactly what the
conflict is.
You need to use a different variable name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] tomcat pull request #:

2018-07-27 Thread Jagadishbommareddy
Github user Jagadishbommareddy commented on the pull request:


https://github.com/apache/tomcat/commit/414f3586e382f942eee62c2b0d3ea7612d8a9886#commitcomment-29862116
  
ghgk


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62577] apache cannot be resolved or is not a field

2018-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62577

xlee poi  changed:

   What|Removed |Added

 OS||All
 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62577] apache cannot be resolved or is not a field

2018-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62577

xlee poi  changed:

   What|Removed |Added

 OS||Windows 7

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62577] New: apache cannot be resolved or is not a field

2018-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62577

Bug ID: 62577
   Summary: apache cannot be resolved or is not a field
   Product: Tomcat 7
   Version: 7.0.76
  Hardware: PC
Status: NEW
  Severity: blocker
  Priority: P2
 Component: Jasper
  Assignee: dev@tomcat.apache.org
  Reporter: xlee...@gmail.com
  Target Milestone: ---

When test.jsp pages have a variable name like  org  

For example:
<%
String org = (String)session.getAttribute("organization_id");
%>


The test.jsp will show 500 error ,The error information like below:

"org.apache.jasper.JasperException: Unable to compile class for JSP"
"apache cannot be resolved or is not a field"


When I change this variable name to others like : org_parm\org_id
This jsp can be displayed normally


In my environment(Windows 7 x64) , this 500 error will only appear when Tomcat
version>= 7.0.76 (even includes Tomcat 8.5)

Everything is good when Tomcat version <=7.0.75


A same problem on internet like this:
http://techierg.blogspot.com/2011/07/jsp-compilation-error-apache-cannot-be.html


But this comments posted in 2011 , Perhaps in other environments, this error
will appear in earlier Tomcat server versions

On the Internet , people only know the variable name  "org"  have some
compatibility issues

But no one can tell the reason

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1836788 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipProvider.java

2018-07-27 Thread kfujino
Author: kfujino
Date: Fri Jul 27 08:09:15 2018
New Revision: 1836788

URL: http://svn.apache.org/viewvc?rev=1836788&view=rev
Log:
Implement leftOver.

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipProvider.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipProvider.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipProvider.java?rev=1836788&r1=1836787&r2=1836788&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipProvider.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipProvider.java
 Fri Jul 27 08:09:15 2018
@@ -208,9 +208,9 @@ public class StaticMembershipProvider ex
 if (!(msg instanceof MemberMessage)) return;
 MemberMessage memMsg = (MemberMessage) msg;
 if (memMsg.getMsgtype() == MemberMessage.MSG_START) {
-//TODO
+messageReceived(memMsg, sender);
 } else if (memMsg.getMsgtype() == MemberMessage.MSG_PING) {
-//TODO
+messageReceived(memMsg, sender);
 } else {
 // other messages are ignored.
 if (log.isInfoEnabled())



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Don't require a base directory?

2018-07-27 Thread Mark Thomas
There are multiple places in the Tomcat code where a base directory is 
required. Some of those may not be required in the embedded case and 
some can be configured around by using absolute paths. However, there 
will be some ugly error messages in some cases.


I'd suggest creating an enhancement request to:

- make the setting of a base directory optional
- provide useful error messages at all the points where a base directory
  is currently required to highlight the configuration options that
  would enable Tomcat to continue

I don't see a need for an explicit configuration option at this point.

Mark


On 19/07/2018 12:44, Romain Manni-Bucau wrote:

up? :)

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le dim. 15 juil. 2018 à 12:12, Romain Manni-Bucau  a
écrit :


Hi guys,

Just tested with Tomcat 9.0.10 embed and it seems the requirement is a
base directory is now arbitrary.

To be concrete I overrided org.apache.catalina.startup.Tomcat#initBaseDir
to not mkdir the folder if it doesn't exist and I ran several apps
(including meecrowave/cdi based ones) without any issue.

Is it possible to relax this constraint? I envision it as a toggle
settable on Tomcat instance (tomcat.setRequiresDirectories(false)). If set
it to false it would disable the mkdir and probably disable the webapp
extractions.

Guess spring boot can benefit from it as well.

Wdyt?

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github
 | LinkedIn
 | Book






-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62558] Tomcat Russian localization

2018-07-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62558

--- Comment #4 from Mark Thomas  ---
The Manager app does localize based on the request. Look for lines like this:
StringManager smClient = StringManager.getManager(Constants.Package,
request.getLocales());

The index page is not currently localized. Using the JSTL tags (see 
https://docs.oracle.com/javaee/5/tutorial/doc/bnakw.html for an example) is
probably the way to go.

If there is a translation missing then the fallback is to use the English
version.

Additional language support is always interesting. Applying this patch is on my
TODO list for the next release. I hope to get to this next week.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1836787 - in /tomcat/trunk/java/org/apache/catalina/tribes/membership: LocalStrings.properties StaticMembershipService.java

2018-07-27 Thread kfujino
Author: kfujino
Date: Fri Jul 27 07:59:28 2018
New Revision: 1836787

URL: http://svn.apache.org/viewvc?rev=1836787&view=rev
Log:
Add log messages.

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties

tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipService.java

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties?rev=1836787&r1=1836786&r2=1836787&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/membership/LocalStrings.properties 
Fri Jul 27 07:59:28 2018
@@ -49,4 +49,5 @@ memberImpl.notEnough.bytes=Not enough by
 memberImpl.invalid.package.end=Invalid package, should end with:[{0}]
 memberImpl.unableParse.hostname=Unable to parse hostname.
 memberImpl.large.payload=Payload is to large for tribes to handle.
-staticMember.invalid.uuidLength=UUID must be exactly 16 bytes, not:[{0}]
\ No newline at end of file
+staticMember.invalid.uuidLength=UUID must be exactly 16 bytes, not:[{0}]
+staticMembershipService.stopFail=Unable to stop the static membership service, 
level: [{0}]
\ No newline at end of file

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipService.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipService.java?rev=1836787&r1=1836786&r2=1836787&view=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipService.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/membership/StaticMembershipService.java
 Fri Jul 27 07:59:28 2018
@@ -76,8 +76,7 @@ public class StaticMembershipService ext
 channel = null;;
 }
 } catch (Exception e) {
-//TODO
-log.error("stop failed", e);
+log.error(sm.getString("staticMembershipService.stopFail", 
Integer.valueOf(level)), e);
 }
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1836786 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

2018-07-27 Thread markt
Author: markt
Date: Fri Jul 27 07:52:43 2018
New Revision: 1836786

URL: http://svn.apache.org/viewvc?rev=1836786&view=rev
Log:
Fix version typo

Modified:
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1836786&r1=1836785&r2=1836786&view=diff
==
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Fri Jul 27 07:52:43 2018
@@ -118,7 +118,7 @@
 (rjung)
   
   
-58425: Fix regression in 1.4.41 that prevented  AJP 1.2
+58425: Fix regression in 1.2.41 that prevented  AJP 1.2
 workers from initialising. Note that the AJP 1.2 protocol is 
deprecated.
 Patch provided by yagisita. (markt)
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



RE: JDK Release Cadence

2018-07-27 Thread Johannes Elsinghorst
Thanks for your insights Thomas!

Best,
Johannes

-Original Message-
From: Mark Thomas [mailto:ma...@apache.org] 
Sent: Donnerstag, 19. Juli 2018 20:29
To: Tomcat Developers List ; Johannes Elsinghorst 

Subject: Re: JDK Release Cadence

On July 19, 2018 2:29:37 PM UTC, Johannes Elsinghorst 
 wrote:
>Hello,
>I am currently looking into what the new release cadence for the JDK 
>means for Tomcat.
>-Is there a plan for tomcat to support Oracles new release cadence, 
>i.e. supporting all versions of the JDK or only the LTS  versions?
>-Which JDK are supported by Tomcat? Like  Oracle JDK (Free),  Oracle 
>JDK (Commercial), AdoptOpenJDK, Zulu Enterprise If this is not the 
>right place to ask these questions please point me in the right 
>direction.
>
>Thanks,
>Johannes
>
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For 
>additional commands, e-mail: dev-h...@tomcat.apache.org

Tomcat has a (spec mandated) minimum Java version.

To date we have supported Tomcat on any JVM that a) meets the minimum version 
requirement and b) passes the Java TCK irrespective of vendor.

So far, the change in release cadence hasn't changed that. I also don't see 
anything that would change that.

The latest Tomcat 7 8 and 9 releases all work on Java 10 and with the 11 EA 
release. Now the first 12 EA release is out we'll be testing that too.

If someone finds and reports a Java version related bug I my expectation is 
that it will be fixed. Almost certainly for the next release.

HTH,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Duplicate registration of ServletContextListerner

2018-07-27 Thread Mark Thomas
On July 27, 2018 1:53:40 AM UTC, Huxing Zhang  wrote:



>What if the listener isn't in control, e.g. the listener class is in a
>3rd party library.
>In some cases, a listener may not allow multiple instances, if the
>second listener start, it will fail.

Raise a bug against the 3rd party library?

>Is it possible to add a new method in ServletContext called
>getListeners(), and let the user to decide whether to add it or not?

Yes, but we can't do that. We can't change the Servlet API. I suggest opening 
an issue against the Servlet API to make a change in the next version.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org