date:20190107

[Bug 63063] 8.5.37 does not longer start because of error in catalina.sh start section with new redirect to $catalina_out_command eval code code block

2019-01-07 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=63063

--- Comment #2 from Patrik S.  ---
Yes, it's the same issue as in tomcat 9.0 with BZ-63041.
"Could not contact [localhost:[8005]]. Tomcat may not be running." is the only
error shown in journalctl -xe

Adding "set -x" to catalina.sh shows following output after trying to start the
service:

output of journalctl -xe
   [.]
   Jan 07 13:19:58 machinehostname startup.sh[26562]: + eval '{'
'"/opt/java/bin/java"'
'"-Djava.util.logging.config.file=/opt/tomcat/conf/logging.properties"'
-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager
-Djdk.tls.ephemeralDHKeySize=2048 -Djava.proto
   Jan 07 13:19:58 machinehostname startup.sh[26562]: + echo 'Tomcat started.'
   Jan 07 13:19:58 machinehostname startup.sh[26562]: Tomcat started.

startup.sh script finished, but shutdown is called directly afterwards:
   Jan 07 13:19:58 machinehostname shutdown.sh[26577]: + os400=false
   ...
   Jan 07 13:19:58 machinehostname shutdown.sh[26577]: Jan 07, 2019 1:19:58 PM
org.apache.catalina.startup.Catalina stopServer
   Jan 07 13:19:58 machinehostname shutdown.sh[26577]: SEVERE: Could not
contact [localhost:[8005]]. Tomcat may not be running.
   Jan 07 13:19:58 machinehostname shutdown.sh[26577]: Jan 07, 2019 1:19:58 PM
org.apache.catalina.startup.Catalina stopServer
   Jan 07 13:19:58 machinehostname shutdown.sh[26577]: SEVERE: Catalina.stop:
   Jan 07 13:19:58 machinehostname shutdown.sh[26577]:
java.net.ConnectException: Connection refused (Connection refused)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-01-07 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=63041

--- Comment #8 from Patrik S.  ---
Yes, BZ-63063 is exactly the same issue opened for tomcat 8.5 branch.
In tomcat 9.0 the catalina.sh contains at the same line 479 and 489 that faulty
code:

 2\>\&1 \& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command "&"

it needs to be 

delimitered:
 2\>\&1 \; echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command "&"
or logical AND:
 2\>\&1 \&\& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command "&"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63063] 8.5.37 does not longer start because of error in catalina.sh start section with new redirect to $catalina_out_command eval code code block

2019-01-07 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=63063

--- Comment #1 from Igal Sapir  ---
Possibly related to BZ-63041

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-01-07 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=63041

--- Comment #7 from Igal Sapir  ---
Possibly related to BZ-63063

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Setting "svn:mime-type" in non-English .properties (Was: svn commit: r1850330 [1/2] - in /tomcat/trunk/java: ...)

2019-01-07 Thread Woonsan Ko

On Mon, Jan 7, 2019 at 11:58 PM Christopher Schultz
 wrote:
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Mark,
>
> On 1/6/19 17:12, Mark Thomas wrote:
> > On 06/01/2019 21:51, Christopher Schultz wrote:
> >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256
> >>
> >> Mark,
> >>
> >> On 1/6/19 16:37, Mark Thomas wrote:
> >>> On 06/01/2019 17:40, Christopher Schultz wrote:
>  -BEGIN PGP SIGNED MESSAGE- Hash: SHA256
> 
>  Woonsan,
> 
>  On 1/4/19 05:11, Woonsan Ko wrote:
> > I've noticed in the commit messages that some i18n bundle
> > files showing Japanese correctly (e.g,
> > tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings_j
> a.
> >>
> >
> pr
> 
> >
> >> operties
> >
> >
>  below) while scrambling it in others (e.g,
> > tomcat/trunk/java/javax/el/LocalStrings_ja.properties
> > below).
> >
> > The difference comes from whether or not the file was set
> > with svn property, "svn:mime-type", to "text/plain;
> > charset=UTF-8".
> >
> > $ svn propget svn:mime-type
> > java/org/apache/catalina/authenticator/LocalStrings_ja.properties
> >
> >
> >>
> >
> text/plain; charset=UTF-8 $ svn propget svn:mime-type
> > java/javax/el/LocalStrings_ja.properties svn: warning:
> > W200017: Property 'svn:mime-type' not found on
> > 'java/javax/el/LocalStrings_ja.properties'
> >
> > Would anyone mind if I set "svn:mime-type" to "text/plain;
> > charset=UTF-8" in all the non-English .properties files in
> > trunk?
> >>>
> >>> +1. It is an oversight that I haven't been doing this when
> >>> adding new files.
> >>>
>  - -1
> 
>  Properties files are, by definition[1], in ISO-8859-1
>  encoding. Characters that are not in the ISO-8859-1 character
>  set need to be Unicode-escaped.
> 
>  For example, if you want ã you need to use \u00e3
> 
>  I'm not sure why the files haven't been formatted in this way
>  so far.
> >>>
> >>> Because that is what we decided to do to make the files easier
> >>> to work with:
> >>> https://tomcat.markmail.org/thread/2fqmyn2ds3vcmfvw
> >>
> >> I don't see any invocation of native2ascii in any of the build
> >> tools.
> >>
> >> Is it an undocumented "feature" of
> >> ResourceBundle/PropertyResourceBundle that UTF-8-encoded files
> >> "just work"?
> >
> > No.
> >
> > Read the thread I referenced in my previous message and/or search
> > build.xml for 'native2ascii'.
>
> My apologies. I looked for the conversion in the build script and
> didn't find it for some reason. Probably a typo in the search.
>
> Woonsan, my -1 is now a +1 for changing the MIME-types of any
> .properties files that aren't already set, and to actually use that
> encoding wherever it makes sense in preference to \u notation.

Thanks, Chris and Mark!
I've committed the changes (r1850710) after these:

find java -name "LocalStrings_*.properties" -exec svn propset
svn:mime-type "text/plain; charset=UTF-8" {} \;
find java -name "Messages_*.properties" -exec svn propset
svn:mime-type "text/plain; charset=UTF-8" {} \;

When someone adds a new language set later, we can run those again.

Cheers,

Woonsan

>
> - -chris
> -BEGIN PGP SIGNATURE-
> Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
>
> iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlwzaR8ACgkQHPApP6U8
> pFjJAA/+LNkhdieCQm6ZA5BIf8xR/5VIdNizGK6aRzDGVHd0685xzfm51KdjI22h
> KOpsOipRqH0lVoJ0kcfLTj7vdjafgt/B9FRZtmixeuHJ6quw9BVsfHT/kF2eojzQ
> ndOBWqLSO2ucQtZ/bS7BoZzCxWbakE+DaCsLlOCbgzcb3uh3UOWCWotlEHHt0CG6
> kM6QsZANyj+rVGu90Wz4W2LKP0fEkk39MgzIPMcEYh9xWRRC5RENBNzpmxMRGLUq
> BMbVrMhNGtJTsWZdUis1AXheYuCyAlZbNbkwLJKOsBRo3Y3LpLR9jDTi3Nln8H0L
> 49e1sqoHhSvR/trbfzDBxDtFTovPiKkddrqaRVT6moZYDif/i4Cbe27DVpWh1Ptf
> EpGylmCLXjPyFzchrrjMQtE0uoUAA1aXAcaZnf4cJX/yULi2ZdhIkjA8eA+8ZRJ/
> L3w8EhAg83y2JI22En2zkjFOyhGTANECiXzH+JXVvm44v9G/qIxxG/YQQeJvPyM9
> 3BV5bXSNmafR2m2GV34Bldckk+9LtZM0xLuTGuYS8WEoMpGG9/I0dnYdHj8jLPFu
> 7W4qyryqlVRhxGT0SkiY8Q6uLnD84sxhNhPLuJIw196qNYidOcS2iDF+n5GqdbZA
> bYHWSawFDGbKfZjwJciX00VKr+m2p+09Znx3CegrTL693p+lVqQ=
> =fZ4Z
> -END PGP SIGNATURE-
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-01-07 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=63041

--- Comment #6 from Igal Sapir  ---
(In reply to Christopher Schultz from comment #5)
> On the users' mailing list, I asked Steve to try the catalina.sh from 9.0.13
> on his 9.0.14 install, but there has been no reply for a few days.

He wrote this in comment #2, possibly replying in the "wrong" thread:
> Tomcat 9.0.14 runs as expected using a transplanted 9.0.13 catalina.sh

At first glance it looks like a regression from BZ-53930, which made quite a
few changes to catalina.sh, but I will dig deeper and update with my findings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1850710 [1/2] - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/authenticator/jaspic/ org/apache/catalina/connec

2019-01-07 Thread woonsan

Author: woonsan
Date: Tue Jan  8 05:01:45 2019
New Revision: 1850710

URL: http://svn.apache.org/viewvc?rev=1850710=rev
Log:
Setting svn mimetype to 'text/plain; charset=UTF-8' on non-English translation 
bundle prop files

Modified:
tomcat/trunk/java/javax/el/LocalStrings_de.properties   (props changed)
tomcat/trunk/java/javax/el/LocalStrings_fr.properties   (props changed)
tomcat/trunk/java/javax/el/LocalStrings_ja.properties   (props changed)
tomcat/trunk/java/javax/el/LocalStrings_ko.properties   (props changed)
tomcat/trunk/java/javax/el/LocalStrings_pt_BR.properties   (props changed)
tomcat/trunk/java/javax/el/LocalStrings_zh_CN.properties   (props changed)
tomcat/trunk/java/javax/servlet/LocalStrings_de.properties   (props changed)
tomcat/trunk/java/javax/servlet/LocalStrings_ko.properties   (props changed)
tomcat/trunk/java/javax/servlet/LocalStrings_zh_CN.properties   (props 
changed)
tomcat/trunk/java/javax/servlet/http/LocalStrings_de.properties   (props 
changed)
tomcat/trunk/java/javax/servlet/http/LocalStrings_ko.properties   (props 
changed)
tomcat/trunk/java/javax/servlet/http/LocalStrings_zh_CN.properties   (props 
changed)

tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings_de.properties  
 (props changed)

tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings_ko.properties  
 (props changed)

tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings_pt_BR.properties
   (props changed)

tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings_zh_CN.properties
   (props changed)

tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings_de.properties
   (props changed)

tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings_es.properties
   (props changed)

tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings_fr.properties
   (props changed)

tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings_ja.properties
   (props changed)

tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings_ko.properties
   (props changed)

tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings_pt_BR.properties
   (props changed)

tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings_ru.properties
   (props changed)

tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/LocalStrings_zh_CN.properties
   (props changed)
tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_de.properties  
 (props changed)
tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_ko.properties  
 (props changed)

tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_pt_BR.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_ru.properties  
 (props changed)

tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_zh_CN.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/core/LocalStrings_de.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/core/LocalStrings_ko.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/core/LocalStrings_pt_BR.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/core/LocalStrings_ru.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/core/LocalStrings_zh_CN.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/deploy/LocalStrings_de.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/deploy/LocalStrings_es.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/deploy/LocalStrings_fr.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/deploy/LocalStrings_ja.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/deploy/LocalStrings_ko.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/deploy/LocalStrings_pt_BR.properties  
 (props changed)
tomcat/trunk/java/org/apache/catalina/deploy/LocalStrings_zh_CN.properties  
 (props changed)
tomcat/trunk/java/org/apache/catalina/filters/LocalStrings_de.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/filters/LocalStrings_ja.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/filters/LocalStrings_ko.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/filters/LocalStrings_pt_BR.properties 
  (props changed)
tomcat/trunk/java/org/apache/catalina/filters/LocalStrings_ru.properties   
(props changed)
tomcat/trunk/java/org/apache/catalina/filters/LocalStrings_zh_CN.properties 
  (props changed)

tomcat/trunk/java/org/apache/catalina/ha/authenticator/LocalStrings_fr.properties
   (props changed)

tomcat/trunk/java/org/apache/catalina/ha/authenticator/LocalStrings_ja.properties
   (props changed)

svn commit: r1850710 [2/2] - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/authenticator/jaspic/ org/apache/catalina/connec

2019-01-07 Thread woonsan

Propchange: 
tomcat/trunk/java/org/apache/catalina/webresources/LocalStrings_zh_CN.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: tomcat/trunk/java/org/apache/coyote/LocalStrings_de.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: tomcat/trunk/java/org/apache/coyote/LocalStrings_fr.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: tomcat/trunk/java/org/apache/coyote/LocalStrings_ja.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: tomcat/trunk/java/org/apache/coyote/LocalStrings_ko.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: tomcat/trunk/java/org/apache/coyote/LocalStrings_pt_BR.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: tomcat/trunk/java/org/apache/coyote/LocalStrings_zh_CN.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings_de.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings_fr.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings_ja.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings_ko.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: 
tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings_pt_BR.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: 
tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings_zh_CN.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: 
tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_de.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: 
tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_ko.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: 
tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_pt_BR.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: 
tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_ru.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: 
tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_zh_CN.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: 
tomcat/trunk/java/org/apache/coyote/http11/filters/LocalStrings_de.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: 
tomcat/trunk/java/org/apache/coyote/http11/filters/LocalStrings_es.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: 
tomcat/trunk/java/org/apache/coyote/http11/filters/LocalStrings_fr.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: 
tomcat/trunk/java/org/apache/coyote/http11/filters/LocalStrings_ja.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: 
tomcat/trunk/java/org/apache/coyote/http11/filters/LocalStrings_ko.properties
--
svn:mime-type = text/plain; charset=UTF-8

Propchange: 
tomcat/trunk/java/org/apache/coyote/http11/filters/LocalStrings_pt_BR.properties
--
svn:mime-type =

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-01-07 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=63041

--- Comment #5 from Christopher Schultz  ---
On the users' mailing list, I asked Steve to try the catalina.sh from 9.0.13 on
his 9.0.14 install, but there has been no reply for a few days.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-01-07 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=63041

--- Comment #4 from Igal Sapir  ---
I will look into this issue if no one else has already started

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-01-07 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=63041

--- Comment #3 from Igal Sapir  ---
(In reply to Steve Demy from comment #2)
> Tomcat 9.0.14 runs as expected using a transplanted 9.0.13 catalina.sh.  It
> starts, stops and restarts using systemd (systemctl start|stop|restart
> tomcat).  

So if you take catalina.sh from 9.0.13 it works fine but with catalina.sh
9.0.14 you experience this issue?  All other factors are the same?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-01-07 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=63041

jpho...@korem.com changed:

   What|Removed |Added

 CC||jpho...@korem.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63063] 8.5.37 does not longer start because of error in catalina.sh start section with new redirect to $catalina_out_command eval code code block

2019-01-07 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=63063

lop...@readaccess.com changed:

   What|Removed |Added

 CC||lop...@readaccess.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-85-trunk

2019-01-07 Thread Mark Thomas

On 07/01/2019 17:17, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-85-trunk while 
> building . Full details are available at:
> https://ci.apache.org/builders/tomcat-85-trunk/builds/1599
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: silvanus_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-85-commit' 
> triggered this build
> Build Source Stamp: [branch tomcat/tc8.5.x/trunk] 1850669
> Blamelist: markt
> 
> BUILD FAILED: failed compile_1

False positive. JVM 'abnormal exit'.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in on tomcat-85-trunk

2019-01-07 Thread buildbot

The Buildbot has detected a new failure on builder tomcat-85-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-85-trunk/builds/1599

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-85-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.5.x/trunk] 1850669
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 58194] Tomcat crash EXCEPTION_ACCESS_VIOLATION in tcnative-1.dll

2019-01-07 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=58194

Eduardo Guadalupe Quintanilla  changed:

   What|Removed |Added

 CC||eduardo...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1850669 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/http2.xml

2019-01-07 Thread markt

Author: markt
Date: Mon Jan  7 16:50:25 2019
New Revision: 1850669

URL: http://svn.apache.org/viewvc?rev=1850669=rev
Log:
Correct default value in docs

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.5.x/trunk/webapps/docs/config/http2.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jan  7 16:50:25 2019
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205

svn commit: r1850668 - in /tomcat/trunk/webapps/docs: changelog.xml config/http2.xml

2019-01-07 Thread markt

Author: markt
Date: Mon Jan  7 16:49:54 2019
New Revision: 1850668

URL: http://svn.apache.org/viewvc?rev=1850668=rev
Log:
Correct default value in docs

Modified:
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/http2.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1850668=1850667=1850668=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Jan  7 16:49:54 2019
@@ -5285,6 +5285,10 @@
 InstanceManager.destroy() to ensure that the method is
 executed. (markt)
   
+  
+Document the default for the HTTP/2 configuration parameter
+maxConcurrentStreamExecution as 20. (markt)
+  
 
   
   

Modified: tomcat/trunk/webapps/docs/config/http2.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/http2.xml?rev=1850668=1850667=1850668=diff
==
--- tomcat/trunk/webapps/docs/config/http2.xml (original)
+++ tomcat/trunk/webapps/docs/config/http2.xml Mon Jan  7 16:49:54 2019
@@ -135,7 +135,7 @@
   can be allocated threads from the container thread pool. If more streams
   are active than threads are available, those streams will have to wait
   for a stream to become available. If not specified, the default value of
-  200 will be used.
+  20 will be used.
 
 
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDK 12 Early Access build 26 & JDK 13 Early Access builds available

2019-01-07 Thread Mark Thomas

Hi Rory,

Happy New Year to you and your colleagues.

I've run the Tomcat 9.0.x test suite with OpenJDK 12 EA 26 and OpenJDK
13 EA 2.

TL;DR - all good. No problems.

There was one test failure but this was expected as the test is intended
to fail if a new public class, interface etc. is added to the java.lang
package and java.lang.Enum$EnumDesc has been added.

Tomcat maintains a list of the public classes etc. in the java.lang
package to support a performance optimisation in javax.el.ImportHandler
(we can skip some expensive class loader lookups by caching a list of
all the known public classes etc.). We need to keep this list up to date
so the test is designed to prompt us to add new classes as required.
This all worked exactly to plan. I have already added the new class to
the list.

Kind regards,

Mark

On 04/01/2019 10:21, Rory O'Donnell wrote:
> Hi Mark,
> 
> Happy New Year!
> 
> *OpenJDK builds *- JDK 12 Early Access build 26 is available at
> http://jdk.java.net/12/
> 
>  * These early-access, open-source builds are provided under the GNU
>    General Public License, version 2, with the Classpath Exception
>    .
>  * Changes since last email
>  o Distrust TLS server certificates anchored by Symantec Root CAs
>    (JDK-8207258 )
>  o Customizing the generation of a PKCS12 keystore (JDK-8076190
>    )
>  o Compact Number Formatting Support (JDK-8177552
>    )
> 
> *OpenJDK builds *- JDK 13 - Early Access build 2 is available at
> http://jdk.java.net/13/
> 
>  * These early-access, open-source builds are provided under the GNU
>    General Public License, version 2, with the Classpath Exception
>    .
>  * Changes in this build
>   
> 
> 
> 
> *jpackage EA builds*
> 
>  * This is an early access build of JEP 343: Packaging Tool
>    , aimed at testing a prototype
>    implementation of jpackage, which is a new tool for packaging
>    self-contained Java applications along with a Java Runtime Environment.
>  * Please send feedback via e-mail to core-libs-...@openjdk.java.net
>    
> 
> *Quality Outreach report for December 2018*
> 
>  * The report for December 2018 is available here
>   
> 
> 
> 
> Rgds,Rory
> 

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Setting "svn:mime-type" in non-English .properties (Was: svn commit: r1850330 [1/2] - in /tomcat/trunk/java: ...)

2019-01-07 Thread Christopher Schultz

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Mark,

On 1/6/19 17:12, Mark Thomas wrote:
> On 06/01/2019 21:51, Christopher Schultz wrote:
>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA256
>> 
>> Mark,
>> 
>> On 1/6/19 16:37, Mark Thomas wrote:
>>> On 06/01/2019 17:40, Christopher Schultz wrote:
 -BEGIN PGP SIGNED MESSAGE- Hash: SHA256
 
 Woonsan,
 
 On 1/4/19 05:11, Woonsan Ko wrote:
> I've noticed in the commit messages that some i18n bundle 
> files showing Japanese correctly (e.g, 
> tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings_j
a.
>>
> 
pr
 
> 
>> operties
> 
> 
 below) while scrambling it in others (e.g,
> tomcat/trunk/java/javax/el/LocalStrings_ja.properties
> below).
> 
> The difference comes from whether or not the file was set
> with svn property, "svn:mime-type", to "text/plain;
> charset=UTF-8".
> 
> $ svn propget svn:mime-type 
> java/org/apache/catalina/authenticator/LocalStrings_ja.properties
>
>
>>
> 
text/plain; charset=UTF-8 $ svn propget svn:mime-type
> java/javax/el/LocalStrings_ja.properties svn: warning: 
> W200017: Property 'svn:mime-type' not found on 
> 'java/javax/el/LocalStrings_ja.properties'
> 
> Would anyone mind if I set "svn:mime-type" to "text/plain; 
> charset=UTF-8" in all the non-English .properties files in 
> trunk?
>>> 
>>> +1. It is an oversight that I haven't been doing this when
>>> adding new files.
>>> 
 - -1
 
 Properties files are, by definition[1], in ISO-8859-1
 encoding. Characters that are not in the ISO-8859-1 character
 set need to be Unicode-escaped.
 
 For example, if you want ã you need to use \u00e3
 
 I'm not sure why the files haven't been formatted in this way
 so far.
>>> 
>>> Because that is what we decided to do to make the files easier
>>> to work with:
>>> https://tomcat.markmail.org/thread/2fqmyn2ds3vcmfvw
>> 
>> I don't see any invocation of native2ascii in any of the build
>> tools.
>> 
>> Is it an undocumented "feature" of 
>> ResourceBundle/PropertyResourceBundle that UTF-8-encoded files
>> "just work"?
> 
> No.
> 
> Read the thread I referenced in my previous message and/or search 
> build.xml for 'native2ascii'.

My apologies. I looked for the conversion in the build script and
didn't find it for some reason. Probably a typo in the search.

Woonsan, my -1 is now a +1 for changing the MIME-types of any
.properties files that aren't already set, and to actually use that
encoding wherever it makes sense in preference to \u notation.

- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlwzaR8ACgkQHPApP6U8
pFjJAA/+LNkhdieCQm6ZA5BIf8xR/5VIdNizGK6aRzDGVHd0685xzfm51KdjI22h
KOpsOipRqH0lVoJ0kcfLTj7vdjafgt/B9FRZtmixeuHJ6quw9BVsfHT/kF2eojzQ
ndOBWqLSO2ucQtZ/bS7BoZzCxWbakE+DaCsLlOCbgzcb3uh3UOWCWotlEHHt0CG6
kM6QsZANyj+rVGu90Wz4W2LKP0fEkk39MgzIPMcEYh9xWRRC5RENBNzpmxMRGLUq
BMbVrMhNGtJTsWZdUis1AXheYuCyAlZbNbkwLJKOsBRo3Y3LpLR9jDTi3Nln8H0L
49e1sqoHhSvR/trbfzDBxDtFTovPiKkddrqaRVT6moZYDif/i4Cbe27DVpWh1Ptf
EpGylmCLXjPyFzchrrjMQtE0uoUAA1aXAcaZnf4cJX/yULi2ZdhIkjA8eA+8ZRJ/
L3w8EhAg83y2JI22En2zkjFOyhGTANECiXzH+JXVvm44v9G/qIxxG/YQQeJvPyM9
3BV5bXSNmafR2m2GV34Bldckk+9LtZM0xLuTGuYS8WEoMpGG9/I0dnYdHj8jLPFu
7W4qyryqlVRhxGT0SkiY8Q6uLnD84sxhNhPLuJIw196qNYidOcS2iDF+n5GqdbZA
bYHWSawFDGbKfZjwJciX00VKr+m2p+09Znx3CegrTL693p+lVqQ=
=fZ4Z
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1850645 - in /tomcat/tc8.5.x/trunk: ./ java/javax/el/ImportHandler.java test/javax/el/TestImportHandlerStandardPackages.java webapps/docs/changelog.xml

2019-01-07 Thread markt

Author: markt
Date: Mon Jan  7 14:27:04 2019
New Revision: 1850645

URL: http://svn.apache.org/viewvc?rev=1850645=rev
Log:
Update the performance optimisation for using expressions in tags that depend 
on uninitialised tag attributes with implied scope to make the performance 
optimisation aware of the new public class (java.lang.Enum$EnumDesc) added in 
Java 12.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/javax/el/ImportHandler.java
tomcat/tc8.5.x/trunk/test/javax/el/TestImportHandlerStandardPackages.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jan  7 14:27:04 2019
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205

svn commit: r1850644 - in /tomcat/trunk: java/javax/el/ImportHandler.java test/javax/el/TestImportHandlerStandardPackages.java webapps/docs/changelog.xml

2019-01-07 Thread markt

Author: markt
Date: Mon Jan  7 14:26:05 2019
New Revision: 1850644

URL: http://svn.apache.org/viewvc?rev=1850644=rev
Log:
Update the performance optimisation for using expressions in tags that depend 
on uninitialised tag attributes with implied scope to make the performance 
optimisation aware of the new public class (java.lang.Enum$EnumDesc) added in 
Java 12.

Modified:
tomcat/trunk/java/javax/el/ImportHandler.java
tomcat/trunk/test/javax/el/TestImportHandlerStandardPackages.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/javax/el/ImportHandler.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ImportHandler.java?rev=1850644=1850643=1850644=diff
==
--- tomcat/trunk/java/javax/el/ImportHandler.java (original)
+++ tomcat/trunk/java/javax/el/ImportHandler.java Mon Jan  7 14:26:05 2019
@@ -164,6 +164,7 @@ public class ImportHandler {
 javaLangClassNames.add("Compiler");
 javaLangClassNames.add("Double");
 javaLangClassNames.add("Enum");
+javaLangClassNames.add("Enum.EnumDesc");
 javaLangClassNames.add("Float");
 javaLangClassNames.add("InheritableThreadLocal");
 javaLangClassNames.add("Integer");

Modified: tomcat/trunk/test/javax/el/TestImportHandlerStandardPackages.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/javax/el/TestImportHandlerStandardPackages.java?rev=1850644=1850643=1850644=diff
==
--- tomcat/trunk/test/javax/el/TestImportHandlerStandardPackages.java (original)
+++ tomcat/trunk/test/javax/el/TestImportHandlerStandardPackages.java Mon Jan  
7 14:26:05 2019
@@ -61,8 +61,10 @@ public class TestImportHandlerStandardPa
 // 9 (and later) so it is not necessary that this is executed on
 // every test run. The intention is that it will catch new classes
 // when the tests are run on a newer JRE.
-// The latest version of the JRE where this test is known to pass 
is
-// Java 11, Early Access 21
+// The latest versions of the JRE where this test is known to pass 
are
+// - OpenJDK 11.0.1
+// - OpenJDK 12 EA 26
+// - OpenJDK 13 EA 02
 if (!JreCompat.isJre9Available()) {
 return;
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1850644=1850643=1850644=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Jan  7 14:26:05 2019
@@ -111,6 +111,12 @@
 that did not correctly scan the web application directory structure for
 JSPs. (markt)
   
+  
+Update the performance optimisation for using expressions in tags that
+depend on uninitialised tag attributes with implied scope to make the
+performance optimisation aware of the new public class
+(java.lang.Enum$EnumDesc) added in Java 12. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-85-trunk

2019-01-07 Thread buildbot

The Buildbot has detected a restored build on builder tomcat-85-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-85-trunk/builds/1597

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-85-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.5.x/trunk] 1850641
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1850641 - /tomcat/tc8.5.x/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

2019-01-07 Thread markt

Author: markt
Date: Mon Jan  7 13:41:26 2019
New Revision: 1850641

URL: http://svn.apache.org/viewvc?rev=1850641=rev
Log:
Fix logic of GCM support check

Modified:

tomcat/tc8.5.x/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

Modified: 
tomcat/tc8.5.x/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java?rev=1850641=1850640=1850641=diff
==
--- 
tomcat/tc8.5.x/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java
 (original)
+++ 
tomcat/tc8.5.x/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java
 Mon Jan  7 13:41:26 2019
@@ -292,7 +292,7 @@ public class TestEncryptInterceptor {
 dest.setEncryptionAlgorithm("AES/GCM/PKCS5Padding");
 dest.start(Channel.SND_TX_SEQ);
 } catch (ChannelException ce) {
-Assume.assumeTrue("Skipping testGCM due to lack of JVM support",
+Assume.assumeFalse("Skipping testGCM due to lack of JVM support",
 ce.getCause() instanceof NoSuchAlgorithmException
 && ce.getCause().getMessage().contains("GCM"));
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63063] New: 8.5.37 does not longer start because of error in catalina.sh start section with new redirect to $catalina_out_command eval code code block

2019-01-07 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=63063

Bug ID: 63063
   Summary: 8.5.37 does not longer start because of error in
catalina.sh start section with new redirect to
$catalina_out_command eval code code block
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: PC
OS: Linux
Status: NEW
  Severity: major
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: patrik@gmx.net
  Target Milestone: 

In relation to ticket https://bz.apache.org/bugzilla/show_bug.cgi?id=53930
since tomcat 8.5.36 the catalina.sh start section was changed to handle the
stdout & stderr redirect into $CATALINA_OUT in another way.

But with 8.5.37 release I was not longer able to start the tomcat by using
systemd. On the other hand I was able to start it manually by calling
bin/startup.sh. This was strange

At the end I hopyfully found the simple fault in catalina.sh start section.
During the rebuild of the eval  code blocks in lines 470 ++ and 482 ++
there is a typo.

Line 479 and 489 contains both that code:
 2\>\&1 \& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command "&"

but since the redirect "2\>\&1" finishes the command call, the next "\&" has to
be a:
1. "\;" to delimiter the follow up command "echo \$!"
2. or I belive it should be a double ampersand "\&\&" to combine both shell
commands

After I changed both lines into:
for case 1: 2\>\&1 \; echo \$! \>\"$catalina_pid_file\" \; \}
$catalina_out_command "&"

for case 2: 2\>\&1 \&\& echo \$! \>\"$catalina_pid_file\" \; \}
$catalina_out_command "&"


it works again for me with both variants.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1850635 - /tomcat/trunk/test/org/apache/catalina/users/MemoryUserDatabaseTests.java

2019-01-07 Thread markt

Author: markt
Date: Mon Jan  7 13:01:48 2019
New Revision: 1850635

URL: http://svn.apache.org/viewvc?rev=1850635=rev
Log:
Fix IDE nags

Modified:
tomcat/trunk/test/org/apache/catalina/users/MemoryUserDatabaseTests.java

Modified: 
tomcat/trunk/test/org/apache/catalina/users/MemoryUserDatabaseTests.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/users/MemoryUserDatabaseTests.java?rev=1850635=1850634=1850635=diff
==
--- tomcat/trunk/test/org/apache/catalina/users/MemoryUserDatabaseTests.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/users/MemoryUserDatabaseTests.java 
Mon Jan  7 13:01:48 2019
@@ -157,6 +157,7 @@ public class MemoryUserDatabaseTests {
 throws Exception {
 // Generate lots of concurrent load on the user database
 Runnable job = new Runnable() {
+@Override
 public void run() {
 for(int i=0; i<10; ++i)
 db.createUser("newUser-" + 
Thread.currentThread().getName() + "-" + i, "x", null);
@@ -170,6 +171,7 @@ public class MemoryUserDatabaseTests {
 
 // Let's
 threads[numThreads] = new Thread(new Runnable() {
+@Override
 public void run() {
 try { db.open(); }
 catch (Exception e) {
@@ -210,7 +212,7 @@ public class MemoryUserDatabaseTests {
 
 private void assertPrincipalNames(String[] expectedNames, Iterator i)
 {
-HashSet names = new HashSet(expectedNames.length);
+HashSet names = new HashSet<>(expectedNames.length);
 for(String name : expectedNames)
 names.add(name);
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63063] 8.5.37 does not longer start because of error in catalina.sh start section with new redirect to $catalina_out_command eval code code block

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

[Bug 63063] 8.5.37 does not longer start because of error in catalina.sh start section with new redirect to $catalina_out_command eval code code block

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

Re: Setting "svn:mime-type" in non-English .properties (Was: svn commit: r1850330 [1/2] - in /tomcat/trunk/java: ...)

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

svn commit: r1850710 [1/2] - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/authenticator/jaspic/ org/apache/catalina/connec

svn commit: r1850710 [2/2] - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/authenticator/jaspic/ org/apache/catalina/connec

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

[Bug 63063] 8.5.37 does not longer start because of error in catalina.sh start section with new redirect to $catalina_out_command eval code code block

Re: buildbot failure in on tomcat-85-trunk

buildbot failure in on tomcat-85-trunk

[Bug 58194] Tomcat crash EXCEPTION_ACCESS_VIOLATION in tcnative-1.dll

svn commit: r1850669 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/http2.xml

svn commit: r1850668 - in /tomcat/trunk/webapps/docs: changelog.xml config/http2.xml

Re: JDK 12 Early Access build 26 & JDK 13 Early Access builds available

Re: Setting "svn:mime-type" in non-English .properties (Was: svn commit: r1850330 [1/2] - in /tomcat/trunk/java: ...)

svn commit: r1850645 - in /tomcat/tc8.5.x/trunk: ./ java/javax/el/ImportHandler.java test/javax/el/TestImportHandlerStandardPackages.java webapps/docs/changelog.xml

svn commit: r1850644 - in /tomcat/trunk: java/javax/el/ImportHandler.java test/javax/el/TestImportHandlerStandardPackages.java webapps/docs/changelog.xml

buildbot success in on tomcat-85-trunk

svn commit: r1850641 - /tomcat/tc8.5.x/trunk/test/org/apache/catalina/tribes/group/interceptors/TestEncryptInterceptor.java

[Bug 63063] New: 8.5.37 does not longer start because of error in catalina.sh start section with new redirect to $catalina_out_command eval code code block

svn commit: r1850635 - /tomcat/trunk/test/org/apache/catalina/users/MemoryUserDatabaseTests.java

26 matches

Site Navigation

Mail list logo

Footer information