[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2019-05-04 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 24 mins 24 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dsaaj-api.jar=/srv/gump/packages/saaj-api/saaj-api-1.3.5.jar 
-Djaxrpc-lib.jar=/srv/gump/packages/jaxrpc/geronimo-spec-jaxrpc-1.1-rc4.jar 
-Dtest.temp=output/test-tmp-NIO2 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20190504/bin/openssl
 -Dexecute
 .test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dexecute.test.apr=false 
-Dwsdl4j-lib.jar=/srv/gump/packages/wsdl4j/wsdl4j-1.6.3.jar 
-Dtest.reports=output/logs-NIO2 -Dexecute.test.nio2=true 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.10-201812060815/ecj-4.10.jar 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true -Dtest.accesslog=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-4.1-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/cata

[GitHub] [tomcat] johnkdev opened a new pull request #162: Add support for same-site cookie attribute

2019-05-04 Thread GitBox 
johnkdev opened a new pull request #162: Add support for same-site cookie 
attribute
URL: https://github.com/apache/tomcat/pull/162
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.41

2019-05-04 Thread Igal Sapir 

On 5/4/2019 2:56 AM, Mark Thomas wrote:

The proposed Apache Tomcat 8.5.41 release is now available for voting.

The proposed 8.5.41 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 8.5.41


Unit tests passed on Ubuntu and Windows with Java 8 and tc-native-1.2.21

Igal



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.41

2019-05-04 Thread Christopher Schultz 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

All,

On 5/4/19 05:56, Mark Thomas wrote:
> The proposed Apache Tomcat 8.5.41 release is now available for
> voting.
> 
> The major changes compared to the 8.5.40 release are:
> 
> - Stack traces written by the OneLineFormatter are fully indented.
> The entire stack trace is now indented by an additional TAB
> character.
> 
> - Avoid OutOfMemoryErrors and ArrayIndexOutOfBoundsExceptions when 
> accessing large files via the default servlet when resource
> caching has been disabled.
> 
> - When running on newer JREs that don't support SSLv2Hello, don't 
> warn that it is not available unless explicitly configured.
> 
> Along with lots of other bug fixes and improvements.
> 
> For full details, see the changelog: 
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
> 
> It can be obtained from: 
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.41/
> 
> The Maven staging repo is: 
> https://repository.apache.org/content/repositories/orgapachetomcat-121
2/
>
>  The tag is: https://github.com/apache/tomcat/tree/8.5.41 
> 753f95658fb9a26594d8f9cc65a48de04d2e7bd7
> 
> 
> The proposed 8.5.41 release is: [ ] Broken - do not release [X]
> Stable - go ahead and release as 8.5.41

Works with my development application (standard servlet stuff).

Failing unit tests listed below are expected.

Details:

* Environment
*  Java (build): openjdk version "1.8.0_212" OpenJDK Runtime
Environment (build 1.8.0_212-8u212-b01-1~deb9u1-b01) OpenJDK 64-Bit
Server VM (build 25.212-b01, mixed mode)
*  Java (test): openjdk version "1.8.0_212" OpenJDK Runtime
Environment (build 1.8.0_212-8u212-b01-1~deb9u1-b01) OpenJDK 64-Bit
Server VM (build 25.212-b01, mixed mode)
*  OS:   Linux 4.9.0-7-amd64 x86_64
*  cc:   cc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
*  make: GNU Make 4.1
*  OpenSSL:  OpenSSL 1.1.1 11 Sep 2018
*  APR:  1.5.2
*
* Valid SHA-512 signature for apache-tomcat-8.5.41.zip
* Valid GPG signature for apache-tomcat-8.5.41.zip
* Valid SHA-512 signature for apache-tomcat-8.5.41.tar.gz
* Valid GPG signature for apache-tomcat-8.5.41.tar.gz
* Valid SHA-512 signature for apache-tomcat-8.5.41.exe
* Valid GPG signature for apache-tomcat-8.5.41.exe
* Valid SHA512 signature for apache-tomcat-8.5.41-src.zip
* Valid GPG signature for apache-tomcat-8.5.41-src.zip
* Valid SHA512 signature for apache-tomcat-8.5.41-src.tar.gz
* Valid GPG signature for apache-tomcat-8.5.41-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: Same
*
* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: FAILED
*
* Tests that failed:
* org.apache.catalina.session.TestStandardSessionIntegration.APR.txt
* org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt
* org.apache.catalina.session.TestStandardSessionIntegration.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.tx
t
*
org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.t
xt
*
org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.t
xt
*
org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2.
txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator
.APR.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator
.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator
.NIO2.txt
*
org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.t
xt
*
org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.t
xt
*
org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.
txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.APR
.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO
.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO
2.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio
nParser.APR.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio
nParser.NIO.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio
nParser.NIO2.txt


-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlzNusUACgkQHPApP6U8
pFimcA//crP4NWiES/vO1VHgKskVJVixzC5dDvUV9CpvC2J0QBMjpAkxX2s6s1Pn
7/Zum4TgORnQtkui9

buildbot success in on tomcat-trunk

2019-05-04 Thread buildbot 
The Buildbot has detected a restored build on builder tomcat-trunk while 
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/4292

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] a717084483dad42c60fbeca09eeeff499b525dbc
Blamelist: remm 

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.20

2019-05-04 Thread Igal Sapir 

On 5/3/2019 3:52 PM, Mark Thomas wrote:

The proposed Apache Tomcat 9.0.20 release is now available for voting.

The proposed 9.0.20 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 9.0.20


Unit tests pass for NIO, NIO2, and APR on Ubuntu and Windows with Java 8 
and tc-native-1.2.21


Igal




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in on tomcat-trunk

2019-05-04 Thread buildbot 
The Buildbot has detected a new failure on builder tomcat-trunk while building 
tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/4291

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] 51241d8b53d80dd8e795d6373fed84aa471d3a85
Blamelist: Felix Schumacher ,remm 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Use spotbugs instead of findbugs

2019-05-04 Thread fschumacher 
This is an automated email from the ASF dual-hosted git repository.

fschumacher pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 96df339  Use spotbugs instead of findbugs
96df339 is described below

commit 96df33983ffdad304674bc6fae11cc7c4a887eb1
Author: Felix Schumacher 
AuthorDate: Sat May 4 16:26:41 2019 +0200

Use spotbugs instead of findbugs
---
 BUILDING.txt   |  2 +-
 build.properties.default   | 11 +--
 webapps/docs/changelog.xml |  5 +
 3 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/BUILDING.txt b/BUILDING.txt
index 7f90c54..e0811af 100644
--- a/BUILDING.txt
+++ b/BUILDING.txt
@@ -529,7 +529,7 @@ target. The command is:
 NOTE: FindBugs is licensed under LGPL. Using Findbugs during Tomcat build is
   optional and is off by default.
 
-  See http://findbugs.sourceforge.net/ for more information.
+  See https://spotbugs.github.io/ for more information.
 
 To enable FindBugs, add the following property to build.properties file:
 
diff --git a/build.properties.default b/build.properties.default
index 4dd3905..be14532 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -267,11 +267,10 @@ cobertura.lib=${cobertura.home}/lib
 cobertura.loc=${base-sf.loc}/cobertura/cobertura-2.1.1-bin.tar.gz
 
 # - Findbugs -
-findbugs.version=3.0.1
+findbugs.version=3.1.12
 findbugs.checksum.enabled=true
 findbugs.checksum.algorithm=MD5|SHA-1
-findbugs.checksum.value=dec8828de8657910fcb258ce5383c168|59a24064ca6869e483ce9a04d3c50d14a227d5e6
-findbugs.home=${base.path}/findbugs-${findbugs.version}
-findbugs.lib=${findbugs.home}/lib
-findbugs.jar=${findbugs.lib}/findbugs-ant.jar
-findbugs.loc=${base-sf.loc}/project/findbugs/findbugs/${findbugs.version}/findbugs-${findbugs.version}.tar.gz
+findbugs.checksum.value=8c54502a8e1b78ea6b173a186ce6f379|95114d9aaeeba7bd4ea5a3d6a2167cd6c87bb943
+findbugs.home=${base.path}/spotbugs-${findbugs.version}
+findbugs.jar=${findbugs.home}/lib/spotbugs-ant.jar
+findbugs.loc=${base-maven.loc}/com/github/spotbugs/spotbugs/${findbugs.version}/spotbugs-${findbugs.version}.tgz
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index bd7f589..a6792d4 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -45,6 +45,11 @@
   issues do not "pop up" wrt. others).
 -->
 
+  
+
+  Switch from FindBugs to SpotBugs. (fschumacher)
+
+  
 
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Fix instructions

2019-05-04 Thread remm 
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new a717084  Fix instructions
a717084 is described below

commit a717084483dad42c60fbeca09eeeff499b525dbc
Author: remm 
AuthorDate: Sat May 4 17:12:18 2019 +0200

Fix instructions
---
 res/tomcat-maven/README.md | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/res/tomcat-maven/README.md b/res/tomcat-maven/README.md
index f195977..f816f09 100644
--- a/res/tomcat-maven/README.md
+++ b/res/tomcat-maven/README.md
@@ -73,7 +73,7 @@ An example `tomcat.yaml` is included which uses the Docker 
image. It uses the he
 
 ### Cluster
 
-If using the Kubernetes cloud clustering membership provider, the pod needs to 
have the persmission to view other pods. For exemple with Openshift, this is 
done with:
+If using the Kubernetes cloud clustering membership provider, the pod needs to 
have the permission to view other pods. For exemple with Openshift, this is 
done with:
 ```
 oc policy add-role-to-user view system:serviceaccount:$(oc project -q):default 
-n $(oc project -q)
 ```
@@ -81,9 +81,7 @@ oc policy add-role-to-user view system:serviceaccount:$(oc 
project -q):default -
 ## Native Image
 
 ```
-export JAVA_HOME=/home/remm/Work/graalvm-ce-1.0.0-rc17
-export JAVA_OPTS=-agentlib:native-image-agent=config-output-dir=./target/
-java -jar ./target/tomcat-maven-1.0.jar
+$JAVA_HOME/bin/java -agentlib:native-image-agent=config-output-dir=./target/ 
-jar ./target/tomcat-maven-1.0.jar
 ```
 Then exercise necessary paths of your service with the Tomcat configuration.
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2019-05-04 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 24 mins 20 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dsaaj-api.jar=/srv/gump/packages/saaj-api/saaj-api-1.3.5.jar 
-Djaxrpc-lib.jar=/srv/gump/packages/jaxrpc/geronimo-spec-jaxrpc-1.1-rc4.jar 
-Dtest.temp=output/test-tmp-NIO2 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20190504/bin/openssl
 -Dexecute
 .test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dexecute.test.apr=false 
-Dwsdl4j-lib.jar=/srv/gump/packages/wsdl4j/wsdl4j-1.6.3.jar 
-Dtest.reports=output/logs-NIO2 -Dexecute.test.nio2=true 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.10-201812060815/ecj-4.10.jar 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true -Dtest.accesslog=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-4.1-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/cata

[tomcat] branch master updated: Use spotbugs instead of findbugs

2019-05-04 Thread fschumacher 
This is an automated email from the ASF dual-hosted git repository.

fschumacher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 51241d8  Use spotbugs instead of findbugs
51241d8 is described below

commit 51241d8b53d80dd8e795d6373fed84aa471d3a85
Author: Felix Schumacher 
AuthorDate: Sat May 4 16:26:41 2019 +0200

Use spotbugs instead of findbugs
---
 BUILDING.txt   |  2 +-
 build.properties.default   | 10 +-
 webapps/docs/changelog.xml |  5 +
 3 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/BUILDING.txt b/BUILDING.txt
index 331184a..1f618fb 100644
--- a/BUILDING.txt
+++ b/BUILDING.txt
@@ -523,7 +523,7 @@ target. The command is:
 NOTE: FindBugs is licensed under LGPL. Using Findbugs during Tomcat build is
   optional and is off by default.
 
-  See http://findbugs.sourceforge.net/ for more information.
+  See https://spotbugs.github.io/ for more information.
 
 To enable FindBugs, add the following property to build.properties file:
 
diff --git a/build.properties.default b/build.properties.default
index 960ed5b..1bacc19 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -264,13 +264,13 @@ 
cobertura.jar=${cobertura.home}/cobertura-${cobertura.version}.jar
 cobertura.loc=${base-sf.loc}/cobertura/cobertura-2.1.1-bin.tar.gz
 
 # - Findbugs -
-findbugs.version=3.0.1
+findbugs.version=3.1.12
 findbugs.checksum.enabled=true
 findbugs.checksum.algorithm=MD5|SHA-1
-findbugs.checksum.value=dec8828de8657910fcb258ce5383c168|59a24064ca6869e483ce9a04d3c50d14a227d5e6
-findbugs.home=${base.path}/findbugs-${findbugs.version}
-findbugs.jar=${findbugs.home}/lib/findbugs-ant.jar
-findbugs.loc=${base-sf.loc}/project/findbugs/findbugs/${findbugs.version}/findbugs-${findbugs.version}.tar.gz
+findbugs.checksum.value=8c54502a8e1b78ea6b173a186ce6f379|95114d9aaeeba7bd4ea5a3d6a2167cd6c87bb943
+findbugs.home=${base.path}/spotbugs-${findbugs.version}
+findbugs.jar=${findbugs.home}/lib/spotbugs-ant.jar
+findbugs.loc=${base-maven.loc}/com/github/spotbugs/spotbugs/${findbugs.version}/spotbugs-${findbugs.version}.tgz
 
 # - SAAJ API, used by Code Signing for releases -
 # - No longer part of JRE from Java 11 onwards  -
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index c2a4018..b35610c 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -45,6 +45,11 @@
   issues do not "pop up" wrt. others).
 -->
 
+  
+
+  Switch from FindBugs to SpotBugs. (fschumacher)
+
+  
 
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Try a longer stream write timeout

2019-05-04 Thread remm 
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 47e65d4  Try a longer stream write timeout
47e65d4 is described below

commit 47e65d4b2f2daf806fe100d9c44d1ba87e648b39
Author: remm 
AuthorDate: Sat May 4 16:53:24 2019 +0200

Try a longer stream write timeout
---
 test/org/apache/coyote/http2/Http2TestBase.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/org/apache/coyote/http2/Http2TestBase.java 
b/test/org/apache/coyote/http2/Http2TestBase.java
index 3a0c8d9..e4ff857 100644
--- a/test/org/apache/coyote/http2/Http2TestBase.java
+++ b/test/org/apache/coyote/http2/Http2TestBase.java
@@ -540,7 +540,7 @@ public abstract class Http2TestBase extends TomcatBaseTest {
 http2Protocol.setWriteTimeout(2000);
 http2Protocol.setKeepAliveTimeout(5000);
 http2Protocol.setStreamReadTimeout(1000);
-http2Protocol.setStreamWriteTimeout(1000);
+http2Protocol.setStreamWriteTimeout(1500);
 http2Protocol.setMaxConcurrentStreams(maxConcurrentStreams);
 connector.addUpgradeProtocol(http2Protocol);
 }


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-trunk

2019-05-04 Thread buildbot 
The Buildbot has detected a restored build on builder tomcat-trunk while 
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/4290

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] 24adb8231349caf76966a77cf8491fb11e0f7de4
Blamelist: Christopher Schultz 

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.20

2019-05-04 Thread Rémy Maucherat 
On Sat, May 4, 2019 at 12:13 PM Rémy Maucherat  wrote:

> On Sat, May 4, 2019 at 12:52 AM Mark Thomas  wrote:
>
>> The proposed Apache Tomcat 9.0.20 release is now available for voting.
>>
>> The major changes compared to the 9.0.19 release are:
>>
>> - The useAsyncIO boolean attribute on the Connector element value now
>>   defaults to true.
>>
>> - Stack traces written by the OneLineFormatter are fully indented. The
>>   entire stack trace is now indented by an additional TAB character.
>>
>> - Various HTTP/2 improvements and stability fixes.
>>
>> Along with lots of other bug fixes and improvements.
>>
>> For full details, see the changelog:
>> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.20/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1211/
>> The tag is:
>> https://github.com/apache/tomcat/tree/9.0.20
>> 4202de2f20c29f38a6a700133f9724745c7306d8
>>
>> The proposed 9.0.20 release is:
>> [ ] Broken - do not release
>> [X] Stable - go ahead and release as 9.0.20
>>
>> There is a suspicious failure in a recent testsuite run though (
> https://ci.apache.org/projects/tomcat/tomcat9/logs/4285/TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO.txt)
> but for me at least it's good. We'll see.
>
>
https://ci.apache.org/projects/tomcat/tomcat9/logs/4288/TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO2.txt
#4288 with debug reproduced it, it seems to be a not-that-rare situation
introduced by the stream timeout:
04-May-2019 13:25:21.576 FINE [http-nio2-127.0.0.1-auto-2-exec-7]
org.apache.coyote.http2.Stream.close Connection [1], Stream [17], Reset
sent due to [ENHANCE_YOUR_CALM]
04-May-2019 13:25:21.576 FINE [http-nio2-127.0.0.1-auto-2-exec-7]
org.apache.coyote.http2.Http2AsyncUpgradeHandler.sendStreamReset Connection
[1], Stream [17], Error [ENHANCE_YOUR_CALM], Message [Timeout waiting for
client to increase flow control window to permit stream data to be
written],  RST (closing stream)
04-May-2019 13:25:21.577 FINE [main]
org.apache.coyote.http2.Http2Parser.validateFrame Connection [-1], Stream
[17], Frame type [RST], Flags [0], Payload size [4]
04-May-2019 13:25:21.577 INFO [main]
org.apache.coyote.http2.TestHttp2Section_5_3.testWeighting 17-RST-[11]

So it could be related to the new write timeout, not 100% certain yet.

Rémy

[tomcat] branch master updated: Fetch WebResource objects directly, rather than fetching Strings and then looking-up the entries individually by name.

2019-05-04 Thread schultz 
This is an automated email from the ASF dual-hosted git repository.

schultz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new e3ab24d  Fetch WebResource objects directly, rather than fetching 
Strings and then looking-up the entries individually by name.
 new 24adb82  Merge branch 'master' of https://github.com/apache/tomcat
e3ab24d is described below

commit e3ab24db494d8bf53417687dd95b4873f170e505
Author: Christopher Schultz 
AuthorDate: Sat May 4 15:47:04 2019 +0200

Fetch WebResource objects directly, rather than fetching Strings and then 
looking-up the entries individually by name.
---
 java/org/apache/catalina/servlets/DefaultServlet.java | 17 -
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/java/org/apache/catalina/servlets/DefaultServlet.java 
b/java/org/apache/catalina/servlets/DefaultServlet.java
index cba40c5..4144f6d 100644
--- a/java/org/apache/catalina/servlets/DefaultServlet.java
+++ b/java/org/apache/catalina/servlets/DefaultServlet.java
@@ -1711,11 +1711,11 @@ public class DefaultServlet extends HttpServlet {
 
 StringBuilder sb = new StringBuilder();
 
-String[] entries = resources.list(resource.getWebappPath());
+String directoryWebappPath = resource.getWebappPath();
+WebResource[] entries = resources.listResources(directoryWebappPath);
 
 // rewriteUrl(contextPath) is expensive. cache result for later reuse
 String rewrittenContextPath =  rewriteUrl(contextPath);
-String directoryWebappPath = resource.getWebappPath();
 
 // Render the page header
 sb.append("\r\n");
@@ -1774,13 +1774,12 @@ public class DefaultServlet extends HttpServlet {
 sb.append("");
 
 boolean shade = false;
-for (String entry : entries) {
-if (entry.equalsIgnoreCase("WEB-INF") ||
-entry.equalsIgnoreCase("META-INF"))
+for (WebResource childResource : entries) {
+String filename = childResource.getName();
+if (filename.equalsIgnoreCase("WEB-INF") ||
+filename.equalsIgnoreCase("META-INF"))
 continue;
 
-WebResource childResource =
-resources.getResource(directoryWebappPath + entry);
 if (!childResource.exists()) {
 continue;
 }
@@ -1794,11 +1793,11 @@ public class DefaultServlet extends HttpServlet {
 sb.append("  \r\n");
 sb.append("");
-sb.append(Escape.htmlElementContent(entry));
+sb.append(Escape.htmlElementContent(filename));
 if (childResource.isDirectory())
 sb.append("/");
 sb.append("\r\n");


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in on tomcat-trunk

2019-05-04 Thread buildbot 
The Buildbot has detected a new failure on builder tomcat-trunk while building 
tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/4288

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] 1488552190f3272ab1c57baa4ed34e3e1f84e6c9
Blamelist: Mark Thomas ,remm 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Tentative Graal native image instructions

2019-05-04 Thread remm 
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 7443c4e  Tentative Graal native image instructions
7443c4e is described below

commit 7443c4ee8f502cc6388376d1407a1335544d0d35
Author: remm 
AuthorDate: Sat May 4 15:19:36 2019 +0200

Tentative Graal native image instructions

Will need RC17 at least.
---
 res/tomcat-maven/README.md | 15 +++
 1 file changed, 15 insertions(+)

diff --git a/res/tomcat-maven/README.md b/res/tomcat-maven/README.md
index 7e0ed7d..f195977 100644
--- a/res/tomcat-maven/README.md
+++ b/res/tomcat-maven/README.md
@@ -77,3 +77,18 @@ If using the Kubernetes cloud clustering membership 
provider, the pod needs to h
 ```
 oc policy add-role-to-user view system:serviceaccount:$(oc project -q):default 
-n $(oc project -q)
 ```
+
+## Native Image
+
+```
+export JAVA_HOME=/home/remm/Work/graalvm-ce-1.0.0-rc17
+export JAVA_OPTS=-agentlib:native-image-agent=config-output-dir=./target/
+java -jar ./target/tomcat-maven-1.0.jar
+```
+Then exercise necessary paths of your service with the Tomcat configuration.
+
+And generate the native image using the generated reflection metadata.
+```
+cd target
+$JAVA_HOME/bin/native-image -H:+ReportUnsupportedElementsAtRuntime 
-H:ConfigurationFileDirectories=./ -jar tomcat-maven-1.0.jar
+```


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59750] Amend "authenticate" method with context by means of HttpServletRequest

2019-05-04 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59750

--- Comment #11 from Mark Thomas  ---
JASPIC exposes both the request and the response. The solution to this one
could just be "Use JASPIC".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59750] Amend "authenticate" method with context by means of HttpServletRequest

2019-05-04 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59750

--- Comment #10 from Remy Maucherat  ---
I agree you could experiment with a combined realm (lockout realm is an example
of that indeed), it would need to call your listener in authenticate and
invoke.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59750] Amend "authenticate" method with context by means of HttpServletRequest

2019-05-04 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59750

--- Comment #9 from Christopher Schultz  ---
(In reply to Christopher Schultz from comment #8)
> Two additional thoughts:
> 
> 1. Could this be implemented as a Realm which can wrap another realm? This
> may simplify things when a user wants to authenticate using one-of-many
> concrete realm implementations.

Justification for Realm over Authenticator:

1. Realm is easier to configure for users than authenticator(s)
2. Realm is more flexible since they can be nested ; you can track failures of
specific realms separately from one another
3. Custom authenticators do not need to be re-written to use this new
capability

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Avoid possible NPE reported by Coverity scan

2019-05-04 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 1488552  Avoid possible NPE reported by Coverity scan
1488552 is described below

commit 1488552190f3272ab1c57baa4ed34e3e1f84e6c9
Author: Mark Thomas 
AuthorDate: Sat May 4 13:47:12 2019 +0100

Avoid possible NPE reported by Coverity scan
---
 java/org/apache/catalina/realm/JAASCallbackHandler.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/java/org/apache/catalina/realm/JAASCallbackHandler.java 
b/java/org/apache/catalina/realm/JAASCallbackHandler.java
index 3b439ce..407414e 100644
--- a/java/org/apache/catalina/realm/JAASCallbackHandler.java
+++ b/java/org/apache/catalina/realm/JAASCallbackHandler.java
@@ -90,7 +90,7 @@ public class JAASCallbackHandler implements CallbackHandler {
 this.realm = realm;
 this.username = username;
 
-if (realm.hasMessageDigest()) {
+if (password != null && realm.hasMessageDigest()) {
 this.password = realm.getCredentialHandler().mutate(password);
 }
 else {


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59750] Amend "authenticate" method with context by means of HttpServletRequest

2019-05-04 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59750

--- Comment #8 from Christopher Schultz  ---
Two additional thoughts:

1. Could this be implemented as a Realm which can wrap another realm? This may
simplify things when a user wants to authenticate using one-of-many concrete
realm implementations.

2. Does JASPIC provide anything like this already, or specify any interfaces,
etc. for this kind of thing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Enable debug again

2019-05-04 Thread remm 
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 7a471d3  Enable debug again
7a471d3 is described below

commit 7a471d3238bc771d17f23ac07c84a4147253b458
Author: remm 
AuthorDate: Sat May 4 14:19:33 2019 +0200

Enable debug again

Try to look at #4285, if it happens again.
---
 conf/logging.properties | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/conf/logging.properties b/conf/logging.properties
index e8b7b16..fc52083 100644
--- a/conf/logging.properties
+++ b/conf/logging.properties
@@ -73,7 +73,7 @@ 
org.apache.catalina.core.ContainerBase.[Catalina].[localhost].[/host-manager].ha
 #org.apache.jasper.compiler.TldLocationsCache.level = FINE
 
 # To see debug messages for HTTP/2 handling, uncomment the following line:
-#org.apache.coyote.http2.level = FINE
+org.apache.coyote.http2.level = FINE
 
 # To see debug messages for WebSocket handling, uncomment the following line:
 #org.apache.tomcat.websocket.level = FINE


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.41

2019-05-04 Thread Rémy Maucherat 
On Sat, May 4, 2019 at 11:57 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.41 release is now available for voting.
>
> The major changes compared to the 8.5.40 release are:
>
> - Stack traces written by the OneLineFormatter are fully indented. The
>   entire stack trace is now indented by an additional TAB character.
>
> - Avoid OutOfMemoryErrors and ArrayIndexOutOfBoundsExceptions when
>   accessing large files via the default servlet when resource caching
>   has been disabled.
>
> - When running on newer JREs that don't support SSLv2Hello, don't
>   warn that it is not available unless explicitly configured.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.41/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1212/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.41
> 753f95658fb9a26594d8f9cc65a48de04d2e7bd7
>
>
> The proposed 8.5.41 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.41
>
>
Rémy

Re: [VOTE] Release Apache Tomcat 9.0.20

2019-05-04 Thread Rémy Maucherat 
On Sat, May 4, 2019 at 12:52 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.20 release is now available for voting.
>
> The major changes compared to the 9.0.19 release are:
>
> - The useAsyncIO boolean attribute on the Connector element value now
>   defaults to true.
>
> - Stack traces written by the OneLineFormatter are fully indented. The
>   entire stack trace is now indented by an additional TAB character.
>
> - Various HTTP/2 improvements and stability fixes.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.20/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1211/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.20
> 4202de2f20c29f38a6a700133f9724745c7306d8
>
> The proposed 9.0.20 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.20
>
> There is a suspicious failure in a recent testsuite run though (
https://ci.apache.org/projects/tomcat/tomcat9/logs/4285/TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO.txt)
but for me at least it's good. We'll see.

Rémy

[tomcat] branch 8.5.x updated: Increment version numbers for next dev cycle

2019-05-04 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new d3472f6  Increment version numbers for next dev cycle
d3472f6 is described below

commit d3472f615b413d3aaed0db4983e173821492f85a
Author: Mark Thomas 
AuthorDate: Sat May 4 10:59:47 2019 +0100

Increment version numbers for next dev cycle
---
 build.properties.default | 2 +-
 res/maven/mvn.properties.default | 2 +-
 webapps/docs/changelog.xml   | 4 +++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/build.properties.default b/build.properties.default
index 416eaf8..4dd3905 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -25,7 +25,7 @@
 # - Version Control Flags -
 version.major=8
 version.minor=5
-version.build=41
+version.build=42
 version.patch=0
 version.suffix=-dev
 
diff --git a/res/maven/mvn.properties.default b/res/maven/mvn.properties.default
index 150ea1c..2f26c2b 100644
--- a/res/maven/mvn.properties.default
+++ b/res/maven/mvn.properties.default
@@ -39,7 +39,7 @@ 
maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/d
 maven.asf.release.repo.repositoryId=apache.releases.https
 
 # Release version info
-maven.asf.release.deploy.version=8.5.41
+maven.asf.release.deploy.version=8.5.42
 
 #Where do we load the libraries from
 tomcat.lib.path=../../output/build/lib
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 24a4b9a..bd7f589 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -44,7 +44,9 @@
   They eventually become mixed with the numbered issues (i.e., numbered
   issues do not "pop up" wrt. others).
 -->
-
+
+
+
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] Release Apache Tomcat 8.5.41

2019-05-04 Thread Mark Thomas 
The proposed Apache Tomcat 8.5.41 release is now available for voting.

The major changes compared to the 8.5.40 release are:

- Stack traces written by the OneLineFormatter are fully indented. The
  entire stack trace is now indented by an additional TAB character.

- Avoid OutOfMemoryErrors and ArrayIndexOutOfBoundsExceptions when
  accessing large files via the default servlet when resource caching
  has been disabled.

- When running on newer JREs that don't support SSLv2Hello, don't
  warn that it is not available unless explicitly configured.

Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.41/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1212/

The tag is:
https://github.com/apache/tomcat/tree/8.5.41
753f95658fb9a26594d8f9cc65a48de04d2e7bd7


The proposed 8.5.41 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.5.41

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r33898 [1/2] - in /dev/tomcat/tomcat-8/v8.5.41: ./ bin/ bin/embed/ bin/extras/ src/

2019-05-04 Thread markt 
Author: markt
Date: Sat May  4 09:40:48 2019
New Revision: 33898

Log:
Upload 8.5.41 for voting

Added:
dev/tomcat/tomcat-8/v8.5.41/
dev/tomcat/tomcat-8/v8.5.41/KEYS
dev/tomcat/tomcat-8/v8.5.41/README.html
dev/tomcat/tomcat-8/v8.5.41/RELEASE-NOTES
dev/tomcat/tomcat-8/v8.5.41/bin/
dev/tomcat/tomcat-8/v8.5.41/bin/README.html
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-deployer.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-deployer.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-deployer.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-deployer.zip   (with 
props)
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-deployer.zip.asc
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-deployer.zip.sha512
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-fulldocs.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-fulldocs.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-fulldocs.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-windows-x64.zip   
(with props)
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-windows-x64.zip.asc
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-windows-x64.zip.sha512
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-windows-x86.zip   
(with props)
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-windows-x86.zip.asc
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41-windows-x86.zip.sha512
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41.exe   (with props)
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41.exe.asc
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41.exe.sha512
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41.tar.gz   (with props)
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41.zip   (with props)
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41.zip.asc
dev/tomcat/tomcat-8/v8.5.41/bin/apache-tomcat-8.5.41.zip.sha512
dev/tomcat/tomcat-8/v8.5.41/bin/embed/
dev/tomcat/tomcat-8/v8.5.41/bin/embed/apache-tomcat-8.5.41-embed.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.5.41/bin/embed/apache-tomcat-8.5.41-embed.tar.gz.asc

dev/tomcat/tomcat-8/v8.5.41/bin/embed/apache-tomcat-8.5.41-embed.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.41/bin/embed/apache-tomcat-8.5.41-embed.zip   
(with props)
dev/tomcat/tomcat-8/v8.5.41/bin/embed/apache-tomcat-8.5.41-embed.zip.asc
dev/tomcat/tomcat-8/v8.5.41/bin/embed/apache-tomcat-8.5.41-embed.zip.sha512
dev/tomcat/tomcat-8/v8.5.41/bin/extras/
dev/tomcat/tomcat-8/v8.5.41/bin/extras/catalina-jmx-remote.jar   (with 
props)
dev/tomcat/tomcat-8/v8.5.41/bin/extras/catalina-jmx-remote.jar.asc
dev/tomcat/tomcat-8/v8.5.41/bin/extras/catalina-jmx-remote.jar.sha512
dev/tomcat/tomcat-8/v8.5.41/bin/extras/catalina-ws.jar   (with props)
dev/tomcat/tomcat-8/v8.5.41/bin/extras/catalina-ws.jar.asc
dev/tomcat/tomcat-8/v8.5.41/bin/extras/catalina-ws.jar.sha512
dev/tomcat/tomcat-8/v8.5.41/src/
dev/tomcat/tomcat-8/v8.5.41/src/apache-tomcat-8.5.41-src.tar.gz   (with 
props)
dev/tomcat/tomcat-8/v8.5.41/src/apache-tomcat-8.5.41-src.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.41/src/apache-tomcat-8.5.41-src.tar.gz.sha512
dev/tomcat/tomcat-8/v8.5.41/src/apache-tomcat-8.5.41-src.zip   (with props)
dev/tomcat/tomcat-8/v8.5.41/src/apache-tomcat-8.5.41-src.zip.asc
dev/tomcat/tomcat-8/v8.5.41/src/apache-tomcat-8.5.41-src.zip.sha512

Added: dev/tomcat/tomcat-8/v8.5.41/KEYS
==
--- dev/tomcat/tomcat-8/v8.5.41/KEYS (added)
+++ dev/tomcat/tomcat-8/v8.5.41/KEYS Sat May  4 09:40:48 2019
@@ -0,0 +1,676 @@
+This file contains the PGP&GPG keys of various Apache developers.
+Please don't use them for email unless you have to. Their main
+purpose is code signing.
+
+Apache users: pgp < KEYS
+Apache developers:
+(pgpk -ll  && pgpk -xa ) >> this file.
+  or
+(gpg --fingerprint --list-sigs 
+ && gpg --armor --export ) >> this file.
+
+Apache developers: please ensure that your key is also available via the
+PGP keyservers (such as pgpkeys.mit.edu).
+
+
+Type Bits/KeyIDDate   User ID
+pub  2048/F22C4FED 2001/07/02 Andy Armstrong 
+
+-BEGIN PGP PUBLIC KEY BLOCK-
+Version: PGPfreeware 7.0.3 for non-commercial use 
+
+mQGiBDtAWuURBADZ0KUEyUkSUiTA09e7tvEbX25STsjxrR+DNTainCls+XlkVOij
+gBv216lqge9tIsS0L6hCP4OQbFf/64qVtJssX4QXdyiZGb5wpmcj0Mz602Ew8r+N
+I0S5NvmogoYWW7BlP4r61jNxO5zrr03KaijM5r4ipJdLUxyOmM6P2jRPUwCg/5gm
+bpqiYl7pXX5FgDeB36tmD+UD/06iLqOnoiKO0vMbOk7URclhCObMNrHqxTxozMTS
+B9soYURbIeArei+plYo2n+1qB12ayybjhVu3uksXRdT9bEkyxMfslvLbIpDAG8Cz
+gNftTbKx/MVS7cQU0II8BKo2Akr

svn commit: r33898 [2/2] - in /dev/tomcat/tomcat-8/v8.5.41: ./ bin/ bin/embed/ bin/extras/ src/

2019-05-04 Thread markt 
Added: dev/tomcat/tomcat-8/v8.5.41/src/apache-tomcat-8.5.41-src.zip.asc
==
--- dev/tomcat/tomcat-8/v8.5.41/src/apache-tomcat-8.5.41-src.zip.asc (added)
+++ dev/tomcat/tomcat-8/v8.5.41/src/apache-tomcat-8.5.41-src.zip.asc Sat May  4 
09:40:48 2019
@@ -0,0 +1,16 @@
+-BEGIN PGP SIGNATURE-
+
+iQIzBAABCAAdFiEEqcXfTSLpmZjZh1pREMAcWi9gWecFAlzNWhUACgkQEMAcWi9g
+Wed+oRAA7nk0T49g+sCVUz8TA+9DvOQyU+kKZQCDMWVue8uWlShZ1yz3109M7iWB
+0KC+zwzwbItE1Y/xquUFcNVHFfmWHFP/5rVEfP13FuMy9zRm+aNCu4kABithWMO3
+DyMN26FIhpXA1mrskIozT6miBawPM6tA4IAR7aMXwnupdl36ekq2J79G096fVPn0
+MdzfFft7X0OpjKJYYdG1tvsdomNBPm+kFcTr2Yd1/p3XAB+tXzGHLMfnPjWT74/V
+UxhGJAjk2TELMhf2kZigHRuYrEhvSjsLcS29COoigE5mpBNde52Yv0SJ9WSBfLQV
+lAVtoVE7QwdXpZ5W71Ag34jOmSSabscdHpvvC/P6nBkdwulqIA1UZYAisrxCGItF
+LtdMiy0BLc1x95UFj4nZBh0CU6eyXCjoV3aV3raGihf6kYAemGcoXl4lBgWuQR54
+OcnuZMBcICK47ra12km7igI5H/j3q/BR/mgcukQjIfah+f9Qh+FbhdJBBm4nY9FD
+g3Ln29O4IhdO9EcekOHdZBSM+lXqureqBiGjRswbhlGXjuKxlGtsf0Teu6p+x8NZ
+StjHgFSe7y6EZo0kNSqCl0/DmOjiShMYabp9UC66ShWmFrGZ+Kzbm0JBfVCXSJKm
+cNPhJci+MvSAnesLOl5fboSF6qIpKXSGgdpZF/DT5husS1d2OMo=
+=JCt8
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-8/v8.5.41/src/apache-tomcat-8.5.41-src.zip.sha512
==
--- dev/tomcat/tomcat-8/v8.5.41/src/apache-tomcat-8.5.41-src.zip.sha512 (added)
+++ dev/tomcat/tomcat-8/v8.5.41/src/apache-tomcat-8.5.41-src.zip.sha512 Sat May 
 4 09:40:48 2019
@@ -0,0 +1 @@
+d67c0b2785f3266840ff417ba5600398bff8ecd8b1e36b2bd1cf174975bb35d7d50522ed49cb8ce87f718550f8571541ad7f9cbba84dfb1231974142d40d5d01
 *apache-tomcat-8.5.41-src.zip
\ No newline at end of file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.20

2019-05-04 Thread Mark Thomas 
On 03/05/2019 23:52, Mark Thomas wrote:

> The proposed 9.0.20 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.20

Unit tests pass for NIO, NIO2 and APR/native with Tomcat Native 1.2.21
on Linux, OSX and Windows.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Increment version numbers for next dev cycle

2019-05-04 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 8439559  Increment version numbers for next dev cycle
8439559 is described below

commit 843955917a13a2ae01801736e9867f20b24f7644
Author: Mark Thomas 
AuthorDate: Sat May 4 10:12:11 2019 +0100

Increment version numbers for next dev cycle
---
 build.properties.default | 2 +-
 res/maven/mvn.properties.default | 2 +-
 webapps/docs/changelog.xml   | 4 +++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/build.properties.default b/build.properties.default
index 7f48d3a..960ed5b 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -25,7 +25,7 @@
 # - Version Control Flags -
 version.major=9
 version.minor=0
-version.build=20
+version.build=21
 version.patch=0
 version.suffix=-dev
 
diff --git a/res/maven/mvn.properties.default b/res/maven/mvn.properties.default
index 509637e..0159f06 100644
--- a/res/maven/mvn.properties.default
+++ b/res/maven/mvn.properties.default
@@ -39,7 +39,7 @@ 
maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/d
 maven.asf.release.repo.repositoryId=apache.releases.https
 
 # Release version info
-maven.asf.release.deploy.version=9.0.20
+maven.asf.release.deploy.version=9.0.21
 
 #Where do we load the libraries from
 tomcat.lib.path=../../output/build/lib
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 228e867..c2a4018 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -44,7 +44,9 @@
   They eventually become mixed with the numbered issues (i.e., numbered
   issues do not "pop up" wrt. others).
 -->
-
+
+
+
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] 01/01: Tag 8.5.41

2019-05-04 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to tag 8.5.41
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 753f95658fb9a26594d8f9cc65a48de04d2e7bd7
Author: Mark Thomas 
AuthorDate: Sat May 4 09:51:14 2019 +0100

Tag 8.5.41
---
 build.properties.default   | 2 +-
 webapps/docs/changelog.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/build.properties.default b/build.properties.default
index 416eaf8..096fa64 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -27,7 +27,7 @@ version.major=8
 version.minor=5
 version.build=41
 version.patch=0
-version.suffix=-dev
+version.suffix=
 
 # - Build control flags -
 # Note enabling validation uses Checkstyle which is LGPL licensed
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 24a4b9a..3be3905 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -44,7 +44,7 @@
   They eventually become mixed with the numbered issues (i.e., numbered
   issues do not "pop up" wrt. others).
 -->
-
+
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] tag 8.5.41 created (now 753f956)

2019-05-04 Thread markt 
This is an automated email from the ASF dual-hosted git repository.

markt pushed a change to tag 8.5.41
in repository https://gitbox.apache.org/repos/asf/tomcat.git.


  at 753f956  (commit)
This tag includes the following new commits:

 new 753f956  Tag 8.5.41

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org