buildbot success in on tomcat-9-trunk
The Buildbot has detected a restored build on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/38 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-9-commit' triggered this build Build Source Stamp: [branch 9.0.x] 297e8818a42a7643cf2422f51b8640c0f0818a83 Blamelist: Violeta Georgieva Build succeeded! Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated: Fix typo
This is an automated email from the ASF dual-hosted git repository. violetagg pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 8f09ca7 Fix typo 8f09ca7 is described below commit 8f09ca7726882743929c192fb4ac1c620438f34e Author: Violeta Georgieva AuthorDate: Sat Feb 8 08:35:23 2020 +0200 Fix typo Fixes having an issue number are sorted by their number, ascending. --- webapps/docs/changelog.xml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 3270a7d..2a4a3c4 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -66,6 +66,10 @@ Avoid useless environment restore when not using GSSCredential in JNDIRealm. (remm) + +58577: Respect the argument-count when searching for MBean +operations to invoke via the JMXProxyServlet. (schultz) + 62755: Add ability to opt out of adding the default web.xml config when embedding Tomcat and adding a context via @@ -106,10 +110,6 @@ Do not throw a NullPointerException when an MBean or operation cannot be found by the JMXProxyServlet. (schultz) - -58577: Respect the argument-count when searching for MBean -operations to invoke via the JMXProxyServlet. (schultz) - Refactor recycle facade system property into a new connector attribute named discardFacades. (remm) @@ -157,7 +157,7 @@ Add a new attribute, allowedRequestAttributesPattern to -the AJP/1.3 Connector. Requests with unreconised attributes will be +the AJP/1.3 Connector. Requests with unrecognised attributes will be blocked with a 403. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Fix typos
This is an automated email from the ASF dual-hosted git repository. violetagg pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4de785f Fix typos 4de785f is described below commit 4de785f66063ddf8ef03bdf99c4645aeb291a560 Author: Violeta Georgieva AuthorDate: Sat Feb 8 08:35:23 2020 +0200 Fix typos --- webapps/docs/changelog.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 7974a2f..9ef9ead 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -170,7 +170,7 @@ Fix a problem that meant that remote host, address and port information could be missing in the access log for an HTTP/2 request where the -connection was closed unexpectely. (markt) +connection was closed unexpectedly. (markt) @@ -181,7 +181,7 @@ are made using HTTP/2. (markt) -Fix the corrupton of the TLS configuration when using the deprecated TLS +Fix the corruption of the TLS configuration when using the deprecated TLS attributes on the Connector if the configuration has already been set via the new SSLHostConfig and SSLHostConfigCertificate elements. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix typos
This is an automated email from the ASF dual-hosted git repository. violetagg pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 297e881 Fix typos 297e881 is described below commit 297e8818a42a7643cf2422f51b8640c0f0818a83 Author: Violeta Georgieva AuthorDate: Sat Feb 8 08:35:23 2020 +0200 Fix typos --- webapps/docs/changelog.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index f344768..65ad524 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -162,7 +162,7 @@ Fix a problem that meant that remote host, address and port information could be missing in the access log for an HTTP/2 request where the -connection was closed unexpectely. (markt) +connection was closed unexpectedly. (markt) @@ -176,7 +176,7 @@ are made using HTTP/2. (markt) -Fix the corrupton of the TLS configuration when using the deprecated TLS +Fix the corruption of the TLS configuration when using the deprecated TLS attributes on the Connector if the configuration has already been set via the new SSLHostConfig and SSLHostConfigCertificate elements. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64121] Log messages should not be localized
https://bz.apache.org/bugzilla/show_bug.cgi?id=64121 --- Comment #4 from Christopher Schultz --- Localized log messages make it easier for speakers of all languages to use Tomcat. There is a lot of English out there, but the more other languages are used, the more Google will become a source of help for those localized messages. By your standard, we could never change an error message to be more helpful, or to change the wording in any way or fear that Google would no longer answer questions as readily. If you'd like to discuss this more, please do so on the users' mailing list. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in on tomcat-9-trunk
The Buildbot has detected a new failure on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/37 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-9-commit' triggered this build Build Source Stamp: [branch 9.0.x] f06b28baf7cca13ea7907717acbe70906bf5d359 Blamelist: remm BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Avoid code duplication for attributes
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new f06b28b Avoid code duplication for attributes
f06b28b is described below
commit f06b28baf7cca13ea7907717acbe70906bf5d359
Author: remm
AuthorDate: Fri Feb 7 17:12:53 2020 +0100
Avoid code duplication for attributes
The lack of default also cause cosmetic NPEs for store config.
---
.../tribes/membership/cloud/CloudMembershipProvider.java | 8
.../catalina/tribes/membership/cloud/CloudMembershipService.java | 9 +++--
2 files changed, 7 insertions(+), 10 deletions(-)
diff --git
a/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipProvider.java
b/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipProvider.java
index 9940673..f33aed6 100644
---
a/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipProvider.java
+++
b/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipProvider.java
@@ -100,13 +100,13 @@ public abstract class CloudMembershipProvider extends
MembershipProviderBase imp
public void init(Properties properties) throws IOException {
startTime = Instant.now();
-connectionTimeout =
Integer.parseInt(properties.getProperty("connectionTimeout", "1000"));
-readTimeout = Integer.parseInt(properties.getProperty("readTimeout",
"1000"));
+CloudMembershipService service = (CloudMembershipService) this.service;
+connectionTimeout = service.getConnectTimeout();
+readTimeout = service.getReadTimeout();
+expirationTime = service.getExpirationTime();
localIp = InetAddress.getLocalHost().getHostAddress();
port = Integer.parseInt(properties.getProperty("tcpListenPort"));
-
-expirationTime =
Long.parseLong(properties.getProperty("expirationTime", "5000"));
}
@Override
diff --git
a/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipService.java
b/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipService.java
index df08508..bcb213e 100644
---
a/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipService.java
+++
b/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipService.java
@@ -209,8 +209,7 @@ public class CloudMembershipService extends
MembershipServiceBase
@Override
public int getConnectTimeout() {
-String connectTimeout = properties.getProperty("connectTimeout");
-return Integer.parseInt(connectTimeout);
+return Integer.parseInt(properties.getProperty("connectTimeout",
"1000"));
}
public void setConnectTimeout(int connectTimeout) {
@@ -219,8 +218,7 @@ public class CloudMembershipService extends
MembershipServiceBase
@Override
public int getReadTimeout() {
-String readTimeout = properties.getProperty("readTimeout");
-return Integer.parseInt(readTimeout);
+return Integer.parseInt(properties.getProperty("readTimeout", "1000"));
}
public void setReadTimeout(int readTimeout) {
@@ -229,8 +227,7 @@ public class CloudMembershipService extends
MembershipServiceBase
@Override
public long getExpirationTime() {
-String expirationTime = properties.getProperty("expirationTime");
-return Long.parseLong(expirationTime);
+return Long.parseLong(properties.getProperty("expirationTime",
"5000"));
}
public void setExpirationTime(long expirationTime) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Avoid code duplication for attributes
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new e45dfb8 Avoid code duplication for attributes
e45dfb8 is described below
commit e45dfb84d3e481d4ab5b909f6aa76b9678fcf0c8
Author: remm
AuthorDate: Fri Feb 7 17:12:53 2020 +0100
Avoid code duplication for attributes
The lack of default also cause cosmetic NPEs for store config.
---
.../tribes/membership/cloud/CloudMembershipProvider.java | 8
.../catalina/tribes/membership/cloud/CloudMembershipService.java | 9 +++--
2 files changed, 7 insertions(+), 10 deletions(-)
diff --git
a/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipProvider.java
b/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipProvider.java
index 9940673..f33aed6 100644
---
a/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipProvider.java
+++
b/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipProvider.java
@@ -100,13 +100,13 @@ public abstract class CloudMembershipProvider extends
MembershipProviderBase imp
public void init(Properties properties) throws IOException {
startTime = Instant.now();
-connectionTimeout =
Integer.parseInt(properties.getProperty("connectionTimeout", "1000"));
-readTimeout = Integer.parseInt(properties.getProperty("readTimeout",
"1000"));
+CloudMembershipService service = (CloudMembershipService) this.service;
+connectionTimeout = service.getConnectTimeout();
+readTimeout = service.getReadTimeout();
+expirationTime = service.getExpirationTime();
localIp = InetAddress.getLocalHost().getHostAddress();
port = Integer.parseInt(properties.getProperty("tcpListenPort"));
-
-expirationTime =
Long.parseLong(properties.getProperty("expirationTime", "5000"));
}
@Override
diff --git
a/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipService.java
b/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipService.java
index df08508..bcb213e 100644
---
a/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipService.java
+++
b/java/org/apache/catalina/tribes/membership/cloud/CloudMembershipService.java
@@ -209,8 +209,7 @@ public class CloudMembershipService extends
MembershipServiceBase
@Override
public int getConnectTimeout() {
-String connectTimeout = properties.getProperty("connectTimeout");
-return Integer.parseInt(connectTimeout);
+return Integer.parseInt(properties.getProperty("connectTimeout",
"1000"));
}
public void setConnectTimeout(int connectTimeout) {
@@ -219,8 +218,7 @@ public class CloudMembershipService extends
MembershipServiceBase
@Override
public int getReadTimeout() {
-String readTimeout = properties.getProperty("readTimeout");
-return Integer.parseInt(readTimeout);
+return Integer.parseInt(properties.getProperty("readTimeout", "1000"));
}
public void setReadTimeout(int readTimeout) {
@@ -229,8 +227,7 @@ public class CloudMembershipService extends
MembershipServiceBase
@Override
public long getExpirationTime() {
-String expirationTime = properties.getProperty("expirationTime");
-return Long.parseLong(expirationTime);
+return Long.parseLong(properties.getProperty("expirationTime",
"5000"));
}
public void setExpirationTime(long expirationTime) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64121] Log messages should not be localized
https://bz.apache.org/bugzilla/show_bug.cgi?id=64121 --- Comment #3 from Mark Thomas --- The Manager UI is localized based on the UA's locale, not the server's so this is already supported. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Other javax APIs
On February 7, 2020 2:02:18 PM UTC, "Rémy Maucherat" wrote: >Hi, > >So the migration tool handles many EE package names (but far from all), >and >in the trunk sources the javax.transaction.xa and javax.xml.ws packages >remain. That is correct. As far as I am aware, those APIs did not transfer to Eclipse. No objections to the regexp being expanded to additional / all the Jakarta APIs. Mark > >Should we do something about this ? > >Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4925 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch master] 010fdb7e458d9d8755e2b67203ac4757d78c2f64 Blamelist: remm Build succeeded! Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Store config fixes
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 40fe1da Store config fixes 40fe1da is described below commit 40fe1daf0c3c928f69b86ca8f9b05c4e9e0964e3 Author: remm AuthorDate: Fri Feb 7 16:09:20 2020 +0100 Store config fixes The only real fix is the listener (no default constructor = boom). --- java/org/apache/catalina/storeconfig/server-registry.xml | 4 +--- webapps/docs/changelog.xml | 7 +++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/java/org/apache/catalina/storeconfig/server-registry.xml b/java/org/apache/catalina/storeconfig/server-registry.xml index 97d0a45..846135d 100644 --- a/java/org/apache/catalina/storeconfig/server-registry.xml +++ b/java/org/apache/catalina/storeconfig/server-registry.xml @@ -99,9 +99,6 @@ children="true" storeFactoryClass="org.apache.catalina.storeconfig.ConnectorSF" storeAppenderClass="org.apache.catalina.storeconfig.ConnectorStoreAppender"> -URIEncoding -maxProcessor -minProcessor SSLProtocol sslEnabledProtocols @@ -290,6 +287,7 @@ org.apache.catalina.mbeans.ServerLifecycleListener org.apache.catalina.core.NamingContextListener org.apache.catalina.startup.ContextConfig + org.apache.catalina.startup.ContextConfig$HostWebXmlCacheCleaner org.apache.catalina.startup.EngineConfig org.apache.catalina.startup.HostConfig org.apache.catalina.core.StandardHost$MemoryLeakTrackingListener diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index c9dbc21..7974a2f 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -45,6 +45,13 @@ issues do not "pop up" wrt. others). --> + + + +Store config compatibility with HostWebXmlCacheCleaner listener. (remm) + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Store config fixes
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new fb877d7 Store config fixes fb877d7 is described below commit fb877d72bdd332adea7414ea474d6f2b8e9a749c Author: remm AuthorDate: Fri Feb 7 16:09:20 2020 +0100 Store config fixes The only real fix is the listener (no default constructor = boom). --- java/org/apache/catalina/storeconfig/server-registry.xml | 4 +--- webapps/docs/changelog.xml | 7 +++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/java/org/apache/catalina/storeconfig/server-registry.xml b/java/org/apache/catalina/storeconfig/server-registry.xml index 124ad9d..1223b57 100644 --- a/java/org/apache/catalina/storeconfig/server-registry.xml +++ b/java/org/apache/catalina/storeconfig/server-registry.xml @@ -99,9 +99,6 @@ children="true" storeFactoryClass="org.apache.catalina.storeconfig.ConnectorSF" storeAppenderClass="org.apache.catalina.storeconfig.ConnectorStoreAppender"> -URIEncoding -maxProcessor -minProcessor SSLProtocol sslEnabledProtocols @@ -290,6 +287,7 @@ org.apache.catalina.mbeans.ServerLifecycleListener org.apache.catalina.core.NamingContextListener org.apache.catalina.startup.ContextConfig + org.apache.catalina.startup.ContextConfig$HostWebXmlCacheCleaner org.apache.catalina.startup.EngineConfig org.apache.catalina.startup.HostConfig org.apache.catalina.startup.ListenerCreateRule$OptionalListener diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 88b184a..f344768 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -45,6 +45,13 @@ issues do not "pop up" wrt. others). --> + + + +Store config compatibility with HostWebXmlCacheCleaner listener. (remm) + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64121] Log messages should not be localized
https://bz.apache.org/bugzilla/show_bug.cgi?id=64121 --- Comment #2 from Kohei Tamura --- I think manager apps should be localized but log messages should not by default. Please reconsider my proposal if votes are increased. See also: https://stackoverflow.com/questions/52405966/how-to-turn-off-localized-log-messages-in-jboss-as-7 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Store config fixes
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 010fdb7 Store config fixes 010fdb7 is described below commit 010fdb7e458d9d8755e2b67203ac4757d78c2f64 Author: remm AuthorDate: Fri Feb 7 15:38:08 2020 +0100 Store config fixes The only real fix is the listener (no default constructor = boom). --- java/org/apache/catalina/storeconfig/server-registry.xml | 4 +--- webapps/docs/changelog.xml | 7 +++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/java/org/apache/catalina/storeconfig/server-registry.xml b/java/org/apache/catalina/storeconfig/server-registry.xml index 2b8279a..6c46ab0 100644 --- a/java/org/apache/catalina/storeconfig/server-registry.xml +++ b/java/org/apache/catalina/storeconfig/server-registry.xml @@ -99,9 +99,6 @@ children="true" storeFactoryClass="org.apache.catalina.storeconfig.ConnectorSF" storeAppenderClass="org.apache.catalina.storeconfig.ConnectorStoreAppender"> -URIEncoding -maxProcessor -minProcessor org.apache.catalina.mbeans.ServerLifecycleListener org.apache.catalina.core.NamingContextListener org.apache.catalina.startup.ContextConfig + org.apache.catalina.startup.ContextConfig$HostWebXmlCacheCleaner org.apache.catalina.startup.EngineConfig org.apache.catalina.startup.HostConfig org.apache.catalina.startup.ListenerCreateRule$OptionalListener diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 61bc7db..10e5a53 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -45,6 +45,13 @@ issues do not "pop up" wrt. others). --> + + + +Store config compatibility with HostWebXmlCacheCleaner listener. (remm) + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Other javax APIs
Hi, So the migration tool handles many EE package names (but far from all), and in the trunk sources the javax.transaction.xa and javax.xml.ws packages remain. Should we do something about this ? Rémy
[Bug 64121] Log messages should not be localized
https://bz.apache.org/bugzilla/show_bug.cgi?id=64121 Mark Thomas changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #1 from Mark Thomas --- Other users take a different view and prefer to have localized log messages. Users are free to control the locale used for log messages by setting an appropriate locale in setenv.[sh|bat]. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
