[Bug 64021] SCI ordering prevents a web application SCI from using a service bootstrapped by a container-provided SCI

2020-03-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64021

zhander...@huawei.com  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED
   Target Milestone|-   |---
Version|9.0.x   |7.0.100
Product|Tomcat 9|Tomcat 7
URL||https://bz.apache.org/bugzi
   ||lla/show_bug.cgi?id=64021
  Component|Catalina|Catalina

--- Comment #3 from zhander...@huawei.com  ---
Webapp can not be loaded by tomcat-7.0.100, the reason can refer to the comment
of this commit
'https://github.com/apache/tomcat/commit/fe905a43bf935cb293db462915a17ad87c303438?diff=split'.
please check it, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64240] New: http 0.9 request return nothing

2020-03-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64240

Bug ID: 64240
   Summary: http 0.9 request return nothing
   Product: Tomcat 8
   Version: 8.5.53
  Hardware: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: 382188...@qq.com
  Target Milestone: 

when send http 0.9 request to tomcat, the server will return nothing and close
the TCP connection.
the request contains only one line:
"GET /CRLF"
there is no space between / and CRLF

if there is one space between / and CRLF, tomcat will return content in
response

but this bug can't be reproduced every time
after restart tomcat, it maybe disappear
and may next time restart, it maybe appear

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: sources repository for taglibs-standard-impl/specs-1.2.5-migrated-0.0.1

2020-03-18 Thread Olivier Lamy
On Wed, 18 Mar 2020 at 20:36, Mark Thomas  wrote:

> On 18/03/2020 01:44, Olivier Lamy wrote:
> > Hi
> > Thanks for your answer.
> > Is there any plan to publish those artifacts to maven central repository?
>
> Not at this time. Maybe at some point in the future.
>
> > And maybe update taglib sources as well?
>
> The taglibs project is dormant at the moment. If updating to Jakarta EE
> 9 is an itch someone wants to scratch then, as always, contributions are
> welcome.
>

I'm definitely happy to contribute this.
Any objections to move to git first?
If ok is there any procedure or I only need to create INFRA ticket?

cheers
Olivier


>
> Mark
>
>
> > Thanks
> > Olivier
> >
> > On Mon, 16 Mar 2020 at 18:47, Mark Thomas  > > wrote:
> >
> > On 15/03/2020 23:37, Olivier Lamy wrote:
> > > Hi
> > > I wonder if there is any source repo (git/svn) for those jars
> > which has
> > > been dropped with 10 release?
> > > they contains relocation to jakarta namespace but I cannot find any
> > > official sources? (maven metadata seems
> > >
> wrong META-INF/maven/org.apache.taglibs/taglibs-standard-impl/pom.xml)
> >
> > They are the Apache Taglibs 1.2.5 JARs from here:
> > https://tomcat.apache.org/download-taglibs.cgi
> >
> > That have been processed with the Apache Tomcat migration tool for
> > Jakarta EE (using the 0.0.1 tag):
> > https://github.com/apache/tomcat-jakartaee-migration
> >
> > Mark
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > 
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> > 
> >
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


[tomcat] branch master updated: Avoid retrieving the selection key on Java 11

2020-03-18 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 0c42530  Avoid retrieving the selection key on Java 11
0c42530 is described below

commit 0c42530829bafa745a7d0e36c5d4f0ccedf0ef84
Author: remm 
AuthorDate: Wed Mar 18 16:44:23 2020 +0100

Avoid retrieving the selection key on Java 11

In that case, cancelledKey only closes the socket wrapper.
---
 java/org/apache/tomcat/util/net/NioEndpoint.java | 12 
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/NioEndpoint.java 
b/java/org/apache/tomcat/util/net/NioEndpoint.java
index 7012782..b3947c9 100644
--- a/java/org/apache/tomcat/util/net/NioEndpoint.java
+++ b/java/org/apache/tomcat/util/net/NioEndpoint.java
@@ -1569,23 +1569,27 @@ public class NioEndpoint extends 
AbstractJsseEndpoint
 state = getHandler().process(socketWrapper, event);
 }
 if (state == SocketState.CLOSED) {
-
poller.cancelledKey(socket.getIOChannel().keyFor(poller.getSelector()), 
socketWrapper);
+SelectionKey key = JreCompat.isJre11Available() ? null 
: socket.getIOChannel().keyFor(poller.getSelector());
+poller.cancelledKey(key, socketWrapper);
 }
 } else if (handshake == -1 ) {
 getHandler().process(socketWrapper, 
SocketEvent.CONNECT_FAIL);
-
poller.cancelledKey(socket.getIOChannel().keyFor(poller.getSelector()), 
socketWrapper);
+SelectionKey key = JreCompat.isJre11Available() ? null : 
socket.getIOChannel().keyFor(poller.getSelector());
+poller.cancelledKey(key, socketWrapper);
 } else if (handshake == SelectionKey.OP_READ){
 socketWrapper.registerReadInterest();
 } else if (handshake == SelectionKey.OP_WRITE){
 socketWrapper.registerWriteInterest();
 }
 } catch (CancelledKeyException cx) {
-
poller.cancelledKey(socket.getIOChannel().keyFor(poller.getSelector()), 
socketWrapper);
+SelectionKey key = JreCompat.isJre11Available() ? null : 
socket.getIOChannel().keyFor(poller.getSelector());
+poller.cancelledKey(key, socketWrapper);
 } catch (VirtualMachineError vme) {
 ExceptionUtils.handleThrowable(vme);
 } catch (Throwable t) {
 log.error(sm.getString("endpoint.processing.fail"), t);
-
poller.cancelledKey(socket.getIOChannel().keyFor(poller.getSelector()), 
socketWrapper);
+SelectionKey key = JreCompat.isJre11Available() ? null : 
socket.getIOChannel().keyFor(poller.getSelector());
+poller.cancelledKey(key, socketWrapper);
 } finally {
 socketWrapper = null;
 event = null;


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] Iridias opened a new pull request #264: fix regression: only skip jar-scanning completely if scanSet is empty

2020-03-18 Thread GitBox
Iridias opened a new pull request #264: fix regression: only skip jar-scanning 
completely if scanSet is empty
URL: https://github.com/apache/tomcat/pull/264
 
 
   The commit 21d08e1952d6612da9a712a173c81174958f4b8b introduced a regression 
to the behavior of jar-scanning. Since version 9.0.31 it skips all jars, if a 
wildcard is found in the skipSet - no matter the content of the scanSet!
   
   The documentation for `jarsToScan` clearly states: 
   > overrides the default jarsToSkip list above
   
   This PR restores this behavior by also respecting the "jarsToScan".


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 7.0.103

2020-03-18 Thread Konstantin Kolinko
пн, 16 мар. 2020 г. в 12:13, Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.103 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.103/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1260/
> The git tag is:
> https://github.com/apache/tomcat/tree/7.0.103
> c4e59ac215eebff2de5fd9d23fb37fe222bc99c5
>
> The proposed 7.0.103 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.103 Stable

Unit tests pass on Windows 10, all connectors,
ran tests (compiled with Java 6 and Java 7) with Java 6 (Oracle 6u45
32-bit) (with several known failing tests), 7 (Oracle 7u80 32-bit), 8
(AdoptOpenJDK 8u242 64-bit), 11 (AdoptOpenJDK 11.0.6), 14 (OpenJDK GA
release).

A small issue with configuration, filed as
https://bz.apache.org/bugzilla/show_bug.cgi?id=64237
Mime-mapping for *.Z files is broken.
Not a showstopper.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64237] Mime-mapping for *.Z files is missing in default configuration of Tomcat 7.0.103

2020-03-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64237

Konstantin Kolinko  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Konstantin Kolinko  ---
Not a show-stopper. Anyone affected can edit their own conf/web.xml file. Also
I think that *.Z files are rarely used nowadays. It is an old compression
format.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64237] New: Mime-mapping for *.Z files is missing in default configuration of Tomcat 7.0.103

2020-03-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64237

Bug ID: 64237
   Summary: Mime-mapping for *.Z files is missing in default
configuration of Tomcat 7.0.103
   Product: Tomcat 7
   Version: trunk
  Hardware: PC
Status: NEW
  Severity: regression
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: knst.koli...@gmail.com
  Target Milestone: ---

The following commit removed the  for "Z" files from the default
conf/web.xml, under assumption that Tomcat 7 processes mime mappings in
case-insensitive manner:

https://github.com/apache/tomcat/commit/fa587753d13125573118cfd6bad46dce6088b857

Smoke-testing Tomcat 7.0.103, it does not.

Using a sample file, placed into the ROOT webapp (named "foo.Z", then "foo.z"):

wget.exe --save-headers http://localhost:8080/foo.Z
[[[
HTTP/1.1 200 OK
Server: Apache-Coyote/1.1
Accept-Ranges: bytes
ETag: W/"6-1584539021767"
Last-Modified: Wed, 18 Mar 2020 13:43:41 GMT
Content-Length: 6
Date: Wed, 18 Mar 2020 13:46:45 GMT

Test
]]]

wget.exe --save-headers http://localhost:8080/foo.z
[[[
HTTP/1.1 200 OK
Server: Apache-Coyote/1.1
Accept-Ranges: bytes
ETag: W/"6-1584539021767"
Last-Modified: Wed, 18 Mar 2020 13:43:41 GMT
Content-Type: application/x-compress
Content-Length: 6
Date: Wed, 18 Mar 2020 13:47:44 GMT

Test
]]]

The Content-Type header is missing from the first response.
Testing Tomcat 8.5.53, it returns Content-Type header as expected.


One of the options to fix this is to backport case-insensitive mime-type
mapping to Tomcat 7. The feature was implemented in Tomcat 8.0.0 with r1356151:

https://bz.apache.org/bugzilla/show_bug.cgi?id=45995
https://github.com/apache/tomcat/commit/2a18548f51cf89694077f4f72605190a8e7a427e

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: sources repository for taglibs-standard-impl/specs-1.2.5-migrated-0.0.1

2020-03-18 Thread Mark Thomas
On 18/03/2020 01:44, Olivier Lamy wrote:
> Hi
> Thanks for your answer.
> Is there any plan to publish those artifacts to maven central repository?

Not at this time. Maybe at some point in the future.

> And maybe update taglib sources as well? 

The taglibs project is dormant at the moment. If updating to Jakarta EE
9 is an itch someone wants to scratch then, as always, contributions are
welcome.

Mark


> Thanks
> Olivier
> 
> On Mon, 16 Mar 2020 at 18:47, Mark Thomas  > wrote:
> 
> On 15/03/2020 23:37, Olivier Lamy wrote:
> > Hi
> > I wonder if there is any source repo (git/svn) for those jars
> which has
> > been dropped with 10 release?
> > they contains relocation to jakarta namespace but I cannot find any
> > official sources? (maven metadata seems
> > wrong META-INF/maven/org.apache.taglibs/taglibs-standard-impl/pom.xml)
> 
> They are the Apache Taglibs 1.2.5 JARs from here:
> https://tomcat.apache.org/download-taglibs.cgi
> 
> That have been processed with the Apache Tomcat migration tool for
> Jakarta EE (using the 0.0.1 tag):
> https://github.com/apache/tomcat-jakartaee-migration
> 
> Mark
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> 
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 
> 
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] gazzyt commented on issue #262: Fix and tests for tomcat bug #64226

2020-03-18 Thread GitBox
gazzyt commented on issue #262: Fix and tests for tomcat bug #64226
URL: https://github.com/apache/tomcat/pull/262#issuecomment-600542134
 
 
   I did some hacking on the Java 8 `DateTimeFormatter` yesterday and concur 
with @ChristopherSchultz. I found that `DateTimeFormatter` parsing was more 
strict that `SimpleDateFormat` for the same format string and would throw 
exceptions where `SimpleDateFormat` returned success. These differences can be 
overcome - `DateTimeFormatter` does give you a lot more control but the risk of 
regression is there. I'll leave this code at 
https://github.com/gazzyt/tomcat/commits/java8-datetimeformatter in case it is 
useful to anyone.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Release Announcement: General Availability of Java 14 / JDK 14

2020-03-18 Thread Rory O'Donnell

  Hi Mark,


**Release Announcement: General Availability of Java 14 / JDK 14 [1] * *

 * JDK 14, the reference implementation of Java 14, is now Generally
   Available.
 * GPL-licensed OpenJDK builds from Oracle are available here:
   https://jdk.java.net/14
 * JDK 14 Release notes
   




JDK 14  includes sixteen features [2]:

  305: Pattern Matching for instanceof (Preview)
  343: Packaging Tool (Incubator)
  345: NUMA-Aware Memory Allocation for G1
  349: JFR Event Streaming
  352: Non-Volatile Mapped Byte Buffers
  358: Helpful NullPointerExceptions
  359: Records (Preview)
  361: Switch Expressions (Standard)
  362: Deprecate the Solaris and SPARC Ports
  363: Remove the Concurrent Mark Sweep (CMS) Garbage Collector
  364: ZGC on macOS
  365: ZGC on Windows
  366: Deprecate the ParallelScavenge + SerialOld GC Combination
  367: Remove the Pack200 Tools and API
  368: Text Blocks (Second Preview)
  370: Foreign-Memory Access API (Incubator)

Thanks to everyone who contributed to JDK 14, whether by creating 
features or enhancements, logging  bugs, or downloading and testing the 
early-access builds.


OpenJDK 15 EA build 14 is now available at http://jdk.java.net/15 *
*

 * These early access, open source builds are provided under the GNU
   General Public License, version 2, with the Classpath Exception
   .
 * Significant changes since the last availability email:
 o Build 13 - JDK-8238555
   : Allow
   Initialization of SunPKCS11 with NSS when there are external
   FIPS modules in the NSSDB
 o Build 10 - JDK-8237776
   : Shenandoah:
   Wrong result with Lucene test
 + Reported by Apache Lucene.
 o Build 9 - JDK-8222793
   : Javadoc tool
   ignores "-locale" param and uses default locale for all messages
   and texts
 + Reported by Apache Lucene.

Project Metropolis Early-Access Builds - Build 14-metropolis+1-17 
 (2020/3/5)


 * These builds are intended for developers looking to test and provide
   feedback on using /Graal,/ in form of native library
   /(libjvmcicompiler.so)/, instead of C2 as HotSpot high optimizing
   JIT compiler.
 * These early-access builds are provided under the GNU General Public
   License, version 2, with the Classpath Exception
   .
 * Please send feedback via e-mail to metropolis-...@openjdk.java.net
   . To send e-mail to this
   address you must first subscribe to the mailing list
   .


Regards,
Rory

[1] https://mail.openjdk.java.net/pipermail/jdk-dev/2020-March/004089.html
[2] https://openjdk.java.net/projects/jdk/14

--
Rgds, Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin, Ireland