[GitHub] [tomcat] kamnani commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

[GitBox]

kamnani commented on pull request #352:
URL: https://github.com/apache/tomcat/pull/352#issuecomment-689825942


   @martin-g   Thanks for your time on this : )
   I have marked all of the conversations as resolved after the latest commits. 
Do we have any more feedback on this PR?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] kamnani edited a comment on pull request #351: Remove White Spaces from the JSP files

[GitBox]

kamnani edited a comment on pull request #351:
URL: https://github.com/apache/tomcat/pull/351#issuecomment-689824792


   @martin-g  @rotty3000 Thanks for your time on this : )
   I have marked all of the conversations as resolved after the latest commits. 
Do we have any more feedback on this PR? 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

[GitBox]

kamnani commented on pull request #351:
URL: https://github.com/apache/tomcat/pull/351#issuecomment-689824792


   @markt-asf @rotty3000 Thanks for your time on this : )
   I have marked all of the conversations as resolved after the latest commits. 
Do we have any more feedback on this PR? 
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in on tomcat-trunk

[buildbot]

The Buildbot has detected a new failure on builder tomcat-trunk while building 
tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/5408

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: asf946_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] 53c304ad1f65a09c921c40e03a115de438f6c68a
Blamelist: Mark Thomas 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: Fix (hopefully) intermittent test failures.

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new 6f46935  Fix (hopefully) intermittent test failures.
6f46935 is described below

commit 6f46935122f82d35e484849353573c9bdfb52756
Author: Mark Thomas 
AuthorDate: Wed Sep 9 20:22:57 2020 +0100

Fix (hopefully) intermittent test failures.

Refactor the test to check the coordinator election has completed before
performing tests that assume that the election has finished.
---
 .../interceptors/TestNonBlockingCoordinator.java   | 63 +-
 1 file changed, 49 insertions(+), 14 deletions(-)

diff --git 
a/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
 
b/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
index 4c0d0ed..3d5d4ff 100644
--- 
a/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
+++ 
b/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
@@ -54,7 +54,6 @@ public class TestNonBlockingCoordinator {
 public void run() {
 try {
 channels[j].start(Channel.DEFAULT);
-Thread.sleep(50);
 } catch (Exception x) {
 x.printStackTrace();
 }
@@ -68,9 +67,28 @@ public class TestNonBlockingCoordinator {
 for (int i = 0; i < CHANNEL_COUNT; i++) {
 threads[i].join();
 }
-Thread.sleep(1000);
+
+// Allow up to 30s for cluster to form once all the nodes have been
+// started
+int count = 0;
+Member member = null;
+boolean electionComplete = false;
+while (!electionComplete && count < 300) {
+electionComplete = true;
+member = coordinators[0].getCoordinator();
+if (member == null) {
+electionComplete = false;
+} else {
+for (int i = 0; i < CHANNEL_COUNT; i++) {
+electionComplete = electionComplete && 
(member.equals(coordinators[i].getCoordinator()));
+}
+}
+Thread.sleep(100);
+count++;
+}
 }
 
+
 @Test
 public void testCoord1() throws Exception {
 int expectedCount = channels[0].getMembers().length;
@@ -79,34 +97,30 @@ public class TestNonBlockingCoordinator {
 Assert.assertEquals("Member count expected to be equal.", 
expectedCount,
 channels[i].getMembers().length);
 }
+
 Member member = coordinators[0].getCoordinator();
-int cnt = 0;
-while (member == null && (cnt++ < 100)) {
-try {
-Thread.sleep(100);
-member = coordinators[0].getCoordinator();
-} catch (Exception x) {
-/* Ignore */
-}
-}
 log.info("Coordinator[0] is:" + member);
 for (int i = 0; i < CHANNEL_COUNT; i++) {
-Assert.assertEquals("Local member" + 
channels[i].getLocalMember(false), member, coordinators[i].getCoordinator());
+Assert.assertEquals("Local member " + 
channels[i].getLocalMember(false), member, coordinators[i].getCoordinator());
 }
 }
 
+
 @Test
 public void testCoord2() throws Exception {
+// Stop current coordinator to trigger new election
 Member member = coordinators[1].getCoordinator();
 System.out.println("Coordinator[2a] is:" + member);
 int index = -1;
-for ( int i=0; i

[tomcat] branch 8.5.x updated: Fix (hopefully) intermittent test failures.

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new baf7d8e  Fix (hopefully) intermittent test failures.
baf7d8e is described below

commit baf7d8e9889ed346edb12b61ea7cb1d544a66a55
Author: Mark Thomas 
AuthorDate: Wed Sep 9 20:22:57 2020 +0100

Fix (hopefully) intermittent test failures.

Refactor the test to check the coordinator election has completed before
performing tests that assume that the election has finished.
---
 .../interceptors/TestNonBlockingCoordinator.java   | 63 +-
 1 file changed, 49 insertions(+), 14 deletions(-)

diff --git 
a/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
 
b/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
index 4c0d0ed..3d5d4ff 100644
--- 
a/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
+++ 
b/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
@@ -54,7 +54,6 @@ public class TestNonBlockingCoordinator {
 public void run() {
 try {
 channels[j].start(Channel.DEFAULT);
-Thread.sleep(50);
 } catch (Exception x) {
 x.printStackTrace();
 }
@@ -68,9 +67,28 @@ public class TestNonBlockingCoordinator {
 for (int i = 0; i < CHANNEL_COUNT; i++) {
 threads[i].join();
 }
-Thread.sleep(1000);
+
+// Allow up to 30s for cluster to form once all the nodes have been
+// started
+int count = 0;
+Member member = null;
+boolean electionComplete = false;
+while (!electionComplete && count < 300) {
+electionComplete = true;
+member = coordinators[0].getCoordinator();
+if (member == null) {
+electionComplete = false;
+} else {
+for (int i = 0; i < CHANNEL_COUNT; i++) {
+electionComplete = electionComplete && 
(member.equals(coordinators[i].getCoordinator()));
+}
+}
+Thread.sleep(100);
+count++;
+}
 }
 
+
 @Test
 public void testCoord1() throws Exception {
 int expectedCount = channels[0].getMembers().length;
@@ -79,34 +97,30 @@ public class TestNonBlockingCoordinator {
 Assert.assertEquals("Member count expected to be equal.", 
expectedCount,
 channels[i].getMembers().length);
 }
+
 Member member = coordinators[0].getCoordinator();
-int cnt = 0;
-while (member == null && (cnt++ < 100)) {
-try {
-Thread.sleep(100);
-member = coordinators[0].getCoordinator();
-} catch (Exception x) {
-/* Ignore */
-}
-}
 log.info("Coordinator[0] is:" + member);
 for (int i = 0; i < CHANNEL_COUNT; i++) {
-Assert.assertEquals("Local member" + 
channels[i].getLocalMember(false), member, coordinators[i].getCoordinator());
+Assert.assertEquals("Local member " + 
channels[i].getLocalMember(false), member, coordinators[i].getCoordinator());
 }
 }
 
+
 @Test
 public void testCoord2() throws Exception {
+// Stop current coordinator to trigger new election
 Member member = coordinators[1].getCoordinator();
 System.out.println("Coordinator[2a] is:" + member);
 int index = -1;
-for ( int i=0; i

[tomcat] branch 9.0.x updated: Fix (hopefully) intermittent test failures.

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new d56076f  Fix (hopefully) intermittent test failures.
d56076f is described below

commit d56076f0be4bc386cc4a008e77adf7b0e6c156b6
Author: Mark Thomas 
AuthorDate: Wed Sep 9 20:22:57 2020 +0100

Fix (hopefully) intermittent test failures.

Refactor the test to check the coordinator election has completed before
performing tests that assume that the election has finished.
---
 .../interceptors/TestNonBlockingCoordinator.java   | 63 +-
 1 file changed, 49 insertions(+), 14 deletions(-)

diff --git 
a/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
 
b/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
index 4c0d0ed..3d5d4ff 100644
--- 
a/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
+++ 
b/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
@@ -54,7 +54,6 @@ public class TestNonBlockingCoordinator {
 public void run() {
 try {
 channels[j].start(Channel.DEFAULT);
-Thread.sleep(50);
 } catch (Exception x) {
 x.printStackTrace();
 }
@@ -68,9 +67,28 @@ public class TestNonBlockingCoordinator {
 for (int i = 0; i < CHANNEL_COUNT; i++) {
 threads[i].join();
 }
-Thread.sleep(1000);
+
+// Allow up to 30s for cluster to form once all the nodes have been
+// started
+int count = 0;
+Member member = null;
+boolean electionComplete = false;
+while (!electionComplete && count < 300) {
+electionComplete = true;
+member = coordinators[0].getCoordinator();
+if (member == null) {
+electionComplete = false;
+} else {
+for (int i = 0; i < CHANNEL_COUNT; i++) {
+electionComplete = electionComplete && 
(member.equals(coordinators[i].getCoordinator()));
+}
+}
+Thread.sleep(100);
+count++;
+}
 }
 
+
 @Test
 public void testCoord1() throws Exception {
 int expectedCount = channels[0].getMembers().length;
@@ -79,34 +97,30 @@ public class TestNonBlockingCoordinator {
 Assert.assertEquals("Member count expected to be equal.", 
expectedCount,
 channels[i].getMembers().length);
 }
+
 Member member = coordinators[0].getCoordinator();
-int cnt = 0;
-while (member == null && (cnt++ < 100)) {
-try {
-Thread.sleep(100);
-member = coordinators[0].getCoordinator();
-} catch (Exception x) {
-/* Ignore */
-}
-}
 log.info("Coordinator[0] is:" + member);
 for (int i = 0; i < CHANNEL_COUNT; i++) {
-Assert.assertEquals("Local member" + 
channels[i].getLocalMember(false), member, coordinators[i].getCoordinator());
+Assert.assertEquals("Local member " + 
channels[i].getLocalMember(false), member, coordinators[i].getCoordinator());
 }
 }
 
+
 @Test
 public void testCoord2() throws Exception {
+// Stop current coordinator to trigger new election
 Member member = coordinators[1].getCoordinator();
 System.out.println("Coordinator[2a] is:" + member);
 int index = -1;
-for ( int i=0; i

[tomcat] branch master updated: Fix (hopefully) intermittent test failures.

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 53c304a  Fix (hopefully) intermittent test failures.
53c304a is described below

commit 53c304ad1f65a09c921c40e03a115de438f6c68a
Author: Mark Thomas 
AuthorDate: Wed Sep 9 20:22:57 2020 +0100

Fix (hopefully) intermittent test failures.

Refactor the test to check the coordinator election has completed before
performing tests that assume that the election has finished.
---
 .../interceptors/TestNonBlockingCoordinator.java   | 63 +-
 1 file changed, 49 insertions(+), 14 deletions(-)

diff --git 
a/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
 
b/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
index 4c0d0ed..3d5d4ff 100644
--- 
a/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
+++ 
b/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
@@ -54,7 +54,6 @@ public class TestNonBlockingCoordinator {
 public void run() {
 try {
 channels[j].start(Channel.DEFAULT);
-Thread.sleep(50);
 } catch (Exception x) {
 x.printStackTrace();
 }
@@ -68,9 +67,28 @@ public class TestNonBlockingCoordinator {
 for (int i = 0; i < CHANNEL_COUNT; i++) {
 threads[i].join();
 }
-Thread.sleep(1000);
+
+// Allow up to 30s for cluster to form once all the nodes have been
+// started
+int count = 0;
+Member member = null;
+boolean electionComplete = false;
+while (!electionComplete && count < 300) {
+electionComplete = true;
+member = coordinators[0].getCoordinator();
+if (member == null) {
+electionComplete = false;
+} else {
+for (int i = 0; i < CHANNEL_COUNT; i++) {
+electionComplete = electionComplete && 
(member.equals(coordinators[i].getCoordinator()));
+}
+}
+Thread.sleep(100);
+count++;
+}
 }
 
+
 @Test
 public void testCoord1() throws Exception {
 int expectedCount = channels[0].getMembers().length;
@@ -79,34 +97,30 @@ public class TestNonBlockingCoordinator {
 Assert.assertEquals("Member count expected to be equal.", 
expectedCount,
 channels[i].getMembers().length);
 }
+
 Member member = coordinators[0].getCoordinator();
-int cnt = 0;
-while (member == null && (cnt++ < 100)) {
-try {
-Thread.sleep(100);
-member = coordinators[0].getCoordinator();
-} catch (Exception x) {
-/* Ignore */
-}
-}
 log.info("Coordinator[0] is:" + member);
 for (int i = 0; i < CHANNEL_COUNT; i++) {
-Assert.assertEquals("Local member" + 
channels[i].getLocalMember(false), member, coordinators[i].getCoordinator());
+Assert.assertEquals("Local member " + 
channels[i].getLocalMember(false), member, coordinators[i].getCoordinator());
 }
 }
 
+
 @Test
 public void testCoord2() throws Exception {
+// Stop current coordinator to trigger new election
 Member member = coordinators[1].getCoordinator();
 System.out.println("Coordinator[2a] is:" + member);
 int index = -1;
-for ( int i=0; i

Re: [VOTE] Release Apache Tomcat 10.0.0-M8

[Mark Thomas]

On 09/09/2020 15:57, Mark Thomas wrote:


> 
> The proposed 10.0.0-M8 release is:
> [ ] Broken - do not release
> [X] Alpha  - go ahead and release as 10.0.0-M8

Unit tests pass for NIO, NIO2, APR/Native (with Tomcat Native 1.2.25) on
Windows, Linux and OSX.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64710

Mark Thomas  changed:

   What|Removed |Added

 Status|REOPENED|NEEDINFO

--- Comment #15 from Mark Thomas  ---
I am unable to reproduce this with 9.0.x or 10.0.x.

Ideally, we need a more reliable test case.

Is it just the one stack trace you see with the BufferOverflowException? If
there is more than one stack trace - or if other exceptions are present in the
logs - it might be helpful to see each of them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Increment version for next dev cycle

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 4dbc475  Increment version for next dev cycle
4dbc475 is described below

commit 4dbc475435b6f9c3327c1cde8402908376a0ce57
Author: Mark Thomas 
AuthorDate: Wed Sep 9 16:03:36 2020 +0100

Increment version for next dev cycle
---
 build.properties.default | 2 +-
 res/maven/mvn.properties.default | 2 +-
 webapps/docs/changelog.xml   | 4 +++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/build.properties.default b/build.properties.default
index 57ec1c6..3406d82 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -27,7 +27,7 @@ version.major=10
 version.minor=0
 version.build=0
 version.patch=0
-version.suffix=-M8-dev
+version.suffix=-M9-dev
 
 # - Source control flags -
 git.branch=master
diff --git a/res/maven/mvn.properties.default b/res/maven/mvn.properties.default
index 4c6bdb6..6f0fd03 100644
--- a/res/maven/mvn.properties.default
+++ b/res/maven/mvn.properties.default
@@ -39,7 +39,7 @@ 
maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/d
 maven.asf.release.repo.repositoryId=apache.releases.https
 
 # Release version info
-maven.asf.release.deploy.version=10.0.0-M8
+maven.asf.release.deploy.version=10.0.0-M9
 
 #Where do we load the libraries from
 tomcat.lib.path=../../output/build/lib
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index d4dbf0c..737bf79 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -44,7 +44,9 @@
   They eventually become mixed with the numbered issues (i.e., numbered
   issues do not "pop up" wrt. others).
 -->
-
+
+
+
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] Release Apache Tomcat 10.0.0-M8

[Mark Thomas]

The proposed Apache Tomcat 10.0.0-M8 release is now available for
voting.

Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary
package for all the specification APIs has changed from javax.* to jakarta.*
Applications that run on Tomcat 9 will not run on Tomcat 10 without changes.

The notable changes compared to 10.0.0-M7 are:

- For requests containing the Expect: 100-continue header, optional
  support has been added to delay sending an intermediate 100 status
  response until the servlet reads the request body, allowing the
  servlet the opportunity to respond without asking for the request
  body. Based on a pull request by malaysf.

- Add support for a read idle timeout and a write idle timeout to the
  WebSocket session via custom properties in the user properties
  instance associated with the session. Based on a pull request by
  sakshamverma.

- Update the packaged version of the Tomcat Native Library to 1.2.25

Along with lots of other bug fixes and improvements.


For full details, see the changelog:
https://ci.apache.org/projects/tomcat/tomcat10/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.0-M8/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcatrepo-1276/
The tag is:
https://github.com/apache/tomcat/tree/10.0.0-M8
b3f5e0d88336d81a61a767fc10ab06930c9587ee

The proposed 10.0.0-M8 release is:
[ ] Broken - do not release
[ ] Alpha  - go ahead and release as 10.0.0-M8

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Fix typo

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 29b09f5  Fix typo
29b09f5 is described below

commit 29b09f5342dba837e4a6ab01f3e14027027d89b7
Author: Mark Thomas 
AuthorDate: Wed Sep 9 15:51:51 2020 +0100

Fix typo
---
 webapps/docs/changelog.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index e209416..d4dbf0c 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -168,7 +168,7 @@
 client. (markt)
   
   
-Improve handling of HTTP/2 stream level flow control errors and notidy
+Improve handling of HTTP/2 stream level flow control errors and notify
 the stream immediately if it is waiting for an allocation when the flow
 control error occurs. (markt)
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 9.0.x updated: Fix typo

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new b0b2d37  Fix typo
b0b2d37 is described below

commit b0b2d379e75a6b7d3d001e7480e7fd7e4db85687
Author: Mark Thomas 
AuthorDate: Wed Sep 9 15:51:51 2020 +0100

Fix typo
---
 webapps/docs/changelog.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index ecce19f..2343bea 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -164,7 +164,7 @@
 client. (markt)
   
   
-Improve handling of HTTP/2 stream level flow control errors and notidy
+Improve handling of HTTP/2 stream level flow control errors and notify
 the stream immediately if it is waiting for an allocation when the flow
 control error occurs. (markt)
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Fix typo

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 9d15a7b  Fix typo
9d15a7b is described below

commit 9d15a7b287e4c669c8375f58b89012b20d411f88
Author: Mark Thomas 
AuthorDate: Wed Sep 9 15:51:51 2020 +0100

Fix typo
---
 webapps/docs/changelog.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index c10e4ea..600caa4 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -149,7 +149,7 @@
 client. (markt)
   
   
-Improve handling of HTTP/2 stream level flow control errors and notidy
+Improve handling of HTTP/2 stream level flow control errors and notify
 the stream immediately if it is waiting for an allocation when the flow
 control error occurs. (markt)
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64715] PasswordValidationCallback not supported

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64715

--- Comment #15 from Robert Rodewald  ---
I found an interesting differentiation on this page:
https://github.com/wildfly/wildfly/blob/master/docs/src/main/asciidoc/_elytron/Elytron_and_Java_Authentication_SPI_for_Containers-JASPI.adoc

If a SAM requires access to the configured identity management (the realm) of
the runtime is uses "integrated" mode (this would be a CallbackHandler
implementation that implements Contained).

If it establishes the identity and roles of the user by itself it can use
"non-itegrated" mode (no access to the realm) and is what was supported by
Tomcat before the patch (CallbackHandler does not implement Contained and has
no access to the Realm).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64715] PasswordValidationCallback not supported

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64715

--- Comment #14 from Robert Rodewald  ---
(In reply to Christopher Schultz from comment #12)
> Doesn't this tie the implementation class to Tomcata internals? It would be
> nice to implement a CallbackHandler which can be built (and run)
> independently of Tomcat classes. Or do I have an unrealistic expectation,
> here, of the way CallbackHandlers would be implemented? Is it possible for
> them to be container-agnostic?

In my understanding the CallbackHandler cannot be decoupled from Tomcat (the
"runtime" in the JASPIC specification), because it represents the "glue code"
to the runtime. A replacement of the implementing class is not intended
anywhere in the JASPIC specification as far as I can see, but is a nice thing
to have. This way the user can implement some very special non-standard
Callbacks.

The inner workings of the CallbackHandler are not well defined in the specs,
neither are the standard callbacks. 

For example the PasswordValidationCallback:
- Shall it set the principal in the client subject or shall it just return true
or false for the getResult method?
- The password field may be null (as per spec) but how should the
CallbackHandler handle this case? Set the roles/groups of the principal anyway?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64710

Arshiya  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #14 from Arshiya  ---
Mark , Thank you for the response.
Sorry to have missed out on a few points.

I tried testing the same , post the fix with the hash
https://github.com/apache/tomcat/commit/ea0a200fe29829bd88fb6fecb5549158896b68ea
 

I can still see the BufferOverflow Exception.Please help us with this.

JMeter Version: apache-jmeter-4.0 (with additional plugin for HTTP2)
I have attached the source code and jmx file to reproduce the issue .
To build the source code I have pointed to 9.0.36 in the pom.xml, but while
executing the application , the classpath where the the tomcat jars built from
the given hash is referred.

java -cp  -jar tomcat-9-embedded-1.0.4.jar -Xmx1g
 - where the latest tomcat (9.0.38) jars are placed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64710

--- Comment #13 from Arshiya  ---
Created attachment 37444
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37444=edit
JMX file and Source Code

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64715] PasswordValidationCallback not supported

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64715

--- Comment #13 from Christopher Schultz  ---
(In reply to Robert Rodewald from comment #9)
> Slightly off topic, but could someone explain why the package imports in
> CallbackHandlerImpl switched from
> 
> import javax.security.auth.callback.UnsupportedCallbackException;
> import javax.security.auth.message.callback.CallerPrincipalCallback;
> import javax.security.auth.message.callback.GroupPrincipalCallback;
> 
> in Tomcat 9 to the corresponding jakarta.security.auth equivalents in Tomcat
> 10? Is that a JASPIC 2.0 change?

I don't know about the JASPIC version implications, but Java EE recently change
to Jakarta EE an all the package names changed for their forthcoming versions.
Presumably, this includes JASPIC because it's included in the Java EE
specifications which have been "migrated" to the new Jakarta umbrella. [1]

For all the affected APIs, Tomcat has basically done a search-and-replace for
javax.(api).whatever to jakarta.(api).whatever.

It is not (currently, maybe ever) expected that web applications written for
Tomcat 9 can be directly run under Tomcat 10: they will require migration to
the new API package names. That includes all servlets, etc.[2]

There is an experimental migration tool available[3] which aims to migrate your
web applications from Java EE to Jakarta EE. I'd be interested to see if it
works for you and gives you artifacts you can successfully deploy into Tomcat
10.

[1] https://jakarta.ee/specifications/authentication/1.1/apidocs/
[2] http://tomcat.apache.org/migration-10.html#Specification_APIs
[3] https://github.com/apache/tomcat-jakartaee-migration

> Would we have to support both in Tomcat 10 so that the implementation is
> backwards compatible or am I mislead?

I don't believe any backward-compatibility would be expected. We toyed with
that idea, but it seems like a maintenance nightmare so we decided not to do
it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64715] PasswordValidationCallback not supported

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64715

--- Comment #12 from Christopher Schultz  ---
(In reply to Mark Thomas from comment #7)
> Users may wish to use a 3rd party custom CallbackHandler that knows nothing
> about Tomcat internals. A no-arg Constructor needs to be supported.
> 
> There are multiple class loaders involved and while the default
> configuration avoids most of the complexities, the non-default configs need
> to be handled.
> 
> Some users reconfigure the class loaders so they look like this:
> http://tomcat.apache.org/tomcat-4.1-doc/class-loader-howto.html
> 
> and may want to put the custom CallbackHandler in the Catalina loader. This
> boils down to you need to try and load the specified class first with the
> web app class loader (TCCL) and then with the class loader that loaded the
> current class.
> 
> For adding the Context I'm suggesting something like:
> 
> if (callbackHandler instanceof Contained) {
> ((Contained) callbackHandler).setContainer(context);
> }
> 
> Tomcat can then do:
> if (callbackHandler instanceof Contained) {
> getContainer().getRealm()...
> }

Doesn't this tie the implementation class to Tomcata internals? It would be
nice to implement a CallbackHandler which can be built (and run) independently
of Tomcat classes. Or do I have an unrealistic expectation, here, of the way
CallbackHandlers would be implemented? Is it possible for them to be
container-agnostic?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r41380 - in /dev/tomcat/tomcat-10/v10.0.0-M8: ./ bin/ bin/embed/ src/

[markt]

Author: markt
Date: Wed Sep  9 13:28:54 2020
New Revision: 41380

Log:
Upload Apache Tomcat 10.0.0-M8 for voting

Added:
dev/tomcat/tomcat-10/v10.0.0-M8/
dev/tomcat/tomcat-10/v10.0.0-M8/KEYS
dev/tomcat/tomcat-10/v10.0.0-M8/README.html
dev/tomcat/tomcat-10/v10.0.0-M8/RELEASE-NOTES
dev/tomcat/tomcat-10/v10.0.0-M8/bin/
dev/tomcat/tomcat-10/v10.0.0-M8/bin/README.html
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-deployer.tar.gz 
  (with props)

dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-deployer.tar.gz.asc

dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-deployer.tar.gz.sha512
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-deployer.zip   
(with props)
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-deployer.zip.asc

dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-deployer.zip.sha512
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-fulldocs.tar.gz 
  (with props)

dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-fulldocs.tar.gz.asc

dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-fulldocs.tar.gz.sha512
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-windows-x64.zip 
  (with props)

dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-windows-x64.zip.asc

dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-windows-x64.zip.sha512
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-windows-x86.zip 
  (with props)

dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-windows-x86.zip.asc

dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8-windows-x86.zip.sha512
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8.exe   (with 
props)
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8.exe.asc
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8.exe.sha512
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8.tar.gz   (with 
props)
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8.tar.gz.asc
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8.tar.gz.sha512
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8.zip   (with 
props)
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8.zip.asc
dev/tomcat/tomcat-10/v10.0.0-M8/bin/apache-tomcat-10.0.0-M8.zip.sha512
dev/tomcat/tomcat-10/v10.0.0-M8/bin/embed/

dev/tomcat/tomcat-10/v10.0.0-M8/bin/embed/apache-tomcat-10.0.0-M8-embed.tar.gz  
 (with props)

dev/tomcat/tomcat-10/v10.0.0-M8/bin/embed/apache-tomcat-10.0.0-M8-embed.tar.gz.asc

dev/tomcat/tomcat-10/v10.0.0-M8/bin/embed/apache-tomcat-10.0.0-M8-embed.tar.gz.sha512
dev/tomcat/tomcat-10/v10.0.0-M8/bin/embed/apache-tomcat-10.0.0-M8-embed.zip 
  (with props)

dev/tomcat/tomcat-10/v10.0.0-M8/bin/embed/apache-tomcat-10.0.0-M8-embed.zip.asc

dev/tomcat/tomcat-10/v10.0.0-M8/bin/embed/apache-tomcat-10.0.0-M8-embed.zip.sha512
dev/tomcat/tomcat-10/v10.0.0-M8/src/
dev/tomcat/tomcat-10/v10.0.0-M8/src/apache-tomcat-10.0.0-M8-src.tar.gz   
(with props)
dev/tomcat/tomcat-10/v10.0.0-M8/src/apache-tomcat-10.0.0-M8-src.tar.gz.asc

dev/tomcat/tomcat-10/v10.0.0-M8/src/apache-tomcat-10.0.0-M8-src.tar.gz.sha512
dev/tomcat/tomcat-10/v10.0.0-M8/src/apache-tomcat-10.0.0-M8-src.zip   (with 
props)
dev/tomcat/tomcat-10/v10.0.0-M8/src/apache-tomcat-10.0.0-M8-src.zip.asc
dev/tomcat/tomcat-10/v10.0.0-M8/src/apache-tomcat-10.0.0-M8-src.zip.sha512

Added: dev/tomcat/tomcat-10/v10.0.0-M8/KEYS
==
--- dev/tomcat/tomcat-10/v10.0.0-M8/KEYS (added)
+++ dev/tomcat/tomcat-10/v10.0.0-M8/KEYS Wed Sep  9 13:28:54 2020
@@ -0,0 +1,676 @@
+This file contains the PGP keys of various Apache developers.
+Please don't use them for email unless you have to. Their main
+purpose is code signing.
+
+Apache users: pgp < KEYS
+Apache developers:
+(pgpk -ll  && pgpk -xa ) >> this file.
+  or
+(gpg --fingerprint --list-sigs 
+ && gpg --armor --export ) >> this file.
+
+Apache developers: please ensure that your key is also available via the
+PGP keyservers (such as pgpkeys.mit.edu).
+
+
+Type Bits/KeyIDDate   User ID
+pub  2048/F22C4FED 2001/07/02 Andy Armstrong 
+
+-BEGIN PGP PUBLIC KEY BLOCK-
+Version: PGPfreeware 7.0.3 for non-commercial use 
+
+mQGiBDtAWuURBADZ0KUEyUkSUiTA09e7tvEbX25STsjxrR+DNTainCls+XlkVOij
+gBv216lqge9tIsS0L6hCP4OQbFf/64qVtJssX4QXdyiZGb5wpmcj0Mz602Ew8r+N
+I0S5NvmogoYWW7BlP4r61jNxO5zrr03KaijM5r4ipJdLUxyOmM6P2jRPUwCg/5gm
+bpqiYl7pXX5FgDeB36tmD+UD/06iLqOnoiKO0vMbOk7URclhCObMNrHqxTxozMTS
+B9soYURbIeArei+plYo2n+1qB12ayybjhVu3uksXRdT9bEkyxMfslvLbIpDAG8Cz
+gNftTbKx/MVS7cQU0II8BKo2Akr+1FZah+sD4ovK8SfkMXUQUbTeefTntsAQKyyU
+9M9tA/9on9tBiHFl0qVJht6N4GiJ2G689v7rS2giLgKjetjiCduxBXEgvUSuyQID

Request for documentation improvement: changelog UI

[Christopher Schultz]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

All,

Could someone better at CSS look into this for me?

I sometimes find myself searching the changelog for some string e.g.
"keystore". I generally do that by loading-up the changelog in my
browser and using the browser's "Find" feature to search the text. (Duh)
.

The changelog for each version, however, usually stretches to a few
screen-heights and it's often not possible to see the version number
where a particular changelog item is included. I often have to find
something, then scroll "up" to see the version number.

This isn't a big deal when locating something specific: it generally
occurs once (like a bug id) and then you go look at the version number
and you are done.

But when trying to find something that happened between versions X and
Y, there is a great deal of scrolling, searching, re-scrolling,
re-searching, etc. which may be avoided if the following is possible.
(And I'm sure it is).

What I'd like is for the  headings on the changelog pages to
"stick" to the top of the screen as they are scrolled. So, for
example, if you load the changelog for Tomcat 9, you'll see at the
very top of the page there is the standard Tomcat documentation header
("Tomcat", current version number, latest release-date), then the
"Changelog" header, then the first  which is currently "Tomcat
9.0.37 (markt)".

As you scroll, the "Tomcat 9.0.37 (markt)" eventually scrolls up off
the top of the visible page (as web pages generally do). Instead, when
that heading gets to the top of the page, I'd like it to "stick" there
until scrolling replaces it with the next  in the order, which is
currently "Tomcat 9.0.36 (markt)".

This would keep the version number where fixes/improvements have been
made at the top of the screen during any searching activity and make
it much easier to hunt for certain kinds of fixes.

Is anyone willing to look into implementing the above?

- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl9Y17oACgkQHPApP6U8
pFjN0xAAhfFd0Yl69XF38f5tSYtMQMQcDNIOywVDXCIBWnYaSIUPWvzFAPeq0uv/
t7Hvc2MlQ+QlKfu3aiq0PEOpCRy2QEQ9EDDGEonxRPvhQrkhUIDlkuGpTvYrS1XA
RF7XSUuV+g9eVyFeh1KQEQP1BCAKXjxXLNl51v6xHP+FMiySAtAgCF7U3DVbB/fw
rXILy6/wgSjdWyQkcC+yZ/5OHxp9R3s8E80MT0Kdwp7oTtdlCq0bFOdcmqQZqC92
9658bGQhllYfF7eqMeWRVO8TdlIyAI0RFJU8gVlt9IGWy5OHzc6QB853O4ejA8G0
xrjeKVwzWYBNUImkfxxqXoOSdK8/rKK/zEZtBi7GuHeYLiqn8JBvFS4NZGp0rMNY
xWYAf0Nhql+y+gDDbpk10CplptNePCUXjF6fSX7IPSsgpBwyjDbGl671s08DOM83
TJq5NwwjJS37kPmHY7g0DRdhtn0dKf45H97Kdpqm/BEp8Vua63eEtK8WFFXmOVBd
hhEADE8ccQg639U5jxshI9F3wxnChNcfOSKDcdxmCU0Rgfslq3ujgqzZ2sqCHNVP
9SwJiolW76PUFLG02LasM1FYzPSYv85a/0DH5lPGUMpB3EvczCnu5FWagsTS3fu5
8JCHz7Eyo1SrijeMtE/NgSV0LpKbuGjh8v+BUBODiW+jD8vfxxI=
=4+RB
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] tandraschko commented on a change in pull request #355: [perf] Lazy init ELContext#listeners to avoid unnecessary ArrayList and ArrayList$Itr

[GitBox]

tandraschko commented on a change in pull request #355:
URL: https://github.com/apache/tomcat/pull/355#discussion_r485599668



##
File path: java/jakarta/el/ELContext.java
##
@@ -139,6 +140,10 @@ public void setLocale(Locale locale) {
  * @since EL 3.0
  */
 public void addEvaluationListener(EvaluationListener listener) {
+if (listeners == null) {

Review comment:
   i dont think so. At least in JSF and JSP it should be used "request 
scoped". Also currently it doesnt use a concurrent list impl.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] tandraschko commented on a change in pull request #355: [perf] Lazy init ELContext#listeners to avoid unnecessary ArrayList and ArrayList$Itr

[GitBox]

tandraschko commented on a change in pull request #355:
URL: https://github.com/apache/tomcat/pull/355#discussion_r485599668



##
File path: java/jakarta/el/ELContext.java
##
@@ -139,6 +140,10 @@ public void setLocale(Locale locale) {
  * @since EL 3.0
  */
 public void addEvaluationListener(EvaluationListener listener) {
+if (listeners == null) {

Review comment:
   i dont think so. At least in JSF and JSP it should be used "request 
scoped". Also currently it doesnt use concurrent list impl.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] martin-g commented on a change in pull request #355: [perf] Lazy init ELContext#listeners to avoid unnecessary ArrayList and ArrayList$Itr

[GitBox]

martin-g commented on a change in pull request #355:
URL: https://github.com/apache/tomcat/pull/355#discussion_r485590380



##
File path: java/jakarta/el/ELContext.java
##
@@ -139,6 +140,10 @@ public void setLocale(Locale locale) {
  * @since EL 3.0
  */
 public void addEvaluationListener(EvaluationListener listener) {
+if (listeners == null) {

Review comment:
   Is it possible that this method is called by multiple threads ? In that 
case you will need to add locking here.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] 01/01: Tag 10.0.0-M8

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to tag 10.0.0-M8
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit b3f5e0d88336d81a61a767fc10ab06930c9587ee
Author: Mark Thomas 
AuthorDate: Wed Sep 9 11:37:17 2020 +0100

Tag 10.0.0-M8
---
 build.properties.default   | 2 +-
 webapps/docs/changelog.xml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/build.properties.default b/build.properties.default
index 57ec1c6..e1f858c 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -27,7 +27,7 @@ version.major=10
 version.minor=0
 version.build=0
 version.patch=0
-version.suffix=-M8-dev
+version.suffix=-M8
 
 # - Source control flags -
 git.branch=master
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index e209416..af8aa6b 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -44,7 +44,7 @@
   They eventually become mixed with the numbered issues (i.e., numbered
   issues do not "pop up" wrt. others).
 -->
-
+
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] tag 10.0.0-M8 created (now b3f5e0d)

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a change to tag 10.0.0-M8
in repository https://gitbox.apache.org/repos/asf/tomcat.git.


  at b3f5e0d  (commit)
This tag includes the following new commits:

 new b3f5e0d  Tag 10.0.0-M8

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64715] PasswordValidationCallback not supported

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64715

--- Comment #11 from Robert Rodewald  ---
Created attachment 37440
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37440=edit
Proposed patch for bug 64715 (second attempt), Tomcat 9

The Tomcat 9.0.x version of the patch.

Main difference is the difference in the package names for the callbacks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64715] PasswordValidationCallback not supported

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64715

Robert Rodewald  changed:

   What|Removed |Added

  Attachment #37438|0   |1
is obsolete||

--- Comment #10 from Robert Rodewald  ---
Created attachment 37439
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37439=edit
Proposed patch for bug 64715 (second attempt), Tomcat 10

- corrected a spelling error in Locale.properties

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64715] PasswordValidationCallback not supported

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64715

Robert Rodewald  changed:

   What|Removed |Added

  Attachment #37438|Proposed patch for bug  |Proposed patch for bug
description|64715 (second attempt)  |64715 (second attempt),
   ||Tomcat 10

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64715] PasswordValidationCallback not supported

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64715

--- Comment #9 from Robert Rodewald  ---
Slightly off topic, but could someone explain why the package imports in
CallbackHandlerImpl switched from

import javax.security.auth.callback.UnsupportedCallbackException;
import javax.security.auth.message.callback.CallerPrincipalCallback;
import javax.security.auth.message.callback.GroupPrincipalCallback;

in Tomcat 9 to the corresponding jakarta.security.auth equivalents in Tomcat
10? Is that a JASPIC 2.0 change?

Would we have to support both in Tomcat 10 so that the implementation is
backwards compatible or am I mislead? I stumbled upon this while implementing
the tests for my patch and I am quite sure that my own SAM implementation
written for Tomcat 9 would not work with Tomcat 10 because of this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] tandraschko opened a new pull request #355: [perf] Lazy init ELContext#listeners to avoid unnecessary ArrayList and ArrayList$Itr

[GitBox]

tandraschko opened a new pull request #355:
URL: https://github.com/apache/tomcat/pull/355


   It would also be great if you could port it to older branches



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64715] PasswordValidationCallback not supported

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64715

Robert Rodewald  changed:

   What|Removed |Added

  Attachment #37434|0   |1
is obsolete||

--- Comment #8 from Robert Rodewald  ---
Created attachment 37438
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37438=edit
Proposed patch for bug 64715 (second attempt)

Changes to the first version:

- added Contained interface to CallbackHandlerImpl and changed access logic
- implemented check for Contained interface instead of different constructors
in AuthenticatorBase
- added test cases for the three supported Callbacks


A questions that occurred to me:
- Should we throw UnsupportedCallbackException for unsupported callbacks
instead of ignoring them? This breaks compatibility but would enable the user
to check for unimplemented callbacks.

The use of the Contained interface is definitely a big plus. Thanks for the
great feedback Mark.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Fix intermittently failing test

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new d021d5d  Fix intermittently failing test
d021d5d is described below

commit d021d5d7f119bf27d6c88d98c8f2080fc956b72a
Author: Mark Thomas 
AuthorDate: Wed Sep 9 09:54:47 2020 +0100

Fix intermittently failing test

Writes as well as reads will break if the server closes the connection
---
 test/org/apache/coyote/http2/TestHttp2Limits.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/org/apache/coyote/http2/TestHttp2Limits.java 
b/test/org/apache/coyote/http2/TestHttp2Limits.java
index 633f403..327bfde 100644
--- a/test/org/apache/coyote/http2/TestHttp2Limits.java
+++ b/test/org/apache/coyote/http2/TestHttp2Limits.java
@@ -44,8 +44,8 @@ public class TestHttp2Limits extends Http2TestBase {
 http2Connect(false);
 
 for (int i = 0; i < 100; i++) {
-sendSettings(0, false);
 try {
+sendSettings(0, false);
 parser.readFrame(true);
 } catch (IOException ioe) {
 // Server closed connection before client has a chance to read


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 9.0.x updated: Fix intermittently failing test

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new ea0a200  Fix intermittently failing test
ea0a200 is described below

commit ea0a200fe29829bd88fb6fecb5549158896b68ea
Author: Mark Thomas 
AuthorDate: Wed Sep 9 09:54:47 2020 +0100

Fix intermittently failing test

Writes as well as reads will break if the server closes the connection
---
 test/org/apache/coyote/http2/TestHttp2Limits.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/org/apache/coyote/http2/TestHttp2Limits.java 
b/test/org/apache/coyote/http2/TestHttp2Limits.java
index 633f403..327bfde 100644
--- a/test/org/apache/coyote/http2/TestHttp2Limits.java
+++ b/test/org/apache/coyote/http2/TestHttp2Limits.java
@@ -44,8 +44,8 @@ public class TestHttp2Limits extends Http2TestBase {
 http2Connect(false);
 
 for (int i = 0; i < 100; i++) {
-sendSettings(0, false);
 try {
+sendSettings(0, false);
 parser.readFrame(true);
 } catch (IOException ioe) {
 // Server closed connection before client has a chance to read


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Fix intermittently failing test

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 2348b11  Fix intermittently failing test
2348b11 is described below

commit 2348b113fd82a97b84662596834807f031a9a6ef
Author: Mark Thomas 
AuthorDate: Wed Sep 9 09:54:47 2020 +0100

Fix intermittently failing test

Writes as well as reads will break if the server closes the connection
---
 test/org/apache/coyote/http2/TestHttp2Limits.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/org/apache/coyote/http2/TestHttp2Limits.java 
b/test/org/apache/coyote/http2/TestHttp2Limits.java
index c8f463a..1e9644d 100644
--- a/test/org/apache/coyote/http2/TestHttp2Limits.java
+++ b/test/org/apache/coyote/http2/TestHttp2Limits.java
@@ -45,8 +45,8 @@ public class TestHttp2Limits extends Http2TestBase {
 http2Connect(false);
 
 for (int i = 0; i < 100; i++) {
-sendSettings(0, false);
 try {
+sendSettings(0, false);
 parser.readFrame(true);
 } catch (IOException ioe) {
 // Server closed connection before client has a chance to read


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 9.0.x updated: Fix intermittent failures observed running tests locally

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new ae1cc8f  Fix intermittent failures observed running tests locally
ae1cc8f is described below

commit ae1cc8f9b66e4d56b5163780fb1a1cf541bf4993
Author: Mark Thomas 
AuthorDate: Wed Sep 9 08:51:56 2020 +0100

Fix intermittent failures observed running tests locally
---
 test/org/apache/coyote/http2/TestHttp2Limits.java | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/test/org/apache/coyote/http2/TestHttp2Limits.java 
b/test/org/apache/coyote/http2/TestHttp2Limits.java
index 2fa0686..633f403 100644
--- a/test/org/apache/coyote/http2/TestHttp2Limits.java
+++ b/test/org/apache/coyote/http2/TestHttp2Limits.java
@@ -45,7 +45,13 @@ public class TestHttp2Limits extends Http2TestBase {
 
 for (int i = 0; i < 100; i++) {
 sendSettings(0, false);
-parser.readFrame(true);
+try {
+parser.readFrame(true);
+} catch (IOException ioe) {
+// Server closed connection before client has a chance to read
+// the Goaway frame. Treat this as a pass.
+return;
+}
 String trace = output.getTrace();
 if (trace.equals("0-Settings-Ack\n")) {
 // Test continues


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Fix intermittent failures observed running tests locally

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 1ebb3ff  Fix intermittent failures observed running tests locally
1ebb3ff is described below

commit 1ebb3ffd8a915f9e0cd723169538b2a9ccc86a6b
Author: Mark Thomas 
AuthorDate: Wed Sep 9 08:51:56 2020 +0100

Fix intermittent failures observed running tests locally
---
 test/org/apache/coyote/http2/TestHttp2Limits.java | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/test/org/apache/coyote/http2/TestHttp2Limits.java 
b/test/org/apache/coyote/http2/TestHttp2Limits.java
index 2fa0686..633f403 100644
--- a/test/org/apache/coyote/http2/TestHttp2Limits.java
+++ b/test/org/apache/coyote/http2/TestHttp2Limits.java
@@ -45,7 +45,13 @@ public class TestHttp2Limits extends Http2TestBase {
 
 for (int i = 0; i < 100; i++) {
 sendSettings(0, false);
-parser.readFrame(true);
+try {
+parser.readFrame(true);
+} catch (IOException ioe) {
+// Server closed connection before client has a chance to read
+// the Goaway frame. Treat this as a pass.
+return;
+}
 String trace = output.getTrace();
 if (trace.equals("0-Settings-Ack\n")) {
 // Test continues


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Fix intermittent failures observed running tests locally

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new b2b72d9  Fix intermittent failures observed running tests locally
b2b72d9 is described below

commit b2b72d974b5c194a6905b1f9b0348943bb501240
Author: Mark Thomas 
AuthorDate: Wed Sep 9 08:51:56 2020 +0100

Fix intermittent failures observed running tests locally
---
 test/org/apache/coyote/http2/TestHttp2Limits.java | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/test/org/apache/coyote/http2/TestHttp2Limits.java 
b/test/org/apache/coyote/http2/TestHttp2Limits.java
index 32bad19..c8f463a 100644
--- a/test/org/apache/coyote/http2/TestHttp2Limits.java
+++ b/test/org/apache/coyote/http2/TestHttp2Limits.java
@@ -46,7 +46,13 @@ public class TestHttp2Limits extends Http2TestBase {
 
 for (int i = 0; i < 100; i++) {
 sendSettings(0, false);
-parser.readFrame(true);
+try {
+parser.readFrame(true);
+} catch (IOException ioe) {
+// Server closed connection before client has a chance to read
+// the Goaway frame. Treat this as a pass.
+return;
+}
 String trace = output.getTrace();
 if (trace.equals("0-Settings-Ack\n")) {
 // Test continues


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org