[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva closed issue #19: How can I add .groovy file support that do not get converted to .class files
ShamithaSIlva closed issue #19: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva commented on issue #19: How can I add .groovy file support that do not get converted to .class files
ShamithaSIlva commented on issue #19: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841338343 Adding the extension on the file works: https://github.com/apache/tomcat-jakartaee-migration/blob/master/src/main/java/org/apache/tomcat/jakartaee/TextConverter.java#L37 Thanks a lot guys! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva commented on issue #19: How can I add .groovy file support that do not get converted to .class files
ShamithaSIlva commented on issue #19: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841323483 > Yes, just add your extension here: > https://github.com/apache/tomcat-jakartaee-migration/blob/master/src/main/java/org/apache/tomcat/jakartaee/TextConverter.java#L37 Yes I suspected here and added the line let's see. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] rmaucher commented on issue #19: How can I add .groovy file support that do not get converted to .class files
rmaucher commented on issue #19: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841321964 Yes, just add your extension here: https://github.com/apache/tomcat-jakartaee-migration/blob/master/src/main/java/org/apache/tomcat/jakartaee/TextConverter.java#L37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva commented on issue #19: How can I add .groovy file support that do not get converted to .class files
ShamithaSIlva commented on issue #19: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841320652 > Latest 1.0.1-SNAPSHOT here has a f ix you can test: > https://repository.apache.org/content/repositories/snapshots/ > > Note: This is NOT an official ASF release. It is provided solely for the purposes of testing this fix. Use it at your own risk. If you want to update the JAR in Tomcat 10 that does this migration at deployment time you want the shaded JAR. Thanks will try this I thought it should work if I add .grovvy in supportedExtensions in TextConverter file. Will reply if this works with this snapshot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] markt-asf commented on issue #19: How can I add .groovy file support that do not get converted to .class files
markt-asf commented on issue #19: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841318850 Latest 1.0.1-SNAPSHOT here has a f ix you can test: https://repository.apache.org/content/repositories/snapshots/ Note: This is NOT an official ASF release. It is provided solely for the purposes of testing this fix. Use it at your own risk. If you want to update the JAR in Tomcat 10 that does this migration at deployment time you want the shaded JAR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] rmaucher commented on issue #19: How can I add .groovy file support that do not get converted to .class files
rmaucher commented on issue #19: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841318244 Ideally, it has to be done magically [this is mandatory for the Tomcat auto deployment migration to work, since there's very little room for configuration] but this looks hard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] markt-asf commented on issue #19: How can I add .groovy file support that do not get converted to .class files
markt-asf commented on issue #19: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19#issuecomment-841313392 That will need a code change. Longer term we might want to think about making this more configurable. For now, give me a few minutes and I'll have a snapshot build you can test... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva opened a new issue #19: How can I add .groovy file support that do not get converted to .class files
ShamithaSIlva opened a new issue #19: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/19 I have Groovy files having .groovy extensions that do not get compiled to .class file even after deployment. But they still have text based entries on those files like: import javax.servlet.http.HttpServletResponse. Where should I change to add support for such files? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] markt-asf closed issue #18: A way to skip conversion for libraries in WEB-INF/lib
markt-asf closed issue #18: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/18 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] markt-asf commented on issue #18: A way to skip conversion for libraries in WEB-INF/lib
markt-asf commented on issue #18: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/18#issuecomment-841257553 This is already implemented. Use the `-exclude` option on the command line or `Migration.addExclude(String)` if using the API. Note that there is also an Ant Task to perform the migration during the build process and all the migrations will work on both source and compiled code. Between them you have lots of options for how you structure things so the process works best for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Release Managers wanted
On 14/05/2021 14:37, Rémy Maucherat wrote: On Fri, May 14, 2021 at 12:06 PM Mark Thomas wrote: On 14/05/2021 09:39, Rémy Maucherat wrote: On Thu, May 13, 2021 at 12:10 AM Mark Thomas wrote: So, who'd like to volunteer? Well, I used to RM Tomcat a while ago, but I don't think I was very good at it. Is it time to start again ?? That would be great. I'm certainly not going to complain if are able and willing to start RM'ing again. As Chris has volunteered for 8.5.x can I tempt you with 9.0.x? Possibly. I'll need to get my signing key situation sorted out first though. OK. I'll start setting you up with the Windows code signing service. It would be good to have another person set up just in case. Expect a few emails from DigiCert. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] ShamithaSIlva opened a new issue #18: A way to skip conversion for libraries in WEB-INF/lib
ShamithaSIlva opened a new issue #18: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/18 Hi first of all, thanks for the efforts for this plugin. This is not an issue but asking a way to skip conversion of libraries inside a war (WEB-INF/lib). Because libraries do not get changed often so we can save time on conversion between builds (After converting for the first time). So when deployed, old libraries can be manually copied and replaced on the server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Release Managers wanted
On Fri, May 14, 2021 at 12:06 PM Mark Thomas wrote: > On 14/05/2021 09:39, Rémy Maucherat wrote: > > On Thu, May 13, 2021 at 12:10 AM Mark Thomas wrote: > > > > >> So, who'd like to volunteer? > >> > > > > Well, I used to RM Tomcat a while ago, but I don't think I was very good > at > > it. Is it time to start again ?? > > That would be great. I'm certainly not going to complain if are able and > willing to start RM'ing again. As Chris has volunteered for 8.5.x can I > tempt you with 9.0.x? > Possibly. I'll need to get my signing key situation sorted out first though. Rémy
buildbot failure in on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5827 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch master] 945db374e75e4925b78be67552f5b362cbfe00d7 Blamelist: Mark Thomas BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Release Managers wanted
On 14/05/2021 09:39, Rémy Maucherat wrote: On Thu, May 13, 2021 at 12:10 AM Mark Thomas wrote: So, who'd like to volunteer? Well, I used to RM Tomcat a while ago, but I don't think I was very good at it. Is it time to start again ?? That would be great. I'm certainly not going to complain if are able and willing to start RM'ing again. As Chris has volunteered for 8.5.x can I tempt you with 9.0.x? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Release Managers wanted
On 14/05/2021 10:58, Emmanuel Bourg wrote: Le 2021-05-13 00:10, Mark Thomas a écrit : So, who'd like to volunteer? I can take care of the migration tool if you want. Thanks. Done :) It should all be standard the ASF / Maven release process. My personal notes on how to release just say: See https://infra.apache.org/publishing-maven-artifacts.html but if you have any questions just let me know. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Release Managers wanted
Le 2021-05-13 00:10, Mark Thomas a écrit : So, who'd like to volunteer? I can take care of the migration tool if you want. Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Fix typos
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new fdb1f56 Fix typos fdb1f56 is described below commit fdb1f5655dc5cafa61338647747134a2692d1a79 Author: Mark Thomas AuthorDate: Fri May 14 10:48:56 2021 +0100 Fix typos --- webapps/docs/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 9b34c65..f39aa5f 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -107,7 +107,7 @@ -65303; Fix a possible NullPointerException is +65303: Fix a possible NullPointerException if an error occurs on an HTTP/1.1 connection being upgraded to HTTP/2 or on a pushed HTTP/2 stream. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 03/03: Fix typos
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 945db374e75e4925b78be67552f5b362cbfe00d7 Author: Mark Thomas AuthorDate: Fri May 14 10:48:56 2021 +0100 Fix typos --- webapps/docs/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 1dc6671..0efc03d 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -107,7 +107,7 @@ -65303; Fix a possible NullPointerException is +65303: Fix a possible NullPointerException if an error occurs on an HTTP/1.1 connection being upgraded to HTTP/2 or on a pushed HTTP/2 stream. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix typos
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 52fe669 Fix typos 52fe669 is described below commit 52fe6696b2931f28cb5e6ef83e908f5496c8c5a3 Author: Mark Thomas AuthorDate: Fri May 14 10:48:56 2021 +0100 Fix typos --- webapps/docs/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index a3e7adc..5408c65 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -107,7 +107,7 @@ -65303; Fix a possible NullPointerException is +65303: Fix a possible NullPointerException if an error occurs on an HTTP/1.1 connection being upgraded to HTTP/2 or on a pushed HTTP/2 stream. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 01/03: Add release date for 10.0.6
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit e0014f2b77b44aecd56c68911d28ab3344506e6c Author: Mark Thomas AuthorDate: Wed May 12 22:52:03 2021 +0100 Add release date for 10.0.6 --- webapps/docs/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 3e66c96..1dc6671 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -126,7 +126,7 @@ - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated (1b2cad4 -> 945db37)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 1b2cad4 Refactor to use compile time rather than run time type checking new e0014f2 Add release date for 10.0.6 new 7d5f38c Remove unnecessary code - packageless classes are not supported new 945db37 Fix typos The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: java/org/apache/jasper/compiler/Generator.java | 8 +++- webapps/docs/changelog.xml | 4 ++-- 2 files changed, 5 insertions(+), 7 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 02/03: Remove unnecessary code - packageless classes are not supported
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 7d5f38c44a157cd01ad3cab67e1f4c4ea89d193d
Author: Mark Thomas
AuthorDate: Fri May 14 09:39:23 2021 +0100
Remove unnecessary code - packageless classes are not supported
---
java/org/apache/jasper/compiler/Generator.java | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/java/org/apache/jasper/compiler/Generator.java
b/java/org/apache/jasper/compiler/Generator.java
index 88e460f..c3092b2 100644
--- a/java/org/apache/jasper/compiler/Generator.java
+++ b/java/org/apache/jasper/compiler/Generator.java
@@ -3610,11 +3610,9 @@ class Generator {
// Generate package declaration
String className = tagInfo.getTagClassName();
int lastIndex = className.lastIndexOf('.');
-if (lastIndex != -1) {
-String packageName = className.substring(0, lastIndex);
-genPreamblePackage(packageName);
-className = className.substring(lastIndex + 1);
-}
+String packageName = className.substring(0, lastIndex);
+genPreamblePackage(packageName);
+className = className.substring(lastIndex + 1);
// Generate imports
genPreambleImports();
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Release Managers wanted
On Thu, May 13, 2021 at 12:10 AM Mark Thomas wrote: > All, > > Assuming 7.0.109 is the last Tomcat 7 release I am the current release > manager for 10.0.x, 9.0.x, 8.5.x, migration tool, native and mod_jk. I'd > like to share the load and the knowledge a little. > > The step-by-step release process was documented for Tomcat 7: > https://cwiki.apache.org/confluence/display/TOMCAT/ReleaseProcess > > It needs a few minor updates but that should give you an idea of what is > involved. > > I suggest that the major Tomcat versions are actually easier to release as: > - the process is more automated > - because the happen on a roughly monthly cycle you don't forget too >much of the detail between releases > - there is greater flexibility in the build environment (anything that >needs a Windows binary needs a very specific environment to avoid >unwanted system dependencies) > > You should be able to build on Linux or Windows (or MacOS assuming > cygwin works well enough with NSIS) although anything other than Windows > will require a little more setup in the first instance > > I'd be happy to mentor volunteers through their first couple of releases. > > Once you get into the swing of things, the process is fairly quick. > > The only pre-requisite is that you need to be a committer. > > So, who'd like to volunteer? > Well, I used to RM Tomcat a while ago, but I don't think I was very good at it. Is it time to start again ?? Rémy > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: Release Managers wanted
On 13/05/2021 21:36, Christopher Schultz wrote: Michael, On 5/13/21 13:01, Michael Osipov wrote: Am 2021-05-13 um 00:10 schrieb Mark Thomas: All, Assuming 7.0.109 is the last Tomcat 7 release I am the current release manager for 10.0.x, 9.0.x, 8.5.x, migration tool, native and mod_jk. I'd like to share the load and the knowledge a little. The step-by-step release process was documented for Tomcat 7: https://cwiki.apache.org/confluence/display/TOMCAT/ReleaseProcess Looking at the cwiki it does not apply to tcnative..Do you have instructions? My long-term goal would be to provide a CMake-based generator, cross-platform. IIRC, releasing tcnative is pretty terrible because you have to build it with some ancient version of the Windows Driver Development Kit to ensure you don't introduce dependencies on weird MSVCRT.DLL versions. There is a howto page somewhere... https://cwiki.apache.org/confluence/display/TOMCAT/Building+the+native+Tomcat+components+for+Windows If you use a pre-built CMSC distribution it isn't too bad. I should update the Wiki to use that option - or at least mention it. The Native build process could easily be scripted. All the commands are in the wiki. I haven't scripted it so far, partly because the releases are so infrequent it hasn't seemed worth it and partly because I like to do it manually so I can keep a closer eye on what is going on. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
