[Bug 65390] Problem in the code generated by jasper
https://bz.apache.org/bugzilla/show_bug.cgi?id=65390 --- Comment #10 from Konstantin Kolinko --- Note that release candidate binaries are available for Tomcat 10.1.0-M2, 10.0.8, 9.0.50, and 8.5.69. See "[VOTE]" threads on the dev@ mailing list for links. https://tomcat.apache.org/lists.html#tomcat-dev -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65408] New: tomcat8.5.X occurs an AssertionError occationally after running for a period of time
https://bz.apache.org/bugzilla/show_bug.cgi?id=65408 Bug ID: 65408 Summary: tomcat8.5.X occurs an AssertionError occationally after running for a period of time Product: Tomcat 8 Version: 8.5.x-trunk Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: 739711...@qq.com Target Milestone: Tomcat Version:8.5.X -- 8.5.64 JDK: Java(TM) SE Runtime Environment (build 1.8.0_66-b17) OS: CentOS Linux release 7.4.1708 (Core) Problem phenomen: websocket requests failed after running for a period of time Error report: AssertionError and NullPointerException are in the same time, tomcat8.5.64 has problem running in APR or NIO tomcat mode! 28, 2021 9:30:13 org.apache.coyote.http11.Http11Processor service : Ĵ java.lang.AssertionError at org.apache.catalina.mapper.Mapper.internalMap(Mapper.java:744) at org.apache.catalina.mapper.Mapper.map(Mapper.java:702) at org.apache.catalina.connector.CoyoteAdapter.postParseRequest(CoyoteAdapter.java:714) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:358) at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:616) at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65) at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:831) at org.apache.tomcat.util.net.AprEndpoint$SocketWithOptionsProcessor.run(AprEndpoint.java:2045) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) at java.lang.Thread.run(Thread.java:745) [2021-04-28 09:30:13.369] http-apr-0.0.0.0-31998-exec-21 [ERROR] ErrorPageFilter#forwardToErrorPage(190)Forwarding to error page from request [null] due to exception [null] java.lang.NullPointerException: null 28, 2021 9:30:13 org.apache.catalina.core.StandardWrapperValve invoke : ·Ϊ[/ctl]Уservlet[dispatcherServlet]Servlet.service()쳣 java.lang.NullPointerException at org.springframework.boot.web.servlet.support.ErrorPageFilter.forwardToErrorPage(ErrorPageFilter.java:197) at org.springframework.boot.web.servlet.support.ErrorPageFilter.handleException(ErrorPageFilter.java:180) at org.springframework.boot.web.servlet.support.ErrorPageFilter.doFilter(ErrorPageFilter.java:145) at org.springframework.boot.web.servlet.support.ErrorPageFilter.access$000(ErrorPageFilter.java:66) at org.springframework.boot.web.servlet.support.ErrorPageFilter$1.doFilterInternal(ErrorPageFilter.java:105) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) at org.springframework.boot.web.servlet.support.ErrorPageFilter.doFilter(ErrorPageFilter.java:123) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:200) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:200) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:544) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:143) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:81) at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:698) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:364) at org.apache.coyote.http
[Bug 65390] Problem in the code generated by jasper
https://bz.apache.org/bugzilla/show_bug.cgi?id=65390 --- Comment #11 from tk...@ai-ag.de --- Thank you for pointing us to those repositories! Our nightlies have been adjusted and I can confirm, that the fix provided with upcoming 9.0.50 works for all our JSPs :) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65408] tomcat8.5.X occurs an AssertionError occationally after running for a period of time
https://bz.apache.org/bugzilla/show_bug.cgi?id=65408 jiangyangyang <739711...@qq.com> changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from jiangyangyang <739711...@qq.com> --- Tomcat Version:8.5.X -- 8.5.64 JDK: Java(TM) SE Runtime Environment (build 1.8.0_66-b17) OS: CentOS Linux release 7.4.1708 (Core) Problem phenomen: websocket requests occationally failed after running for a period of time CPU/MEM status: CPU used 9.6% ; Mem used 54.7% ; JVM Heap used 54.7% Error report: AssertionError and NullPointerException occationally are in the same time , tomcat8.5.64 has problem running in APR or NIO tomcat mode! 28, 2021 9:30:13 org.apache.coyote.http11.Http11Processor service : Ĵ java.lang.AssertionError at org.apache.catalina.mapper.Mapper.internalMap(Mapper.java:744) at org.apache.catalina.mapper.Mapper.map(Mapper.java:702) at org.apache.catalina.connector.CoyoteAdapter.postParseRequest(CoyoteAdapter.java:714) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:358) at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:616) at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65) at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:831) at org.apache.tomcat.util.net.AprEndpoint$SocketWithOptionsProcessor.run(AprEndpoint.java:2045) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) at java.lang.Thread.run(Thread.java:745) [2021-04-28 09:30:13.369] http-apr-0.0.0.0-31998-exec-21 [ERROR] ErrorPageFilter#forwardToErrorPage(190)Forwarding to error page from request [null] due to exception [null] java.lang.NullPointerException: null 28, 2021 9:30:13 org.apache.catalina.core.StandardWrapperValve invoke : ·Ϊ[/ctl]Уservlet[dispatcherServlet]Servlet.service()쳣 java.lang.NullPointerException at org.springframework.boot.web.servlet.support.ErrorPageFilter.forwardToErrorPage(ErrorPageFilter.java:197) at org.springframework.boot.web.servlet.support.ErrorPageFilter.handleException(ErrorPageFilter.java:180) at org.springframework.boot.web.servlet.support.ErrorPageFilter.doFilter(ErrorPageFilter.java:145) at org.springframework.boot.web.servlet.support.ErrorPageFilter.access$000(ErrorPageFilter.java:66) at org.springframework.boot.web.servlet.support.ErrorPageFilter$1.doFilterInternal(ErrorPageFilter.java:105) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) at org.springframework.boot.web.servlet.support.ErrorPageFilter.doFilter(ErrorPageFilter.java:123) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:200) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:200) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:544) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:143) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:81) at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:698) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:364) at org.apache.coyote.http11.Http11Processor.service(
[Bug 65408] tomcat8.5.X occurs an AssertionError occationally after running for a period of time
https://bz.apache.org/bugzilla/show_bug.cgi?id=65408 jiangyangyang <739711...@qq.com> changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65408] tomcat8.5.X occurs an AssertionError occationally after running for a period of time
https://bz.apache.org/bugzilla/show_bug.cgi?id=65408 jiangyangyang <739711...@qq.com> changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.50
On 28/06/2021 10:56, Rémy Maucherat wrote: The proposed Apache Tomcat 9.0.50 release is now available for voting. The proposed 9.0.50 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 9.0.50 (stable) -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
On Wed, Jun 30, 2021 at 7:45 AM Konstantin Kolinko wrote: > > ср, 30 июн. 2021 г. в 00:03, Christopher Schultz > : > > > > [...] > > > > It can be obtained from: > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/ > > > > The Maven staging repo is: > > https://repository.apache.org/content/repositories/orgapachetomcat-1322/ > > The Maven repository responds with 404: > > Repository "orgapachetomcat-1322 (staging: open)" > [id=orgapachetomcat-1322] exists but is not exposed. I tried closing it but this failed as the artefacts are not signed. So this will have to be dropped and rebuilt. Rémy > > Best regards, > Konstantin Kolinko > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65409] New: failed to set property [acceptorThreadCount] to [2]
https://bz.apache.org/bugzilla/show_bug.cgi?id=65409 Bug ID: 65409 Summary: failed to set property [acceptorThreadCount] to [2] Product: Tomcat 10 Version: 10.0.6 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: bernd.wah...@k2interactive.de Target Milestone: -- This warning start to appear after update from tomcat 9.0.46 to 10.0.6/10.0.7 tomcat.2021-06-30.log:30-Jun-2021 09:59:48.469 WARNING [main] org.apache.tomcat.util.digester.SetPropertiesRule.begin Match [Server/Service/Connector] failed to set property [acceptorThreadCount] to [2] i tried only on staging (with only 2 cpus). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65409] failed to set property [acceptorThreadCount] to [2]
https://bz.apache.org/bugzilla/show_bug.cgi?id=65409 qeepcologne changed: What|Removed |Added Component|Catalina|Util -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65409] failed to set property [acceptorThreadCount] to [2]
https://bz.apache.org/bugzilla/show_bug.cgi?id=65409 qeepcologne changed: What|Removed |Added Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65409] failed to set property [acceptorThreadCount] to [2]
https://bz.apache.org/bugzilla/show_bug.cgi?id=65409 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Remy Maucherat --- The property is no longer used in Tomcat 9 and has been removed in that new Tomcat 10 branch. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57830] Add support for ProxyProtocol
https://bz.apache.org/bugzilla/show_bug.cgi?id=57830 --- Comment #23 from Mark Thomas --- (In reply to Tim from comment #22) > Mark Thomas: Why do you object to the optional config? Because it is insecure. It is for this reason that the PROXY spec explicitly states that "The receiver ... MUST not try to guess whether the protocol header is present or not." Looking at a diff against the 8.5.23, I'm also wondering if the implementation has been made at the right point. That the broadly the same implementation would need to be repeated across multiple connectors suggests it should be better implemented further up the stack. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.1.0-M2
On 26/06/2021 00:06, Mark Thomas wrote: [X] Alpha - go ahead and release as 10.1.0-M2 (alpha) Tested on fedora34. -- Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65408] tomcat8.5.X occurs an AssertionError occationally after running for a period of time
https://bz.apache.org/bugzilla/show_bug.cgi?id=65408 --- Comment #2 from Mark Thomas --- Looks like the MappingData fields need to be either final or volatile. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat-connectors] branch main updated (6e5a5ec -> e719874)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git. from 6e5a5ec Update after rename of branch to main new 6ec3c8c Additional ignore new e719874 Fix BZ 64878 - Fix build in MaxOS The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: native/.gitignore | 1 + native/scripts/build/jk_common.m4 | 1 + xdocs/miscellaneous/changelog.xml | 6 ++ 3 files changed, 8 insertions(+) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat-connectors] 02/02: Fix BZ 64878 - Fix build in MaxOS
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git commit e719874b21a526cb3447c747b9901719cf46eafe Author: Mark Thomas AuthorDate: Wed Jun 30 10:58:58 2021 +0100 Fix BZ 64878 - Fix build in MaxOS With thanks to d...@isle.plus at https://bz.apache.org/bugzilla/show_bug.cgi?id=64753#c13 https://bz.apache.org/bugzilla/show_bug.cgi?id=64878 --- native/scripts/build/jk_common.m4 | 1 + xdocs/miscellaneous/changelog.xml | 6 ++ 2 files changed, 7 insertions(+) diff --git a/native/scripts/build/jk_common.m4 b/native/scripts/build/jk_common.m4 index c39792a..201bd42 100644 --- a/native/scripts/build/jk_common.m4 +++ b/native/scripts/build/jk_common.m4 @@ -35,6 +35,7 @@ changequote([, ])dnl AC_MSG_CHECKING(size of $2) AC_CACHE_VAL(AC_CV_NAME, [AC_TRY_RUN([#include +#include $1 main() { diff --git a/xdocs/miscellaneous/changelog.xml b/xdocs/miscellaneous/changelog.xml index 0b7d834..e2980f3 100644 --- a/xdocs/miscellaneous/changelog.xml +++ b/xdocs/miscellaneous/changelog.xml @@ -41,6 +41,12 @@ + + + 64878: Common: Enable configure to find the correct sizes for + pid_t and pthread_t when building on MacOS. (markt) + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat-connectors] 01/02: Additional ignore
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-connectors.git commit 6ec3c8c205b9712ac4c10db0656b7f2b6824217a Author: Mark Thomas AuthorDate: Wed Jun 30 10:45:11 2021 +0100 Additional ignore --- native/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/native/.gitignore b/native/.gitignore index 850aacf..d1a6353 100644 --- a/native/.gitignore +++ b/native/.gitignore @@ -1,3 +1,4 @@ +Makefile Makefile.in aclocal.m4 configure - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64878] Can not determine the proper size for pid_t / pthread_t
https://bz.apache.org/bugzilla/show_bug.cgi?id=64878 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Mark Thomas --- Fix for 1.2.49 onwards. https://github.com/apache/tomcat-connectors/commit/e71987 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.1.0-M2
On 25/06/2021 23:06, Mark Thomas wrote: The proposed 10.1.0-M2 release is: [ ] Broken - do not release [X] Alpha - go ahead and release as 10.1.0-M2 (alpha) Unit tests pass for NIO, NIO2 and APR/Native (1.2.30) on Windows, Linux and MacOS. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.0.8
On 26/06/2021 00:26, Mark Thomas wrote: The proposed 10.0.8 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 10.0.8 (stable) Unit tests pass for NIO, NIO2 and APR/Native (1.2.30) on Windows, Linux and MacOS. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65409] failed to set property [acceptorThreadCount] to [2]
https://bz.apache.org/bugzilla/show_bug.cgi?id=65409 --- Comment #2 from qeepcologne --- thanks for the quick answer, then please add to the tomcat10 migration guide -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65410] New: TestXxxEndpoint testUnixDomainSocket fails with an Error on Windows 10, should be skipped
https://bz.apache.org/bugzilla/show_bug.cgi?id=65410 Bug ID: 65410 Summary: TestXxxEndpoint testUnixDomainSocket fails with an Error on Windows 10, should be skipped Product: Tomcat 9 Version: unspecified Hardware: PC Status: NEW Severity: minor Priority: P2 Component: Connectors Assignee: dev@tomcat.apache.org Reporter: knst.koli...@gmail.com Target Milestone: - Testing release candidate of Tomcat 9.0.50, when running with Java 16 on Windows 10, the following test fails with NIO connector: org.apache.tomcat.util.net.TestXxxEndpoint#testUnixDomainSocket Notes: 1. This test is skipped when running with version of Java earlier than java 16. This test is skipped for any connector implementation besides NIO. 2. I think this failure is expected on Windows, so there is one more condition to check before skipping the test. 3. I wonder, why this feature is not implemented for NIO2 connector. - It is implemented for NIO. (via original PR, since 9.0.42) - It is implemented for APR. (via bug 64943, since 9.0.47) Searching through the source code, "unixDomainSocketPath" properties are implemented in - AprEndpoint, - NioEndpoint. 4. Missing docs: "unixDomainSocketPath", "unixDomainSocketPathPermissions" attributes are documented for the Nio connector only. They are not documented for the APR connector. https://tomcat.apache.org/tomcat-9.0-doc/config/http.html 5. I wonder, why this test is skipped for an APR connector, if it implements the feature. The Error with the test looks like the following (Tomcat 9.0.50, OpenJDK 16.0.1): [[[ Testsuite: org.apache.tomcat.util.net.TestXxxEndpoint Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2,621 sec - Standard Error - 30-Jun-2021 00:28:34.827 INFO [main] org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case [testUnixDomainSocket] 30-Jun-2021 00:28:35.323 INFO [main] org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler ["http-nio-/tmp/testUnixDomainSocket"] 30-Jun-2021 00:28:35.355 SEVERE [main] org.apache.catalina.util.LifecycleBase.handleSubClassException Failed to initialize component [Connector[HTTP/1.1-/tmp/testUnixDomainSocket]] org.apache.catalina.LifecycleException: Protocol handler initialization failed at org.apache.catalina.connector.Connector.initInternal(Connector.java:1049) at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:136) at org.apache.catalina.core.StandardService.initInternal(StandardService.java:561) at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:136) at org.apache.catalina.core.StandardServer.initInternal(StandardServer.java:1049) at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:136) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:173) at org.apache.catalina.startup.Tomcat.start(Tomcat.java:486) at org.apache.catalina.startup.TomcatBaseTest$TomcatWithFastSessionIDs.start(TomcatBaseTest.java:878) at org.apache.tomcat.util.net.TestXxxEndpoint.testUnixDomainSocket(TestXxxEndpoint.java:209) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:567) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.
Re: [VOTE] Release Apache Tomcat 9.0.50
On Mon, Jun 28, 2021 at 11:57 AM Rémy Maucherat wrote: > The proposed Apache Tomcat 9.0.50 release is now available for voting. > > The notable changes compared to 9.0.50 are: > > - Re-work the HTTP/2 overhead protection to reduce the likelihood of >false positives. Note that the default overheadCountFactor has changed >from 1 to 10 and that the useful range is now 0 to ~20. > > - Update to Eclipse JDT compiler 4.20. > > - Fix regressions in JSP compilation in the previous release. > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat-9.0.x/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.50/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1321 > The tag is: > https://github.com/apache/tomcat/tree/9.0.50 > 06572792aa5424b5995c91edcc1e3fca4cc89bc1 > > The proposed 9.0.50 release is: > [ ] Broken - do not release > [ X ] Stable - go ahead and release as 9.0.50 (stable) > Regards, Martin > > Remy > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 8.5.69
Hi, On Wed, Jun 30, 2021 at 11:54 AM Rémy Maucherat wrote: > On Wed, Jun 30, 2021 at 7:45 AM Konstantin Kolinko > wrote: > > > > ср, 30 июн. 2021 г. в 00:03, Christopher Schultz < > ch...@christopherschultz.net>: > > > > > > [...] > > > > > > It can be obtained from: > > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/ > > > > > > The Maven staging repo is: > > > > https://repository.apache.org/content/repositories/orgapachetomcat-1322/ > > > > The Maven repository responds with 404: > > > > Repository "orgapachetomcat-1322 (staging: open)" > > [id=orgapachetomcat-1322] exists but is not exposed. > > I tried closing it but this failed as the artefacts are not signed. So > this will have to be dropped and rebuilt. > One more issue: $ tar zxvf apache-tomcat-8.5.69.tar.gz apache-tomcat-8.5.69/conf/ apache-tomcat-8.5.69/conf/catalina.policy tar: apache-tomcat-8.5.69/conf/catalina.policy: time stamp 2021-06-30 21:00:00 is 27213.161195036 s in the future apache-tomcat-8.5.69/conf/catalina.properties tar: apache-tomcat-8.5.69/conf/catalina.properties: time stamp 2021-06-30 21:00:00 is 27213.160612259 s in the future apache-tomcat-8.5.69/conf/context.xml tar: apache-tomcat-8.5.69/conf/context.xml: time stamp 2021-06-30 21:00:00 is 27213.160310352 s in the future apache-tomcat-8.5.69/conf/jaspic-providers.xml tar: apache-tomcat-8.5.69/conf/jaspic-providers.xml: time stamp 2021-06-30 21:00:00 is 27213.159964308 s in the future apache-tomcat-8.5.69/conf/jaspic-providers.xsd . > > Rémy > > > > > Best regards, > > Konstantin Kolinko > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
[Bug 65407] Generator breaks for jsp:Attributes when the content contains other tags such as c:if
https://bz.apache.org/bugzilla/show_bug.cgi?id=65407 --- Comment #2 from Konstantin Kolinko --- I failed to reproduce your error with Tomcat 9.0.48, based on your description. Thus I cannot verify whether the issue has already been fixed or not. The examples web application has a similar jsp page: http://localhost:8080/examples/jsp/jsp2/tagfiles/products.jsp Source code: - webapps/examples/WEB-INF/tags/displayProducts.tag A tag that uses <%@ attribute name="..." fragment="true" %> - webapps/examples/jsp/jsp2/tagfiles/products.jsp The page. A difference is that the page from the examples does not use nested tags. I tried to modify the page, adding taglib declaration <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"; %> and nested tags, as in your example, but the page still works successfully for me with Tomcat 9.0.48, as well as with 9.0.50. Please: 1. Retest with Tomcat 9.0.50 - release candidate builds are available, see "[VOTE]" thread on the dev mailing list. 2. Provide a simple sample web application that reproduces the issue. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.0.8
On Sat, Jun 26, 2021 at 2:27 AM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.8 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* > > Applications that run on Tomcat 9 will not run on Tomcat 10 without > changes. Java EE applications designed for Tomcat 9 and earlier may be > placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will > automatically convert them to Jakarta EE and copy them to the webapps > directory > > The notable changes compared to 10.0.7 are: > > - Re-work the HTTP/2 overhead protection to reduce the likelihood of >false positives. Note that the default overheadCountFactor has changed >from 1 to 10 and that the useful range is now 0 to ~20. > > - Update to Eclipse JDT compiler 4.20. > > - Fix regressions in JSP compilation in the previous release. > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat-10.0.x/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.8/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1319 > > The tag is: > https://github.com/apache/tomcat/tree/10.0.8 > 64520a63e23437b4e92db42bfc70a20d1f9e79c4 > > The proposed 10.0.8 release is: > [ ] Broken - do not release > [ X ] Stable - go ahead and release as 10.0.8 (stable) > Regards, Martin > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 10.1.0-M2
On Sat, Jun 26, 2021 at 1:07 AM Mark Thomas wrote: > The proposed Apache Tomcat 10.1.0-M2 release is now available for > voting. > > Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 > without changes. Java EE applications designed for Tomcat 9 and earlier > may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat > will automatically convert them to Jakarta EE and copy them to the > webapps directory. > > The notable changes compared to 10.1.0-M1 are: > > - Re-work the HTTP/2 overhead protection to reduce the likelihood of >false positives. Note that the default overheadCountFactor has changed >from 1 to 10 and that the useful range is now 0 to ~20. > > - Update to Eclipse JDT compiler 4.20. > > - Fix regressions in JSP compilation in the previous release. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat-10.1.x/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M2/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1318 > > The tag is: > https://github.com/apache/tomcat/tree/10.1.0-M2 > 0e59fedb28df646930c5aff945159b64d7a52260 > > The proposed 10.1.0-M2 release is: > [ ] Broken - do not release > [ X ] Alpha - go ahead and release as 10.1.0-M2 (alpha) > Regards, Martin > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 9.0.50
пн, 28 июн. 2021 г. в 11:57, Rémy Maucherat : > > The proposed Apache Tomcat 9.0.50 release is now available for voting. > > > The proposed 9.0.50 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 9.0.50 (stable) Tested on Windows 10. Smoke tests OK. (exe installer with Java 8, examples) Tests OK (AdoptOpenJDK 8u292. AdoptOpenJDK 11.0.11, OpenJDK 16.0.1), except one failure with 16.0.1. The failure is expected, as the test tests Unix Domain Sockets and just has not been skipped. I filed https://bz.apache.org/bugzilla/show_bug.cgi?id=65410 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] martin-g merged pull request #429: Typo
martin-g merged pull request #429: URL: https://github.com/apache/tomcat/pull/429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Fix typo in method's javadoc (#429)
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 40920f6 Fix typo in method's javadoc (#429) 40920f6 is described below commit 40920f6522f3f390a503738dd943a1a5be5b96b2 Author: Shi.Kun <34267068+pachul...@users.noreply.github.com> AuthorDate: Wed Jun 30 19:06:59 2021 +0800 Fix typo in method's javadoc (#429) s/contain/container/ --- java/jakarta/servlet/ServletOutputStream.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/jakarta/servlet/ServletOutputStream.java b/java/jakarta/servlet/ServletOutputStream.java index d788b08..86a57c6 100644 --- a/java/jakarta/servlet/ServletOutputStream.java +++ b/java/jakarta/servlet/ServletOutputStream.java @@ -282,7 +282,7 @@ public abstract class ServletOutputStream extends OutputStream { * false, it will cause a callback to * {@link WriteListener#onWritePossible()} when the buffer has emptied. If * this method returns false no further data must be written - * until the contain calls {@link WriteListener#onWritePossible()}. + * until the container calls {@link WriteListener#onWritePossible()}. * * @return true if data can be written, else false * - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.0.x updated: Fix typo in method's javadoc (#429)
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 7ccef09 Fix typo in method's javadoc (#429) 7ccef09 is described below commit 7ccef0989324f3428d3ce6d6edabf18d43e6f0c0 Author: Shi.Kun <34267068+pachul...@users.noreply.github.com> AuthorDate: Wed Jun 30 19:06:59 2021 +0800 Fix typo in method's javadoc (#429) s/contain/container/ (cherry picked from commit 40920f6522f3f390a503738dd943a1a5be5b96b2) --- java/jakarta/servlet/ServletOutputStream.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/jakarta/servlet/ServletOutputStream.java b/java/jakarta/servlet/ServletOutputStream.java index d788b08..86a57c6 100644 --- a/java/jakarta/servlet/ServletOutputStream.java +++ b/java/jakarta/servlet/ServletOutputStream.java @@ -282,7 +282,7 @@ public abstract class ServletOutputStream extends OutputStream { * false, it will cause a callback to * {@link WriteListener#onWritePossible()} when the buffer has emptied. If * this method returns false no further data must be written - * until the contain calls {@link WriteListener#onWritePossible()}. + * until the container calls {@link WriteListener#onWritePossible()}. * * @return true if data can be written, else false * - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix typo in method's javadoc (#429)
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 26d5fe4 Fix typo in method's javadoc (#429) 26d5fe4 is described below commit 26d5fe47268dccbc35a62844a5fbe2f0167fef8f Author: Shi.Kun <34267068+pachul...@users.noreply.github.com> AuthorDate: Wed Jun 30 19:06:59 2021 +0800 Fix typo in method's javadoc (#429) s/contain/container/ (cherry picked from commit 40920f6522f3f390a503738dd943a1a5be5b96b2) --- java/javax/servlet/ServletOutputStream.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/javax/servlet/ServletOutputStream.java b/java/javax/servlet/ServletOutputStream.java index bf40d97..7cc1d38 100644 --- a/java/javax/servlet/ServletOutputStream.java +++ b/java/javax/servlet/ServletOutputStream.java @@ -282,7 +282,7 @@ public abstract class ServletOutputStream extends OutputStream { * false, it will cause a callback to * {@link WriteListener#onWritePossible()} when the buffer has emptied. If * this method returns false no further data must be written - * until the contain calls {@link WriteListener#onWritePossible()}. + * until the container calls {@link WriteListener#onWritePossible()}. * * @return true if data can be written, else false * - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Fix typo in method's javadoc (#429)
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new bcee3ac Fix typo in method's javadoc (#429) bcee3ac is described below commit bcee3ac19a6b4d41fc343db175cf0abb4b0ac3fc Author: Shi.Kun <34267068+pachul...@users.noreply.github.com> AuthorDate: Wed Jun 30 19:06:59 2021 +0800 Fix typo in method's javadoc (#429) s/contain/container/ (cherry picked from commit 40920f6522f3f390a503738dd943a1a5be5b96b2) --- java/javax/servlet/ServletOutputStream.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/javax/servlet/ServletOutputStream.java b/java/javax/servlet/ServletOutputStream.java index bf40d97..7cc1d38 100644 --- a/java/javax/servlet/ServletOutputStream.java +++ b/java/javax/servlet/ServletOutputStream.java @@ -282,7 +282,7 @@ public abstract class ServletOutputStream extends OutputStream { * false, it will cause a callback to * {@link WriteListener#onWritePossible()} when the buffer has emptied. If * this method returns false no further data must be written - * until the contain calls {@link WriteListener#onWritePossible()}. + * until the container calls {@link WriteListener#onWritePossible()}. * * @return true if data can be written, else false * - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.0.8
On Fri, Jun 25, 2021 at 7:27 PM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.8 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* > > Applications that run on Tomcat 9 will not run on Tomcat 10 without > changes. Java EE applications designed for Tomcat 9 and earlier may be > placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will > automatically convert them to Jakarta EE and copy them to the webapps > directory > > The notable changes compared to 10.0.7 are: > > - Re-work the HTTP/2 overhead protection to reduce the likelihood of >false positives. Note that the default overheadCountFactor has changed >from 1 to 10 and that the useful range is now 0 to ~20. > > - Update to Eclipse JDT compiler 4.20. > > - Fix regressions in JSP compilation in the previous release. > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat-10.0.x/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.8/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1319 > > The tag is: > https://github.com/apache/tomcat/tree/10.0.8 > 64520a63e23437b4e92db42bfc70a20d1f9e79c4 > > The proposed 10.0.8 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 10.0.8 (stable) > +1 > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 9.0.50
On Mon, Jun 28, 2021 at 4:57 AM Rémy Maucherat wrote: > The proposed Apache Tomcat 9.0.50 release is now available for voting. > > The notable changes compared to 9.0.50 are: > > - Re-work the HTTP/2 overhead protection to reduce the likelihood of >false positives. Note that the default overheadCountFactor has changed >from 1 to 10 and that the useful range is now 0 to ~20. > > - Update to Eclipse JDT compiler 4.20. > > - Fix regressions in JSP compilation in the previous release. > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat-9.0.x/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.50/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1321 > The tag is: > https://github.com/apache/tomcat/tree/9.0.50 > 06572792aa5424b5995c91edcc1e3fca4cc89bc1 > > The proposed 9.0.50 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 9.0.50 (stable) > +1, LGTM > Remy > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
[GitHub] [tomcat] oole opened a new pull request #430: Fix locked up connection for NamingException.
oole opened a new pull request #430: URL: https://github.com/apache/tomcat/pull/430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65411] New: NamingException in JDNIRealm.getPrincipal(String username, GSSCredential gssCredential) ends in locked-up realm
https://bz.apache.org/bugzilla/show_bug.cgi?id=65411 Bug ID: 65411 Summary: NamingException in JDNIRealm.getPrincipal(String username, GSSCredential gssCredential) ends in locked-up realm Product: Tomcat 9 Version: 9.0.39 Hardware: All OS: All Status: NEW Severity: regression Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: ole.osterga...@knime.com Target Milestone: - A NamingException during JDNIRealm.getPrincipal(String username, GSSCredential gssCredential) leads to a locked up realm. Which leads to tomcat locking up. Similar to the fix for Bug 65033 (https://bz.apache.org/bugzilla/show_bug.cgi?id=65033), the second catching of the NamingException should also close the connection and unlock the singleConnectionLock. It seems that the connection used to be closed, but with 9.0.39 and this commit https://github.com/apache/tomcat/commit/95658dfd868216db0773c38aad8eebf544024b09?branch=95658dfd868216db0773c38aad8eebf544024b09 the close(connection) is not called anymore. Corresponding PR: https://github.com/apache/tomcat/pull/430 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65410] TestXxxEndpoint testUnixDomainSocket fails with an Error on Windows 10, should be skipped
https://bz.apache.org/bugzilla/show_bug.cgi?id=65410 Remy Maucherat changed: What|Removed |Added OS||All --- Comment #1 from Remy Maucherat --- This is not so simple. UDS is supposed to be supported on Windows by the JVM, but the support might be partial. So not sure what's going on. The trace and the "Network is down" does seem to me the JVM is trying but a needed subsystem is not enabled (??). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.50
On 28/06/2021 09:56, Rémy Maucherat wrote: The proposed 9.0.50 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 9.0.50 (stable) Unit tests pass for NIO, NIO2 and APR/Native (1.2.30) on Windows, Linux and MacOS. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
Konstantin, On 6/30/21 01:44, Konstantin Kolinko wrote: ср, 30 июн. 2021 г. в 00:03, Christopher Schultz : [...] It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1322/ The Maven repository responds with 404: Repository "orgapachetomcat-1322 (staging: open)" [id=orgapachetomcat-1322] exists but is not exposed. Thanks for the report. I forgot to "close" that repo, so it's giving that error. Before I close it, I'm going to try to figure out why some files in there are not signed. Please standby. -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65411] NamingException in JDNIRealm.getPrincipal(String username, GSSCredential gssCredential) ends in locked-up realm
https://bz.apache.org/bugzilla/show_bug.cgi?id=65411 --- Comment #1 from Remy Maucherat --- Well, that was quite intentional, since the regular NamingException is nearly always when connecting, so no connection to close (it will be null). Can you give the full stack trace ? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65411] NamingException in JDNIRealm.getPrincipal(String username, GSSCredential gssCredential) ends in locked-up realm
https://bz.apache.org/bugzilla/show_bug.cgi?id=65411 --- Comment #2 from Ole Ostergaard --- That is true, but the lock still does not get released. This is the stack trace that is causing the lock (Tomcat 9.0.45): 30-Jun-2021 03:45:35.211 SEVERE [https-jsse-nio2-8443-exec-154] org.apache.catalina.realm.JNDIRealm.getPrincipal Exception performing authentication javax.naming.NamingException: LDAP response read timed out, timeout used: 5000 ms.; remaining name 'ou=people, dc=knime, dc=com' at com.sun.jndi.ldap.LdapRequest.getReplyBer(LdapRequest.java:129) at com.sun.jndi.ldap.Connection.readReply(Connection.java:469) at com.sun.jndi.ldap.LdapClient.getSearchReply(LdapClient.java:638) at com.sun.jndi.ldap.LdapClient.search(LdapClient.java:561) at com.sun.jndi.ldap.LdapCtx.doSearch(LdapCtx.java:2013) at com.sun.jndi.ldap.LdapCtx.searchAux(LdapCtx.java:1872) at com.sun.jndi.ldap.LdapCtx.c_search(LdapCtx.java:1797) at com.sun.jndi.toolkit.ctx.ComponentDirContext.p_search(ComponentDirContext.java:392) at com.sun.jndi.toolkit.ctx.PartialCompositeDirContext.search(PartialCompositeDirContext.java:358) at com.sun.jndi.toolkit.ctx.PartialCompositeDirContext.search(PartialCompositeDirContext.java:341) at javax.naming.directory.InitialDirContext.search(InitialDirContext.java:267) at org.apache.catalina.realm.JNDIRealm.getUserBySearch(JNDIRealm.java:1698) at org.apache.catalina.realm.JNDIRealm.getUser(JNDIRealm.java:1535) at org.apache.catalina.realm.JNDIRealm.getUser(JNDIRealm.java:1463) at org.apache.catalina.realm.JNDIRealm.getPrincipal(JNDIRealm.java:2418) at org.apache.catalina.realm.JNDIRealm.getPrincipal(JNDIRealm.java:2347) at org.apache.catalina.realm.JNDIRealm.getPrincipal(JNDIRealm.java:2311) at org.apache.catalina.realm.RealmBase.authenticate(RealmBase.java:312) at org.apache.catalina.realm.CombinedRealm.authenticate(CombinedRealm.java:154) ... And this is the JStack that we took when we realised something was off (~150 waiting threads, and no thread that holds the lock as far as we can see)): "https-jsse-nio2-8443-exec-326" #7207 daemon prio=5 os_prio=0 tid=0x7fa9bc139800 nid=0x630d waiting on condition [0x7fa93003f000] java.lang.Thread.State: WAITING (parking) at sun.misc.Unsafe.park(Native Method) - parking to wait for <0x0004401dd5a8> (a java.util.concurrent.locks.ReentrantLock$NonfairSync) at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175) at java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870) at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199) at java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:209) at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285) at org.apache.catalina.realm.JNDIRealm.get(JNDIRealm.java:2469) at org.apache.catalina.realm.JNDIRealm.authenticate(JNDIRealm.java:1302) at org.apache.catalina.realm.CombinedRealm.authenticate(CombinedRealm.java:191) at org.apache.catalina.realm.LockOutRealm.authenticate(LockOutRealm.java:154) at org.apache.catalina.authenticator.BasicAuthenticator.doAuthenticate(BasicAuthenticator.java:101) at org.apache.catalina.authenticator.AuthenticatorBase.authenticate(AuthenticatorBase.java:740) ... The get() in getPrincipal(String username, GSSCredential gssCredential) sets the singleConnectionLock.lock(), which never gets unlocked. (https://github.com/apache/tomcat/blob/main/java/org/apache/catalina/realm/JNDIRealm.java#L2280) The close(connection), not only closes the connection, but also unlocks the lock (singleConnectionLock.unlock()). (https://github.com/apache/tomcat/blob/main/java/org/apache/catalina/realm/JNDIRealm.java#L2143-L2148) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Possible code clean-up
All, I wanted to get some feedback on a possible code clean-up. Currently, we declare literal arrays like this: String[] array = new String[] { "value1", "value2", "value3" ); We could simplify these declarations to: String[] array = { "value1", "value2", "value3" ); There doesn't appear to be a checkstyle rule to enforce one approach or the other. Assuming someone is willing to spend the time to make these changes what do the folks here think? I think the code is a little cleaner and therefore easier to read but the benefit seems minimal. I'm not sure it is worth "fixing" the existing code. We could use this going forward as the opportunity arises. The inconsistency in style bugs me a little - but not so much I couldn't live with it. Thoughts? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Always close the connection when an uncaught NamingException occurs
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a533203 Always close the connection when an uncaught NamingException occurs a533203 is described below commit a53320349d2510af657cf0d3581bc56173b5efc4 Author: remm AuthorDate: Wed Jun 30 14:57:40 2021 +0200 Always close the connection when an uncaught NamingException occurs 65411: Avoids possible connection locking. And this is safer anyway. Submitted by Ole Ostergaard. --- java/org/apache/catalina/realm/JNDIRealm.java | 4 webapps/docs/changelog.xml| 9 + 2 files changed, 13 insertions(+) diff --git a/java/org/apache/catalina/realm/JNDIRealm.java b/java/org/apache/catalina/realm/JNDIRealm.java index ed5b4bd..6e2a305 100644 --- a/java/org/apache/catalina/realm/JNDIRealm.java +++ b/java/org/apache/catalina/realm/JNDIRealm.java @@ -2311,6 +2311,10 @@ public class JNDIRealm extends RealmBase { // Log the problem for posterity containerLog.error(sm.getString("jndiRealm.exception"), e); +// close the connection so we know it will be reopened. +close(connection); +closePooledConnections(); + // Return "not authenticated" for this request return null; } diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 3d75a8e..dce18b3 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -105,6 +105,15 @@ issues do not "pop up" wrt. others). --> + + + +65411: Always close the connection when an uncaught +NamingException occurs to avoid connection locking. +Submitted by Ole Ostergaard. (remm) + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.0.x updated: Always close the connection when an uncaught NamingException occurs
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 6afd1bd Always close the connection when an uncaught NamingException occurs 6afd1bd is described below commit 6afd1bdcc14fc88dc00a53fbcfbcec2e443cef5b Author: remm AuthorDate: Wed Jun 30 14:57:40 2021 +0200 Always close the connection when an uncaught NamingException occurs 65411: Avoids possible connection locking. And this is safer anyway. Submitted by Ole Ostergaard. --- java/org/apache/catalina/realm/JNDIRealm.java | 4 webapps/docs/changelog.xml| 9 + 2 files changed, 13 insertions(+) diff --git a/java/org/apache/catalina/realm/JNDIRealm.java b/java/org/apache/catalina/realm/JNDIRealm.java index 89564ea..7f71dbd 100644 --- a/java/org/apache/catalina/realm/JNDIRealm.java +++ b/java/org/apache/catalina/realm/JNDIRealm.java @@ -2311,6 +2311,10 @@ public class JNDIRealm extends RealmBase { // Log the problem for posterity containerLog.error(sm.getString("jndiRealm.exception"), e); +// close the connection so we know it will be reopened. +close(connection); +closePooledConnections(); + // Return "not authenticated" for this request return null; } diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index cbb302c..48e95c8 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -105,6 +105,15 @@ issues do not "pop up" wrt. others). --> + + + +65411: Always close the connection when an uncaught +NamingException occurs to avoid connection locking. +Submitted by Ole Ostergaard. (remm) + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Always close the connection when an uncaught NamingException occurs
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new a695dc3 Always close the connection when an uncaught NamingException occurs a695dc3 is described below commit a695dc3b549e5643b1afe15c1c3d663bedeeb4ad Author: remm AuthorDate: Wed Jun 30 14:57:40 2021 +0200 Always close the connection when an uncaught NamingException occurs 65411: Avoids possible connection locking. And this is safer anyway. Submitted by Ole Ostergaard. --- java/org/apache/catalina/realm/JNDIRealm.java | 4 webapps/docs/changelog.xml| 9 + 2 files changed, 13 insertions(+) diff --git a/java/org/apache/catalina/realm/JNDIRealm.java b/java/org/apache/catalina/realm/JNDIRealm.java index 7f72ae3..dd43c0c 100644 --- a/java/org/apache/catalina/realm/JNDIRealm.java +++ b/java/org/apache/catalina/realm/JNDIRealm.java @@ -2312,6 +2312,10 @@ public class JNDIRealm extends RealmBase { // Log the problem for posterity containerLog.error(sm.getString("jndiRealm.exception"), e); +// close the connection so we know it will be reopened. +close(connection); +closePooledConnections(); + // Return "not authenticated" for this request return null; } diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 5102b40..9c19ee9 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -105,6 +105,15 @@ issues do not "pop up" wrt. others). --> + + + +65411: Always close the connection when an uncaught +NamingException occurs to avoid connection locking. +Submitted by Ole Ostergaard. (remm) + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Possible code clean-up
On Wed, Jun 30, 2021 at 3:51 PM Mark Thomas wrote: > All, > > I wanted to get some feedback on a possible code clean-up. Currently, we > declare literal arrays like this: > > String[] array = new String[] { "value1", "value2", "value3" ); > > We could simplify these declarations to: > > String[] array = { "value1", "value2", "value3" ); > > There doesn't appear to be a checkstyle rule to enforce one approach or > the other. > > Assuming someone is willing to spend the time to make these changes what > do the folks here think? > > I think the code is a little cleaner and therefore easier to read but > the benefit seems minimal. I'm not sure it is worth "fixing" the > existing code. > > We could use this going forward as the opportunity arises. The > inconsistency in style bugs me a little - but not so much I couldn't > live with it. > > Thoughts? > +1 to simplify ! > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
[tomcat] branch 8.5.x updated: Increment version
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 3a6c6be Increment version 3a6c6be is described below commit 3a6c6bea56a69b68efa7c63bcfde20b8b90529bf Author: remm AuthorDate: Wed Jun 30 15:17:07 2021 +0200 Increment version --- build.properties.default | 2 +- res/maven/mvn.properties.default | 2 +- webapps/docs/changelog.xml | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/build.properties.default b/build.properties.default index 6dda35e..101f496 100644 --- a/build.properties.default +++ b/build.properties.default @@ -25,7 +25,7 @@ # - Version Control Flags - version.major=8 version.minor=5 -version.build=69 +version.build=70 version.patch=0 version.suffix=-dev diff --git a/res/maven/mvn.properties.default b/res/maven/mvn.properties.default index 1b6069c..598c933 100644 --- a/res/maven/mvn.properties.default +++ b/res/maven/mvn.properties.default @@ -39,7 +39,7 @@ maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/d maven.asf.release.repo.repositoryId=apache.releases.https # Release version info -maven.asf.release.deploy.version=8.5.69 +maven.asf.release.deploy.version=8.5.70 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 9b9aeef..00ea428 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -104,7 +104,9 @@ They eventually become mixed with the numbered issues (i.e., numbered issues do not "pop up" wrt. others). --> - + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Always close the connection when an uncaught NamingException occurs
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 3fb49e1 Always close the connection when an uncaught NamingException occurs 3fb49e1 is described below commit 3fb49e1bf771399638bbe2b47ce82584ca87a414 Author: remm AuthorDate: Wed Jun 30 14:57:40 2021 +0200 Always close the connection when an uncaught NamingException occurs 65411: Avoids possible connection locking. And this is safer anyway. Submitted by Ole Ostergaard. --- java/org/apache/catalina/realm/JNDIRealm.java | 4 webapps/docs/changelog.xml| 9 + 2 files changed, 13 insertions(+) diff --git a/java/org/apache/catalina/realm/JNDIRealm.java b/java/org/apache/catalina/realm/JNDIRealm.java index cbef335..b0e75a5 100644 --- a/java/org/apache/catalina/realm/JNDIRealm.java +++ b/java/org/apache/catalina/realm/JNDIRealm.java @@ -2327,6 +2327,10 @@ public class JNDIRealm extends RealmBase { // Log the problem for posterity containerLog.error(sm.getString("jndiRealm.exception"), e); +// close the connection so we know it will be reopened. +close(connection); +closePooledConnections(); + // Return "not authenticated" for this request return null; } diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 00ea428..ad85d11 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -105,6 +105,15 @@ issues do not "pop up" wrt. others). --> + + + +65411: Always close the connection when an uncaught +NamingException occurs to avoid connection locking. +Submitted by Ole Ostergaard. (remm) + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65411] NamingException in JDNIRealm.getPrincipal(String username, GSSCredential gssCredential) ends in locked-up realm
https://bz.apache.org/bugzilla/show_bug.cgi?id=65411 Remy Maucherat changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Remy Maucherat --- Given the trace it is completely reasonable. This will be in 10.1.0-M3, 10.0.9, 9.0.51, 8.5.70. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #430: Fix locked up connection for NamingException.
rmaucher commented on pull request #430: URL: https://github.com/apache/tomcat/pull/430#issuecomment-871405290 Thanks for the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rmaucher closed pull request #430: Fix locked up connection for NamingException.
rmaucher closed pull request #430: URL: https://github.com/apache/tomcat/pull/430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
All, I believe I have resolved the issue with the Maven repository. Apologies for the hiccup. Thanks, -chris On 6/30/21 08:14, Christopher Schultz wrote: Konstantin, On 6/30/21 01:44, Konstantin Kolinko wrote: ср, 30 июн. 2021 г. в 00:03, Christopher Schultz : [...] It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1322/ The Maven repository responds with 404: Repository "orgapachetomcat-1322 (staging: open)" [id=orgapachetomcat-1322] exists but is not exposed. Thanks for the report. I forgot to "close" that repo, so it's giving that error. Before I close it, I'm going to try to figure out why some files in there are not signed. Please standby. -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: certificateVerification="optionalNoCA" and OCSP validation.
On 29/06/2021 18:22, Mark Thomas wrote: On 29/06/2021 15:19, jean-frederic clere wrote: On 29/06/2021 14:45, Mark Thomas wrote: On 29/06/2021 12:29, jean-frederic clere wrote: Hi, It seems certificateVerification="optionalNoCA" only works if the OCSP is disabled. In Otherwise the OCSP check forces an error because it can't check anything... How to "fix" that? Just document it? or return OK where we test SSL_CVERIFY_OPTIONAL_NO_CA (https://github.com/apache/tomcat-native/blob/main/native/src/sslutils.c#L337)? Hmm. My expectation is that: - certificate provided results in OCSP for that cert and the connection fails if the check fails. certificateVerification="optional" makes the client certificate optional (required by webapps if needed). certificateVerification="optionalNoCA" does the same and additionally should avoid checking the client against the CA. The OCSP checking needs to validate the client certificate against the CA otherwise it will prevent getting the connection, making NoCA like ignored... Got it. In which case I'll change my expectation to optionalNoCA == no OCSP check. We should document this. OK I will fix the code and document it. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org -- Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65410] TestXxxEndpoint testUnixDomainSocket fails with an Error on Windows 10, should be skipped
https://bz.apache.org/bugzilla/show_bug.cgi?id=65410 --- Comment #2 from Konstantin Kolinko --- I wonder whether the path matters. The test uses file path "/tmp/testUnixDomainSocket", and "/tmp/" does not exist here. BTW, as the path is not unique (not random), several parallel runs of this test may conflict with each other. (e.g. when testing different branches of Tomcat in parallel) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
On 30/06/2021 15:56, Christopher Schultz wrote: All, I believe I have resolved the issue with the Maven repository. Apologies for the hiccup. Could you call for another [VOTE] with updated links so we have a clean thread (same as Remy did for 9) Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Possible code clean-up
Mark, On 6/30/21 08:51, Mark Thomas wrote: All, I wanted to get some feedback on a possible code clean-up. Currently, we declare literal arrays like this: String[] array = new String[] { "value1", "value2", "value3" ); We could simplify these declarations to: String[] array = { "value1", "value2", "value3" ); There doesn't appear to be a checkstyle rule to enforce one approach or the other. Assuming someone is willing to spend the time to make these changes what do the folks here think? I think the code is a little cleaner and therefore easier to read but the benefit seems minimal. I'm not sure it is worth "fixing" the existing code. We could use this going forward as the opportunity arises. The inconsistency in style bugs me a little - but not so much I couldn't live with it. Thoughts? Hmm. Is there a minimum compiler version necessary to use that syntax? I've literally never seen it before. Maybe it's just always been there... -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
Mladen, On 6/30/21 11:23, Mladen Turk wrote: On 30/06/2021 15:56, Christopher Schultz wrote: All, I believe I have resolved the issue with the Maven repository. Apologies for the hiccup. Could you call for another [VOTE] with updated links so we have a clean thread (same as Remy did for 9) Same links; no changes are necessary. I could re-announce if you'd like, but the contents will be the same. -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Possible code clean-up
All, On 6/30/21 11:23, Christopher Schultz wrote: Mark, On 6/30/21 08:51, Mark Thomas wrote: All, I wanted to get some feedback on a possible code clean-up. Currently, we declare literal arrays like this: String[] array = new String[] { "value1", "value2", "value3" ); We could simplify these declarations to: String[] array = { "value1", "value2", "value3" ); There doesn't appear to be a checkstyle rule to enforce one approach or the other. Assuming someone is willing to spend the time to make these changes what do the folks here think? I think the code is a little cleaner and therefore easier to read but the benefit seems minimal. I'm not sure it is worth "fixing" the existing code. We could use this going forward as the opportunity arises. The inconsistency in style bugs me a little - but not so much I couldn't live with it. Thoughts? Hmm. Is there a minimum compiler version necessary to use that syntax? I've literally never seen it before. Maybe it's just always been there... Been there forever: http://titanium.cs.berkeley.edu/doc/java-langspec-1.0/10.doc.html#11358 +0 for me, I guess -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65410] TestXxxEndpoint testUnixDomainSocket fails with an Error on Windows 10, should be skipped
https://bz.apache.org/bugzilla/show_bug.cgi?id=65410 --- Comment #3 from Remy Maucherat --- (In reply to Konstantin Kolinko from comment #2) > I wonder whether the path matters. > > The test uses file path "/tmp/testUnixDomainSocket", and "/tmp/" does not > exist here. > > BTW, as the path is not unique (not random), several parallel runs of this > test may conflict with each other. (e.g. when testing different branches of > Tomcat in parallel) That would be a good point, this needs to be written in a more portable way. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
On 30/06/2021 17:25, Christopher Schultz wrote: Mladen, On 6/30/21 11:23, Mladen Turk wrote: On 30/06/2021 15:56, Christopher Schultz wrote: All, I believe I have resolved the issue with the Maven repository. Apologies for the hiccup. Could you call for another [VOTE] with updated links so we have a clean thread (same as Remy did for 9) Same links; no changes are necessary. I could re-announce if you'd like, but the contents will be the same. If links are the same and since there were no votes think we can use this thread as an official vote thread. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Possible code clean-up
ср, 30 июн. 2021 г. в 18:26, Christopher Schultz : > > All, > > On 6/30/21 11:23, Christopher Schultz wrote: > > Mark, > > > > On 6/30/21 08:51, Mark Thomas wrote: > >> All, > >> > >> I wanted to get some feedback on a possible code clean-up. Currently, > >> we declare literal arrays like this: > >> > >> String[] array = new String[] { "value1", "value2", "value3" ); > >> > >> We could simplify these declarations to: > >> > >> String[] array = { "value1", "value2", "value3" ); > >> > >> [...] > > > > Hmm. Is there a minimum compiler version necessary to use that syntax? > > I've literally never seen it before. Maybe it's just always been there... > > Been there forever: > http://titanium.cs.berkeley.edu/doc/java-langspec-1.0/10.doc.html#11358 I also wondered. Just tested that it works with Java 6. More examples here: https://docs.oracle.com/javase/tutorial/java/nutsandbolts/arrays.html +1 to simplify. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Portable temp path code
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new d2ef158 Portable temp path code d2ef158 is described below commit d2ef158945a4aca00dc06900c65c059cbb66c410 Author: remm AuthorDate: Wed Jun 30 17:45:20 2021 +0200 Portable temp path code --- test/org/apache/tomcat/util/net/TestXxxEndpoint.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java index 653e751..efc4dd1 100644 --- a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java +++ b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java @@ -213,7 +213,9 @@ public class TestXxxEndpoint extends TomcatBaseTest { c.getProtocolHandlerClassName().contains("NioProtocol") && JreCompat.isJre16Available()); -final String unixDomainSocketPath = "/tmp/testUnixDomainSocket"; +File tempPath = File.createTempFile("tomcat", ".uds"); +final String unixDomainSocketPath = tempPath.getAbsolutePath(); +tempPath.delete(); Assert.assertTrue(c.setProperty("unixDomainSocketPath", unixDomainSocketPath)); tomcat.start(); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.0.x updated: Portable temp path code
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 69dd781 Portable temp path code 69dd781 is described below commit 69dd78106ee53d7bc55922910991c6efb664c4ce Author: remm AuthorDate: Wed Jun 30 17:45:20 2021 +0200 Portable temp path code --- test/org/apache/tomcat/util/net/TestXxxEndpoint.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java index 653e751..efc4dd1 100644 --- a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java +++ b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java @@ -213,7 +213,9 @@ public class TestXxxEndpoint extends TomcatBaseTest { c.getProtocolHandlerClassName().contains("NioProtocol") && JreCompat.isJre16Available()); -final String unixDomainSocketPath = "/tmp/testUnixDomainSocket"; +File tempPath = File.createTempFile("tomcat", ".uds"); +final String unixDomainSocketPath = tempPath.getAbsolutePath(); +tempPath.delete(); Assert.assertTrue(c.setProperty("unixDomainSocketPath", unixDomainSocketPath)); tomcat.start(); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Portable temp path code
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f06f99c Portable temp path code f06f99c is described below commit f06f99c90f4b8dcfa8c350cc97f781bc399f84ef Author: remm AuthorDate: Wed Jun 30 17:45:20 2021 +0200 Portable temp path code --- test/org/apache/tomcat/util/net/TestXxxEndpoint.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java index b4b0a86..c094480 100644 --- a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java +++ b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java @@ -204,7 +204,9 @@ public class TestXxxEndpoint extends TomcatBaseTest { c.getProtocolHandlerClassName().contains("NioProtocol") && JreCompat.isJre16Available()); -final String unixDomainSocketPath = "/tmp/testUnixDomainSocket"; +File tempPath = File.createTempFile("tomcat", ".uds"); +final String unixDomainSocketPath = tempPath.getAbsolutePath(); +tempPath.delete(); Assert.assertTrue(c.setProperty("unixDomainSocketPath", unixDomainSocketPath)); tomcat.start(); - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in on tomcat-9.0.x
The Buildbot has detected a new failure on builder tomcat-9.0.x while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9.0.x/builds/64 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-9.0-commit' triggered this build Build Source Stamp: [branch 9.0.x] a695dc3b549e5643b1afe15c1c3d663bedeeb4ad Blamelist: remm BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat-jakartaee-migration] mohiniagrawal opened a new issue #21: facing issue while migrating the war
mohiniagrawal opened a new issue #21: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/21 I am trying to deploy a war in which there is a class extending javax.servet.ServletContextListener and overriding method contextIntialized(javax.servlet.ServletContextEvent) method. After migrating the war using the tomcat-jakartaee-migration tool, the following issue is resolved. **java.lang.NoClassDefFoundError: javax/servlet/ServletContextListener** But now it is looking for overriden method contextIntialized(jakarta.servlet.ServletContextEvent) but in actual code it is contextIntialized(javax.servlet.ServletContextEvent). So since the migration tool is in progress now, so I wanted to ask if there is a plan to handle such a scenario as well while migration or it should be handled by application developers themselves? And if there is a plan to handle such a scenario then may I know the expected timeline it is planned for? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65410] TestXxxEndpoint testUnixDomainSocket fails with an Error on Windows 10, should be skipped
https://bz.apache.org/bugzilla/show_bug.cgi?id=65410 --- Comment #4 from Konstantin Kolinko --- > commit f06f99c90f4b8dcfa8c350cc97f781bc399f84ef > AuthorDate: Wed Jun 30 17:45:20 2021 +0200 > Portable temp path code Wow. It was the path. The recent commit (cited above) fixes the issue: the test completes successfully on Windows 10. (9.0.x, Java 16.0.1) [[[ Testsuite: org.apache.tomcat.util.net.TestXxxEndpoint Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10,033 sec - Standard Error - 30-Jun-2021 19:25:48.116 INFO [main] org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case [testUnixDomainSocket] 30-Jun-2021 19:25:50.882 INFO [main] org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler ["http-nio-C:\\Users\\username-censored\\AppData\\Local\\Temp\\tomcat1743897028267623289.uds"] 30-Jun-2021 19:25:50.938 INFO [main] org.apache.catalina.core.StandardService.startInternal Starting service [Tomcat] 30-Jun-2021 19:25:50.938 INFO [main] org.apache.catalina.core.StandardEngine.startInternal Starting Servlet engine: [Apache Tomcat/9.0.38-dev] 30-Jun-2021 19:25:51.168 INFO [main] org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler ["http-nio-C:\\Users\\username-censored\\AppData\\Local\\Temp\\tomcat1743897028267623289.uds"] 30-Jun-2021 19:25:52.198 INFO [main] org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler ["http-nio-C:\\Users\\username-censored\\AppData\\Local\\Temp\\tomcat1743897028267623289.uds"] 30-Jun-2021 19:25:52.208 INFO [main] org.apache.catalina.core.StandardService.stopInternal Stopping service [Tomcat] 30-Jun-2021 19:25:52.219 INFO [main] org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler ["http-nio-C:\\Users\\username-censored\\AppData\\Local\\Temp\\tomcat1743897028267623289.uds"] 30-Jun-2021 19:25:52.255 INFO [main] org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler ["http-nio-C:\\Users\\username-censored\\AppData\\Local\\Temp\\tomcat1743897028267623289.uds"] [...] - --- Testcase: testUnixDomainSocket took 4,823 sec Testcase: testStartStopBindOnStart took 4,771 sec Testcase: testStartStopBindOnInit took 0,369 sec ]]] -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65413] New: Error in compiled jsp with forEach loop
https://bz.apache.org/bugzilla/show_bug.cgi?id=65413 Bug ID: 65413 Summary: Error in compiled jsp with forEach loop Product: Tomcat 8 Version: 8.5.68 Hardware: Macintosh Status: NEW Severity: normal Priority: P2 Component: Jasper Assignee: dev@tomcat.apache.org Reporter: neihe...@gmail.com Target Milestone: As of release 8.5.67 we've noticed that a lot of our JSP's that use a forEach loop won't compile and give us an error: n error occurred at line: [736] in the generated java file: [/Users/Patrick.Neihengen/Library/Caches/JetBrains/IntelliJIdea2021.1/tomcat/0bd8c2a6-1c0a-4d03-801e-ca9be966847a/work/Catalina/localhost/ROOT/org/apache/jsp/WEB_002dINF/pages/admin/userAdminList_jsp.java] _jspx_push_body_count_c_005fforEach_005f0 cannot be resolved to a variable Stacktrace: at org.apache.jasper.compiler.DefaultErrorHandler.javacError(DefaultErrorHandler.java:102) at org.apache.jasper.compiler.ErrorDispatcher.javacError(ErrorDispatcher.java:213) at org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:545) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:380) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:350) at org.apache.jasper.compiler.Compiler.compile(Compiler.java:334) at org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:597) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:398) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:383) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:331) at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:232) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:167) at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:194) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:167) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:113) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:194) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:167) at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:712) at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:462) at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:388) at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:316) at org.springframework.web.servlet.view.InternalResourceView.renderMergedOutputModel(InternalResourceView.java:171) at org.springframework.web.servlet.view.AbstractView.render(AbstractView.java:316) at org.springframework.web.servlet.DispatcherServlet.render(DispatcherServlet.java:1373) at org.springframework.web.servlet.DispatcherServlet.processDispatchResult(DispatcherServlet.java:1118) at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1057) at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:943) at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006) at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:898) at javax.servlet.http.HttpServlet.service(HttpServlet.java:655) at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883) at javax.servlet.http.HttpServlet.service(HttpServlet.java:764) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:232) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:167) at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:194) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:167) I've noticed this: https://bz.apache.org/bugzilla/show_bug.cgi?id=65387 but it says its
[Bug 65413] Error in compiled jsp with forEach loop
https://bz.apache.org/bugzilla/show_bug.cgi?id=65413 Patrick Neihengen changed: What|Removed |Added OS||All --- Comment #1 from Patrick Neihengen --- Suspecting it has something to do with this release note: Jasper Code: Review code used to generate Java source from JSPs and tags and remove code found to be unnecessary. (markt) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65413] Error in compiled jsp with forEach loop
https://bz.apache.org/bugzilla/show_bug.cgi?id=65413 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Mark Thomas --- *** This bug has been marked as a duplicate of bug 65390 *** -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65390] Problem in the code generated by jasper
https://bz.apache.org/bugzilla/show_bug.cgi?id=65390 Mark Thomas changed: What|Removed |Added CC||neihe...@gmail.com --- Comment #12 from Mark Thomas --- *** Bug 65413 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
On Tue, Jun 29, 2021 at 2:03 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > The proposed Apache Tomcat 8.5.69 release is now available for voting. > > > > The proposed 8.5.69 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.69 > Unit tests passed on Ubuntu 20.04 with Java 11 Igal > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
buildbot success in on tomcat-9.0.x
The Buildbot has detected a restored build on builder tomcat-9.0.x while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9.0.x/builds/65 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-9.0-commit' triggered this build Build Source Stamp: [branch 9.0.x] f06f99c90f4b8dcfa8c350cc97f781bc399f84ef Blamelist: remm Build succeeded! Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
On 29/06/2021 23:03, Christopher Schultz wrote: The proposed 8.5.69 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.69 Tested on Windows Server 2019 with OpenJDK 1.8.0 Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.50
On Mon, Jun 28, 2021 at 1:57 AM Rémy Maucherat wrote: > The proposed Apache Tomcat 9.0.50 release is now available for voting. > > > > The proposed 9.0.50 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 9.0.50 (stable) > Unit tests passed on Ubuntu 20.04 with Java 11 Igal > > Remy > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [tomcat] branch main updated: Portable temp path code
Am 2021-06-30 um 17:45 schrieb r...@apache.org: This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new d2ef158 Portable temp path code d2ef158 is described below commit d2ef158945a4aca00dc06900c65c059cbb66c410 Author: remm AuthorDate: Wed Jun 30 17:45:20 2021 +0200 Portable temp path code --- test/org/apache/tomcat/util/net/TestXxxEndpoint.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java index 653e751..efc4dd1 100644 --- a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java +++ b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java @@ -213,7 +213,9 @@ public class TestXxxEndpoint extends TomcatBaseTest { c.getProtocolHandlerClassName().contains("NioProtocol") && JreCompat.isJre16Available()); -final String unixDomainSocketPath = "/tmp/testUnixDomainSocket"; +File tempPath = File.createTempFile("tomcat", ".uds"); The common extension for UDS is actually '.sock' - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Beautify test
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new d866168 Beautify test d866168 is described below commit d8661682937a1d8f53a3830cff17d05d897e692f Author: remm AuthorDate: Wed Jun 30 22:07:55 2021 +0200 Beautify test --- test/org/apache/tomcat/util/net/TestXxxEndpoint.java | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java index efc4dd1..f270258 100644 --- a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java +++ b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java @@ -213,12 +213,14 @@ public class TestXxxEndpoint extends TomcatBaseTest { c.getProtocolHandlerClassName().contains("NioProtocol") && JreCompat.isJre16Available()); -File tempPath = File.createTempFile("tomcat", ".uds"); -final String unixDomainSocketPath = tempPath.getAbsolutePath(); -tempPath.delete(); +File tempPath = File.createTempFile("uds-tomcat-test-", ".sock"); +String unixDomainSocketPath = tempPath.getAbsolutePath(); +// Need to delete the file to make way for the actual socket +Assert.assertTrue(tempPath.delete()); Assert.assertTrue(c.setProperty("unixDomainSocketPath", unixDomainSocketPath)); tomcat.start(); +// Connect to the domain socket as a client SocketAddress sa = JreCompat.getInstance().getUnixDomainSocketAddress(unixDomainSocketPath); ByteBuffer response = ByteBuffer.allocate(1024); try (SocketChannel socket = JreCompat.getInstance().openUnixDomainSocketChannel()) { - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.0.x updated: Beautify test
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new bcb62c6 Beautify test bcb62c6 is described below commit bcb62c6e3fab70d8f1c1dd26fc4554a0a15e896b Author: remm AuthorDate: Wed Jun 30 22:07:55 2021 +0200 Beautify test --- test/org/apache/tomcat/util/net/TestXxxEndpoint.java | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java index efc4dd1..f270258 100644 --- a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java +++ b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java @@ -213,12 +213,14 @@ public class TestXxxEndpoint extends TomcatBaseTest { c.getProtocolHandlerClassName().contains("NioProtocol") && JreCompat.isJre16Available()); -File tempPath = File.createTempFile("tomcat", ".uds"); -final String unixDomainSocketPath = tempPath.getAbsolutePath(); -tempPath.delete(); +File tempPath = File.createTempFile("uds-tomcat-test-", ".sock"); +String unixDomainSocketPath = tempPath.getAbsolutePath(); +// Need to delete the file to make way for the actual socket +Assert.assertTrue(tempPath.delete()); Assert.assertTrue(c.setProperty("unixDomainSocketPath", unixDomainSocketPath)); tomcat.start(); +// Connect to the domain socket as a client SocketAddress sa = JreCompat.getInstance().getUnixDomainSocketAddress(unixDomainSocketPath); ByteBuffer response = ByteBuffer.allocate(1024); try (SocketChannel socket = JreCompat.getInstance().openUnixDomainSocketChannel()) { - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Beautify test
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 851534b Beautify test 851534b is described below commit 851534bc66f5929b29dfd9d89ef27eed38a86968 Author: remm AuthorDate: Wed Jun 30 22:07:55 2021 +0200 Beautify test --- test/org/apache/tomcat/util/net/TestXxxEndpoint.java | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java index c094480..0c23787 100644 --- a/test/org/apache/tomcat/util/net/TestXxxEndpoint.java +++ b/test/org/apache/tomcat/util/net/TestXxxEndpoint.java @@ -204,12 +204,14 @@ public class TestXxxEndpoint extends TomcatBaseTest { c.getProtocolHandlerClassName().contains("NioProtocol") && JreCompat.isJre16Available()); -File tempPath = File.createTempFile("tomcat", ".uds"); -final String unixDomainSocketPath = tempPath.getAbsolutePath(); -tempPath.delete(); +File tempPath = File.createTempFile("uds-tomcat-test-", ".sock"); +String unixDomainSocketPath = tempPath.getAbsolutePath(); +// Need to delete the file to make way for the actual socket +Assert.assertTrue(tempPath.delete()); Assert.assertTrue(c.setProperty("unixDomainSocketPath", unixDomainSocketPath)); tomcat.start(); +// Connect to the domain socket as a client SocketAddress sa = JreCompat.getInstance().getUnixDomainSocketAddress(unixDomainSocketPath); ByteBuffer response = ByteBuffer.allocate(1024); try (SocketChannel socket = JreCompat.getInstance().openUnixDomainSocketChannel()) { - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.69
On Tue, Jun 29, 2021 at 11:03 PM Christopher Schultz wrote: > > The proposed Apache Tomcat 8.5.69 release is now available for voting. > > The notable changes compared to the 8.5.68 release are: > > - Re-work the HTTP/2 overhead protection to reduce the likelihood of >false positives. Note that the default overheadCountFactor has changed >from 1 to 10 and that the useful range is now 0 to ~20. > > - Fix regressions in JSP compilation in the previous release. > > - Improve HTTP header parsing to ignore empty elements in 1#token >values, as per RFC 7230 section 7. > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat-8.5.x/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1322/ > > The tag is: > https://github.com/apache/tomcat/tree/8.5.69 > a17eaf7de9aa166dea03a5bc3bb4f1915176a3c8 > > The proposed 8.5.69 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.69 Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56430] Extension mapping that includes a dot in the extension does not work
https://bz.apache.org/bugzilla/show_bug.cgi?id=56430 jullieverma changed: What|Removed |Added URL||https://cutt.ly/Bmo9ZOE Keywords||FAQ --- Comment #10 from jullieverma --- Ok, but then it would be great, to get any kind of a feedback when deploying the application. When I use an invalid pattern like '/*.jsp' the server also complains. But when I use '*.my.txt' I get no hint that something is wrong. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57830] Add support for ProxyProtocol
https://bz.apache.org/bugzilla/show_bug.cgi?id=57830 --- Comment #24 from Tim --- I just re-read the spec and I see that the Proxy Protocol header must be required on every request. I'm not convinced requiring the Proxy Protocol header on every request increases security, especially not in the narrow context of HTTP and HTTPS connections. As I understood the argument, requiring the header always be present would somehow prevent spoofing. I don't see any way it prevents a malicious actor from sending a request with a falsified header. I think the correct guard against malicious actors sending falsified headers is to limit the range of IP's that can send requests with the Proxy Protocol header. In the context of supporting Proxy Protocol in Tomcat, I wouldn't want an implementation unless it provided the ability to limit the allowed senders of the Proxy Protocol header with an allow list that specified either a list of allowed IP addresses or one or more CIDRs. It is probably better to support the spec as written, but I would support an 'optional' argument to autodetect presence of the Proxy Protocol header if it didn't meet fierce resistance from the Tomcat team and if it rejected requests with a Proxy Protocol header that did not come from an address in the allow list. I think logs should show both the "claimed" IP as well as the actual IP a request came from. This is the approach I've taken when processing X-Request-For headers; log both the source of tcp connectoin and the X-Request-For address so anybody investigating a breach can verify if the request actually came from an authorized load balancer. Lastly, I think the implementation should make the "claimed" IP and port from the Proxy Protocol header available in the X-Forwarded-For and X-Forwarded-Port headers when handing the request off to the Servlet. This would preserve the data necessary to log both the "claimed" ip and the actual IP. In the tomcat access log, I think the %a and %h flags should print both the actual source of the connection (e.g. load balancer), and the "claimed" IP and port. I'm not strongly invested in any of my positions I layed out here. I'm just trying to get a better handle on what sort of patch would be acceptable. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56430] Extension mapping that includes a dot in the extension does not work
https://bz.apache.org/bugzilla/show_bug.cgi?id=56430 --- Comment #11 from jullieverma --- Since this is at best an enhancement, it can be considered fixed in Tomcat 8 which includes a rewrite valve that can easily do this sort of matching. Documentation available here: https://www.callandys.com -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65414] New: Problem compiling JSP using multiple taglib
https://bz.apache.org/bugzilla/show_bug.cgi?id=65414 Bug ID: 65414 Summary: Problem compiling JSP using multiple taglib Product: Tomcat 9 Version: 9.0.48 Hardware: PC Status: NEW Severity: critical Priority: P2 Component: Jasper Assignee: dev@tomcat.apache.org Reporter: janpier.san...@softwell.com.br Target Milestone: - Created attachment 37925 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37925&action=edit File on 9.0.48 This problem does not occur using version 9.0.46, only with the update of apache tomcat the compilation error starts to occur. Below is an excerpt of the JSP code that has a compilation error: ${wfre.jsName} When compiling the JSP file in version 9.0.46 the .java output file has the following instruction for invoke2: public boolean invoke2( javax.servlet.jsp.JspWriter out ) throws java.lang.Throwable { out.write("\n"); out.write(" "); if (_jspx_meth_webrun_005fmessageParam_005f1(_jspx_parent, _jspx_page_context, _jspx_push_body_count)) return true; out.write("\n"); out.write(""); return false; } The same JSP in version 9.0.48 the .java output file has the following instruction for invoke2: public boolean invoke2( javax.servlet.jsp.JspWriter out ) throws java.lang.Throwable { out.write("\n"); out.write(" "); if (_jspx_meth_webrun_005fmessageParam_005f1(_jspx_parent, _jspx_page_context, _jspx_push_body_count_c_005fforEach_005f0)) return true; out.write("\n"); out.write(""); return false; } Note that in version 9.0.46 the variable has the name _jspx_push_body_count and in 9.0.48 this name becomes _jspx_push_body_count_c_005fforEach_005f0, as this variable does not exist, the compilation error is displayed. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65414] Problem compiling JSP using multiple taglib
https://bz.apache.org/bugzilla/show_bug.cgi?id=65414 Konstantin Kolinko changed: What|Removed |Added OS||All --- Comment #1 from Konstantin Kolinko --- Please retest with release candidate binaries for Tomcat 9.0.50. See a "[VOTE]" thread on the dev mailing list for links. (Or provide a simple sample web application so that anybody else could test it for you.) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 65414] Problem compiling JSP using multiple taglib
https://bz.apache.org/bugzilla/show_bug.cgi?id=65414 --- Comment #2 from Janpier --- (In reply to Konstantin Kolinko from comment #1) > Please retest with release candidate binaries for Tomcat 9.0.50. > See a "[VOTE]" thread on the dev mailing list for links. > > (Or provide a simple sample web application so that anybody else could test > it for you.) I didn't find the link, could you send it? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1891167 - in /tomcat/site/trunk: docs/ci.html xdocs/ci.xml
Author: kkolinko Date: Wed Jun 30 22:09:41 2021 New Revision: 1891167 URL: http://svn.apache.org/viewvc?rev=1891167&view=rev Log: Update CI page to list links to the Snapshots and Staging repositories. Inspired by Mark's comment in bug 65390. https://bz.apache.org/bugzilla/show_bug.cgi?id=65390#c8 Modified: tomcat/site/trunk/docs/ci.html tomcat/site/trunk/xdocs/ci.xml Modified: tomcat/site/trunk/docs/ci.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/ci.html?rev=1891167&r1=1891166&r2=1891167&view=diff == --- tomcat/site/trunk/docs/ci.html (original) +++ tomcat/site/trunk/docs/ci.html Wed Jun 30 22:09:41 2021 @@ -2,7 +2,7 @@ Apache Tomcat® - Continuous Integrationhttp://tomcat.apache.org/";>Apache Tomcat®https://www.apache.org/foundation/contributing.html"; target="_blank" class="pull-left">https://www.apache.org/images/SupportApache-small.png"; class="support-asf" alt="Support Apache">http://www.apache.org/"; target="_blank" class="pull-left ">https://www.google.com/search"; method="get">GOhttps://www.apache.org/events/current-event.html";>https://www.apache.org/events/current-event-234x60.png"; alt="Next ASF event"> Save the date! Apache TomcatHomeTaglibsMaven PluginDownloadWhich version?https://tomcat.apache.org/download-10.cgi";>Tomcat 10https://tomcat.apache.org/download-90.cgi";>Tomcat 9https://tomcat.apache.org/download-80.cgi";>Tomcat 8https://tomcat.apache.org/download-70.cgi";>Tomcat 7https://tomcat.apache.org/download-migration.cgi";>Tomcat Migration Tool for Jakarta EEhttps://tomcat.apache.org/download-connectors.cgi";>Tomcat Connectorshttps://tomcat.apache.org/download-native.cgi";>Tomcat Nativehttps://tomcat.apache.org/download-taglibs.cgi";>Taglibshttps://archive.apache.org/dist/tomcat/";>A rchivesDocumentationTomcat 10.1 (alpha)Tomcat 10.0Tomcat 9.0Tomcat 8.5Tomcat 7.0Tomcat ConnectorsTomcat Nativehttps://cwiki.apache.org/confluence/display/TOMCAT";>WikiMigration GuidePresentationshttps://cwiki.apache.org/confluence/x/Bi8lBg";>SpecificationsProblems?Security ReportsFind helphttps://cwiki.apache.org/confluence/display/TOMCAT/FAQ";>FAQMailing ListsBug DatabaseIRCGet InvolvedOverviewSource codeBuildbothttps://cwiki.apache.org/confluence/x/vIPzBQ";>TranslationsToolsMediahttps://twitter.com/theapachetomcat";>Twitterhttps://www.youtube.com/c/ApacheTomcatOfficial";>YouTubehttps://blogs.apache.org/tomcat/";>BlogMiscWho We Arehttps://www.redbubble.com/people/comdev/works/30885254-apache-tomcat";>SwagHeritagehttp://www.apache.org";>Apache HomeResourcesContactLegalhttps://www.apache.org/foundation/contributing.html";>Support Apachehttps://www.apache.org/foundation/sponsorship.html";>Sponsorshiphttp://www.apache.org/foundation/thanks.html";>Thankshttp://www.apache.org/licenses/";>LicenseContentTable of Contents -OverviewDocumentation snapshotsBuild resultsBuildbotGumpJenkinsTravisCI +OverviewDocumentation snapshotsMaven snapshot repositoriesBuild resultsBuildbotGumpJenkinsTravisCI Overview Apache Tomcat project uses several https://ci.apache.org/";>automated build services provided by @@ -34,6 +34,21 @@ prepared and published by ASF Buildbot, https://ci.apache.org/projects/tomcat/tomcat-7.0.x/docs/index.html"; rel="nofollow">Tomcat 7.0.x +Maven snapshot repositories +There are the following Apache Maven repositories that provide binaries +for not-yet-released versions of Apache Tomcat + + + https://repository.apache.org/content/repositories/snapshots/"; rel="nofollow">Snapshots repository. +These binaries are updated with that each CI build done at ASF Buildbot. +Browse: https://repository.apache.org/content/repositories/snapshots/org/apache/tomcat/tomcat/";>arg.apache.tomcat : tomcat. + + https://repository.apache.org/content/groups/staging/"; rel="nofollow">Staging repository. +It hosts release candidates. Binaries are uploaded here when a release vote is being called. +Browse: https://repository.apache.org/content/groups/staging/org/apache/tomcat/tomcat/";>arg.apache.tomcat : tomcat. + + + Build results Buildbot Modified: tomcat/site/trunk/xdocs/ci.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/ci.xml?rev=1891167&r1=1891166&r2=1891167&view=diff == --- tomcat/site/trunk/xdocs/ci.xml (original) +++ tomcat/site/trunk/xdocs/ci.xml Wed Jun 30 22:09:41 2021 @@ -46,6 +46,27 @@ prepared and published by ASF Buildbot, + +There are the following Apache Maven repositories that provide binaries +for not-yet-released versions of Apache Tomcat + + + https://repository.apache.org/content/repositories/snapshots/"; rel="nofollow" +>Snapshots repository. +These binaries are updated with that each CI build done at ASF Buildbot. +Browse: https://repository.apache.org/content/repositories/snapshots/org/apache/tomcat/tomca
[Bug 65414] Problem compiling JSP using multiple taglib
https://bz.apache.org/bugzilla/show_bug.cgi?id=65414 --- Comment #3 from Konstantin Kolinko --- (In reply to Janpier from comment #2) > I didn't find the link, could you send it? https://tomcat.apache.org/lists.html#tomcat-dev https://tomcat.markmail.org/thread/jaq2m2s4okd3u2zx -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Fwd: [Bug 56430] Extension mapping that includes a dot in the extension does not work
All, I don't believe I have any BZ karma at all, but this user has duplicated old comments and inserted spam URLs into the comment stream. Can someone kill this stuff? -chris Forwarded Message Subject: [Bug 56430] Extension mapping that includes a dot in the extension does not work Date: Wed, 30 Jun 2021 20:58:16 + From: bugzi...@apache.org Reply-To: Tomcat Developers List To: dev@tomcat.apache.org https://bz.apache.org/bugzilla/show_bug.cgi?id=56430 jullieverma changed: What|Removed |Added URL||https://cutt.ly/Bmo9ZOE Keywords||FAQ --- Comment #10 from jullieverma --- Ok, but then it would be great, to get any kind of a feedback when deploying the application. When I use an invalid pattern like '/*.jsp' the server also complains. But when I use '*.my.txt' I get no hint that something is wrong. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1891168 - in /tomcat/site/trunk: docs/lists.html xdocs/lists.xml
Author: kkolinko Date: Wed Jun 30 22:46:46 2021 New Revision: 1891168 URL: http://svn.apache.org/viewvc?rev=1891168&view=rev Log: Update links to mail list archives. Add links to Pony Mail at the ASF. 1. Add links to Pony Mail archives at ASF. 2. Fix links for taglibs-user mailing list. Archives for this list at the ASF are no longer split between @tomcat.a.o and older @jakarta.a.o. 3. Update some links to use https: protocol. Modified: tomcat/site/trunk/docs/lists.html tomcat/site/trunk/xdocs/lists.xml Modified: tomcat/site/trunk/docs/lists.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/lists.html?rev=1891168&r1=1891167&r2=1891168&view=diff == --- tomcat/site/trunk/docs/lists.html (original) +++ tomcat/site/trunk/docs/lists.html Wed Jun 30 22:46:46 2021 @@ -145,12 +145,13 @@ Tomcat questions to Eric or Rick themsel Archives: -at http://mail-archives.apache.org/mod_mbox/tomcat-users/";>Apache -, or searchable archives at -http://marc.info/?l=tomcat-user"; rel="nofollow">MARC, -http://markmail.org/list/org.apache.tomcat.user/"; rel="nofollow">MarkMail, +at the ASF with http://mail-archives.apache.org/mod_mbox/tomcat-users/";>mod_mbox +or with https://lists.apache.org/list.html?us...@tomcat.apache.org";>Pony Mail, +or searchable archives at +https://marc.info/?l=tomcat-user"; rel="nofollow">MARC, +https://markmail.org/list/org.apache.tomcat.user/"; rel="nofollow">MarkMail, http://tomcat.10.x6.nabble.com/Tomcat-User-f1968778.html"; rel="nofollow">Nabble -and http://www.mail-archive.com/users@tomcat.apache.org/"; rel="nofollow">Mail Archive +and https://www.mail-archive.com/users@tomcat.apache.org/"; rel="nofollow">Mail Archive @@ -201,9 +202,9 @@ other project announcements. Archives: -at http://mail-archives.apache.org/mod_mbox/tomcat-announce/";> -Apache, -at http://markmail.org/list/org.apache.tomcat.announce/"; rel="nofollow">MarkMail and +at the ASF with http://mail-archives.apache.org/mod_mbox/tomcat-announce/";>mod_mbox +or with https://lists.apache.org/list.html?annou...@tomcat.apache.org";>Pony Mail, +at https://markmail.org/list/org.apache.tomcat.announce/"; rel="nofollow">MarkMail and at http://www.mail-archive.com/announce@tomcat.apache.org/"; rel="nofollow">Mail Archive @@ -276,12 +277,13 @@ issues. Other questions will be ignored. Archives: -at http://mail-archives.apache.org/mod_mbox/tomcat-dev/";>Apache -, or searchable archives at -http://marc.info/?l=tomcat-dev"; rel="nofollow">MARC, -http://markmail.org/list/org.apache.tomcat.dev/"; rel="nofollow">MarkMail, +at the ASF with http://mail-archives.apache.org/mod_mbox/tomcat-dev/";>mod_mbox +or with https://lists.apache.org/list.html?dev@tomcat.apache.org";>Pony Mail, +or searchable archives at +https://marc.info/?l=tomcat-dev"; rel="nofollow">MARC, +https://markmail.org/list/org.apache.tomcat.dev/"; rel="nofollow">MarkMail, http://tomcat.10.x6.nabble.com/Tomcat-Dev-f2176423.html"; rel="nofollow">Nabble -and http://www.mail-archive.com/dev@tomcat.apache.org/"; rel="nofollow">Mail Archive +and https://www.mail-archive.com/dev@tomcat.apache.org/"; rel="nofollow">Mail Archive @@ -300,6 +302,10 @@ a good forum for asking questions about and how they can be used. + +Note: This mailing list was formelly known as taglibs-u...@jakarta.apache.org. + + Volume: @@ -348,13 +354,11 @@ and how they can be used. Archives: -at http://mail-archives.apache.org/mod_mbox/tomcat-taglibs-user/";> -Apache (see -http://mail-archives.apache.org/mod_mbox/jakarta-taglibs-user/";> -older archives), at -http://markmail.org/list/org.apache.jakarta.taglibs-user/"; rel="nofollow">MarkMail (both old and new) and at -http://www.mail-archive.com/taglibs-user@tomcat.apache.org/"; rel="nofollow">Mail Archive (also -http://www.mail-archive.com/taglibs-user@jakarta.apache.org/"; rel="nofollow">older archives) +at the ASF with http://mail-archives.apache.org/mod_mbox/tomcat-taglibs-user/";>mod_mbox +or with https://lists.apache.org/list.html?taglibs-u...@tomcat.apache.org";>Pony Mail, +at https://markmail.org/list/org.apache.jakarta.taglibs-user/"; rel="nofollow">MarkMail and at +https://www.mail-archive.com/taglibs-user@tomcat.apache.org/"; rel="nofollow">Mail Archive (also +https://www.mail-archive.com/taglibs-user@jakarta.apache.org/"; rel="nofollow">older archives) Modified: tomcat/site/trunk/xdocs/lists.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/lists.xml?rev=1891168&r1=1891167&r2=1891168&view=diff == --- tomcat/site/trunk/xdocs/lists.xml (original) +++ tomcat/site/trunk/xdocs/lists.xml Wed Jun 30 2
svn commit: r1891169 - in /tomcat/site/trunk: docs/lists.html xdocs/lists.xml
Author: kkolinko Date: Wed Jun 30 22:58:22 2021 New Revision: 1891169 URL: http://svn.apache.org/viewvc?rev=1891169&view=rev Log: Update mailing list posting guidelines. Add Tomcat 10.1 to a list of versions. Modified: tomcat/site/trunk/docs/lists.html tomcat/site/trunk/xdocs/lists.xml Modified: tomcat/site/trunk/docs/lists.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/lists.html?rev=1891169&r1=1891168&r2=1891169&view=diff == --- tomcat/site/trunk/docs/lists.html (original) +++ tomcat/site/trunk/docs/lists.html Wed Jun 30 22:58:22 2021 @@ -72,12 +72,12 @@ Tomcat questions to Eric or Rick themsel When asking questions on the list, please state your exact Tomcat version - (which is three numbers, 9.0.xx, 8.5.yy, 8.0.zz or 7.0.vv), your operating + (which is three numbers, 10.1.zz, 10.0.yy, 9.0.xx, 8.5.ww, 8.0.vv, or 7.0.uu), your operating system, and essential bits of your configuration. Note, that Tomcat Documentation is provided on this site and is searchable - (see links and search box at the left). Add "Tomcat 9.0", "Tomcat 8.5", - "Tomcat 8.0" or "Tomcat 7.0" to your query to refine your results. The + (see links and search box at the left). Add "Tomcat 10.0", "Tomcat 9.0", + or "Tomcat 8.5" to your query to refine your results. The tomcat-users mailing list archives (links are below) are also searchable. The https://cwiki.apache.org/confluence/display/TOMCAT/FAQ";>FAQ and @@ -86,12 +86,12 @@ Tomcat questions to Eric or Rick themsel https://cwiki.apache.org/confluence/display/TOMCAT";>Tomcat Wiki. Usage of these mailing lists is subject to the - http://www.apache.org/foundation/public-archives.html";>Public Forum Archive Policy. + https://www.apache.org/foundation/public-archives.html";>Public Forum Archive Policy. To post a question, start a new thread by sending your mail to the "Posting questions" address below. Do not reply to an existing e-mail. To be able to post to the mailing list, you have to be subscribed. When replying, please write your text below the quoted one. - http://en.wikipedia.org/wiki/Posting_style#Choosing_the_proper_posting_style"; rel="nofollow">Top-posting + https://en.wikipedia.org/wiki/Posting_style#Choosing_the_proper_posting_style"; rel="nofollow">Top-posting is bad. (Hint: when replying in GMail, click on "..." button to show the text of original e-mail. Other mail clients have similar features.) Modified: tomcat/site/trunk/xdocs/lists.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/lists.xml?rev=1891169&r1=1891168&r2=1891169&view=diff == --- tomcat/site/trunk/xdocs/lists.xml (original) +++ tomcat/site/trunk/xdocs/lists.xml Wed Jun 30 22:58:22 2021 @@ -82,12 +82,12 @@ Tomcat questions to Eric or Rick themsel When asking questions on the list, please state your exact Tomcat version - (which is three numbers, 9.0.xx, 8.5.yy, 8.0.zz or 7.0.vv), your operating + (which is three numbers, 10.1.zz, 10.0.yy, 9.0.xx, 8.5.ww, 8.0.vv, or 7.0.uu), your operating system, and essential bits of your configuration. Note, that Tomcat Documentation is provided on this site and is searchable - (see links and search box at the left). Add "Tomcat 9.0", "Tomcat 8.5", - "Tomcat 8.0" or "Tomcat 7.0" to your query to refine your results. The + (see links and search box at the left). Add "Tomcat 10.0", "Tomcat 9.0", + or "Tomcat 8.5" to your query to refine your results. The tomcat-users mailing list archives (links are below) are also searchable. The https://cwiki.apache.org/confluence/display/TOMCAT/FAQ";>FAQ and @@ -96,12 +96,12 @@ Tomcat questions to Eric or Rick themsel https://cwiki.apache.org/confluence/display/TOMCAT";>Tomcat Wiki. Usage of these mailing lists is subject to the - http://www.apache.org/foundation/public-archives.html";>Public Forum Archive Policy. + https://www.apache.org/foundation/public-archives.html";>Public Forum Archive Policy. To post a question, start a new thread by sending your mail to the "Posting questions" address below. Do not reply to an existing e-mail. To be able to post to the mailing list, you have to be subscribed. When replying, please write your text below the quoted one. - http://en.wikipedia.org/wiki/Posting_style#Choosing_the_proper_posting_style"; rel="nofollow">Top-posting + https://en.wikipedia.org/wiki/Posting_style#Choosing_the_proper_posting_style"; rel="nofollow">Top-posting is bad. (Hint: when replying in GMail, click on "..." button to show the text of original e-mail. Other mail clients have similar features.) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org