[GitHub] [tomcat] Catclaws12 commented on a change in pull request #183: preload driver in connection pool

2021-10-20 Thread GitBox 


Catclaws12 commented on a change in pull request #183:
URL: https://github.com/apache/tomcat/pull/183#discussion_r733090607



##
File path: 
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java
##
@@ -335,7 +308,7 @@ protected void connectUsingDriver() throws SQLException {
 }
 }
 if (connection==null) {
-throw new SQLException("Driver:"+driver+" returned null for 
URL:"+driverURL);
+throw new SQLException("Driver:"+parent.getDriver()+" returned 
null for URL:"+driverURL);

Review comment:
   - [ ] 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: 2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-20 Thread Mark Thomas 

I'm not seeing those failures with OpenJDK 17.0.1

The response line and body look to be correct to me.

The failure appears to be with the request body. Is it possible you 
aren't using UTF-8 for the *.java file? You could try using 
"/foo\u20acbar" as the expected canonicalized URI.


Mark


On 20/10/2021 12:53, Martin Grigorov wrote:

Hi,

Today I've tested JDK 17.0.1 and noticed these failures:

Testcase: testCanonicalizationSpecification[49:
requestURI[/foo%E2%82%ACbar]] took 0.055 sec
 FAILED
HTTP/1.1 200
/foo€bar
junit.framework.AssertionFailedError: HTTP/1.1 200
/foo€bar
 at
org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.doTestCanonicalization(TestCoyoteAdapterCanonicalization.java:200)
 at
org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.testCanonicalizationSpecification(TestCoyoteAdapterCanonicalization.java:156)
 at jdk.internal.reflect.GeneratedMethodAccessor28.invoke(Unknown
Source)
 at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

Testcase: testCanonicalizationTomcat[49: requestURI[/foo%E2%82%ACbar]] took
0.087 sec
 FAILED
HTTP/1.1 200
/foo€bar
junit.framework.AssertionFailedError: HTTP/1.1 200
/foo€bar
 at
org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.doTestCanonicalization(TestCoyoteAdapterCanonicalization.java:200)
 at
org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.testCanonicalizationTomcat(TestCoyoteAdapterCanonicalization.java:161)
 at jdk.internal.reflect.GeneratedMethodAccessor29.invoke(Unknown
Source)
 at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

They fail consitently on both x86_64 and aarch64.

Regards,
Martin




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

2 tests in TestCoyoteAdapterCanonicalization fail

2021-10-20 Thread Martin Grigorov 
Hi,

Today I've tested JDK 17.0.1 and noticed these failures:

Testcase: testCanonicalizationSpecification[49:
requestURI[/foo%E2%82%ACbar]] took 0.055 sec
FAILED
HTTP/1.1 200
/foo€bar
junit.framework.AssertionFailedError: HTTP/1.1 200
/foo€bar
at
org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.doTestCanonicalization(TestCoyoteAdapterCanonicalization.java:200)
at
org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.testCanonicalizationSpecification(TestCoyoteAdapterCanonicalization.java:156)
at jdk.internal.reflect.GeneratedMethodAccessor28.invoke(Unknown
Source)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

Testcase: testCanonicalizationTomcat[49: requestURI[/foo%E2%82%ACbar]] took
0.087 sec
FAILED
HTTP/1.1 200
/foo€bar
junit.framework.AssertionFailedError: HTTP/1.1 200
/foo€bar
at
org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.doTestCanonicalization(TestCoyoteAdapterCanonicalization.java:200)
at
org.apache.catalina.connector.TestCoyoteAdapterCanonicalization.testCanonicalizationTomcat(TestCoyoteAdapterCanonicalization.java:161)
at jdk.internal.reflect.GeneratedMethodAccessor29.invoke(Unknown
Source)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

They fail consitently on both x86_64 and aarch64.

Regards,
Martin