[Bug 66084] bytesWritten in writeBytes() miscalculation for OutputBuffer
https://bz.apache.org/bugzilla/show_bug.cgi?id=66084 lihan changed: What|Removed |Added OS||All --- Comment #1 from lihan --- I've raised a pr based on your feedback, https://github.com/apache/tomcat/pull/516 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66084] New: bytesWritten in writeBytes() miscalculation for OutputBuffer
https://bz.apache.org/bugzilla/show_bug.cgi?id=66084 Bug ID: 66084 Summary: bytesWritten in writeBytes() miscalculation for OutputBuffer Product: Tomcat 9 Version: 9.0.63 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: 1205878...@qq.com Target Milestone: - Created attachment 38301 --> https://bz.apache.org/bugzilla/attachment.cgi?id=38301=edit left is source code, right is test code 在org.apache.catalina.connector.OutputBuffer类的private void writeBytes(ByteBuffer from) 方法中，不能正确的将可写入字节长度计入写入字节数据总量中。 In org. Apache. Catalina. Connector. OutputBuffer class private void writeBytes (ByteBuffer from) method, is unable to correctly write bytes will be recorded in writing bytes of data amount. -By translation software -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: [ANN] ApacheCon NA 2022 in New Orleans, 3-6 Oct 2022, CFP is OPEN!
Ah, ok. I understand. :-) It may be something to consider for the future, for those of us with disabilities. :-) Dream * Excel * Explore * Inspire Jon McAlexander Senior Infrastructure Engineer Asst. Vice President He/His Middleware Product Engineering Enterprise CIO | EAS | Middleware | Infrastructure Solutions 8080 Cobblestone Rd | Urbandale, IA 50322 MAC: F4469-010 Tel 515-988-2508 | Cell 515-988-2508 jonmcalexan...@wellsfargo.com This message may contain confidential and/or privileged information. If you are not the addressee or authorized to receive this for the addressee, you must not use, copy, disclose, or take any action based on this message or any information herein. If you have received this message in error, please advise the sender immediately by reply e-mail and delete this message. Thank you for your cooperation. > -Original Message- > From: Christopher Schultz > Sent: Monday, May 23, 2022 3:49 PM > To: Tomcat Developers List ; > jonmcalexan...@wellsfargo.com.INVALID; us...@tomcat.apache.org; > csuth...@apache.org > Subject: Re: [ANN] ApacheCon NA 2022 in New Orleans, 3-6 Oct 2022, CFP is > OPEN! > Importance: High > > Jon, > > On 5/23/22 16:41, jonmcalexan...@wellsfargo.com.INVALID wrote: > > Understood. > > > > I'm willing to give it a try if you want to sign me up, but I have to > > do it virtual. Traveling is not possible for me. > Oh. Sorry about that; it will need to be in-person. We don't have any set up > to do pre-recorded or virtual presentations (that I know of) at the moment. > > Thanks, > -chris > > - > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org
Re: [ANN] Apache Tomcat 8.5.79 available
All, I jumped the gun on sending this announcement, so I went ahead and updated the web site, too. The CDN doesn't have the release artifacts, yet, but the ASF downloads server does. Please be patient until the CDN updates. Thanks, -chris On 5/23/22 16:56, Christopher Schultz wrote: The Apache Tomcat team announces the immediate availability of Apache Tomcat 8.5.79. Apache Tomcat 8 is an open source software implementation of the Java Servlet, JavaServer Pages, Java Unified Expression Language, Java WebSocket and JASPIC technologies. Apache Tomcat 8.5.79 is a bugfix and feature release. The notable changes compared to 8.5.78 include: - Provide a property source that sources values from Kubernetes service bindings. Provided by Sumit Kulhadia and Gareth Evans. - The root cause of the Linux kernel duplicate accept bug has been identified along with the version of the kernel that includes the fix. The error message displayed when this bug occurs has been updated to reflect this new information and to advise users to update to a version of the OS that uses kernel 5.10 or later. Thanks to Christopher Gual for the research into this issue. - Update the packaged version of the Tomcat Native Library to 1.2.33 to pick up Windows binaries built with OpenSSL 1.1.1o. - Add support for encrypted PKCS#1 formatted private keys when configuring the internal, in-memory key store. Along with lots of other bug fixes and improvements. Please refer to the change log for the complete list of changes: https://tomcat.apache.org/tomcat-8.5-doc/changelog.html Downloads: https://tomcat.apache.org/download-80.cgi Migration guides from Apache Tomcat 7.x and 8.0: https://tomcat.apache.org/migration.html Enjoy! - The Apache Tomcat team - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1901183 - in /tomcat/site/trunk: ./ docs/ docs/tomcat-8.5-doc/ docs/tomcat-8.5-doc/annotationapi/ docs/tomcat-8.5-doc/annotationapi/javax/annotation/ docs/tomcat-8.5-doc/annotationapi/jav
Author: schultz Date: Mon May 23 21:08:50 2022 New Revision: 1901183 URL: http://svn.apache.org/viewvc?rev=1901183=rev Log: Update site to include 8.5.79 release. [This commit notification would consist of 75 parts, which exceeds the limit of 50 ones, so it was shortened to the summary.] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[ANN] Apache Tomcat 8.5.79 available
The Apache Tomcat team announces the immediate availability of Apache Tomcat 8.5.79. Apache Tomcat 8 is an open source software implementation of the Java Servlet, JavaServer Pages, Java Unified Expression Language, Java WebSocket and JASPIC technologies. Apache Tomcat 8.5.79 is a bugfix and feature release. The notable changes compared to 8.5.78 include: - Provide a property source that sources values from Kubernetes service bindings. Provided by Sumit Kulhadia and Gareth Evans. - The root cause of the Linux kernel duplicate accept bug has been identified along with the version of the kernel that includes the fix. The error message displayed when this bug occurs has been updated to reflect this new information and to advise users to update to a version of the OS that uses kernel 5.10 or later. Thanks to Christopher Gual for the research into this issue. - Update the packaged version of the Tomcat Native Library to 1.2.33 to pick up Windows binaries built with OpenSSL 1.1.1o. - Add support for encrypted PKCS#1 formatted private keys when configuring the internal, in-memory key store. Along with lots of other bug fixes and improvements. Please refer to the change log for the complete list of changes: https://tomcat.apache.org/tomcat-8.5-doc/changelog.html Downloads: https://tomcat.apache.org/download-80.cgi Migration guides from Apache Tomcat 7.x and 8.0: https://tomcat.apache.org/migration.html Enjoy! - The Apache Tomcat team - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] ApacheCon NA 2022 in New Orleans, 3-6 Oct 2022, CFP is OPEN!
Jon, On 5/23/22 16:41, jonmcalexan...@wellsfargo.com.INVALID wrote: Understood. I'm willing to give it a try if you want to sign me up, but I have to do it virtual. Traveling is not possible for me. Oh. Sorry about that; it will need to be in-person. We don't have any set up to do pre-recorded or virtual presentations (that I know of) at the moment. Thanks, -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: [ANN] ApacheCon NA 2022 in New Orleans, 3-6 Oct 2022, CFP is OPEN!
Understood. I'm willing to give it a try if you want to sign me up, but I have to do it virtual. Traveling is not possible for me. Let me know please. Dream * Excel * Explore * Inspire Jon McAlexander Senior Infrastructure Engineer Asst. Vice President He/His Middleware Product Engineering Enterprise CIO | EAS | Middleware | Infrastructure Solutions 8080 Cobblestone Rd | Urbandale, IA 50322 MAC: F4469-010 Tel 515-988-2508 | Cell 515-988-2508 jonmcalexan...@wellsfargo.com This message may contain confidential and/or privileged information. If you are not the addressee or authorized to receive this for the addressee, you must not use, copy, disclose, or take any action based on this message or any information herein. If you have received this message in error, please advise the sender immediately by reply e-mail and delete this message. Thank you for your cooperation. > -Original Message- > From: Christopher Schultz > Sent: Monday, May 23, 2022 3:36 PM > To: Tomcat Developers List ; > jonmcalexan...@wellsfargo.com.INVALID; us...@tomcat.apache.org; > csuth...@apache.org > Subject: Re: [ANN] ApacheCon NA 2022 in New Orleans, 3-6 Oct 2022, CFP is > OPEN! > Importance: High > > Jon, > > On 5/23/22 15:53, jonmcalexan...@wellsfargo.com.INVALID wrote: > > I would really Love to have something, but I just don't have the time > > to work on anything like this > You could just talk about something you are already doing. It doesn't need to > be ground-breaking work. Something along the lines of "we are using Tomcat > feature X to solve problem Y at job Z". As long as it's not an advertisement > for > your company/product. > > I mean... most of the presentations given by committers are like "Here's how > to do this fairly mundane thing like connect httpd -> Tomcat". > > > nor do I feel confident enough yet. > > I'm sure you'd do fine. It's not a hostile crowd. > > > Chris keeps blowing holes in my understanding so now I think I need to > > go and fine-tooth thru the documentation. I really feel I know proper > > "instance" configuration, but now, not so sure. :-=) Maybe in an > > upcoming year when I'm older, closer to retirement age. :-D > The proper configuration it the one that's working for you... especially if > you > understand it! If you don't understand youre configuration, you will be afraid > to change anything for the better... or the worse. :) > > If it takes you a while to figure something out, you are probably not alone. > You could give a talk on "How I Learned to Stop Worrying and Love the > Configuration" or whatever. Not everybody thinks the same way, and > hearing it from you instead of (e.g.) me might be better for the audience. > > -chris > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional > commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r54695 - /dev/tomcat/tomcat-8/v8.5.79/ /release/tomcat/tomcat-8/v8.5.79/
Author: schultz Date: Mon May 23 20:42:34 2022 New Revision: 54695 Log: Promote 8.5.79 release Added: release/tomcat/tomcat-8/v8.5.79/ - copied from r54694, dev/tomcat/tomcat-8/v8.5.79/ Removed: dev/tomcat/tomcat-8/v8.5.79/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] ApacheCon NA 2022 in New Orleans, 3-6 Oct 2022, CFP is OPEN!
Jon, On 5/23/22 15:53, jonmcalexan...@wellsfargo.com.INVALID wrote: I would really Love to have something, but I just don't have the time to work on anything like this You could just talk about something you are already doing. It doesn't need to be ground-breaking work. Something along the lines of "we are using Tomcat feature X to solve problem Y at job Z". As long as it's not an advertisement for your company/product. I mean... most of the presentations given by committers are like "Here's how to do this fairly mundane thing like connect httpd -> Tomcat". nor do I feel confident enough yet. I'm sure you'd do fine. It's not a hostile crowd. Chris keeps blowing holes in my understanding so now I think I need to go and fine-tooth thru the documentation. I really feel I know proper "instance" configuration, but now, not so sure. :-=) Maybe in an upcoming year when I'm older, closer to retirement age. :-D The proper configuration it the one that's working for you... especially if you understand it! If you don't understand youre configuration, you will be afraid to change anything for the better... or the worse. :) If it takes you a while to figure something out, you are probably not alone. You could give a talk on "How I Learned to Stop Worrying and Love the Configuration" or whatever. Not everybody thinks the same way, and hearing it from you instead of (e.g.) me might be better for the audience. -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66076] Final block of encrypted response payload not being sent occasionally over TLS
https://bz.apache.org/bugzilla/show_bug.cgi?id=66076 --- Comment #9 from Phil Clay --- The test using the dev build unfortunately failed after about 3 hours with the same symptom. After it failed, a re-ran it with a breakpoint in NioEndpoint.flushNonBlocking to see the new code in action, but my breakpoint unfortunately never gets hit when sending outbound websocket messages. (It does get hit when sending a normal HTTP response, so I can confirm the new code is active and the breakpoint is working.) Here's the partial stacktrace when SecureNioEndpoint.flush gets called (when it doesn't write everything out). Perhaps that provides some visibility into why NioEndpoint.flushNonBlocking is never called ? Breakpoint reached at org.apache.tomcat.util.net.SecureNioChannel.flush(SecureNioChannel.java:123) at org.apache.tomcat.util.net.SecureNioChannel.write(SecureNioChannel.java:863) at org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper$NioOperationState.run(NioEndpoint.java:1674) at org.apache.tomcat.util.net.SocketWrapperBase$OperationState.start(SocketWrapperBase.java:1063) at org.apache.tomcat.util.net.SocketWrapperBase.vectoredOperation(SocketWrapperBase.java:1482) at org.apache.tomcat.util.net.SocketWrapperBase.write(SocketWrapperBase.java:1408) at org.apache.tomcat.util.net.SocketWrapperBase.write(SocketWrapperBase.java:1379) at org.apache.tomcat.websocket.server.WsRemoteEndpointImplServer.doWrite(WsRemoteEndpointImplServer.java:93) at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.writeMessagePart(WsRemoteEndpointImplBase.java:512) at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.startMessage(WsRemoteEndpointImplBase.java:398) at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.sendBytesByCompletion(WsRemoteEndpointImplBase.java:155) at org.apache.tomcat.websocket.WsRemoteEndpointAsync.sendBinary(WsRemoteEndpointAsync.java:65) at org.springframework.web.reactive.socket.adapter.StandardWebSocketSession.sendMessage(StandardWebSocketSession.java:92) Should something in that stack be triggering NioEndpoint.flushNonBlocking (either directly or indirectly via flushing the socket)? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: [ANN] ApacheCon NA 2022 in New Orleans, 3-6 Oct 2022, CFP is OPEN!
> -Original Message- > From: Christopher Schultz > Sent: Monday, May 23, 2022 2:37 PM > To: Tomcat Users List ; Coty Sutherland > > Cc: Tomcat Developers List > Subject: Re: [ANN] ApacheCon NA 2022 in New Orleans, 3-6 Oct 2022, CFP is > OPEN! > Importance: High > > Coty, > > On 5/23/22 15:22, Coty Sutherland wrote: > > On Fri, Apr 29, 2022 at 2:53 PM Christopher Schultz < > > ch...@christopherschultz.net> wrote: > > > >> All, > >> > >> Please remember that the ApacheCon North American conference is still > >> accepting presentations until 23 May 2022. > >> > >> The Tomcat track currently has *zero* proposals, and we were hoping > >> to fill a 3-day track. > >> > >> So please, send in your ideas for presentations! > > > > How are we doing now? I just submitted one with the hopes of > > submitting a second, but I think one is about all I can handle at the > moment... > > jfclere proposed 4 talks and it looks like remm added another 2. I guess yours > is the 7th. (I can't actually see the submitter names right now). > I haven't done any, yet (I was going to wait to see what else showed up). > > The CFP is officially over today, so I'll probably drop 3a few in there, too. > > I'm sad to see that no non-committers submitted anything. Maybe its just > that people aren't ready to travel/conference quite yet. > > -chris > > - > To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org > For additional commands, e-mail: users-h...@tomcat.apache.org I would really Love to have something, but I just don't have the time to work on anything like this, nor do I feel confident enough yet. Chris keeps blowing holes in my understanding so now I think I need to go and fine-tooth thru the documentation. I really feel I know proper "instance" configuration, but now, not so sure. :-=) Maybe in an upcoming year when I'm older, closer to retirement age. :-D Thanks, Dream * Excel * Explore * Inspire Jon McAlexander Senior Infrastructure Engineer Asst. Vice President He/His Middleware Product Engineering Enterprise CIO | EAS | Middleware | Infrastructure Solutions 8080 Cobblestone Rd | Urbandale, IA 50322 MAC: F4469-010 Tel 515-988-2508 | Cell 515-988-2508 jonmcalexan...@wellsfargo.com This message may contain confidential and/or privileged information. If you are not the addressee or authorized to receive this for the addressee, you must not use, copy, disclose, or take any action based on this message or any information herein. If you have received this message in error, please advise the sender immediately by reply e-mail and delete this message. Thank you for your cooperation. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [tomcat] branch main updated: Refactor to remove syncs on SocketWrapper to support Loom experiments
On Mon, May 23, 2022 at 6:29 PM Mark Thomas wrote: > > On 23/05/2022 17:27, ma...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > markt pushed a commit to branch main > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The following commit(s) were added to refs/heads/main by this push: > > new 0a94801588 Refactor to remove syncs on SocketWrapper to support > > Loom experiments > > 0a94801588 is described below > > > > commit 0a9480158874ea910a4d629d24f31d69d6cc5f96 > > Author: Mark Thomas > > AuthorDate: Mon May 23 17:27:24 2022 +0100 > > > > Refactor to remove syncs on SocketWrapper to support Loom experiments > > From what has been posted on dev@, I think this should be sufficient > for folks that want to explore loom to get started. I strongly suspect > further changes will be required as those experimenting with loom expand > the range of Tomcat features they want to use. My thinking is we address > any additional refactoring as the need for it is identified. I read the instructions for Loom and researched, and it doesn't seem to me like a good fit for an app server, to be honest. At this point at least. Thread locals apparently don't work as well, so there's a large amount of the functionality that cannot be implemented (AFAIK). >From the IO side, it would mean going (back) to java.io if we're really serious about it, since it's the most efficient (it's basically java.io > NIO > NIO2). Also native code is kind of a problem it seems. Rémy > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE][RESULT] Release Apache Tomcat 8.5.79
All, Binding: +1: markt, remm, fhanik, schultz Non-Binding +1: rotyy3000 There were no other votes. The vote therefore passes. I'll start the release process in a few minutes. -chris On 5/16/22 12:13, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.79 release is now available for voting. The notable changes compared to 8.5.78 are: - Provide a property source that sources values from Kubernetes service bindings. Provided by Sumit Kulhadia and Gareth Evans. - The root cause of the Linux kernel duplicate accept bug has been identified along with the version of the kernel that includes the fix. The error message displayed when this bug occurs has been updated to reflect this new information and to advise users to update to a version of the OS that uses kernel 5.10 or later. Thanks to Christopher Gual for the research into this issue. - Update the packaged version of the Tomcat Native Library to 1.2.33 to pick up Windows binaries built with OpenSSL 1.1.1o. - Add support for encrypted PKCS#1 formatted private keys when configuring the internal, in memory key store. Along with lots of other bug fixes and improvements. For full details, see the changelog: https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.79/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1375 The tag is: https://github.com/apache/tomcat/tree/8.5.79 1af5f227ae591e601a9426d3788bf6a60a1b75a3 The proposed 8.5.79 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.5.79 (stable) -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] ApacheCon NA 2022 in New Orleans, 3-6 Oct 2022, CFP CLOSES TODAY!!
All, If you were considering submitting a presentation, please do it *RIGHT NOW*. Thank, -chris On 4/7/22 10:26, Christopher Schultz wrote: All, [Cross-posting to dev@, please reply to users@] ApacheCon NA 2022 is back *in-person* in New Orleans, Louisiana. It will be held 3 - 6 October 2022 at the Canal Street Sheraton right next to the French Quarter. The call-for-presentations is currently open and we are looking to fill a 3-day track for Tomcat, so please submit your proposals today! https://www.apachecon.com/acna2022/ (The link at the top is a little obscure, but at the top of the page there is a "Call for Presentations" where you can submit a proposal). Note that you don't have to have the presentation ready to go today in order to make a proposal. It's just gotta be ready around 30 seconds before you start to present it ;) (There is a tradition at ApacheCon of editing ones slides during the previous presentation. I don't recommend it, but anyone who is intimidated by the process can rest assured that even repeat-presenters are putting things together at the last moment.) Anyone who has never attended an ApacheCon should consider making this year their first: it's great fun, and you get to meet a lof of folks from all over the ASF, not just the Tomcat or httpd people, but folks working on projects you've never even heard of. If you aren't sure if you are interested in presenting, or aren't sure if you have the experience, knowledge, etc. to warrant a position as a speaker, please consider the following: 1. This is a welcoming community 2. This community exists to serve YOU 3. You are a part of this community 4. Helping others within the community encourages others to do the same 5. Topics can be very wide-ranging. Here are some examples of presentations from previous ApacheCon events: [From Committers / directly about Tomcat] - Running Apache Tomcat on GraalVM - Tomcat in clusters and clouds - Using Let's Encrypt with Tomcat - Securing Tomcat - Reverse-proxying Tomcat - Load balancing with Tomcat - Clustering with Tomcat [From Non-Committers or not directly about Tomcat] - Packaging Tomcat for Linux Distributions - I Love Lucee -- a Java implementation of Cold Fusion - Routing CDN traffic at scale using Tomcat - Secure Web Applications using Apache Fortress - Monitoring Tomcat; various tools - Building Reactive Applications on Tomcat - Troubleshooting performance using thread dumps - High Throughput Production Systems on Tomcat - Why I Love Open Source - Introduction to Spring Boot - Tomcat, TomEE, and Meecrowave - Apache Tomcat: Enabling Scripting Languages in JSPs If you are using Tomcat at $work and doing something interesting, we'd love to hear about it. 6. You don't need to be the foremost expert in $feature to talk about it 7. We are actively looking for speakers to talk about these and other topics: - Deploying Tomcat in an auto-scaling environment (e.g. AWS EBS) - Tomcat should really have [Feature X] - Whatever you think might be interesting! Please consider speaking ESPECIALLY if you haven't done so before. If you are worried about whether your idea is good enough: don't. Just submit your idea to the CFP -- you don't have to write-up the presentation in order to submit an idea, just write a paragraph or two about what you want to do -- and the track chairpersons (chairpeople?[1]) will decide whether or not to include your presentation in the event. (And chances are good that if you submit an idea it will be accepted.) Please reply to the users list with any questions you may have about ApacheCon, the Tomcat track, or submitting a talk proposal. Thanks, -chris On behalf of all ApacheCon 2022 Tomcat Track chairpersons [1] https://vignette.wikia.nocookie.net/rickandmorty/images/c/cd/Furniture.png/revision/latest/scale-to-width-down/1000?cb=20160910223642 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] ApacheCon NA 2022 in New Orleans, 3-6 Oct 2022, CFP is OPEN!
Coty, On 5/23/22 15:22, Coty Sutherland wrote: On Fri, Apr 29, 2022 at 2:53 PM Christopher Schultz < ch...@christopherschultz.net> wrote: All, Please remember that the ApacheCon North American conference is still accepting presentations until 23 May 2022. The Tomcat track currently has *zero* proposals, and we were hoping to fill a 3-day track. So please, send in your ideas for presentations! How are we doing now? I just submitted one with the hopes of submitting a second, but I think one is about all I can handle at the moment... jfclere proposed 4 talks and it looks like remm added another 2. I guess yours is the 7th. (I can't actually see the submitter names right now). I haven't done any, yet (I was going to wait to see what else showed up). The CFP is officially over today, so I'll probably drop 3a few in there, too. I'm sad to see that no non-committers submitted anything. Maybe its just that people aren't ready to travel/conference quite yet. -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.79
All, On 5/16/22 12:13, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.79 release is now available for voting. The notable changes compared to 8.5.78 are: - Provide a property source that sources values from Kubernetes service bindings. Provided by Sumit Kulhadia and Gareth Evans. - The root cause of the Linux kernel duplicate accept bug has been identified along with the version of the kernel that includes the fix. The error message displayed when this bug occurs has been updated to reflect this new information and to advise users to update to a version of the OS that uses kernel 5.10 or later. Thanks to Christopher Gual for the research into this issue. - Update the packaged version of the Tomcat Native Library to 1.2.33 to pick up Windows binaries built with OpenSSL 1.1.1o. - Add support for encrypted PKCS#1 formatted private keys when configuring the internal, in memory key store. Along with lots of other bug fixes and improvements. For full details, see the changelog: https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.79/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1375 The tag is: https://github.com/apache/tomcat/tree/8.5.79 1af5f227ae591e601a9426d3788bf6a60a1b75a3 The proposed 8.5.79 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.79 (stable) Works with a boring servlet-based application in a development environment. Note: test failures appear to be due to a bug in the JDK itself and can be ignored. -chris Details: * Environment * Java (build): openjdk version "1.8.0_292" OpenJDK Runtime Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit Server VM (build 25.292-b10, mixed mode) * Java (test): openjdk version "1.8.0_292" OpenJDK Runtime Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit Server VM (build 25.292-b10, mixed mode) * OS: Linux 4.19.0-20-amd64 x86_64 * cc: cc (Debian 8.3.0-6) 8.3.0 * make: GNU Make 4.2.1 * OpenSSL: OpenSSL 1.1.1 11 Sep 2018 * APR: 1.6.5 * * Valid SHA-512 signature for apache-tomcat-8.5.79.zip * Valid GPG signature for apache-tomcat-8.5.79.zip * Valid SHA-512 signature for apache-tomcat-8.5.79.tar.gz * Valid GPG signature for apache-tomcat-8.5.79.tar.gz * Valid SHA-512 signature for apache-tomcat-8.5.79.exe * Valid GPG signature for apache-tomcat-8.5.79.exe * Valid Windows Digital Signature for apache-tomcat-8.5.79.exe * Valid SHA512 signature for apache-tomcat-8.5.79-src.zip * Valid GPG signature for apache-tomcat-8.5.79-src.zip * Valid SHA512 signature for apache-tomcat-8.5.79-src.tar.gz * Valid GPG signature for apache-tomcat-8.5.79-src.tar.gz * * Binary Zip and tarball: Same * Source Zip and tarball: Same * * Building dependencies returned: 0 * tcnative builds cleanly * Tomcat builds cleanly * Junit Tests: FAILED * * Tests that failed: * org.apache.tomcat.util.net.jsse.TestPEMFile.APR.txt * org.apache.tomcat.util.net.jsse.TestPEMFile.NIO.txt * org.apache.tomcat.util.net.jsse.TestPEMFile.NIO2.txt - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [ANN] ApacheCon NA 2022 in New Orleans, 3-6 Oct 2022, CFP is OPEN!
On Fri, Apr 29, 2022 at 2:53 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > All, > > Please remember that the ApacheCon North American conference is still > accepting presentations until 23 May 2022. > > The Tomcat track currently has *zero* proposals, and we were hoping to > fill a 3-day track. > > So please, send in your ideas for presentations! > How are we doing now? I just submitted one with the hopes of submitting a second, but I think one is about all I can handle at the moment...
Re: Plans for Tomcat Native
Hi all, I've started to look at this and I think we need a slightly broader plan. Hence this post to discuss it before I do to much work on it. It looks like we are going to need to support OpenSSL 1.1.1 in some form for quite some time. We are also going to need to support OpenSSL 3.0.x. Then there is LibreSSL. That appears to have been forked from OpenSSL 1.0.2 and hasn't kept completely in sync with subsequent API changes. I really don't want to have to support what are essentially three different APIs to the native SSL library. But I'd like to try and keep support for LibreSSL. Then there is the long term plan to reduce the Native library to the minimum required for NIO(2)+OpenSSL. It appears that LibreSSL does include most/all (TBC) of the API required for NIO(2)+OpenSSL. Given the above I am now thinking about the following plan. Tomcat Native main becomes 2.0.x where: - requires OpenSSL 3.0.x - requires APR 1.7.0 (or not at all) - can be built with LibreSSL (TBC) - drops all the native code apart from that required for NIO(2)+OpenSSL - is the minimum Tomcat Native version required by 10.1.x - provides FIPS support for 3.0.x Tomcat Native 1.2.x continues in a (low) maintenance mode - No changes to minimum versions - Security fixes - Releases to pick up newer OpenSSL versions for Windows binaries My aim would be for it to be possible to use Tomcat Native 2.0.x with Tomcat 9.0.x and earlier, provided it was only used for NIO(2)+OpenSSL. Trying to use APR or any of the other native code would result in an error. Optionally, at some point in the future, 1.2.x gets replaced by 1.3.x that increases minimum versions to OpenSSL 1.1.1 and APR 1.6.3. I'm not sure about this and what it means for OpenSSL 1.x and FIPS support. That said, that code is no longer supported by OpenSSL so it may not be a concern. Thoughts on the updated plan. Suggestions for a different approach? Mark On 23/05/2022 11:52, Mark Thomas wrote: Hi all, A question on the users list about Tomcat Native, OpenSSL 3.0 FIPs caused me to take a look at the current state of supported versions. The detail is here: https://github.com/apache/tomcat-native/blob/main/native/srclib/VERSIONS The planned transition to Tomcat Native 1.3 never happened in April 2021 so I'd like to propose the following: - Create a 1.2.x branch from current main - main becomes 1.3.x - 1.3.x is updated to require at least OpenSSL 1.1.1 - 1.3.x is updated to require at least APR 1.6.3 - Update 1.3.x to support OpenSSL 3.x in FIPS mode - Update 10.1.x to require at least Tomcat Native 1.3.x 1.2.x releases will continue until we have a stable 1.3x release. Thoughts? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Plans for Tomcat Native
On Mon, May 23, 2022 at 6:52 AM Mark Thomas wrote: > Hi all, > > A question on the users list about Tomcat Native, OpenSSL 3.0 FIPs > caused me to take a look at the current state of supported versions. > > The detail is here: > https://github.com/apache/tomcat-native/blob/main/native/srclib/VERSIONS > > The planned transition to Tomcat Native 1.3 never happened in April 2021 > so I'd like to propose the following: > > - Create a 1.2.x branch from current main > - main becomes 1.3.x > - 1.3.x is updated to require at least OpenSSL 1.1.1 > - 1.3.x is updated to require at least APR 1.6.3 > - Update 1.3.x to support OpenSSL 3.x in FIPS mode > - Update 10.1.x to require at least Tomcat Native 1.3.x > > 1.2.x releases will continue until we have a stable 1.3x release. > > Thoughts? > +1
[tomcat-native] branch 1.2.x created (now c283658d9)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 1.2.x in repository https://gitbox.apache.org/repos/asf/tomcat-native.git at c283658d9 Update version info No new revisions were added by this update. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [tomcat] branch main updated: Refactor to remove syncs on SocketWrapper to support Loom experiments
On 23/05/2022 17:27, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 0a94801588 Refactor to remove syncs on SocketWrapper to support Loom experiments 0a94801588 is described below commit 0a9480158874ea910a4d629d24f31d69d6cc5f96 Author: Mark Thomas AuthorDate: Mon May 23 17:27:24 2022 +0100 Refactor to remove syncs on SocketWrapper to support Loom experiments From what has been posted on dev@, I think this should be sufficient for folks that want to explore loom to get started. I strongly suspect further changes will be required as those experimenting with loom expand the range of Tomcat features they want to use. My thinking is we address any additional refactoring as the need for it is identified. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Refactor to remove syncs on SocketWrapper to support Loom experiments
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 0a94801588 Refactor to remove syncs on SocketWrapper to support Loom
experiments
0a94801588 is described below
commit 0a9480158874ea910a4d629d24f31d69d6cc5f96
Author: Mark Thomas
AuthorDate: Mon May 23 17:27:24 2022 +0100
Refactor to remove syncs on SocketWrapper to support Loom experiments
---
java/org/apache/coyote/AbstractProcessor.java | 7 ++-
.../apache/coyote/http2/Http2UpgradeHandler.java | 73 +++---
.../tomcat/util/net/SocketProcessorBase.java | 7 ++-
.../apache/tomcat/util/net/SocketWrapperBase.java | 7 +++
webapps/docs/changelog.xml | 9 +++
5 files changed, 80 insertions(+), 23 deletions(-)
diff --git a/java/org/apache/coyote/AbstractProcessor.java
b/java/org/apache/coyote/AbstractProcessor.java
index 699a935eb6..50743ffece 100644
--- a/java/org/apache/coyote/AbstractProcessor.java
+++ b/java/org/apache/coyote/AbstractProcessor.java
@@ -23,6 +23,7 @@ import java.util.Iterator;
import java.util.concurrent.RejectedExecutionException;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicReference;
+import java.util.concurrent.locks.Lock;
import jakarta.servlet.RequestDispatcher;
import jakarta.servlet.ServletConnection;
@@ -865,7 +866,9 @@ public abstract class AbstractProcessor extends
AbstractProcessorLight implement
SocketWrapperBase socketWrapper = getSocketWrapper();
Iterator dispatches = getIteratorAndClearDispatches();
if (socketWrapper != null) {
-synchronized (socketWrapper) {
+Lock lock = socketWrapper.getLock();
+lock.lock();
+try {
/*
* This method is called when non-blocking IO is initiated by
defining
* a read and/or write listener in a non-container thread. It
is called
@@ -888,6 +891,8 @@ public abstract class AbstractProcessor extends
AbstractProcessorLight implement
DispatchType dispatchType = dispatches.next();
socketWrapper.processSocket(dispatchType.getSocketStatus(), false);
}
+} finally {
+lock.unlock();
}
}
}
diff --git a/java/org/apache/coyote/http2/Http2UpgradeHandler.java
b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
index 64ad129b40..c143149c3c 100644
--- a/java/org/apache/coyote/http2/Http2UpgradeHandler.java
+++ b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
@@ -335,12 +335,15 @@ class Http2UpgradeHandler extends AbstractStream
implements InternalHttpUpgradeH
try {
switch(status) {
case OPEN_READ:
-synchronized (socketWrapper) {
+socketWrapper.getLock().lock();
+try {
if (!socketWrapper.canWrite()) {
// Only send a ping if there is no other data waiting
to be sent.
// Ping manager will ensure they aren't sent too
frequently.
pingManager.sendPing(false);
}
+} finally {
+socketWrapper.getLock().unlock();
}
try {
// There is data to read so use the read timeout while
@@ -567,12 +570,15 @@ class Http2UpgradeHandler extends AbstractStream
implements InternalHttpUpgradeH
// may see out of order RST frames which may hard to follow if
// the client is unaware the RST frames may be received out of
// order.
-synchronized (socketWrapper) {
+socketWrapper.getLock().lock();
+try {
if (state != null) {
state.sendReset();
}
socketWrapper.write(true, rstFrame, 0, rstFrame.length);
socketWrapper.flush(true);
+} finally {
+socketWrapper.getLock().unlock();
}
}
@@ -658,7 +664,8 @@ class Http2UpgradeHandler extends AbstractStream implements
InternalHttpUpgradeH
byte[] payloadLength = new byte[3];
ByteUtil.setThreeBytes(payloadLength, 0, len);
-synchronized (socketWrapper) {
+socketWrapper.getLock().lock();
+try {
socketWrapper.write(true, payloadLength, 0, payloadLength.length);
socketWrapper.write(true, GOAWAY, 0, GOAWAY.length);
socketWrapper.write(true, fixedPayload, 0, 8);
@@ -666,14 +673,19 @@ class Http2UpgradeHandler extends AbstractStream
implements InternalHttpUpgradeH
socketWrapper.write(true, debugMsg, 0, debugMsg.length);
}
socketWrapper.flush(true);
+} finally {
+
[Bug 66076] Final block of encrypted response payload not being sent occasionally over TLS
https://bz.apache.org/bugzilla/show_bug.cgi?id=66076 --- Comment #8 from Phil Clay --- Thanks Mark! I'll get the test started today. The test will need to run for a while before I'm confident in the fix. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Plans for Tomcat Native
On Mon, May 23, 2022 at 12:52 PM Mark Thomas wrote: > > Hi all, > > A question on the users list about Tomcat Native, OpenSSL 3.0 FIPs > caused me to take a look at the current state of supported versions. > > The detail is here: > https://github.com/apache/tomcat-native/blob/main/native/srclib/VERSIONS > > The planned transition to Tomcat Native 1.3 never happened in April 2021 > so I'd like to propose the following: > > - Create a 1.2.x branch from current main > - main becomes 1.3.x > - 1.3.x is updated to require at least OpenSSL 1.1.1 > - 1.3.x is updated to require at least APR 1.6.3 > - Update 1.3.x to support OpenSSL 3.x in FIPS mode > - Update 10.1.x to require at least Tomcat Native 1.3.x > > 1.2.x releases will continue until we have a stable 1.3x release. > > Thoughts? +1 Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Plans for Tomcat Native
Sounds like a healthy plan. +1 On Mon, May 23, 2022 at 03:52 Mark Thomas wrote: > Hi all, > > A question on the users list about Tomcat Native, OpenSSL 3.0 FIPs > caused me to take a look at the current state of supported versions. > > The detail is here: > https://github.com/apache/tomcat-native/blob/main/native/srclib/VERSIONS > > The planned transition to Tomcat Native 1.3 never happened in April 2021 > so I'd like to propose the following: > > - Create a 1.2.x branch from current main > - main becomes 1.3.x > - 1.3.x is updated to require at least OpenSSL 1.1.1 > - 1.3.x is updated to require at least APR 1.6.3 > - Update 1.3.x to support OpenSSL 3.x in FIPS mode > - Update 10.1.x to require at least Tomcat Native 1.3.x > > 1.2.x releases will continue until we have a stable 1.3x release. > > Thoughts? > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
[tomcat] branch 8.5.x updated: Remove unnecessary code
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new c05ed11868 Remove unnecessary code
c05ed11868 is described below
commit c05ed11868e1ec64424f593fba417c7e6db7ba9c
Author: Mark Thomas
AuthorDate: Mon May 23 12:12:11 2022 +0100
Remove unnecessary code
---
java/org/apache/catalina/core/StandardThreadExecutor.java | 12
1 file changed, 12 deletions(-)
diff --git a/java/org/apache/catalina/core/StandardThreadExecutor.java
b/java/org/apache/catalina/core/StandardThreadExecutor.java
index 6e18c61852..9d83c51f35 100644
--- a/java/org/apache/catalina/core/StandardThreadExecutor.java
+++ b/java/org/apache/catalina/core/StandardThreadExecutor.java
@@ -96,12 +96,6 @@ public class StandardThreadExecutor extends
LifecycleMBeanBase
// -- Public Methods
-@Override
-protected void initInternal() throws LifecycleException {
-super.initInternal();
-}
-
-
/**
* Start the component and implement the requirements
* of {@link org.apache.catalina.util.LifecycleBase#startInternal()}.
@@ -141,12 +135,6 @@ public class StandardThreadExecutor extends
LifecycleMBeanBase
}
-@Override
-protected void destroyInternal() throws LifecycleException {
-super.destroyInternal();
-}
-
-
@Override
@Deprecated
public void execute(Runnable command, long timeout, TimeUnit unit) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Remove unnecessary code
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 4567a4075e Remove unnecessary code
4567a4075e is described below
commit 4567a4075e43652fe3a6e78fbedc26970d918d5b
Author: Mark Thomas
AuthorDate: Mon May 23 12:12:11 2022 +0100
Remove unnecessary code
---
java/org/apache/catalina/core/StandardThreadExecutor.java | 12
1 file changed, 12 deletions(-)
diff --git a/java/org/apache/catalina/core/StandardThreadExecutor.java
b/java/org/apache/catalina/core/StandardThreadExecutor.java
index 6e18c61852..9d83c51f35 100644
--- a/java/org/apache/catalina/core/StandardThreadExecutor.java
+++ b/java/org/apache/catalina/core/StandardThreadExecutor.java
@@ -96,12 +96,6 @@ public class StandardThreadExecutor extends
LifecycleMBeanBase
// -- Public Methods
-@Override
-protected void initInternal() throws LifecycleException {
-super.initInternal();
-}
-
-
/**
* Start the component and implement the requirements
* of {@link org.apache.catalina.util.LifecycleBase#startInternal()}.
@@ -141,12 +135,6 @@ public class StandardThreadExecutor extends
LifecycleMBeanBase
}
-@Override
-protected void destroyInternal() throws LifecycleException {
-super.destroyInternal();
-}
-
-
@Override
@Deprecated
public void execute(Runnable command, long timeout, TimeUnit unit) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.0.x updated: Remove unnecessary code
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.0.x by this push:
new 2d589d125d Remove unnecessary code
2d589d125d is described below
commit 2d589d125de0abf43da8eb8b04bd18a613fd043c
Author: Mark Thomas
AuthorDate: Mon May 23 12:12:11 2022 +0100
Remove unnecessary code
---
java/org/apache/catalina/core/StandardThreadExecutor.java | 12
1 file changed, 12 deletions(-)
diff --git a/java/org/apache/catalina/core/StandardThreadExecutor.java
b/java/org/apache/catalina/core/StandardThreadExecutor.java
index 6e18c61852..9d83c51f35 100644
--- a/java/org/apache/catalina/core/StandardThreadExecutor.java
+++ b/java/org/apache/catalina/core/StandardThreadExecutor.java
@@ -96,12 +96,6 @@ public class StandardThreadExecutor extends
LifecycleMBeanBase
// -- Public Methods
-@Override
-protected void initInternal() throws LifecycleException {
-super.initInternal();
-}
-
-
/**
* Start the component and implement the requirements
* of {@link org.apache.catalina.util.LifecycleBase#startInternal()}.
@@ -141,12 +135,6 @@ public class StandardThreadExecutor extends
LifecycleMBeanBase
}
-@Override
-protected void destroyInternal() throws LifecycleException {
-super.destroyInternal();
-}
-
-
@Override
@Deprecated
public void execute(Runnable command, long timeout, TimeUnit unit) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Remove unnecessary code
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 02611f118d Remove unnecessary code
02611f118d is described below
commit 02611f118d3baf0c63f8d8a233247da4e95681ae
Author: Mark Thomas
AuthorDate: Mon May 23 12:12:11 2022 +0100
Remove unnecessary code
---
java/org/apache/catalina/core/StandardThreadExecutor.java | 12
1 file changed, 12 deletions(-)
diff --git a/java/org/apache/catalina/core/StandardThreadExecutor.java
b/java/org/apache/catalina/core/StandardThreadExecutor.java
index 7f926108c8..09c34fb4a4 100644
--- a/java/org/apache/catalina/core/StandardThreadExecutor.java
+++ b/java/org/apache/catalina/core/StandardThreadExecutor.java
@@ -96,12 +96,6 @@ public class StandardThreadExecutor extends
LifecycleMBeanBase
// -- Public Methods
-@Override
-protected void initInternal() throws LifecycleException {
-super.initInternal();
-}
-
-
/**
* Start the component and implement the requirements
* of {@link org.apache.catalina.util.LifecycleBase#startInternal()}.
@@ -141,12 +135,6 @@ public class StandardThreadExecutor extends
LifecycleMBeanBase
}
-@Override
-protected void destroyInternal() throws LifecycleException {
-super.destroyInternal();
-}
-
-
@Override
public void execute(Runnable command) {
if (executor != null) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Plans for Tomcat Native
Hi all, A question on the users list about Tomcat Native, OpenSSL 3.0 FIPs caused me to take a look at the current state of supported versions. The detail is here: https://github.com/apache/tomcat-native/blob/main/native/srclib/VERSIONS The planned transition to Tomcat Native 1.3 never happened in April 2021 so I'd like to propose the following: - Create a 1.2.x branch from current main - main becomes 1.3.x - 1.3.x is updated to require at least OpenSSL 1.1.1 - 1.3.x is updated to require at least APR 1.6.3 - Update 1.3.x to support OpenSSL 3.x in FIPS mode - Update 10.1.x to require at least Tomcat Native 1.3.x 1.2.x releases will continue until we have a stable 1.3x release. Thoughts? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #514: Registry gives inaccurate log message saying "Creating MBeanServer ... " after already created the MBeanServer
markt-asf commented on PR #514: URL: https://github.com/apache/tomcat/pull/514#issuecomment-1134492314 I don't see any issues with those changes. PRs aren't the way to provide updates to these strings. Please use POEditor as described here: https://cwiki.apache.org/confluence/display/TOMCAT/Managing+translations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66076] Final block of encrypted response payload not being sent occasionally over TLS
https://bz.apache.org/bugzilla/show_bug.cgi?id=66076 --- Comment #7 from Mark Thomas --- A 9.0.x dev build is available here: https://people.apache.org/~markt/dev/v9.0.64-dev-b311c0a/ Usual caveats apply. This isn't an official release. Use at your own risk. It is the standard release layout so the JARs you want will be in bin/embed/apache-tomcat-9.0.64-dev-b311c0a-embed.tar.gz -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix BZ 66076. Non-blocking flush with TLS+NIO must flush network buffer
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new b311c0a0ac Fix BZ 66076. Non-blocking flush with TLS+NIO must flush
network buffer
b311c0a0ac is described below
commit b311c0a0acc33d0d6530c92e6b1f0f5906b62144
Author: Mark Thomas
AuthorDate: Mon May 23 10:17:02 2022 +0100
Fix BZ 66076. Non-blocking flush with TLS+NIO must flush network buffer
https://bz.apache.org/bugzilla/show_bug.cgi?id=66076
---
java/org/apache/tomcat/util/net/NioEndpoint.java | 24 ++
.../apache/tomcat/util/net/SocketWrapperBase.java | 14 +
webapps/docs/changelog.xml | 9
3 files changed, 43 insertions(+), 4 deletions(-)
diff --git a/java/org/apache/tomcat/util/net/NioEndpoint.java
b/java/org/apache/tomcat/util/net/NioEndpoint.java
index 78f4d3ca53..b8b6d4339d 100644
--- a/java/org/apache/tomcat/util/net/NioEndpoint.java
+++ b/java/org/apache/tomcat/util/net/NioEndpoint.java
@@ -1345,20 +1345,20 @@ public class NioEndpoint extends
AbstractJsseEndpoint
@Override
protected boolean flushNonBlocking() throws IOException {
-boolean dataLeft = !socketBufferHandler.isWriteBufferEmpty();
+boolean dataLeft = socketOrNetworkBufferHasDataLeft();
// Write to the socket, if there is anything to write
if (dataLeft) {
doWrite(false);
-dataLeft = !socketBufferHandler.isWriteBufferEmpty();
+dataLeft = socketOrNetworkBufferHasDataLeft();
}
if (!dataLeft && !nonBlockingWriteBuffer.isEmpty()) {
dataLeft = nonBlockingWriteBuffer.write(this, false);
-if (!dataLeft && !socketBufferHandler.isWriteBufferEmpty()) {
+if (!dataLeft && socketOrNetworkBufferHasDataLeft()) {
doWrite(false);
-dataLeft = !socketBufferHandler.isWriteBufferEmpty();
+dataLeft = socketOrNetworkBufferHasDataLeft();
}
}
@@ -1366,6 +1366,22 @@ public class NioEndpoint extends
AbstractJsseEndpoint
}
+/*
+ * https://bz.apache.org/bugzilla/show_bug.cgi?id=66076
+ *
+ * When using TLS an additional buffer is used for the encrypted data
+ * before it is written to the network. It is possible for this network
+ * output buffer to contain data while the socket write buffer is
empty.
+ *
+ * For NIO with non-blocking I/O, this case is handling by ensuring
that
+ * flush only returns false (i.e. no data left to flush) if all buffers
+ * are empty.
+ */
+private boolean socketOrNetworkBufferHasDataLeft() {
+return !socketBufferHandler.isWriteBufferEmpty() ||
getSocket().getOutboundRemaining() > 0;
+}
+
+
@Override
protected void doWrite(boolean block, ByteBuffer buffer) throws
IOException {
int n = 0;
diff --git a/java/org/apache/tomcat/util/net/SocketWrapperBase.java
b/java/org/apache/tomcat/util/net/SocketWrapperBase.java
index 67a6d0f08d..bcb0119fc6 100644
--- a/java/org/apache/tomcat/util/net/SocketWrapperBase.java
+++ b/java/org/apache/tomcat/util/net/SocketWrapperBase.java
@@ -722,6 +722,12 @@ public abstract class SocketWrapperBase {
}
+/**
+ * Writes all remaining data from the buffers and blocks until the write is
+ * complete.
+ *
+ * @throws IOException If an IO error occurs during the write
+ */
protected void flushBlocking() throws IOException {
doWrite(true);
@@ -736,6 +742,14 @@ public abstract class SocketWrapperBase {
}
+/**
+ * Writes as much data as possible from any that remains in the buffers.
+ *
+ * @return true if data remains to be flushed after this
method
+ * completes, otherwise false.
+ *
+ * @throws IOException If an IO error occurs during the write
+ */
protected abstract boolean flushNonBlocking() throws IOException;
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 5e6fa49603..24c8a20c36 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -126,6 +126,15 @@
+
+
+
+66076: When using TLS with non-blocking writes and the NIO
+connector, ensure that flushing the buffers attempts to empty all of
the
+output buffers. (markt)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Reminder: ApacheCon Asia 2022 CFP closes on May 31st
Hi All, Just a kind reminder that the CALL FOR PRESENTATIONS of ApacheCon Asia 2022 closes at 8 AM (Beijing Time), May 31st. Please do not wait until the last minute. :) Details: https://apachecon.com/acasia2022/cfp.html The event is completely virtual and the talk is pre-recorded. The presentation could be either in English or in Chinese. Submission: https://shimo.im/forms/6ZTBLanjqW8pY3dj/fill?channel=website -- Best Regards！ Huxing - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
