Re: [VOTE] Release Apache Tomcat Native 1.2.38

2023-08-06 Thread Han Li



> On Aug 2, 2023, at 18:08, Mark Thomas  wrote:
> 
> Version 1.2.38 includes the following changes compared to 1.2.37
> 
> - Align default pass phrase prompt with HTTPd
> - The windows binaries in this release have been built with OpenSSL
>  1.1.1v and APR 1.7.4
> 
> The proposed release artifacts can be found at [1],
> and the build was done using tag [2].
> 
> The Apache Tomcat Native 1.2.38 release is
> [ X] Stable, go ahead and release
> [ ] Broken because of ...

Han
> 
> Thanks,
> 
> Mark
> 
> 
> [1]
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.38
> [2] 
> https://github.com/apache/tomcat-native/tree/79282a056db1cf624cac11a4f014b4a9e72058bd
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 8.5.x updated: Tighter validation to debug Gump failure

2023-08-06 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 8ebf1f455d Tighter validation to debug Gump failure
8ebf1f455d is described below

commit 8ebf1f455ddf496f003b0d7601bd53488fd57175
Author: Mark Thomas 
AuthorDate: Sun Aug 6 13:14:14 2023 +0100

Tighter validation to debug Gump failure
---
 test/org/apache/coyote/http2/TestHttp2Section_6_9.java | 14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/test/org/apache/coyote/http2/TestHttp2Section_6_9.java 
b/test/org/apache/coyote/http2/TestHttp2Section_6_9.java
index 176c669cef..966bf88d24 100644
--- a/test/org/apache/coyote/http2/TestHttp2Section_6_9.java
+++ b/test/org/apache/coyote/http2/TestHttp2Section_6_9.java
@@ -93,12 +93,20 @@ public class TestHttp2Section_6_9 extends Http2TestBase {
 // Default connection window size is 64k - 1. Initial request will have
 // used 8k (56k -1).
 
-// Use up the remaining connection window. These requests require 56k
-// but there is only 56k - 1 available.
-for (int i = 3; i < 17; i += 2) {
+// Use up the remaining connection window. These requests require 48k.
+for (int i = 3; i < 15; i += 2) {
 sendSimpleGetRequest(i);
 readSimpleGetResponse();
+Assert.assertEquals(getSimpleResponseTrace(i), output.getTrace());
+output.clearTrace();
 }
+// This request requires 8k but there is only 8k-1 available
+sendSimpleGetRequest(15);
+readSimpleGetResponse();
+String expected = getResponseBodyFrameTrace(15, 200, 
"application/octet-stream", null, "8191", "8192");
+// No end of stream
+expected = expected.substring(0, expected.length() - 
"15-EndOfStream\n".length());
+Assert.assertEquals(expected, output.getTrace());
 output.clearTrace();
 
 // It should be possible to send a request that generates an empty


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 9.0.x updated: Tighter validation to debug Gump failure

2023-08-06 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new bfd87b1214 Tighter validation to debug Gump failure
bfd87b1214 is described below

commit bfd87b1214de50c515358692f6e5afac5ae9e383
Author: Mark Thomas 
AuthorDate: Sun Aug 6 13:14:14 2023 +0100

Tighter validation to debug Gump failure
---
 test/org/apache/coyote/http2/TestHttp2Section_6_9.java | 14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/test/org/apache/coyote/http2/TestHttp2Section_6_9.java 
b/test/org/apache/coyote/http2/TestHttp2Section_6_9.java
index 176c669cef..966bf88d24 100644
--- a/test/org/apache/coyote/http2/TestHttp2Section_6_9.java
+++ b/test/org/apache/coyote/http2/TestHttp2Section_6_9.java
@@ -93,12 +93,20 @@ public class TestHttp2Section_6_9 extends Http2TestBase {
 // Default connection window size is 64k - 1. Initial request will have
 // used 8k (56k -1).
 
-// Use up the remaining connection window. These requests require 56k
-// but there is only 56k - 1 available.
-for (int i = 3; i < 17; i += 2) {
+// Use up the remaining connection window. These requests require 48k.
+for (int i = 3; i < 15; i += 2) {
 sendSimpleGetRequest(i);
 readSimpleGetResponse();
+Assert.assertEquals(getSimpleResponseTrace(i), output.getTrace());
+output.clearTrace();
 }
+// This request requires 8k but there is only 8k-1 available
+sendSimpleGetRequest(15);
+readSimpleGetResponse();
+String expected = getResponseBodyFrameTrace(15, 200, 
"application/octet-stream", null, "8191", "8192");
+// No end of stream
+expected = expected.substring(0, expected.length() - 
"15-EndOfStream\n".length());
+Assert.assertEquals(expected, output.getTrace());
 output.clearTrace();
 
 // It should be possible to send a request that generates an empty


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 10.1.x updated: Tighter validation to debug Gump failure

2023-08-06 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.1.x by this push:
 new 62db193a4d Tighter validation to debug Gump failure
62db193a4d is described below

commit 62db193a4d3ce28fd96c065c17ab4f70407c6f9f
Author: Mark Thomas 
AuthorDate: Sun Aug 6 13:14:14 2023 +0100

Tighter validation to debug Gump failure
---
 test/org/apache/coyote/http2/TestHttp2Section_6_9.java | 14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/test/org/apache/coyote/http2/TestHttp2Section_6_9.java 
b/test/org/apache/coyote/http2/TestHttp2Section_6_9.java
index 176c669cef..966bf88d24 100644
--- a/test/org/apache/coyote/http2/TestHttp2Section_6_9.java
+++ b/test/org/apache/coyote/http2/TestHttp2Section_6_9.java
@@ -93,12 +93,20 @@ public class TestHttp2Section_6_9 extends Http2TestBase {
 // Default connection window size is 64k - 1. Initial request will have
 // used 8k (56k -1).
 
-// Use up the remaining connection window. These requests require 56k
-// but there is only 56k - 1 available.
-for (int i = 3; i < 17; i += 2) {
+// Use up the remaining connection window. These requests require 48k.
+for (int i = 3; i < 15; i += 2) {
 sendSimpleGetRequest(i);
 readSimpleGetResponse();
+Assert.assertEquals(getSimpleResponseTrace(i), output.getTrace());
+output.clearTrace();
 }
+// This request requires 8k but there is only 8k-1 available
+sendSimpleGetRequest(15);
+readSimpleGetResponse();
+String expected = getResponseBodyFrameTrace(15, 200, 
"application/octet-stream", null, "8191", "8192");
+// No end of stream
+expected = expected.substring(0, expected.length() - 
"15-EndOfStream\n".length());
+Assert.assertEquals(expected, output.getTrace());
 output.clearTrace();
 
 // It should be possible to send a request that generates an empty


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch main updated: Tighter validation to debug Gump failure

2023-08-06 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 21f904f1cb Tighter validation to debug Gump failure
21f904f1cb is described below

commit 21f904f1cb32e34a7b5d4c0dff949027947d3029
Author: Mark Thomas 
AuthorDate: Sun Aug 6 13:14:14 2023 +0100

Tighter validation to debug Gump failure
---
 test/org/apache/coyote/http2/TestHttp2Section_6_9.java | 14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/test/org/apache/coyote/http2/TestHttp2Section_6_9.java 
b/test/org/apache/coyote/http2/TestHttp2Section_6_9.java
index 176c669cef..966bf88d24 100644
--- a/test/org/apache/coyote/http2/TestHttp2Section_6_9.java
+++ b/test/org/apache/coyote/http2/TestHttp2Section_6_9.java
@@ -93,12 +93,20 @@ public class TestHttp2Section_6_9 extends Http2TestBase {
 // Default connection window size is 64k - 1. Initial request will have
 // used 8k (56k -1).
 
-// Use up the remaining connection window. These requests require 56k
-// but there is only 56k - 1 available.
-for (int i = 3; i < 17; i += 2) {
+// Use up the remaining connection window. These requests require 48k.
+for (int i = 3; i < 15; i += 2) {
 sendSimpleGetRequest(i);
 readSimpleGetResponse();
+Assert.assertEquals(getSimpleResponseTrace(i), output.getTrace());
+output.clearTrace();
 }
+// This request requires 8k but there is only 8k-1 available
+sendSimpleGetRequest(15);
+readSimpleGetResponse();
+String expected = getResponseBodyFrameTrace(15, 200, 
"application/octet-stream", null, "8191", "8192");
+// No end of stream
+expected = expected.substring(0, expected.length() - 
"15-EndOfStream\n".length());
+Assert.assertEquals(expected, output.getTrace());
 output.clearTrace();
 
 // It should be possible to send a request that generates an empty


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat Native 1.2.38

2023-08-06 Thread Mark Thomas

This VOTE needs at least two more PMC member votes to pass.

Mark


On 02/08/2023 11:08, Mark Thomas wrote:

Version 1.2.38 includes the following changes compared to 1.2.37

- Align default pass phrase prompt with HTTPd
- The windows binaries in this release have been built with OpenSSL
   1.1.1v and APR 1.7.4

The proposed release artifacts can be found at [1],
and the build was done using tag [2].

The Apache Tomcat Native 1.2.38 release is
  [ ] Stable, go ahead and release
  [ ] Broken because of ...

Thanks,

Mark


[1]
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.38
[2] 
https://github.com/apache/tomcat-native/tree/79282a056db1cf624cac11a4f014b4a9e72058bd


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat Native 2.0.5

2023-08-06 Thread Mark Thomas

This VOTE needs at least one more PMC member vote to pass.

Mark

On 01/08/2023 19:24, Mark Thomas wrote:

The key differences of version 2.0.5 compared to 2.0.4 are:

- Align default pass phrase prompt with HTTPd
- Update autotools and associated fixes
- Fix memory leak in SNI processing
- The windows binaries in this release have been built with OpenSSL
   3.0.10 and APR 1.7.4

The 2.0.x branch is primarily intended for use with Tomcat 10.1.x 
onwards but can be used with earlier versions as long as the APR/native 
connector is not used.


The proposed release artifacts can be found at [1],
and the build was done using tag [2].

The Apache Tomcat Native 2.0.5 release is
  [ ] Stable, go ahead and release
  [ ] Broken because of ...

Thanks,

Mark


[1]
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/2.0.5
[2] 
https://github.com/apache/tomcat-native/commit/7b3d702481bc9198e958b88a1f6028b9be5de4ff


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 66842] Http2AsyncUpgradeHandler does not update overhead count based on sent frames

2023-08-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66842

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #1 from Mark Thomas  ---
Fixed in:
- 11.0.x for 11.0.0-M10 onwards
- 10.1.x for 10.1.12 onwards
-  9.0.x for  9.0.79 onwards

8.5.x was unaffected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 9.0.x updated: Fix BZ 66842 - include DATA frames in overhead count with async

2023-08-06 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new c551ecaa1b Fix BZ 66842 - include DATA frames in overhead count with 
async
c551ecaa1b is described below

commit c551ecaa1ba4ffe50a67009a9c94efb03439ae8b
Author: Mark Thomas 
AuthorDate: Sun Aug 6 12:44:07 2023 +0100

Fix BZ 66842 - include DATA frames in overhead count with async

https://bz.apache.org/bugzilla/show_bug.cgi?id=66842
---
 java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java | 3 +++
 java/org/apache/coyote/http2/Http2UpgradeHandler.java  | 2 +-
 webapps/docs/changelog.xml | 5 +
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java 
b/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java
index d9f69464f6..5c5c494357 100644
--- a/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java
+++ b/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java
@@ -227,6 +227,9 @@ public class Http2AsyncUpgradeHandler extends 
Http2UpgradeHandler {
 log.debug(sm.getString("upgradeHandler.writeBody", connectionId, 
stream.getIdAsString(),
 Integer.toString(len), Boolean.valueOf(finished)));
 }
+
+reduceOverheadCount(FrameType.DATA);
+
 // Need to check this now since sending end of stream will change this.
 boolean writable = stream.canWrite();
 byte[] header = new byte[9];
diff --git a/java/org/apache/coyote/http2/Http2UpgradeHandler.java 
b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
index 4975e8f82d..d8e04d04da 100644
--- a/java/org/apache/coyote/http2/Http2UpgradeHandler.java
+++ b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
@@ -1375,7 +1375,7 @@ class Http2UpgradeHandler extends AbstractStream 
implements InternalHttpUpgradeH
 }
 
 
-private void reduceOverheadCount(FrameType frameType) {
+void reduceOverheadCount(FrameType frameType) {
 // A non-overhead frame reduces the overhead count by
 // Http2Protocol.DEFAULT_OVERHEAD_REDUCTION_FACTOR. A simple browser
 // request is likely to have one non-overhead frame (HEADERS) and one
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index b30faa3777..abb82adbaa 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -165,6 +165,11 @@
 called after an error during asynchronous processing with HTTP/2.
 (markt)
   
+  
+66842: When using asynchronous I/O (the default for NIO and
+NIO2), include DATA frames when calculating the HTTP/2 overhead count 
to
+ensure that connections are not prematurely terminated. (markt)
+  
 
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 10.1.x updated: Fix BZ 66842 - include DATA frames in overhead count with async

2023-08-06 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.1.x by this push:
 new 9efe006642 Fix BZ 66842 - include DATA frames in overhead count with 
async
9efe006642 is described below

commit 9efe0066424117673ec5b719e3aab10b0cead890
Author: Mark Thomas 
AuthorDate: Sun Aug 6 12:44:07 2023 +0100

Fix BZ 66842 - include DATA frames in overhead count with async

https://bz.apache.org/bugzilla/show_bug.cgi?id=66842
---
 java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java | 3 +++
 java/org/apache/coyote/http2/Http2UpgradeHandler.java  | 2 +-
 webapps/docs/changelog.xml | 5 +
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java 
b/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java
index 0a0868d477..d551bbc6ab 100644
--- a/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java
+++ b/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java
@@ -228,6 +228,9 @@ public class Http2AsyncUpgradeHandler extends 
Http2UpgradeHandler {
 log.debug(sm.getString("upgradeHandler.writeBody", connectionId, 
stream.getIdAsString(),
 Integer.toString(len), Boolean.valueOf(finished)));
 }
+
+reduceOverheadCount(FrameType.DATA);
+
 // Need to check this now since sending end of stream will change this.
 boolean writable = stream.canWrite();
 byte[] header = new byte[9];
diff --git a/java/org/apache/coyote/http2/Http2UpgradeHandler.java 
b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
index bf8be7cf83..137d009fd6 100644
--- a/java/org/apache/coyote/http2/Http2UpgradeHandler.java
+++ b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
@@ -1381,7 +1381,7 @@ class Http2UpgradeHandler extends AbstractStream 
implements InternalHttpUpgradeH
 }
 
 
-private void reduceOverheadCount(FrameType frameType) {
+void reduceOverheadCount(FrameType frameType) {
 // A non-overhead frame reduces the overhead count by
 // Http2Protocol.DEFAULT_OVERHEAD_REDUCTION_FACTOR. A simple browser
 // request is likely to have one non-overhead frame (HEADERS) and one
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 44c53200cf..c446f608db 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -144,6 +144,11 @@
 called after an error during asynchronous processing with HTTP/2.
 (markt)
   
+  
+66842: When using asynchronous I/O (the default), include
+DATA frames when calculating the HTTP/2 overhead count to ensure that
+connections are not prematurely terminated. (markt)
+  
 
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch main updated: Fix BZ 66842 - include DATA frames in overhead count with async

2023-08-06 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new ca9f5c51c6 Fix BZ 66842 - include DATA frames in overhead count with 
async
ca9f5c51c6 is described below

commit ca9f5c51c63f87a5901f8be254d86342c944571b
Author: Mark Thomas 
AuthorDate: Sun Aug 6 12:44:07 2023 +0100

Fix BZ 66842 - include DATA frames in overhead count with async

https://bz.apache.org/bugzilla/show_bug.cgi?id=66842
---
 java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java | 3 +++
 java/org/apache/coyote/http2/Http2UpgradeHandler.java  | 2 +-
 webapps/docs/changelog.xml | 5 +
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java 
b/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java
index 0a0868d477..d551bbc6ab 100644
--- a/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java
+++ b/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java
@@ -228,6 +228,9 @@ public class Http2AsyncUpgradeHandler extends 
Http2UpgradeHandler {
 log.debug(sm.getString("upgradeHandler.writeBody", connectionId, 
stream.getIdAsString(),
 Integer.toString(len), Boolean.valueOf(finished)));
 }
+
+reduceOverheadCount(FrameType.DATA);
+
 // Need to check this now since sending end of stream will change this.
 boolean writable = stream.canWrite();
 byte[] header = new byte[9];
diff --git a/java/org/apache/coyote/http2/Http2UpgradeHandler.java 
b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
index e648d4dace..8b6c53bad5 100644
--- a/java/org/apache/coyote/http2/Http2UpgradeHandler.java
+++ b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
@@ -1381,7 +1381,7 @@ class Http2UpgradeHandler extends AbstractStream 
implements InternalHttpUpgradeH
 }
 
 
-private void reduceOverheadCount(FrameType frameType) {
+void reduceOverheadCount(FrameType frameType) {
 // A non-overhead frame reduces the overhead count by
 // Http2Protocol.DEFAULT_OVERHEAD_REDUCTION_FACTOR. A simple browser
 // request is likely to have one non-overhead frame (HEADERS) and one
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 993af03a15..7491ef84c1 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -165,6 +165,11 @@
 called after an error during asynchronous processing with HTTP/2.
 (markt)
   
+  
+66842: When using asynchronous I/O (the default), include
+DATA frames when calculating the HTTP/2 overhead count to ensure that
+connections are not prematurely terminated. (markt)
+  
 
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 66841] Memory leak from cancelled async http/2 streams

2023-08-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66841

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #3 from Mark Thomas  ---
Fixed in:
- 11.0.x for 11.0.0-M10 onwards
- 10.1.x for 10.1.12 onwards
-  9.0.x for  9.0.79 onwards
-  8.5.x for  8.5.92 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on a diff in pull request #641: Add DESTROYED state (if DESTROYED we are already STOPPED).

2023-08-06 Thread via GitHub


markt-asf commented on code in PR #641:
URL: https://github.com/apache/tomcat/pull/641#discussion_r1285192745


##
java/org/apache/catalina/startup/HostConfig.java:
##
@@ -154,6 +154,16 @@ public class HostConfig implements LifecycleListener {
  */
 protected final Set invalidWars = new HashSet<>();
 
+/**
+ *  Tell that we are in check()
+ */
+protected volatile boolean isDoingCheck = false;
+
+/**
+ *  Tell that we are stopping (set after event beforestop).
+ */
+protected volatile boolean isDoingStop = false;
+

Review Comment:
   Needs to correctly handle a sequence start, stop, start, stop etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat Modules [2023/08/06]

2023-08-06 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen|
|51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho|
|51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods   |
|52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o|
|53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe|
|54437|New|Enh|2013-01-16|Update PoolProperties javadoc for ConnectState int|
|54929|Inf|Nor|2013-05-05|jdbc-pool cannot be used with Java 1.5, "java.lang|
|55078|New|Nor|2013-06-07|Configuring a DataSource Resource with dataSourceJ|
|55662|New|Enh|2013-10-17|Add a way to set an instance of java.sql.Driver di|
|56046|New|Enh|2014-01-21|org.apache.tomcat.jdbc.pool.XADataSource InitSQL p|
|56088|New|Maj|2014-01-29|AbstractQueryReport$StatementProxy throws exceptio|
|56310|Inf|Maj|2014-03-25|PooledConnection and XAConnection not handled corr|
|56586|New|Nor|2014-06-02|initSQL should be committed if defaultAutoCommit =|
|56775|New|Nor|2014-07-28|PoolCleanerTime schedule issue|
|56779|New|Nor|2014-07-28|Allow multiple connection initialization statement|
|56790|New|Nor|2014-07-29|Resizing pool.maxActive to a higher value at runti|
|56798|New|Nor|2014-07-31|Idle eviction strategy could perform better (and i|
|56804|New|Nor|2014-08-02|Use a default validationQueryTimeout other than "f|
|56805|New|Nor|2014-08-02|datasource.getConnection() may be unnecessarily bl|
|56837|New|Nor|2014-08-11|if validationQuery have error with timeBetweenEvic|
|56970|New|Nor|2014-09-11|MaxActive vs. MaxTotal for commons-dbcp and tomcat|
|57460|New|Nor|2015-01-19|[DB2]Connection broken after few hours but not rem|
|57729|New|Enh|2015-03-20|Add QueryExecutionReportInterceptor to log query e|
|58489|Opn|Maj|2015-10-08|QueryStatsComparator throws IllegalArgumentExcepti|
|59077|New|Nor|2016-02-26|DataSourceFactory creates a neutered data source  |
|59569|New|Nor|2016-05-18|isWrapperFor/unwrap implementations incorrect |
|59879|New|Nor|2016-07-18|StatementCache interceptor returns ResultSet objec|
|60195|New|Nor|2016-10-02|No javadoc in Maven Central   |
|60522|New|Nor|2016-12-27|An option for setting if the transaction should be|
|60524|Inf|Nor|2016-12-28|NPE in SlowQueryReport in tomcat-jdbc-7.0.68  |
|60645|New|Nor|2017-01-25|StatementFinalizer is not thread-safe |
|61032|New|Nor|2017-04-24|min pool size is not being respected  |
|61103|New|Nor|2017-05-18|StatementCache potentially caching non-functional |
|61302|New|Enh|2017-07-15|Refactoring of DataSourceProxy|
|61303|New|Enh|2017-07-15|Refactoring of ConnectionPool |
|62432|New|Nor|2018-06-06|Memory Leak in Statement Finalizer?   |
|62598|New|Enh|2018-08-04|support pool with multiple JDBC data sources  |
|62910|Inf|Nor|2018-11-15|tomcat-jdbc global pool transaction problem   |
|63612|Inf|Cri|2019-07-26|PooledConnection#connectUsingDriver, Thread.curren|
|63705|New|Nor|2019-08-29|The tomcat pool doesn't register all connection th|
|64083|New|Nor|2020-01-17|JDBC pool keeps closed connection as available|
|64107|New|Maj|2020-01-30|PreparedStatements correctly closed are not return|
|64231|New|Nor|2020-03-16|Tomcat jdbc pool behaviour|
|64570|New|Nor|2020-07-01|Transaction not rollbacked if autocommit is false |
|64809|New|Nor|2020-10-13|Connection properties not reset to defaults when C|
|65347|New|Nor|2021-06-02|The equals method from statements generated by the|
|65929|New|Nor|2022-03-03|Connection is not released on Connection.abort() c|
|66502|New|Enh|2023-03-01|tomcat-jdbc ConnectionPool.returnConnection() acce|
+-+---+---+--+--+
| Total   48 bugs   |
+---+


Bug report for Tomcat 9 [2023/08/06]

2023-08-06 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|53602|Ver|Enh|2012-07-25|Support for HTTP status code 451  |
|57505|New|Enh|2015-01-27|Add integration tests for JspC|
|58530|New|Enh|2015-10-23|Proposal for new Manager HTML GUI |
|58548|Inf|Enh|2015-10-26|support certifcate transparency   |
|58859|New|Enh|2016-01-14|Allow to limit charsets / encodings supported by T|
|59750|New|Enh|2016-06-24|Amend "authenticate" method with context by means |
|60997|New|Enh|2017-04-17|Enhance SemaphoreValve to support denied status an|
|61971|New|Enh|2018-01-06|documentation for using tomcat with systemd   |
|62048|New|Enh|2018-01-25|Missing logout function in Manager and Host-Manage|
|62072|New|Enh|2018-02-01|Add support for request compression   |
|62405|New|Enh|2018-05-23|Add Rereadable Request Filter |
|62488|New|Enh|2018-06-25|Obtain dependencies from Maven Central where possi|
|62611|Inf|Enh|2018-08-09|Compress log files after rotation |
|62773|New|Enh|2018-09-28|Change DeltaManager to handle session deserializat|
|62814|New|Enh|2018-10-10|Use readable names for cluster channel/map options|
|62843|New|Enh|2018-10-22|Tomcat Russian localization   |
|62964|Inf|Enh|2018-11-29|Add RFC7807 conformant Problem Details for HTTP st|
|63023|New|Enh|2018-12-20|Provide a way to load SecurityProviders into the s|
|63049|New|Enh|2018-12-31|Add support in system properties override from com|
|63237|New|Enh|2019-03-06|Consider processing mbeans-descriptors.xml at comp|
|63389|New|Enh|2019-04-27|Enable Servlet Warmup for Containerization|
|63493|New|Enh|2019-06-10|enhancement - add JMX counters to monitor authenti|
|63505|New|Enh|2019-06-14|enhancement - support of stored procedures for Dat|
|63545|New|Enh|2019-07-06|enhancement - add a new pattern attribute for logg|
|63943|Opn|Enh|2019-11-20|Add possibility to overwrite remote port with info|
|63983|Ver|Cri|2019-12-03|Jasper builds-up open files until garbage collecti|
|64230|New|Enh|2020-03-15|Allow to configure session manager to skip expirin|
|64395|New|Enh|2020-04-30|Windows Installer should offer an option to select|
|65208|New|Enh|2021-03-29|Multi-threaded loading of servlets|
|65302|New|Enh|2021-05-12|Add support for setting com.sun.jndi.ldap.tls.cbty|
|65778|Opn|Enh|2022-01-01|Don't create URL from string  |
|65779|Inf|Enh|2022-01-01|Introduce CATALINA_BASE_DATA  |
|66592|Opn|Enh|2023-05-04|Support for HTTPS proxy in websocket client   |
|66631|New|Enh|2023-06-07|Consider moving module-info.class to META-INF/vers|
|66647|New|Enh|2023-06-14|Analyze usefulness and consider deprecation of cer|
|66654|New|Enh|2023-06-16|Setting displayname while using service.bat to ins|
|66670|Inf|Enh|2023-06-26|Add SSLHostConfig#certificateKeyPasswordFile  |
|66706|Inf|Nor|2023-07-19|The name of jar is different with the artifactId i|
|66841|New|Reg|2023-08-03|Memory leak from cancelled async http/2 streams   |
|66842|New|Nor|2023-08-03|Http2AsyncUpgradeHandler does not update overhead |
+-+---+---+--+--+
| Total   40 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat 8 [2023/08/06]

2023-08-06 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|55243|New|Enh|2013-07-11|Add special search string for nested roles|
|55470|New|Enh|2013-08-23|Help users for ClassNotFoundExceptions during star|
|55477|New|Enh|2013-08-23|Add a solution to map a realm name to a security r|
|55675|New|Enh|2013-10-18|Checking and handling invalid configuration option|
|55788|New|Enh|2013-11-16|TagPlugins should key on tag QName rather than imp|
|56148|New|Enh|2014-02-17|support (multiple) ocsp stapling  |
|56166|New|Enh|2014-02-20|Suggestions for exception handling (avoid potentia|
|56300|New|Enh|2014-03-22|[Tribes] No useful examples, lack of documentation|
|56398|New|Enh|2014-04-11|Support Arquillian-based unit testing |
|56402|New|Enh|2014-04-11|Add support for HTTP Upgrade to AJP components|
|56438|New|Enh|2014-04-21|If jar scan does not find context config or TLD co|
|56546|New|Enh|2014-05-19|Improve thread trace logging in WebappClassLoader.|
|56614|New|Enh|2014-06-12|Add a switch to ignore annotations detection on ta|
|56713|New|Enh|2014-07-12|Limit time that incoming request waits while webap|
|56787|New|Enh|2014-07-29|Simplified jndi name parsing  |
|57129|Opn|Enh|2014-10-22|Regression. Load WEB-INF/lib jarfiles in alphabeti|
|57130|New|Enh|2014-10-22|Allow digest.sh to accept password from a file or |
|57367|New|Enh|2014-12-18|If JAR scan experiences a stack overflow, give the|
|57421|New|Enh|2015-01-07|Farming default directories   |
|57486|New|Enh|2015-01-23|Improve reuse of ProtectedFunctionMapper instances|
|57701|New|Enh|2015-03-13|Implement "[Redeploy]" button for a web applicatio|
|57827|New|Enh|2015-04-17|Enable adding/removing of members via jmx in a sta|
|57830|New|Enh|2015-04-18|Add support for ProxyProtocol |
|57872|New|Enh|2015-04-29|Do not auto-switch session cookie to version=1 due|
|58052|Opn|Enh|2015-06-19|RewriteValve: Implement additional RewriteRule dir|
|58072|New|Enh|2015-06-23|ECDH curve selection  |
|58935|Opn|Enh|2016-01-29|Re-deploy from war without deleting context   |
|60849|New|Enh|2017-03-13|Tomcat NIO Connector not able to handle SSL renego|
|61877|New|Enh|2017-12-08|use web.xml from CATALINA_HOME by default |
|62214|New|Enh|2018-03-22|The "userSubtree=true" and "roleSubtree=true" in J|
|63080|New|Enh|2019-01-16|Support rfc7239 Forwarded header  |
|63167|New|Enh|2019-02-12|Network Requirements To Resolve No Members Active |
|63195|Inf|Enh|2019-02-21|Add easy way to test RemoteIpValve works properly |
|65809|New|Enh|2022-01-19|Reduce memory footprint for long-lasting WebSocket|
+-+---+---+--+--+
| Total   34 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Taglibs [2023/08/06]

2023-08-06 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field   |
|38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)|
|42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements   |
|46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l|
|48333|New|Enh|2009-12-02|TLD generator |
|57548|New|Min|2015-02-08|Auto-generate the value for org.apache.taglibs.sta|
|57684|New|Min|2015-03-10|Version info should be taken from project version |
|59359|New|Enh|2016-04-20|(Task) Extend validity period for signing KEY - be|
|59668|New|Nor|2016-06-06|x:forEach retains the incorrect scope when used in|
|61875|New|Nor|2017-12-08|Investigate whether Xalan can be removed  |
|64649|New|Nor|2020-08-06|XSLT transformation - document('') doesn't return |
|65491|New|Nor|2021-08-09|Behavior differences with c:import when flushing o|
+-+---+---+--+--+
| Total   12 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat Connectors [2023/08/06]

2023-08-06 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca|
|47327|New|Enh|2009-06-07|Return tomcat authenticated user back to mod_jk (A|
|47750|New|Maj|2009-08-27|ISAPI: Loss of worker settings when changing via j|
|48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv|
|49822|New|Enh|2010-08-25|Add hash lb worker method |
|49903|New|Enh|2010-09-09|Make workers file reloadable  |
|52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus|
|54621|New|Enh|2013-02-28|[PATCH] custom mod_jk availability checks |
|56489|New|Enh|2014-05-05|Include a directory for configuration files   |
|56576|New|Enh|2014-05-29|Websocket support |
|57402|New|Enh|2014-12-30|Provide correlation ID between mod_jk log and acce|
|57403|New|Enh|2014-12-30|Persist configuration changes made via status work|
|57407|New|Enh|2014-12-31|Make session_cookie, session_path and session_cook|
|57790|New|Enh|2015-04-03|Check worker names for typos  |
|61476|New|Enh|2017-09-01|Allow reset of an individual worker stat value|
|61621|New|Enh|2017-10-15|Content-Type is forced to lowercase when it goes t|
|62093|New|Enh|2018-02-09|Allow use_server_errors to apply to specific statu|
|63808|Inf|Enh|2019-10-05|the fact that JkMount makes other directives ineff|
|64775|Inf|Nor|2020-09-28|mod_jk is sending both Content-Length and Transfer|
|65488|Inf|Nor|2021-08-08|Destroy method is not being called during Failover|
|65901|New|Nor|2022-02-20|HTTP 401 response for a HEAD request violates HTTP|
|66005|New|Nor|2022-04-11|Apache crashes, if there is a tomcat server, which|
+-+---+---+--+--+
| Total   22 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat 10 [2023/08/06]

2023-08-06 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|64353|New|Enh|2020-04-15|Add support for accessing server certificate from |
|64549|New|Enh|2020-06-23|create a project module to launch Tomcat in OSGi  |
|64550|New|Enh|2020-06-23|create a project module to launch Tomcat in JPMS  |
|65124|New|Enh|2021-02-03|Inefficient generated JSP code|
|65267|New|Enh|2021-04-27|Implement mod_headers like filter |
|65391|New|Enh|2021-06-19|Additional user attributes queried by (some) realm|
|65635|New|Enh|2021-10-15|Methods to return auth errors |
|65770|New|Enh|2021-12-28|Make keys reload automatically|
|66125|New|Enh|2022-06-16|JMProxy - enhance security restrictions   |
|66191|New|Enh|2022-08-01|compile taglibs that are not (yet) included in jsp|
|66406|New|Enh|2023-01-02|JULI ClassLoaderLogManager creates multiple logger|
|66613|Ver|Enh|2023-05-23|Developing wiki page: Unclear reference to "servic|
|66616|Ver|Nor|2023-05-26|French: Misleading HTTP 401 error description ("La|
|66676|Inf|Nor|2023-06-30|WebSocket session complains about closed state whe|
+-+---+---+--+--+
| Total   14 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug report for Tomcat Native [2023/08/06]

2023-08-06 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|62911|New|Enh|2018-11-15|Add support for proxying ocsp  requests via ProxyH|
|64826|New|Maj|2020-10-19|libtcnative prompts for private key password in so|
|64862|New|Enh|2020-10-30|Improve LibreSSL support  |
|65344|New|Enh|2021-05-31|OpenSSL configuration |
|7|New|Enh|2023-06-23|Take care of OpenSSL deprecated code  |
+-+---+---+--+--+
| Total5 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org