[Bug 68884] Delayed HTTP Traffic Processing After Mass Websocket Disconnect/Reconnect

2024-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68884

--- Comment #4 from Matt M  ---
Thank you for the feedback and completely agree that there are other factors
involved in creating the conditions for this issue to occur.

The intent behind the proposal is to make those scenarios more recoverable when
they do occur and to solicit feedback on if there may be a better way to
accomplish this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68884] Delayed HTTP Traffic Processing After Mass Websocket Disconnect/Reconnect

2024-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68884

Matt M  changed:

   What|Removed |Added

  Attachment #39658|0   |1
is obsolete||

--- Comment #3 from Matt M  ---
Created attachment 39664
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=39664=edit
Proposed patch

Updated format
Diff vs 9.0.86

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.88

2024-04-12 Thread Dimitris Soumis
+1 All tests pass on Fedora 38 with Java 17, tcnative-1.2.39, apr-1.7.4,
openssl-3.0.13.

On Tue, Apr 9, 2024 at 5:03 PM Rémy Maucherat  wrote:

> The proposed Apache Tomcat 9.0.88 release is now available for voting.
>
> The notable changes compared to 9.0.87 are:
>
> - Cookies header generation enhancements.
>
> - Fix regression when reloading TLS configuration and files.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.88/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1489
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.88
> e644d98329aca2ccf7f2014c0670c5fabc7fcb16
>
> The proposed 9.0.88 release is:
> [ ] -1, Broken - do not release
> [X ] +1, Stable - go ahead and release as 9.0.88
>
> Rémy
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


[Bug 68884] Delayed HTTP Traffic Processing After Mass Websocket Disconnect/Reconnect

2024-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68884

--- Comment #2 from Mark Thomas  ---
Patches should be in diff -u form.

The Tomcat team avoids using system properties for configuration unless
absolutely necessary (it isn't necessary here).

Given that this requires a network interruption or stop the world GC of > 35
seconds, I'd argue that if you are dealing with network drop-outs or GC pauses
of that length you have much bigger problems than this issue. Not that we won't
try and fix this issue but it may affect how we address it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 10.1.22

2024-04-12 Thread Dimitris Soumis
+1 All tests pass on Fedora 38 with Java 21, tcnative-2.0.7, openssl-3.0.13.

On Wed, Apr 10, 2024 at 10:02 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed Apache Tomcat 10.1.22 release is now available for
> voting. Apache Tomcat 10.1.21 was canceled due to a release-build
> mistake. There are no source-level changes between 10.1.21 and 10.1.22.
>
> The notable changes compared to 10.1.20 are:
>
> - Add OpenSSL support when FFM is available
>
> - Improve locking strategies in Catalina core
>
> - Updates to Apache Commons dependencies
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.22/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1491
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.22
> fd9c0bb1f0a7e586daabfda625ef50827bcfddf3
>
> Please reply with a +1 for release or -0/-1 with an explanation.
>
> The proposed 10.1.22 release is:
> [ ] Broken - do not release
> [X ] Stable - go ahead and release as 10.1.22
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


[Bug 68889] README.md refers to superseded Tomcat 10.0 version

2024-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68889

Remy Maucherat  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Remy Maucherat  ---
Ok. There were quite a few issues with the readme, most importantly talking
about the old EE. Woops.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch 9.0.x updated: Update

2024-04-12 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new 11fa0211a6 Update
11fa0211a6 is described below

commit 11fa0211a61b2163a0bcc7828a05068567eb98f8
Author: remm 
AuthorDate: Fri Apr 12 14:56:41 2024 +0200

Update
---
 README.md | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/README.md b/README.md
index 6cef104c45..1961da67fa 100644
--- a/README.md
+++ b/README.md
@@ -29,9 +29,9 @@ project logo are trademarks of the Apache Software Foundation.
 For every major Tomcat version there is one download page containing
 links to the latest binary and source code downloads, but also
 links for browsing the download directories and archives:
+- [Tomcat 11](https://tomcat.apache.org/download-11.cgi)
 - [Tomcat 10](https://tomcat.apache.org/download-10.cgi)
 - [Tomcat 9](https://tomcat.apache.org/download-90.cgi)
-- [Tomcat 8](https://tomcat.apache.org/download-80.cgi)
 
 To facilitate choosing the right major Tomcat version one, we have provided a
 [version overview page](https://tomcat.apache.org/whichversion.html).
@@ -42,10 +42,9 @@ The documentation available as of the date of this release is
 included in the docs webapp which ships with tomcat. You can access that webapp
 by starting tomcat and visiting  in your browser.
 The most up-to-date documentation for each version can be found at:
-- [Tomcat 10.1](https://tomcat.apache.org/tomcat-10.1-doc/)
-- [Tomcat 10.0](https://tomcat.apache.org/tomcat-10.0-doc/)
+- [Tomcat 11](https://tomcat.apache.org/tomcat-11.0-doc/)
+- [Tomcat 10](https://tomcat.apache.org/tomcat-10.1-doc/)
 - [Tomcat 9](https://tomcat.apache.org/tomcat-9.0-doc/)
-- [Tomcat 8](https://tomcat.apache.org/tomcat-8.5-doc/)
 
 ### Installation
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch 10.1.x updated: Updates

2024-04-12 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.1.x by this push:
 new 0ea75904cd Updates
0ea75904cd is described below

commit 0ea75904cd3b56356f050419e7c371f22fdaccbc
Author: remm 
AuthorDate: Fri Apr 12 14:52:00 2024 +0200

Updates
---
 README.md | 17 -
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/README.md b/README.md
index 6cef104c45..678db89c97 100644
--- a/README.md
+++ b/README.md
@@ -2,11 +2,11 @@
 
 ### What Is It?
 
-The Apache Tomcat® software is an open source implementation of the Java
-Servlet, JavaServer Pages, Java Expression Language and Java WebSocket
-technologies. The Java Servlet, JavaServer Pages, Java Expression Language and
-Java WebSocket specifications are developed under the
-[Java Community Process](https://jcp.org/en/introduction/overview).
+The Apache Tomcat® software is an open source implementation of the Jakarta
+Servlet, Jakarta Pages, Jakarta Expression Language and Jakarta WebSocket
+technologies. The Jakarta Servlet, Jakarta Server Pages, Jakarta Expression 
Language and
+Jakarta WebSocket specifications are developed as part of the 
+[Jakarta EE Platform](https://jakarta.ee/specifications/).
 
 The Apache Tomcat software is developed in an open and participatory
 environment and released under the
@@ -29,9 +29,9 @@ project logo are trademarks of the Apache Software Foundation.
 For every major Tomcat version there is one download page containing
 links to the latest binary and source code downloads, but also
 links for browsing the download directories and archives:
+- [Tomcat 11](https://tomcat.apache.org/download-11.cgi)
 - [Tomcat 10](https://tomcat.apache.org/download-10.cgi)
 - [Tomcat 9](https://tomcat.apache.org/download-90.cgi)
-- [Tomcat 8](https://tomcat.apache.org/download-80.cgi)
 
 To facilitate choosing the right major Tomcat version one, we have provided a
 [version overview page](https://tomcat.apache.org/whichversion.html).
@@ -42,10 +42,9 @@ The documentation available as of the date of this release is
 included in the docs webapp which ships with tomcat. You can access that webapp
 by starting tomcat and visiting  in your browser.
 The most up-to-date documentation for each version can be found at:
-- [Tomcat 10.1](https://tomcat.apache.org/tomcat-10.1-doc/)
-- [Tomcat 10.0](https://tomcat.apache.org/tomcat-10.0-doc/)
+- [Tomcat 11](https://tomcat.apache.org/tomcat-11.0-doc/)
+- [Tomcat 10](https://tomcat.apache.org/tomcat-10.1-doc/)
 - [Tomcat 9](https://tomcat.apache.org/tomcat-9.0-doc/)
-- [Tomcat 8](https://tomcat.apache.org/tomcat-8.5-doc/)
 
 ### Installation
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch main updated: Switch to Jakarta

2024-04-12 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 8a16506abf Switch to Jakarta
8a16506abf is described below

commit 8a16506abf926dbc2a803de502de7cd6816127f5
Author: remm 
AuthorDate: Fri Apr 12 14:51:21 2024 +0200

Switch to Jakarta
---
 README.md | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/README.md b/README.md
index 1961da67fa..3b4507570e 100644
--- a/README.md
+++ b/README.md
@@ -2,11 +2,11 @@
 
 ### What Is It?
 
-The Apache Tomcat® software is an open source implementation of the Java
-Servlet, JavaServer Pages, Java Expression Language and Java WebSocket
-technologies. The Java Servlet, JavaServer Pages, Java Expression Language and
-Java WebSocket specifications are developed under the
-[Java Community Process](https://jcp.org/en/introduction/overview).
+The Apache Tomcat® software is an open source implementation of the Jakarta
+Servlet, Jakarta Pages, Jakarta Expression Language and Jakarta WebSocket
+technologies. The Jakarta Servlet, Jakarta Pages, Jakarta Expression Language 
and
+Jakarta WebSocket specifications are developed as part of the 
+[Jakarta EE Platform](https://jakarta.ee/specifications/).
 
 The Apache Tomcat software is developed in an open and participatory
 environment and released under the


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch main updated: Update version numbers

2024-04-12 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 4fd19f0297 Update version numbers
4fd19f0297 is described below

commit 4fd19f0297440018ed43473aa637d3969a207fd9
Author: remm 
AuthorDate: Fri Apr 12 14:44:09 2024 +0200

Update version numbers
---
 README.md | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/README.md b/README.md
index 17c7c7c2df..1961da67fa 100644
--- a/README.md
+++ b/README.md
@@ -32,7 +32,6 @@ links for browsing the download directories and archives:
 - [Tomcat 11](https://tomcat.apache.org/download-11.cgi)
 - [Tomcat 10](https://tomcat.apache.org/download-10.cgi)
 - [Tomcat 9](https://tomcat.apache.org/download-90.cgi)
-- [Tomcat 8](https://tomcat.apache.org/download-80.cgi)
 
 To facilitate choosing the right major Tomcat version one, we have provided a
 [version overview page](https://tomcat.apache.org/whichversion.html).
@@ -43,10 +42,9 @@ The documentation available as of the date of this release is
 included in the docs webapp which ships with tomcat. You can access that webapp
 by starting tomcat and visiting  in your browser.
 The most up-to-date documentation for each version can be found at:
-- [Tomcat 11.0](https://tomcat.apache.org/tomcat-11.0-doc/)
+- [Tomcat 11](https://tomcat.apache.org/tomcat-11.0-doc/)
 - [Tomcat 10](https://tomcat.apache.org/tomcat-10.1-doc/)
 - [Tomcat 9](https://tomcat.apache.org/tomcat-9.0-doc/)
-- [Tomcat 8](https://tomcat.apache.org/tomcat-8.5-doc/)
 
 ### Installation
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 11.0.0-M19

2024-04-12 Thread Dimitris Soumis
+1 All tests pass on Fedora 38 with Java 21, tcnative-2.0.7, openssl-3.0.13.

Just to mention that with my laptop under heavy load I got *two consecutive
crashes* when running nio2 TestResolverSSL with the following logs:

[junit] Running org.apache.catalina.valves.rewrite.TestResolverSSL
[junit] 12-Apr-2024 12:50:31.005 INFO [main]
org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
[testSslEnv[JSSE]]
[junit] 12-Apr-2024 12:50:31.407 INFO [main]
org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
["https-jsse-nio2-127.0.0.1-auto-1"]
[junit] 12-Apr-2024 12:50:31.484 INFO [main]
org.apache.tomcat.util.net.AbstractEndpoint.logCertificate Connector
[https-jsse-nio2-127.0.0.1-auto-1], TLS virtual host [_default_],
certificate type [UNDEFINED] configured from keystore
[/home/dsoumis/Downloads/tomcat-11.0.0-M19/test/org/apache/tomcat/util/net/localhost-rsa.jks]
using alias [tomcat] with trust store
[/home/dsoumis/Downloads/tomcat-11.0.0-M19/test/org/apache/tomcat/util/net/ca.jks]
[junit] 12-Apr-2024 12:50:31.493 INFO [main]
org.apache.catalina.core.StandardService.startInternal Starting service
[Tomcat]
[junit] 12-Apr-2024 12:50:31.493 INFO [main]
org.apache.catalina.core.StandardEngine.startInternal Starting Servlet
engine: [Apache Tomcat/11.0.0-M19]
[junit] 12-Apr-2024 12:50:31.530 INFO [main]
org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
["https-jsse-nio2-127.0.0.1-auto-1-43711"]
[junit] [HTTPS] true
[junit] [SSL_PROTOCOL] TLSv1.2
[junit] [SSL_SESSION_ID]
dc891f9599838280d50c3729830e4c7b365c7f2b8526f5a687171eea28f58de0
[junit] [SSL_SESSION_RESUMED] null
[junit] [SSL_SECURE_RENEG] null
[junit] [SSL_CIPHER] TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
[junit] [SSL_CIPHER_EXPORT] false
[junit] [SSL_CIPHER_USEKEYSIZE] 256
[junit] [SSL_CIPHER_ALGKEYSIZE] 256
[junit] [SSL_COMPRESS_METHOD] null
[junit] [SSL_VERSION_INTERFACE] null
[junit] [SSL_VERSION_LIBRARY] null
[junit] [SSL_CLIENT_M_VERSION] 3
[junit] [SSL_CLIENT_M_SERIAL] 4111
[junit] [SSL_CLIENT_S_DN] CN=user1, OU=Apache Tomcat PMC, O=The Apache
Software Foundation, L=Wilmington, ST=DE, C=US
[junit] [SSL_CLIENT_S_DN_CN] user1
[junit] [SSL_CLIENT_S_DN_O] The Apache Software Foundation
[junit] [SSL_CLIENT_S_DN_C] US
[junit] [SSL_CLIENT_SAN_Email_0] null
[junit] [SSL_CLIENT_SAN_DNS_0] null
[junit] [SSL_CLIENT_SAN_OTHER_msUPN_0] null
[junit] [SSL_CLIENT_I_DN] CN=Apache Tomcat Test CA,OU=Apache Tomcat
PMC,O=The Apache Software Foundation,L=Wakefield,ST=MA,C=US
[junit] [SSL_CLIENT_I_DN_CN] Apache Tomcat Test CA
[junit] [SSL_CLIENT_I_DN_O] The Apache Software Foundation
[junit] [SSL_CLIENT_I_DN_C] US
[junit] [SSL_CLIENT_V_START] 1692196363000
[junit] [SSL_CLIENT_V_END] 1755268363000
[junit] [SSL_CLIENT_V_REMAIN] 490
[junit] [SSL_CLIENT_A_SIG] SHA256withRSA
[junit] [SSL_CLIENT_A_KEY] RSA
[junit] [SSL_CLIENT_CERT] -BEGIN CERTIFICATE-
[junit] MIIFHzCCAwegAwIBAgICEA8wDQYJKoZIhvcNAQELBQAwgZMxCzAJBgNVBAYTAlVT
[junit] 12-Apr-2024 12:50:31.753 INFO [main]
org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler
["https-jsse-nio2-127.0.0.1-auto-1-43711"]
[junit] 12-Apr-2024 12:50:31.753 INFO [main]
org.apache.catalina.core.StandardService.stopInternal Stopping service
[Tomcat]
[junit] 12-Apr-2024 12:50:31.763 INFO [main]
org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler
["https-jsse-nio2-127.0.0.1-auto-1-43711"]
[junit] 12-Apr-2024 12:50:31.764 INFO [main]
org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
["https-jsse-nio2-127.0.0.1-auto-1-43711"]
[junit] 12-Apr-2024 12:50:31.770 INFO [main]
org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
[testSslEnv[OpenSSL]]
[junit] MQswCQYDVQQIEwJNQTESMBAGA1UEBxMJV2FrZWZpZWxkMScwJQYDVQQKEx5UaGUg
[junit] 12-Apr-2024 12:50:31.775 INFO [main]
org.apache.catalina.core.AprLifecycleListener.lifecycleEvent Loaded Apache
Tomcat Native library [2.0.7] using APR version [1.7.4].
[junit] QXBhY2hlIFNvZnR3YXJlIEZvdW5kYXRpb24xGjAYBgNVBAsTEUFwYWNoZSBUb21j
[junit] 12-Apr-2024 12:50:31.777 INFO [main]
org.apache.catalina.core.AprLifecycleListener.initializeSSL OpenSSL
successfully initialized [OpenSSL 3.0.13 30 Jan 2024]
[junit] YXQgUE1DMR4wHAYDVQQDExVBcGFjaGUgVG9tY2F0IFRlc3QgQ0EwHhcNMjMwODE2
[junit] MTQzMjQzWhcNMjUwODE1MTQzMjQzWjCBhDELMAkGA1UEBhMCVVMxCzAJBgNVBAgT
[junit] 12-Apr-2024 12:50:31.778 INFO [main]
org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
["https-openssl-nio2-127.0.0.1-auto-2"]
[junit] AkRFMRMwEQYDVQQHEwpXaWxtaW5ndG9uMScwJQYDVQQKEx5UaGUgQXBhY2hlIFNv
[junit] ZnR3YXJlIEZvdW5kYXRpb24xGjAYBgNVBAsTEUFwYWNoZSBUb21jYXQgUE1DMQ4w
[junit] 12-Apr-2024 12:50:31.790 INFO [main]
org.apache.tomcat.util.net.AbstractEndpoint.logCertificate Connector
[https-openssl-nio2-127.0.0.1-auto-2], TLS virtual host 

[Bug 68890] New: Several JSPs in the manage application have contradicting encoding

2024-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68890

Bug ID: 68890
   Summary: Several JSPs in the manage application have
contradicting encoding
   Product: Tomcat 11
   Version: 11.0.0-M18
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Manager
  Assignee: dev@tomcat.apache.org
  Reporter: micha...@apache.org
  Target Milestone: ---

This also applies to other versions of Tomcat.
List the JSP files:
osipovmi@deblndw011x:~/var/Projekte/tomcat (main *=)
$ find webapps/manager -name \*.jsp
webapps/manager/WEB-INF/jsp/401.jsp
webapps/manager/WEB-INF/jsp/403.jsp
webapps/manager/WEB-INF/jsp/404.jsp
webapps/manager/WEB-INF/jsp/sessionDetail.jsp
webapps/manager/WEB-INF/jsp/sessionsList.jsp
webapps/manager/WEB-INF/jsp/connectorCerts.jsp
webapps/manager/WEB-INF/jsp/connectorCiphers.jsp
webapps/manager/WEB-INF/jsp/connectorTrustedCerts.jsp
webapps/manager/index.jsp

and open them. Many have the XML prolog set "", but set the output encoding to
 <%@page session="false" contentType="text/html; charset=ISO-8859-1" %>
 

This is weird and it should be consistently one encoding, the prolog and those
JSP/HTML tags.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68890] Several JSPs in the manage application have contradicting encoding

2024-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68890

Michael Osipov  changed:

   What|Removed |Added

 CC||micha...@apache.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68889] README.md refers to superseded Tomcat 10.0 version

2024-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68889

Michael Osipov  changed:

   What|Removed |Added

 CC||micha...@apache.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68889] New: README.md refers to superseded Tomcat 10.0 version

2024-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68889

Bug ID: 68889
   Summary: README.md refers to superseded Tomcat 10.0 version
   Product: Tomcat 10
   Version: 10.1.20
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Documentation
  Assignee: dev@tomcat.apache.org
  Reporter: micha...@apache.org
  Target Milestone: --

In main
https://github.com/apache/tomcat/blob/fa1cc930c5627c30581a1dbd81be05014a47cdd2/README.md?plain=1#L47
refers only to 10.1, but in the others:
*
https://github.com/apache/tomcat/blob/86b7beeb8eb52ef8854fe4dacaf639279075e0ed/README.md?plain=1#L46
*
https://github.com/apache/tomcat/blob/a41afc8e804835e5c20b37d48e4a339e398fdc1c/README.md?plain=1#L46
*
https://github.com/apache/tomcat/blob/3ca0410760b992ffdbf684f53397190ed0e23bbe/README.md?plain=1#L46

Still refer to an superseded version. I belive that this block should be
consistent throughout versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 11.0.0-M19

2024-04-12 Thread Rémy Maucherat
On Tue, Apr 9, 2024 at 3:13 PM Rémy Maucherat  wrote:
>
> The proposed Apache Tomcat 11.0.0-M19 release is now available for
> voting.
>
> Apache Tomcat 11.0.0-M19 is a milestone release of the 11.0.x branch and
> has been made to provide users with early access to the new features in
> Apache Tomcat 11.0.x so that they may provide feedback. The notable
> changes compared to the previous milestone include:
>
> - Finalize update to the Jakarta EE 11 specifications.
>
> - Cookies header generation enhancements.
>
> - Fix regression when reloading TLS configuration and files.
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-11.0.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 11
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory. Applications using deprecated APIs may require
> further changes.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-11/v11.0.0-M19/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1488
>
> The tag is:
> https://github.com/apache/tomcat/tree/11.0.0-M19
> 19e301275f23056e3c46ab296c87cf6e16fbe68f
>
> The proposed 11.0.0-M19 release is:
> [ ] -1 Broken - do not release
> [X] +1 Alpha  - go ahead and release as 11.0.0-M19

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.88

2024-04-12 Thread Rémy Maucherat
On Tue, Apr 9, 2024 at 3:54 PM Rémy Maucherat  wrote:
>
> The proposed Apache Tomcat 9.0.88 release is now available for voting.
>
> The notable changes compared to 9.0.87 are:
>
> - Cookies header generation enhancements.
>
> - Fix regression when reloading TLS configuration and files.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.88/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1489
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.88
> e644d98329aca2ccf7f2014c0670c5fabc7fcb16
>
> The proposed 9.0.88 release is:
> [ ] -1, Broken - do not release
> [X] +1, Stable - go ahead and release as 9.0.88

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68884] Delayed HTTP Traffic Processing After Mass Websocket Disconnect/Reconnect

2024-04-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68884

Michael Osipov  changed:

   What|Removed |Added

  Attachment #39658|1   |0
   is patch||

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 10.1.22

2024-04-12 Thread Rémy Maucherat
On Thu, Apr 11, 2024 at 7:22 PM Rainer Jung  wrote:
>
> Am 10.04.24 um 20:51 schrieb Christopher Schultz:
> > The proposed Apache Tomcat 10.1.22 release is now available for
> > voting. Apache Tomcat 10.1.21 was canceled due to a release-build
> > mistake. There are no source-level changes between 10.1.21 and 10.1.22.
> >
> > The notable changes compared to 10.1.20 are:
> >
> > - Add OpenSSL support when FFM is available
> >
> > - Improve locking strategies in Catalina core
> >
> > - Updates to Apache Commons dependencies
> >
> > For full details, see the change log:
> > https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
> >
> > Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> > without changes. Java EE applications designed for Tomcat 9 and earlier
> > may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> > will automatically convert them to Jakarta EE and copy them to the
> > webapps directory.
> >
> > It can be obtained from:
> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.22/
> >
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1491
> >
> > The tag is:
> > https://github.com/apache/tomcat/tree/10.1.22
> > fd9c0bb1f0a7e586daabfda625ef50827bcfddf3
> >
> > Please reply with a +1 for release or -0/-1 with an explanation.
> >
> > The proposed 10.1.22 release is:
> > [X] Broken - do not release
> > [ ] Stable - go ahead and release as 10.1.22
>
> Unfortunately it seems broken.
>
> Commit 6550e203a8119683f38c182cbfbb9b56587c54a0 introduced the use of
> --enable-native-access to the catalina script, which I think breaks 10.1
> on Java 11, since the flag was introduced later.

It is trivial to address by a user though.

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [PR] Sessioncounter [tomcat]

2024-04-12 Thread via GitHub


rmaucher commented on PR #713:
URL: https://github.com/apache/tomcat/pull/713#issuecomment-2051302240

   Thanks for pointing this out. Since tracking too many redundant stats is not 
super useful, I decided to remove this one (it is now approximated by adding 
the active sessions to the expired sessions).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [PR] Sessioncounter [tomcat]

2024-04-12 Thread via GitHub


rmaucher closed pull request #713: Sessioncounter
URL: https://github.com/apache/tomcat/pull/713


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch main updated: Update version numbers, remove Tomcat 8.5

2024-04-12 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new fa1cc930c5 Update version numbers, remove Tomcat 8.5
fa1cc930c5 is described below

commit fa1cc930c5627c30581a1dbd81be05014a47cdd2
Author: remm 
AuthorDate: Fri Apr 12 09:42:05 2024 +0200

Update version numbers, remove Tomcat 8.5
---
 .github/workflows/ci.yml | 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 4867591919..a4a5788c37 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -18,7 +18,6 @@ on:
   - main
   - 10.1.x
   - 9.0.x
-  - 8.5.x
   pull_request:
 branches:
   - main
@@ -33,17 +32,13 @@ jobs:
   matrix:
 isMain:
   - ${{ contains(github.ref, 'main') }}
-java: [ 17, 20, 21 ]
+java: [ 17, 21, 22 ]
 os: [ ubuntu-latest, windows-latest ]
 exclude:
   - isMain: true
 java: 17
-  - isMain: true
-java: 20
-  - os: windows-latest
-java: 20
   - os: windows-latest
-java: 21
+java: 22
 name: JDK${{ matrix.java }} ${{ matrix.os }}
 runs-on: ${{ matrix.os }}
 steps:


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



(tomcat) branch main updated: Remove deprecated items

2024-04-12 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 56fc7a8f40 Remove deprecated items
56fc7a8f40 is described below

commit 56fc7a8f40490cb4d1cc32bc3be74d9415b78613
Author: remm 
AuthorDate: Fri Apr 12 09:21:06 2024 +0200

Remove deprecated items
---
 java/org/apache/catalina/Manager.java | 10 --
 java/org/apache/catalina/session/ManagerBase.java | 43 ---
 2 files changed, 53 deletions(-)

diff --git a/java/org/apache/catalina/Manager.java 
b/java/org/apache/catalina/Manager.java
index b8438b1150..ed52490b33 100644
--- a/java/org/apache/catalina/Manager.java
+++ b/java/org/apache/catalina/Manager.java
@@ -85,16 +85,6 @@ public interface Manager {
 long getSessionCounter();
 
 
-/**
- * Sets the total number of sessions created by this manager.
- *
- * @param sessionCounter Total number of sessions created by this manager.
- * @deprecated This will be removed in Tomcat 11
- */
-@Deprecated
-void setSessionCounter(long sessionCounter);
-
-
 /**
  * Gets the maximum number of sessions that have been active at the same
  * time.
diff --git a/java/org/apache/catalina/session/ManagerBase.java 
b/java/org/apache/catalina/session/ManagerBase.java
index 68bb0195d7..54845485ae 100644
--- a/java/org/apache/catalina/session/ManagerBase.java
+++ b/java/org/apache/catalina/session/ManagerBase.java
@@ -127,13 +127,6 @@ public abstract class ManagerBase extends 
LifecycleMBeanBase implements Manager
  */
 protected Map sessions = new ConcurrentHashMap<>();
 
-/**
- * Number of sessions created by this manager.
- * @deprecated This will be removed in Tomcat 11
- */
-@Deprecated
-protected long sessionCounter = 0;
-
 protected volatile int maxActive = 0;
 
 private final Object maxActiveUpdateLock = new Object();
@@ -148,13 +141,6 @@ public abstract class ManagerBase extends 
LifecycleMBeanBase implements Manager
  */
 protected int rejectedSessions = 0;
 
-/**
- * Number of duplicated session ids, anything > 0 means we have problems.
- * @deprecated This will be removed in Tomcat 11
- */
-@Deprecated
-protected volatile int duplicates = 0;
-
 /**
  * Processing time during session expiration.
  */
@@ -892,41 +878,12 @@ public abstract class ManagerBase extends 
LifecycleMBeanBase implements Manager
 //  Package Methods
 
 
-@Override
-public void setSessionCounter(long sessionCounter) {
-this.sessionCounter = sessionCounter;
-}
-
-
 @Override
 public long getSessionCounter() {
 return getActiveSessions() + getExpiredSessions();
 }
 
 
-/**
- * Number of duplicated session IDs generated by the random source. 
Anything bigger than 0 means problems.
- *
- * @return The count of duplicates
- * @deprecated This will be removed in Tomcat 11
- */
-@Deprecated
-public int getDuplicates() {
-return duplicates;
-}
-
-
-/**
- * Set duplicates count.
- * @param duplicates the new duplicates count
- * @deprecated This will be removed in Tomcat 11
- */
-@Deprecated
-public void setDuplicates(int duplicates) {
-this.duplicates = duplicates;
-}
-
-
 @Override
 public int getActiveSessions() {
 return sessions.size();


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org