[jira] [Commented] (MTOMCAT-177) tomcat7:deploy ignores proxy settings

2016-04-05 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227660#comment-15227660
 ] 

ASF GitHub Bot commented on MTOMCAT-177:


Github user nalbion closed the pull request at:

https://github.com/apache/tomcat-maven-plugin/pull/3


> tomcat7:deploy ignores proxy settings
> -
>
> Key: MTOMCAT-177
> URL: https://issues.apache.org/jira/browse/MTOMCAT-177
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>  Components: tomcat7
>Affects Versions: 2.0
>Reporter: Brad Larson
>Assignee: Olivier Lamy (*$^¨%`£)
>  Labels: proxy
> Fix For: 2.3
>
> Attachments: MTOMCAT-177.patch
>
>
> Using these settings:
> org.apache.tomcat.maven
> tomcat7-maven-plugin
> 2.0-SNAPSHOT
> When running tomcat7:deploy behind a network proxy (specified in 
> ~/.m2/settings.xml), the deploy will fail with a very generic error message.  
> Running outside of the proxy (with no proxy settings in ~/.m2/settings.xml) 
> works fine.
> The error message is simply "Connection refused", no other details provided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-302) Tomcat 8: Invalid resource paths added when scanning for TLDs

2016-02-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152785#comment-15152785
 ] 

ASF GitHub Bot commented on MTOMCAT-302:


Github user rupert654 closed the pull request at:

https://github.com/apache/tomcat-maven-plugin/pull/21


> Tomcat 8: Invalid resource paths added when scanning for TLDs
> -
>
> Key: MTOMCAT-302
> URL: https://issues.apache.org/jira/browse/MTOMCAT-302
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Dependency upgrade
>Reporter: Rupert Madden-Abbott
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Blocker
> Fix For: 3.0
>
>
> Tomcat 8 now requires that all resource paths begin with "/".
> However, in org.apache.tomcat.maven.plugin.tomcat8.run.RunMojo, there is an 
> anonymous class extending 
> org.apache.tomcat.maven.plugin.tomcat8.run.AbstractRunMojo.MyDirContext.
> This overrides the method listWebAppPaths and the implementation will return 
> file names, which do not begin with "/".
> This will result in an error if you place a tld file in your WEB-INF 
> directory. Doing this will cause listWebAppPaths to return your tld file, 
> which then causes an error as the path is not valid.
> One solution would be to alter this method so it appended the path relative 
> to the classpath, to each file. This seems to be how the equivalent method in 
> org.apache.catalina.webresources.DirResourceSet works.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-302) Tomcat 8: Invalid resource paths added when scanning for TLDs

2015-12-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068390#comment-15068390
 ] 

ASF GitHub Bot commented on MTOMCAT-302:


GitHub user rupert654 opened a pull request:

https://github.com/apache/tomcat-maven-plugin/pull/21

Ensure that resource paths begin with "/" as required by Tomcat 8.

This fixes https://issues.apache.org/jira/browse/MTOMCAT-302

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rupert654/tomcat-maven-plugin MTOMCAT-302

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat-maven-plugin/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #21


commit 216c0f0826b6d4d5900fcd7baa62585d36030b8f
Author: Rupert Madden-Abbott 
Date:   2015-12-22T16:47:59Z

Ensure that resource paths begin with "/" as required by Tomcat 8.




> Tomcat 8: Invalid resource paths added when scanning for TLDs
> -
>
> Key: MTOMCAT-302
> URL: https://issues.apache.org/jira/browse/MTOMCAT-302
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Dependency upgrade
>Reporter: Rupert Madden-Abbott
>Priority: Blocker
> Fix For: 3.0
>
>
> Tomcat 8 now requires that all resource paths begin with "/".
> However, in org.apache.tomcat.maven.plugin.tomcat8.run.RunMojo, there is an 
> anonymous class extending 
> org.apache.tomcat.maven.plugin.tomcat8.run.AbstractRunMojo.MyDirContext.
> This overrides the method listWebAppPaths and the implementation will return 
> file names, which do not begin with "/".
> This will result in an error if you place a tld file in your WEB-INF 
> directory. Doing this will cause listWebAppPaths to return your tld file, 
> which then causes an error as the path is not valid.
> One solution would be to alter this method so it appended the path relative 
> to the classpath, to each file. This seems to be how the equivalent method in 
> org.apache.catalina.webresources.DirResourceSet works.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-299) when a context file is configured if it is not found it should log a warning message

2015-05-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554328#comment-14554328
 ] 

ASF GitHub Bot commented on MTOMCAT-299:


GitHub user ccronemberger opened a pull request:

https://github.com/apache/tomcat-maven-plugin/pull/18

fix for https://issues.apache.org/jira/browse/MTOMCAT-299



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ccronemberger/tomcat-maven-plugin trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat-maven-plugin/pull/18.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18


commit ee4eba0787f68f51dff80c02dd66465229ec021f
Author: ccronemberger 
Date:   2015-05-21T14:14:28Z

fix for https://issues.apache.org/jira/browse/MTOMCAT-299




> when a context file is configured if it is not found it should log a warning 
> message
> 
>
> Key: MTOMCAT-299
> URL: https://issues.apache.org/jira/browse/MTOMCAT-299
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Improvement
>  Components: tomcat7
>Affects Versions: 2.2, 2.3
>Reporter: Constantino Cronemberger
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> In the RunMojo.java class in the method getContextFile it does this:
> if ( contextFile != null && contextFile.exists() )
> {
> // filter file
> } else {
>// no context file is used
> }
> If I have configured a wrong path for my file I would like to have this 
> logged instead of just falling back to the default when no file is specified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-290) Parallel deployment - Support version in war file name when using run-war goal

2014-12-08 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237887#comment-14237887
 ] 

ASF GitHub Bot commented on MTOMCAT-290:


GitHub user oroger opened a pull request:

https://github.com/apache/tomcat-maven-plugin/pull/14

MTOMCAT-290 - Fix for parallel deployment

Fix for the probleme explained in MTOMCAT-290 
(https://issues.apache.org/jira/browse/MTOMCAT-290).
This fix simply strip the version, if present, from the path when running a 
WAR.

BEWARE: I did not look into the internals of the project, this patch might 
have side-effects should not have side effects but I could not verify it (Is 
there a test suite to run for this plugin?)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/oroger/tomcat-maven-plugin trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat-maven-plugin/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit dc29fabf542812f84df03581a5f20b747794edf6
Author: Olivier Roger 
Date:   2014-12-08T14:04:45Z

Fix for parallel deployment




> Parallel deployment - Support version in war file name when using run-war goal
> --
>
> Key: MTOMCAT-290
> URL: https://issues.apache.org/jira/browse/MTOMCAT-290
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Improvement
>  Components: tomcat7
>Affects Versions: 2.2
> Environment: maven tomcat7
>Reporter: Olivier Roger
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Minor
>  Labels: maven, parallel-deployment, run-war
> Attachments: tomcat-maven-plugin_parallel-deploy.patch
>
>
> When using the tomcat7:run-war goal, the context is created based on the 
> *path* configuration parameter.
> To use parallel deployment 
> (http://jagadesh4java.blogspot.be/2013/08/tomcat-7-parallel-deployment.html) 
> I usually append the timestamp to the path as shown below:
>   org.apache.tomcat.maven
>   tomcat7-maven-plugin
>   
>   /myWar##${maven.build.timestamp}
> This works perfectly when deploying (tomcat7:deploy-only) the war since 
> Tomcat detect the ## and separate the context from the version.
> However there the same process is not applied when running the war 
> (tomocat7:run-war) the *##* characters are URL encoded as *%13%13* and the 
> version (=timestamp) is in the resulting context.
> Usually all character should be URL encoded as it is done as the moment, but 
> this case of parallel deployement might be an exception. (feature was 
> introducted in tomcat7).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-234) Tomcat8 Maven Plugin

2014-08-22 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106971#comment-14106971
 ] 

ASF GitHub Bot commented on MTOMCAT-234:


Github user anenviousguest closed the pull request at:

https://github.com/apache/tomcat-maven-plugin/pull/9


> Tomcat8 Maven Plugin
> 
>
> Key: MTOMCAT-234
> URL: https://issues.apache.org/jira/browse/MTOMCAT-234
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 2.0, 2.1, 2.2
> Environment: Maven 3.1, Tomcat8.0RC1, Oracle JDK7u25
>Reporter: Petr Novak
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Blocker
> Fix For: 3.0
>
>
> Please provide initial version of Tomcat8 Maven Plugin. 
> I tried the recommendations in 
> http://tomcat.10.x6.nabble.com/Tomcat-8-Tomcat-Maven-Plugin-2-2-Tomcat8-Maven-Plugin-td4995858.html#none
> but the guideline 
> http://tomcat.apache.org/maven-plugin-trunk/tomcat7-maven-plugin/adjust-embedded-tomcat-version.html
> does not work for Tomcat8 .
> The problem is in changed Tomcat 8 API, the maven throws folloving exception:
>  at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:142)
>  ... 20 more
> by: java.lang.NoSuchMethodError: 
> org.apache.catalina.startup.Tomcat.setDefaultRealm(Lorg/apache/catalina/Realm;)V
>  at 
> org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999)
>  at 
> org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:514)
>  at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106)
>  ... 20 more
>  The method setDefaultRealm is deprecated in Tomcat7 and was removed in 
> Tomcat8 as described in documentation:
> http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html#setDefaultRealm(org.apache.catalina.Realm)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-275) Resources served from static context do NOT have Content-Type set

2014-08-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102220#comment-14102220
 ] 

ASF GitHub Bot commented on MTOMCAT-275:


Github user bdemers closed the pull request at:

https://github.com/apache/tomcat-maven-plugin/pull/10


> Resources served from static context do NOT have Content-Type set
> -
>
> Key: MTOMCAT-275
> URL: https://issues.apache.org/jira/browse/MTOMCAT-275
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>Reporter: Brian Demers
>
> This causes issues when serving css for IE (the css is ignored because of the 
> missing header)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-275) Resources served from static context do NOT have Content-Type set

2014-08-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100842#comment-14100842
 ] 

ASF GitHub Bot commented on MTOMCAT-275:


GitHub user bdemers opened a pull request:

https://github.com/apache/tomcat-maven-plugin/pull/10

Adding default init so the mime types are set for the static content

MTOMCAT-275

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bdemers/tomcat-maven-plugin static-mime-type

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat-maven-plugin/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10


commit 4c7129aefef90e3413c441a44fe4600644110bc9
Author: bdemers 
Date:   2014-08-18T16:46:54Z

Adding default init so the mime types are set for the static content




> Resources served from static context do NOT have Content-Type set
> -
>
> Key: MTOMCAT-275
> URL: https://issues.apache.org/jira/browse/MTOMCAT-275
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>Reporter: Brian Demers
>
> This causes issues when serving css for IE (the css is ignored because of the 
> missing header)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-234) Tomcat8 Maven Plugin

2014-08-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100159#comment-14100159
 ] 

ASF GitHub Bot commented on MTOMCAT-234:


GitHub user anenviousguest opened a pull request:

https://github.com/apache/tomcat-maven-plugin/pull/9

MTOMCAT-234 (Tomcat8 plugin is now working) + MTOMCAT-274

Hi,
Don't know how to split this request into two separate ones. Anyway, I 
finally got Tomcat 8 plugin passing integration tests.
One thing: it seems that integration tests start embedded Tomcat with 
http-nio protocol handler, rather than with http-bio, which means that 
assertion statements had to be changed accordingly.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anenviousguest/tomcat-maven-plugin tc8.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat-maven-plugin/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit a2e146c785e7f1c964b5d875c78a0bea034dfc78
Author: Vladislav Ponomarev 
Date:   2014-08-15T08:12:52Z

1. Fix: MTOMCAT-274 (updated maven-war-plugin version).
2. Fix: access_log.* files excluded from apache-rat-plugin configuration. 
These are generated during Tomcat run and should not be checked.

commit 952e3d3f9e0c7d1fcb86cc1594f74ebb3648092e
Author: Vladislav Ponomarev 
Date:   2014-08-17T13:26:33Z

Fix: MTOMCAT-234




> Tomcat8 Maven Plugin
> 
>
> Key: MTOMCAT-234
> URL: https://issues.apache.org/jira/browse/MTOMCAT-234
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 2.0, 2.1, 2.2
> Environment: Maven 3.1, Tomcat8.0RC1, Oracle JDK7u25
>Reporter: Petr Novak
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Blocker
> Fix For: 3.0
>
>
> Please provide initial version of Tomcat8 Maven Plugin. 
> I tried the recommendations in 
> http://tomcat.10.x6.nabble.com/Tomcat-8-Tomcat-Maven-Plugin-2-2-Tomcat8-Maven-Plugin-td4995858.html#none
> but the guideline 
> http://tomcat.apache.org/maven-plugin-trunk/tomcat7-maven-plugin/adjust-embedded-tomcat-version.html
> does not work for Tomcat8 .
> The problem is in changed Tomcat 8 API, the maven throws folloving exception:
>  at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:142)
>  ... 20 more
> by: java.lang.NoSuchMethodError: 
> org.apache.catalina.startup.Tomcat.setDefaultRealm(Lorg/apache/catalina/Realm;)V
>  at 
> org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999)
>  at 
> org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:514)
>  at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106)
>  ... 20 more
>  The method setDefaultRealm is deprecated in Tomcat7 and was removed in 
> Tomcat8 as described in documentation:
> http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html#setDefaultRealm(org.apache.catalina.Realm)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-274) Tomcat8 integration tests fail with JDK 7 / Maven 3.2.2

2014-08-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099952#comment-14099952
 ] 

ASF GitHub Bot commented on MTOMCAT-274:


Github user anenviousguest closed the pull request at:

https://github.com/apache/tomcat-maven-plugin/pull/8


> Tomcat8 integration tests fail with JDK 7 / Maven 3.2.2
> ---
>
> Key: MTOMCAT-274
> URL: https://issues.apache.org/jira/browse/MTOMCAT-274
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>Affects Versions: 2.3
> Environment: OS name: "mac os x", version: "10.9.4", arch: "x86_64", 
> family: "mac"
> Java version: 1.7.0_67, vendor: Oracle Corporation
> Maven 3.2.2
>Reporter: Envious Guest
>
> When running integration tests for Tomcat8, like that:
> mvn clean verify -pl :tomcat8-maven-plugin -am -P run-its
> The build fails with following exception:
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-war-plugin:2.1-alpha-2:war (default-war) 
> on project simple-war-project: Execution default-war of goal 
> org.apache.maven.plugins:maven-war-plugin:2.1-alpha-2:war failed: Cannot 
> construct org.apache.maven.plugin.war.util.WebappStructure as it does not 
> have a no-args constructor
>  Debugging information 
> message : Cannot construct 
> org.apache.maven.plugin.war.util.WebappStructure as it does not have a 
> no-args constructor
> cause-exception : 
> com.thoughtworks.xstream.converters.reflection.ObjectAccessException
> cause-message   : Cannot construct 
> org.apache.maven.plugin.war.util.WebappStructure as it does not have a 
> no-args constructor
> class   : org.apache.maven.plugin.war.util.WebappStructure
> required-type   : org.apache.maven.plugin.war.util.WebappStructure
> path: /webapp-structure
> line number : 1
> ---
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:224)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:364)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-war of goal org.apache.maven.plugins:maven-war-plugin:2.1-alpha-2:war 
> failed: Cannot construct org.apache.maven.plugin.war.util.WebappStructure as 
> it does not have a no-args constructor



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-274) Tomcat8 integration tests fail with JDK 7 / Maven 3.2.2

2014-08-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098341#comment-14098341
 ] 

ASF GitHub Bot commented on MTOMCAT-274:


GitHub user anenviousguest opened a pull request:

https://github.com/apache/tomcat-maven-plugin/pull/8

Updated maven-war-plugin version

Related to MTOMCAT-274
ITs for Tomcat 7 still passing, ITs for Tomcat8 are still failing, but 
WebappStructure-related error is now gone.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anenviousguest/tomcat-maven-plugin tc8.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat-maven-plugin/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit 506769941392604a7c4fd5f9772461b175000aab
Author: Vladislav Ponomarev 
Date:   2014-08-15T08:12:52Z

Updated maven-war-plugin version




> Tomcat8 integration tests fail with JDK 7 / Maven 3.2.2
> ---
>
> Key: MTOMCAT-274
> URL: https://issues.apache.org/jira/browse/MTOMCAT-274
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>Affects Versions: 2.3
> Environment: OS name: "mac os x", version: "10.9.4", arch: "x86_64", 
> family: "mac"
> Java version: 1.7.0_67, vendor: Oracle Corporation
> Maven 3.2.2
>Reporter: Envious Guest
>
> When running integration tests for Tomcat8, like that:
> mvn clean verify -pl :tomcat8-maven-plugin -am -P run-its
> The build fails with following exception:
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-war-plugin:2.1-alpha-2:war (default-war) 
> on project simple-war-project: Execution default-war of goal 
> org.apache.maven.plugins:maven-war-plugin:2.1-alpha-2:war failed: Cannot 
> construct org.apache.maven.plugin.war.util.WebappStructure as it does not 
> have a no-args constructor
>  Debugging information 
> message : Cannot construct 
> org.apache.maven.plugin.war.util.WebappStructure as it does not have a 
> no-args constructor
> cause-exception : 
> com.thoughtworks.xstream.converters.reflection.ObjectAccessException
> cause-message   : Cannot construct 
> org.apache.maven.plugin.war.util.WebappStructure as it does not have a 
> no-args constructor
> class   : org.apache.maven.plugin.war.util.WebappStructure
> required-type   : org.apache.maven.plugin.war.util.WebappStructure
> path: /webapp-structure
> line number : 1
> ---
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:224)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.executeForkedExecutions(MojoExecutor.java:364)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:198)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
>   at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
>   at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
>   at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
>   at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:606)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>   at 
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>   at 

[jira] [Commented] (MTOMCAT-234) Tomcat8 Maven Plugin

2014-08-14 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098264#comment-14098264
 ] 

ASF GitHub Bot commented on MTOMCAT-234:


Github user kalgon closed the pull request at:

https://github.com/apache/tomcat-maven-plugin/pull/7


> Tomcat8 Maven Plugin
> 
>
> Key: MTOMCAT-234
> URL: https://issues.apache.org/jira/browse/MTOMCAT-234
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 2.0, 2.1, 2.2
> Environment: Maven 3.1, Tomcat8.0RC1, Oracle JDK7u25
>Reporter: Petr Novak
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Blocker
> Fix For: 3.0
>
>
> Please provide initial version of Tomcat8 Maven Plugin. 
> I tried the recommendations in 
> http://tomcat.10.x6.nabble.com/Tomcat-8-Tomcat-Maven-Plugin-2-2-Tomcat8-Maven-Plugin-td4995858.html#none
> but the guideline 
> http://tomcat.apache.org/maven-plugin-trunk/tomcat7-maven-plugin/adjust-embedded-tomcat-version.html
> does not work for Tomcat8 .
> The problem is in changed Tomcat 8 API, the maven throws folloving exception:
>  at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:142)
>  ... 20 more
> by: java.lang.NoSuchMethodError: 
> org.apache.catalina.startup.Tomcat.setDefaultRealm(Lorg/apache/catalina/Realm;)V
>  at 
> org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999)
>  at 
> org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:514)
>  at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106)
>  ... 20 more
>  The method setDefaultRealm is deprecated in Tomcat7 and was removed in 
> Tomcat8 as described in documentation:
> http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html#setDefaultRealm(org.apache.catalina.Realm)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-234) Tomcat8 Maven Plugin

2014-08-14 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097945#comment-14097945
 ] 

ASF GitHub Bot commented on MTOMCAT-234:


GitHub user kalgon opened a pull request:

https://github.com/apache/tomcat-maven-plugin/pull/7

MTOMCAT-234 Classloading issues

this fixes the `java.lang.ClassFormatError` but there is another problem: 
it seems that the `JarScanner` scans the tomcat-maven-plugin dependencies 
instead of the webapp ones. The result is that no `web-fragment.xml` or 
`ServletContainerInitializer` works anymore (and I suspect there should be 
other consequences as well). I did not have enough time to investigate but I 
noticed that, at line 202 in `StandardJarScanner`, a classloader is skipped (it 
wasn't so in Tomcat7)... but I don't know if this could be the cause as I don't 
know the internals of Tomcat very well. I'll try to make some time next week to 
dig a bit deeper.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kalgon/tomcat-maven-plugin tc8.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat-maven-plugin/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #7


commit 8e92cb72f9c2629116b54ca2c6cd4957b7ef6496
Author: kalgon 
Date:   2014-08-14T10:47:12Z

MTOMCAT-234 Classloading issues




> Tomcat8 Maven Plugin
> 
>
> Key: MTOMCAT-234
> URL: https://issues.apache.org/jira/browse/MTOMCAT-234
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 2.0, 2.1, 2.2
> Environment: Maven 3.1, Tomcat8.0RC1, Oracle JDK7u25
>Reporter: Petr Novak
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Blocker
> Fix For: 3.0
>
>
> Please provide initial version of Tomcat8 Maven Plugin. 
> I tried the recommendations in 
> http://tomcat.10.x6.nabble.com/Tomcat-8-Tomcat-Maven-Plugin-2-2-Tomcat8-Maven-Plugin-td4995858.html#none
> but the guideline 
> http://tomcat.apache.org/maven-plugin-trunk/tomcat7-maven-plugin/adjust-embedded-tomcat-version.html
> does not work for Tomcat8 .
> The problem is in changed Tomcat 8 API, the maven throws folloving exception:
>  at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:142)
>  ... 20 more
> by: java.lang.NoSuchMethodError: 
> org.apache.catalina.startup.Tomcat.setDefaultRealm(Lorg/apache/catalina/Realm;)V
>  at 
> org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.startContainer(AbstractRunMojo.java:999)
>  at 
> org.apache.tomcat.maven.plugin.tomcat7.run.AbstractRunMojo.execute(AbstractRunMojo.java:514)
>  at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106)
>  ... 20 more
>  The method setDefaultRealm is deprecated in Tomcat7 and was removed in 
> Tomcat8 as described in documentation:
> http://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/startup/Tomcat.html#setDefaultRealm(org.apache.catalina.Realm)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org