[jira] [Commented] (MTOMCAT-83) Support specifying arguments using a real forked JVM

2015-06-03 Thread Constantino Cronemberger (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570852#comment-14570852
 ] 

Constantino Cronemberger commented on MTOMCAT-83:
-

Isn't this issue very similar to this one MTOMCAT-266?



 Support specifying arguments using a real forked JVM
 

 Key: MTOMCAT-83
 URL: https://issues.apache.org/jira/browse/MTOMCAT-83
 Project: Apache Tomcat Maven Plugin
  Issue Type: New Feature
Affects Versions: 1.1
Reporter: Stevo Slavic
 Fix For: backlog


 [tomcat-maven-plugin's run 
 goal|http://mojo.codehaus.org/tomcat-maven-plugin/run-mojo.html] seems to 
 support forking, but not specifying arguments for forked JVM. Something like 
 that IMO would be useful for specifying memory options different from Maven 
 build and javaagent like jacoco for coverage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Comment Edited] (MTOMCAT-83) Support specifying arguments using a real forked JVM

2015-06-03 Thread Constantino Cronemberger (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570852#comment-14570852
 ] 

Constantino Cronemberger edited comment on MTOMCAT-83 at 6/3/15 1:55 PM:
-

Isn't this issue very similar to this one MTOMCAT-266? I have added some 
comment on that issue.




was (Author: ccronemberger):
Isn't this issue very similar to this one MTOMCAT-266?



 Support specifying arguments using a real forked JVM
 

 Key: MTOMCAT-83
 URL: https://issues.apache.org/jira/browse/MTOMCAT-83
 Project: Apache Tomcat Maven Plugin
  Issue Type: New Feature
Affects Versions: 1.1
Reporter: Stevo Slavic
 Fix For: backlog


 [tomcat-maven-plugin's run 
 goal|http://mojo.codehaus.org/tomcat-maven-plugin/run-mojo.html] seems to 
 support forking, but not specifying arguments for forked JVM. Something like 
 that IMO would be useful for specifying memory options different from Maven 
 build and javaagent like jacoco for coverage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-266) The fork attribute crashes Tomcat on startup

2015-06-03 Thread Constantino Cronemberger (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570844#comment-14570844
 ] 

Constantino Cronemberger commented on MTOMCAT-266:
--

It looks like this is similar to MTOMCAT-83.

I understand fork is used for integration tests, so it will not really cover 
what I really need and maybe what the reporter wants as well.

In my case I would like to run tomcat with this Java argument:

-Djava.util.logging.manager=org.apache.logging.log4j.jul.LogManager

I tried to add it in the systemProperties element but it did not work because 
Maven also uses JUL so it gets initialized before this system property is set.

The option I have now is to pass this argument to Maven, but then I would need 
to also add to Maven classpath all Lo4j2 jars which is not a good idea.

Then I searched for some options to let Tomcat be started in a separate JVM and 
I found this fork configuration, but now I know it will not work for me.

So maybe we will need another option to control whether we want to let the 
forked process running or not.



 The fork attribute crashes Tomcat on startup
 --

 Key: MTOMCAT-266
 URL: https://issues.apache.org/jira/browse/MTOMCAT-266
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat7
Affects Versions: 2.2
 Environment: Windows 8.1, Java 1.7.0_51 and Maven 3.2.1
Reporter: M. R.
Assignee: Olivier Lamy (*$^¨%`£)
Priority: Minor
 Attachments: tomcat-plugin-crash.txt


 The plugin works perfectly running Tomcat with my project web application.
 I do mvn tomcat7:run and the server is started, the webapp is deployed and 
 I can browse to it.
 If I add the fork / attribute, though, the server crashes.
 Here's (a portion of) my pom:
 plugin
 groupIdorg.apache.tomcat.maven/groupId
 artifactIdtomcat7-maven-plugin/artifactId
 version2.2/version
 configuration
 addresslocalhost/address
 port8080/port
 path//path
 uriEncodingUTF-8/uriEncoding
 /configuration
 /plugin
 (I'll add the stacktrace later)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Created] (MTOMCAT-299) when a context file is configured if it is not found it should log a warning message

2015-05-21 Thread Constantino Cronemberger (JIRA)
Constantino Cronemberger created MTOMCAT-299:


 Summary: when a context file is configured if it is not found it 
should log a warning message
 Key: MTOMCAT-299
 URL: https://issues.apache.org/jira/browse/MTOMCAT-299
 Project: Apache Tomcat Maven Plugin
  Issue Type: Improvement
  Components: tomcat7
Affects Versions: 2.2, 2.3
Reporter: Constantino Cronemberger
Assignee: Olivier Lamy (*$^¨%`£)
Priority: Minor


In the RunMojo.java class in the method getContextFile it does this:

if ( contextFile != null  contextFile.exists() )
{
// filter file
} else {
   // no context file is used
}

If I have configured a wrong path for my file I would like to have this logged 
instead of just falling back to the default when no file is specified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-299) when a context file is configured if it is not found it should log a warning message

2015-05-21 Thread Constantino Cronemberger (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554329#comment-14554329
 ] 

Constantino Cronemberger commented on MTOMCAT-299:
--

I have created this pull request for this simple fix:

https://github.com/apache/tomcat-maven-plugin/pull/18

 when a context file is configured if it is not found it should log a warning 
 message
 

 Key: MTOMCAT-299
 URL: https://issues.apache.org/jira/browse/MTOMCAT-299
 Project: Apache Tomcat Maven Plugin
  Issue Type: Improvement
  Components: tomcat7
Affects Versions: 2.2, 2.3
Reporter: Constantino Cronemberger
Assignee: Olivier Lamy (*$^¨%`£)
Priority: Minor
   Original Estimate: 1h
  Remaining Estimate: 1h

 In the RunMojo.java class in the method getContextFile it does this:
 if ( contextFile != null  contextFile.exists() )
 {
 // filter file
 } else {
// no context file is used
 }
 If I have configured a wrong path for my file I would like to have this 
 logged instead of just falling back to the default when no file is specified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-246) Allow for adding dirs/files to webapp classpath

2015-03-23 Thread Constantino Cronemberger (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375996#comment-14375996
 ] 

Constantino Cronemberger commented on MTOMCAT-246:
--

I managed to get it working by adding a resources declaration in a profile I 
use only when running with Tomcat7 plugin:


profile
!-- Enable this profile to run the application with mvn 
tomcat7:run -Pdev. --
iddev/id
build
resources

resourcedirectoryinstance-config/dev/directory/resource

resourcedirectorysrc/main/resources/directory/resource
/resources
/build
/profile


 Allow for adding dirs/files to webapp classpath
 ---

 Key: MTOMCAT-246
 URL: https://issues.apache.org/jira/browse/MTOMCAT-246
 Project: Apache Tomcat Maven Plugin
  Issue Type: New Feature
  Components: tomcat7
Reporter: Ondrej Burkert
Assignee: Olivier Lamy (*$^¨%`£)
 Fix For: 3.0

 Attachments: sample.zip


 We have projects developed using Spring. Every project has a set of 
 configuration files (usually just logback configuration XML and a property 
 file). They are placed on the classpath and loaded from there by Spring app 
 context.
 I don't see any way to put these on the classpath with current (we try 2.1 at 
 the moment) version of the plugin. Adding it using the 
 additionalClasspathDirs does not work as that is apparently Tomcat's not 
 application's classpath. It fails with FileNotFound exception. We place these 
 in the tomcat/lib folder for regular deployments.
 Any workaround or preferably solution for the problem would be highly 
 appreciated. There are couple unanswered questions in this direction on 
 stackoverflow as well. 
 (http://stackoverflow.com/questions/18862237/tomcat7-maven-plugin-couldnt-locate-the-property-file-on-classpath,
  
 http://stackoverflow.com/questions/17962524/extending-classpath-and-tomcat-plugin)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-127) tomcat:run - Configuring Logging with JULI

2015-03-20 Thread Constantino Cronemberger (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14371893#comment-14371893
 ] 

Constantino Cronemberger commented on MTOMCAT-127:
--

workaround I have used was:

mvnDebug tomcat7:run 
-Djava.util.logging.config.file=src/test/resources/logging.properties

 tomcat:run - Configuring Logging with JULI 
 ---

 Key: MTOMCAT-127
 URL: https://issues.apache.org/jira/browse/MTOMCAT-127
 Project: Apache Tomcat Maven Plugin
  Issue Type: New Feature
  Components: tomcat6, tomcat7
Affects Versions: 2.0
Reporter: Cédric Couralet
Assignee: Olivier Lamy (*$^¨%`£)
Priority: Minor
 Fix For: backlog

 Attachments: mtomcat-127.zip


 The configuration for a custom logging.properties is not taken into account 
 with the tomcat6-7:run goal.
 From what I've seen, the reason is that the configuration for 
 java.util.logging is done before setting the system properties in the same 
 class loader.
 I think it could be fixed by putting a call to 
 LogManager.getLogManager().readConfiguration(); right after setting the 
 system properties. I'm not confident enough on the possible side effects to 
 say it is the best solution. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org