Problems building 5.5.27 from source

2009-04-17 Thread Kirk True 

Hi all,

I had some problems building 5.5.27 as pulled from 
http://tomcat.apache.org/download-55.cgi.


The first issue was that I couldn't use a JDK 1.4.2-level compiler as it 
chokes on the class format of the JUnit libraries. Using JDK 1.6 didn't 
work because of the fact that the java.sql.Wrapper class methods aren't 
implemented in the connection pool module classes. So I had to install a 
1.5-era JDK. No biggie.


Secondly, there are some version problems in the 
build.properties.default for which I've submitted a patch (below). I 
don't know what the right fix is for the native Tomcat dependencies, 
but this at least allowed the build to complete. I couldn't find 1.1.12 
anywhere, so while the build doesn't complain, I don't _assume_ this is 
the correct fix.


Thanks,
Kirk

--- a/build/build.properties.default2008-08-28 22:10:32.0 -0700
+++ b/build/build.properties.default2009-04-17 11:58:06.0 -0700
@@ -12,10 +12,10 @@
# - Vesion Control Flags -
version.major=5
version.minor=5
-version.build=26
+version.build=27
version.patch=0
#Set the pretty version name
-version=5.5.26
+version=5.5.27

# - Compile Control Flags -
compile.debug=on
@@ -140,9 +140,9 @@
jdt.loc=http://www.eclipse.org/downloads/download.php?file=/eclipse/downloads/drops/R-3.3.1-200709211145/eclipse-JDT-3.3.1.zip

# - Tomcat native library -
-tomcat-native.home=${base.path}/tomcat-native-1.1.12
+tomcat-native.home=${base.path}/tomcat-native-1.1.16
tomcat-native.tar.gz=${tomcat-native.home}/tomcat-native.tar.gz
-tomcat-native.loc=${base-tomcat.loc}/tomcat-connectors/native/tomcat-native-1.1.12-src.tar.gz
+tomcat-native.loc=${base-tomcat.loc}/tomcat-connectors/native/source/1.1.16/tomcat-native-1.1.16-src.tar.gz


# --


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Problems building 5.5.27 from source

2009-04-17 Thread Kirk True 

Hi sebb,

sebb wrote:

On 17/04/2009, Kirk True k...@mustardgrain.com wrote:
  

Hi all,

 I had some problems building 5.5.27 as pulled from
http://tomcat.apache.org/download-55.cgi.

 The first issue was that I couldn't use a JDK 1.4.2-level compiler as it
chokes on the class format of the JUnit libraries.



AFAIK it requires Java 1.5, see:

http://www.mirrorservice.org/sites/ftp.apache.org/tomcat/tomcat-5/v5.5.27/README.html

Or is there some other documentation that says otherwise?
  


In the zip, apache-tomcat-5.5.27-src.zip is a file named 
build/BUILDING.txt which provides steps to build, among which is:


   (0) Download and Install a Java Development Kit

   * If the JDK is already installed, skip to (1).

   * Download a Java Development Kit (JDK) release (version 1.4.x or 
later) from:


   http://java.sun.com/j2se/

   * Install the JDK according to the instructions included with the 
release.


   * Set an environment variable JAVA_HOME to the pathname of the directory
 into which you installed the JDK release.

That's what I went off of.

Kirk


Using JDK 1.6 didn't work
because of the fact that the java.sql.Wrapper class methods aren't
implemented in the connection pool module classes. So I had to install a
1.5-era JDK. No biggie.

 Secondly, there are some version problems in the build.properties.default
for which I've submitted a patch (below). I don't know what the right fix
is for the native Tomcat dependencies, but this at least allowed the build
to complete. I couldn't find 1.1.12 anywhere, so while the build doesn't
complain, I don't _assume_ this is the correct fix.



I don't know about the properties file, perhaps someone more familiar
with Tomcat releases will chip in.

  

 Thanks,
 Kirk

 --- a/build/build.properties.default2008-08-28
22:10:32.0 -0700
 +++ b/build/build.properties.default2009-04-17
11:58:06.0 -0700
 @@ -12,10 +12,10 @@
 # - Vesion Control Flags -
 version.major=5
 version.minor=5
 -version.build=26
 +version.build=27
 version.patch=0
 #Set the pretty version name
 -version=5.5.26
 +version=5.5.27

 # - Compile Control Flags -
 compile.debug=on
 @@ -140,9 +140,9 @@
jdt.loc=http://www.eclipse.org/downloads/download.php?file=/eclipse/downloads/drops/R-3.3.1-200709211145/eclipse-JDT-3.3.1.zip

 # - Tomcat native library -
 -tomcat-native.home=${base.path}/tomcat-native-1.1.12
 +tomcat-native.home=${base.path}/tomcat-native-1.1.16
tomcat-native.tar.gz=${tomcat-native.home}/tomcat-native.tar.gz
-tomcat-native.loc=${base-tomcat.loc}/tomcat-connectors/native/tomcat-native-1.1.12-src.tar.gz
+tomcat-native.loc=${base-tomcat.loc}/tomcat-connectors/native/source/1.1.16/tomcat-native-1.1.16-src.tar.gz


 # --


-
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

  


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat newbie developer tasks?

2009-04-03 Thread Kirk True 

Hi all,

Can anyone suggest some trivial newbie projects for the Tomcat code 
base? I don't care how menial it is, typo changes, logging, testing 
(something specific), etc. I've been lurking on the list for awhile and 
want to start getting my hands dirty.


Thanks,
Kirk

Kirk True wrote:

Hi all,

Is there a list of tasks with which one can begin to get familiar with 
the Tomcat source and contribute? Most of the bugs in the Bugzilla 
look difficult (at least without some guidance) or already have patches.


Thanks,
Kirk



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Question about Bugzilla etiquette

2009-01-28 Thread Kirk True 

Hi guys,

If I want to work on a bug that's in Bugzilla, should I assign it to 
myself or keep it assigned to the dev@tomcat.apache.org user?


Thanks,
Kirk

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

View towards refactoring changes?

2009-01-25 Thread Kirk True 

Hi all,

There are a number of places in NioEndpoint and JIoEndpoint that share a 
good portion of common code. The accessors for common properties take up 
a good chunk, but there's also some boilerplate code for checking if 
we're paused, running, etc. There are a lot of places where variable and 
method scope could be cleaned up too.


Obviously I can't commit this code myself, but if I submitted patches 
for it, would they be looked upon favorably or ignored as noise? :)


Thanks,
Kirk

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat newbie developer tasks?

2008-12-09 Thread Kirk True 

Hi Mark,

Mark Thomas wrote:
Take a look at the following bugs. 
  


. . .



https://issues.apache.org/bugzilla/show_bug.cgi?id=38570
https://issues.apache.org/bugzilla/show_bug.cgi?id=38726
https://issues.apache.org/bugzilla/show_bug.cgi?id=39013

  



Bugs 38570 and 38726 do not reproduce for the trunk, 6.0.18, or 5.5.27. 
I noted this in the bug but didn't close them - should I?


However, bug 39013 still occurs on the trunk (as of yesterday). I trace 
through and found a one-liner that solved the reported issue and 
attached the patch to the bug. As noted in the bug comments, I could 
easily have overlooked or broken something inadvertently.


Thanks,
Kirk

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Unnecessary entries in Eclipse project

2008-12-08 Thread Kirk True 

Hi all,

When I use the included Eclipse project file (from trunk), I get these 
error messages:


   Project 'trunk' is missing required library: 
'output/extras/webservices/jaxrpc.jar'
   Project 'trunk' is missing required library: 
'output/extras/webservices/wsdl4j.jar'


That said, I can remove the CLASSPATH entries from the Eclipse project 
and rebuild and everything works fine. Are these part of an optional 
build, only accessed at runtime, or are they really removable from the 
Eclipse project?


Thanks,
Kirk


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Unnecessary entries in Eclipse project

2008-12-08 Thread Kirk True 

Hi Filip,

Filip Hanik - Dev Lists wrote:

ant -f extras.xml



Thanks. I do know how to get the libraries, that's not really the 
question ;)


It seems that the core code in the Eclipse project doesn't reference 
those libraries and so it seems they're superfluously included in the 
.project file.


I don't care, and it doesn't bother me, I'm just trying to put the 
pieces together and want to make sure I understand where they all go :)


Thanks,
Kirk


Filip

Kirk True wrote:

Hi all,

When I use the included Eclipse project file (from trunk), I get 
these error messages:


   Project 'trunk' is missing required library: 
'output/extras/webservices/jaxrpc.jar'
   Project 'trunk' is missing required library: 
'output/extras/webservices/wsdl4j.jar'


That said, I can remove the CLASSPATH entries from the Eclipse 
project and rebuild and everything works fine. Are these part of an 
optional build, only accessed at runtime, or are they really 
removable from the Eclipse project?


Thanks,
Kirk


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Tomcat newbie developer tasks?

2008-11-28 Thread Kirk True 

Hi all,

Is there a list of tasks with which one can begin to get familiar with 
the Tomcat source and contribute? Most of the bugs in the Bugzilla look 
difficult (at least without some guidance) or already have patches.


Thanks,
Kirk

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Minor changes needed to compile trunk and import into Eclipse

2008-01-06 Thread Kirk True 

Hi all,

I downloaded the source for the trunk and tried to compile it, but ran into
some minor issues...

The first problem is that ant download couldn't compile some dependencies
because I was using Java 1.6. I assumed this was OK as the verbiage states
something to the effect of Java 5 or greater. I installed the latest Java 5,
updated my JAVA_HOME variable, and ant download and ant worked fine. Is
1.6 expected to work?

Secondly, (even though I know it's unsupported) I imported the stock
.project into my Eclipse workspace.
I had three minor issues: 

1. org/apache/naming/factory/webservices isn't excluded in the
.classpath file as it is
in the build.xml
2. The Eclipse plugin has been updated, so the downloaded dependency was
3.3.1 
while the .classpath expected 3.1.2
3. The Ant JAR dependency was not downloaded, so I updated the
.classpath to use
$ANT_HOME/lib/ant.jar 

diff of .classpath:

Index: .classpath
===
--- .classpath  (revision 609508)
+++ .classpath  (working copy)
@@ -16,10 +16,10 @@
   limitations under the License.
 --
 classpath
-   classpathentry
excluding=**/.svn/**|org/apache/tomcat/util/net/puretls/ kind=src
path=java/
+   classpathentry
excluding=**/.svn/**|org/apache/tomcat/util/net/puretls/|org/apache/naming/factory/webservices/
kind=src path=java/
classpathentry kind=src path=webapps/examples/WEB-INF/classes/
classpathentry kind=con
path=org.eclipse.jdt.launching.JRE_CONTAINER/
-   classpathentry kind=var
path=TOMCAT_LIBS_BASE/apache-ant-1.6.5/lib/ant.jar/
-   classpathentry kind=var
path=TOMCAT_LIBS_BASE/eclipse/plugins/org.eclipse.jdt.core_3.1.2.jar/
+   classpathentry kind=var path=ANT_HOME/lib/ant.jar/
+   classpathentry kind=var
path=TOMCAT_LIBS_BASE/eclipse/plugins/org.eclipse.jdt.core_3.3.1.v_780_R33x.jar/
classpathentry kind=output path=.settings/output/
 /classpath

Thanks,
Kirk
-- 
View this message in context: 
http://www.nabble.com/Minor-changes-needed-to-compile-trunk-and-import-into-Eclipse-tp14658709p14658709.html
Sent from the Tomcat - Dev mailing list archive at Nabble.com.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]