[Bug 50504] Allow setting query string character set trough request attribute
https://issues.apache.org/bugzilla/show_bug.cgi?id=50504 --- Comment #6 from Mark Thomas ma...@apache.org --- The query string remains as bytes until it is required (if at all). Take a look at Http11InputBuffer.parseRequestLine() in trunk and when it is called. Hence why setting the character encoding on the request (assuming they do that before they read the query string) allows applications to choose the encoding they want to use for the query string on a per request basis. The URI is a different matter. It gets used for mapping so it has to be decoded before the mapping can take place so a per web application URI decoding makes no sense. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 50504] Allow setting query string character set trough request attribute
https://issues.apache.org/bugzilla/show_bug.cgi?id=50504 --- Comment #5 from Christopher Schultz ch...@christopherschultz.net --- (In reply to Mark Thomas from comment #4) Request URI decoding has to bee connector wide since the URI has to be decoded before it is mapped. If it can be assumed that the mapping has been done correctly and won't change, could the query string itself be re-decoded from the original bytes if the request contains an attribute that differs from the initial character set used for decoding? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 50504] Allow setting query string character set trough request attribute
https://issues.apache.org/bugzilla/show_bug.cgi?id=50504 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Mark Thomas ma...@apache.org --- Request URI decoding has to bee connector wide since the URI has to be decoded before it is mapped. If you want per web application control of query string encoding, use a filter and call ServletRequest.setCharacterEncoding(). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50504] Allow setting query string character set trough request attribute
https://issues.apache.org/bugzilla/show_bug.cgi?id=50504 --- Comment #2 from Christopher Schultz ch...@christopherschultz.net 2011-09-20 21:50:03 UTC --- Couldn't this just be written as a Valve? The only utility I can see for checking for a request attribute like org.apache.tomcat.request.query_encoding would be to have /another/ Valve set that value conditionally (or even unconditionally) for some reason. If you're writing a Valve, why not just go ahead and set the character encoding yourself at that point? I briefly considered a Valve that inspected a request /parameter/ to see if the client wanted to specify that everything was to be decoded in, say, shift-jis or something, but that gets you into a chicken-in-an-egg scenario so it's not a valid use case. I don't see why the Request class should be modified in this way when a Valve can accomplish the same thing. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50504] Allow setting query string character set trough request attribute
https://issues.apache.org/bugzilla/show_bug.cgi?id=50504 --- Comment #3 from Attila Király kiralyattila...@gmail.com 2011-09-21 05:17:51 UTC --- A Valve could be a solution too if it comes with Tomcat. It would mean that encoding can be configured per webapp which is what this ticket is about. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50504] Allow setting query string character set trough request attribute
https://issues.apache.org/bugzilla/show_bug.cgi?id=50504 --- Comment #1 from Attila Király kiralyattila...@gmail.com 2010-12-21 04:17:22 EST --- Created an attachment (id=26432) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26432) Patch implementing the suggestion + junit test Attaching patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50504] Allow setting query string character set trough request attribute
https://issues.apache.org/bugzilla/show_bug.cgi?id=50504 Attila Király kiralyattila...@gmail.com changed: What|Removed |Added CC||kiralyattila...@gmail.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
