[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #15 from Mark Thomas ma...@apache.org --- Fixed in 6.0.x and will be included in 6.0.36 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071
Mark Thomas ma...@apache.org changed:
What|Removed |Added
Component|Catalina|Catalina
Version|7.0.29 |6.0.35
Product|Tomcat 7|Tomcat 6
Target Milestone|--- |default
--- Comment #14 from Mark Thomas ma...@apache.org ---
Jasper issue fixed in trunk and 7.0.x.
Jasper fix and {0} fix proposed for 6.0.c
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 Konstantin Kolinko knst.koli...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Component|Catalina|Catalina Version|6.0.35 |7.0.29 Resolution|FIXED |--- Product|Tomcat 6|Tomcat 7 Target Milestone|default |--- --- Comment #13 from Konstantin Kolinko knst.koli...@gmail.com --- Reopening this. This needs further improvement. When there is a java compilation error in JSP page, the error page becomes especially ugly. Reproducible in 7.0.29. To reproduce: 1. Change ROOT/index.jsp introducing a typo in Java code scriptlet, e.g. s/SimpleDateFormat/SimpleDate Format/ 2. Access the page. Actual result: The whole text of the compilation exception, including a source code fragment, is included in the h1 header, as well as in the message field. That is a lot of text without any formatting, occupying the whole screen. It is ugly. Expected result: Maybe include just some part of the text, and replace the rest with ellipsis (...)? Maybe use just the first line, as line breaks are lost when rendering HTML? Also, the changes mentioned in Comment 11 still have to be proposed/fixed in 6.0. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071
--- Comment #12 from Michael Osipov 1983-01...@gmx.net ---
(In reply to comment #11)
(In reply to comment #8)
I personally do not like use of {0} in the messages for the description
field. Especially the ones for 404 and 403. It looks like some unrelated
text is inserted into the middle of a sentence. With this change it is
printed 4 times on the same page.
I removed the {0} from the report in r1361991 (trunk) and r1362000 (tc7).
Rainer,
can you backport to Tomcat 6 too?
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071
--- Comment #11 from Rainer Jung rainer.j...@kippdata.de ---
(In reply to comment #8)
I personally do not like use of {0} in the messages for the description
field. Especially the ones for 404 and 403. It looks like some unrelated
text is inserted into the middle of a sentence. With this change it is
printed 4 times on the same page.
I removed the {0} from the report in r1361991 (trunk) and r1362000 (tc7).
Motivation:
As far as I can see, those properties are only used in ErrorReportValve. There
they are only put into the report, which is only output in an HTML document
directly below the message that would have been put into {0}.
In addition the same message is again being output as an h1 heading shortly
before.
So I see no reason at all to keep the message inside the report.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #10 from Mark Thomas ma...@apache.org --- Fixed in 6.0.x and will be included in 6.0.36 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #6 from Konstantin Kolinko knst.koli...@gmail.com --- Created attachment 28920 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28920action=edit Screen shot from Tomcat 7.0.27 Just a screen shot, for comparison. It is before implementing this feature. It is CookieExample page, when pressing submit button without entering any values. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #7 from Konstantin Kolinko knst.koli...@gmail.com --- Created attachment 28921 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28921action=edit Screen shot from Tomcat trunk The same with Tomcat trunk after implementing the feature. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071
--- Comment #8 from Konstantin Kolinko knst.koli...@gmail.com ---
(In reply to comment #4)
Putting this caveat in the bug and not just on the dev list:
I agree with Mark here.
The change in r1348762 is in the place where ErrorReportValve prepares HTML
text of the page. It does not affect other components. It does not affect
components that display their own error pages. The old implementation already
displays the exception, so nothing new is revealed.
I personally do not like use of {0} in the messages for the description
field. Especially the ones for 404 and 403. It looks like some unrelated text
is inserted into the middle of a sentence. With this change it is printed 4
times on the same page.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071
--- Comment #9 from Michael Osipov 1983-01...@gmx.net ---
(In reply to comment #8)
(In reply to comment #4)
Putting this caveat in the bug and not just on the dev list:
I agree with Mark here.
The change in r1348762 is in the place where ErrorReportValve prepares HTML
text of the page. It does not affect other components. It does not affect
components that display their own error pages. The old implementation
already displays the exception, so nothing new is revealed.
Exactly, the same information but more prominent.
I personally do not like use of {0} in the messages for the description
field. Especially the ones for 404 and 403. It looks like some unrelated
text is inserted into the middle of a sentence. With this change it is
printed 4 times on the same page.
I personally dislike that one too in this valve.
In my opinion, the following should happen:
If message is not given: Message should be from
https://tools.ietf.org/html/rfc2616#section-6.1.1 as per status code short name
and description should be a copy of the first sentence of the RFC description.
Maybe just as HTTPd does.
If message is given: Display message and show RFC description too.
Stack trace should be left as is.
It might make sense to limit the message length in the first line to n chars
and show the entire message in the message line. But if and only if the message
is to0 long. Otherwise the message line should be omitted.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #2 from Mark Thomas ma...@apache.org --- Fixed in trunk and 7.0.x and will be included in 7.0.28 onwards. Proposed for 6.0.x Notes: 1. The message from the Throwable was displayed in the stack trace. 2. I modified the patch. The message from the Throwable is only used if no message is specified via sendError() -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #3 from Michael Osipov 1983-01...@gmx.net --- (In reply to comment #2) Fixed in trunk and 7.0.x and will be included in 7.0.28 onwards. Proposed for 6.0.x Notes: 1. The message from the Throwable was displayed in the stack trace. I am aware of that but I don't want to burden my users with the stack traces, the message is just fine. 2. I modified the patch. The message from the Throwable is only used if no message is specified via sendError() This is perfectly fine and does the job. Thanks for the fix. Looking forward to 6.0.36. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #4 from Christopher Schultz ch...@christopherschultz.net --- Putting this caveat in the bug and not just on the dev list: This might end up being a security problem, depending on what information is in the exception message. Can we make this a non-default option? Many sites (ours included) attempt to avoid any part of a stack trace (even the message) leaking-out to users. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #5 from Mark Thomas ma...@apache.org --- Then you have already replaced / modified the error report valve and you won't see this change. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 53071] ErrorReportValve ignores message from throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 --- Comment #1 from Michael Osipov 1983-01...@gmx.net 2012-04-13 09:34:41 UTC --- This change could also be applied to Tomcat 7. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
