https://issues.apache.org/bugzilla/show_bug.cgi?id=53700

          Priority: P2
            Bug ID: 53700
          Assignee: dev@tomcat.apache.org
           Summary: InternalNioOutputBuffer unused (debug?) code
          Severity: minor
    Classification: Unclassified
                OS: Windows XP
          Reporter: s...@apache.org
          Hardware: PC
            Status: NEW
           Version: trunk
         Component: Catalina
           Product: Tomcat 7

The class InternalNioOutputBuffer includes the field:

int total = 0;

This is currently defined at line 227, which is between the Javadoc and method
body to which the Javadoc applies, i.e. private synchronized int writeToSocket.

This invalidates the method Javadoc.

The field is used to keep a running total of bytes written by the method;
however the field is not actually referenced - the System.out.println statement
is commented out.

The field and associated code shcould probably be deleted.

If the field is to be kept, it should be private, and it should probably be
changed to long, and of course should be moved so it does not invalidate the
method Javadoc.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to