[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 --- Comment #13 from Mark Thomas ma...@apache.org --- Fixed in 6.0.x and will be included in 6.0.36 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 --- Comment #7 from Mark Thomas ma...@apache.org --- Very different failure mode (a whole chunk of data is missing from the end). Probably a different bug. I'll start digging. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 --- Comment #8 from Mark Thomas ma...@apache.org --- Easy solution implemented for trunk (Tomcat 8). Still trying to find a fix for Tomcat 7. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 --- Comment #9 from Konstantin Kolinko knst.koli...@gmail.com --- Created attachment 29297 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29297action=edit 2012-08-29_tc6_53725.patch Thank you for the test! Fixed in 7.0 with r1378378. Will be in 7.0.30. Here is patch for Tomcat 6 (r1377343 + r1378378). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #10 from Mark Thomas ma...@apache.org --- That test (In reply to comment #9) Created attachment 29297 [details] 2012-08-29_tc6_53725.patch Thank you for the test! Fixed in 7.0 with r1378378. Will be in 7.0.30. Here is patch for Tomcat 6 (r1377343 + r1378378). While that patch fixed the test for the second test case, it re-broke it for the first. After a lot of trial and error I have a patch that works for both test cases. I'm not at all clear as to the root cause of what is happening as the critical code is native code. The latest patch may still fail for some edge cases. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 --- Comment #11 from Jess Holle je...@ptc.com --- After some time with dealing with such issues with our own servlet filter for compression and trying various solutions tried in Tomcat, I finally gave up and went with jzlib for pre-Java-7 cases and with the built-in sync-flush functionality in Java 7 cases. I got tired of someone always coming up with some new case where trying to allow flushing with the pre-Java-7 GZipOutputStream caused an issue. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725
--- Comment #12 from Konstantin Kolinko knst.koli...@gmail.com ---
I reverted the fix in r1378402
and implemented a different one in r1378403 + r1378408
(will be in 7.0.30)
The FlushableGZIPOutputStream#deflate() method is not called by this class
directly, but by its parent class, DeflaterOutputStream.
Such calls are always in a loop,
while (!def.needsInput()) {
deflate();
}
while (!def.finished()) {
deflate();
}
so I there should not be a need to add (!def.needsInput()) condition to the
deflate() method itself.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 --- Comment #3 from kevin.l.st...@nokia.com --- Created attachment 29286 -- https://issues.apache.org/bugzilla/attachment.cgi?id=29286action=edit Demonstrates the same problem post-fix. Please unzip to obtain the data.bin which causes the issue. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 kevin.l.st...@nokia.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #4 from kevin.l.st...@nokia.com --- I have attached a new data.bin which demonstrates that the problem remains post-fix. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 --- Comment #5 from kevin.l.st...@nokia.com --- Note that, not surprisingly, using Java 7's GZIPOutputStream with syncFlush=true resolves the issue. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 --- Comment #6 from Mark Thomas ma...@apache.org --- That is an option for Tomcat 8 (which will require Java 7) but not for Tomcat 7 and earlier. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 --- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com --- Good catch. I proposed backport of this fix (r1377342) to Tomcat 6.0. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53725] Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53725 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Mark Thomas ma...@apache.org --- Thanks for the test case. It made fixing this a whole lot easier than it would otherwise have been. The fix has been applied to trunk and 7.0.x and will be included in 7.0.30 onwards. I haven't included the test case in the unit tests due to the size of the file required to trigger this issue. (It would significantly increase the size of the source distribution.) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
