[Bug 54387] Having servlets with same url should at least cause warning

2014-02-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

--- Comment #11 from Jackie Rosen jackie.ro...@hushmail.com ---
*** Bug 260998 has been marked as a duplicate of this bug. ***
Seen from the domain http://volichat.com
Page where seen: http://volichat.com/adult-chat-rooms
Marked for reference. Resolved as fixed @bugzilla.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54387] Having servlets with same url should at least cause warning

2013-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

Abdul Aziz javahop...@gmail.com changed:

   What|Removed |Added

Version|7.0.34  |7.0.47

--- Comment #8 from Abdul Aziz javahop...@gmail.com ---
I want to understand more..

having following configuration in deployment descriptor

servlet
servlet-namesn1/servlet-name
servlet-classcom.servlets.urlpatterns.Servlet1/servlet-class
/servlet
servlet-mapping
servlet-namesn1/servlet-name
url-pattern/s/url-pattern
/servlet-mapping

servlet
servlet-namesn2/servlet-name
servlet-classcom.servlets.urlpatterns.Servlet1/servlet-class
/servlet
servlet-mapping
servlet-namesn2/servlet-name
url-pattern/s/url-pattern
/servlet-mapping

why should the server startup / app deployment fail? what makes the difference?

Any how both the servlets sn1 and sn2 are referring to same Servlet1

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54387] Having servlets with same url should at least cause warning

2013-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

--- Comment #9 from Violeta Georgieva violet...@apache.org ---
(In reply to Abdul Aziz from comment #8)
 
 Any how both the servlets sn1 and sn2 are referring to same Servlet1

Once you use 
servlet-classcom.servlets.urlpatterns.Servlet1/servlet-class
the servlets will point to one and the same class.

But you need to specify different url-patterns that's the case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54387] Having servlets with same url should at least cause warning

2013-12-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

--- Comment #10 from Abdul Aziz javahop...@gmail.com ---
(In reply to Violeta Georgieva from comment #9)
 (In reply to Abdul Aziz from comment #8)
  
  Any how both the servlets sn1 and sn2 are referring to same Servlet1
 
 Once you use 
 servlet-classcom.servlets.urlpatterns.Servlet1/servlet-class
 the servlets will point to one and the same class.
 
 But you need to specify different url-patterns that's the case.

Correct!! My Question is, Why should the server start-up fail?

What difference would it make if I try to access either of the servlet's with
same url pattern?

I agree its foolish doing so.. But failure during server up doesn't make sense,
Right?

Earlier versions of Tomcat used to support this (prior to 7.0.35)

However server start-up should fail, if same url pattern refers to different
servlets say

servlet
servlet-namesn1/servlet-name
servlet-classcom.servlets.urlpatterns.Servlet1/servlet-class
/servlet
servlet-mapping
servlet-namesn1/servlet-name
url-pattern/s/url-pattern
/servlet-mapping

servlet
servlet-namesn2/servlet-name
servlet-classcom.servlets.urlpatterns.Servlet2/servlet-class
/servlet
servlet-mapping
servlet-namesn2/servlet-name
url-pattern/s/url-pattern
/servlet-mapping

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54387] Having servlets with same url should at least cause warning

2013-06-04 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

Loïc Albertin loic.alber...@ow2.org changed:

   What|Removed |Added

 CC||loic.alber...@ow2.org

--- Comment #7 from Loïc Albertin loic.alber...@ow2.org ---
Hi Violeta,

thank you for that clarification, I agree with you. 
I missed this statement in the specification.

Thanks again.
Regards,
Loïc

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54387] Having servlets with same url should at least cause warning

2013-05-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

--- Comment #4 from Loïc Albertin loic.alber...@ow2.org ---
Hi Mark,

I totally agree with the fact that an URL should be mapped to only one Servlet.
But, I'd like to have your point of view and maybe the one of the Servlet EG
about the following case.

Let's imagine that we have a Servlet annotated with @WebServlet(/an/url) and
a web.xml descriptor that define the same Servlet class with a different
logical name mapped to the same URL through a Servlet mapping.

From my point of view this is actually the same Servlet which is mapped to
this URL and it doesn't contradict the updated paragraph in the Servlet
specification [1].

With the current Tomcat implementation this case will lead to a deployment
failure. My proposed solution is that when different Servlet names with the
same Servlet class are mapped to a same URL the first one defined will be
chosen. This will lead to prefer the one defined in the web descriptor over
annotations.
So, what do you think?

Thanks  regards,
Loïc


[1] If the effective web.xml (after merging information from fragments and
annotations) contains any url-patterns that are mapped to multiple servlets
then the deployment must fail.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54387] Having servlets with same url should at least cause warning

2013-05-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

--- Comment #5 from Edson Richter edsonrich...@hotmail.com ---
My understanding is that

Scenario 1:

ServletA - /my/path/to/servlet
ServletB - /my/path/to/servlet

Rule: same path to different servlets = failure.


Scenario 2:

ServletA - /my/path/to/servlet1
ServletA - /my/path/to/servlet2

Rule: same servlet to different paths: success.



Regards,

Edson

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54387] Having servlets with same url should at least cause warning

2013-05-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

--- Comment #6 from Violeta Georgieva violet...@apache.org ---
(In reply to comment #4)
 
 Let's imagine that we have a Servlet annotated with @WebServlet(/an/url)
 and a web.xml descriptor that define the same Servlet class with a different
 logical name mapped to the same URL through a Servlet mapping.
 


In Servlet Spec 3.0, 8.1.1 @WebServlet

There is an explicit statement that these are two different servlets.


If the same servlet class is declared in the deployment
descriptor under a different name, a new instance of the servlet MUST be
instantiated.


Regards
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54387] Having servlets with same url should at least cause warning

2013-01-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #2 from Mark Thomas ma...@apache.org ---
The EG has confirmed that deployment should fail.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54387] Having servlets with same url should at least cause warning

2013-01-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Mark Thomas ma...@apache.org ---
This has been fixed in trunk and 7.0.x and will be included in 7.0.35 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54387] Having servlets with same url should at least cause warning

2013-01-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54387

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from Mark Thomas ma...@apache.org ---
Hmm.

Before we do anything on this I'd like to get some feedback from the Servlet EG
as to what the expected behaviour is here. My personal view is that it should
not be allowed and the web application should fail to start.

http://java.net/jira/browse/SERVLET_SPEC-53

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org