[Bug 54770] Add jarsToScan properties to counteract jarsToSkip exclusions; support per-web-app properties; port to Tomcat 7

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54770

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
  Component|Catalina|Catalina
Version|7.0.40  |trunk
 Resolution|--- |FIXED
Product|Tomcat 7|Tomcat 8
   Target Milestone|--- |

--- Comment #6 from Mark Thomas ma...@apache.org ---
As discussed previously, thsi has been fixed for 8.0.x and will not be
back-ported to 7.0.x.

Nick's patches have been applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54770] Add jarsToScan properties to counteract jarsToSkip exclusions; support per-web-app properties; port to Tomcat 7

2013-07-10 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54770

--- Comment #7 from Nick Williams nicho...@nicholaswilliams.net ---
Excellent. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54770] Add jarsToScan properties to counteract jarsToSkip exclusions; support per-web-app properties; port to Tomcat 7

2013-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54770

--- Comment #4 from Nick Williams nicho...@nicholaswilliams.net ---
Created attachment 30562
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=30562action=edit
Patch to keep Log4j 2 JARs from being skipped

I've attached a patch to keep the Log4j 2 JARs from being skipped. Can you
apply this in trunk and Tomcat 7? Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54770] Add jarsToScan properties to counteract jarsToSkip exclusions; support per-web-app properties; port to Tomcat 7

2013-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54770

Nick Williams nicho...@nicholaswilliams.net changed:

   What|Removed |Added

  Attachment #30562|Patch to keep Log4j 2 JARs  |Patch to keep Log4j 2 JARs
description|from being skipped  |from being skipped in
   ||Tomcat 7

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54770] Add jarsToScan properties to counteract jarsToSkip exclusions; support per-web-app properties; port to Tomcat 7

2013-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54770

--- Comment #5 from Nick Williams nicho...@nicholaswilliams.net ---
Created attachment 30566
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=30566action=edit
Patch to keep Log4j 2 JARs from being skipped in Tomcat 8

The previous patch I attached is sufficient for Tomcat 7. However, it can still
result in some unnecessary scanning of Log4j JARs. There's nothing we can do
about that in Tomcat 7 without porting this entire change back, but with the
new jarsToScan setting in Tomcat 8 we can do this better in trunk.

I have attached a second patch, this one for Tomcat 8 (trunk).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54770] Add jarsToScan properties to counteract jarsToSkip exclusions; support per-web-app properties; port to Tomcat 7

2013-06-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54770

--- Comment #3 from Mark Thomas ma...@apache.org ---
This has been implemented in trunk for Tomcat 8.

The changes are non-trivial to back-port. I don't intend proposing a back-port
of these changes. The log4j issue can be resolved by a less broad exclusion in
jarsToSkip such as log4j-1*.jar (although I note log4j-core.jar shipped with
1.0.x and 1.1.x and is not log4j-2.x specific).

I'll leave this open a little while in case someone wants to look at a back
port. In not, I'll change the version to 8.0.x and resolve it as fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54770] Add jarsToScan properties to counteract jarsToSkip exclusions; support per-web-app properties; port to Tomcat 7

2013-05-18 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54770

Nick Williams nicho...@nicholaswilliams.net changed:

   What|Removed |Added

  Component|Catalina|Catalina
Version|trunk   |7.0.40
Product|Tomcat 8|Tomcat 7
   Target Milestone||---

--- Comment #2 from Nick Williams nicho...@nicholaswilliams.net ---
You can read about the Log4j tag library, available since Log4j 2.0.0-beta5,
here: http://logging.apache.org/log4j/2.x/log4j-taglib/index.html.

As Log4j 2 approaches its general availability, this is going to start becoming
a bigger issue. At the very least, the log4j*.jar exclusion in the stock
catalina.properties needs to be removed from Tomcat 7 and 8. Of course, if
there were a jarsToScan property as this bug suggests, it could contain a stock
*taglib*.jar or log4j-taglib*.jar inclusion that would negate the need to
remove log4j*.jar from the exclusions.

There was a good deal of discussion about this back on February 21-26, and then
it just died. Is there someone willing to pick this up? This is a bigger task
than I have the time or Tomcat knowledge to tackle, I'm afraid.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54770] Add jarsToScan properties to counteract jarsToSkip exclusions; support per-web-app properties; port to Tomcat 7

2013-05-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54770

Nick Williams nicho...@nicholaswilliams.net changed:

   What|Removed |Added

Summary|Add jarsToScan properties   |Add jarsToScan properties
   |to counteract jarsToSkip|to counteract jarsToSkip
   |exclusions; support |exclusions; support
   |per-web-app properties; |per-web-app properties;
   |port to Java 7  |port to Tomcat 7

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org