[Bug 55884] JSPs no longer compile in Java 8

2014-12-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55884

Konstantin Kolinko knst.koli...@gmail.com changed:

   What|Removed |Added

 Status|VERIFIED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55884] JSPs no longer compile in Java 8

2013-12-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55884

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Mark Thomas ma...@apache.org ---
Thanks for the report. I have fixed this in trunk.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55884] JSPs no longer compile in Java 8

2013-12-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55884

Nick Williams nicho...@nicholaswilliams.net changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #7 from Nick Williams nicho...@nicholaswilliams.net ---
I can confirm that this is fixed. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55884] JSPs no longer compile in Java 8

2013-12-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55884

Nick Williams nicho...@nicholaswilliams.net changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Nick Williams nicho...@nicholaswilliams.net ---
Well that was pointless, because apparently there's a tiny size limit on
attachments. Suggestions on how to attach this WAR file?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55884] JSPs no longer compile in Java 8

2013-12-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55884

--- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com ---
(In reply to Nick Williams from comment #1)

1. Simplify.

Your issue is that a single JSP page does not compile. Remove everything that
is not related to the problem. There is no need to bundle all of Spring etc.

2. Are you sure that you have a JAR that contains
org.apache.taglibs.standard.tag.rt.core.UrlTag
on the classpath?

It seems that you are trying to use Oracle JSTL implementation (that abuses
Apache package names).

3. What version of Tomcat 8 are you using?
Several tag-file related bugs were fixed in the last few days (those were noted
during 8.0.0-RC7 voting).

4. What versions of Java 8 and of Apache Ant are you using?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55884] JSPs no longer compile in Java 8

2013-12-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55884

--- Comment #3 from Jeremy Boynes jboy...@apache.org ---
The mixed use of URL encoding on the classpath looks suspicious:
 
/C:/Program%20Files/Apache%20Software%20Foundation/Tomcat%208.0/webapps/messaging1/WEB-INF/lib/javax.servlet.jsp.jstl-1.2.2.jar
vs.
  /C:/Program Files/Apache Software Foundation/Tomcat 8.0/lib/servlet-api.jar

The difference seems to be paths to libraries sourced from the webapp, which
would include the jar containing the classes needed for JSTL.

Can you reproduce this with the stock distribution (the SVG example
http://localhost:8080/examples/jsp/jsp2/jspx/svgexample.html uses JSTL) when it
is installed in a directory with spaces and uses the Ant compiler?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 55884] JSPs no longer compile in Java 8

2013-12-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55884

--- Comment #4 from Nick Williams nicho...@nicholaswilliams.net ---
Created attachment 31117
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=31117action=edit
Application Replicating Problem

Okay. I've attached the simplest possible application that replicates the
problem. Just go to http://localhost:8080/test-jstl/ after deploying it.

To respond to your questions (and in anticipation of future questions):

1) I'm using Tomcat 8.0.0-trunk-1550920 (compiled this morning).
2) http://localhost:8080/examples/jsp/jsp2/jspx/svgexample.html works fine.
3) Yes, I have the necessary JARs in my application (see attached WAR file).
4) Java 8-ea-120 (this week)
5) Ant 1.9.0 compiled on March 5 2013
6) The app only fails to compile the JSP in Tomcat 8 using the Ant+Java 8
compiler configuration.
7) The app works fine in Tomcat 8.0.0-trunk-1550920 using the built-in Eclipse
compiler.
8) The app works fine in Tomcat 7.0.47 using the built-in Eclipse compiler.
9) The app works fine in Tomcat 7.0.47 using the same Ant+Java 8 compiler
configuration.

Here's the error for the new test-jstl.war app:

14-Dec-2013 20:16:10.819 SEVERE [http-nio-8080-exec-2]
org.apache.jasper.compiler.AntCompiler.generateClass Javac exception
 Compile failed; see the compiler error output for details.
at org.apache.tools.ant.taskdefs.Javac.compile(Javac.java:1174)
at org.apache.tools.ant.taskdefs.Javac.execute(Javac.java:930)
at
org.apache.jasper.compiler.AntCompiler.generateClass(AntCompiler.java:234)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:380)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:355)
at org.apache.jasper.compiler.Compiler.compile(Compiler.java:342)
at
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:564)
at
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:357)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:403)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:347)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:107)
at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:504)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:155)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:76)
at
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:934)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:90)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:522)
at
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1015)
at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:646)
at
org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1597)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1555)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:744)

14-Dec-2013 20:16:10.834 SEVERE [http-nio-8080-exec-2]
org.apache.jasper.compiler.AntCompiler.generateClass Environment:Compile:
javaFileName=C:\Program Files\Apache Software Foundation\Tomcat
8.0\work\Catalina\localhost\test-jstl\org\apache\jsp\index_jsp.java
   
classpath=/C:/Program%20Files/Apache%20Software%20Foundation/Tomcat%208.0/webapps/test-jstl/WEB-INF/lib/javax.servlet.jsp.jstl-1.2.2.jar;/C:/Program%20Files/Apache%20Software%20Foundation/Tomcat%208.0/webapps/test-jstl/WEB-INF/lib/javax.servlet.jsp.jstl-api-1.2.1.jar;C:\Program
Files\Apache Software Foundation\Tomcat
8.0\work\Catalina\localhost\test-jstl;/C:/Program Files/Apache Software
Foundation/Tomcat 8.0/lib/;/C:/Program Files/Apache Software Foundation/Tomcat
8.0/lib/annotations-api.jar;/C:/Program Files/Apache Software Foundation/Tomcat
8.0/lib/catalina-ant.jar;/C:/Program Files/Apache Software Foundation/Tomcat
8.0/lib/catalina-ha.jar;/C:/Program 

[Bug 55884] JSPs no longer compile in Java 8

2013-12-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55884

--- Comment #5 from Jeremy Boynes jboy...@apache.org ---
I can reproduce this on OSX using Java 1.7 and the stock distribution.

If I copy output/build to /tmp/good-path and make the config changes
described (setenv.sh and JspServlet) then the SVG demo and Nick's app work. If
I then move the install to /tmp/bad path then I get the same compilation
error occurs with both.

I assume it's in the resource handling which is replacing the   with %20 in
the classpath entry.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org