[Bug 57097] Add name attribute to standard connectors

2014-10-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57097

--- Comment #3 from Christopher Schultz ch...@christopherschultz.net ---
I think there is a legitimate use case here.

The name shouldn't override the existing JMX name... just add another
property that can be used to locate the connector, even if you have to grab the
whole set of connectors and loop through them looking for it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 57097] Add name attribute to standard connectors

2014-10-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57097

--- Comment #4 from Mark Thomas ma...@apache.org ---
(In reply to Christopher Schultz from comment #3)
 I think there is a legitimate use case here.

I disagree. The connectors already have a unique name and I have no desire to
add unecessary code to provide another attribute that does exactly the same
thing.

 The name shouldn't override the existing JMX name... just add another
 property that can be used to locate the connector, even if you have to grab
 the whole set of connectors and loop through them looking for it.

The only difference between the approaches whether Tomcat provides the option
for a unique name to be added to a connector as defined by some external (to
Tomcat) system or if Tomcat requires the external system to use Tomcat's unique
name.

I'm fine with the latter approach. The connectors need less code,not more.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 57097] Add name attribute to standard connectors

2014-10-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57097

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #1 from Mark Thomas ma...@apache.org ---
Connectors are uniquely identified by the combination of address and port. This
information is already included in the JMX name. An additional name property
would be redundant.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 57097] Add name attribute to standard connectors

2014-10-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=57097

--- Comment #2 from Jens Borgland jens.borgl...@gmail.com ---
Well, yes that uniquely identifies the connector but since both those
attributes may be set at will by the administrator when deploying the
application they cannot be used to identify which connector is which (for my
purposes) - I have no way of knowing which address or port that is supposed to
be the backend or frontend.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org