[Bug 57154] Failure of TestWsWebSocketContainer when directory %TEMP%\test exists

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=57154

--- Comment #10 from Konstantin Kolinko  ---
Implemented in Tomcat 6 by r1725061 and will be in 6.0.45 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57154] Failure of TestWsWebSocketContainer when directory %TEMP%\test exists

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=57154

--- Comment #9 from Konstantin Kolinko  ---
(In reply to Mark Thomas from comment #8)
> Thanks for the patch. It has been applied (with a few minor tweaks to
> silence some Eclipse warnings) to 7.0.x and will be included in 7.0.63
> onwards.

For a reference, implementation of this feature in Tomcat 7 is
r1681953 + r1724913

Comments working on backport to Tomcat 6
==

1). Currently null is an unsupported value for StandardContext.docBase.

Using the null value is going to fail with a NullPointerException thrown
from a "new File(null)" call.

So implementing support for a null docBase is a new feature
and does not break any existing one.


2). There is a slight difference with Tomcat 7 that ApplicationContext and
ReplicatedContext$ReplApplContext constructors accept additional argument
basePath.

public ServletContext getServletContext() {
if (context == null) {
context = new ApplicationContext(getBasePath(), this);

This resulted in a stacktrace like this:

  java.lang.NullPointerException
 at java.io.File.(File.java:194)
 at
org.apache.catalina.core.StandardContext.getBasePath(StandardContext.java:5179)
 at
org.apache.catalina.core.StandardContext.getServletContext(StandardContext.java:1932)
 at
org.apache.catalina.core.StandardContext.postWorkDirectory(StandardContext.java:5448)
 at
org.apache.catalina.core.StandardContext.start(StandardContext.java:4563)

The basePath value is used to implement methods
ApplicationContext.getRealPath(String)
and getResource(String).

(For historic reference: commits that removed basePath field from
ApplicationContext
in Tomcat 7 are r784083 + r834220)

In both methods the use of basePath is conditioned on "if
(context.isFilesystemBased())"
condition. So if StandardContext is not based on a filesystem, the value of
basePath in ApplicationContext does not matter.

Thus I am going to change StandardContext.getBasePath() to return null for a
null docBase,
instead of failing with a NullPointerException.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57154] Failure of TestWsWebSocketContainer when directory %TEMP%\test exists

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=57154

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #8 from Mark Thomas ma...@apache.org ---
Thanks for the patch. It has been applied (with a few minor tweaks to silence
some Eclipse warnings) to 7.0.x and will be included in 7.0.63 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57154] Failure of TestWsWebSocketContainer when directory %TEMP%\test exists

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=57154

--- Comment #7 from Huxing Zhang huxing.zh...@gmail.com ---
Hi @Konstantin and @Mark, 

Is there any update on this?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57154] Failure of TestWsWebSocketContainer when directory %TEMP%\test exists

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=57154

Huxing Zhang huxing.zh...@gmail.com changed:

   What|Removed |Added

 CC||huxing.zh...@gmail.com

--- Comment #6 from Huxing Zhang huxing.zh...@gmail.com ---
Created attachment 32749
  -- https://bz.apache.org/bugzilla/attachment.cgi?id=32749action=edit
backport the feature from bug 57155 to Tomcat 7.0.x

Hi @Konstantin and @Mark, 

I have backported the feature from bug 57155 to Tomcat 7.0.x.
Would you please kindly review the attached fix?
The main idea is borrowed from Mark's implementation in Tomcat 8.0.x.

The changes in the patch mainly includes:
1) an EmptyDirContext implementation which is not backed by a file system.
2) an enhancement in StandardContext that allows an application to be
configured to have no docBase, precisely speaking, to have docBase to be null.
3) changes in test cases that replacing unnecessary file system doc base with
null doc base.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57154] Failure of TestWsWebSocketContainer when directory %TEMP%\test exists

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57154

Konstantin Kolinko knst.koli...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
  Component|WebSocket   |WebSocket
 Resolution|FIXED   |---
Product|Tomcat 8|Tomcat 7
   Target Milestone||---
   Severity|normal  |minor

--- Comment #5 from Konstantin Kolinko knst.koli...@gmail.com ---
This test failure is reproducible with current Tomcat 7.0.x testsuite.
Note that it does not happen by default, but only if one creates a %TEMP%\test
directory.

Possible solutions:
a) Backport the feature from bug 57155 (for reference: r1635222).
b) Reconfigure the tests to use some different temporary directory as docBase
instead of the system-wide one.
c) Improve Mapper.
d) Close as WONTFIX.

a) is the best one, but requires some work as resource implementations differ
between Tomcat 8 and 7.

b) is an alternative way if a) is too hard.

c) unlikely without further analysis.

d) possible. A test configuration issue is not a show stopper.

I am reopening this for Tomcat 7 now, so that it is not forgotten.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57154] Failure of TestWsWebSocketContainer when directory %TEMP%\test exists

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57154

--- Comment #3 from Mark Thomas ma...@apache.org ---
The root cause of this is indeed the redirect from the Mapper.

The redirect is a result of one of the requirements for welcome file
processing. The Servlet spec is clear Tomcat can implement these any way it
likes so the current Tomcat behaviour is valid.

It looks like the best solution for this bug is a fix for bug 57155.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57154] Failure of TestWsWebSocketContainer when directory %TEMP%\test exists

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57154

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Mark Thomas ma...@apache.org ---
Fixed with the fixes for bug 57155.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57154] Failure of TestWsWebSocketContainer when directory %TEMP%\test exists

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57154

Konstantin Kolinko knst.koli...@gmail.com changed:

   What|Removed |Added

Summary|Failure of  |Failure of
   |TestWsWebSocketContainer|TestWsWebSocketContainer
   |when there is directory |when directory %TEMP%\test
   |%TEMP%\test |exists
 OS||All

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57154] Failure of TestWsWebSocketContainer when directory %TEMP%\test exists

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57154

--- Comment #1 from Konstantin Kolinko knst.koli...@gmail.com ---
Created attachment 32152
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=32152action=edit
TEST-org.apache.tomcat.websocket.TestWsWebSocketContainer.NIO.txt

Log file from testing Tomcat 8 trunk (@r1634690)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57154] Failure of TestWsWebSocketContainer when directory %TEMP%\test exists

[bugzilla]

https://issues.apache.org/bugzilla/show_bug.cgi?id=57154

--- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com ---
Created attachment 32153
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=32153action=edit
TEST-org.apache.tomcat.websocket.TestWsWebSocketContainer.NIO2.txt

Log file from testing Tomcat 8 trunk (@r1634690)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org