[Bug 57425] ReplicatedContext implementation throws NullPointerException for attributes with null value
https://issues.apache.org/bugzilla/show_bug.cgi?id=57425 Felix Schumacher felix.schumac...@internetallee.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Felix Schumacher felix.schumac...@internetallee.de --- Included in trunk (r1651120, r1651280). Will be included in 8.0.18 (r1651421, r1651422) and tomcat 7.0.58 (r1651439, r1651446). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57425] ReplicatedContext implementation throws NullPointerException for attributes with null value
https://issues.apache.org/bugzilla/show_bug.cgi?id=57425 --- Comment #6 from Josh Landin jlan...@gmail.com --- Looks good. Thanks for the quick attention on this. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57425] ReplicatedContext implementation throws NullPointerException for attributes with null value
https://issues.apache.org/bugzilla/show_bug.cgi?id=57425 Felix Schumacher felix.schumac...@internetallee.de changed: What|Removed |Added Attachment #32358|0 |1 is obsolete|| --- Comment #4 from Felix Schumacher felix.schumac...@internetallee.de --- Created attachment 32363 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32363action=edit Don't add context attribute if it is null Don't add a context attribute if its value or name is null. For the test case the bugfix 57431 will have to be applied. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57425] ReplicatedContext implementation throws NullPointerException for attributes with null value
https://issues.apache.org/bugzilla/show_bug.cgi?id=57425 --- Comment #2 from Felix Schumacher felix.schumac...@internetallee.de --- Created attachment 32358 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32358action=edit Don't add orderedLibs attribute if it is null The attached patch is for tomcat 8. But the same logic would apply to tomcat 7. The file in tomcat 7 is named java/org/apache/catalina/deploy/WebXml.java. It applies cleanly for trunk. The idea is to not store the attribute, if it is null, since getAttribute will give a null value, if the attribute is not present and the replicated context fails, if the concurrent hashmap gets a null as a value or a key. If noone objects, I will apply the patch. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57425] ReplicatedContext implementation throws NullPointerException for attributes with null value
https://issues.apache.org/bugzilla/show_bug.cgi?id=57425 --- Comment #3 from Mark Thomas ma...@apache.org --- I'd suggest that this is fixing the symptom rather than the root cause. I think it would be better to replicate the correct handling of setAttribute(String,null) (which is to remove the attribute) in ReplicatedContext.ReplApplContext -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57425] ReplicatedContext implementation throws NullPointerException for attributes with null value
https://issues.apache.org/bugzilla/show_bug.cgi?id=57425 Josh Landin jlan...@gmail.com changed: What|Removed |Added OS||All --- Comment #1 from Josh Landin jlan...@gmail.com --- This work item is to make ReplicatedContext behave the way StandardContext does for null values. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
