[Bug 59564] HttpServletRequest.getPart() always returns null with HTTP/2

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59564

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #5 from Mark Thomas  ---
Reproducible with:
- Clean 9.0.x build
- NIO + OpenSSL + HTTP/2
- ~40MB WAR (Spring Pet Clinic)

Violeta's patch fixes this so I have applied it to 9.0.x for 9.0.0.M7 onwards
and 8.5.x for 8.5.3 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59564] HttpServletRequest.getPart() always returns null with HTTP/2

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59564

Violeta Georgieva  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #4 from Violeta Georgieva  ---
Hi,

I was able to reproduce this issue.

I think that we should invoke 'data.arrayOffset() + data.position()' when we
fill the data:


Index: Http2Parser.java
===
--- Http2Parser.java(revision 1745545)
+++ Http2Parser.java(working copy)
@@ -561,7 +561,7 @@
 }

 default boolean fill(boolean block, ByteBuffer data, int len) throws
IOException {
-boolean result = fill(block, data.array(), data.arrayOffset(),
len);
+boolean result = fill(block, data.array(), data.arrayOffset() +
data.position(), len);
 if (result) {
 data.position(data.position() + len);
 }

What do you think?

Regards,
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59564] HttpServletRequest.getPart() always returns null with HTTP/2

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59564

--- Comment #3 from Remy Maucherat  ---
No idea at this point. I guess it will be explained eventually.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59564] HttpServletRequest.getPart() always returns null with HTTP/2

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59564

--- Comment #2 from Thad Humphries  ---
Rats. I was afraid that's what I'd be told. Is something wrong with my
connector? The cert is self-signed. Does that matter?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59564] HttpServletRequest.getPart() always returns null with HTTP/2

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59564

Remy Maucherat  changed:

   What|Removed |Added

 OS||All
 Status|NEW |NEEDINFO

--- Comment #1 from Remy Maucherat  ---
This works for me (can't sat anything else really).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org