[Bug 61316] Test files used by TestEncodingDetector test are broken in src.zip, src.tar.gz [8.5.18]

2017-07-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61316

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Mark Thomas  ---
Fixed in:
- trunk for 9.0.0.M25 onwards
- 8.5.x for 8.5.19 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 61316] Test files used by TestEncodingDetector test are broken in src.zip, src.tar.gz [8.5.18]

2017-07-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61316

--- Comment #2 from Konstantin Kolinko  ---
svn is configured correctly:
If I run the tests from svn checkout, it completes successfully on my Windows,
and it completes successfully at Buildbot (on Linux).

>From svn pont of view the files with 16-bit characters should be treated as
binary. The should not have svn:eol-style property on them.


The problem is with configuration of  task in build.xml.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 61316] Test files used by TestEncodingDetector test are broken in src.zip, src.tar.gz [8.5.18]

2017-07-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61316

Christopher Schultz  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Christopher Schultz  ---
Could this be a svn client problem?

$ svn pget svn:mime-type test/webapp/jsp/encoding/bom-none-prolog-none.jspx
text/plain; charset=UTF-8
$ svn pget svn:eol-style test/webapp/jsp/encoding/bom-none-prolog-none.jspx
native

$ svn pget svn:mime-type
test/webapp/jsp/encoding/bom-utf16be-prolog-utf16le.jspx
text/plain; charset=UTF-16BE
$ svn pget svn:eol-style
test/webapp/jsp/encoding/bom-utf16be-prolog-utf16le.jspx
svn: warning: W200017: Property 'svn:eol-style' not found on
'test/webapp/jsp/encoding/bom-utf16be-prolog-utf16le.jspx'
svn: E20: A problem occurred; see other errors for details

Should the eol-style be set for any of these files? Should the mime-type be
application/binary, or do we trust svn clients not to botch the encoding?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org