[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2020-03-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

--- Comment #11 from Michael Osipov  ---
(In reply to Remy Maucherat from comment #9)
> AccessLogValve was not doing anything related. The argument that used
> milliseconds was in AbstractALV, now it uses nanoseconds.

Rémy, I have updated documentation to reflect your changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2020-02-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

Michael Osipov  changed:

   What|Removed |Added

 CC||micha...@apache.org

--- Comment #10 from Michael Osipov  ---
Let me recheck this. I hope docs have been updated too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2020-02-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

--- Comment #9 from Remy Maucherat  ---
AccessLogValve was not doing anything related. The argument that used
milliseconds was in AbstractALV, now it uses nanoseconds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2020-02-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

--- Comment #8 from Michael Osipov  ---
(In reply to Remy Maucherat from comment #7)
> This should be fixed in 10.0.0-M2.

I fail to find this commit in
https://github.com/apache/tomcat/commits/master/java/org/apache/catalina/valves/AccessLogValve.java
and
https://github.com/apache/tomcat/commits/master/java/org/apache/catalina/valves/AbstractAccessLogValve.java.
Where is it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2020-02-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

Remy Maucherat  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Remy Maucherat  ---
This should be fixed in 10.0.0-M2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2019-04-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

--- Comment #6 from Rainer Jung  ---
There's another difference between httpd and Tomcat access logs that people
often stumble upon: By default the request timestamp for httpd is the time of
the beginning of the request, for Tomcat it is the end of the requst (or more
precisely the moment of peparing the access log line).

Since httpd 2.4 and TC 7 (?) one can choose between begin and end with a
documented pattern, but the defaults still differ.

The delta makes it harder to align the logs in case of long running requests.

One consequence is, that the timestamp in Tomcat access logs always increase
monotonically, but not so in httpd access log. Later but faster requests might
get logged before earlier but slower requests.

Should we document this as well?

Regards,

Rainer

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2019-04-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

Mark Thomas  changed:

   What|Removed |Added

   Severity|major   |enhancement

--- Comment #5 from Mark Thomas  ---
The documentation has been fixed in:
- master for 9.0.18 onwards
- 8.5.x for 8.5.40 onwards
- 7.0.x for 7.0.94 onwards

Moving this to enhancement request to add support for %{UNIT}T

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2019-03-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

--- Comment #4 from Michael Osipov  ---
That's fine by me. Though, %{UNIT}T can be introduced in 8.5 and 9, can't it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2019-03-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

--- Comment #3 from Mark Thomas  ---
We can't change the behaviour in the middle of the 9.0.x series. The risk of
braking things for users is too great. I've added it to the TODO list for
10.0.x.

Meanwhile, we can clearly document the current behaviour and note the
differences with httpd. Working on that now...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2019-03-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

--- Comment #2 from Michael Osipov  ---
(In reply to Mark Thomas from comment #1)
> Also see bug 56966. I don't recall why that stalled. It may have been
> related to the API changes required. Probably time to take another look.

It looks related, but the issue you mention is about resolution, this one's
different. Three years have passed since the ticket has been touched.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2019-03-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

--- Comment #1 from Mark Thomas  ---
Also see bug 56966. I don't recall why that stalled. It may have been related
to the API changes required. Probably time to take another look.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org