[Bug 63943] Add possibility to overwrite remote port with information from header value

2020-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63943

--- Comment #8 from Mark Thomas  ---
A little research suggests that this is usually included in the X-Forwarded-For
header rather than as a separate header. RFC 7239 uses that format as does
Azure. I haven't found any references to a dedicated header.

Any reason to to address this by adding support for port as well as address in
X-Forwarded-For ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63943] Add possibility to overwrite remote port with information from header value

2020-04-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63943

--- Comment #7 from Mark Thomas  ---
Because users want to write applications that "just work" irrespective of
whether there is a reverse proxy in front of Tomcat and/or how that reverse
proxy is configured.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63943] Add possibility to overwrite remote port with information from header value

2020-04-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63943

--- Comment #6 from Nicolò Boschi  ---
Why can't you just read the header value?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63943] Add possibility to overwrite remote port with information from header value

2019-11-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63943

--- Comment #5 from Mark Thomas  ---
(In reply to George Stanchev from comment #4)
> According to [1] it is "x-forwarded-port"

No, that is the port on the proxy that the client connected to (already
supported). The enhancement request is for the port that the client connected
from.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63943] Add possibility to overwrite remote port with information from header value

2019-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63943

--- Comment #4 from George Stanchev  ---
According to [1] it is "x-forwarded-port"

https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/x-forwarded-headers.html#x-forwarded-port

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63943] Add possibility to overwrite remote port with information from header value

2019-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63943

Mark Thomas  changed:

   What|Removed |Added

 Resolution|INVALID |---
 Status|RESOLVED|REOPENED

--- Comment #3 from Mark Thomas  ---
Sorry, now I understand. You want to be able to set the value returned from
ServletRequest.getRemotePort() based on a header.

Is there a standard, OK typical, name for this header (we can make it
configurable anyway).

Note there is also bug 63080.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63943] Add possibility to overwrite remote port with information from header value

2019-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63943

--- Comment #2 from Peter Gierl  ---
It's not implemented in RemoteIpValve, only the server port information may be
transported, not the remote port. So where is it present?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63943] Add possibility to overwrite remote port with information from header value

2019-11-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63943

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Mark Thomas  ---
This feature has been present since May 2011.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org