[Bug 64506] NullPointerException when loading webapp class

2020-06-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64506

--- Comment #6 from Arvind Talari  ---
Mark,
Tested the fix with a simulated race condition, and it worked. Thanks again for
the quick turn around.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64506] NullPointerException when loading webapp class

2020-06-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64506

--- Comment #5 from Arvind Talari  ---
Hmmm.. actually may be it is not required, since
org.apache.catalina.webresources.CachedResource#validateResources isn't
conditionally validating.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64506] NullPointerException when loading webapp class

2020-06-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64506

--- Comment #4 from Arvind Talari  ---
Thank you Mark for the quick turn around.
Yes, we are able to build from source, being a race condition it isn't
reproducible at will, we will need to manually simulate the race condition.

Although, we haven't run into this issue, I am also wondering if a similar fix
needs to be made in org.apache.catalina.webresources.Cache#getResources.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64506] NullPointerException when loading webapp class

2020-06-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64506

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64506] NullPointerException when loading webapp class

2020-06-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64506

--- Comment #3 from Mark Thomas  ---
Fixed in:
- master for 10.0.0-M7 onwards
- 9.0.x for 9.0.37 onwards
- 8.5.x for 8.5.57 onwards

7.0.x is not affected.

It would be great if you were able to test this. Our you able to build Tomcat
from source? If not, I can provide a snapshot build for you to test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64506] NullPointerException when loading webapp class

2020-06-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64506

--- Comment #2 from Arvind Talari  ---
Mark,
Thank you for your prompt reply.

The resource we found that was being looked up concurrently is
"/WEB-INF/classes/".

Thread 1 could be doing something like this
Thread#getContextClassLoader()#getResource("") for a class loader resource.

And Thread 2 could be doing
org.apache.catalina.WebResourceRoot#getResource("/WEB-INF/classes/") (from
org.apache.catalina.webresources.FileResource#getCodeBase) for a non-class
loader resource.  This corresponds to the NPE stack trace shown in the
description

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64506] NullPointerException when loading webapp class

2020-06-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64506

--- Comment #1 from Mark Thomas  ---
Thanks for the report and the careful analysis. I think the analysis has
identified the root cause. I'l look into a fix.

Out of curiosity, what resources are being looked up as class loader resources
and non-class loader resources in parallel?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org