Re: [Fwd: Re: TC patches as discussed]

2008-11-10 Thread Rainer Jung

Mark Thomas wrote:

http://people.apache.org/~markt/patches/2008-10-31-tc4-wininstaller.patch


Can you explain a bit the motivation for all the path changes (including 
the sub directory in the target path and adding *.* to the source)?


I might then well be able to vote for the second one too.

Regards,

Rainer

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [Fwd: Re: TC patches as discussed]

2008-11-10 Thread Mark Thomas
Rainer Jung wrote:
 Mark Thomas wrote:
 http://people.apache.org/~markt/patches/2008-10-31-tc4-wininstaller.patch

 
 Can you explain a bit the motivation for all the path changes (including
 the sub directory in the target path and adding *.* to the source)?

File -r common matches common/*.* and */common/*.*

File -r common/*.* matches only common/*.*

Because we use common/*.* as a pattern you have to set the directory first
to make sure stuff gets expanded to the right place.

The problem with the current pattern is we include stuff we shouldn't form
other random directories that happen to include the root directory name in
their path.

Mark



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[Fwd: Re: TC patches as discussed]

2008-11-08 Thread Mark Thomas
For the record. I pestered Jean-Frederic to review these at ApacheCon.

Mark

 Original Message 
Subject: Re: TC patches as discussed
Date: Sat, 08 Nov 2008 00:35:07 +0100
From: jean-frederic clere [EMAIL PROTECTED]
To: Mark Thomas [EMAIL PROTECTED]
References: [EMAIL PROTECTED]

Mark Thomas wrote:
 http://people.apache.org/~markt/patches/2008-10-30-bug44494-regression.patch

+1

 http://people.apache.org/~markt/patches/2008-10-31-tc4-wininstaller.patch

+1

 
 Mark
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]