[GitHub] [tomcat] Pingvin235 commented on pull request #434: Optionally inherit request parameters

2021-07-14 Thread GitBox


Pingvin235 commented on pull request #434:
URL: https://github.com/apache/tomcat/pull/434#issuecomment-880204596


   Thanks for pointing. Assuming this is the conflicting part:
   
   "Parameters specified in the query string used to create the 
RequestDispatcher take precedence over other parameters of the same name passed 
to the included servlet."
   
   Perhaps I understand it wrong, but if other parameters are completely 
excluded, do query string parameters loose their precedence? Actually that we 
need is to have the query string parameters only. May be you can recommend 
another way to archive such behavior?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] Pingvin235 commented on pull request #434: Optionally inherit request parameters

2021-07-14 Thread GitBox


Pingvin235 commented on pull request #434:
URL: https://github.com/apache/tomcat/pull/434#issuecomment-880042757


   > Regarding the implementation, I am -1 on the proposed implementation as it 
is based on an environment variable. If it were implemented, It would need to 
be a per context configuration attribute.
   
   Can do it this way of course case this option is in principle allowed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] Pingvin235 commented on pull request #434: Optionally inherit request parameters

2021-07-14 Thread GitBox


Pingvin235 commented on pull request #434:
URL: https://github.com/apache/tomcat/pull/434#issuecomment-880041227


   Could you please point me the place in the specification, describing that 
behavior? For 4.0 could found only section 9.3 regarding includes, but didn't 
notice anything about parameters inheritance / precedence..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org