[GitHub] [tomcat] anuragdy commented on a diff in pull request #666: Performance improvements for ImplicitObjectELResolver

2023-09-08 Thread via GitHub 


anuragdy commented on code in PR #666:
URL: https://github.com/apache/tomcat/pull/666#discussion_r1319841883


##
java/javax/servlet/jsp/el/ImplicitObjectELResolver.java:
##
@@ -44,31 +44,32 @@
  * @since JSP 2.1
  */
 public class ImplicitObjectELResolver extends ELResolver {
+private enum Scope {
+APPLICATION_SCOPE, COOKIE, HEADER, HEADER_VALUES, INIT_PARAM, 
PAGE_CONTEXT, PAGE_SCOPE, PARAM, PARAM_VALUES,
+REQUEST_SCOPE, SESSION_SCOPE;

Review Comment:
   I think consistency is of greater value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] anuragdy commented on a diff in pull request #666: Performance improvements for ImplicitObjectELResolver

2023-09-07 Thread via GitHub 


anuragdy commented on code in PR #666:
URL: https://github.com/apache/tomcat/pull/666#discussion_r1319322612


##
java/javax/servlet/jsp/el/ImplicitObjectELResolver.java:
##
@@ -44,31 +44,32 @@
  * @since JSP 2.1
  */
 public class ImplicitObjectELResolver extends ELResolver {
+private enum Scope {
+APPLICATION_SCOPE, COOKIE, HEADER, HEADER_VALUES, INIT_PARAM, 
PAGE_CONTEXT, PAGE_SCOPE, PARAM, PARAM_VALUES,
+REQUEST_SCOPE, SESSION_SCOPE;

Review Comment:
   They are consistent with the property values, but certainly redundant.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org