[GitHub] [tomcat] kamnani commented on pull request #354: Optimize Server startup time using multi-threading for annotation scanning
kamnani commented on pull request #354: URL: https://github.com/apache/tomcat/pull/354#issuecomment-694934337 Thank you @rmaucher @martin-g to get this moving fast 👍 . Will this be backported to version 9 ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] kamnani commented on pull request #354: Optimize Server startup time using multi-threading for annotation scanning
kamnani commented on pull request #354: URL: https://github.com/apache/tomcat/pull/354#issuecomment-689023592 @rmaucher I actually tested the optimization with the flag in a large application having 1000's of Jar in the classpath and the server startup gains are significant and the stats are as follows : 2816 classes - 44% improvement 1800 classes - 40% improvement 1000 classes - 40% improvement The default tomcat app shows an improvement of 6% with the flag. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] kamnani commented on pull request #354: Optimize Server startup time using multi-threading for annotation scanning
kamnani commented on pull request #354: URL: https://github.com/apache/tomcat/pull/354#issuecomment-688967898 > I still don't really like some items, like the explicit flag (but I don't see yet how to do it) or some of the "optimizations". > By default the utility thread count is 2, so not too much parallelism. Yes, You're right with the default Value, but that can be changed through the Host Configuration.. right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] kamnani commented on pull request #354: Optimize Server startup time using multi-threading for annotation scanning
kamnani commented on pull request #354: URL: https://github.com/apache/tomcat/pull/354#issuecomment-687380392 Thanks @rmaucher for your comment. I have made the necessary changes as suggested. It would be great if you could verify that change. I have also updated the PR description since the flags have now been changed with this change. Is there any other change needed on this PR you want to suggest ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
