markt-asf commented on issue #281: URL: https://github.com/apache/tomcat/pull/281#issuecomment-618447383
The question is "At what cost?" I have two concerns. 1. Regressions. The changes should be obvious and easy to check but there are plenty of examples in the history of Tomcat of seemingly simple clean-up triggering unintended regressions. That isn't a reason not to do it but there needs to be a clear benefit - such as reduced lines of code - of making the change. 2. Performance. I have in the past seen very significant performance drops changing from a simple array to an object (byte[] to ByteBuffer is the case I am thinking of). We need to be very careful of changes that are on the critical path (get executed for all/most requests). In those cases I would want to see repeatable performance numbers that demonstrated the performance cost/benefit of making the change including the impact on garbage generation. `ApplicationFilterChain` falls into this category. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
