[GitHub] [tomcat] markt-asf commented on pull request #434: Optionally inherit request parameters
markt-asf commented on pull request #434: URL: https://github.com/apache/tomcat/pull/434#issuecomment-979437308 This is not going to be applied. The users mailing list is the place to discuss your requirement and possible solutions. As a starting point, how about ensuring the target servlets take only the first value for any parameter. Then you can rely on the precedence rules in the specification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #434: Optionally inherit request parameters
markt-asf commented on pull request #434: URL: https://github.com/apache/tomcat/pull/434#issuecomment-880066207 You want the last paragraph of section 9.1.1. A RequestDispatcher is what performs the include or forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #434: Optionally inherit request parameters
markt-asf commented on pull request #434: URL: https://github.com/apache/tomcat/pull/434#issuecomment-879789821 Such an option would be in direct violation of the Servlet specification. That makes me very hesitant to agree to such a change. The Servlet specification already states that the parameters from the include take precedence. I'd rather add clarification of any ambiguities (if necessary) to the spec and align Tomcat's behaviour with that than add an option for non-compliant behaviour. Regarding the implementation, I am -1 on the proposed implementation as it is based on an environment variable. If it were implemented, It would need to be a per context configuration attribute. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
