[GitHub] [tomcat] markt-asf commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement
markt-asf commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570534844 > @markt-asf that looks better that what was there ;-) Thanks. Can you recall if there was a use case for this Valve on a single node? Or was it always intended for use behind a non-sticky load-balancer and, therefore, it was up to the client to enforce the "no more than one concurrent request per session" rule? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement
markt-asf commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570461148 I haven't deprecated this yet. I'm waiting on input from the OP of BZ 66513 and/or @jfclere as the original author of the Valve in case there is a use case I have missed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #623: BZ 66513: Enforce one concurrent request per session requirement
markt-asf commented on PR #623: URL: https://github.com/apache/tomcat/pull/623#issuecomment-1568591682 Map eviction is handled in the finally block. That we can only make this work on a single node is why Rémy is proposing that we remove/deprecate this Valve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org